Skip to content

Changes

#317 (Sep 25, 2024, 3:36:05 AM)

  1. reduce compiler warnings (#1180) — noreply / githubweb
  2. reduce compiler warnings (#1180) — noreply / githubweb

#316 (Sep 21, 2024, 3:36:06 AM)

  1. refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179) — noreply / githubweb
  2. refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179) — noreply / githubweb

#315 (Sep 20, 2024, 3:36:10 AM)

  1. Removing duplicate definition of edsclr when CLUBB_CAM is defined. — Gunther Huebler / githubweb
  2. Ri zm calc6 (#1177) — noreply / githubweb

#314 (Sep 18, 2024, 3:36:07 AM)

  1. change loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173) — noreply / githubweb
  2. Ri zm calc5 (#1175) — noreply / githubweb

#313 (Sep 12, 2024, 3:36:09 AM)

  1. Change variables from a1 and a3 to a1_coef and a3_coef — Vince Larson / githubweb

#312 (Sep 6, 2024, 3:36:06 AM)

  1. Well, this will probably anger the Grim Reaper, but I have finally — bmg2 / githubweb

#311 (Sep 3, 2024, 3:36:09 AM)

  1. Ri zm calc4 (#1168) — noreply / githubweb

#310 (Sep 2, 2024, 3:36:10 AM)

  1. An update of CLUBB Diagnostic — noreply / githubweb

#309 (Aug 30, 2024, 3:36:08 AM)

  1. Ri_zm calc (Part 4) - Implementing calc_Ri_zm (#1160) — noreply / githubweb

#308 (Aug 27, 2024, 3:36:10 AM)

  1. Variable name correction in acc data statement. — Gunther Huebler / githubweb
  2. Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine. — Gunther Huebler / githubweb
  3. Making radf size correct in api and clubb_driver. — Gunther Huebler / githubweb

#307 (Aug 23, 2024, 3:36:07 AM)

  1. Clubb ghost exorcism (#1159) — noreply / githubweb
  2. Clubb ghost exorcism (#1159) — noreply / githubweb

#306 (Aug 17, 2024, 3:36:08 AM)

  1. Nightly clubb plots (#1167) — noreply / githubweb

#305 (Aug 9, 2024, 3:36:09 AM)

  1. Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161) — noreply / githubweb
  2. Moving PosInf to clubb_model_settings.F90 — Gunther Huebler / githubweb

#304 (Aug 2, 2024, 3:36:08 AM)

  1. Fixing .gitmodules so submodules are cloned via https instead of ssh. See comment https://github.com/larson-group/sys_admin/issues/629\#issuecomment-561306186 and commit 4efea21 for slightly more info. — Gunther Huebler / githubweb

#303 (Aug 1, 2024, 3:36:09 AM)

  1. Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175 — Gunther Huebler / githubweb
  2. Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats. — Gunther Huebler / githubweb
  3. Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test. — Gunther Huebler / githubweb

#302 (Jul 20, 2024, 3:36:08 AM)

  1. Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp. — bmg2 / githubweb
  2. Fixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175 — Gunther Huebler / githubweb

#301 (Jul 19, 2024, 3:36:09 AM)

  1. In my previous commit, I changed the domain of the maxloc commands — bmg2 / githubweb
  2. This commit brings the stats output from the all cases run with — bmg2 / githubweb
  3. Committing a change that will initialize this set of variables — bmg2 / githubweb

#300 (Jul 18, 2024, 3:36:09 AM)

  1. There were furhter issues found with the k_lh_start code. — bmg2 / githubweb
  2. Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157) — noreply / githubweb

#299 (Jul 17, 2024, 3:36:09 AM)

  1. I am committing changes to stats output for cloud_cover, rcm_in_layer, — bmg2 / githubweb

#298 (Jul 15, 2024, 3:36:09 AM)

  1. I am updating the SILHS code that calculates k_lh_start to work — bmg2 / githubweb
  2. Update CESM_CLUBB_diag_tauspaper.py, a specific "ITCZ" is added that lets WP back to its original meaning "warm pool". — noreply / githubweb
  3. ESM_CLUBB_diag was changed along with CESM_CLUBB_diag, otherwise it always confused us. — noreply / githubweb

#297 (Jul 12, 2024, 3:36:09 AM)

  1. This code in adj_low_res_nu was using the ghost point when — bmg2 / githubweb

#296 (Jul 3, 2024, 3:36:09 AM)

  1. Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156) — noreply / githubweb

#295 (Jun 21, 2024, 3:36:10 AM)

  1. Adds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3e — noreply / githubweb

#294 (Jun 20, 2024, 3:36:06 AM)

  1. Ri zm calc (Part 1) - Combine and move call to  calc_brunt_vaisala_freq_sqd (#1154) — noreply / githubweb
  2. Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155) — noreply / githubweb

#293 (Jun 15, 2024, 3:36:07 AM)

  1. Flexible settings for PNG resolution have been added. — noreply / githubweb

#292 (Jun 5, 2024, 3:36:06 AM)

  1. Making the only change required to make clubb run with openacc in cam. — Gunther Huebler / githubweb

#291 (Jun 4, 2024, 3:36:07 AM)

  1. Making the f in f90 capital for consistency. — Gunther Huebler / githubweb

#290 (May 30, 2024, 3:36:10 AM)

  1. The variable rc_coef_zm needed to be passed in and saved from — bmg2 / githubweb

#289 (May 17, 2024, 3:37:08 AM)

  1. Fixing a bug. Does not change default results. — bmg2 / githubweb

#288 (May 16, 2024, 3:37:09 AM)

  1. Fixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs. — Gunther Huebler / githubweb

#287 (May 14, 2024, 3:37:07 AM)

  1. gr%zm should be used here instead of gr%zt, since these are — bmg2 / githubweb
  2. Thermodynamic-level (zt) values should be used with zt-variable — bmg2 / githubweb

#286 (May 4, 2024, 3:37:08 AM)

  1. Adding extra exclamation to acc statement to comment it out. — Gunther Huebler / githubweb

#285 (May 3, 2024, 3:37:10 AM)

  1. I am committing code that effectively ignores the values of certain — bmg2 / githubweb
  2. I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the — bmg2 / githubweb

#284 (May 2, 2024, 3:37:06 AM)

  1. Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. — Gunther Huebler / githubweb
  2. Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. — Gunther Huebler / githubweb

#283 (May 1, 2024, 3:37:07 AM)

  1. Moved the ghost-point setting of xm(1) = xm(2) to the last line — bmg2 / githubweb
  2. Optional arguments are just best sometimes (#1150) — noreply / githubweb

#282 (Apr 27, 2024, 3:37:08 AM)

  1. I'm changing the way ddzt handles the derivative over momentum level 1. — bmg2 / githubweb

#281 (Apr 20, 2024, 3:36:09 AM)

  1. Changing the linear interpolation in the zt2zm function at momentum — bmg2 / githubweb

#280 (Apr 19, 2024, 3:36:06 AM)

  1. Committing some thresholding around positive-definite fields after — bmg2 / githubweb

#279 (Apr 14, 2024, 3:36:09 AM)

  1. I am committing a stats change to the ghost point values of zt — bmg2 / githubweb

#278 (Apr 12, 2024, 3:36:07 AM)

  1. This commit is being made to keep the stats zt output from the — bmg2 / githubweb
  2. I am committing a bug fix to the code that calculates mixed Brunt — bmg2 / githubweb

#277 (Apr 11, 2024, 3:36:08 AM)

  1. While it doesn't affect results, I fixed what appears to be an — bmg2 / githubweb
  2. I am updating the loop in subroutine diagnose_xpwp so that it doesn't — bmg2 / githubweb

#276 (Apr 7, 2024, 3:36:09 AM)

  1. It was discovered that the location where the ghost point values — bmg2 / githubweb

#275 (Apr 6, 2024, 3:36:08 AM)

  1. At the ghost point below the surface, which does not matter in — bmg2 / githubweb
  2. The code that advances um and vm when l_predict_upwp_vpwp is turned off — bmg2 / githubweb

#274 (Apr 2, 2024, 1:49:56 PM)

  1. Making compatible with latest clubb changes. — Gunther Huebler / githubweb

#273 (Apr 2, 2024, 3:36:09 AM)

  1. Fixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false. — Gunther Huebler / githubweb

#272 (Apr 1, 2024, 3:36:10 AM)

  1. Putting ngrdcol in clubb_params (#1147) — noreply / githubweb

#271 (Mar 29, 2024, 11:07:52 PM)

  1. We need to cherry-pick one commit to remove a polymorphic warning for gcc-10 and beyond, but also can't update the whole submodule. see https://github.com/larson-group/e3sm/issues/46\#issuecomment-1004408975 — Gunther Huebler / githubweb

#270 (Mar 29, 2024, 8:48:05 PM)

  1. Making e3sm not reliant on gcc-8 by adding -fallow-argument-mismatch to fflags — Gunther Huebler / githubweb

#267 (Mar 25, 2024, 3:36:08 AM)

  1. Adding sum part to comment — Gunther Huebler / githubweb

#266 (Mar 23, 2024, 3:36:08 AM)

  1. Adding comment to explain unusual code choice. — Gunther Huebler / githubweb

#265 (Mar 19, 2024, 3:36:07 AM)

  1. OpenMP Optimizations (#1146) — noreply / githubweb

#264 (Mar 6, 2024, 3:36:08 AM)

  1. Removes comment about Numerical Recipes — noreply / githubweb

#263 (Feb 16, 2024, 3:36:09 AM)

  1. Small acc tweaks (#1144) — noreply / githubweb

#262 (Feb 15, 2024, 3:36:09 AM)

  1. Add blank line in order to trigger Jenkins tests for CAM — noreply / githubweb

#261 (Feb 14, 2024, 3:36:10 AM)

  1. fixing bug, name of wm_zt was left as "wm" — Vince Larson / githubweb

#260 (Feb 9, 2024, 3:36:08 AM)

  1. adding equals sign cuz I've had it up to here with this typo! — benjamin.andrew.stephens / githubweb

#259 (Feb 8, 2024, 3:36:06 AM)

  1. Fixing a bug where the Lscale used in calculating the damping — bmg2 / githubweb

#258 (Feb 1, 2024, 3:36:06 AM)

  1. This is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\#issuecomment-1865156979. — Gunther Huebler / githubweb
  2. Removing backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\#issuecomment-1910844013 — Gunther Huebler / githubweb

#257 (Jan 25, 2024, 3:36:07 AM)

  1. Now that the value of wp3 is being set to a boundary value of 0 — bmg2 / githubweb

#256 (Jan 24, 2024, 3:36:06 AM)

  1. Update draw_plots_hoz_2D.py — noreply / githubweb

#255 (Jan 23, 2024, 3:36:09 AM)

  1. Update draw_plots_hoz_2D.py — noreply / githubweb

#254 (Jan 22, 2024, 3:36:07 AM)

  1. Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs. — Gunther Huebler / githubweb
  2. Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs. — Gunther Huebler / githubweb

#253 (Jan 19, 2024, 3:36:17 AM)

  1. Fixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139 — Gunther Huebler / githubweb
  2. Slight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139 — Gunther Huebler / githubweb
  3. Fixing small GPU stats bug — Gunther Huebler / githubweb
  4. Changing xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it. — Gunther Huebler / githubweb

#252 (Jan 12, 2024, 3:36:07 AM)

  1. I am altering the mean advection code in preparation for ghost point — bmg2 / githubweb

#251 (Jan 9, 2024, 3:36:10 AM)

  1. Adding new argument list variables to openacc copyin statements — Gunther Huebler / githubweb

#250 (Jan 6, 2024, 1:22:37 AM)

  1. None of that worked, case.submit does not return a status indicator, causing tests to only report fail. Now we save output to a file and grep for an error message to determine whether or not there was an error. — Gunther Huebler / githubweb

#249 (Jan 5, 2024, 10:43:58 PM)

  1. Removing wpthlp_entermfl and Richardson_num from clubb_vars_zm_list. These are no longer used, and overdefining namelists makes fortran unhappy. — Gunther Huebler / githubweb
  2. Small updates — Gunther Huebler / githubweb

#248 (Jan 5, 2024, 10:27:05 PM)

  1. Making e3sm fail properly by making a custom version of case.submit that return an error status because for some reason the cime people only thought to do that for case.build. — Gunther Huebler / githubweb
  2. Removing accidentally commited file — Gunther Huebler / githubweb

#247 (Jan 5, 2024, 3:36:10 AM)

  1. Removing awkward nan check in favor of a default for Ncnp2_on_Ncnm2 — Gunther Huebler / githubweb

#246 (Jan 4, 2024, 3:36:08 AM)

  1. Adding if around allocation and adding call for fields to be output, these are both to prevent runtime bugs — Gunther Huebler / githubweb
  2. Threadpublic (#1133) — noreply / githubweb
  3. Threadpublic (#1133) — noreply / githubweb
  4. Making compatible with latest clubb changes. — Gunther Huebler / githubweb

#245 (Dec 22, 2023, 3:36:07 AM)

  1. With wp3 now being set to a fixed-point boundary condition value — bmg2 / githubweb

#244 (Dec 19, 2023, 3:36:09 AM)

  1. Updating the code to set the bottom of the thermodynamic level grid for — Brian Griffin / githubweb
  2. Commit to enforce a fixed-point boundary condition of wp3=0 at — Brian Griffin / githubweb

#243 (Dec 13, 2023, 3:36:08 AM)

  1. Added new Brunt-Väisälä frequency plots to pyplotgen's VariableGroupTaus — Vince Larson / githubweb
  2. Adds commas to fix bug — noreply / githubweb

#242 (Dec 9, 2023, 3:36:07 AM)

  1. Adding boundary conditions for the wp3_term_ta_ADG1_lhs subroutine. — Brian Griffin / githubweb
  2. For single loop vectors, removing the "collapse(2)" from the acc statements. — Brian Griffin / githubweb

#241 (Dec 7, 2023, 3:36:08 AM)

  1. Update draw_plots_hoz_2D.py — noreply / githubweb

#240 (Nov 29, 2023, 3:36:11 AM)

  1. Re-adjusted cap for invrs_tau_wpxp in src/CLUBB_core/mixing_length.F90 — Steffen Domke / githubweb

#239 (Nov 25, 2023, 3:36:10 AM)

  1. Update draw_plots_hoz_2D.py — noreply / githubweb

#238 (Nov 19, 2023, 3:36:06 AM)

  1. Update draw_plots_hoz_2D.py — noreply / githubweb
  2. Update E3SM_CLUBB_diag.py — noreply / githubweb

#237 (Nov 17, 2023, 3:36:09 AM)

  1. Added non-trapezoidal zm interpolation for cloud_frac (#1127) — noreply / githubweb

#236 (Nov 15, 2023, 3:36:10 AM)

  1. Changing order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING. — Gunther Huebler / githubweb
  2. Setting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126 — Gunther Huebler / githubweb
  3. BIT_CHANGING! Updated taus code calculations - CLUBB ticket #1115 (#1125) — noreply / githubweb

#235 (Nov 11, 2023, 3:36:10 AM)

  1. Making work with latest clubb changes. — Gunther Huebler / githubweb
  2. Removing removed parameters from run file. — Gunther Huebler / githubweb
  3. Changing stat_indices to stats_metadata_type — Gunther Huebler / githubweb
  4. New Stats Indices Type (#1118) — noreply / githubweb
  5. New Stats Indices Type (#1118) — noreply / githubweb

#234 (Nov 10, 2023, 3:36:08 AM)

  1. Z displace tunable (#1122) — noreply / githubweb
  2. Z displace tunable (#62) — noreply / githubweb

#233 (Nov 9, 2023, 3:36:11 AM)

  1. Updated CLUBB so that adj_low_res_nu (which can be called on its own — bmg2 / githubweb
  2. Updated for recent changes to CLUBB. — bmg2 / githubweb
  3. Removing begin_height and end_height as outputs from setup_grid. They — bmg2 / githubweb
  4. Updated for recent changes to CLUBB. — bmg2 / githubweb

#232 (Nov 1, 2023, 3:36:08 AM)

  1. Latest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119) — noreply / githubweb
  2. BIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120) — noreply / githubweb

#231 (Oct 25, 2023, 3:36:09 AM)

  1. Finally removing scratch variables. (#1116) — noreply / githubweb

#230 (Oct 20, 2023, 3:36:08 AM)

  1. Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106) — noreply / githubweb
  2. BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102 — noreply / githubweb
  3. BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108) — noreply / githubweb
  4. Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109) — noreply / githubweb
  5. Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110) — noreply / githubweb
  6. BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111) — noreply / githubweb
  7. Tunable Richardson number exponent - CLUBB ticket #1102 (#1114) — noreply / githubweb
  8. Deletes svn id tag, will trigger host-model nightly tests. — noreply / githubweb
  9. Remove svn id tag in order to trigger nightly tests. — noreply / githubweb
  10. Removed 3rd svn id tag in order to trigger nightly tests — noreply / githubweb

#229 (Oct 17, 2023, 12:53:35 PM)

  1. wpxp_Ri_exp (#61) — noreply / githubweb

#228 (Oct 17, 2023, 11:20:58 AM)

  1. Update draw_plots_hoz_2D.py — noreply / githubweb
  2. Update E3SM_CLUBB_diag.py — noreply / githubweb
  3. Raw-copy updating components/eam/src/physics/clubb — LarsonGroupSysAdmin / githubweb

#226 (Oct 14, 2023, 3:36:07 AM)

  1. Raw-copy updating components/eam/src/physics/clubb — root / githubweb

#225 (Oct 3, 2023, 3:36:09 AM)

  1. Adds code to loop over parameters — noreply / githubweb

#224 (Sep 11, 2023, 3:36:08 AM)

  1. Update draw_plots_hoz_2D.py — noreply / githubweb
  2. Update draw_plots_hoz_2D.py — noreply / githubweb

#223 (Aug 29, 2023, 3:36:06 AM)

  1. Update draw_plots_hoz_2D.py — noreply / githubweb

#222 (Aug 2, 2023, 3:36:08 AM)

  1. Adding wp_coef and wp_coef_zt to acc data statements. — Gunther Huebler / githubweb
  2. Bv efold bit changing (#1095) — noreply / githubweb

#221 (Jul 26, 2023, 3:36:09 AM)

  1. Bit changing changes (#1104) — noreply / githubweb

#220 (Jul 19, 2023, 3:36:11 AM)

  1. Openacc tweaks and cleanup 2 (#1099) — noreply / githubweb

#219 (Jul 16, 2023, 3:36:07 AM)

  1. Loop to `nz-1` instead of `nz` because upper boundary condition — noreply / githubweb

#218 (Jul 12, 2023, 3:36:07 AM)

  1. Openacc tweaks and cleanup (#1097) — noreply / githubweb

#217 (Jul 11, 2023, 3:36:10 AM)

  1. Making compatible with latest clubb changes. — Gunther Huebler / githubweb

#216 (Jul 6, 2023, 3:36:08 AM)

  1. Changing "Fnc" to "fnc" for consistency and easy search. — benjamin.andrew.stephens / githubweb
  2. Memory usage optimizations (#1091) — noreply / githubweb

#215 (Jun 30, 2023, 3:36:09 AM)

  1. bv_efold (#57) — noreply / githubweb

#214 (Jun 28, 2023, 3:36:07 AM)

  1. CLUBB ticket #1069: (#1092) — noreply / githubweb

#213 (Jun 21, 2023, 3:36:11 AM)

  1. Data movement improvement (#1089) — noreply / githubweb

#212 (Jun 14, 2023, 3:36:09 AM)

  1. Moving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088) — noreply / githubweb

#211 (Jun 9, 2023, 3:36:09 AM)

  1. advance_xp2_xpyp with explicitly managed memory (#1086) — noreply / githubweb
  2. advance_windm_edsclrm with explicitly managed memory (#1087) — noreply / githubweb

#210 (Jun 7, 2023, 3:36:10 AM)

  1. advance_wp2_wp3 with explicitly managed memory  (#1085) — noreply / githubweb

#209 (Jun 3, 2023, 3:36:10 AM)

  1. GPUizing most of advance_clubb_core (#1084) — noreply / githubweb

#208 (May 31, 2023, 3:36:08 AM)

  1. GPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083) — noreply / githubweb

#207 (May 14, 2023, 3:36:08 AM)

  1. making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
  2. making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
  3. Here is another commit that changes nothing — cernikt / githubweb
  4. Here is another commit that changes nothing — cernikt / githubweb
  5. change to trigger updates — cernikt / githubweb
  6. change to calc pressure to trigger autoupdate — cernikt / githubweb

#206 (May 7, 2023, 3:36:10 AM)

  1. Removed Space From clip_explicit — cernikt / githubweb

#205 (May 4, 2023, 3:36:09 AM)

  1. Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code. — benjamin.andrew.stephens / githubweb

#204 (May 3, 2023, 3:36:08 AM)

  1. Calc sfc varnce GPUization (#1081) — noreply / githubweb

#203 (May 2, 2023, 3:36:09 AM)

  1. Making CLUBB's splatting scheme implicit and smoother (#1075) — noreply / githubweb

#202 (May 1, 2023, 3:36:09 AM)

  1. adding an update that changes nothing and is just a test for the autoupdate script — cernikt / githubweb

#201 (Apr 24, 2023, 3:36:10 AM)

  1. This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
  2. This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
  3. this is another commit that cahnges nothing that will trigger the gitUpdate scripts — cernikt / githubweb

#200 (Apr 22, 2023, 3:36:08 AM)

  1. GPUizing Various Small Routines (#1080) — noreply / githubweb

#199 (Apr 20, 2023, 3:36:07 AM)

  1. Lscale GPUization (#1079) — noreply / githubweb
  2. gfortran does not like intent(out) specifiers for functions. — Gunther Huebler / githubweb

#198 (Apr 8, 2023, 3:36:08 AM)

  1. Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test. — Gunther Huebler / githubweb

#197 (Apr 6, 2023, 2:07:08 PM)

  1. Advance xm wpxp gpuization (#1077) — noreply / githubweb
  2. Small tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems. — Gunther Huebler / githubweb
  3. Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard. — Gunther Huebler / githubweb

#195 (Apr 4, 2023, 4:49:02 PM)

  1. This commit contains code changes to implement modifications on limiters in three places: — bmg2 / githubweb
  2. Updated for recent changes to CLUBB. — bmg2 / githubweb

#194 (Apr 1, 2023, 3:36:10 AM)

  1. Code changes to implement modificiations on wp3 clippings — bmg2 / githubweb

#193 (Mar 25, 2023, 3:36:08 AM)

  1. Small GPU fixes (#1076) — noreply / githubweb

#192 (Mar 23, 2023, 3:36:08 AM)

  1. Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2. — Gunther Huebler / githubweb

#191 (Mar 17, 2023, 3:36:07 AM)

  1. Moving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break. — Gunther Huebler / githubweb

#190 (Mar 15, 2023, 3:36:08 AM)

  1. Pdf closure driver gpuization (#1071) — noreply / githubweb

#189 (Mar 14, 2023, 3:36:09 AM)

  1. Making 'a_const' into a CLUBB tunable parameter. (#1072) — noreply / githubweb
  2. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/1072. — benjamin.andrew.stephens / githubweb

#188 (Mar 10, 2023, 3:36:06 AM)

  1. Implements Thomas Toniazzo's bug fix for spike removal — noreply / githubweb

#187 (Mar 9, 2023, 3:36:07 AM)

  1. Gpu updates (#1070) — noreply / githubweb

#186 (Mar 1, 2023, 3:36:10 AM)

  1. Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068) — noreply / githubweb

#185 (Feb 28, 2023, 3:36:07 AM)

  1. Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly. — 37674341+huebleruwm / githubweb

#184 (Feb 18, 2023, 3:36:09 AM)

  1. Adding wp3_on_wp2_cfl_num to CLUBB's output stats. — bmg2 / githubweb

#183 (Feb 9, 2023, 3:36:08 AM)

  1. Porting pdf_closure subroutine with OpenACC (#1059) — noreply / githubweb

#182 (Feb 8, 2023, 3:36:07 AM)

  1. GPUizing some helping procedures. — 37674341+huebleruwm / githubweb
  2. Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory. — 37674341+huebleruwm / githubweb

#181 (Feb 5, 2023, 3:36:06 AM)

  1. Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1 — Gunther Huebler / githubweb

#180 (Feb 3, 2023, 3:36:10 AM)

  1. Pushing column loop into calculate_thvm — 37674341+huebleruwm / githubweb
  2. Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926. — 37674341+huebleruwm / githubweb

#179 (Jan 26, 2023, 3:36:10 AM)

  1. GPUizing sat_mixrat_ice_2D. — 37674341+huebleruwm / githubweb

#178 (Jan 25, 2023, 3:36:10 AM)

  1. Adding OpenACC data directives for mixing length and adg routines — Vince Larson / githubweb
  2. Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general. — Gunther Huebler / githubweb

#177 (Jan 20, 2023, 3:36:09 AM)

  1. Breaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051) — noreply / githubweb
  2. Adding tridiag_lu solver (#1056) — noreply / githubweb

#176 (Jan 19, 2023, 3:36:08 AM)

  1. Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) — noreply / githubweb

#175 (Jan 13, 2023, 3:36:11 AM)

  1. Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052) — noreply / githubweb

#174 (Jan 12, 2023, 3:36:09 AM)

  1. Pushing column loop into lapack wrap. — 37674341+huebleruwm / githubweb

#173 (Dec 10, 2022, 3:36:10 AM)

  1. I updated the clubb_intr.F90 file in the clubb_silhs_devel branch to — bmg2 / githubweb
  2. I can now safely remove all the "ifdef E3SM" statements from CLUBB's — bmg2 / githubweb

#172 (Dec 8, 2022, 3:36:06 AM)

  1. ADG1_pdf_driver subroutine port with OpenACC — 37674341+huebleruwm / githubweb
  2. Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049 — 37674341+huebleruwm / githubweb

#171 (Nov 29, 2022, 3:36:07 AM)

  1. I added "smooth" max clipping for invrs_tau_shear, which is a variable — bmg2 / githubweb

#170 (Nov 24, 2022, 3:36:09 AM)

  1. Making compatible with latest clubb changes. — Gunther Huebler / githubweb
  2. Adding capability to change matrix solving method via clubb_config_flags. — 37674341+huebleruwm / githubweb
  3. Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones. — 37674341+huebleruwm / githubweb
  4. Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024. — 37674341+huebleruwm / githubweb

#169 (Nov 23, 2022, 3:36:06 AM)

  1. Steffens tuner fixer branch (#1041) — noreply / githubweb

#168 (Nov 22, 2022, 3:36:08 AM)

  1. A different way of dealing with monotonic flux limiter spikes (#1046) — noreply / githubweb

#167 (Nov 17, 2022, 3:36:07 AM)

  1. Making interface for matrix solvers. — 37674341+huebleruwm / githubweb
  2. Making tridag tridiag everywhere, making sol soln, and adding intent comments. — 37674341+huebleruwm / githubweb

#166 (Nov 9, 2022, 3:36:08 AM)

  1. Minor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043) — noreply / githubweb

#164 (Oct 15, 2022, 3:36:09 AM)

  1. Creating new flags to control monotonic flux limiter (#1039) — noreply / githubweb
  2. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/1039. — 59519056+bstephens82 / githubweb
  3. I am adding cloudy_updraft_frac and cloudy_downdraft_frac as — bmg2 / githubweb
  4. Modified for changes made to call to advance_clubb_core_api. — bmg2 / githubweb

#163 (Oct 14, 2022, 3:36:07 AM)

  1. Updating monotonic flux limiter code to remove spikes. (#1038) — noreply / githubweb

#162 (Oct 11, 2022, 3:36:07 AM)

  1. Adds commented-out line that prevents the monotonic flux — noreply / githubweb

#161 (Oct 10, 2022, 11:17:03 AM)

  1. I have updated the diagnostic. Main changes: 1. Merge Prof. Larson's tuner analyze_sensitivity_matrix. But domatrix is false by default, because the tuner is not the latest version.  2. Mergeing Kate's changes in function_pick_out.py. CAM's FV  dycore can be handled. 3. Plotting profiles below 700hPa. 4. Merge Brian's flag for DJF mean. 5. Creating new regional files for tuner, see draw_plots_hoz_2D.py. — guozhun / githubweb
  2. Plotting file for large scale variables. — guozhun / githubweb

#160 (Oct 6, 2022, 3:36:08 AM)

  1. Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical. — 37674341+huebleruwm / githubweb

#159 (Sep 10, 2022, 3:36:06 AM)

  1. Adding initial subroutine calc_ice_cloud_frac_component. — 37674341+huebleruwm / githubweb
  2. Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  3. Comment update — 37674341+huebleruwm / githubweb
  4. Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines. — 37674341+huebleruwm / githubweb

#158 (Sep 8, 2022, 3:36:07 AM)

  1. Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  2. Adding comments. — 37674341+huebleruwm / githubweb

#157 (Aug 31, 2022, 3:36:09 AM)

  1. Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972. — 37674341+huebleruwm / githubweb
  2. Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  3. Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  4. Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb

#155 (Aug 18, 2022, 3:36:11 AM)

  1. I have optimized the new w_up_in_cloud and w_down_in_cloud code by — bmg2 / githubweb

#154 (Aug 17, 2022, 3:36:10 AM)

  1. I altered the w_up_in_cloud and w_down_in_cloud code so that a — bmg2 / githubweb

#153 (Aug 16, 2022, 3:36:07 AM)

  1. I changed the w_up_in_cloud code in 2 ways: — bmg2 / githubweb
  2. I added stats output for w_down_in_cloud to all_stats.in. — bmg2 / githubweb
  3. Modifications for the latest CLUBB code changes. — bmg2 / githubweb
  4. Adding w_down_in_cl to the E3SM stats output, as well. — bmg2 / githubweb

#152 (Jul 20, 2022, 3:36:07 AM)

  1. Fixing a bug in mono_flux_limiter.F90. (#1026) — noreply / githubweb
  2. Fixing a bug. — bmg2 / githubweb

#151 (Jun 22, 2022, 3:36:08 AM)

  1. Fixing units in stats_zt_module.F90 — noreply / githubweb

#150 (Jun 18, 2022, 3:36:08 AM)

  1. Making linear_interpolated_azt_2D and linear_interpolated_azm_2D subroutines just to avoid a needless data copy. — 37674341+huebleruwm / githubweb
  2. Making update_xp2_mc 2D and creating interface for 1D calls. — 37674341+huebleruwm / githubweb
  3. Making use of new 2D call to update_xp2_mc — Gunther Huebler / githubweb

#149 (Jun 16, 2022, 3:36:08 AM)

  1. Pushing loop into fill_holes. — 37674341+huebleruwm / githubweb
  2. Forgot small change. — 37674341+huebleruwm / githubweb

#148 (Jun 11, 2022, 3:36:09 AM)

  1. Fixing small bug preventing compilation. — Gunther Huebler / githubweb
  2. Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it. — 37674341+huebleruwm / githubweb
  3. Pushing column loop into mean advection procedures. — 37674341+huebleruwm / githubweb
  4. Little loop push — 37674341+huebleruwm / githubweb
  5. Moving above/below index of grid weights to last dimension. — 37674341+huebleruwm / githubweb

#147 (Jun 10, 2022, 3:36:08 AM)

  1. The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb
  2. The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb
  3. Making compatible with latest clubb change. update_xp2_mc will be broken by this, but all we need to do to fix it is push the column loop into it. — Gunther Huebler / githubweb

#146 (Jun 9, 2022, 3:36:09 AM)

  1. Putting other log file copy commands in try catch to prevent it from failing the step before cleaning the directory — pbroels / githubweb

#145 (Jun 8, 2022, 1:15:37 PM)

  1. edited config_compilers.xml nelson configuration flags to make it work on pop OS — cernikt / githubweb

#144 (Jun 8, 2022, 3:36:08 AM)

  1. Lots of small loop pushes — 37674341+huebleruwm / githubweb
  2. Small bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run. — 37674341+huebleruwm / githubweb
  3. Small refactoring to mfl_xm_lhs, just removing need to pass in gr. — 37674341+huebleruwm / githubweb
  4. Final loop pushes needed before the grid change. — 37674341+huebleruwm / githubweb
  5. Replacing use of gr with nz — 37674341+huebleruwm / githubweb
  6. Replacing use of gr with nz — 37674341+huebleruwm / githubweb

#143 (Jun 3, 2022, 1:47:53 PM)

  1. Fixing small bug preventing compilation. — Gunther Huebler / githubweb

#141 (Jun 3, 2022, 3:36:08 AM)

  1. Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value. — Gunther Huebler / githubweb
  2. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  3. Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types. — Gunther Huebler / githubweb
  4. Making compatible with latest clubb change. — Gunther Huebler / githubweb

#140 (Jun 2, 2022, 3:36:07 AM)

  1. The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. — Gunther Huebler / githubweb
  2. Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version. — Gunther Huebler / githubweb
  3. Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). — Gunther Huebler / githubweb
  4. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  5. Making 2D versions of setup_grid and setup_parameters. — Gunther Huebler / githubweb

#139 (Jun 1, 2022, 3:36:07 AM)

  1. Almost final loop pushes (#1012) — noreply / githubweb
  2. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  3. Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) — noreply / githubweb

#138 (May 28, 2022, 3:36:11 AM)

  1. Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
  2. Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
  3. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4. — benjamin.andrew.stephens / githubweb

#137 (May 26, 2022, 3:36:09 AM)

  1. Made an update to use an optional (false by default) seasonal — bmg2 / githubweb
  2. Added a E3SM diags run script that is set up for model vs. model — bmg2 / githubweb

#136 (May 16, 2022, 2:51:34 PM)

  1. Added ability to apply smooth min max functions in mixing_length.F90 — 68997723+JanGrn / githubweb
  2. Updated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
  3. Checked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
  4. Added test cases to smooth_min_max_tests.F90 and updated documentation. — 68997723+JanGrn / githubweb

#130 (May 6, 2022, 3:36:11 AM)

  1. Renamed smth_range to heaviside_smth_range — 68997723+JanGrn / githubweb
  2. Added tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes. — 68997723+JanGrn / githubweb
  3. Implemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0. — 68997723+JanGrn / githubweb
  4. Changed priorities of total normalized variation stats, included error handling in total normalized variation stats. — 68997723+JanGrn / githubweb
  5. Renamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls. — 68997723+JanGrn / githubweb
  6. Gunthers branch 2 (#1002) — noreply / githubweb
  7. Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail. — 68997723+JanGrn / githubweb

#129 (May 4, 2022, 3:36:07 AM)

  1. Gunthers branch (#999) — noreply / githubweb

#128 (Apr 27, 2022, 3:36:10 AM)

  1. Small bug fix. — Gunther Huebler / githubweb
  2. Another similar small bug fix. — Gunther Huebler / githubweb
  3. Adding in comments to explain confusing parts of the Jenkinsfiles. — pbroels / githubweb

#127 (Apr 26, 2022, 3:36:09 AM)

  1. Various simple changes to improve performance. All bit-for-bit. — Gunther Huebler / githubweb
  2. Pushing loop into calc_stability_correction. — Gunther Huebler / githubweb

#126 (Apr 22, 2022, 3:36:08 AM)

  1. Fixing small bug. This wasn't answer changing, but would cause a crash if we turned bound checking debug flags on. — Gunther Huebler / githubweb
  2. Gunthers branch (#996) — noreply / githubweb
  3. Adding in the jenkins file and updating names for the copy test. — pbroels / githubweb
  4. Renaming directory to be consistant with other repos. — pbroels / githubweb

#125 (Apr 20, 2022, 1:59:22 PM)

  1. Updating E3SM for the latest version of CLUBB. — bmg2 / githubweb

#122 (Apr 13, 2022, 3:36:10 AM)

  1. I added the code for the l_linearize_pbl_winds flag that was originally — bmg2 / githubweb

#121 (Apr 9, 2022, 3:36:08 AM)

  1. Commenting out sponge damping code. This is BIT_CHANGING. — Gunther Huebler / githubweb
  2. This fixes a bug that was exposed when we switched to having pdf closure in the post position. pdf_params_chnk is the structure that keeps track of the pdf_params each timestep, and the single_col version is only a local variable we use to get pdf_params from clubb then save them into the chnk version. But we were not copying from the chnk version into the single_col version before calling clubb, so when pdf_closure is done in post, we had incorrect pdf_params as input. This is BIT_CHANGING. This will also be deleted in the next commit, it is mostly symbolic just to demonstrate what exactly the problem was. — Gunther Huebler / githubweb
  3. Making clubb_tend_cam use the multi column version of clubb. This is bit-for-bit. — Gunther Huebler / githubweb

#120 (Apr 8, 2022, 3:36:08 AM)

  1. Breaking up column loop in clubb_tend_cam. — Gunther Huebler / githubweb

#119 (Apr 6, 2022, 3:36:07 AM)

  1. Added idiot-proofing to print a warning message when l_diag_Lscale_from_tau — bmg2 / githubweb
  2. Updating the call to setup_clubb_core_api based on new CLUBB — bmg2 / githubweb

#118 (Apr 1, 2022, 3:36:07 AM)

  1. Adding e3smClubbCodeCopy.bash to the jenkins directory for testing Clubb changes. larson-group/sys_admin#768 — pbroels / githubweb

#117 (Mar 30, 2022, 3:36:06 AM)

  1. Added a3_coef_min to the list of CLUBB's tunable parameter and then — bmg2 / githubweb
  2. Adding CLUBB's new a3_coef_min tunable parameter to the E3SM-CLUBB code. — bmg2 / githubweb

#116 (Mar 26, 2022, 3:36:07 AM)

  1. I added l_relax_clipping to CLUBB's config flags. — bmg2 / githubweb
  2. Added the l_enable_relaxed_clipping interface to E3SM-CLUBB — bmg2 / githubweb

#115 (Mar 22, 2022, 3:36:10 AM)

  1. Changing Carson compiler definition to work for the Carson nightly tests. larson-group/sys_admin#763 — pbroels / githubweb

#114 (Mar 17, 2022, 3:36:07 AM)

  1. Removes a blank line in order to trigger merge with E3SM — noreply / githubweb
  2. Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  3. Replacing the i loop iterator for scalars with sclr. — 37674341+huebleruwm / githubweb
  4. Pushing loop into advance_xp2_wpxp. — 37674341+huebleruwm / githubweb
  5. Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats. — 37674341+huebleruwm / githubweb
  6. Moving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call. — 37674341+huebleruwm / githubweb
  7. Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way. — 37674341+huebleruwm / githubweb
  8. Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn. — 37674341+huebleruwm / githubweb
  9. Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp. — 37674341+huebleruwm / githubweb

#113 (Mar 15, 2022, 3:36:06 AM)

  1. For other:ticket:362, adding our current license agreement to the source code. — nieznan3 / githubweb
  2. For clubb:ticket:740, I added `l_rcm_in_cloud_k_lh_start` and `l_random_k_lh_start` to the microphysics namelist for experimentation. — raut / githubweb
  3. I made the changes necessary to get 2D output working. — raut / githubweb
  4. I patched a memory leak related to clubb:ticket:740. — raut / githubweb
  5. For clubb:ticket:740, I implemented an algorithm to limit the sample point weights to a prescribed maximum. The algorithm ended up being a bit more convoluted that I originally thought it would, but it works! — raut / githubweb
  6. For clubb:ticket:740, I am adding an output, "rrm_mc_nonadj", that contains the value of the tendenc — raut / githubweb
  7. For clubb:ticket:740, I added `prob_thresh` to the microphysics namelist as `importance_prob_thresh` in preparation of finalizing a configuration for the paper. — raut / githubweb
  8. For clubb:tickets:770, I am merging my branch into the trunk. This code includes a 3D_Luhar pdf closure and is provided 'as is' and without warranty. — weberjk / githubweb
  9. For clubb:ticket:740, I generalized the clustering code to handle different numbers of categories in each cluster. — raut / githubweb
  10. I am committing, into a feature branch (because I hear they are the hot new thing), some untested code that proportionally allocates categories only in the cloud or precipitation regions. — raut / githubweb
  11. For clubb:ticket:770, cleaning up some compiler warnings. In the process, found a bug where Skrt_zm was not being computed. I deleted diagnose_xp3_module since it is unfinished and unused. If we want to add a third order moment for interactive runs, the Ticket_770 branch has diagnose_xp3_module.F90 for one to continue work on. — weberjk / githubweb
  12. I renamed `new_scheme` to `two_cluster_cp_nocp`. — raut / githubweb
  13. A small bug fix for an assertion check was committed herein. — raut / githubweb
  14. For clubb:ticket:770, the Oracle compiler was throwing a floating point exception here. wpxp2 and xp2 were being fed in as Nans. — weberjk / githubweb
  15. For clubb:ticket:740, I am making some changes to the importance sampling code to support zero prescribed probability in a cluster. — raut / githubweb
  16. For clubb:ticket:740, I changed some SILHS parameters and added others to the namelist so they can be changed at runtime. At this point, the configuration of SILHS to be used in the paper can be enabled without editing any source code. — raut / githubweb
  17. The new file calc_roots.F90 contains functions that solve for the roots of a — bmg2 / githubweb
  18. I added a comment. — raut / githubweb
  19. For clubb:ticket:740, I implemented the algorithm to prescribe `f_j` (called the "variance fraction" in the code) rather than `S_j` (called the "prescribed probability" in the code). The algorithm ended up being short and elegant because transferrence is not required when prescribing `f_j`. (When prescribing `f_j`, `p_j = 0` implies `S_j = 0`, so transferrence is not needed.) — raut / githubweb
  20. For clubb:ticket:740, I added `l_lh_var_frac` to the namelist. — raut / githubweb
  21. For clubb:ticket:740, I am handling the scariest divide-by-zero situation you've ever seen, just in case. — raut / githubweb
  22. I tweaked the precipitation fraction code so that the weighted ith PDF component — bmg2 / githubweb
  23. For clubb:ticket:740, I had, in an earlier commit, left out a block of code that should be there. Now it is there. — raut / githubweb
  24. I moved the subroutine `determine_sample_categories` to the module `silhs_importance_sample_module` to make it available to modules within the `SILHS` subfolder. — raut / githubweb
  25. For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j. — raut / githubweb
  26. For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j. — raut / githubweb
  27. I have discovered a better way to do the assertion check for consistency between `chi_i`, `stdev_chi_i`, and `cloud_frac_i`. — raut / githubweb
  28. For clubb:ticket:720: — raut / githubweb
  29. I updated pdf_closure_module.F90 by integrating changes I made in the — bmg2 / githubweb
  30. For cam:ticket:36: — raut / githubweb
  31. For cam:ticket:36#comment:132, I removed `gr` from the use statement in `setup_grid_heights_api`. — raut / githubweb
  32. For clubb:ticket:773, I fixed some unsoundness in our code regarding kinds, specifically in `parameters_model.F90` and `endian.F90`. — raut / githubweb
  33. For cam:ticket:41, the change in clubb:r7921 should be applied to the trunk as well. — raut / githubweb
  34. For clubb:ticket:775: — raut / githubweb
  35. For clubb:ticket:775: — raut / githubweb
  36. Misc. code cleanup — raut / githubweb
  37. I am updating default CLUBB to use the same hydrometeor PDF parameters that are — bmg2 / githubweb
  38. For cam:ticket:50: — raut / githubweb
  39. For cam:ticket:50: — raut / githubweb
  40. For cam:ticket:50: — raut / githubweb
  41. For clubb:ticket:778, I am setting the tolerance on an assertion check based on epsilon. Hopefully, this assertion will no longer trip in single precision mode. — raut / githubweb
  42. For cam:ticket:52: — raut / githubweb
  43. For cam:ticket:52, I added some parameter indices to the API. — raut / githubweb
  44. I forgot a parameter! — raut / githubweb
  45. For cam:ticket:54: — raut / githubweb
  46. For clubb:ticket:753: — raut / githubweb
  47. For clubb:ticket:753: — raut / githubweb
  48. For clubb:ticket:782: — raut / githubweb
  49. I forgot a flag. — raut / githubweb
  50. For clubb:ticket:782: — raut / githubweb
  51. For cam:ticket:55, I added some parameters to CLUBB's API. — raut / githubweb
  52. For cam:ticket:55: — raut / githubweb
  53. For clubb:ticket:782, I merged in NCAR's changes to SILHS. — raut / githubweb
  54. For clubb:ticket:753: — raut / githubweb
  55. For clubb:ticket:753: — raut / githubweb
  56. For clubb:ticket:753: — raut / githubweb
  57. I cleaned up some warnings from the Mac compiler. (build:14977) — raut / githubweb
  58. I cleaned up some warnings from the Mac compiler. (build:14977) — raut / githubweb
  59. For clubb:ticket:785, I renamed `initvars` to `clubb_params_nl`. — raut / githubweb
  60. For clubb:ticket:785: — raut / githubweb
  61. For clubb:ticket:779: — raut / githubweb
  62. For cam:ticket:56: — raut / githubweb
  63. For cam:ticket:56: — raut / githubweb
  64. For clubb:ticket:786: — raut / githubweb
  65. For clubb:ticket:786: — raut / githubweb
  66. For clubb:ticket:786: — raut / githubweb
  67. For clubb:ticket:782, I added all CLUBB's parameter indices to the API. — raut / githubweb
  68. helpful note — raut / githubweb
  69. more helpful note — raut / githubweb
  70. most helpful note — raut / githubweb
  71. For cam:ticket:56: — raut / githubweb
  72. While working on cam:ticket:59, I noticed that `tau_N2_zm` is computed twice. I removed one computation. — raut / githubweb
  73. Dat crazy indentation, though... — raut / githubweb
  74. For cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`. — raut / githubweb
  75. For cam:ticket:59: — raut / githubweb
  76. For cam:ticket:59: — raut / githubweb
  77. For cam:ticket:59: — raut / githubweb
  78. For cam:ticket:59, I added a new output for Richardson number. — raut / githubweb
  79. For cam:ticket:59: — raut / githubweb
  80. Per cam:ticket:59#comment:21, using `T_in_K_zm` in "the formula". — raut / githubweb
  81. For cam:ticket:59. — raut / githubweb
  82. For cam:ticket:59 I renamed `Richardson_no` to `Richardson_num`. — raut / githubweb
  83. For cam:ticket:59, I added kludgy statistical output for `brunt_vaisala_freq_sqd`. — raut / githubweb
  84. I made an error message more verbose. — raut / githubweb
  85. Still wanted to stop, though... — raut / githubweb
  86. For cam:ticket:59: — raut / githubweb
  87. For cam:ticket:59: — raut / githubweb
  88. For cam:ticket:59: — raut / githubweb
  89. For cam:ticket:59. — raut / githubweb
  90. For cam:ticket:59: — raut / githubweb
  91. Apparently, I didn't have to jump through the hoop of declaring a separate profile to use in the `max` statement. — raut / githubweb
  92. For cam:ticket:59: — raut / githubweb
  93. For cam:ticket:59: — raut / githubweb
  94. For cam:ticket:59: — raut / githubweb
  95. For clubb:ticket:782: — raut / githubweb
  96. For cam:ticket:59: — raut / githubweb
  97. For cam:ticket:59: — raut / githubweb
  98. For cam:ticket:59: — raut / githubweb
  99. For cam:ticket:59: — raut / githubweb
  100. For clubb:ticket:782: — raut / githubweb
  101. For cam:ticket:59: — raut / githubweb
  102. For cam:ticket:59, I fixed bugs in the `l_use_C7_Richardson=T` vertical averaging code: — raut / githubweb
  103. I adjusted a comment. — raut / githubweb
  104. For clubb:ticket:788: — raut / githubweb
  105. For cam:ticket:59: — raut / githubweb
  106. For clubb:ticket:788: — raut / githubweb
  107. For clubb:ticket:788: — raut / githubweb
  108. For clubb:ticket:788: — raut / githubweb
  109. For clubb:ticket:788: — raut / githubweb
  110. For clubb:ticket:788: — raut / githubweb
  111. Renamed C7 to Cx in appropriate places. — raut / githubweb
  112. For cam:ticket:59: — raut / githubweb
  113. For cam:ticket:59: — raut / githubweb
  114. I made it a default to use 0 instead of cloud_frac_min in the B.V. frequency calculation. — raut / githubweb
  115. For clubb:ticket:790: — raut / githubweb
  116. I am setting `l_lh_normalize_weights=T` by default in both the source code and the namelist. — raut / githubweb
  117. It is more robust to check the average of the sample point weights rather than the sum of the sample point weights for unity-ness. — raut / githubweb
  118. For cam:ticket:67: — raut / githubweb
  119. For cam:ticket:67: — raut / githubweb
  120. Code improvements. — raut / githubweb
  121. Vince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more! — raut / githubweb
  122. For cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used. — raut / githubweb
  123. Fixed a comment. — raut / githubweb
  124. For clubb:ticket:788: — raut / githubweb
  125. For clubb:ticket:792: — raut / githubweb
  126. For clubb:ticket:792: — raut / githubweb
  127. For clubb:ticket:792, I added more initializations for uninitialized variables. — raut / githubweb
  128. When l_avg_Lscale is turned on but the plume-centered calculation is disabled, — bmg2 / githubweb
  129. For clubb:ticket:792: — raut / githubweb
  130. For clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output. — raut / githubweb
  131. I renamed RH_postPDF to rel_humidity. — raut / githubweb
  132. For clubb:ticket:792. rsat actually should be recomputed here before output, because it will change if `l_rcm_supersat_adj = T`. — raut / githubweb
  133. For clubb:ticket:792. I am reusing the `rel_humidity` variable for output, for no particular reason. — raut / githubweb
  134. For clubb:ticket:792!!!! I set `l_rcm_supersat_adj = T` by default, in both source code and namelist. — raut / githubweb
  135. As requested, I am adding a warning message (debug level 1) when spurious supersaturation is removed. — raut / githubweb
  136. Comment. — raut / githubweb
  137. For clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010). — raut / githubweb
  138. I removed a spurious print statement. — raut / githubweb
  139. For cam:ticket:73: — raut / githubweb
  140. I am beginning to generalize the sponge damping code so that it can be applied to — bmg2 / githubweb
  141. I have added all the coding infrastructure to perform sponge damping (and record — bmg2 / githubweb
  142. Vince Larson / githubweb
  143. clubb:ticket:796 — roessle9 / githubweb
  144. clubb:ticket:796 — roessle9 / githubweb
  145. I added some parameter value checking in subroutine setup_parameters. — bmg2 / githubweb
  146. clubb:ticket:796 — roessle9 / githubweb
  147. I finally have a standalone version of the new subroutine, generate_pdf_params, — bmg2 / githubweb
  148. Some code within advance_clubb_core that is found within CAM_CLUBB preprocessor — bmg2 / githubweb
  149. The perturbation Lscale code requires rtm_frz, thlm_frz, and pdf_params_frz to — bmg2 / githubweb
  150. I added a missing intent(out) statement. — bmg2 / githubweb
  151. I have interfaced the new subroutine containing all of the PDF closure-related — bmg2 / githubweb
  152. I got rid of some variables that were brought into advance_clubb_core by use statements — bmg2 / githubweb
  153. I cleaned up more compiler warnings for unused variables.  The warnings came from g95. — bmg2 / githubweb
  154. I have added a second call to subroutine generate_pdf_params.  This one occurs — bmg2 / githubweb
  155. I moved the setting of qclvar and thlprcp_out to after the second call to — bmg2 / githubweb
  156. I have declared the l_use_ice_latent option and the l_call_pdf_closure_twice — bmg2 / githubweb
  157. I added a local cslculation of sigma_sqd_w near the top of subroutine — bmg2 / githubweb
  158. I am changing the inputs and outputs of subroutine advance_clubb_core so that — bmg2 / githubweb
  159. I added code so that stats that are internal to subroutine generate_pdf_params — bmg2 / githubweb
  160. I have updated subroutine advance_clubb_core so that pdf_params_zm is now passed — bmg2 / githubweb
  161. Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical — savva / githubweb
  162. Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical — savva / githubweb
  163. Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical — savva / githubweb
  164. Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical — savva / githubweb
  165. Vince Larson / githubweb
  166. Vince Larson / githubweb
  167. I added a new subroutine, init_pdf_params, to pdf_parameter_module.F90. — bmg2 / githubweb
  168. I renamed the subroutine pack_pdf_params found in setup_clubb_pdf_params.F90 — bmg2 / githubweb
  169. I am now using the new subroutine init_pdf_params to initialize the — bmg2 / githubweb
  170. I removed the CAM_CLUBB preprocessor directives from pack_pdf_params_api, — bmg2 / githubweb
  171. clubb:ticket:800 -- Changed fatal errors statements to debug level 0. — savva / githubweb
  172. clubb:ticket:800 -- Changed fatal errors statements to debug level 0. — savva / githubweb
  173. I updated CLUBB stats so that wpthvp, wp2thvp, rtpthvp, and thlpthvp — bmg2 / githubweb
  174. I have added the coding infrastructure to output additional statistics — bmg2 / githubweb
  175. This is a bug fix for the Sun compiler.  The variables pdf_params_zm and — bmg2 / githubweb
  176. I am updating the hydrometeor PDF code to set mu_hm_1 and — bmg2 / githubweb
  177. Running the Bitten tests. — bmg2 / githubweb
  178. I added some comments so that CLUBB-SILHS would be consistent with — Vince Larson / githubweb
  179. I added some comments so that CLUBB-SILHS would be consistent with — Vince Larson / githubweb
  180. clubb:ticket:805 — roessle9 / githubweb
  181. clubb:ticket:805 — roessle9 / githubweb
  182. clubb:ticket:805 — roessle9 / githubweb
  183. For clubb:ticket:805, I made two changes: — Vince Larson / githubweb
  184. As a first step, I changed all instances of rrtthl to corr_rt_thl_1. — bmg2 / githubweb
  185. I have added corr_rt_thl_2 to the code to go along with corr_rt_thl_2. — bmg2 / githubweb
  186. I have added some code to add corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2 — bmg2 / githubweb
  187. I added new statistics to the CLUBB _zt output files, specifically corr_w_rt_1, corr_w_rt_2, — bmg2 / githubweb
  188. I am updating the equations for wp2rtp, wp2thlp, wprtp2, and wpthlp2 to include — bmg2 / githubweb
  189. I am adding a special function to calculate the within-component correlation of — bmg2 / githubweb
  190. I added variables corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 — bmg2 / githubweb
  191. I am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to type — bmg2 / githubweb
  192. Now that the PDF component correlations of w and chi, as well as w and eta, — bmg2 / githubweb
  193. I am adding statistical output for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, — bmg2 / githubweb
  194. I am changing the name of the flag l_fix_chi_eta_correlations to — bmg2 / githubweb
  195. The two component normal (double Gaussian) PDF used by CLUBB will now be — bmg2 / githubweb
  196. I moved the checking of the options for the PDF call placement to subroutine — bmg2 / githubweb
  197. I am altering setup PDF parameters to be able to read in the values of — bmg2 / githubweb
  198. I am adding the new file new_pdf.F90 to the CLUBB core directory.  So far, it — bmg2 / githubweb
  199. I am adding a large amount of code to the new PDF.  I have filled in the driver — bmg2 / githubweb
  200. I am adding code to the new PDF that calculates the minimum and maximum — bmg2 / githubweb
  201. I added a new iiPDF entry for the new PDF, and I neatened some of the current — bmg2 / githubweb
  202. I added an option to call the new PDF from subroutine pdf_closure. — bmg2 / githubweb
  203. I had to add checking for the new PDF so someone does not try to run it — bmg2 / githubweb
  204. I made a couple changes to (1) initialize two variables that aren't used by the — bmg2 / githubweb
  205. I added a conditional to the subroutine that sets the responder parameters. — bmg2 / githubweb
  206. I have added the beginnings of a new unit test for the PDF parameters. — bmg2 / githubweb
  207. I have updated the PDF parameter unit test to make a call to the full PDF (for — bmg2 / githubweb
  208. I have added a feature to the PDF parameter unit tests which allows the user — bmg2 / githubweb
  209. In the setter variable description and subprograms, I made a name change from — bmg2 / githubweb
  210. I have updated the method of calculating the setter variable so that mu_x_1 — bmg2 / githubweb
  211. I added primarily some more documentation and notes. — bmg2 / githubweb
  212. I added some more comments documenting the code. — bmg2 / githubweb
  213. I got rid of some of the expressions that a script might try to flag as — bmg2 / githubweb
  214. I added much more documentation about the responder variable.  Specifically, — bmg2 / githubweb
  215. I am adding the new file, original_pdf.F90, as the new home for the ADG1, ADG2, — bmg2 / githubweb
  216. I have now switched the PDF closure code over to calling the code that had been — bmg2 / githubweb
  217. I updated the documentation in the code comments for the setter method and — bmg2 / githubweb
  218. I added a comment. — bmg2 / githubweb
  219. I added a new function, calc_comp_corrs_binormal, to pdf_utilities.F90.  This — bmg2 / githubweb
  220. I added some more descriptive comments and a new function that calculates the — bmg2 / githubweb
  221. I updated the code so that coef_sigma_x_1_sqd and coef_sigma_x_2_sqd are passed — bmg2 / githubweb
  222. I fixed a mistake. — bmg2 / githubweb
  223. I have added code to call the new function that calculates wp4 implicitly from — bmg2 / githubweb
  224. I moved the calculations of wp2xp (wp2rtp and wp2thlp), wp4, and wpxp2 (wprtp2 — bmg2 / githubweb
  225. I added another function to the new PDF.  This function helps to calculate — bmg2 / githubweb
  226. I added a special case for the wpxp2 implicit code. — bmg2 / githubweb
  227. Back in clubb:r8409, the PDF component correlations of w and rt and w and — bmg2 / githubweb
  228. I added a subroutine that calculates the implicit and explicit portions of the — bmg2 / githubweb
  229. I renamed original_pdf.F90 as adg1_adg2_3d_luhar_pdf.F90. — bmg2 / githubweb
  230. I added statistical output for F_w, F_rt, F_thl, min_F_w, max_F_w, min_F_rt, — bmg2 / githubweb
  231. I split the new PDF into two files.  I added a new file that currently houses — bmg2 / githubweb
  232. I clipped temperature within the Goff-Gratch functions for saturation over liquid and ice. — Vince Larson / githubweb
  233. I initialized some output variables in order to prevent a runtime error. — bmg2 / githubweb
  234. I made a sub-driver level subroutine for the calculations necessary for a — bmg2 / githubweb
  235. I added code to allow the variable (of w, rt, or theta-l) with the greatest — bmg2 / githubweb
  236. I added calls to the functions and subroutines that calculate the implicit and — bmg2 / githubweb
  237. I changed coef_wp2xp_explicit (coef_wp2rtp_explicit and coef_wp2thlp_explicit) — bmg2 / githubweb
  238. I am adding a new file for the new trivariate skewness-dependent analaytic — bmg2 / githubweb
  239. I fixed a bug in the new Trivariate skewness-dependent analytic double Gaussian — bmg2 / githubweb
  240. In order for the TSDADG PDF to work correctly, when Skx * sgn( <w'x'> ) >= 0, — bmg2 / githubweb
  241. In order to clarify coding in CLUBB, I am moving a block of code that is — bmg2 / githubweb
  242. I am fixing a bug where rtp2 and thlp2 (and sclrp2) were not preserved when — bmg2 / githubweb
  243. I updated the TSDADG PDF by adding the responding variable description, the — bmg2 / githubweb
  244. When ADG1 or ADG2 are not used, we have to set alpha_rt, alpha_thl, and — bmg2 / githubweb
  245. I am calling the new TSDADG PDF from subroutine pdf_closure. — bmg2 / githubweb
  246. Clarity changes to the new TSDADG PDF. — bmg2 / githubweb
  247. I added some references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
  248. I added some references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
  249. I fixed a bug in the calculation of PDF component variances in the new TSDADG — bmg2 / githubweb
  250. I added more references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
  251. I added more references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
  252. I added more links to the CLUBB-SILHS overview tech doc. — Vince Larson / githubweb
  253. I have set the tunable parameters F_x and zeta_x to skewness functions for the — bmg2 / githubweb
  254. I needed to increase the limit of nvarmax_zt so that LBA (and other — bmg2 / githubweb
  255. I changed the URL references to the CLUBB-SILHS overview document. — Vince Larson / githubweb
  256. I changed the URL references to the CLUBB-SILHS overview document. — Vince Larson / githubweb
  257. Changed variable and subroutine names, see ticket 810 and 811 — hoc_browser / githubweb
  258. Changed variable and subroutine names, see ticket 810 and 811 — hoc_browser / githubweb
  259. I have added the Lewellen and Yoh (1993) PDF to CLUBB for testing and comparison — bmg2 / githubweb
  260. Fixed line length exceding 100 characters warnings — Gunther Huebler / githubweb
  261. Changed the arrangement of variables in the subroutine compute_mixing_length as well as calls to it clubb:ticket:815 — Gunther Huebler / githubweb
  262. Fixed lines exceeding 100 characters warnings clubb:ticket:815 — Gunther Huebler / githubweb
  263. I added an option to incorporate the buoyancy term into CLUBB's eddy diffusivity for momentum. — Vince Larson / githubweb
  264. I added c_K10 as a tuning parameter in front of the new momentum eddy diffusivity. — Vince Larson / githubweb
  265. Removed unused parameters to clear warnings clubb:ticket:803 — Gunther Huebler / githubweb
  266. Removed unused parameters to clear warnings clubb:ticket:803 — Gunther Huebler / githubweb
  267. I multiplied the eddy diffusivity for momentum by a skewness-dependent factor — Vince Larson / githubweb
  268. I changed the way that F_rt and F_thl are set in the new PDF.  They are now set — bmg2 / githubweb
  269. I changed the flag setting on the new PDF so that it always uses w as the setter — bmg2 / githubweb
  270. Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803 — Gunther Huebler / githubweb
  271. Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803 — Gunther Huebler / githubweb
  272. Improved binary search algorithm clubb:ticket:818 — Gunther Huebler / githubweb
  273. Added warning messages to function binary_search clubb:ticket:818 — Gunther Huebler / githubweb
  274. Removed unused variables causing warnings clubb:ticket:803 — Gunther Huebler / githubweb
  275. I updated the call to the new PDF so that Skrt and Skthl are intent INOUT — bmg2 / githubweb
  276. Removed many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803 — Gunther Huebler / githubweb
  277. I am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90.  This — bmg2 / githubweb
  278. I finished adding the units to the variable descriptions in — bmg2 / githubweb
  279. The calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>, — bmg2 / githubweb
  280. I added the tunable or adjustable parameters for the new PDF to CLUBB's list — bmg2 / githubweb
  281. Fixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803 — Gunther Huebler / githubweb
  282. I am committing a line of code that limits the adjusted correlation of rt and — bmg2 / githubweb
  283. I implemented a new method to handle cumulus momentum fluxes. — Vince Larson / githubweb
  284. Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804 — Gunther Huebler / githubweb
  285. Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804 — Gunther Huebler / githubweb
  286. Removed file anl_erf.F90, it is no longer used — Gunther Huebler / githubweb
  287. I am altering the solution to the wp3 predictive equation to calculate the — bmg2 / githubweb
  288. I fixed the problem with the wp3 budgets as a result of r8584.  The budgets in — bmg2 / githubweb
  289. I altered the names of the turbulent advection functions that are closed by — bmg2 / githubweb
  290. I added a couple comments about how the discretization of the turbulent — bmg2 / githubweb
  291. I added the function that sets up the implicit calculation of the wp3 turbulent — bmg2 / githubweb
  292. I added a function that calculates the explicit form of the wp3 turbulent — bmg2 / githubweb
  293. I am adding a function to calculate the turbulent advection of wpxp explicitly. — bmg2 / githubweb
  294. I am adding a function to calculate the turbulent advection of xp2 and xpyp — bmg2 / githubweb
  295. I interfaced the wp3 explicit turbulent advection code with CLUBB.  It is — bmg2 / githubweb
  296. I am interfacing the wpxp explicit turbulent advection option with the rest of — bmg2 / githubweb
  297. I fixed a small bug with the explicit turbulent advection option for wpxp. — bmg2 / githubweb
  298. I am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code. — bmg2 / githubweb
  299. I added the l_explicit_turbulent_adv_* family of flags to the new PDF, for some — bmg2 / githubweb
  300. I am packing up the implicit coefficients and explicit terms calculated by the — bmg2 / githubweb
  301. Made epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804 — Gunther Huebler / githubweb
  302. I made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90. — bmg2 / githubweb
  303. I have completed interfacing the implicit form of the wp3 turbulent advection — bmg2 / githubweb
  304. When the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advection — bmg2 / githubweb
  305. I cleaned up the Skx_module and added an additional function, — bmg2 / githubweb
  306. I fixed a bug in the calculation of scalar skewness.  It was being set to 0, — bmg2 / githubweb
  307. I moved the location of the LG 2005 ansatz to calculate xp3 because it would be — bmg2 / githubweb
  308. I reverted clubb:r8611 because (1) having the code in the other location — bmg2 / githubweb
  309. I have added a new function, term_ta_new_pdf_lhs, to — bmg2 / githubweb
  310. I have linked the implicit turbulent advection code for rtp2 and thlp2 to the — bmg2 / githubweb
  311. I have added a new file that has two options for handling the xp3 term for — bmg2 / githubweb
  312. I have interface the new xp3 code to the rest of CLUBB.  It can be turned on — bmg2 / githubweb
  313. I added a driver level subroutine for the new advance xp3 code.  This will make — bmg2 / githubweb
  314. I added budget stats for rtp3 and thlp3 to CLUBB. — bmg2 / githubweb
  315. I am adding code that allows the turbulent advection of wpxp to be treated — bmg2 / githubweb
  316. Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code. — Gunther Huebler / githubweb
  317. Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code. — Gunther Huebler / githubweb
  318. Various small comment removals and returned some functionality to api interface clubb:ticket:800 — Gunther Huebler / githubweb
  319. A variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800 — Gunther Huebler / githubweb
  320. This is the first part of a two-part change.  I am updating plotgen plots so — bmg2 / githubweb
  321. In part 2 of this two part commit, I have added rc_coef to the list of — bmg2 / githubweb
  322. Various debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800 — Gunther Huebler / githubweb
  323. Check negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800 — Gunther Huebler / githubweb
  324. I'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800 — Gunther Huebler / githubweb
  325. Changed calls to parameterization check to work with the new check negative implementation clubb:ticket:800 — Gunther Huebler / githubweb
  326. Gunther Huebler / githubweb
  327. Removed rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800 — Gunther Huebler / githubweb
  328. Changed error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800 — Gunther Huebler / githubweb
  329. Fixed unused variable warnings related to error code changes — Gunther Huebler / githubweb
  330. I am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to account — bmg2 / githubweb
  331. Added error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to  keep track of error messages is multithreaded scenarios clubb:ticket:800 — Gunther Huebler / githubweb
  332. In r8659, I accidentally overwrote some code.  This commit restores the prior — bmg2 / githubweb
  333. Sigh — bmg2 / githubweb
  334. Added clubb debug level checks to error checking statements clubb:ticket:800 — Gunther Huebler / githubweb
  335. Changed many stop commands to return commands and added more err_code checks clubb:ticket:800 — Gunther Huebler / githubweb
  336. Reverted api changes that broke SAM and WRF — Gunther Huebler / githubweb
  337. I am adding the semi-implicit formulation of wprtpthlp, which is the turbulent — bmg2 / githubweb
  338. I am adding output statistics for the implicit and semi-implicit coefficients — bmg2 / githubweb
  339. I corrected the units on a couple of implicit coefficients. — bmg2 / githubweb
  340. I fixed a bug. — bmg2 / githubweb
  341. Removed failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
  342. Removed reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
  343. I am fixing a bug with the CLUBB tuner.  Variables that were allocated at the — bmg2 / githubweb
  344. Completed the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800 — Gunther Huebler / githubweb
  345. Made all debug levels produce the same output, see clubb:ticket:823 — Gunther Huebler / githubweb
  346. I am moving type variable implicit_coefs_terms from new_pdf_main.F90 to — bmg2 / githubweb
  347. Modified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802 — Gunther Huebler / githubweb
  348. Added checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802 — Gunther Huebler / githubweb
  349. This should fix the thlm out of bounds error on clubb:ticket:828 — Gunther Huebler / githubweb
  350. I changed the name of type variable new_pdf_implct_coefs_terms to — bmg2 / githubweb
  351. Changed T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828 — Gunther Huebler / githubweb
  352. I added a flag option to clip the (large, negative) effects of microphysics on — bmg2 / githubweb
  353. I added a flag option to calculate the minimum threshold for xp2 (rtp2 and — bmg2 / githubweb
  354. I added a special max magnitude correlation for fluxes wprtp and wpthlp.  This — bmg2 / githubweb
  355. Made better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more information — Gunther Huebler / githubweb
  356. This commit sets C8b=0.02, changes the non-linear damping on wp3 — Vince Larson / githubweb
  357. Added a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829 — Gunther Huebler / githubweb
  358. I am adding a general purpose function for the turbulent advection of CLUBB's — bmg2 / githubweb
  359. I added/changed a couple comments for the rhs portion of the generalized — bmg2 / githubweb
  360. The turbulent advection file that handles turbulent advection for predictive — bmg2 / githubweb
  361. I added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, that — bmg2 / githubweb
  362. Whoops, I forgot to make wpxpyp_zm and xpyp intent (in). — bmg2 / githubweb
  363. Added functionality to make the  hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830 — Gunther Huebler / githubweb
  364. I am updating the code that advances predictive variances and covariances in — bmg2 / githubweb
  365. Renamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830 — Gunther Huebler / githubweb
  366. I am updating the code that advances predictive scalar fluxes (<w'x'>) in — bmg2 / githubweb
  367. As a first step toward having code that can clip mean values of hydrometeor — bmg2 / githubweb
  368. init_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562 — Gunther Huebler / githubweb
  369. I have now interfaced the subroutine that I made out of the code that clips — bmg2 / githubweb
  370. I have added a call to the subroutine that clips hydrometeor concentrations from — bmg2 / githubweb
  371. I added new code that clips the overall correlation of w and rt or the overall — bmg2 / githubweb
  372. I added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which are — bmg2 / githubweb
  373. Made clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800 — Gunther Huebler / githubweb
  374. Reverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800 — Gunther Huebler / githubweb
  375. Fixed nightly tests — Gunther Huebler / githubweb
  376. I have added code to allow C2 to be adjusted by multiplying by the greater of — bmg2 / githubweb
  377. I moved the location of the declaration and setting of new model flags to — bmg2 / githubweb
  378. Improved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834 — Gunther Huebler / githubweb
  379. Fixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834 — Gunther Huebler / githubweb
  380. Actually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
  381. Optimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
  382. Reverted stats_clubb_utilities, accidental commit — Gunther Huebler / githubweb
  383. This should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837 — Gunther Huebler / githubweb
  384. Vince Larson / githubweb
  385. Impoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834 — Gunther Huebler / githubweb
  386. This commit implements the effects of splatting on wp3. — Vince Larson / githubweb
  387. I am making the first step toward committing code that allows for the option — bmg2 / githubweb
  388. I added code to allow the option of predicting upwp and vpwp by using the — bmg2 / githubweb
  389. I took the liberty of upgrading CLUBB's PDF closure and related code to a vector — bmg2 / githubweb
  390. I updated the monotonic flux limiter to account for vector variables u and v. — bmg2 / githubweb
  391. I am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output. — bmg2 / githubweb
  392. In r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic flux — bmg2 / githubweb
  393. I am turning on the l_predict_upwp_vpwp code! — bmg2 / githubweb
  394. Improved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834 — Gunther Huebler / githubweb
  395. Improved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834 — Gunther Huebler / githubweb
  396. Changed the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834 — Gunther Huebler / githubweb
  397. Added grid_class to the dependency lists of the pdf files that were changed in commit 8773 — Gunther Huebler / githubweb
  398. Accidental commit, undoing 8783 — Gunther Huebler / githubweb
  399. I am changing the default setting of flags l_min_wp2_from_corr_wx and — Brian Griffin / githubweb
  400. Modified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834 — Gunther Huebler / githubweb
  401. Removed print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases. — Gunther Huebler / githubweb
  402. Changed the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834 — Gunther Huebler / githubweb
  403. I am adding source code for the introduction of budgets for predictive upwp — Brian Griffin / githubweb
  404. Improved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834 — Gunther Huebler / githubweb
  405. Improved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834 — Gunther Huebler / githubweb
  406. Modified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834 — Gunther Huebler / githubweb
  407. Copied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834 — Gunther Huebler / githubweb
  408. Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834 — Gunther Huebler / githubweb
  409. Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834 — Gunther Huebler / githubweb
  410. Improved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834 — Gunther Huebler / githubweb
  411. I made the surface splatting terms conservative.  That is, I subtracted from wp2_sfc — Vince Larson / githubweb
  412. I added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2. — Vince Larson / githubweb
  413. This commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero).  Hence it is BIT_CHANGING. — Vince Larson / githubweb
  414. Added functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834 — Gunther Huebler / githubweb
  415. Update advance_clubb_core_module.F90 — noreply / githubweb
  416. Update latin_hypercube_driver_module.F90 — noreply / githubweb
  417. I clipped sigma_sqd_w to prevent interpolated values of it — Vince Larson / githubweb
  418. I added a new option to diagnose the dissipation time scale, tau, first — Vince Larson / githubweb
  419. I found a new way to diagnose upthvp.  Instead of using a bound on correlations, it relies — Vince Larson / githubweb
  420. introducing error into clubb core for testing larson-group/sys_admin#533 — mcfadd34 / githubweb
  421. reverting error that was introduced larson-group/sys_admin#533 — mcfadd34 / githubweb
  422. I am briefly changing some of the flag and parameter settings in CLUBB — bmg2 / githubweb
  423. Revert "I am briefly changing some of the flag and parameter settings in CLUBB" — bmg2 / githubweb
  424. I am adding code that clips the sample point value of chi under — bmg2 / githubweb
  425. I have updated the SILHS code to omit the assert_consistent_cf_component — bmg2 / githubweb
  426. I added a couple of comments reminding users to change the conditions in — bmg2 / githubweb
  427. I added a couple of comments reminding users to change the conditions in — bmg2 / githubweb
  428. Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"" — bmg2 / githubweb
  429. Revert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""" — bmg2 / githubweb
  430. I committed a subroutine, diagnose_upxp, that calculates — Vince Larson / githubweb
  431. Improved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834 — Gunther Huebler / githubweb
  432. I am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a large — bmg2 / githubweb
  433. I am updating the code within setup_clubb_pdf_parameters.F90 in order to take — bmg2 / githubweb
  434. To diagnose uprcp using CLUBB's PDF machinery, — Vince Larson / githubweb
  435. Continuing with diagnosis of uprcp using CLUBB's PDF, — Vince Larson / githubweb
  436. More code to diagnose uprcp using CLUBB's PDF. — Vince Larson / githubweb
  437. Correction for the last uprcp-related commit: — Vince Larson / githubweb
  438. I am correcting the code so that the Nightly Uninitialized Variables Test — bmg2 / githubweb
  439. I am continuing to pull parts of setup_pdf_parameters outside of a large "do" — bmg2 / githubweb
  440. I am pulling statistical output subroutine pdf_param_ln_hm_stats outside — bmg2 / githubweb
  441. Changing the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope. — Gunther Huebler / githubweb
  442. commenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566 — mcfadd34 / githubweb
  443. uncommenting threadprivate larson-group/sys_admin#566 — mcfadd34 / githubweb
  444. I have changed the structure of setup_pdf_parameters so that the subroutine that — bmg2 / githubweb
  445. Returned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING. — Gunther Huebler / githubweb
  446. I am turning on the new calculation of uprcp that uses CLUBB's PDF. — Vince Larson / githubweb
  447. I modified the code in setup_clubb_pdf_params.F90 to use only one call to — bmg2 / githubweb
  448. I am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch to — bmg2 / githubweb
  449. I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch — bmg2 / githubweb
  450. I temporarily set l_clip_extreme_chi_sample_pts back to false in the — bmg2 / githubweb
  451. Revert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the" — bmg2 / githubweb
  452. The value of nz is passed into SILHS, so we don't need to use gr%nz. — bmg2 / githubweb
  453. I improved the error messages when LU decomp. fails within — bmg2 / githubweb
  454. Improved error message prints in advance_xm_wpxp. — bmg2 / githubweb
  455. I added improved LHS and RHS print statements when a LU decomp. error occurs — bmg2 / githubweb
  456. I added params_list to the list of variables that are accessible through — bmg2 / githubweb
  457. I am making the first step for updating the code that calculates sigma_sqd_w. — bmg2 / githubweb
  458. I added a log-law height dependence to the code that diagnoses — Vince Larson / githubweb
  459. I added fill_holes_hydromet_api to clubb_api_module.F90. — bmg2 / githubweb
  460. I added a new python script, check_for_missing_threadprivate.py, — Vince Larson / githubweb
  461. Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834 — Gunther Huebler / githubweb
  462. Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834 — Gunther Huebler / githubweb
  463. Fixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834 — Gunther Huebler / githubweb
  464. Added temp test file — noreply / githubweb
  465. Remove test file — noreply / githubweb
  466. Adding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical. — Gunther Huebler / githubweb
  467. Optimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases. — Gunther Huebler / githubweb
  468. ticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequency — guozhun / githubweb
  469. Modifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855 — Gunther Huebler / githubweb
  470. Replacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855 — Gunther Huebler / githubweb
  471. Making procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855 — Gunther Huebler / githubweb
  472. Missed one — Gunther Huebler / githubweb
  473. I have added a new file, calc_pressure.F90, which contains code for initializing — bmg2 / githubweb
  474. I updated CLUBB so that pressure is updated after mean fields have been — bmg2 / githubweb
  475. Removing gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855 — Gunther Huebler / githubweb
  476. Forgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855 — Gunther Huebler / githubweb
  477. issue #842 — guozhun / githubweb
  478. We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. — guozhun / githubweb
  479. We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842) — guozhun / githubweb
  480. Update advance_clubb_core_module.F90 — noreply / githubweb
  481. We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly) — guozhun / githubweb
  482. Efficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855 — Gunther Huebler / githubweb
  483. This should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855 — Gunther Huebler / githubweb
  484. An additional damping is added to the invrs_tau term in the C8 equation. ticket #842 — guozhun / githubweb
  485. Adding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations. — Gunther Huebler / githubweb
  486. We use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8. — guozhun / githubweb
  487. Changing ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855 — Gunther Huebler / githubweb
  488. Pulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855 — Gunther Huebler / githubweb
  489. Renaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855 — Gunther Huebler / githubweb
  490. Efficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855. — Gunther Huebler / githubweb
  491. Modifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855 — Gunther Huebler / githubweb
  492. Refactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855 — Gunther Huebler / githubweb
  493. Update advance_clubb_core_module.F90 — noreply / githubweb
  494. Update advance_clubb_core_module.F90 — noreply / githubweb
  495. I switched on direct diagnosis of tau rather than Lscale. — Vince Larson / githubweb
  496. I updated the pressure initialization for cases that use sounding that is given — bmg2 / githubweb
  497. I changed the function calculate_thvm from a pre-defined vector of size nz to — bmg2 / githubweb
  498. I updated the calculation of thvm in advance_clubb_core to use the — bmg2 / githubweb
  499. Adding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler. — Gunther Huebler / githubweb
  500. Adding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855 — Gunther Huebler / githubweb
  501. Changing where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626 — Gunther Huebler / githubweb
  502. I am committing a test where I changed subroutine ADG1_w_closure — bmg2 / githubweb
  503. Changing determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862 — Gunther Huebler / githubweb
  504. Finally fixing line length error in pdf_closure — Gunther Huebler / githubweb
  505. Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861 — Gunther Huebler / githubweb
  506. Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861 — Gunther Huebler / githubweb
  507. Adding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862 — Gunther Huebler / githubweb
  508. This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc. — guozhun / githubweb
  509. Update advance_helper_module.F90 — noreply / githubweb
  510. Update advance_clubb_core_module.F90 — noreply / githubweb
  511. Update advance_helper_module.F90 — noreply / githubweb
  512. Adding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626 — Gunther Huebler / githubweb
  513. I am adding a file for the new hybrid PDF, which combines the w equation set — bmg2 / githubweb
  514. I updated the function to calculate the implicit coefficient for the wp4 term, — bmg2 / githubweb
  515. I made some changes to new_hybrid_pdf.F90 so that it would compile in its — bmg2 / githubweb
  516. I edited that subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
  517. I updated the subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
  518. Replaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves. — nselke / githubweb
  519. I am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the new — bmg2 / githubweb
  520. I worked more the functions for the new hybrid PDF. — bmg2 / githubweb
  521. Refactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855 — Gunther Huebler / githubweb
  522. I changed all the PDF utility functions in pdf_utilities.F90 to elemental — bmg2 / githubweb
  523. I forgot a "then" to go with an "elseif". — bmg2 / githubweb
  524. Removed all use statements involving silhs flags from the SILHS files below the API level and putting the flags into the argument lists. — nselke / githubweb
  525. Adding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855 — Gunther Huebler / githubweb
  526. Adding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855 — Gunther Huebler / githubweb
  527. Refactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855 — Gunther Huebler / githubweb
  528. I am continuing to build the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
  529. I am continuing to work on the driver file for the new hybrid PDF. — bmg2 / githubweb
  530. I have completed the main parts of the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
  531. The code for the new hybrid PDF now compiles. — bmg2 / githubweb
  532. I added an entry for the new hybrid PDF. — bmg2 / githubweb
  533. I have added the new hybrid PDF to the G unit tests. — bmg2 / githubweb
  534. Mathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0. — bmg2 / githubweb
  535. I added code to interface the call to the new hybrid PDF with pdf_closure — bmg2 / githubweb
  536. I interfaced the implicit coefficients and explicit terms used in the turbulent — bmg2 / githubweb
  537. I fixed a small error.  The code compiles again now. — bmg2 / githubweb
  538. Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group — pbroels / githubweb
  539. Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group — pbroels / githubweb
  540. Pushing down loops over transform_uniform_samples_to_pdf and resolving many if statments beforehand by copying values to new arrays with an additional sample index. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  541. Replacing the lapack function with a simple loop to multiply a pdf_dim x pdf_dim array by a pdf_dim vector. The arrays are too small to justify using lapack. This ends up slightly faster and allows a lot more flexibility which is going to be needed shortly. This is BIT_CHANGING, but not answer changing. larson-group/clubb#869 — Gunther Huebler / githubweb
  542. I have added code that allows CLUBB to run interactively using the new hybrid — bmg2 / githubweb
  543. I am updating the subroutine that calculates PDF component means and standard — bmg2 / githubweb
  544. I placed proper thresholding on interpolated up2 and interpolated vp2 — bmg2 / githubweb
  545. I introduced the silhs_config_flags_type in clubb which now handles all SILHS config flags. — nselke / githubweb
  546. I added a limiter to keep the maximum magnitude of the correlations of — bmg2 / githubweb
  547. I upgraded Nc_Ncn_eqns.F90 to use elemental functions. — bmg2 / githubweb
  548. The new hybrid PDF also uses this bit of code that sets the correlation — bmg2 / githubweb
  549. I made modifications to the new hybrid PDF so that that calculation of F_w — bmg2 / githubweb
  550. Minor clean-up. Writing 'Intent(in)' in call to 'generate_uniform_sample_at_k_lh_start' and adding descriptions for input and output arguments in 'initialize_silhs_config_flags_type(_api)' and 'set_default_silhs_config_flags(_api)'. #856 — nselke / githubweb
  551. Fixed small typo I accidentally introduced in my last commit. — nselke / githubweb
  552. I added the ability to handle scalars interactively to the new hybrid PDF. — bmg2 / githubweb
  553. I found a couple of spots in the new hybrid PDF where I needed to add — bmg2 / githubweb
  554. I added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90. — bmg2 / githubweb
  555. The variable type implicit_coefs_terms needs to be made public — bmg2 / githubweb
  556. I changed the value of the coefficient in the F_w equation to 0.45 — bmg2 / githubweb
  557. I am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_core — bmg2 / githubweb
  558. Replacing algorithm that calculates the inverse CDF. It's only accurate to single precision, so the uniform samples are clipped to be within a valid range for the algorithm to always be accurate. This is BIT_CHANGING for silhs enabled cases, but plots are visibly identical for rico_silhs. larson-group/clubb#869 — Gunther Huebler / githubweb
  559. I have added a print subroutine for the SILHS configurable flags. #856 — nselke / githubweb
  560. I have started the process of adding the coding infrastructure — bmg2 / githubweb
  561. I have completed the addition of the ability to use different up2 — bmg2 / githubweb
  562. I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856 — nselke / githubweb
  563. I made the l_calc_w_corr code (turned off by default) run again by — bmg2 / githubweb
  564. I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute. — nselke / githubweb
  565. I have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac', — nselke / githubweb
  566. I continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm', — nselke / githubweb
  567. I continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm', — nselke / githubweb
  568. Adding more clipping to the uniform sample values, and reducing the treshold. This is BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
  569. I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp', — nselke / githubweb
  570. I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp', — nselke / githubweb
  571. Changing values to use core_rknd precision. larson-group/clubb#869 — Gunther Huebler / githubweb
  572. Cleaning up clip_transform_silhs_output and removing the X_nl_all_levs_raw variable. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  573. Changing X_nl_all_levs to inout in clip_transform_silhs_output_api, this was missed in the last commit. larson-group/clubb#869 — Gunther Huebler / githubweb
  574. Finished altering argument lists. This commit covers the final seven flags, which are in different namelists. — nselke / githubweb
  575. Finished altering argument lists. This commit covers the final seven flags, which are in different namelists. — nselke / githubweb
  576. Pushing a loop down and other small performance refactorings. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  577. I introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type. — nselke / githubweb
  578. I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856 — nselke / githubweb
  579. I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856 — nselke / githubweb
  580. I have removed the 'rc_estimate' subroutine in 'src/SILHS/est_kessler_microphys_module.F90' because it was not working properly. I changed the 'autoconv_estimate' subroutine in the same file to be able to calculate both 'lh_AKm' and 'lh_rcm_avg' with it. I renamed that subroutine to 'calc_estimate'. #692 — nselke / githubweb
  581. I fed pdf_params_frz into subroutine advance_clubb_core — Vince Larson / githubweb
  582. Adding error code to arguement list of non-api routines where it was included in the api version. — Gunther Huebler / githubweb
  583. Moving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal. — Gunther Huebler / githubweb
  584. Added use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public. — Steffen Domke / githubweb
  585. I have fixed the warnings for lines exceeding 100 characters. — nselke / githubweb
  586. I have fixed the warnings for lines exceeding 100 characters. — nselke / githubweb
  587. Passing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity. — Gunther Huebler / githubweb
  588. Adding GPU code to portion of SILHS, and refactoring minor aspects of code structure. larson-group/clubb#869 — Gunther Huebler / githubweb
  589. Removing problems. This should fix the compiler error. — Gunther Huebler / githubweb
  590. Making subroutine to generate random samples and weights on CPU's, this will be accompanied by one for GPU's shortly. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  591. Simplifiying call trees a bit, removing unused procedures, and creating a random pool to be used where random numbers were being used. This pool allows all randoms to be generated at the same time, which is better for CPUs and (as far as I know) the only decent way to do this on GPUs. Becuase of the different random numbers, this is BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
  592. Trivial update to test if cams autoupdate works — noreply / githubweb
  593. Changing clipping of uniform samples. This is the same fix from commit afe34fb444a47aa4cb8bcc8b9cbcaeceb0539c9f, but was accidentally reverted in commit 766a5934a8352a556ed5ba2cfeac6aa547f76f86. larson-group/clubb#869 — Gunther Huebler / githubweb
  594. Commiting a space, because the last commit, be3699d840ed6bc3ff52dc5d397a74767ecdc414, is BIT_CHANGING. — Gunther Huebler / githubweb
  595. Simplifying call tree some more, moving around where calculations are done so that GPU code doesn't have to be interrupted with data copies or CPU code. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  596. Lots of GPUizing and reorganizing calls. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  597. Revert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch" — bmg2 / githubweb
  598. Moving sample point clipping to after the sampling drivers, rather than immediately after generate_uniform_lh_sample. This was causing sample points to end up out of range when compiling in single precision, which is why the nightly tests were failing for PGI. This should be BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
  599. I placed E3SM preprocessor commands around E3SM-specific code in — bmg2 / githubweb
  600. Restoring assertion check for the vertical correlation calculation. larson-group/clubb#869 — Gunther Huebler / githubweb
  601. Changing the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869 — Gunther Huebler / githubweb
  602. I added E3SM's clubb_ parameters that can be read in from the — bmg2 / githubweb
  603. I added the remainder the clubb_ terms that were added previously to — bmg2 / githubweb
  604. Changing error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869 — Gunther Huebler / githubweb
  605. Small updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  606. Redoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  607. Adding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
  608. Simple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
  609. Small performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  610. Removing lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869 — Gunther Huebler / githubweb
  611. Update latin_hypercube_driver_module.F90 — noreply / githubweb
  612. Update parameters_tunable.F90 — noreply / githubweb
  613. GPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  614. Making some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  615. I changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874 — nselke / githubweb
  616. I added the new l_update_pressure configurable flag to clubb_config_flags. — bmg2 / githubweb
  617. I added some code I used in the special input fields branch to make — bmg2 / githubweb
  618. An improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875] — guozhun / githubweb
  619. I revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874. — nselke / githubweb
  620. I got rid of the "allocatable", "allocate", and "deallocate" statements — bmg2 / githubweb
  621. I placed an ifndef CLUBB_CAM preprocessor flag around the code in — bmg2 / githubweb
  622. I reduced the minimum possible value of lmin from 4.0 to 1.0. — noreply / githubweb
  623. I made a print/write statement debug level 3 — noreply / githubweb
  624. I made a second print/write statement debug level 3 — noreply / githubweb
  625. I fix a print/write statement debug level3. For #755 and #800 — guozhun / githubweb
  626. I am replacing the "use" statements that referenced — bmg2 / githubweb
  627. I "brought back the stats" by passing the stats from advance_clubb_core — bmg2 / githubweb
  628. Removing the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref) — bmg2 / githubweb
  629. Results were changed yesterday for some cases because thlprcp was — bmg2 / githubweb
  630. I have resolved all the issues surrounding recent CLUBB commits that — bmg2 / githubweb
  631. I removed code that stops a run if the output time step is less than a minute. — noreply / githubweb
  632. I removed references to variables_prognostic_module and — bmg2 / githubweb
  633. Fixed a boo-boo. — bmg2 / githubweb
  634. I set `l_diag_Lscale_from_tau = .true.` in source code — noreply / githubweb
  635. I removed references to variable_diagnostic_module for various Kessler — bmg2 / githubweb
  636. I removed the reference to use variables_diagnostic_module for Kh_zm — bmg2 / githubweb
  637. Removed a reference to variables_diagnostic_module for Kh_zm in — bmg2 / githubweb
  638. I am able to remove references to variables_prognostic_module and — bmg2 / githubweb
  639. I removed the l_use_ice_latent flag from the code, and along with it — bmg2 / githubweb
  640. I have completed the project of removing variables_prognostic_module — bmg2 / githubweb
  641. I added some missing threadprivate statements — noreply / githubweb
  642. I have taken the code from wp2_term_ta_all and placed it in the subroutine — bmg2 / githubweb
  643. I am updating wp3_term_ta_new_pdf_lhs to use the optimized code from — bmg2 / githubweb
  644. This commit is BIT_CHANGING.  It makes the parameter values in parameters_tunable.F90 agree with those in tunable_parameters.in — benjamin.andrew.stephens / githubweb
  645. I am making the change of using tau_wp2_zm to damp up2 and vp2, — bmg2 / githubweb
  646. I have added the integer flags iiPDF_type and ipdf_call_placement — bmg2 / githubweb
  647. I am going to make primary PDF type options and primary PDF call — bmg2 / githubweb
  648. I added E3SM customizations to CLUBB's master branch.  This is meant — bmg2 / githubweb
  649. I am updating the clubb_ list of namelist parameters used in E3SM — bmg2 / githubweb
  650. Typo — bmg2 / githubweb
  651. Fixed more typos — bmg2 / githubweb
  652. I am changing the new hybrid PDF's calculation of F_w to use — bmg2 / githubweb
  653. I updated the xp3 calculation for PDF types other than ADG1. — bmg2 / githubweb
  654. This xp3_coef_ parameters produce new hybrid PDF results similar to the old — bmg2 / githubweb
  655. I added the 2 new parameters in the simple xp3 equation (for PDF — bmg2 / githubweb
  656. I have combined the wp3_term_ta_ADG1_lhs and wp3_term_ta_ADG1_lhs_all — bmg2 / githubweb
  657. I added the partially upwinded implementation of the wp3 turbulent advection — bmg2 / githubweb
  658. Removed unused module imports — isenfireldc / githubweb
  659. Removed unused module imports — isenfireldc / githubweb
  660. Removed a comma that I missed while removing unused imports (#878) — isenfireldc / githubweb
  661. I am adding l_partial_upwind_wp3 to the list of clubb_config_flags. — bmg2 / githubweb
  662. Deprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129 — Gunther Huebler / githubweb
  663. I started the process of paring 2 subprograms back down to 1 in — bmg2 / githubweb
  664. I pared two more sets of equivalent subprograms down to 1 (each). — bmg2 / githubweb
  665. Paring down 2 equivalent subprograms to 1 again. — bmg2 / githubweb
  666. I condensed two more sets of doubled subprograms down to 1 (each) — bmg2 / githubweb
  667. Reduced two more sets of "doubled" subprograms down. — bmg2 / githubweb
  668. Updating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129 — Gunther Huebler / githubweb
  669. Adding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129 — Gunther Huebler / githubweb
  670. I updated CLUBB's copyright date range. — noreply / githubweb
  671. Adding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129 — Gunther Huebler / githubweb
  672. Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
  673. Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
  674. Taking more duplicated subprograms and paring them down to 1. — bmg2 / githubweb
  675. Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
  676. Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
  677. Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
  678. Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
  679. Removed styleguide violations from my code — isenfireldc / githubweb
  680. Fixed a backwards epsilon comparison from 8e8e71e — isenfireldc / githubweb
  681. Removed the "doubling" of the remainder of the subprograms from — bmg2 / githubweb
  682. Changing epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878 — Gunther Huebler / githubweb
  683. Small changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129 — Gunther Huebler / githubweb
  684. Changed the length of solve_type_str to 20 [-Wcharacter-trucation] — isenfireldc / githubweb
  685. Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
  686. Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
  687. Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
  688. Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
  689. I have tidied up advance_wp2_wp3_module.F90, and I have removed all doubled — bmg2 / githubweb
  690. Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
  691. Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
  692. I handled the "doubled" subprograms in turbulent_adv_pdf.F90. — bmg2 / githubweb
  693. Making change explained in larson-group/clubb#878 — Gunther Huebler / githubweb
  694. Removed some unused variables (ifort) — isenfireldc / githubweb
  695. Removed some unused variables (ifort) — isenfireldc / githubweb
  696. Adding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129 — Gunther Huebler / githubweb
  697. Removed unused import [-Wunused-variable] — isenfireldc / githubweb
  698. Removes unused function calc_cloud_frac [-Wunused-function] — isenfireldc / githubweb
  699. Fixes style issue — isenfireldc / githubweb
  700. Removed import without only as it was unused — isenfireldc / githubweb
  701. Adds mpishorthand back with only, it appears to be used somewhere — isenfireldc / githubweb
  702. I have pared two subprograms down to one again, this time for the — bmg2 / githubweb
  703. I pared down subprogram pairs again, this time for mean advection. — bmg2 / githubweb
  704. I added altitude_threshold to the list of CLUBB's tunable parameters. — bmg2 / githubweb
  705. Updating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots. — strike / githubweb
  706. Updating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be). — strike / githubweb
  707. Adds more debug lines — isenfireldc / githubweb
  708. Removes debug lines — isenfireldc / githubweb
  709. Adds debug lines and changes format — isenfireldc / githubweb
  710. Modifies debug line — isenfireldc / githubweb
  711. Modifies debug line — isenfireldc / githubweb
  712. Initialize ncf%ntimes to 0 when opening netcdf for writing — isenfireldc / githubweb
  713. Removes debug lines — isenfireldc / githubweb
  714. Changes length of units variable in stat_file_module from 20 to 25 — isenfireldc / githubweb
  715. This commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true.  A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines. — benjamin.andrew.stephens / githubweb
  716. Adding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close.  This will aid in implementing the SILHS 2D output subroutines in host models.  The new API subroutines necessitated some minor changes in clubb_driver.F90 as well.  Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo). — benjamin.andrew.stephens / githubweb
  717. I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
  718. I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
  719. This commit primarily overhauls the way the 2D SILHS samples are output to netCDF.  Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file.  Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
  720. This commit primarily overhauls the way the 2D SILHS samples are output to netCDF.  Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file.  Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
  721. Undoing accidental find and replace. larson-group/cam#129 — Gunther Huebler / githubweb
  722. Updated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832 — nchief / githubweb
  723. Fix super serious 1 character bug that broke all of the things — strike / githubweb
  724. I am committing Zhun's changes to the CLUBB portion of his — bmg2 / githubweb
  725. Update stats_zm_module.F90 — noreply / githubweb
  726. I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max — bmg2 / githubweb
  727. I connected the new tunable parameters to advance_helper_module.F90. — bmg2 / githubweb
  728. I added l_use_shear_Richardson to CLUBB's configurable model flags. — bmg2 / githubweb
  729. Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp.  This is intended to help smooth high-frequency oscillations.  Flag is set to false by default so has no impact on standard runs. — benjamin.andrew.stephens / githubweb
  730. In order to prevent dycoms2_rf02_so from crashing, — Vince Larson / githubweb
  731. I updated the recording of the budget terms for upwp_pr4 and vpwp_pr4. — Vince Larson / githubweb
  732. Adding the smooth_min and smooth_max functions to the repo.  These are not yet implemented in CLUBB but are now available for use and testing. See issue #894. — benjamin.andrew.stephens / githubweb
  733. Adding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions.  See issue #894. — benjamin.andrew.stephens / githubweb
  734. Modifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129 — Gunther Huebler / githubweb
  735. This commit replaces division by tau with multiplication by inverse tau in most cases.  It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files.  Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine. — benjamin.andrew.stephens / githubweb
  736. I am committing a bug fix to the invrs_tau_zm equation that was — bmg2 / githubweb
  737. CLUBB and pyplotgen changes: — benjamin.andrew.stephens / githubweb
  738. I fixed the LMM stepping bug that was affecting E3SM (because — bmg2 / githubweb
  739. Fixed alignment. — bmg2 / githubweb
  740. This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code.  The primary code changes are in advance_clubb_core_module.F90. — benjamin.andrew.stephens / githubweb
  741. Update parameter_indices.F90 — noreply / githubweb
  742. Update model_flags.F90 — noreply / githubweb
  743. Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3).  See issue #884. — benjamin.andrew.stephens / githubweb
  744. Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced.  See https://github.com/larson-group/clubb/issues/901. — benjamin.andrew.stephens / githubweb
  745. I am now passing vert_decorr_coef into SILHS instead of involving — bmg2 / githubweb
  746. This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39).  Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before.  I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up). — benjamin.andrew.stephens / githubweb
  747. Adding a test to make sure new C_uu_buoy parameter is within the valid range. See #901. — benjamin.andrew.stephens / githubweb
  748. This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb".  The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. — benjamin.andrew.stephens / githubweb
  749. This will allow for a better interface of SILHS parameter — bmg2 / githubweb
  750. Fixed a preprocessor command. — bmg2 / githubweb
  751. I'm adding the api entry for read_silhs_parameters, called — bmg2 / githubweb
  752. Revert "I'm adding the api entry for read_silhs_parameters, called" — bmg2 / githubweb
  753. Revert "Fixed a preprocessor command." — bmg2 / githubweb
  754. Revert "This will allow for a better interface of SILHS parameter" — bmg2 / githubweb
  755. I updated silhs_api_module so that vert_decorr_coef is publically available — bmg2 / githubweb
  756. Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code.  The flag is set to false by default so results are unaffected.  See #902. — benjamin.andrew.stephens / githubweb
  757. Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. — benjamin.andrew.stephens / githubweb
  758. Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129 — Gunther Huebler / githubweb
  759. Update parameters_tunable.F90 — noreply / githubweb
  760. Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129 — Gunther Huebler / githubweb
  761. Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129 — Gunther Huebler / githubweb
  762. Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
  763. Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
  764. Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch.  See #902. — 59519056+bstephens82 / githubweb
  765. Turning on wp3 pr_turb term. — benjamin.andrew.stephens / githubweb
  766. Changed the variable up2_vp2_factor to up2_sfc_coef in all files — rhodesk / githubweb
  767. I added an option to improve dry, convecting boundary layers. — Vince Larson / githubweb
  768. This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2.  In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1.  This makes the terms in these equations more consistent with the terms in the wp2 equation.  I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped). — Vince Larson / githubweb
  769. Changed surface to sfc in all instances where requested — rhodesk / githubweb
  770. Undid sfc change in stats_sfc_module.F90 — noreply / githubweb
  771. Undid sfc change to grid_class.F90 — noreply / githubweb
  772. Undid sfc change in numerical_check.F90 — noreply / githubweb
  773. Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129 — Gunther Huebler / githubweb
  774. Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  775. Fixed typo bug. larson-group/cam#129 — Gunther Huebler / githubweb
  776. Pushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  777. More pushing loops down. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  778. More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  779. More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  780. Adding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129 — Gunther Huebler / githubweb
  781. More loop pushing, all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  782. Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions. — Gunther Huebler / githubweb
  783. Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled. — Gunther Huebler / githubweb
  784. Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129 — Gunther Huebler / githubweb
  785. Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  786. Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  787. Performance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  788. Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  789. Reducing operations. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  790. Adding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  791. Some small cleanup, all just formatting. larson-group/cam#129 — Gunther Huebler / githubweb
  792. Changed ustar from an array to a scalar issue #909 — rhodesk / githubweb
  793. Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909 — rhodesk / githubweb
  794. Created new subroutine and ensured it's BFB. All cases run sucessfully #909 — rhodesk / githubweb
  795. added in missing flag which was causing memory errors #909 — rhodesk / githubweb
  796. confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909 — rhodesk / githubweb
  797. Update stats_zm_module.F90 — noreply / githubweb
  798. Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129 — Gunther Huebler / githubweb
  799. Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  800. Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  801. Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  802. Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129 — Gunther Huebler / githubweb
  803. Reformatted mixing length to be more compliant with the coding standard #909 — rhodesk / githubweb
  804. added a reference to new subroutine #909 — rhodesk / githubweb
  805. Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
  806. Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
  807. Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
  808. Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
  809. Pushing loops related to pdf_params down. larson-group/cam#129 — Gunther Huebler / githubweb
  810. clubb warnings introduced from merge have been removed #909 — rhodesk / githubweb
  811. Changed safeguard threshold in sigma_sqd_w. — rhodesk / githubweb
  812. Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. — 59519056+bstephens82 / githubweb
  813. Adding new coefficient to control the wp3 pressure diffusion term. — 59519056+bstephens82 / githubweb
  814. Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. — 59519056+bstephens82 / githubweb
  815. Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. — 59519056+bstephens82 / githubweb
  816. Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). — 59519056+bstephens82 / githubweb
  817. These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. — 59519056+bstephens82 / githubweb
  818. Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form.  This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. — 59519056+bstephens82 / githubweb
  819. Added intent comments for the following files: — rhodesk / githubweb
  820. Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core.  Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs).  This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated. — benjamin.andrew.stephens / githubweb
  821. Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90. — benjamin.andrew.stephens / githubweb
  822. Fixed comment regarding wp3 splatting term. — benjamin.andrew.stephens / githubweb
  823. Added intent comments. — rhodesk / githubweb
  824. Added intent comments. — rhodesk / githubweb
  825. Added intent comments for advance_xp2_xpyp_module.F90. — rhodesk / githubweb
  826. Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface. — 59519056+bstephens82 / githubweb
  827. Deleting comments around the old "magic number" for the near-surface clipping. — 59519056+bstephens82 / githubweb
  828. Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928. — Gunther Huebler / githubweb
  829. Changed some elements of clubb to allow for better script execution — rhodesk / githubweb
  830. Fixed clubb not compiling — rhodesk / githubweb
  831. Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
  832. Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
  833. Reverted changes to clubb_api. For #886 — rhodesk / githubweb
  834. Replacing use gr statements with feeding gr throught the arg list. — rhodesk / githubweb
  835. Adding proper indentation to needed files. — rhodesk / githubweb
  836. Fixing spacing issue on blank lines. #886 — rhodesk / githubweb
  837. Fixed comment changes. #886 — rhodesk / githubweb
  838. Fixed incorrect spacing on use — rhodesk / githubweb
  839. Revert "Fixed incorrect spacing on use" — rhodesk / githubweb
  840. Fixed spacing — rhodesk / githubweb
  841. Fixed spacing going too far — rhodesk / githubweb
  842. Fixed comments being pushed over — rhodesk / githubweb
  843. Fixed not all variables being indented properly — rhodesk / githubweb
  844. Fixed indentation going beyond variables — rhodesk / githubweb
  845. Fixed file_functions indentation being off — rhodesk / githubweb
  846. Fixed indentation on operations being wrong — rhodesk / githubweb
  847. Reverted incorrect changes to new_pdf and new_hybrid_pdf — rhodesk / githubweb
  848. Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
  849. Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
  850. Removing gr as a module variable from grid_class. — rhodesk / githubweb
  851. Removing gr as a module variable from grid_class. — rhodesk / githubweb
  852. Fixing typo in stats_zm_module.F90.  Background:  Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases.  It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit.  This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced.  However, since the budget balance test still found the variable, it kept passing successfully.  This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format. — benjamin.andrew.stephens / githubweb
  853. Fixing a typo from an earlier commit. — noreply / githubweb
  854. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  855. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  856. Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB. — rhodesk / githubweb
  857. The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken. — rhodesk / githubweb
  858. Add error header for CLUBB in CAM — noreply / githubweb
  859. Fixing the ordering of gr in the clubb_api arg list for affected subroutines. — rhodesk / githubweb
  860. Fixing coding standard violations — rhodesk / githubweb
  861. Improving error messages in setup_clubb_core. larson-group/e3sm#38 — Gunther Huebler / githubweb
  862. Feeding stats variables through the argument lists of needed subroutines. — 72510114+RhodesKeegan / githubweb
  863. Fixing spacing issues along with placing the stats varibales on their own lines. — 72510114+RhodesKeegan / githubweb
  864. Changing more subroutines to include stats vars in their arg lists. — 72510114+RhodesKeegan / githubweb
  865. Fixing incorrect subroutine arg list — 72510114+RhodesKeegan / githubweb
  866. Fixing host models not compiling. — 72510114+RhodesKeegan / githubweb
  867. Fixing argument list so that way the coding standard is upheld. — 72510114+RhodesKeegan / githubweb
  868. I changed the name to calc_responder_driver because I thought that — bmg2 / githubweb
  869. Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978.  Related to #920. — 59519056+bstephens82 / githubweb
  870. Fixing comment for the wp2_term_pr_dfsn subroutine.  Related to #920. — 59519056+bstephens82 / githubweb
  871. Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. — 59519056+bstephens82 / githubweb
  872. Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues.  Related to #920. — 59519056+bstephens82 / githubweb
  873. Fixing some comments. — 59519056+bstephens82 / githubweb
  874. Correcting a typo bug and adding some descriptive comments to two new variables.  This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. — benjamin.andrew.stephens / githubweb
  875. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
  876. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
  877. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  878. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  879. Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation.  Related to #920. — 59519056+bstephens82 / githubweb
  880. Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine.  Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. — 59519056+bstephens82 / githubweb
  881. Removing l_interp_prescribed_params from setup_clubb_pdf_params. — rhodesk / githubweb
  882. Adding comments labeling subroutine calls with intent. — rhodesk / githubweb
  883. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
  884. Removing unnecessary constant from use statement — noreply / githubweb
  885. Eliminating l_nu_grid_dependent as requested. — rhodesk / githubweb
  886. Eliminating l_use_buoy_mod_Km_zm. — rhodesk / githubweb
  887. Eliminating l_iter_xp2_xpyp flag. — rhodesk / githubweb
  888. Eliminating l_apply_rule_to_pdf_params flag. — rhodesk / githubweb
  889. Eliminating l_ub_const_deriv flag. — rhodesk / githubweb
  890. Eliminating l_equation_21 flag. — rhodesk / githubweb
  891. Eliminating l_wp3_2nd_buoyancy flag. — rhodesk / githubweb
  892. Eliminating l_refine_grid_in_cloud and l_interactive_refined. — rhodesk / githubweb
  893. Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds — rhodesk / githubweb
  894. Eliminating l_use_wp3_pr3 flag. — rhodesk / githubweb
  895. Eliminating l_clip_semi_implicit flag. — rhodesk / githubweb
  896. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
  897. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  898. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  899. Eliminating l_include_ice and sat_ice_ratio. — rhodesk / githubweb
  900. Eliminating l_update_pressure flag. — rhodesk / githubweb
  901. Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
  902. Updating the surface clipping coefficient... — noreply / githubweb
  903. Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb
  904. Removing a couple of unused parameters from use statement. — noreply / githubweb
  905. Pushing k loop down through clip_variance_level. — rhodesk / githubweb
  906. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. — 59519056+bstephens82 / githubweb
  907. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. — 59519056+bstephens82 / githubweb
  908. Updating some comments related to the tuner updates. — 59519056+bstephens82 / githubweb
  909. I have passed clubb_params down into advance_xm_wpxp_module.F90. — bmg2 / githubweb
  910. Adding space to trigger autoupdate. larson-group/sys_admin#755 — Gunther Huebler / githubweb
  911. Remove space to trigger autoupdate. larson-group/sys_admin#755 — noreply / githubweb
  912. Add space to trigger nightly tests.  For larson-group/sys_admin#755. — noreply / githubweb
  913. See ticket — jan.gruenenwald / githubweb
  914. I am fixing a bug that was introduced in 6b0348e, where the logical — bmg2 / githubweb
  915. I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. — bmg2 / githubweb
  916. added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — jan.gruenenwald / githubweb
  917. Updates to separate out C4 and C14 in advance_xp2 module.  This will make it easier to control which invrs_tau_* variable multiplies each term for example. — 59519056+bstephens82 / githubweb
  918. Changing the name of dummy_1d variables for clarity. — 59519056+bstephens82 / githubweb
  919. I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 — bmg2 / githubweb
  920. Add a blank line to trigger nightly tests. — noreply / githubweb
  921. Passing down more of CLUBB's tunable parameters. — bmg2 / githubweb
  922. I accidentally removed an important comment in the previous commit. — bmg2 / githubweb
  923. Passing down more CLUBB tunable parameters. — bmg2 / githubweb
  924. More passing down CLUBB parameters ... whoop-de-doo — bmg2 / githubweb
  925. Passing down more tunable parameters and removing references to — bmg2 / githubweb
  926. Removing line to trigger the nightly tests for all repos. — noreply / githubweb
  927. See respective messages on the issue 958 on date 10/12/2021 — jan.gruenenwald / githubweb
  928. Handling the abomination that is lmin. — bmg2 / githubweb
  929. Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix.  I included comments to describe why this was done.  Results are b4b. — benjamin.andrew.stephens / githubweb
  930. Passing tunable parameters into the new tau code. — bmg2 / githubweb
  931. Passed down more parameters. Results are bit-for-bit. — bmg2 / githubweb
  932. Passing through more clubb parameters. Bit-for-bit — bmg2 / githubweb
  933. Passing down CLUBB's tunable parameters into the setup_pdf_parameters and — bmg2 / githubweb
  934. These updates incorporate some of Shixuan Zhang's changes, including: — benjamin.andrew.stephens / githubweb
  935. Passing down CLUBB's tunable parameters into the remainder of the — bmg2 / githubweb
  936. I passed down the forgotten thlp2_rad_coef tunable parameter. — bmg2 / githubweb
  937. Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test.  I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. — benjamin.andrew.stephens / githubweb
  938. I am passing down the forgotten parameter, altitude threshold, in — bmg2 / githubweb
  939. Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3.  Relevant to CLUBB issue #920. — 59519056+bstephens82 / githubweb
  940. Updates as requested to the l_use_tke_in_K_dfsn code: — 59519056+bstephens82 / githubweb
  941. I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
  942. I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
  943. Adding an option to use invrs_tau_N2_iso for C4 terms.  The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233).  The flag is currently set to false so results will be b4b. — 59519056+bstephens82 / githubweb
  944. Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion.  This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. — 59519056+bstephens82 / githubweb
  945. Adding comments for clarity. — 59519056+bstephens82 / githubweb
  946. I forgot to add this necessary subroutine call to the clubb API. — bmg2 / githubweb
  947. Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690.  There was some overcounting of the relevant terms. — benjamin.andrew.stephens / githubweb
  948. I have turned the nu_vert_res_dep family of variables into a derived — bmg2 / githubweb
  949. Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — jan.gruenenwald / githubweb
  950. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — jan.gruenenwald / githubweb
  951. Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — jan.gruenenwald / githubweb
  952. fixed a typo in pdf_closure_module.f90, line 1284 — jan.gruenenwald / githubweb
  953. See ticket — 68997723+JanGrn / githubweb
  954. added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — 68997723+JanGrn / githubweb
  955. See respective messages on the issue 958 on date 10/12/2021 — 68997723+JanGrn / githubweb
  956. Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — 68997723+JanGrn / githubweb
  957. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — 68997723+JanGrn / githubweb
  958. Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — 68997723+JanGrn / githubweb
  959. fixed a typo in pdf_closure_module.f90, line 1284 — 68997723+JanGrn / githubweb
  960. Passing w_up_in_cloud out of advance_clubb_core — bmg2 / githubweb
  961. fixed compiler warning regarding w_up_in_cloud — jan.gruenenwald / githubweb
  962. Remove clipping from a3_coef. — noreply / githubweb
  963. These changes allow you to call the 4 clubb "advance" subroutines in any — Brian Griffin / githubweb
  964. Placing the order variables in a nice, convenient place for testing use. — Brian Griffin / githubweb
  965. I reordered advance_clubb_core so that the "Advance xp3" (which is a — Brian Griffin / githubweb
  966. I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx — Brian Griffin / githubweb
  967. I am indenting the portion of the code where the advance subroutines — Brian Griffin / githubweb
  968. Temporarily commenting out the idiot proofing in order to run some tests ... — Brian Griffin / githubweb
  969. Now official reinstating the idiot-proofing and turning off the — bmg2 / githubweb
  970. I am committing some idiot proofing in regards to the advance — bmg2 / githubweb
  971. Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. — bmg2 / githubweb
  972. Now that uprcp and vprcp have been passed through advance_clubb_core, — bmg2 / githubweb
  973. I am adding more arguments to the argument list for advance_clubb_core — bmg2 / githubweb
  974. Insert print about overwriting default flags with namelist values — noreply / githubweb
  975. Insert print about overwriting default parameters with namelist values — noreply / githubweb
  976. Making api version of setup_grid. larson-group/clubb#972 — Gunther Huebler / githubweb
  977. Making some paramters_silhs variables available from the silhs api — Gunther Huebler / githubweb
  978. Comment out setting of fatal error — noreply / githubweb
  979. This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. — Gunther Huebler / githubweb
  980. Changing the value of C_invrs_tau_shear from 0.02 to 0.15. — bmg2 / githubweb
  981. Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. — Gunther Huebler / githubweb
  982. Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that — bmg2 / githubweb
  983. Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm — noreply / githubweb
  984. Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 — Gunther Huebler / githubweb
  985. Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 — Gunther Huebler / githubweb
  986. Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 — Gunther Huebler / githubweb
  987. Breaking up column loop in advance_clubb_core. larson-group/clubb#972 — Gunther Huebler / githubweb
  988. Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
  989. I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence — bmg2 / githubweb
  990. Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
  991. Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 — Gunther Huebler / githubweb
  992. Making a commit that officially places the call to the PDF in the "post" — bmg2 / githubweb
  993. Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 — Gunther Huebler / githubweb
  994. Forgot an & symbol. — Gunther Huebler / githubweb
  995. We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 — Gunther Huebler / githubweb
  996. I am updating ice_supersat_frac to be an intent(inout) variable for — bmg2 / githubweb
  997. Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 — Gunther Huebler / githubweb
  998. Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 — Gunther Huebler / githubweb
  999. Pushing column index into zm2zt and zt2zm. larson-group/clubb#972 — Gunther Huebler / githubweb
  1000. Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 — Gunther Huebler / githubweb
  1001. A variety of small loop pushing. larson-group/clubb#972 — Gunther Huebler / githubweb
  1002. Fixed small bug that slipped through because the G_unit tests use nz=1. — Gunther Huebler / githubweb
  1003. Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 — Gunther Huebler / githubweb
  1004. I added a subroutine that prints that values of all PDF parameters in — bmg2 / githubweb
  1005. Small changes and a loop push. larson-group/clubb#972 — Gunther Huebler / githubweb
  1006. Pushing loop into advance_xm_wpxp. larson-group/clubb#972 — Gunther Huebler / githubweb
  1007. Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 — Gunther Huebler / githubweb
  1008. Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 — Gunther Huebler / githubweb
  1009. Pushing column loop into local functions. larson-group/clubb#972 — Gunther Huebler / githubweb
  1010. Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing. — Gunther Huebler / githubweb
  1011. Adding 2D version of zt2zm and zm2zt to clubb_api — Gunther Huebler / githubweb
  1012. Pushing loop into solve_xm_wpxp_with_single_lhs (#986) — noreply / githubweb
  1013. Refactoring to remove need for global stats scratch variables. (#988) — noreply / githubweb
  1014. Gunthers branch (#989) — noreply / githubweb
  1015. Fixing small bug that breaks runs with scalars. — Gunther Huebler / githubweb
  1016. Implementations of smooth min, max and heaviside function. Added G-Unit tests — 68997723+JanGrn / githubweb
  1017. Making setup_pdf_parameters accept ngrdcols size arrays of stats and grid types. — Gunther Huebler / githubweb
  1018. Forgot two small changes. larson-group/cam#129 — Gunther Huebler / githubweb
  1019. Removing need for data copies. larson-group/cam#129 — Gunther Huebler / githubweb
  1020. Changing column loop index from j to i. larson-group/cam#129 — Gunther Huebler / githubweb
  1021. Removing data copies that we don't need anymore. This still runs correctly on GPUs. — 37674341+huebleruwm / githubweb
  1022. Making clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible. — 37674341+huebleruwm / githubweb
  1023. No more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols. — 37674341+huebleruwm / githubweb
  1024. Adds a blank line to trigger git merge with E3SM — noreply / githubweb

#112 (Mar 11, 2022, 3:36:09 AM)

  1. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  2. Raw-copy updating components/eam/src/physics/silhs — LarsonGroupSysAdmin / githubweb

#111 (Mar 9, 2022, 4:15:52 PM)

  1. Changing log display steps to fit the new logs put out during the test. Also changed the ne4 test to display logs in the post step. — pbroels / githubweb

#110 (Mar 8, 2022, 4:15:46 PM)

  1. Making e3sm compatible with latest clubb updates. larson-group/clubb#972 — Gunther Huebler / githubweb

#109 (Mar 2, 2022, 5:20:23 PM)

  1. Fixing error where test could not find CXX definition. #46 — pbroels / githubweb

#108 (Mar 2, 2022, 3:36:09 AM)

  1. Raw-copy updating components/eam/src/physics/clubb — LarsonGroupSysAdmin / githubweb

#106 (Feb 26, 2022, 3:36:07 AM)

  1. Raw-copy updating components/eam/src/physics/clubb — LarsonGroupSysAdmin / githubweb

#104 (Feb 25, 2022, 5:28:07 PM)

  1. Add harmonicAnalysisRestart stream — mpetersen / githubweb
  2. Adjust stream variables, after talking with Steve Brus. — mpetersen / githubweb
  3. Scripts changes corresponding to updated Registry — jonbob / githubweb
  4. Populating the samxx code. It passes standalone tests. — hannah6 / githubweb
  5. Adding YAKL submodule — hannah6 / githubweb
  6. YAKL fix — hannah6 / githubweb
  7. Making it clear that cub is a library and defaulting it to the home directory. Getting rid of stale information from older README — hannah6 / githubweb
  8. Working toward adding -crm samxx as an option — hannah6 / githubweb
  9. samxx and yakl are building. Working through decoupling crm_physics and sam still. — hannah6 / githubweb
  10. Forgot to add params_kind.F90 — hannah6 / githubweb
  11. The model builds with samxx on the CPU now — hannah6 / githubweb
  12. Changed sam/ interface to pass cam physics data in rather than accessing from sam/. samxx is still giving the wrong answer (evidenced by complaints in e3sm log). I need to find what's different between the tests and the runs — hannah6 / githubweb
  13. Working to get the samxx fortran baseline the same as the sam/ fortran code — hannah6 / githubweb
  14. Working to get the samxx fortran baseline the same as the sam/ fortran code — hannah6 / githubweb
  15. Working to get the samxx fortran baseline the same as the sam/ fortran code — hannah6 / githubweb
  16. Using original FFTs. standalone has machine precision similarity — hannah6 / githubweb
  17. Fix F-MMFXX compset — hannah6 / githubweb
  18. Working on a hardwired approach to GPU for now. As always, CMake is a dumpster fire. — hannah6 / githubweb
  19. restricting new stuff to when gnugpu is used — hannah6 / githubweb
  20. CUDA build works currently. Simulation seems to run successfully. Answer looks good. — hannah6 / githubweb
  21. Add comments, wrap CUDA_FLAGS sm_70 in a test for the summit machine — hannah6 / githubweb
  22. Found a nicer way to specify CUDA and CUDA_FLAGS through config_compilers.xml — hannah6 / githubweb
  23. A change to how USE_CUDA is set to PARENT_SCOPE in CMakeLists.txt — hannah6 / githubweb
  24. Removing a few duplicate summit gnugpu entries in config_compilers.xml.   Also, moving the crm_ecpp_output_module.F90 file into sam and samxx separately. This breaks compilation, but I can't figure out why. — hannah6 / githubweb
  25. Fixing the compilation bug. samxx is no longer trying to compile crm_ecpp_output_module.F90 and is leavng it to the libatm.a build instead. — hannah6 / githubweb
  26. retabbing source files — hannah6 / githubweb
  27. Using clang-format on the C++ code in samxx — hannah6 / githubweb
  28. Revert "Using clang-format on the C++ code in samxx" — hannah6 / githubweb
  29. using clang-format without all the submodules problems from before — hannah6 / githubweb
  30. Revert "using clang-format without all the submodules problems from before" — hannah6 / githubweb
  31. Reducing line length for samxx files — hannah6 / githubweb
  32. better comment for MSA in crm_physics.F90 — hannah6 / githubweb
  33. Apply MMF aerosol optics changes to samxx — hannah6 / githubweb
  34. Adjust ifdefs to fix odd build error — hannah6 / githubweb
  35. Fix build errors — whannah1 / githubweb
  36. Add averaging step for crm_clear_rh — whannah1 / githubweb
  37. Update mpas-source: fixes sea ice melt bug — akt / githubweb
  38. Add semi-colon — whannah1 / githubweb
  39. Fixing a build issue with non-CUDA builds — whannah1 / githubweb
  40. Homme: Fix number of levels in SL trajectory DSS. — ambradl / githubweb
  41. typo fix — whannah1 / githubweb
  42. Homme: Grid total area diagnostic data in simulations. — ambradl / githubweb
  43. Homme: Fix a performance bug in boundary exchange. — ambradl / githubweb
  44. Rename clm testmods to elm — jacob / githubweb
  45. Rename clm to elm in CIME — jacob / githubweb
  46. Address PR comments — hannah6 / githubweb
  47. Add activeTracerHorMixTendency to the timeSeriesStatsMonthlyOutput stream — jonbob / githubweb
  48. Address more PR comments — hannah6 / githubweb
  49. update mpas-source: compass only — mpetersen / githubweb
  50. Homme: fix cmake warning when homme is built without pio support. — lbertag / githubweb
  51. fates-nutrients: added site level mass balance tracking to phosphatase driven p uptake by plants. Cleaned up interface routines and where they call some routines from — rgknox / githubweb
  52. Update CIME submodule again — jgfouca / githubweb
  53. Update mpas-source: compiler flag changes — mpetersen / githubweb
  54. Add CIME src path for MPAS builds — azamat / githubweb
  55. add dam construction year for transient runs — tian.zhou / githubweb
  56. small change — tian.zhou / githubweb
  57. Fixes default compute interval for heat budget — luke.vanroekel / githubweb
  58. Update mpas-source: fix landIceMask bug — mturner / githubweb
  59. Fix format error — jonbob / githubweb
  60. Homme: set default value for USE_MPIEXEC — lbertag / githubweb
  61. Homme: correctly link to scorpio/scorpio_classic when building with pio support — lbertag / githubweb
  62. Homme: remove un-needed (and problematic) deps in share_kokkos_ut — lbertag / githubweb
  63. Homme: bug fix in col_ops_ut [packed reduction] — lbertag / githubweb
  64. Replace CLM with ELM in allactive compsets — jacob / githubweb
  65. Change CLM to ELM in config_pesall — jacob / githubweb
  66. Replace CLM with ELM in F-cases — jacob / githubweb
  67. Fix clear air RH variables in samxx — whannah1 / githubweb
  68. Update mpas-source: bugfix 3rd order advection coeff — mturner / githubweb
  69. Fixing machine files to automatically add -DYAKL_DEBUG to CXXFLAGS for debug runs, fix for debugging symbols and for duplicate CUDA flags — normanmr / githubweb
  70. Homme: build homme_tool tests only if tool is enabled. — lbertag / githubweb
  71. Update MMF tests — hannah6 / githubweb
  72. Homme: fix random initialization of HybridVCoord — lbertag / githubweb
  73. Homme: fix to TeamUtils, to accommodate league_size=0 — lbertag / githubweb
  74. Update mpas-source submodule with updated MALI code — mhoffman / githubweb
  75. Initial commits to support the mpas.gis1to10km mesh in a tri-grid configuration — mhoffman / githubweb
  76. Change IG compset definition to use FO-MALI instead of SIA-MALI — mhoffman / githubweb
  77. Replace albany_input.xml file with yaml version — mhoffman / githubweb
  78. Update albany_input.yaml to use tpetra/MueLu — mhoffman / githubweb
  79. Update version of Albany used by MALI on Cori — mhoffman / githubweb
  80. Update logic for MALI_DYNAMIC to reflect True/False values — mhoffman / githubweb
  81. Make MALI_DYNAMIC options uppercase — mhoffman / githubweb
  82. Make A_BGWCYCL1850 compset use FO MALI — mhoffman / githubweb
  83. Update namelist scripts to correspond to changes to Registry — mhoffman / githubweb
  84. Update fsurdat for r05 grid at sim_year 2000 — mhoffman / githubweb
  85. update albany_input.yaml file — mhoffman / githubweb
  86. Change MALI input file for mpas.gis1to10km resolution — mhoffman / githubweb
  87. Comment out option to write out Albany exo files by default. — mhoffman / githubweb
  88. Script changes to allow input file and decomp files have different dates — mhoffman / githubweb
  89. Make BG and IG compsets used Static MALI (but with Albany build) — mhoffman / githubweb
  90. Disable calving in MALI by default — mhoffman / githubweb
  91. Modify IGCLM45_MLI compset to use SIA — jonbob / githubweb
  92. Checkout from master to reod the rebase — jonbob / githubweb
  93. Update fsurdat for r05 grid at sim_year 2000 — jonbob / githubweb
  94. Add last datafile changes to support new MALI implementation — jonbob / githubweb
  95. fixed a bug in the previous commit related to incloud -> grid-mean conversion — kai.zhang / githubweb
  96. Homme: Removed HOMMEXX_GB_CONFIG CPP logic — lbertag / githubweb
  97. updated clubbv2 — zheng7 / githubweb
  98. HOMME: update dirk weights in tstep 10 in theta-l_kokkos target — lbertag / githubweb
  99. Another update — jgfouca / githubweb
  100. Upgraded kokkos version to 3.2, and adjusted e3sm cmake logic — lbertag / githubweb
  101. This fix is to address Wuyin's comments on the overall consistency between in-cloud & — kai.zhang / githubweb
  102. fixing negative reservoir storage bug — tian.zhou / githubweb
  103. Exclude default paths when looking for kokkos — lbertag / githubweb
  104. Handling the C++14 requirement for yakl and samxx — normanmr / githubweb
  105. Update MPAS-Source: Rayleigh damping fix and continuation line — mpetersen / githubweb
  106. Updated LUT for alignment between iESM and ELM — gautam.bisht / githubweb
  107. Updated comments for LUT v2 — gautam.bisht / githubweb
  108. Increased precision of calculations and outputs — gautam.bisht / githubweb
  109. Updated Makefile to help with compilation on Cori and Compy — gautam.bisht / githubweb
  110. Updated makefile and cleaned up some precision issues — gautam.bisht / githubweb
  111. Added high-precision rounding to stabilize outputs across machines — gautam.bisht / githubweb
  112. Also rounding the harvest outputs — gautam.bisht / githubweb
  113. Turned off debug output for default — gautam.bisht / githubweb
  114. Added additional make message in Makefile — gautam.bisht / githubweb
  115. Updated 1850 and 2015 initial file mcrop names in code — gautam.bisht / githubweb
  116. Update run example to include current input file directory — gautam.bisht / githubweb
  117. Updated land use translator to more easily do different scenarios — gautam.bisht / githubweb
  118. Updated mksurfdata tools for new LUT — gautam.bisht / githubweb
  119. Updated namelist defaults for mksrf_vegtyp — gautam.bisht / githubweb
  120. Update clm namelist definition to include new land surface file rcp tags — gautam.bisht / githubweb
  121. Updated the default historical file name — gautam.bisht / githubweb
  122. rename WRMUnit%active to WRMUnit%active_stage — tian.zhou / githubweb
  123. Changed kokkos version used for submodule — lbertag / githubweb
  124. HOMME: Removed pointless macro link_to_kokkos — lbertag / githubweb
  125. HOMME: fix Kokkos error in debug mode on Cuda — lbertag / githubweb
  126. I updated the version of CLUBB and SILHS used in this NGD CLUBB SILHS branch — bmg2 / githubweb
  127. Upload some modifications which allow better LBA. — bmg2 / githubweb
  128. Upgrade budgets numlib and numice, as well as the diagnostic package. — bmg2 / githubweb
  129. We added a simple detrainment scheme in clubb_intr.F90, in order to reduce SWCF over storm tack. — bmg2 / githubweb
  130. Normal update of diagnostic_v2_0. — bmg2 / githubweb
  131. change clubb_ipdf_call_placement — zheng7 / githubweb
  132. Commit for newbase run. issue #18 — bmg2 / githubweb
  133. Commit for newbase. We added a conserved detrainment code, snowfrc=0.1, rhmini=0.8. #18 — bmg2 / githubweb
  134. In order to limite the tunable parameters, we changed the advance_clubb_core_module.F90 and run scritp. We can repeat the result of [caseB](https://carson.math.uwm.edu/larson-group/internal/E3SM_Global_output/output-20200316/) — bmg2 / githubweb
  135. Change a magic number of altitude_threshold, it allows a deeper mixing layer. issue #18 — bmg2 / githubweb
  136. We increase `altitude_threshold` from 100 to 300m that makes a deeper mixing layar and solves fog problems over stratocumuls regimes. Issue #18. — bmg2 / githubweb
  137. This commit can repeat simulation B, in https://github.com/larson-group/E3SM/issues/18#issuecomment-622158613 — bmg2 / githubweb
  138. I fixed a bug of PDF_PARAMS_FRZ. issue #18 — bmg2 / githubweb
  139. git sucks — bmg2 / githubweb
  140. Adds E3SM support for MPAS-Ocean/Sea-ice grid ECwISC30to60E1r2. — dcomeau / githubweb
  141. Adding JRA support to ECwISC30to60E1r2 grid — dcomeau / githubweb
  142. Correcting paths for mapping files — dcomeau / githubweb
  143. Create draw_micro_budget.py — bmg2 / githubweb
  144. Update CLUBB's Diagnostic Pack — bmg2 / githubweb
  145. Update E3SM_CLUBB_diag.py — bmg2 / githubweb
  146. Update MPAS-Source: COMPASS and documentation only — mpetersen / githubweb
  147. clean up unnecessary comments — zheng7 / githubweb
  148. We added a new formula for [invrs_tau_xp2](https://github.com/larson-group/E3SM/issues/18#issuecomment-636089345). The results of this commit is shown [here](https://github.com/larson-group/E3SM/issues/18#issuecomment-638331975). — bmg2 / githubweb
  149. Finishing off the previous cherry-pick/merge. — bmg2 / githubweb
  150. This commit can reproduce simulation C in https://github.com/larson-group/E3SM/issues/18#issuecomment-640086590. — bmg2 / githubweb
  151. We tuned tau and its equations. This tuning has better ITCZ and a stronger contrast between SC and CU. Results is shown in D of https://github.com/larson-group/E3SM/issues/18#issuecomment-640708110 — bmg2 / githubweb
  152. Script support for new EC30to60E2v2 ocean mesh — jonbob / githubweb
  153. Update function_cal_mean.py — bmg2 / githubweb
  154. update function_cal_mean.py for handling muli year — bmg2 / githubweb
  155. Update E3SM_CLUBB_diag.py — bmg2 / githubweb
  156. Update function_cal_mean.py — bmg2 / githubweb
  157. Update function_pick_out.py — bmg2 / githubweb
  158. We make a new Richardson related formula for invrs_tau_wpxp, in order to remove the `5`. This change makes a good distinction between CU and SC, result can be found in D of [plots](https://github.com/larson-group/E3SM/issues/18#issuecomment-657628303). — bmg2 / githubweb
  159. Update CLUBB's diagnostic package. Now, making average for multiple years is allowed. Please set `nyear` in E3SM_CLUBB_diag.py. — bmg2 / githubweb
  160. Clean up the codes of tau and Richardson number. issue #18 — bmg2 / githubweb
  161. For EAM_tau and ZM. Issue #18 — bmg2 / githubweb
  162. A run script for running tau and ZM. Issue #18 — bmg2 / githubweb
  163. Clean up. — bmg2 / githubweb
  164. EAM_tau_silhs run script. — bmg2 / githubweb
  165. Repeat https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.zguo/eam_tau.n2p3_c151_pre1_fallp25_sgv_1d/ — bmg2 / githubweb
  166. Remaping the SE to Lat-Lon — bmg2 / githubweb
  167. Updating function_cal_mean.py to match exactly what is in Zhun's — bmg2 / githubweb
  168. Run script for making global IOP files. — bmg2 / githubweb
  169. Back to no-sgv run. — bmg2 / githubweb
  170. Update Readme — bmg2 / githubweb
  171. I modified the run_silhs_anvil_gust.csh runscript so that it runs — bmg2 / githubweb
  172. I am adding the files necessary to run the AMWG postprocessing scripts on — bmg2 / githubweb
  173. Within the context of my NGD CLUBB SILHS directory, I have changed the names, — bmg2 / githubweb
  174. I committed some changes to my personal NGD CLUBB SILHS directory to set up — bmg2 / githubweb
  175. I also changed the ne30 remapping file in my NGD CLUBB SILHS branch — bmg2 / githubweb
  176. I added the environment file and run script for E3SM diags. — bmg2 / githubweb
  177. I am also changing these remapping files over to my directory paths. — bmg2 / githubweb
  178. Minor changes to postprocessing files. — bmg2 / githubweb
  179. I updated E3SM to match recent changes made to CLUBB code. — bmg2 / githubweb
  180. I removed l_use_ice_latent from the code, following recent changes to CLUBB. — bmg2 / githubweb
  181. I am updating clubb_intr.F90 and subcol_SILHS.F90 based on recent — bmg2 / githubweb
  182. I am updating E3SM-CLUBB for the addition of the l_partial_upwind_wp3 flag — bmg2 / githubweb
  183. I altered the call to setup_pdf_parameters_api to pass in khzm, — bmg2 / githubweb
  184. Changing code to work with newest silhs update. larson-group/cam#129 — bmg2 / githubweb
  185. Partially reverting last commit. The solution was implemented in silhs_api. larson-group/cam#129 — bmg2 / githubweb
  186. Making compatible with newest clubb changes. larson-group/cam#129 — bmg2 / githubweb
  187. Bug fixes for land use translator and surface file creation — adivittorio / githubweb
  188. Update the EC30to60E2r2 salinity restoring file name — jonbob / githubweb
  189. Set GM-kappa to 600 for EC30to60E2r2 G-cases — jonbob / githubweb
  190. cmake changes summit — oksanaguba / githubweb
  191. cmake change summit — oksanaguba / githubweb
  192. I altered parameters_tunable.F90 so that it looks more like the — bmg2 / githubweb
  193. Clean up crm_history_init — hannah6 / githubweb
  194. Fixing compilation errors in this branch. — bmg2 / githubweb
  195. Fix MMF timing factor output — hannah6 / githubweb
  196. Minor clm to elm changes. — jacob / githubweb
  197. Change timing_factor to subcycle_factor — hannah6 / githubweb
  198. Update CIME to master to bring in PR#3701 from ESMCI/jonbob/add-new-ocnice-grids — jonbob / githubweb
  199. Change SP* history variables to MMF_* — hannah6 / githubweb
  200. Homme: fixing errors reported by valgrind. — lbertag / githubweb
  201. Homme: fixing bug related to diagnostic calls in prim_driver.cpp — lbertag / githubweb
  202. anvil cmake changes — oksana.guba / githubweb
  203. Homme: couple of fixes in preqx_kokkos to match preqx implementation — lbertag / githubweb
  204. adds ICG support for EC30to60E2r02 — luke.vanroekel / githubweb
  205. Homme: Adding HOMMEXX_BFB_TESTING to preqx and preqx_kokkos config files — lbertag / githubweb
  206. Homme: bug fix in preqx_kokkos caar functor — lbertag / githubweb
  207. I committed all the updated CLUBB namelist variables to — bmg2 / githubweb
  208. typo — oksana.guba / githubweb
  209. Update mpas-source: GM/Redi and surface buoyancy fixes — mpetersen / githubweb
  210. Update to E3SM scrpts corresponding to mpas-ocean Registry changes — jonbob / githubweb
  211. Changes to make everything run. — bmg2 / githubweb
  212. Borrowing code from the master for namelist variables and printing — bmg2 / githubweb
  213. Fixed a compilation error. — bmg2 / githubweb
  214. Set mocStreamfunctionAM off by default for new EC30to60E2r2 mesh — jonbob / githubweb
  215. adds default layout for EC6030E2r2 for compy — luke.vanroekel / githubweb
  216. Revert "adds default layout for EC6030E2r2 for compy" — luke.vanroekel / githubweb
  217. adds default layout for EC6030E2r2 for compy — luke.vanroekel / githubweb
  218. Enable E3SM on Tulip — azamat / githubweb
  219. I am making the remaining changes to parameter values necessary to — bmg2 / githubweb
  220. I am committing the changes necessary to bring back the Lscale averaging — bmg2 / githubweb
  221. A few more clm to elm mods — jacob / githubweb
  222. Rename user_nl_clm in testdefs — jacob / githubweb
  223. Rename clm to elm in config_archive — jacob / githubweb
  224. Change ELM output to include "elm" string — jacob / githubweb
  225. Update cime branch hash — jacob / githubweb
  226. Update mpas-source: Added GPU macros to seaice core — akt / githubweb
  227. Updating to Scorpio ver 1.1.3 — jayesh / githubweb
  228. adding summit modules — oksanaguba / githubweb
  229. mods to cmake and bash scripts to have flexibility in run/test scripts for modules, omp options, jsrun command — oksanaguba / githubweb
  230. Update output file metdata with ELM — jacob / githubweb
  231. Update README.txt — bmg2 / githubweb
  232. A replay SCM run script. — bmg2 / githubweb
  233. Professor and I added lines of code in order to find out the negative spike of T. — bmg2 / githubweb
  234. Submit run should be kept as true. — bmg2 / githubweb
  235. Reviving the standalone tests, and using sam/ fortran code rather than custom fortran code — whannah1 / githubweb
  236. Switching to YAKL SimpleBounds for lower register usage on the GPU. Bug fix for previous implementation of crm_clear_rh. — whannah1 / githubweb
  237. Update mpas-source: improved sea ice testing — akt / githubweb
  238. remove crm_gpu test mod — whannah1 / githubweb
  239. Fix saxx cpp_driver — whannah1 / githubweb
  240. Update standalone test notes and env — whannah1 / githubweb
  241. Homme: bug fix in preqx_kokkos, regarding un-initialized buffers — lbertag / githubweb
  242. Change area_p to area — hannah6 / githubweb
  243. Rebase cime changes — jacob / githubweb
  244. Add MPAS-Seaice files for OpenMP or OpenACC offload — azamat / githubweb
  245. Update paths for moved files — azamat / githubweb
  246. Add netcdf to Tulip's LD_LIBRARY_PATH — azamat / githubweb
  247. incremental: fixed flags for kokkos target; changes to have only kokkos targets on summit — oksanaguba / githubweb
  248. Remove debugging lines in elm buildnml — jacob / githubweb
  249. Replace CLM with ELM in a few pelayout entires — jacob / githubweb
  250. Homme: Remove some debug-build output. — ambradl / githubweb
  251. finish summit scripts — oksanaguba / githubweb
  252. EAM: Remove dynamics' Q fields from SE dycore restart, leaving only Qdp. — ambradl / githubweb
  253. change options for anvil bfb — oksana.guba / githubweb
  254. addition of snicar for land and sea ice, 5 sea ice snow layers, and ITD snow redistribution — afroberts / githubweb
  255. modify standalone conda commands — whannah1 / githubweb
  256. Centralized definition of r8 for CRM code — whannah1 / githubweb
  257. Address PR comments about private/public — whannah1 / githubweb
  258. Update compy L pe-layout for trigrid with EC30to60 — jonbob / githubweb
  259. Rename cam to eam — jacob / githubweb
  260. Change submodule location for cosp2 and rrtmgp externals — jacob / githubweb
  261. Rename cam testmods to eam — jacob / githubweb
  262. Rename user_nl_cams in testmods — jacob / githubweb
  263. Address PR comments — whannah1 / githubweb
  264. Updating standalone framework — normanmr / githubweb
  265. update mpas-source: Fix OMP Directives and Loop Bounds in Ocean — mpetersen / githubweb
  266. Fixing a standalone bug with params_kind.F90 — normanmr / githubweb
  267. I changed setup_clubb_pdf_params.F90 and latin_hypercube_driver_module.F90 — bmg2 / githubweb
  268. Rename cam to eam in CIME — jacob / githubweb
  269. Change CAM to EAM in allactive compsets — jacob / githubweb
  270. Modify more cime_config files for eam — jacob / githubweb
  271. Adjust other component config files for EAM — jacob / githubweb
  272. Modify a few more testmods — jacob / githubweb
  273. Rename cam to eam in ChemPreprocess.pm for paths to chem_proc and chemistry — wlin / githubweb
  274. Rename cam to eam in machine Depends files for cmake — wlin / githubweb
  275. update mpas-source: vertical transport in stage 1 — mpetersen / githubweb
  276. Additions to Monthly output — mpetersen / githubweb
  277. Fix scorpio submodules after bad merge — bhillma / githubweb
  278. Update cime pointer — jacob / githubweb
  279. revert some changes — oksana.guba / githubweb
  280. Replace cam with eam in cmake files — jacob / githubweb
  281. Updated fates interface bc structure for CNP — rgknox / githubweb
  282. I added some documentation (comments/clean-up) and thresholding on dumr, dumnr, dums, and dumns. — bmg2 / githubweb
  283. Add gmKappaScaling and gmBolusKappa — mpetersen / githubweb
  284. Adds reservoir stratification to MOSART-heat. — gautam.bisht / githubweb
  285. Switch to deafault E3SM V2 output — afroberts / githubweb
  286. Update Depends files to new eam name — jgfouca / githubweb
  287. Initial commit to prepend casename to mpas output files — jonbob / githubweb
  288. fix a bug in ELM-Erosion — zeli.tan / githubweb
  289. Change eam output files to use eam in name — jacob / githubweb
  290. Update cime submodule — jacob / githubweb
  291. Uses isnan from shr_infnan_mod — gautam.bisht / githubweb
  292. inctease time limit for homme suite for anvil — oksana.guba / githubweb
  293. Improve Travis debugging — lukasz / githubweb
  294. Update ICG files for oEC60to30v3 so seaice has new number of snow levels — jonbob / githubweb
  295. Rename .mod files in chem_proc to .in — ac.wlin / githubweb
  296. update buildnml for E3SM V2 — ac.afroberts / githubweb
  297. Change pattern matching of .mod to .in on setting chem_mods file — ac.wlin / githubweb
  298. Update mpas-source: CVMix and GM updates — mpetersen / githubweb
  299. Allow up to 10 atm tapes — harr152 / githubweb
  300. Update bld scripts autogenerated from Registry changes — jonbob / githubweb
  301. update to include monthly albedo by surface type, and pond fraction as default — ac.afroberts / githubweb
  302. Update mpas-source: CVMix and GM updates — mpetersen / githubweb
  303. Sending ALM as hlm_name to FATES instead of CLM — rgknox / githubweb
  304. Change default for config_GM_Visbeck_alpha in coupled model — jonbob / githubweb
  305. Change name of CAM_USER_MODS — jacob / githubweb
  306. Add MMF_WTKE output variable — whannah1 / githubweb
  307. change MMF_WTKE to MMF_TKEW — whannah1 / githubweb
  308. Enable moentum feedback in SAM++ — whannah1 / githubweb
  309. Fix MMF momentum feedback — whannah1 / githubweb
  310. Apply dosurface change to fortran CRM — whannah1 / githubweb
  311. Update eam global attributes — jacob / githubweb
  312. Update elm global attributes — jacob / githubweb
  313. Deallocate local vector that is not deallocated automatically — worleyph / githubweb
  314. Adding big_number_finder.py to the postprocessing directory. — bmg2 / githubweb
  315. update mpas-source: Modify ocean freezing temperature to match MPAS-Seaice — mpetersen / githubweb
  316. Restart from existing land files that do not contain required variables for plant hydraulics. — gautam.bisht / githubweb
  317. Add comments. — gautam.bisht / githubweb
  318. Update bld scripts autogenerated from Registry changes — mpetersen / githubweb
  319. Update config_open_ocean_freezing_temperature_coeff — mpetersen / githubweb
  320. Increase field widths in atm_chunk_cost.txt — worleyph / githubweb
  321. Compiler change after Tulip OS upgrade — azamat / githubweb
  322. Adds support to put crops different landunits — gautam.bisht / githubweb
  323. Fixes to fractions based on global run — gautam.bisht / githubweb
  324. Fixes memory leak — gautam.bisht / githubweb
  325. Add theta-SL-pg2 config for EAM Antarcrica RRM — ac.wlin / githubweb
  326. Update mosart global attributes — jacob / githubweb
  327. Add contact email to eam global attributes — jacob / githubweb
  328. changes for skybridge bfb test — oksana.guba / githubweb
  329. revert gitmodules formatting — oksana.guba / githubweb
  330. Update ATM2LND_SMAP and other corrections — ac.wlin / githubweb
  331. Finish moving cam to eam — jacob / githubweb
  332. fixing new paths — oksana.guba / githubweb
  333. Update ICG file datestamps for EC30to60E2r2 — jonbob / githubweb
  334. I updated the E3SM-CLUBB plots to create a new directory called — bmg2 / githubweb
  335. I updated the run_silhs_anvil_gust.csh runscript to include — bmg2 / githubweb
  336. I have added the files necessary for running AMWG variability — bmg2 / githubweb
  337. add avx=0 to anvil, skybridge optimized setup — oksana.guba / githubweb
  338. Update fully coupled e3sm_prod test to v2 — jacob / githubweb
  339. cice and cime changes for  cime changes to rename CCSM_cppdefs to CIME_cppdefs. We are keeping both for right now (one is a copy of the other) to give models time to adjust) — wpcoomb / githubweb
  340. changes to components/cmake/build_model.cmake for CIME_cppdefs file — wpcoomb / githubweb
  341. changes to E3SM/components/eam/ for CIME_cppdefs — wpcoomb / githubweb
  342. fixed up cice, elm, and mosart — wpcoomb / githubweb
  343. Improved /components/cice/cime_config/buildlib — wpcoomb / githubweb
  344. Improved /components/cice/cime_config/buildlib 2 — wpcoomb / githubweb
  345. Improved /components/cice/cime_config/buildlib 3 — wpcoomb / githubweb
  346. reverting avx_ver=0 from anvil and skybridge, causing wrong flags — oksana.guba / githubweb
  347. Initial scripts support for new WC14to60E2r3 ocn/ice grid — jonbob / githubweb
  348. Add WC14to60E2r3 grid description — jonbob / githubweb
  349. Update mpas-ocean defaults for new WC14to60E2r3 grid — jonbob / githubweb
  350. Update WC14to60 mapping and domain files — jonbob / githubweb
  351. Add a separate grid for the 1900 spinup of this mesh — jonbob / githubweb
  352. Set config_hmix_use_ref_cell_width to true for the WC14to60E2r3 grid — jonbob / githubweb
  353. Update datestamp for WC14to60E2r3 ICG files — jonbob / githubweb
  354. Update grid alias for WC14to60E2r3 to use EAM instead of CAM5 — jonbob / githubweb
  355. Update docn config to add EAMe — jacob / githubweb
  356. Remove UNICON pt1 - cime and build configure — whannah1 / githubweb
  357. Remove UNICON pt2 - misc stuff outside physics — whannah1 / githubweb
  358. Remove UNICON pt3 - general physics changes — whannah1 / githubweb
  359. Remove UNICON pt4 - convection+micro+macro physics — whannah1 / githubweb
  360. Update mapping and domain files for EC30to60E2r2 grid — jonbob / githubweb
  361. Remove UNICON pt5 - unicon files — whannah1 / githubweb
  362. Homme: using exclusively SIMD Vector for Scalar type. — lbertag / githubweb
  363. Add pe-layout for T62_oEC60to30v3 DTESTM on sandiatoss3 on 4 nodes — jonbob / githubweb
  364. Remove UNICON pt6 - fix micro/macro — whannah1 / githubweb
  365. Remove trigmem — whannah1 / githubweb
  366. Add history global att to eam — jacob / githubweb
  367. Update elm global atts — jacob / githubweb
  368. Update mosart global atts — jacob / githubweb
  369. remove avx flag as it is resolved — oksana.guba / githubweb
  370. Files for northamericax4v1pg2_r0125_WC14to60E2r3(_ICG) — ambradl / githubweb
  371. Adjusting PE layouts for compy and a%ne0np4_northamericax4v1.pg2_l%.+_oi%WC14to60E2r3. — ambradl / githubweb
  372. Update the 'L' (Large) default PE layout for compy and RRM V2. — ambradl / githubweb
  373. NA-ocn WC RRM: Updates for CAM -> EAM. — ambradl / githubweb
  374. Machine file changes for PNNL Sooty — balwindersingh / githubweb
  375. Finish removing trigmem option — whannah1 / githubweb
  376. Homme: Removed pointless include dir in share_kokkos_ut CMakeLists.txt — lbertag / githubweb
  377. Homme: Setting kokkos arch in some mach file used for nightlies — lbertag / githubweb
  378. Homme: enable unit tests only in BFB builds — lbertag / githubweb
  379. Improved e3sm commits to 1)Open the new CIME_cppdefs file if the file exists 2)Open and read the old CCSM_cppdefs file if the system can not find the CIME_cppdefs file — wpcoomb / githubweb
  380. Fixed white space. — wpcoomb / githubweb
  381. Fixed white space.a — wpcoomb / githubweb
  382. fixed some formatting — wpcoomb / githubweb
  383. Homme: fixing some cmake logic regarding auto-enabling of targets — lbertag / githubweb
  384. Move eam history attribute — jacob / githubweb
  385. Homme: fixing odd non-bfb issue with Intel18 in Caar functor. — lbertag / githubweb
  386. Update mpas-source: modify Eden Greatbatch length scale; clean up flags — mpetersen / githubweb
  387. Add additional diagnostic outputs to track Sudden Stratospheric Warming events — harr152 / githubweb
  388. Add auto-generated bld files corresponding to Registry changes — jonbob / githubweb
  389. Fix cut-and-paste error that ended up with two single quotation marks — jonbob / githubweb
  390. This simulation is BFB with the refactored code — balwindersingh / githubweb
  391. Adds endrun calls for blocking radiation diagnostics — balwindersingh / githubweb
  392. RRTMGP test runs fine at this point — balwindersingh / githubweb
  393. Fixes the support for user-defined grid for ELM — gautam.bisht / githubweb
  394. Adds a test for ELM_USRDAT resolution — gautam.bisht / githubweb
  395. CRM tests run fine now — balwindersingh / githubweb
  396. Added prescribed ice mode to MPAS-Seaice component — akt / githubweb
  397. AMB fix for unused kokkos in mpas — oksana.guba / githubweb
  398. NA-ocn WC RRM: XS PE layout for cori-knl just to get something going — ambrad / githubweb
  399. Update mksurfdata defaults for 0.5x0.5 res and fix a small bug — divi553 / githubweb
  400. Update mpas-source: Unreverted revert of MPAS-Seaice — akt / githubweb
  401. Adv cime sha — wpcoomb / githubweb
  402. Move new F-compset definition to EAM — jonbob / githubweb
  403. Make build-namelist-section consistent with build-namelist — jonbob / githubweb
  404. Add FC5AV1C-L-MPASSI compset — jonbob / githubweb
  405. Homme, COMPOSE: Fix debug-build error. — ambradl / githubweb
  406. Homme: Use 'any' instead of 'maxval'. — ambradl / githubweb
  407. Add layouts for RRM v2 config on compy. — ndkeen / githubweb
  408. Bring in hot fix to kokkos submodule, relative to CRAYPE linking — lbertag / githubweb
  409. Renames local variable with clm to elm — gautam.bisht / githubweb
  410. Update mpas-source: fixed prescribed ice bug in seaice with category thickness limits — akt / githubweb
  411. Update again kokkos version, following bug fix — lbertag / githubweb
  412. I changed cice/cime_config/buildlib/ to store — wpcoomb / githubweb
  413. Cleaned up unnecessary if statement block. — wpcoomb / githubweb
  414. Revert "Cleaned up unnecessary if statement block." — wpcoomb / githubweb
  415. make SCM compatible with thetal dycore — bogensch / githubweb
  416. Mass test: Double tol on CO2_FF global mass based on compy_pgi change. — ambradl / githubweb
  417. bug fixes for working code — bogensch / githubweb
  418. Adv cime sha to include PRs #3740 & #3741, — wpcoomb / githubweb
  419. EAM: Use new rebin_fast in volc_radiation code and rework idxs. — ambradl / githubweb
  420. Update mpas-source: fixed bug with index in prescribed ice in seaice — akt / githubweb
  421. RRM: Add an XS Cori-KNL layout from Noel. — ambrad / githubweb
  422. turn on xx tests — oksana.guba / githubweb
  423. activating dynamic crop fraction when prognostic crop model is turned off — tian.zhou / githubweb
  424. EAM: Remove some old comments. — ambradl / githubweb
  425. Defense against use of user_nl_cam after renaming cam to eam — wlin / githubweb
  426. first attempt to switch — oksana.guba / githubweb
  427. Rename user_nl_cam in test allactive-v1cmip6 — wlin / githubweb
  428. Remove two MOC flags — mpetersen / githubweb
  429. Update mpas-source for moc update — mpetersen / githubweb
  430. Add moc GM variables to monthly output — mpetersen / githubweb
  431. bug fix for nitrogen fixation calculation for ECA — jinyuntang / githubweb
  432. Scorpio version 1.1.4 — jayesh / githubweb
  433. Add user_nl_mpassi for elm bgcexp testmod in order to pass automated tests — jonbob / githubweb
  434. Remove support for Makefile-based builds for E3SM components — jgfouca / githubweb
  435. another cime update — jgfouca / githubweb
  436. For cori-knl, update PE layout for F compsets at ne4 resolution. — ndkeen / githubweb
  437. Set fill values for radiation outputs — bhillma / githubweb
  438. update flag to allow one-way irrigation, remove unused output, remove redundant comments, fix area fraction inconsistency for coastal irrigation — tian.zhou / githubweb
  439. Add missing HR output for RRTMGP — bhillma / githubweb
  440. another cime update — jgfouca / githubweb
  441. Hommexx: setting vector size in eam builds — lbertag / githubweb
  442. Hommexx: fix usage of HOMMEXX_CUDA_SHARE_BUFFER — lbertag / githubweb
  443. Hommexx: fixed include path for Kokkos_Random.hpp — lbertag / githubweb
  444. Hommexx: fix eam configure script for preqx_kokkos — lbertag / githubweb
  445. Homme: fixed some cmake/compiler warnings — lbertag / githubweb
  446. Homme: better handling of cxx homme session — lbertag / githubweb
  447. update unit in the output — tian.zhou / githubweb
  448. Homme: added interface to BoundaryExchange — lbertag / githubweb
  449. Homme: adding HOMME_WITHOUT_PIOLIBRARY to compile definitions of executables — lbertag / githubweb
  450. Homme: added macro to create a library for preqx_kokkos and theta-l_kokkos — lbertag / githubweb
  451. Homme: store blas/lapack libs location in an internal cache var — lbertag / githubweb
  452. Homme: created f2c module for kokkos targets, plus breaking up some functions — lbertag / githubweb
  453. Homme: minor change in ElementsGeometry initialization — lbertag / githubweb
  454. Homme: make some CAM ifdefs also check for SCREAM — lbertag / githubweb
  455. Apply fixes to MMF too — bhillma / githubweb
  456. Update mpas-source: Fix cmake for tool exes — mpetersen / githubweb
  457. another cime update — jgfouca / githubweb
  458. Homme: init cxx functors before copying data into views — lbertag / githubweb
  459. Add timing to compiles and links — jgfouca / githubweb
  460. make the code compatible with old MOSART parameter file — tian.zhou / githubweb
  461. This is a rebased after cam->eam change — balwindersingh / githubweb
  462. Rebased:Default case is working wih diags and it is BFB — balwindersingh / githubweb
  463. Improve timing feature — jgfouca / githubweb
  464. Preparations for resolving merge between FATES nutrient branch and hash 45c7a29 — rgknox / githubweb
  465. change default settings for a thetal run — bogenschutz1 / githubweb
  466. Incrementally rectifying conflicts with FATES-CLP and master through evaluating diffs — rgknox / githubweb
  467. conflict resolutions between master and FATES-CNP — rgknox / githubweb
  468. conflict resolutions between fates-cnp and master — rgknox / githubweb
  469. conflict resolutions between fates-cnp and master — rgknox / githubweb
  470. conflict resolutions between fates-cnp and master — rgknox / githubweb
  471. conflict resolutions between fates-cnp and master — rgknox / githubweb
  472. Rework timing so that it works with -jN — jgfouca / githubweb
  473. conflict resolutions between fates-cnp and master — rgknox / githubweb
  474. conflict resolutions between fates-cnp and master — rgknox / githubweb
  475. updating fates submodule pointer to api 14 — rgknox / githubweb
  476. Cleaned up clear_rh logic and fixed calcsize ifdef for modal_aero — balwindersingh / githubweb
  477. Bug fix for prescribed aerosols — balwindersingh / githubweb
  478. Removed some unused vars and use rad_cnst sigma — balwindersingh / githubweb
  479. Everything still BFB, changes related to dgnum and voltonumb — balwindersingh / githubweb
  480. still BFB, some cleanup — balwindersingh / githubweb
  481. COMPASS only, New Mesh: EC15to60E2r4 — mpetersen / githubweb
  482. Update cime and improve time format — jgfouca / githubweb
  483. temporary refactor of the proper way q advection should be done, refactor on way — bogensch / githubweb
  484. fixing build for mmfxx test — oksana.guba / githubweb
  485. I am updating clubb_intr.F90, clubb_api_module, and subcol_SILHS.F90 — bmg2 / githubweb
  486. Reworked logic for calcsize_diag, still BFB — balwindersingh / githubweb
  487. minor cleanup, bfb — balwindersingh / githubweb
  488. keep *elm-bgcexptests with preqx — oksana.guba / githubweb
  489. make scm test use preqx — oksana.guba / githubweb
  490. cleaned up update_mmr logic at some places and removed some pointers — balwindersingh / githubweb
  491. Cleaned up update_mmr logic — balwindersingh / githubweb
  492. Always turn on our wrapper — jgfouca / githubweb
  493. Fixes build a build error — balwindersingh / githubweb
  494. alternate way to do vertical advection — bogensch / githubweb
  495. build namelist fix — tian.zhou / githubweb
  496. refactor how the theta-l dycore handles the vertical advection to be more consistent — bogensch / githubweb
  497. update comments and SE improvements — bogensch / githubweb
  498. Homme: cmake fixes for library targets — lbertag / githubweb
  499. bug fix for update_T logical — bogensch / githubweb
  500. fix some spacing issues — bogensch / githubweb
  501. Renames files — gautam.bisht / githubweb
  502. Renames clm_drv to elm_drv — gautam.bisht / githubweb
  503. Renames private subroutines — gautam.bisht / githubweb
  504. Renames clm_finializedMod to elm_finializedMod — gautam.bisht / githubweb
  505. Renames clm_initializeMod to elm_initializeMod — gautam.bisht / githubweb
  506. Renames clm_instMod to elm_instMod — gautam.bisht / githubweb
  507. Renames clm_interface_bgcType to elm_interface_bgcType — gautam.bisht / githubweb
  508. Renames clm_interface_th_datatype to elm_interface_th_datatype — gautam.bisht / githubweb
  509. Renames clm_interface_thType to elm_interface_thType — gautam.bisht / githubweb
  510. Renames clm_interface_dataType to elm_interface_dataType — gautam.bisht / githubweb
  511. Renames clm_interface_data_type to elm_interface_data_type — gautam.bisht / githubweb
  512. Renames clm_inst_biogeochem/biogeophys to elm_inst_biogeochem/biogeophys — gautam.bisht / githubweb
  513. Renames clm_interface_funcsMod to elm_interface_funcsMod — gautam.bisht / githubweb
  514. Renames get_clm to get_elm — gautam.bisht / githubweb
  515. Renames clm_bgc to elm_bgc — gautam.bisht / githubweb
  516. Renames clm_pf_idata, clm_bgc_data, clm_idata to elm_pf_idata, elm_bgc_data, elm_idata — gautam.bisht / githubweb
  517. Renames clm_varcon to elm_varcon — gautam.bisht / githubweb
  518. Renames clm_varpar to elm_varpar — gautam.bisht / githubweb
  519. Renames clm_varctl to elm_varctl — gautam.bisht / githubweb
  520. Renames clm_varsur to elm_varsur — gautam.bisht / githubweb
  521. Renames clm_nlUtilsMod to elm_nlUtilsMod — gautam.bisht / githubweb
  522. Renames vic_clm_fract to vic_elm_fract — gautam.bisht / githubweb
  523. Renames clm_cpl_indices to elm_cpl_indices — gautam.bisht / githubweb
  524. Renames CLMFatesInterfaceMod to ELMFatesInterfaceMod — gautam.bisht / githubweb
  525. Renames clm_varorb to elm_varorb — gautam.bisht / githubweb
  526. Renames clm_domain_mct to elm_domain_mct — gautam.bisht / githubweb
  527. Deletes test directories that are not used by E3SM — gautam.bisht / githubweb
  528. Renames dom_clm to dom_elm — gautam.bisht / githubweb
  529. Renames u10_clm_patch to u10_elm_patch — gautam.bisht / githubweb
  530. Renames clmlevel to elmlevel — gautam.bisht / githubweb
  531. Renames clmveg to elmveg — gautam.bisht / githubweb
  532. Updates output message from CLM to ELM — gautam.bisht / githubweb
  533. Renames tau_clm to tau_elm — gautam.bisht / githubweb
  534. Renames clm_inparm to elm_inparm — gautam.bisht / githubweb
  535. Renames multiple categories in namelist from clm to elm — gautam.bisht / githubweb
  536. Changes multiple namelist options from CLM to ELM — gautam.bisht / githubweb
  537. Changes CLM-PFLTORAN interface to ELM-PFLOTRAN interface — gautam.bisht / githubweb
  538. Change clm_interface_data to elm_interface_data — gautam.bisht / githubweb
  539. Changes CLM to ELM in interface for PFLOTRAN — gautam.bisht / githubweb
  540. Changes CLM to ELM in initSubgridMod — gautam.bisht / githubweb
  541. Changes CLM to ELM in timers — gautam.bisht / githubweb
  542. Changes subroutine name — gautam.bisht / githubweb
  543. Changes name of the option to merge crops — gautam.bisht / githubweb
  544. Changes CLM to ELM in histFileMod — gautam.bisht / githubweb
  545. Change user namelist name — gautam.bisht / githubweb
  546. Changes BGC subroutine name from CLM to ELM — gautam.bisht / githubweb
  547. Changes CLM to ELM in comments — gautam.bisht / githubweb
  548. setup conusx4 res for theta — oksana.guba / githubweb
  549. mpas-source: improve performance of diagnostics — mpetersen / githubweb
  550. Fixing the constants being different in samxx than in sam. Diffs in standalone are much better now. — whannah1 / githubweb
  551. Fixing fortran code bug in crm_clear_rh and mirroring in C++ code — whannah1 / githubweb
  552. C++ code now gives correct results in standalone on the CPU — whannah1 / githubweb
  553. Fix aqua compset for MMF w/ SAM++ — whannah1 / githubweb
  554. Update MMF standalone test files — whannah1 / githubweb
  555. Major bug fix - index error in SAM++ scalar diff — whannah1 / githubweb
  556. CRM Kurant update — whannah1 / githubweb
  557. Update perturb_t_magnitude in SAM++ — whannah1 / githubweb
  558. Misc C++ casting and index updates — whannah1 / githubweb
  559. rename dummy1 variable to temp_tend, which is more descriptive — bogensch / githubweb
  560. This run script can reproduce good simulations for both SCM cases BOMEX and RF01. Issue #18. — bmg2 / githubweb
  561. More 'state_debug_checks' in physpkg.F90, also output the location when we find bad value of state%t. — bmg2 / githubweb
  562. fix mmf tests — oksana.guba / githubweb
  563. Fixes namelist options for a test — gautam.bisht / githubweb
  564. fixes the path surface dataset — gautam.bisht / githubweb
  565. put SCM logical around SCM specific code block — bogensch / githubweb
  566. Update mpas-source: updated sea ice with alignment of atmos coupling — akt / githubweb
  567. typo fix — whannah1 / githubweb
  568. Set PIO_ROOT=1 for ne30-coupled cases on sandiatoss3 — azamat / githubweb
  569. remove SCM from SL tracer advection — bogensch / githubweb
  570. travis: Print e3sm bldlog if build fails — jgfouca / githubweb
  571. Move PIO_ROOT=1 mod to ERP testmod — azamat / githubweb
  572. Fix build time calls — jgfouca / githubweb
  573. Check time availability — jgfouca / githubweb
  574. Another cime build fix — jgfouca / githubweb
  575. Update cime again with new prov stuff — jgfouca / githubweb
  576. further extration from SL transport in SCM — bogensch / githubweb
  577. cleanup — bogensch / githubweb
  578. whitespace issue fix — bogensch / githubweb
  579. linebreak fix — bogensch / githubweb
  580. final cime update — jgfouca / githubweb
  581. remove unnecessary nu parameter from SCM namelist settings — bogensch / githubweb
  582. Update ERP testmod — azamat / githubweb
  583. switch theta-l dycore to tensorHV — mt / githubweb
  584. all hgrid= conditions need a dyn_target= also — mt / githubweb
  585. Increase MOSART restart file name lengths — azamat / githubweb
  586. Add wcprod test mod — jacob / githubweb
  587. Update Blues modules to nvhpc — azamat / githubweb
  588. change 3 to 3.0 — oksana.guba / githubweb
  589. Replace array reference argument with a scalar — worleyph / githubweb
  590. Fix mis-declared variables — worleyph / githubweb
  591. Explain why replacing array reference argument with a scalar — worleyph / githubweb
  592. Add wcprod test mod for eam — jacob / githubweb
  593. Update e3sm_prod suite to v2 cases — jacob / githubweb
  594. Changes NTASKS for ELM-USRDAT test — gautam.bisht / githubweb
  595. account name on bebop cluster has been renamed 'e3sm' — sarich / githubweb
  596. Bug fix to account for snow backscattering in COSPv2 — wlin / githubweb
  597. Fixes some comments and magic numbers — balwindersingh / githubweb
  598. Pointed pointer to null — balwindersingh / githubweb
  599. Fixes GNU bug differently to allow BFB results. — balwindersingh / githubweb
  600. remove some of settings in ftype tests — oksana.guba / githubweb
  601. make bgc tests use theta — oksana.guba / githubweb
  602. Changes that address review comments — gautam.bisht / githubweb
  603. Rebased again for cam->eam change(12/02/2020) — balwindersingh / githubweb
  604. fixed a typo and removed a comment — balwindersingh / githubweb
  605. Removed references to "cam" in comments about submodule paths — balwindersingh / githubweb
  606. fixed typo and removed a reference to clm as well — balwindersingh / githubweb
  607. Removes a file that was mistakenly added earlier — gautam.bisht / githubweb
  608. Initialize mixing ratio when reading restarts — jayesh / githubweb
  609. Removes clm4_0 and clm5_0 from compset namelist — gautam.bisht / githubweb
  610. Updates the namelist build scripts — gautam.bisht / githubweb
  611. Updates indenting — gautam.bisht / githubweb
  612. Renames xml files — gautam.bisht / githubweb
  613. Renames builds perl script — gautam.bisht / githubweb
  614. Remove tests not used by ELM — gautam.bisht / githubweb
  615. Removes script to determine verion of the model — gautam.bisht / githubweb
  616. Removes clm4_0 — gautam.bisht / githubweb
  617. Renames namelist options from CLM to ELM — gautam.bisht / githubweb
  618. Moved new files into the eam directory structure — harr152 / githubweb
  619. Fixes build options in few tests — gautam.bisht / githubweb
  620. Add Chrysalis machine configuration — azamat / githubweb
  621. Add new Chrysalis modules after storage upgrade — azamat / githubweb
  622. Add omp master to a section of code in init that would otherwise have a race condition. — ndkeen / githubweb
  623. Moved the shared nlev_tom variable initialization to be set only once by master thread. — ndkeen / githubweb
  624. Init an array to zero. — ndkeen / githubweb
  625. There were 3 other arrays that should also be set to zero before use, but these — ndkeen / githubweb
  626. Move where the AOD arrays are initialized to zero. — ndkeen / githubweb
  627. Fixes some strings, all dev tests pass with PGI on Compy — balwindersingh / githubweb
  628. Converts integers to logicals in two if conditions — balwindersingh / githubweb
  629. Bug fix in sea ice coupling file to use the same freezing temperature as — afroberts / githubweb
  630. Switch on high-frequncy coupling in sea ice at 10 iterations — afroberts / githubweb
  631. conflict resolution on cherry-pick — rgknox / githubweb
  632. resolved conflicts on cherry-pick — rgknox / githubweb
  633. Support for ne30np4pg2 in ELM — gautam.bisht / githubweb
  634. This commit upgrades the version of CLUBB and SILHS found in Brian's NGD — bmg2 / githubweb
  635. slightly modified logic on FATES and fixation — rgknox / githubweb
  636. Reverting to older and simplified version of allocation before attempting to merge with master. — rgknox / githubweb
  637. Add grid support for the new ne30np4.pg2 ELM files — jonbob / githubweb
  638. initial start of whitespace fix — celdred / githubweb
  639. does this work? — celdred / githubweb
  640. seems to work — celdred / githubweb
  641. almost there — celdred / githubweb
  642. done! — celdred / githubweb
  643. fixed broadcast order of use_fates — rgknox / githubweb
  644. fixes for global norms mod and C++/Kokkos — celdred / githubweb
  645. shallow water fix — celdred / githubweb
  646. Add GNU modules — azamat / githubweb
  647. fates api 14 — rgknox / githubweb
  648. I updated the version of CLUBB-SILHS found in UWM's NGD E3SM-CLUBB-SILHS — bmg2 / githubweb
  649. fixing _kokkos builds — oksana.guba / githubweb
  650. Fixes compute wetdens logic — balwindersingh / githubweb
  651. Advance cime to include GPTL process id update — azamat / githubweb
  652. Rename LCRC paths from acme to e3sm and clean up — azamat / githubweb
  653. fates cnp, minor fix to fire and n/p dep interpolations. — rgknox / githubweb
  654. FATES API 14 fixes — rgknox / githubweb
  655. update mpas-source: Add diagnostics module for GPU performance — mpetersen / githubweb
  656. Unit testing fixes? — celdred / githubweb
  657. Cleaned up Convective Variance Transport — whannah1 / githubweb
  658. Initial C++ port of CVT — whannah1 / githubweb
  659. C++ VT bug fixes — whannah1 / githubweb
  660. VT Bug fix and summit config adjustment for PGI — whannah1 / githubweb
  661. FATES coupling, temporarily disabling SOIL_ORDER read-ins when fates is on, due to lack of data in the 4x5 surfacefile. — rgknox / githubweb
  662. fates api 14 cnp p1, nee coupling fix and comments fix — rgknox / githubweb
  663. Minor VT updates — whannah1 / githubweb
  664. pass moisture and temp scalars from ColumnDataType to FATES — glemieux / githubweb
  665. Change MMF variance transport naming convention — whannah1 / githubweb
  666. Updating to Scorpio v1.1.5 — jayesh / githubweb
  667. fixed a typo in the fates test list — rgknox / githubweb
  668. I updated the version of CLUBB-SILHS in the NGD E3SM-CLUBB-SILHS — bmg2 / githubweb
  669. Fix PRNG for setperturb in SAM++ — whannah1 / githubweb
  670. Update mpas-source: update seaice with ocean surface temperature bug fix — akt / githubweb
  671. Add Circle CI test — lukasz / githubweb
  672. Bug fix for crashing SAM++ VT cases — whannah1 / githubweb
  673. Add history variables for large-scale VT forcing — whannah1 / githubweb
  674. fix for gnu compiler — balwindersingh / githubweb
  675. Add pelayouts for e3sm_prod WC case — azamat / githubweb
  676. Fixes a threading issue — balwindersingh / githubweb
  677. Minor cleanup — balwindersingh / githubweb
  678. Change optimizations of modal_aero_calcsize.F90 to -O1 for Compy's PGI — balwindersingh / githubweb
  679. Replace module removes with module swaps on Theta — azamat / githubweb
  680. Changes ocean defaults to be consistent with WC v2 — luke.vanroekel / githubweb
  681. enables MOC am — luke.vanroekel / githubweb
  682. Update paths and module loads on Theta — azamat / githubweb
  683. Update mpas-source: Fix bug with high freq coupling in MPAS-Seaice — akt / githubweb
  684. Updates hgrid for 0.125x0.125 — gautam.bisht / githubweb
  685. Add C++ FFT filter routine for VT — whannah1 / githubweb
  686. Add code for sanity checking YAKL FFT — whannah1 / githubweb
  687. Added fortran FFT sanity check code — whannah1 / githubweb
  688. Minor clean up — whannah1 / githubweb
  689. Update mpas-source: Updated sea ice emissivity — akt / githubweb
  690. Add ne4 pelayout on Chrysalis — azamat / githubweb
  691. Add HOMME machine file for Chrysalis — azamat / githubweb
  692. fixed fates logic for decomp_verprofiles() call — rgknox / githubweb
  693. fates: updated logic during capacitance-based phosphatase dynamics to move logical filters outside of loops (for performance). — rgknox / githubweb
  694. Changed name of call ZeroUpscaled to ZeroForFates — rgknox / githubweb
  695. removed obsolete print statement — rgknox / githubweb
  696. Replace netcdf versions with versions used on Anvil — azamat / githubweb
  697. updated name of zero-ing of column level datastructures when fates is on — rgknox / githubweb
  698. removed temporary file AllocationMod.F90_new — rgknox / githubweb
  699. updating fates submodule pointer to tag sci.1.43.2_api.14.2.0 — rgknox / githubweb
  700. Removal of high-frequency coupling for V2 default sea ice coupling — afroberts / githubweb
  701. makes parameter changes valid for EC30to60E2r2 only — luke.vanroekel / githubweb
  702. Add IntelMPI modules on Chrysalis — azamat / githubweb
  703. fixing unit tests and minor formatting — oksana.guba / githubweb
  704. clean up — oksana.guba / githubweb
  705. Add new compsets and atm use_case files for v2 — wlin / githubweb
  706. Correct closing tag  for some clubb params in use_case files. — wlin / githubweb
  707. Add v2 setting for missing micro_mg_accre_enhan_fac — wlin / githubweb
  708. Set default atmos parameters for v2 in existing compsets — wlin / githubweb
  709. Update elm config_component to set proper use case for new  compsets — wlin / githubweb
  710. Fix CPP variable for filtered VT — hannah6 / githubweb
  711. Using pointers to avoid unnecessary copies of data — balwindersingh / githubweb
  712. Add support for chrysalis to provenance.py — worleyph / githubweb
  713. Add job monitoring script for chrysalis — worleyph / githubweb
  714. time level fix for SCM — bogensch / githubweb
  715. fix spacing issues — bogensch / githubweb
  716. Change default location for SAVE_TIMING_DIR on Chrysalis — worleyph / githubweb
  717. Update mpas-source: Updated sea ice for algal grazing bug — akt / githubweb
  718. minor bug fixes bring fates api to 14.2 — rgknox / githubweb
  719. Remove I_MPI_ADJUST_ALLREDUCE=1 on Chrysalis — azamat / githubweb
  720. I am trying to re-add the links to the externals that were in conflict during — bmg2 / githubweb
  721. Trying to revert the remainder of these merge-conflicted externals to the — bmg2 / githubweb
  722. Adding externals/YAKL to the list — bmg2 / githubweb
  723. Remove FFT test scripts — whannah1 / githubweb
  724. Remove ifdefs for MMF variance transport — whannah1 / githubweb
  725. VT namelist change — whannah1 / githubweb
  726. VT bug fix in configure — hannah6 / githubweb
  727. I am making this commit to fix the recent merge of the E3SM master branch into — bmg2 / githubweb
  728. Removing a duplicate print statement for all CLUBB tunable parameters. — bmg2 / githubweb
  729. update comments — bogensch / githubweb
  730. fix planar test directories — celdred / githubweb
  731. I made changes necessary for postprocessing the updated output files, where — bmg2 / githubweb
  732. Changing the E3SM-CLUBB plot files to account for the file naming convention — bmg2 / githubweb
  733. Address PR comments — whannah1 / githubweb
  734. Widen halo for Redi hmix computation — mpetersen / githubweb
  735. VT bug fix — hannah6 / githubweb
  736. Update CIME submodule — jgfouca / githubweb
  737. Rename default v2 compsets and use_case files — wlin / githubweb
  738. Set back the CIME commit to avoid PIO issues — jgfouca / githubweb
  739. Clean up av1c/f series of compsets except *AV1C-L and FC5AV1C-H01A for nightly tests — wlin / githubweb
  740. Rename namelist_defaults_cam.xml to namelist_defaults_eam.xml — wlin / githubweb
  741. Add chrysalis prov — jgfouca / githubweb
  742. Homme, SL: Add typedef to make SL transport run in a GPU build. — ambradl / githubweb
  743. Homme, EAM: More details for dt_remap_factor and dt_tracer_factor. — ambradl / githubweb
  744. Add new semi-implicit namelist groups to ocean namelist — mpetersen / githubweb
  745. Update ocean build-namelist with new namelists for semi-implicit — mpetersen / githubweb
  746. Add bfb thread mode for semi-implicit — mpetersen / githubweb
  747. Update flag name — mpetersen / githubweb
  748. Update mpas-source — mpetersen / githubweb
  749. Adds support for NA RRM grid on ELM — gautam.bisht / githubweb
  750. fix enax and twpx  runs — oksana.guba / githubweb
  751. Update mpas-o namelist definitions with output from automated scripts — jonbob / githubweb
  752. update mpas-source: cosine bell test case — mpetersen / githubweb
  753. Update mpas-source: Port ocean velocity to GPU — mturner / githubweb
  754. Enable Cray compiler on Theta — azamat / githubweb
  755. Use ceiling for number of job nodes — azamat / githubweb
  756. Update modules — azamat / githubweb
  757. Add cray compiler to ChemPreprocess.pm — azamat / githubweb
  758. Update Cray compiler to cce/10.0.3 on Theta — azamat / githubweb
  759. Remove darshan for Cray compiler on Theta — azamat / githubweb
  760. Fixes a NBFB issue when clubb_use_sgv and zmconv_tp_fac are used — balwindersingh / githubweb
  761. Add grid definition and maps for bi-grid NA RRM — tang30 / githubweb
  762. mpas clean-up: remove compass/ocean, add doc template — mpetersen / githubweb
  763. Adds support for NA RRM grid on ELM — tang30 / githubweb
  764. Add gnu modules for intel-mpi on Chrysalis — azamat / githubweb
  765. Updates the name of surface data files — gautam.bisht / githubweb
  766. Updates the hgrid names — gautam.bisht / githubweb
  767. More changes due to renmaing of hgrid — gautam.bisht / githubweb
  768. I updated the version of CLUBB and SILHS in the latest E3SMv2 NGD — bmg2 / githubweb
  769. Committed some E3SM-sided updates to work with the new version of CLUBB-SILHS. — bmg2 / githubweb
  770. Enable test runs on compute nodes on Chrysalis — azamat / githubweb
  771. Update HOMME cmake files on Chrysalis — azamat / githubweb
  772. Reverted accidently modified vertical_diffusion.F90 file — balwindersingh / githubweb
  773. Fix uninitialized pblt600 and replace a remaining FC5AV1C-04P2 test — wlin / githubweb
  774. homme_tool fixes for interpolating NE1024 data — mt / githubweb
  775. fix index bug — mt / githubweb
  776. update cori.job script to use threads — mt / githubweb
  777. Further updates to CLUBB, which will be "made official" later. — bmg2 / githubweb
  778. I added subcol_SILHS_vert_decorr_coef to the namelist. — bmg2 / githubweb
  779. I added subcol_SILHS_vert_decorr_coef to namelist_definition.xml. — bmg2 / githubweb
  780. Add procs-per-node option to intel-mpi mpirun on Chrysalis — azamat / githubweb
  781. Update mappy to gcc-8.1.0 to match summit — jgfouca / githubweb
  782. Update mpas-source: fixed seaice column message threading bug — akt / githubweb
  783. Modifying E3SM to work with the latest version of CLUBB-SILHS. — bmg2 / githubweb
  784. Adding clubb_C_invrs_tau_wpxp_Ri and clubb_C_invrs_tau_wpxp_N2_thresh — bmg2 / githubweb
  785. Consolidate v2 atm parameter values into a common default file — wlin / githubweb
  786. Run intel-mpi with slurm srun on Chrysalis — azamat / githubweb
  787. I am officially upgrading the version of CLUBB and SILHS used in E3SM to — bmg2 / githubweb
  788. Altered the git commit hash in the run script to reflect the updated — bmg2 / githubweb
  789. Resetting clubb_debug_level from 3 to 2 allows us to get rid of the — bmg2 / githubweb
  790. Adds test SMS.northamericax4v1pg2_WC14to60E2r3_ICG.A_WCYCL1850S_CMIP6 — balwindersingh / githubweb
  791. Simplify and use srun for homme on Chrysalis — azamat / githubweb
  792. Updating to Scorpio ver 1.1.6 — jayesh / githubweb
  793. Fix calc. for max. number of levels when using noI8 and update comments — worleyph / githubweb
  794. Update mappy serial env — jgfouca / githubweb
  795. I am changing TTEND_CLUBB back to STEND_CLUBB for use in output statistics. — bmg2 / githubweb
  796. Some mods to the test, shell commands  and the use case files — balwindersingh / githubweb
  797. Removed some unused user_nl* files — balwindersingh / githubweb
  798. Changes test name to remove "v2" — balwindersingh / githubweb
  799. Update mpas-source: propagate ocn_diagnostics_variables to shared/ — mturner / githubweb
  800. Update argument lists in ocn_comp_mct for recent MPAS-O changes — mturner / githubweb
  801. Update CIME submodule — jgfouca / githubweb
  802. I updated draw_clubb_budget.py to reflect the CLUBB stat name change — bmg2 / githubweb
  803. Added history fields back with cosp turned on — balwindersingh / githubweb
  804. Adds an "S" PE layout anvil — balwindersingh / githubweb
  805. Update framework in mpas-source — mpetersen / githubweb
  806. Update CXXFLAGS — azamat / githubweb
  807. Use ocn_diagnostics_variables in ocn_comp_mct driver — mturner / githubweb
  808. Explicitly specify UCX transport — jayesh / githubweb
  809. Update mpas-source: finish propagating ocn_diagnostics_variables — mturner / githubweb
  810. Update cime again to remove PIO performance degradation — jgfouca / githubweb
  811. Fixes for F-EAMv1 and F-MMF1 compsets needed after phys name change — wlin / githubweb
  812. Adding PE layouts for v2RRM on cori-knl — ndkeen / githubweb
  813. I am cherry-picking git commit 6e2592c from January 13, 2021 and adding — bmg2 / githubweb
  814. CIME submodule update — jgfouca / githubweb
  815. update mpas-source: Move surface pressure and zMid before EOS — mpetersen / githubweb
  816. Fix restart NBFB when clubb_ipdf_call_placement=2 — wlin / githubweb
  817. implement esmt to samxx — xyuan / githubweb
  818. fix dmdf_write typo — xyuan / githubweb
  819. Add 2 degree mosart grid as option — jacob / githubweb
  820. Add r2_r2 grid alias and r2 domain — jacob / githubweb
  821. fix some VT implementation issues — xyuan / githubweb
  822. CIME submodule update — jgfouca / githubweb
  823. Remove _ICG ocn/ice grids, instead cue off compset option SPUNUP — jonbob / githubweb
  824. Fix for aero_model when chem is none after phys namm change — wlin / githubweb
  825. Hommexx: bug fix in RemapStateProvider — lbertag / githubweb
  826. Hommexx: test also tracers in remap_theta_ut — lbertag / githubweb
  827. Update mpas-source: Improved sea ice column error messages — akt / githubweb
  828. Change from keying off %SPUNUP to including SOI in compset longname — jonbob / githubweb
  829. I am altering P3 for SILHS by making changes equivalent to the — bmg2 / githubweb
  830. Fix an issue that uses dcape related codes when ZM is not used — wlin / githubweb
  831. Updates MPAS ocean and sea ice conditions — luke.vanroekel / githubweb
  832. Updates defaults for EC30to60 and WC14 — luke.vanroekel / githubweb
  833. update mpas-source: make ocean init mode optional — mpetersen / githubweb
  834. Update E3SM bld scripts to reflect changes to the ocean Registry — mpetersen / githubweb
  835. Remove the "-1900" grids as a mechanism for designating different ICs — jonbob / githubweb
  836. I am exporting the fields from P3 microphysics that are necessary — bmg2 / githubweb
  837. Add default layouts for G-cases using EC30to60 on anvil/chrysalis/compy — jonbob / githubweb
  838. Add domain file for r2 — jacob / githubweb
  839. update mpas-source: Fix core_ocean submodule checks in cmake — mpetersen / githubweb
  840. for chrsyalis: initial set of PE layouts for RRMv2 — ndkeen / githubweb
  841. Update default ne30-WC pelayout — azamat / githubweb
  842. Default to a 60-node pelayout — azamat / githubweb
  843. Update cray-specific flags — azamat / githubweb
  844. Update FFLAGS and rename abort redeclarations — azamat / githubweb
  845. Update cray modules — azamat / githubweb
  846. unifies WC14 and EC30to60 del2 and del4 — luke.vanroekel / githubweb
  847. Fix an issue in nudging code — shixuan.zhang / githubweb
  848. Update mpas-ocean: Fixes shortwave absorption for shallow cells — mpetersen / githubweb
  849. Allow time:point cell method — jacob / githubweb
  850. update mpas-source: Simplify computing landIcePressure and vertical grid in ocean init mode — mpetersen / githubweb
  851. Made changes necessary for CLUBB-SILHS-P3 to compile. — bmg2 / githubweb
  852. Replace "+=" for grid related settings with "=" — jonbob / githubweb
  853. Update mpas-source: seaice regional stats bug — akt / githubweb
  854. eam h0 units CF compliance — zhang40 / githubweb
  855. Allow standard_name on variable in EAM — jacob / githubweb
  856. Add standard_names to some EAM output variables — jacob / githubweb
  857. Add dummy args to the call of aircraft_emit_init for the crm version. — wlin / githubweb
  858. Add more CMIP attributes — jacob / githubweb
  859. Additional changes to crm/physpkg.F90 made to cam/physpkg.F90 in this PR — wlin / githubweb
  860. Fix an issue in nudging code — shixuan.zhang / githubweb
  861. update to topo generation tool — mt / githubweb
  862. improve omp reduction — mt / githubweb
  863. fix incorrect comment — mt / githubweb
  864. remove SHARED omp directive — mt / githubweb
  865. Add optional pattern matching for SOI in compset names — jonbob / githubweb
  866. Remove some use_case files not used in v2 — wlin / githubweb
  867. Fix standard_name for  TGCLDCWP TGCLDLWP — jacob / githubweb
  868. Add standard_names for FLUT, SWCF, LWCF, PRECC, PRECT — wlin / githubweb
  869. Add ability to pass standard_name when defining history — jacob / githubweb
  870. Remove standard_names for PRECC, PRECT, FLUT — wlin / githubweb
  871. Make sure standard_name is output — jacob / githubweb
  872. update mpas-source: Add Wright (1997) equation of state — mpetersen / githubweb
  873. Update CIME submodule — jgfouca / githubweb
  874. Cleanup of unused compsets and grids for v2 — wlin / githubweb
  875. Update bld scripts to match changes in ocean core Registry — jonbob / githubweb
  876. Updated for my changes so far to run P3. — bmg2 / githubweb
  877. Add and update global attributies — jacob / githubweb
  878. Add a couple of standard names — jacob / githubweb
  879. Fix CF units and change spval — jacob / githubweb
  880. Put back use_case 1850_cam5_av1c-04p2 to avoid diff of A_WCYCL1850 tests — wlin / githubweb
  881. Update MOSART output for CF and CMIP — jacob / githubweb
  882. Restore accidentally removed compset FSCM5A97 — wlin / githubweb
  883. Update mpas-source: pgi syntax fix — mturner / githubweb
  884. Run CircleCI on master branch only — lukasz / githubweb
  885. update mpas-source: Removes shortwave energy conservation fix — mpetersen / githubweb
  886. Remove 1950 and 2010 specific build-config entries — wlin / githubweb
  887. Restore spval and fillvalue to 1.e36 — jacob / githubweb
  888. Update mpas-ocean bld scripts to match changes to Registry — jonbob / githubweb
  889. Reorder check for bgc and spunup options to get the correct ICs — jonbob / githubweb
  890. update mpas-source: Fixes missing edgeSignOnCell in redi_term2 — mpetersen / githubweb
  891. Run CircleCI on all branches — lukasz / githubweb
  892. Updates WC14 and EC30to60 initial conditions — luke.vanroekel / githubweb
  893. Get verbose output from case.build in CircleCI test — lukasz / githubweb
  894. Corrected the name for  compset alias F-EAM-RCEMIP — wlin / githubweb
  895. update mpas-source: framework update — mpetersen / githubweb
  896. Remove redundant compy G-case layout, use previous layout for new grid — jonbob / githubweb
  897. More changes for running CLUBB-SILHS with P3 ... — bmg2 / githubweb
  898. update mpas-source: stand-alone makefile addition — mpetersen / githubweb
  899. update mpas-source: stand-alone ocean output to single precision — mpetersen / githubweb
  900. Trying to get CLUBB-SILHS-P3 to run — bmg2 / githubweb
  901. update mpas-source: Simplifies the shortwave fixer formulation — mpetersen / githubweb
  902. Add bottomLayerShortwaveTemperatureFlux to timeSeriesStatsMonthlyOutput stream — jonbob / githubweb
  903. Enable shortwave_energy_fixer by default — jonbob / githubweb
  904. make vtheta_thresh a namelist variable — mt / githubweb
  905. typo — mt / githubweb
  906. improve comments — mt / githubweb
  907. update mpas-source: sediment transport design document — mpetersen / githubweb
  908. update mpas-source: cleanup of ocean split-explicit driver — mpetersen / githubweb
  909. adjust constant — oksana.guba / githubweb
  910. Updating to Scorpio version 1.2.0 — jayesh / githubweb
  911. Update mpas-source: init mode case — mpetersen / githubweb
  912. I have edited the P3 interface in an attempt to get everything working. — bmg2 / githubweb
  913. I updated the checkout of scorpio so we'd have a bug fix. — bmg2 / githubweb
  914. With these changes to some of the code in SILHS, CLUBB-SILHS-P3 finally runs to completion!! — bmg2 / githubweb
  915. Edited so that the code still works with MG microphysics. — bmg2 / githubweb
  916. I officially updated the code to read in version 4.1.1 of the P3 lookup tables. — bmg2 / githubweb
  917. Fixed the memory bug. — bmg2 / githubweb
  918. We made some code changes to get these runs in Issue 36, https://github.com/larson-group/e3sm/issues/36#issuecomment-831637272. 1) shut off the detrainment scheme in clubb_intr.F90, 2) reduce v_qit=v_nit by 2 in micro_p3.F90 — guozhun / githubweb
  919. NGD_wP3.csh is the new script for Issue 36, https://github.com/larson-group/e3sm/issues/36#issuecomment-831637272. — guozhun / githubweb
  920. C_invrs_tau_N2_wpxp_thresh = 2.3 for run D in Issue 36,https://github.com/larson-group/e3sm/issues/36#issuecomment-831637272. — guozhun / githubweb
  921. Getting rid of uninitialized memory when P3 is used. — bmg2 / githubweb
  922. Additional correction to go along with the previous commit. — bmg2 / githubweb
  923. Update micro_p3.F90 — noreply / githubweb
  924. I am officially committing the official fix to the memory bug that — bmg2 / githubweb
  925. The path to cime in .gitmodules was not correct. — bmg2 / githubweb
  926. Mopping up after the recent merge of the master. This version of the code actually runs now ... — bmg2 / githubweb
  927. Adding F2010SC5-P3 compset — bmg2 / githubweb
  928. Add CO2 mixing ratio to be consistent with CMIP6 compset — bmg2 / githubweb
  929. Add run script for Compy; ne120 cld_macmic_num_steps = 6 — bmg2 / githubweb
  930. Comment-out the explicit physical setting that are applied through the compset — bmg2 / githubweb
  931. Add/remove IC for run script — bmg2 / githubweb
  932. Removing gibberish added during the most recent cherry-pick merge. — bmg2 / githubweb
  933. Adding the KK-2000/Accretion tuning params — bmg2 / githubweb
  934. P3 + Cooper; Adding new flag to control the usage of Cooper scheme, while disable the Meyers scheme in <nucleate_ice.F90> — bmg2 / githubweb
  935. Committing new runscripts — bmg2 / githubweb
  936. Removing the setting of CLUBB stats output variables from the runscript — bmg2 / githubweb
  937. Updated run script — bmg2 / githubweb
  938. I am committing some small changes to my 1 degree run scripts. — bmg2 / githubweb
  939. I added "seasonally continuous" and "seasonally discontinuous" functionality — bmg2 / githubweb
  940. I am adding the run script for quarter degree production runs. — bmg2 / githubweb
  941. I updated the version of CLUBB and SILHS to version b0feee8 from May 27, 2021. — bmg2 / githubweb
  942. A by-hand redo of commit 814dc04 to the clubb_silhs_devel branch on Feb 4, 2021. — bmg2 / githubweb
  943. This is a hand-merge of commit 9b7b8b6 to the clubb_silhs_devel branch on March 15, 2021. — bmg2 / githubweb
  944. This is a hand re-do of commit e708e6e to the clubb_silhs_devel branch — bmg2 / githubweb
  945. This is a by-hand redo of commit 2f1647c to the clubb_silhs_devel branch — bmg2 / githubweb
  946. A by-hand redo of commit b4fd9aa to the clubb_silhs_devel branch from — bmg2 / githubweb
  947. This is a by-hand cherry-pick of commit 0af8b9a (to the clubb_silhs_devel — bmg2 / githubweb
  948. I am committing a by-hand cherry-pick of commit f3d5061 that was made to the — bmg2 / githubweb
  949. I am committing a by-hand cherry-pick of revision 1f63abb from April 29, 2021, — bmg2 / githubweb
  950. This is a by-hand cherry-pick of commit 853a408 from May 4, 2021, which — bmg2 / githubweb
  951. I am committing a by-hand cherry-pick of commit 85ff2e6 from May 4, 2021, — bmg2 / githubweb
  952. I am committing a by-hand cherry-pick of commit 33d4507 from May 4, 2021, — bmg2 / githubweb
  953. I am committing a by-hand cherry-pick of commit 3482c3a from March 7, 2021, — bmg2 / githubweb
  954. This by-hand cherry-pick is actually 2 cherry-picks for the price of 1!!! — bmg2 / githubweb
  955. I am committing a by-hand cherry-pick of commit ad5378e from May 12, 2021, which — bmg2 / githubweb
  956. Changing clubb_up2_vp2_factor to clubb_up2_sfc_coef to correspond with — bmg2 / githubweb
  957. I am changing some of the run scripts to reflect a recent name change in CLUBB. — bmg2 / githubweb
  958. I am updating runscripts based on a recent name change in CLUBB, where — bmg2 / githubweb
  959. Fixed some whoopsies — bmg2 / githubweb
  960. I am fixing the bug that reorded the column/subcolumn indices in state_sc. This — bmg2 / githubweb
  961. I changed the tolerance on the snow balance error check in the land module — bmg2 / githubweb
  962. Add module load per5-extras for cori machines — bmg2 / githubweb
  963. P3 update and new compsets for AMIP simulations — bmg2 / githubweb
  964. Add simplied v2 run script template run.F20TR-P3.template.sh — bmg2 / githubweb
  965. Change pe-layout to 64x2 on 338 nodes for ne120 on cori-knl — bmg2 / githubweb
  966. Fixed a typo and commented out a line to get the code to compile and run! — bmg2 / githubweb
  967. Updated to use the correct finidat and fsurdat for a 0.25 degree production run. — bmg2 / githubweb
  968. This run repeat the [simulation](https://github.com/larson-group/e3sm/issues/36#issuecomment-881690516). Parameters setting is suggested by the tunner. — guozhun / githubweb
  969. Update the Machine files for Anvil. Issue #36. — guozhun / githubweb
  970. Make two different production run files for the 0.25 degree simulations: — bmg2 / githubweb
  971. Update NGD_wP3_1deg_prod_run.csh — noreply / githubweb
  972. Update micro_p3.F90 — noreply / githubweb
  973. Readying scripts for production runs using the final tuning. — bmg2 / githubweb
  974. Renaming the 1 degree production run script to specify use on Anvil. — bmg2 / githubweb
  975. New file name — bmg2 / githubweb
  976. Updated for new AMIP run script, plus updated stats on 1 deg run script. — bmg2 / githubweb
  977. Removing the offensive ZM variables out of the fincl5 list, allowing — bmg2 / githubweb
  978. Added a special runscript for AMIP sstplus4K — bmg2 / githubweb
  979. Change the dang name! — bmg2 / githubweb
  980. Update NGD_wP3_1deg_prod_run_anvil.csh — noreply / githubweb
  981. Changing clubb_rainevap_turb to false. — bmg2 / githubweb
  982. Removing finidat (initial condition files) for the AMIP runs, following — bmg2 / githubweb
  983. Adding the runscript for the 25 month control run for aerosol production. — bmg2 / githubweb
  984. Added the script for the active end of the Aerosol-Cloud Interaction — bmg2 / githubweb
  985. I am adding Zhun's remap_ne30pg2.csh script to the remap directory. — bmg2 / githubweb
  986. Fixed an error — bmg2 / githubweb
  987. Add files via upload — noreply / githubweb
  988. Committing temporary changes — bmg2 / githubweb
  989. Update NGD_wP3_1deg_prod_run_anvil.csh — noreply / githubweb
  990. Update NGD_wP3_1deg_AMIP_prod_run_anvil.csh — noreply / githubweb
  991. Update NGD_wP3_1deg_AMIP_sstplus4K_prod_run_anvil.csh — noreply / githubweb
  992. Update micro_p3.F90 — noreply / githubweb
  993. Update NGD_wP3_1deg_F2010-CTL_prod_run_anvil.csh — noreply / githubweb
  994. Update NGD_wP3_1deg_F2010-piAEROSOL_prod_run_anvil.csh — noreply / githubweb
  995. Update NGD_wP3_1deg_prod_sens.csh — noreply / githubweb
  996. I am updating the version of CLUBB and SILHS used in E3SM to — bmg2 / githubweb
  997. Made updates to both clubb_intr.F90 and subcol_SILHS.F90 in order — bmg2 / githubweb
  998. I altered the nightly test run scripts to be consistent with what's — bmg2 / githubweb
  999. Adding some additional files that need to be ported over from — bmg2 / githubweb
  1000. Fixing compilation bugs. — bmg2 / githubweb
  1001. Adding ifdef SILHS preprocessor flags around a conditional in subcol_SILHS.F90 — bmg2 / githubweb
  1002. Added analyze_sensitivity_matrix.py to the diagnostic_v2_0 directory. — bmg2 / githubweb
  1003. I am updating config_machines.xml and config_compilers.xml — bmg2 / githubweb
  1004. Fixed the bug where clubb_params was reported to have parameters that — bmg2 / githubweb
  1005. Change user namelist name from "user_nl_cam" to "user_nl_eam". — noreply / githubweb
  1006. Change "F_SCAM5" to "F_SCAM" and "-phys cam5" to "-phys default" — noreply / githubweb
  1007. Change "F_SCAM5" to "F_SCAM" and "-phys cam5" to "-phys default" — noreply / githubweb
  1008. Change "F_SCAM5" to "F_SCAM" and "-phys cam5" to "-phys default" — noreply / githubweb
  1009. Updating the nelson's FFLAGS in config_compilers.xml — noreply / githubweb
  1010. Revert "Updating the nelson's FFLAGS in config_compilers.xml" — bmg2 / githubweb
  1011. I am committing a "manual cherry-pick" of git commit 1b238fe to the clubb_silhs_devel — bmg2 / githubweb
  1012. Updating micro_p3_interface.F90 so that it compiles on Nelson with the gfortran compiler. — bmg2 / githubweb
  1013. Adding w_up_in_cloud to the pbuf, which will eventually allow it to be ported — bmg2 / githubweb
  1014. Adding statistical output for w_up_in_cloud (stat name W_UP_IN_CL_CLUBB). — bmg2 / githubweb
  1015. The stat output for w_up_in_cloud should be on thermodynamic levels ('lev') — bmg2 / githubweb
  1016. I am fixing some of the statistical output level listings for variable CLUBB — bmg2 / githubweb
  1017. I am updating the nightly E3SM SCM scripts (for BOMEX, DYCOMS-II RF01, — bmg2 / githubweb
  1018. Add arm_97 case to the Jenkins e3sm_run_gfortran_test — bmg2 / githubweb
  1019. Updated the E3SM SCM runscript for ARM 97 for E3SM v2 code. — bmg2 / githubweb
  1020. Updating the ARM 97 E3SM SCM run script so that it runs with — bmg2 / githubweb
  1021. Getting rid of this hyper-annoying print statement. — bmg2 / githubweb
  1022. I am updating the version of CLUBB and SILHS in the brand new future — bmg2 / githubweb
  1023. Bringing the branch up-to-date with the changes that needed to be — bmg2 / githubweb
  1024. I updated the version of CLUBB in the future clubb_silhs_devel branch to be — bmg2 / githubweb

#103 (Feb 25, 2022, 3:36:06 AM)

  1. Fixing small bug that breaks runs with scalars. — Gunther Huebler / githubweb

#102 (Feb 24, 2022, 3:36:07 AM)

  1. Gunthers branch (#989) — noreply / githubweb

#101 (Feb 22, 2022, 3:36:10 AM)

  1. Refactoring to remove need for global stats scratch variables. (#988) — noreply / githubweb

#100 (Feb 18, 2022, 3:36:08 AM)

  1. Add arm_97 case to the Jenkins e3sm_run_gfortran_test — noreply / githubweb
  2. Pushing loop into solve_xm_wpxp_with_single_lhs (#986) — noreply / githubweb

#99 (Feb 17, 2022, 3:36:06 AM)

  1. Adding 2D version of zt2zm and zm2zt to clubb_api — Gunther Huebler / githubweb

#98 (Feb 16, 2022, 3:36:11 AM)

  1. Fixing log copy statements to allow test to run. — noreply / githubweb

#97 (Feb 14, 2022, 4:38:48 PM)

  1. Changing post step order to read log files before removing them. — pbroels / githubweb
  2. Fixing script to make the error code correct upon exit — Gunther Huebler / githubweb

#94 (Feb 10, 2022, 5:10:07 PM)

  1. I am fixing the issue with clubb_silhs_devel branch.  The arrays — bmg2 / githubweb

#93 (Feb 10, 2022, 2:50:10 PM)

  1. Script now exits with 1 when run fails. — Gunther Huebler / githubweb

#92 (Feb 10, 2022, 12:22:53 PM)

  1. Fixing ne4 jenkins script from small copy-paste error. — Gunther Huebler / githubweb

#90 (Feb 10, 2022, 3:36:08 AM)

  1. Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing. — Gunther Huebler / githubweb
  2. Added log file output in the post step so it is displayed when the test fails. — pbroels / githubweb

#89 (Feb 5, 2022, 3:36:07 AM)

  1. Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Pushing column loop into local functions. larson-group/clubb#972 — Gunther Huebler / githubweb

#88 (Feb 4, 2022, 3:36:07 AM)

  1. I added a subroutine that prints that values of all PDF parameters in — bmg2 / githubweb
  2. Small changes and a loop push. larson-group/clubb#972 — Gunther Huebler / githubweb
  3. Pushing loop into advance_xm_wpxp. larson-group/clubb#972 — Gunther Huebler / githubweb
  4. Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 — Gunther Huebler / githubweb

#87 (Feb 3, 2022, 3:36:09 AM)

  1. Fixed small bug that slipped through because the G_unit tests use nz=1. — Gunther Huebler / githubweb
  2. Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 — Gunther Huebler / githubweb

#83 (Feb 2, 2022, 3:36:09 AM)

  1. Pushing column index into zm2zt and zt2zm. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 — Gunther Huebler / githubweb
  3. A variety of small loop pushing. larson-group/clubb#972 — Gunther Huebler / githubweb

#82 (Jan 29, 2022, 3:36:23 AM)

  1. Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Making sure that ice_supersat_frac is configured properly for restarts — bmg2 / githubweb
  3. Fixed an array size mismatch — bmg2 / githubweb
  4. Added an initialization for ice_supersat_frac — bmg2 / githubweb
  5. Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 — Gunther Huebler / githubweb

#81 (Jan 28, 2022, 1:05:22 PM)

  1. Making compatible with latest clubb change. — Gunther Huebler / githubweb

#80 (Jan 28, 2022, 3:36:24 AM)

  1. I am updating ice_supersat_frac to be an intent(inout) variable for — bmg2 / githubweb

#79 (Jan 27, 2022, 3:36:25 AM)

  1. We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 — Gunther Huebler / githubweb

#78 (Jan 26, 2022, 3:36:23 AM)

  1. Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Making a commit that officially places the call to the PDF in the "post" — bmg2 / githubweb
  3. Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 — Gunther Huebler / githubweb
  4. Forgot an & symbol. — Gunther Huebler / githubweb

#77 (Jan 25, 2022, 3:36:23 AM)

  1. Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb

#76 (Jan 22, 2022, 3:36:25 AM)

  1. Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence — bmg2 / githubweb

#75 (Jan 21, 2022, 3:36:23 AM)

  1. Breaking up column loop in advance_clubb_core. larson-group/clubb#972 — Gunther Huebler / githubweb

#74 (Jan 20, 2022, 3:36:24 AM)

  1. Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Making e3sm use the single column version of advance clubb core directly, since it does not want to use the interface version. larson-group/clubb#972 — Gunther Huebler / githubweb
  3. Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 — Gunther Huebler / githubweb

#71 (Jan 19, 2022, 3:36:24 AM)

  1. Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Update the config_compilers.xml for carson. — noreply / githubweb

#70 (Jan 17, 2022, 3:36:24 AM)

  1. Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm — noreply / githubweb

#69 (Jan 15, 2022, 3:36:24 AM)

  1. Updated e3sm to fit the new clubb driver api — noreply / githubweb
  2. Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that — bmg2 / githubweb

#68 (Jan 14, 2022, 3:36:24 AM)

  1. This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. — Gunther Huebler / githubweb
  2. Changing the value of C_invrs_tau_shear from 0.02 to 0.15. — bmg2 / githubweb
  3. Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. — Gunther Huebler / githubweb

#67 (Jan 13, 2022, 3:36:25 AM)

  1. Making some paramters_silhs variables available from the silhs api — Gunther Huebler / githubweb
  2. Comment out setting of fatal error — noreply / githubweb

#66 (Jan 12, 2022, 3:36:26 AM)

  1. Making api version of setup_grid. larson-group/clubb#972 — Gunther Huebler / githubweb

#65 (Jan 11, 2022, 3:36:26 AM)

  1. Insert print about overwriting default flags with namelist values — noreply / githubweb
  2. Insert print about overwriting default parameters with namelist values — noreply / githubweb

#64 (Jan 7, 2022, 3:36:23 AM)

  1. Reverting to using Gfortran 8 temporarily to get things working. — pbroels / githubweb

#63 (Jan 6, 2022, 5:12:25 PM)

  1. Adding omitted lines to the call to advance_clubb_core_api. — bmg2 / githubweb

#62 (Dec 31, 2021, 3:36:23 AM)

  1. I am updating clubb_intr.F90 to account for recent changes to the call to — bmg2 / githubweb

#61 (Dec 30, 2021, 3:36:22 AM)

  1. I am adding more arguments to the argument list for advance_clubb_core — bmg2 / githubweb

#60 (Dec 29, 2021, 3:36:24 AM)

  1. Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. — bmg2 / githubweb
  2. Now that uprcp and vprcp have been passed through advance_clubb_core, — bmg2 / githubweb

#59 (Dec 18, 2021, 3:36:25 AM)

  1. These changes allow you to call the 4 clubb "advance" subroutines in any — Brian Griffin / githubweb
  2. Placing the order variables in a nice, convenient place for testing use. — Brian Griffin / githubweb
  3. I reordered advance_clubb_core so that the "Advance xp3" (which is a — Brian Griffin / githubweb
  4. I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx — Brian Griffin / githubweb
  5. I am indenting the portion of the code where the advance subroutines — Brian Griffin / githubweb
  6. Temporarily commenting out the idiot proofing in order to run some tests ... — Brian Griffin / githubweb
  7. Now official reinstating the idiot-proofing and turning off the — bmg2 / githubweb
  8. I am committing some idiot proofing in regards to the advance — bmg2 / githubweb
  9. Updating for the latest version of CLUBB. — bmg2 / githubweb

#58 (Dec 4, 2021, 3:36:25 AM)

  1. Remove clipping from a3_coef. — noreply / githubweb

#57 (Dec 3, 2021, 3:36:25 AM)

  1. See ticket — jan.gruenenwald / githubweb
  2. added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — jan.gruenenwald / githubweb
  3. See respective messages on the issue 958 on date 10/12/2021 — jan.gruenenwald / githubweb
  4. Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — jan.gruenenwald / githubweb
  5. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — jan.gruenenwald / githubweb
  6. Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — jan.gruenenwald / githubweb
  7. fixed a typo in pdf_closure_module.f90, line 1284 — jan.gruenenwald / githubweb
  8. fixed compiler warning regarding w_up_in_cloud — jan.gruenenwald / githubweb

#56 (Nov 16, 2021, 3:36:07 AM)

  1. Passing w_up_in_cloud out of advance_clubb_core — bmg2 / githubweb
  2. Updating clubb_intr.F90 for the changes to advance_clubb_core_api — bmg2 / githubweb

#55 (Nov 12, 2021, 3:36:11 AM)

  1. See ticket — 68997723+JanGrn / githubweb
  2. added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — 68997723+JanGrn / githubweb
  3. See respective messages on the issue 958 on date 10/12/2021 — 68997723+JanGrn / githubweb
  4. Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — 68997723+JanGrn / githubweb
  5. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — 68997723+JanGrn / githubweb
  6. Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — 68997723+JanGrn / githubweb
  7. fixed a typo in pdf_closure_module.f90, line 1284 — 68997723+JanGrn / githubweb

#54 (Nov 6, 2021, 4:25:45 AM)

  1. Updating for changes to CLUBB. — bmg2 / githubweb

#53 (Nov 6, 2021, 3:36:07 AM)

  1. I have turned the nu_vert_res_dep family of variables into a derived — bmg2 / githubweb

#52 (Nov 5, 2021, 3:36:11 AM)

  1. I fixed a couple of errors. — bmg2 / githubweb

#51 (Nov 3, 2021, 3:36:08 AM)

  1. Applying the fix for the new CLUBB code to the developmental — bmg2 / githubweb

#50 (Nov 2, 2021, 3:36:11 AM)

  1. Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690.  There was some overcounting of the relevant terms. — benjamin.andrew.stephens / githubweb

#49 (Oct 31, 2021, 3:36:08 AM)

  1. I forgot to add this necessary subroutine call to the clubb API. — bmg2 / githubweb

#48 (Oct 30, 2021, 3:36:07 AM)

  1. I have passed clubb_params down into advance_xm_wpxp_module.F90. — bmg2 / githubweb
  2. I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. — bmg2 / githubweb
  3. I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 — bmg2 / githubweb
  4. Passing down more of CLUBB's tunable parameters. — bmg2 / githubweb
  5. I accidentally removed an important comment in the previous commit. — bmg2 / githubweb
  6. Passing down more CLUBB tunable parameters. — bmg2 / githubweb
  7. More passing down CLUBB parameters ... whoop-de-doo — bmg2 / githubweb
  8. Passing down more tunable parameters and removing references to — bmg2 / githubweb
  9. Handling the abomination that is lmin. — bmg2 / githubweb
  10. Passing tunable parameters into the new tau code. — bmg2 / githubweb
  11. Passed down more parameters. Results are bit-for-bit. — bmg2 / githubweb
  12. Passing through more clubb parameters. Bit-for-bit — bmg2 / githubweb
  13. Passing down CLUBB's tunable parameters into the setup_pdf_parameters and — bmg2 / githubweb
  14. Passing down CLUBB's tunable parameters into the remainder of the — bmg2 / githubweb
  15. I passed down the forgotten thlp2_rad_coef tunable parameter. — bmg2 / githubweb
  16. I am passing down the forgotten parameter, altitude threshold, in — bmg2 / githubweb
  17. I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
  18. I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
  19. Adding an option to use invrs_tau_N2_iso for C4 terms.  The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233).  The flag is currently set to false so results will be b4b. — 59519056+bstephens82 / githubweb
  20. Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion.  This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. — 59519056+bstephens82 / githubweb
  21. Adding comments for clarity. — 59519056+bstephens82 / githubweb

#47 (Oct 28, 2021, 3:36:07 AM)

  1. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/968. — benjamin.andrew.stephens / githubweb
  2. Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3.  Relevant to CLUBB issue #920. — 59519056+bstephens82 / githubweb
  3. Updates as requested to the l_use_tke_in_K_dfsn code: — 59519056+bstephens82 / githubweb

#46 (Oct 27, 2021, 3:36:07 AM)

  1. Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test.  I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. — benjamin.andrew.stephens / githubweb

#45 (Oct 23, 2021, 3:36:11 AM)

  1. These updates incorporate some of Shixuan Zhang's changes, including: — benjamin.andrew.stephens / githubweb

#44 (Oct 15, 2021, 3:36:09 AM)

  1. Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix.  I included comments to describe why this was done.  Results are b4b. — benjamin.andrew.stephens / githubweb

#43 (Oct 13, 2021, 3:36:11 AM)

  1. Removing line to trigger the nightly tests for all repos. — noreply / githubweb

#42 (Oct 5, 2021, 3:36:08 AM)

  1. Add a blank line to trigger nightly tests. — noreply / githubweb

#41 (Oct 2, 2021, 3:36:07 AM)

  1. Updates to separate out C4 and C14 in advance_xp2 module.  This will make it easier to control which invrs_tau_* variable multiplies each term for example. — 59519056+bstephens82 / githubweb
  2. Changing the name of dummy_1d variables for clarity. — 59519056+bstephens82 / githubweb

#40 (Sep 25, 2021, 3:36:06 AM)

  1. I am fixing a bug that was introduced in 6b0348e, where the logical — bmg2 / githubweb

#39 (Sep 16, 2021, 3:36:06 AM)

  1. Add space to trigger nightly tests.  For larson-group/sys_admin#755. — noreply / githubweb

#38 (Sep 14, 2021, 3:36:08 AM)

  1. Adding space to trigger autoupdate. larson-group/sys_admin#755 — Gunther Huebler / githubweb
  2. Adding space to trigger autoupdate. larson-group/sys_admin#755 — Gunther Huebler / githubweb
  3. Remove space to trigger autoupdate. larson-group/sys_admin#755 — noreply / githubweb

#34 (Sep 3, 2021, 3:36:07 AM)

  1. Pushing k loop down through clip_variance_level. — rhodesk / githubweb
  2. Pushing k loop down through clip_variance_level. — rhodesk / githubweb
  3. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. — 59519056+bstephens82 / githubweb
  4. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. — 59519056+bstephens82 / githubweb
  5. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. — 59519056+bstephens82 / githubweb
  6. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. — 59519056+bstephens82 / githubweb
  7. Updating some comments related to the tuner updates. — 59519056+bstephens82 / githubweb
  8. Updating some comments related to the tuner updates. — 59519056+bstephens82 / githubweb

#33 (Sep 2, 2021, 3:36:07 AM)

  1. Removing a couple of unused parameters from use statement. — noreply / githubweb
  2. Removing a couple of unused parameters from use statement. — noreply / githubweb

#32 (Sep 1, 2021, 3:36:10 AM)

  1. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  2. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  3. Eliminating l_include_ice and sat_ice_ratio. — rhodesk / githubweb
  4. Eliminating l_update_pressure flag. — rhodesk / githubweb
  5. Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
  6. Updating the surface clipping coefficient... — noreply / githubweb
  7. Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb

#31 (Aug 31, 2021, 3:36:08 AM)

  1. Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb
  2. Reflecting changes made to clubb in host models — 72510114+RhodesKeegan / githubweb
  3. Adding clubb directory for testing — 72510114+RhodesKeegan / githubweb
  4. Removing clubb and silhs directory for tonight's merge — 72510114+RhodesKeegan / githubweb

#30 (Aug 26, 2021, 3:36:09 AM)

  1. Updating the surface clipping coefficient... — noreply / githubweb

#29 (Aug 24, 2021, 1:18:38 PM)

  1. Fixing small pathing error in log reading step. larson-group/sys_admin#735 — pbroels / githubweb

#28 (Aug 24, 2021, 12:19:58 PM)

  1. Adding steps to display the logs. larson-group/sys_admin#735 — pbroels / githubweb
  2. Changing log reading proceedure since run logs for standard run test are not compressed. larson-group/sys_admin#735 — pbroels / githubweb

#27 (Aug 21, 2021, 3:36:09 AM)

  1. Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
  2. Reflecting changes made to clubb in host models — rhodesk / githubweb

#26 (Aug 19, 2021, 3:36:09 AM)

  1. For clubb:ticket:770, the Oracle compiler was throwing a floating point exception here. wpxp2 and xp2 were being fed in as Nans. — weberjk / githubweb
  2. The new file calc_roots.F90 contains functions that solve for the roots of a — bmg2 / githubweb
  3. I tweaked the precipitation fraction code so that the weighted ith PDF component — bmg2 / githubweb
  4. For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j. — raut / githubweb
  5. I updated pdf_closure_module.F90 by integrating changes I made in the — bmg2 / githubweb
  6. For cam:ticket:36: — raut / githubweb
  7. For cam:ticket:36#comment:132, I removed `gr` from the use statement in `setup_grid_heights_api`. — raut / githubweb
  8. For clubb:ticket:773, I fixed some unsoundness in our code regarding kinds, specifically in `parameters_model.F90` and `endian.F90`. — raut / githubweb
  9. For cam:ticket:41, the change in clubb:r7921 should be applied to the trunk as well. — raut / githubweb
  10. For clubb:ticket:775: — raut / githubweb
  11. For clubb:ticket:775: — raut / githubweb
  12. Misc. code cleanup — raut / githubweb
  13. I am updating default CLUBB to use the same hydrometeor PDF parameters that are — bmg2 / githubweb
  14. For cam:ticket:50: — raut / githubweb
  15. For cam:ticket:52: — raut / githubweb
  16. For cam:ticket:52, I added some parameter indices to the API. — raut / githubweb
  17. I forgot a parameter! — raut / githubweb
  18. For clubb:ticket:753: — raut / githubweb
  19. For clubb:ticket:782: — raut / githubweb
  20. I forgot a flag. — raut / githubweb
  21. For clubb:ticket:782: — raut / githubweb
  22. For cam:ticket:55, I added some parameters to CLUBB's API. — raut / githubweb
  23. For cam:ticket:55: — raut / githubweb
  24. I cleaned up some warnings from the Mac compiler. (build:14977) — raut / githubweb
  25. For clubb:ticket:785, I renamed `initvars` to `clubb_params_nl`. — raut / githubweb
  26. For clubb:ticket:785: — raut / githubweb
  27. For clubb:ticket:779: — raut / githubweb
  28. For clubb:ticket:786: — raut / githubweb
  29. For clubb:ticket:786: — raut / githubweb
  30. For clubb:ticket:782, I added all CLUBB's parameter indices to the API. — raut / githubweb
  31. helpful note — raut / githubweb
  32. more helpful note — raut / githubweb
  33. most helpful note — raut / githubweb
  34. For cam:ticket:56: — raut / githubweb
  35. While working on cam:ticket:59, I noticed that `tau_N2_zm` is computed twice. I removed one computation. — raut / githubweb
  36. Dat crazy indentation, though... — raut / githubweb
  37. For cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`. — raut / githubweb
  38. For cam:ticket:59: — raut / githubweb
  39. For cam:ticket:59: — raut / githubweb
  40. For cam:ticket:59: — raut / githubweb
  41. For cam:ticket:59, I added a new output for Richardson number. — raut / githubweb
  42. For cam:ticket:59: — raut / githubweb
  43. Per cam:ticket:59#comment:21, using `T_in_K_zm` in "the formula". — raut / githubweb
  44. For cam:ticket:59. — raut / githubweb
  45. For cam:ticket:59 I renamed `Richardson_no` to `Richardson_num`. — raut / githubweb
  46. For cam:ticket:59, I added kludgy statistical output for `brunt_vaisala_freq_sqd`. — raut / githubweb
  47. For cam:ticket:59: — raut / githubweb
  48. For cam:ticket:59: — raut / githubweb
  49. For cam:ticket:59: — raut / githubweb
  50. For cam:ticket:59. — raut / githubweb
  51. For cam:ticket:59: — raut / githubweb
  52. Apparently, I didn't have to jump through the hoop of declaring a separate profile to use in the `max` statement. — raut / githubweb
  53. For cam:ticket:59: — raut / githubweb
  54. For cam:ticket:59: — raut / githubweb
  55. For cam:ticket:59: — raut / githubweb
  56. For clubb:ticket:782: — raut / githubweb
  57. For cam:ticket:59: — raut / githubweb
  58. For cam:ticket:59: — raut / githubweb
  59. For cam:ticket:59: — raut / githubweb
  60. For cam:ticket:59: — raut / githubweb
  61. For clubb:ticket:782: — raut / githubweb
  62. For cam:ticket:59: — raut / githubweb
  63. For cam:ticket:59, I fixed bugs in the `l_use_C7_Richardson=T` vertical averaging code: — raut / githubweb
  64. I adjusted a comment. — raut / githubweb
  65. For clubb:ticket:788: — raut / githubweb
  66. For cam:ticket:59: — raut / githubweb
  67. For clubb:ticket:788: — raut / githubweb
  68. For clubb:ticket:788: — raut / githubweb
  69. For clubb:ticket:788: — raut / githubweb
  70. For clubb:ticket:788: — raut / githubweb
  71. For clubb:ticket:788: — raut / githubweb
  72. Renamed C7 to Cx in appropriate places. — raut / githubweb
  73. For cam:ticket:59: — raut / githubweb
  74. For cam:ticket:59: — raut / githubweb
  75. I made it a default to use 0 instead of cloud_frac_min in the B.V. frequency calculation. — raut / githubweb
  76. For cam:ticket:67: — raut / githubweb
  77. For cam:ticket:67: — raut / githubweb
  78. Code improvements. — raut / githubweb
  79. Vince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more! — raut / githubweb
  80. For cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used. — raut / githubweb
  81. Fixed a comment. — raut / githubweb
  82. For clubb:ticket:788: — raut / githubweb
  83. For clubb:ticket:792: — raut / githubweb
  84. For clubb:ticket:792: — raut / githubweb
  85. For clubb:ticket:792, I added more initializations for uninitialized variables. — raut / githubweb
  86. When l_avg_Lscale is turned on but the plume-centered calculation is disabled, — bmg2 / githubweb
  87. For clubb:ticket:792: — raut / githubweb
  88. For clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output. — raut / githubweb
  89. I renamed RH_postPDF to rel_humidity. — raut / githubweb
  90. For clubb:ticket:792. rsat actually should be recomputed here before output, because it will change if `l_rcm_supersat_adj = T`. — raut / githubweb
  91. For clubb:ticket:792. I am reusing the `rel_humidity` variable for output, for no particular reason. — raut / githubweb
  92. For clubb:ticket:792!!!! I set `l_rcm_supersat_adj = T` by default, in both source code and namelist. — raut / githubweb
  93. As requested, I am adding a warning message (debug level 1) when spurious supersaturation is removed. — raut / githubweb
  94. Comment. — raut / githubweb
  95. For clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010). — raut / githubweb
  96. I removed a spurious print statement. — raut / githubweb
  97. For cam:ticket:73: — raut / githubweb
  98. I am beginning to generalize the sponge damping code so that it can be applied to — bmg2 / githubweb
  99. I have added all the coding infrastructure to perform sponge damping (and record — bmg2 / githubweb
  100. Vince Larson / githubweb
  101. clubb:ticket:796 — roessle9 / githubweb
  102. I added some parameter value checking in subroutine setup_parameters. — bmg2 / githubweb
  103. I finally have a standalone version of the new subroutine, generate_pdf_params, — bmg2 / githubweb
  104. Some code within advance_clubb_core that is found within CAM_CLUBB preprocessor — bmg2 / githubweb
  105. The perturbation Lscale code requires rtm_frz, thlm_frz, and pdf_params_frz to — bmg2 / githubweb
  106. I added a missing intent(out) statement. — bmg2 / githubweb
  107. I have interfaced the new subroutine containing all of the PDF closure-related — bmg2 / githubweb
  108. I got rid of some variables that were brought into advance_clubb_core by use statements — bmg2 / githubweb
  109. I cleaned up more compiler warnings for unused variables.  The warnings came from g95. — bmg2 / githubweb
  110. I have added a second call to subroutine generate_pdf_params.  This one occurs — bmg2 / githubweb
  111. I moved the setting of qclvar and thlprcp_out to after the second call to — bmg2 / githubweb
  112. I have declared the l_use_ice_latent option and the l_call_pdf_closure_twice — bmg2 / githubweb
  113. I added a local cslculation of sigma_sqd_w near the top of subroutine — bmg2 / githubweb
  114. I am changing the inputs and outputs of subroutine advance_clubb_core so that — bmg2 / githubweb
  115. I added code so that stats that are internal to subroutine generate_pdf_params — bmg2 / githubweb
  116. I have updated subroutine advance_clubb_core so that pdf_params_zm is now passed — bmg2 / githubweb
  117. Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical — savva / githubweb
  118. Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical — savva / githubweb
  119. Vince Larson / githubweb
  120. Vince Larson / githubweb
  121. I added a new subroutine, init_pdf_params, to pdf_parameter_module.F90. — bmg2 / githubweb
  122. I renamed the subroutine pack_pdf_params found in setup_clubb_pdf_params.F90 — bmg2 / githubweb
  123. I am now using the new subroutine init_pdf_params to initialize the — bmg2 / githubweb
  124. I removed the CAM_CLUBB preprocessor directives from pack_pdf_params_api, — bmg2 / githubweb
  125. clubb:ticket:800 -- Changed fatal errors statements to debug level 0. — savva / githubweb
  126. I updated CLUBB stats so that wpthvp, wp2thvp, rtpthvp, and thlpthvp — bmg2 / githubweb
  127. I have added the coding infrastructure to output additional statistics — bmg2 / githubweb
  128. This is a bug fix for the Sun compiler.  The variables pdf_params_zm and — bmg2 / githubweb
  129. I am updating the hydrometeor PDF code to set mu_hm_1 and — bmg2 / githubweb
  130. Running the Bitten tests. — bmg2 / githubweb
  131. I added some comments so that CLUBB-SILHS would be consistent with — Vince Larson / githubweb
  132. As a first step, I changed all instances of rrtthl to corr_rt_thl_1. — bmg2 / githubweb
  133. I have added corr_rt_thl_2 to the code to go along with corr_rt_thl_2. — bmg2 / githubweb
  134. I have added some code to add corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2 — bmg2 / githubweb
  135. I added new statistics to the CLUBB _zt output files, specifically corr_w_rt_1, corr_w_rt_2, — bmg2 / githubweb
  136. I am updating the equations for wp2rtp, wp2thlp, wprtp2, and wpthlp2 to include — bmg2 / githubweb
  137. I am adding a special function to calculate the within-component correlation of — bmg2 / githubweb
  138. I added variables corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 — bmg2 / githubweb
  139. I am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to type — bmg2 / githubweb
  140. Now that the PDF component correlations of w and chi, as well as w and eta, — bmg2 / githubweb
  141. I am adding statistical output for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, — bmg2 / githubweb
  142. I am changing the name of the flag l_fix_chi_eta_correlations to — bmg2 / githubweb
  143. The two component normal (double Gaussian) PDF used by CLUBB will now be — bmg2 / githubweb
  144. I moved the checking of the options for the PDF call placement to subroutine — bmg2 / githubweb
  145. I am altering setup PDF parameters to be able to read in the values of — bmg2 / githubweb
  146. I am adding the new file new_pdf.F90 to the CLUBB core directory.  So far, it — bmg2 / githubweb
  147. I am adding a large amount of code to the new PDF.  I have filled in the driver — bmg2 / githubweb
  148. I am adding code to the new PDF that calculates the minimum and maximum — bmg2 / githubweb
  149. I added a new iiPDF entry for the new PDF, and I neatened some of the current — bmg2 / githubweb
  150. I added an option to call the new PDF from subroutine pdf_closure. — bmg2 / githubweb
  151. I had to add checking for the new PDF so someone does not try to run it — bmg2 / githubweb
  152. I made a couple changes to (1) initialize two variables that aren't used by the — bmg2 / githubweb
  153. I added a conditional to the subroutine that sets the responder parameters. — bmg2 / githubweb
  154. I have added the beginnings of a new unit test for the PDF parameters. — bmg2 / githubweb
  155. I have updated the PDF parameter unit test to make a call to the full PDF (for — bmg2 / githubweb
  156. I have added a feature to the PDF parameter unit tests which allows the user — bmg2 / githubweb
  157. In the setter variable description and subprograms, I made a name change from — bmg2 / githubweb
  158. I have updated the method of calculating the setter variable so that mu_x_1 — bmg2 / githubweb
  159. I added primarily some more documentation and notes. — bmg2 / githubweb
  160. I added some more comments documenting the code. — bmg2 / githubweb
  161. I got rid of some of the expressions that a script might try to flag as — bmg2 / githubweb
  162. I added much more documentation about the responder variable.  Specifically, — bmg2 / githubweb
  163. I am adding the new file, original_pdf.F90, as the new home for the ADG1, ADG2, — bmg2 / githubweb
  164. I have now switched the PDF closure code over to calling the code that had been — bmg2 / githubweb
  165. I updated the documentation in the code comments for the setter method and — bmg2 / githubweb
  166. I added a comment. — bmg2 / githubweb
  167. I added a new function, calc_comp_corrs_binormal, to pdf_utilities.F90.  This — bmg2 / githubweb
  168. I added some more descriptive comments and a new function that calculates the — bmg2 / githubweb
  169. I updated the code so that coef_sigma_x_1_sqd and coef_sigma_x_2_sqd are passed — bmg2 / githubweb
  170. I fixed a mistake. — bmg2 / githubweb
  171. I have added code to call the new function that calculates wp4 implicitly from — bmg2 / githubweb
  172. I moved the calculations of wp2xp (wp2rtp and wp2thlp), wp4, and wpxp2 (wprtp2 — bmg2 / githubweb
  173. I added another function to the new PDF.  This function helps to calculate — bmg2 / githubweb
  174. I added a special case for the wpxp2 implicit code. — bmg2 / githubweb
  175. Back in clubb:r8409, the PDF component correlations of w and rt and w and — bmg2 / githubweb
  176. I added a subroutine that calculates the implicit and explicit portions of the — bmg2 / githubweb
  177. I renamed original_pdf.F90 as adg1_adg2_3d_luhar_pdf.F90. — bmg2 / githubweb
  178. I added statistical output for F_w, F_rt, F_thl, min_F_w, max_F_w, min_F_rt, — bmg2 / githubweb
  179. I split the new PDF into two files.  I added a new file that currently houses — bmg2 / githubweb
  180. I clipped temperature within the Goff-Gratch functions for saturation over liquid and ice. — Vince Larson / githubweb
  181. I initialized some output variables in order to prevent a runtime error. — bmg2 / githubweb
  182. I made a sub-driver level subroutine for the calculations necessary for a — bmg2 / githubweb
  183. I added code to allow the variable (of w, rt, or theta-l) with the greatest — bmg2 / githubweb
  184. I added calls to the functions and subroutines that calculate the implicit and — bmg2 / githubweb
  185. I changed coef_wp2xp_explicit (coef_wp2rtp_explicit and coef_wp2thlp_explicit) — bmg2 / githubweb
  186. I am adding a new file for the new trivariate skewness-dependent analaytic — bmg2 / githubweb
  187. I fixed a bug in the new Trivariate skewness-dependent analytic double Gaussian — bmg2 / githubweb
  188. In order for the TSDADG PDF to work correctly, when Skx * sgn( <w'x'> ) >= 0, — bmg2 / githubweb
  189. In order to clarify coding in CLUBB, I am moving a block of code that is — bmg2 / githubweb
  190. I am fixing a bug where rtp2 and thlp2 (and sclrp2) were not preserved when — bmg2 / githubweb
  191. I updated the TSDADG PDF by adding the responding variable description, the — bmg2 / githubweb
  192. When ADG1 or ADG2 are not used, we have to set alpha_rt, alpha_thl, and — bmg2 / githubweb
  193. I am calling the new TSDADG PDF from subroutine pdf_closure. — bmg2 / githubweb
  194. Clarity changes to the new TSDADG PDF. — bmg2 / githubweb
  195. I added some references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
  196. I fixed a bug in the calculation of PDF component variances in the new TSDADG — bmg2 / githubweb
  197. I added more references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
  198. I have set the tunable parameters F_x and zeta_x to skewness functions for the — bmg2 / githubweb
  199. I needed to increase the limit of nvarmax_zt so that LBA (and other — bmg2 / githubweb
  200. I changed the URL references to the CLUBB-SILHS overview document. — Vince Larson / githubweb
  201. Changed variable and subroutine names, see ticket 810 and 811 — hoc_browser / githubweb
  202. I have added the Lewellen and Yoh (1993) PDF to CLUBB for testing and comparison — bmg2 / githubweb
  203. Fixed line length exceding 100 characters warnings — Gunther Huebler / githubweb
  204. Changed the arrangement of variables in the subroutine compute_mixing_length as well as calls to it clubb:ticket:815 — Gunther Huebler / githubweb
  205. Fixed lines exceeding 100 characters warnings clubb:ticket:815 — Gunther Huebler / githubweb
  206. I added an option to incorporate the buoyancy term into CLUBB's eddy diffusivity for momentum. — Vince Larson / githubweb
  207. I added c_K10 as a tuning parameter in front of the new momentum eddy diffusivity. — Vince Larson / githubweb
  208. Removed unused parameters to clear warnings clubb:ticket:803 — Gunther Huebler / githubweb
  209. I multiplied the eddy diffusivity for momentum by a skewness-dependent factor — Vince Larson / githubweb
  210. I changed the way that F_rt and F_thl are set in the new PDF.  They are now set — bmg2 / githubweb
  211. I changed the flag setting on the new PDF so that it always uses w as the setter — bmg2 / githubweb
  212. Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803 — Gunther Huebler / githubweb
  213. Improved binary search algorithm clubb:ticket:818 — Gunther Huebler / githubweb
  214. Added warning messages to function binary_search clubb:ticket:818 — Gunther Huebler / githubweb
  215. Removed unused variables causing warnings clubb:ticket:803 — Gunther Huebler / githubweb
  216. I updated the call to the new PDF so that Skrt and Skthl are intent INOUT — bmg2 / githubweb
  217. Removed many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803 — Gunther Huebler / githubweb
  218. I am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90.  This — bmg2 / githubweb
  219. I finished adding the units to the variable descriptions in — bmg2 / githubweb
  220. The calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>, — bmg2 / githubweb
  221. I added the tunable or adjustable parameters for the new PDF to CLUBB's list — bmg2 / githubweb
  222. Fixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803 — Gunther Huebler / githubweb
  223. I am committing a line of code that limits the adjusted correlation of rt and — bmg2 / githubweb
  224. I implemented a new method to handle cumulus momentum fluxes. — Vince Larson / githubweb
  225. Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804 — Gunther Huebler / githubweb
  226. Removed file anl_erf.F90, it is no longer used — Gunther Huebler / githubweb
  227. I am altering the solution to the wp3 predictive equation to calculate the — bmg2 / githubweb
  228. I fixed the problem with the wp3 budgets as a result of r8584.  The budgets in — bmg2 / githubweb
  229. I altered the names of the turbulent advection functions that are closed by — bmg2 / githubweb
  230. I added a couple comments about how the discretization of the turbulent — bmg2 / githubweb
  231. I added the function that sets up the implicit calculation of the wp3 turbulent — bmg2 / githubweb
  232. I added a function that calculates the explicit form of the wp3 turbulent — bmg2 / githubweb
  233. I am adding a function to calculate the turbulent advection of wpxp explicitly. — bmg2 / githubweb
  234. I am adding a function to calculate the turbulent advection of xp2 and xpyp — bmg2 / githubweb
  235. I interfaced the wp3 explicit turbulent advection code with CLUBB.  It is — bmg2 / githubweb
  236. I am interfacing the wpxp explicit turbulent advection option with the rest of — bmg2 / githubweb
  237. I fixed a small bug with the explicit turbulent advection option for wpxp. — bmg2 / githubweb
  238. I am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code. — bmg2 / githubweb
  239. I added the l_explicit_turbulent_adv_* family of flags to the new PDF, for some — bmg2 / githubweb
  240. I am packing up the implicit coefficients and explicit terms calculated by the — bmg2 / githubweb
  241. Made epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804 — Gunther Huebler / githubweb
  242. I made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90. — bmg2 / githubweb
  243. I have completed interfacing the implicit form of the wp3 turbulent advection — bmg2 / githubweb
  244. When the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advection — bmg2 / githubweb
  245. I cleaned up the Skx_module and added an additional function, — bmg2 / githubweb
  246. I fixed a bug in the calculation of scalar skewness.  It was being set to 0, — bmg2 / githubweb
  247. I moved the location of the LG 2005 ansatz to calculate xp3 because it would be — bmg2 / githubweb
  248. I reverted clubb:r8611 because (1) having the code in the other location — bmg2 / githubweb
  249. I have added a new function, term_ta_new_pdf_lhs, to — bmg2 / githubweb
  250. I have linked the implicit turbulent advection code for rtp2 and thlp2 to the — bmg2 / githubweb
  251. I have added a new file that has two options for handling the xp3 term for — bmg2 / githubweb
  252. I have interface the new xp3 code to the rest of CLUBB.  It can be turned on — bmg2 / githubweb
  253. I added a driver level subroutine for the new advance xp3 code.  This will make — bmg2 / githubweb
  254. I added budget stats for rtp3 and thlp3 to CLUBB. — bmg2 / githubweb
  255. I am adding code that allows the turbulent advection of wpxp to be treated — bmg2 / githubweb
  256. Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code. — Gunther Huebler / githubweb
  257. Various small comment removals and returned some functionality to api interface clubb:ticket:800 — Gunther Huebler / githubweb
  258. A variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800 — Gunther Huebler / githubweb
  259. This is the first part of a two-part change.  I am updating plotgen plots so — bmg2 / githubweb
  260. In part 2 of this two part commit, I have added rc_coef to the list of — bmg2 / githubweb
  261. Various debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800 — Gunther Huebler / githubweb
  262. Check negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800 — Gunther Huebler / githubweb
  263. I'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800 — Gunther Huebler / githubweb
  264. Changed calls to parameterization check to work with the new check negative implementation clubb:ticket:800 — Gunther Huebler / githubweb
  265. Gunther Huebler / githubweb
  266. Removed rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800 — Gunther Huebler / githubweb
  267. Changed error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800 — Gunther Huebler / githubweb
  268. Fixed unused variable warnings related to error code changes — Gunther Huebler / githubweb
  269. I am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to account — bmg2 / githubweb
  270. Added error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to  keep track of error messages is multithreaded scenarios clubb:ticket:800 — Gunther Huebler / githubweb
  271. In r8659, I accidentally overwrote some code.  This commit restores the prior — bmg2 / githubweb
  272. Sigh — bmg2 / githubweb
  273. Added clubb debug level checks to error checking statements clubb:ticket:800 — Gunther Huebler / githubweb
  274. Changed many stop commands to return commands and added more err_code checks clubb:ticket:800 — Gunther Huebler / githubweb
  275. Reverted api changes that broke SAM and WRF — Gunther Huebler / githubweb
  276. I am adding the semi-implicit formulation of wprtpthlp, which is the turbulent — bmg2 / githubweb
  277. I am adding output statistics for the implicit and semi-implicit coefficients — bmg2 / githubweb
  278. I corrected the units on a couple of implicit coefficients. — bmg2 / githubweb
  279. I fixed a bug. — bmg2 / githubweb
  280. Removed failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
  281. Removed reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
  282. I am fixing a bug with the CLUBB tuner.  Variables that were allocated at the — bmg2 / githubweb
  283. Completed the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800 — Gunther Huebler / githubweb
  284. Made all debug levels produce the same output, see clubb:ticket:823 — Gunther Huebler / githubweb
  285. I am moving type variable implicit_coefs_terms from new_pdf_main.F90 to — bmg2 / githubweb
  286. Modified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802 — Gunther Huebler / githubweb
  287. Added checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802 — Gunther Huebler / githubweb
  288. This should fix the thlm out of bounds error on clubb:ticket:828 — Gunther Huebler / githubweb
  289. I changed the name of type variable new_pdf_implct_coefs_terms to — bmg2 / githubweb
  290. Changed T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828 — Gunther Huebler / githubweb
  291. I added a flag option to clip the (large, negative) effects of microphysics on — bmg2 / githubweb
  292. I added a flag option to calculate the minimum threshold for xp2 (rtp2 and — bmg2 / githubweb
  293. I added a special max magnitude correlation for fluxes wprtp and wpthlp.  This — bmg2 / githubweb
  294. Made better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more information — Gunther Huebler / githubweb
  295. This commit sets C8b=0.02, changes the non-linear damping on wp3 — Vince Larson / githubweb
  296. Added a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829 — Gunther Huebler / githubweb
  297. I am adding a general purpose function for the turbulent advection of CLUBB's — bmg2 / githubweb
  298. I added/changed a couple comments for the rhs portion of the generalized — bmg2 / githubweb
  299. The turbulent advection file that handles turbulent advection for predictive — bmg2 / githubweb
  300. I added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, that — bmg2 / githubweb
  301. Whoops, I forgot to make wpxpyp_zm and xpyp intent (in). — bmg2 / githubweb
  302. Added functionality to make the  hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830 — Gunther Huebler / githubweb
  303. I am updating the code that advances predictive variances and covariances in — bmg2 / githubweb
  304. Renamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830 — Gunther Huebler / githubweb
  305. I am updating the code that advances predictive scalar fluxes (<w'x'>) in — bmg2 / githubweb
  306. As a first step toward having code that can clip mean values of hydrometeor — bmg2 / githubweb
  307. init_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562 — Gunther Huebler / githubweb
  308. I have now interfaced the subroutine that I made out of the code that clips — bmg2 / githubweb
  309. I added new code that clips the overall correlation of w and rt or the overall — bmg2 / githubweb
  310. I added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which are — bmg2 / githubweb
  311. Made clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800 — Gunther Huebler / githubweb
  312. Reverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800 — Gunther Huebler / githubweb
  313. Fixed nightly tests — Gunther Huebler / githubweb
  314. I have added code to allow C2 to be adjusted by multiplying by the greater of — bmg2 / githubweb
  315. I moved the location of the declaration and setting of new model flags to — bmg2 / githubweb
  316. Improved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834 — Gunther Huebler / githubweb
  317. Fixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834 — Gunther Huebler / githubweb
  318. Actually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
  319. Optimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
  320. Reverted stats_clubb_utilities, accidental commit — Gunther Huebler / githubweb
  321. This should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837 — Gunther Huebler / githubweb
  322. Vince Larson / githubweb
  323. Impoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834 — Gunther Huebler / githubweb
  324. This commit implements the effects of splatting on wp3. — Vince Larson / githubweb
  325. I am making the first step toward committing code that allows for the option — bmg2 / githubweb
  326. I added code to allow the option of predicting upwp and vpwp by using the — bmg2 / githubweb
  327. I took the liberty of upgrading CLUBB's PDF closure and related code to a vector — bmg2 / githubweb
  328. I updated the monotonic flux limiter to account for vector variables u and v. — bmg2 / githubweb
  329. I am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output. — bmg2 / githubweb
  330. In r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic flux — bmg2 / githubweb
  331. I am turning on the l_predict_upwp_vpwp code! — bmg2 / githubweb
  332. Improved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834 — Gunther Huebler / githubweb
  333. Improved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834 — Gunther Huebler / githubweb
  334. Changed the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834 — Gunther Huebler / githubweb
  335. Added grid_class to the dependency lists of the pdf files that were changed in commit 8773 — Gunther Huebler / githubweb
  336. Accidental commit, undoing 8783 — Gunther Huebler / githubweb
  337. I am changing the default setting of flags l_min_wp2_from_corr_wx and — Brian Griffin / githubweb
  338. Modified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834 — Gunther Huebler / githubweb
  339. Removed print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases. — Gunther Huebler / githubweb
  340. Changed the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834 — Gunther Huebler / githubweb
  341. I am adding source code for the introduction of budgets for predictive upwp — Brian Griffin / githubweb
  342. Improved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834 — Gunther Huebler / githubweb
  343. Improved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834 — Gunther Huebler / githubweb
  344. Modified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834 — Gunther Huebler / githubweb
  345. Copied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834 — Gunther Huebler / githubweb
  346. Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834 — Gunther Huebler / githubweb
  347. Improved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834 — Gunther Huebler / githubweb
  348. I made the surface splatting terms conservative.  That is, I subtracted from wp2_sfc — Vince Larson / githubweb
  349. I added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2. — Vince Larson / githubweb
  350. This commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero).  Hence it is BIT_CHANGING. — Vince Larson / githubweb
  351. Added functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834 — Gunther Huebler / githubweb
  352. Update advance_clubb_core_module.F90 — noreply / githubweb
  353. I clipped sigma_sqd_w to prevent interpolated values of it — Vince Larson / githubweb
  354. I added a new option to diagnose the dissipation time scale, tau, first — Vince Larson / githubweb
  355. I found a new way to diagnose upthvp.  Instead of using a bound on correlations, it relies — Vince Larson / githubweb
  356. introducing error into clubb core for testing larson-group/sys_admin#533 — mcfadd34 / githubweb
  357. reverting error that was introduced larson-group/sys_admin#533 — mcfadd34 / githubweb
  358. I am briefly changing some of the flag and parameter settings in CLUBB — bmg2 / githubweb
  359. Revert "I am briefly changing some of the flag and parameter settings in CLUBB" — bmg2 / githubweb
  360. I added a couple of comments reminding users to change the conditions in — bmg2 / githubweb
  361. Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"" — bmg2 / githubweb
  362. Revert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""" — bmg2 / githubweb
  363. I committed a subroutine, diagnose_upxp, that calculates — Vince Larson / githubweb
  364. Improved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834 — Gunther Huebler / githubweb
  365. I am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a large — bmg2 / githubweb
  366. I am updating the code within setup_clubb_pdf_parameters.F90 in order to take — bmg2 / githubweb
  367. To diagnose uprcp using CLUBB's PDF machinery, — Vince Larson / githubweb
  368. Continuing with diagnosis of uprcp using CLUBB's PDF, — Vince Larson / githubweb
  369. More code to diagnose uprcp using CLUBB's PDF. — Vince Larson / githubweb
  370. Correction for the last uprcp-related commit: — Vince Larson / githubweb
  371. I am correcting the code so that the Nightly Uninitialized Variables Test — bmg2 / githubweb
  372. I am continuing to pull parts of setup_pdf_parameters outside of a large "do" — bmg2 / githubweb
  373. I am pulling statistical output subroutine pdf_param_ln_hm_stats outside — bmg2 / githubweb
  374. Changing the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope. — Gunther Huebler / githubweb
  375. commenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566 — mcfadd34 / githubweb
  376. uncommenting threadprivate larson-group/sys_admin#566 — mcfadd34 / githubweb
  377. I have changed the structure of setup_pdf_parameters so that the subroutine that — bmg2 / githubweb
  378. Returned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING. — Gunther Huebler / githubweb
  379. I am turning on the new calculation of uprcp that uses CLUBB's PDF. — Vince Larson / githubweb
  380. I modified the code in setup_clubb_pdf_params.F90 to use only one call to — bmg2 / githubweb
  381. I am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch to — bmg2 / githubweb
  382. I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch — bmg2 / githubweb
  383. I temporarily set l_clip_extreme_chi_sample_pts back to false in the — bmg2 / githubweb
  384. Revert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the" — bmg2 / githubweb
  385. I improved the error messages when LU decomp. fails within — bmg2 / githubweb
  386. Improved error message prints in advance_xm_wpxp. — bmg2 / githubweb
  387. I added improved LHS and RHS print statements when a LU decomp. error occurs — bmg2 / githubweb
  388. I added params_list to the list of variables that are accessible through — bmg2 / githubweb
  389. I am making the first step for updating the code that calculates sigma_sqd_w. — bmg2 / githubweb
  390. I added a log-law height dependence to the code that diagnoses — Vince Larson / githubweb
  391. I added fill_holes_hydromet_api to clubb_api_module.F90. — bmg2 / githubweb
  392. I added a new python script, check_for_missing_threadprivate.py, — Vince Larson / githubweb
  393. Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834 — Gunther Huebler / githubweb
  394. Fixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834 — Gunther Huebler / githubweb
  395. Added temp test file — noreply / githubweb
  396. Remove test file — noreply / githubweb
  397. Adding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical. — Gunther Huebler / githubweb
  398. Optimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases. — Gunther Huebler / githubweb
  399. ticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequency — guozhun / githubweb
  400. Modifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855 — Gunther Huebler / githubweb
  401. Replacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855 — Gunther Huebler / githubweb
  402. Making procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855 — Gunther Huebler / githubweb
  403. Missed one — Gunther Huebler / githubweb
  404. I have added a new file, calc_pressure.F90, which contains code for initializing — bmg2 / githubweb
  405. I updated CLUBB so that pressure is updated after mean fields have been — bmg2 / githubweb
  406. Removing gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855 — Gunther Huebler / githubweb
  407. Forgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855 — Gunther Huebler / githubweb
  408. issue #842 — guozhun / githubweb
  409. We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. — guozhun / githubweb
  410. We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842) — guozhun / githubweb
  411. Update advance_clubb_core_module.F90 — noreply / githubweb
  412. We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly) — guozhun / githubweb
  413. Efficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855 — Gunther Huebler / githubweb
  414. This should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855 — Gunther Huebler / githubweb
  415. An additional damping is added to the invrs_tau term in the C8 equation. ticket #842 — guozhun / githubweb
  416. Adding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations. — Gunther Huebler / githubweb
  417. We use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8. — guozhun / githubweb
  418. Changing ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855 — Gunther Huebler / githubweb
  419. Pulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855 — Gunther Huebler / githubweb
  420. Renaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855 — Gunther Huebler / githubweb
  421. Efficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855. — Gunther Huebler / githubweb
  422. Modifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855 — Gunther Huebler / githubweb
  423. Refactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855 — Gunther Huebler / githubweb
  424. Update advance_clubb_core_module.F90 — noreply / githubweb
  425. Update advance_clubb_core_module.F90 — noreply / githubweb
  426. I switched on direct diagnosis of tau rather than Lscale. — Vince Larson / githubweb
  427. I updated the pressure initialization for cases that use sounding that is given — bmg2 / githubweb
  428. I changed the function calculate_thvm from a pre-defined vector of size nz to — bmg2 / githubweb
  429. I updated the calculation of thvm in advance_clubb_core to use the — bmg2 / githubweb
  430. Adding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler. — Gunther Huebler / githubweb
  431. Adding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855 — Gunther Huebler / githubweb
  432. Changing where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626 — Gunther Huebler / githubweb
  433. I am committing a test where I changed subroutine ADG1_w_closure — bmg2 / githubweb
  434. Changing determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862 — Gunther Huebler / githubweb
  435. Finally fixing line length error in pdf_closure — Gunther Huebler / githubweb
  436. Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861 — Gunther Huebler / githubweb
  437. Adding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862 — Gunther Huebler / githubweb
  438. This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc. — guozhun / githubweb
  439. Update advance_helper_module.F90 — noreply / githubweb
  440. Update advance_clubb_core_module.F90 — noreply / githubweb
  441. Update advance_helper_module.F90 — noreply / githubweb
  442. Adding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626 — Gunther Huebler / githubweb
  443. I am adding a file for the new hybrid PDF, which combines the w equation set — bmg2 / githubweb
  444. I updated the function to calculate the implicit coefficient for the wp4 term, — bmg2 / githubweb
  445. I made some changes to new_hybrid_pdf.F90 so that it would compile in its — bmg2 / githubweb
  446. I edited that subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
  447. I updated the subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
  448. Replaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves. — nselke / githubweb
  449. I am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the new — bmg2 / githubweb
  450. I worked more the functions for the new hybrid PDF. — bmg2 / githubweb
  451. Refactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855 — Gunther Huebler / githubweb
  452. I changed all the PDF utility functions in pdf_utilities.F90 to elemental — bmg2 / githubweb
  453. I forgot a "then" to go with an "elseif". — bmg2 / githubweb
  454. Adding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855 — Gunther Huebler / githubweb
  455. Adding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855 — Gunther Huebler / githubweb
  456. Refactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855 — Gunther Huebler / githubweb
  457. I am continuing to build the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
  458. I am continuing to work on the driver file for the new hybrid PDF. — bmg2 / githubweb
  459. I have completed the main parts of the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
  460. The code for the new hybrid PDF now compiles. — bmg2 / githubweb
  461. I added an entry for the new hybrid PDF. — bmg2 / githubweb
  462. I have added the new hybrid PDF to the G unit tests. — bmg2 / githubweb
  463. Mathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0. — bmg2 / githubweb
  464. I added code to interface the call to the new hybrid PDF with pdf_closure — bmg2 / githubweb
  465. I interfaced the implicit coefficients and explicit terms used in the turbulent — bmg2 / githubweb
  466. I fixed a small error.  The code compiles again now. — bmg2 / githubweb
  467. Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group — pbroels / githubweb
  468. I have added code that allows CLUBB to run interactively using the new hybrid — bmg2 / githubweb
  469. I am updating the subroutine that calculates PDF component means and standard — bmg2 / githubweb
  470. I placed proper thresholding on interpolated up2 and interpolated vp2 — bmg2 / githubweb
  471. I added a limiter to keep the maximum magnitude of the correlations of — bmg2 / githubweb
  472. I upgraded Nc_Ncn_eqns.F90 to use elemental functions. — bmg2 / githubweb
  473. The new hybrid PDF also uses this bit of code that sets the correlation — bmg2 / githubweb
  474. I made modifications to the new hybrid PDF so that that calculation of F_w — bmg2 / githubweb
  475. I added the ability to handle scalars interactively to the new hybrid PDF. — bmg2 / githubweb
  476. I found a couple of spots in the new hybrid PDF where I needed to add — bmg2 / githubweb
  477. I added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90. — bmg2 / githubweb
  478. The variable type implicit_coefs_terms needs to be made public — bmg2 / githubweb
  479. I changed the value of the coefficient in the F_w equation to 0.45 — bmg2 / githubweb
  480. I am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_core — bmg2 / githubweb
  481. I have started the process of adding the coding infrastructure — bmg2 / githubweb
  482. I have completed the addition of the ability to use different up2 — bmg2 / githubweb
  483. I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856 — nselke / githubweb
  484. I made the l_calc_w_corr code (turned off by default) run again by — bmg2 / githubweb
  485. I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute. — nselke / githubweb
  486. I have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac', — nselke / githubweb
  487. I continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm', — nselke / githubweb
  488. I continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm', — nselke / githubweb
  489. I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp', — nselke / githubweb
  490. Finished altering argument lists. This commit covers the final seven flags, which are in different namelists. — nselke / githubweb
  491. I introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type. — nselke / githubweb
  492. I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856 — nselke / githubweb
  493. I fed pdf_params_frz into subroutine advance_clubb_core — Vince Larson / githubweb
  494. Adding error code to arguement list of non-api routines where it was included in the api version. — Gunther Huebler / githubweb
  495. Moving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal. — Gunther Huebler / githubweb
  496. Added use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public. — Steffen Domke / githubweb
  497. I have fixed the warnings for lines exceeding 100 characters. — nselke / githubweb
  498. Passing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity. — Gunther Huebler / githubweb
  499. Trivial update to test if cams autoupdate works — noreply / githubweb
  500. Revert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch" — bmg2 / githubweb
  501. I placed E3SM preprocessor commands around E3SM-specific code in — bmg2 / githubweb
  502. Restoring assertion check for the vertical correlation calculation. larson-group/clubb#869 — Gunther Huebler / githubweb
  503. Changing the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869 — Gunther Huebler / githubweb
  504. I added E3SM's clubb_ parameters that can be read in from the — bmg2 / githubweb
  505. I added the remainder the clubb_ terms that were added previously to — bmg2 / githubweb
  506. Changing error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869 — Gunther Huebler / githubweb
  507. Small updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  508. Redoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  509. Adding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
  510. Simple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
  511. Small performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  512. Removing lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869 — Gunther Huebler / githubweb
  513. Update latin_hypercube_driver_module.F90 — noreply / githubweb
  514. Update parameters_tunable.F90 — noreply / githubweb
  515. GPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  516. Making some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  517. I changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874 — nselke / githubweb
  518. I added the new l_update_pressure configurable flag to clubb_config_flags. — bmg2 / githubweb
  519. I added some code I used in the special input fields branch to make — bmg2 / githubweb
  520. An improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875] — guozhun / githubweb
  521. I revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874. — nselke / githubweb
  522. I got rid of the "allocatable", "allocate", and "deallocate" statements — bmg2 / githubweb
  523. I placed an ifndef CLUBB_CAM preprocessor flag around the code in — bmg2 / githubweb
  524. I reduced the minimum possible value of lmin from 4.0 to 1.0. — noreply / githubweb
  525. I made a print/write statement debug level 3 — noreply / githubweb
  526. I made a second print/write statement debug level 3 — noreply / githubweb
  527. I fix a print/write statement debug level3. For #755 and #800 — guozhun / githubweb
  528. I am replacing the "use" statements that referenced — bmg2 / githubweb
  529. I "brought back the stats" by passing the stats from advance_clubb_core — bmg2 / githubweb
  530. Removing the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref) — bmg2 / githubweb
  531. Results were changed yesterday for some cases because thlprcp was — bmg2 / githubweb
  532. I have resolved all the issues surrounding recent CLUBB commits that — bmg2 / githubweb
  533. I removed code that stops a run if the output time step is less than a minute. — noreply / githubweb
  534. I removed references to variables_prognostic_module and — bmg2 / githubweb
  535. Fixed a boo-boo. — bmg2 / githubweb
  536. I set `l_diag_Lscale_from_tau = .true.` in source code — noreply / githubweb
  537. I removed references to variable_diagnostic_module for various Kessler — bmg2 / githubweb
  538. I removed the reference to use variables_diagnostic_module for Kh_zm — bmg2 / githubweb
  539. Removed a reference to variables_diagnostic_module for Kh_zm in — bmg2 / githubweb
  540. I am able to remove references to variables_prognostic_module and — bmg2 / githubweb
  541. I removed the l_use_ice_latent flag from the code, and along with it — bmg2 / githubweb
  542. I have completed the project of removing variables_prognostic_module — bmg2 / githubweb
  543. I added some missing threadprivate statements — noreply / githubweb
  544. I have taken the code from wp2_term_ta_all and placed it in the subroutine — bmg2 / githubweb
  545. I am updating wp3_term_ta_new_pdf_lhs to use the optimized code from — bmg2 / githubweb
  546. This commit is BIT_CHANGING.  It makes the parameter values in parameters_tunable.F90 agree with those in tunable_parameters.in — benjamin.andrew.stephens / githubweb
  547. I am making the change of using tau_wp2_zm to damp up2 and vp2, — bmg2 / githubweb
  548. I have added the integer flags iiPDF_type and ipdf_call_placement — bmg2 / githubweb
  549. I am going to make primary PDF type options and primary PDF call — bmg2 / githubweb
  550. I added E3SM customizations to CLUBB's master branch.  This is meant — bmg2 / githubweb
  551. I am updating the clubb_ list of namelist parameters used in E3SM — bmg2 / githubweb
  552. Typo — bmg2 / githubweb
  553. Fixed more typos — bmg2 / githubweb
  554. I am changing the new hybrid PDF's calculation of F_w to use — bmg2 / githubweb
  555. I updated the xp3 calculation for PDF types other than ADG1. — bmg2 / githubweb
  556. This xp3_coef_ parameters produce new hybrid PDF results similar to the old — bmg2 / githubweb
  557. I added the 2 new parameters in the simple xp3 equation (for PDF — bmg2 / githubweb
  558. I have combined the wp3_term_ta_ADG1_lhs and wp3_term_ta_ADG1_lhs_all — bmg2 / githubweb
  559. I added the partially upwinded implementation of the wp3 turbulent advection — bmg2 / githubweb
  560. Removed unused module imports — isenfireldc / githubweb
  561. Removed unused module imports — isenfireldc / githubweb
  562. Removed a comma that I missed while removing unused imports (#878) — isenfireldc / githubweb
  563. I am adding l_partial_upwind_wp3 to the list of clubb_config_flags. — bmg2 / githubweb
  564. Deprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129 — Gunther Huebler / githubweb
  565. I started the process of paring 2 subprograms back down to 1 in — bmg2 / githubweb
  566. I pared two more sets of equivalent subprograms down to 1 (each). — bmg2 / githubweb
  567. Paring down 2 equivalent subprograms to 1 again. — bmg2 / githubweb
  568. I condensed two more sets of doubled subprograms down to 1 (each) — bmg2 / githubweb
  569. Reduced two more sets of "doubled" subprograms down. — bmg2 / githubweb
  570. Updating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129 — Gunther Huebler / githubweb
  571. Adding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129 — Gunther Huebler / githubweb
  572. I updated CLUBB's copyright date range. — noreply / githubweb
  573. Adding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129 — Gunther Huebler / githubweb
  574. Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
  575. Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
  576. Taking more duplicated subprograms and paring them down to 1. — bmg2 / githubweb
  577. Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
  578. Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
  579. Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
  580. Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
  581. Removed styleguide violations from my code — isenfireldc / githubweb
  582. Fixed a backwards epsilon comparison from 8e8e71e — isenfireldc / githubweb
  583. Removed the "doubling" of the remainder of the subprograms from — bmg2 / githubweb
  584. Changing epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878 — Gunther Huebler / githubweb
  585. Small changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129 — Gunther Huebler / githubweb
  586. Changed the length of solve_type_str to 20 [-Wcharacter-trucation] — isenfireldc / githubweb
  587. Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
  588. Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
  589. Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
  590. Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
  591. I have tidied up advance_wp2_wp3_module.F90, and I have removed all doubled — bmg2 / githubweb
  592. Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
  593. Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
  594. I handled the "doubled" subprograms in turbulent_adv_pdf.F90. — bmg2 / githubweb
  595. Making change explained in larson-group/clubb#878 — Gunther Huebler / githubweb
  596. Removed some unused variables (ifort) — isenfireldc / githubweb
  597. Removed some unused variables (ifort) — isenfireldc / githubweb
  598. Adding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129 — Gunther Huebler / githubweb
  599. Removed unused import [-Wunused-variable] — isenfireldc / githubweb
  600. Removes unused function calc_cloud_frac [-Wunused-function] — isenfireldc / githubweb
  601. Fixes style issue — isenfireldc / githubweb
  602. Removed import without only as it was unused — isenfireldc / githubweb
  603. Adds mpishorthand back with only, it appears to be used somewhere — isenfireldc / githubweb
  604. I have pared two subprograms down to one again, this time for the — bmg2 / githubweb
  605. I pared down subprogram pairs again, this time for mean advection. — bmg2 / githubweb
  606. I added altitude_threshold to the list of CLUBB's tunable parameters. — bmg2 / githubweb
  607. Updating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots. — strike / githubweb
  608. Updating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be). — strike / githubweb
  609. Adds more debug lines — isenfireldc / githubweb
  610. Removes debug lines — isenfireldc / githubweb
  611. Adds debug lines and changes format — isenfireldc / githubweb
  612. Modifies debug line — isenfireldc / githubweb
  613. Modifies debug line — isenfireldc / githubweb
  614. Initialize ncf%ntimes to 0 when opening netcdf for writing — isenfireldc / githubweb
  615. Removes debug lines — isenfireldc / githubweb
  616. Changes length of units variable in stat_file_module from 20 to 25 — isenfireldc / githubweb
  617. This commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true.  A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines. — benjamin.andrew.stephens / githubweb
  618. Adding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close.  This will aid in implementing the SILHS 2D output subroutines in host models.  The new API subroutines necessitated some minor changes in clubb_driver.F90 as well.  Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo). — benjamin.andrew.stephens / githubweb
  619. I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
  620. I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
  621. This commit primarily overhauls the way the 2D SILHS samples are output to netCDF.  Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file.  Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
  622. This commit primarily overhauls the way the 2D SILHS samples are output to netCDF.  Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file.  Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
  623. Undoing accidental find and replace. larson-group/cam#129 — Gunther Huebler / githubweb
  624. Updated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832 — nchief / githubweb
  625. Fix super serious 1 character bug that broke all of the things — strike / githubweb
  626. I am committing Zhun's changes to the CLUBB portion of his — bmg2 / githubweb
  627. Update stats_zm_module.F90 — noreply / githubweb
  628. I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max — bmg2 / githubweb
  629. I connected the new tunable parameters to advance_helper_module.F90. — bmg2 / githubweb
  630. I added l_use_shear_Richardson to CLUBB's configurable model flags. — bmg2 / githubweb
  631. Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp.  This is intended to help smooth high-frequency oscillations.  Flag is set to false by default so has no impact on standard runs. — benjamin.andrew.stephens / githubweb
  632. In order to prevent dycoms2_rf02_so from crashing, — Vince Larson / githubweb
  633. I updated the recording of the budget terms for upwp_pr4 and vpwp_pr4. — Vince Larson / githubweb
  634. Adding the smooth_min and smooth_max functions to the repo.  These are not yet implemented in CLUBB but are now available for use and testing. See issue #894. — benjamin.andrew.stephens / githubweb
  635. Adding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions.  See issue #894. — benjamin.andrew.stephens / githubweb
  636. Modifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129 — Gunther Huebler / githubweb
  637. This commit replaces division by tau with multiplication by inverse tau in most cases.  It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files.  Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine. — benjamin.andrew.stephens / githubweb
  638. I am committing a bug fix to the invrs_tau_zm equation that was — bmg2 / githubweb
  639. CLUBB and pyplotgen changes: — benjamin.andrew.stephens / githubweb
  640. I fixed the LMM stepping bug that was affecting E3SM (because — bmg2 / githubweb
  641. Fixed alignment. — bmg2 / githubweb
  642. This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code.  The primary code changes are in advance_clubb_core_module.F90. — benjamin.andrew.stephens / githubweb
  643. Update parameter_indices.F90 — noreply / githubweb
  644. Update model_flags.F90 — noreply / githubweb
  645. Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3).  See issue #884. — benjamin.andrew.stephens / githubweb
  646. Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced.  See https://github.com/larson-group/clubb/issues/901. — benjamin.andrew.stephens / githubweb
  647. I am now passing vert_decorr_coef into SILHS instead of involving — bmg2 / githubweb
  648. This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39).  Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before.  I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up). — benjamin.andrew.stephens / githubweb
  649. Adding a test to make sure new C_uu_buoy parameter is within the valid range. See #901. — benjamin.andrew.stephens / githubweb
  650. This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb".  The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. — benjamin.andrew.stephens / githubweb
  651. This will allow for a better interface of SILHS parameter — bmg2 / githubweb
  652. Fixed a preprocessor command. — bmg2 / githubweb
  653. I'm adding the api entry for read_silhs_parameters, called — bmg2 / githubweb
  654. Revert "I'm adding the api entry for read_silhs_parameters, called" — bmg2 / githubweb
  655. Revert "Fixed a preprocessor command." — bmg2 / githubweb
  656. Revert "This will allow for a better interface of SILHS parameter" — bmg2 / githubweb
  657. I updated silhs_api_module so that vert_decorr_coef is publically available — bmg2 / githubweb
  658. Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code.  The flag is set to false by default so results are unaffected.  See #902. — benjamin.andrew.stephens / githubweb
  659. Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. — benjamin.andrew.stephens / githubweb
  660. Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129 — Gunther Huebler / githubweb
  661. Update parameters_tunable.F90 — noreply / githubweb
  662. Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129 — Gunther Huebler / githubweb
  663. Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129 — Gunther Huebler / githubweb
  664. Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
  665. Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
  666. Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch.  See #902. — 59519056+bstephens82 / githubweb
  667. Turning on wp3 pr_turb term. — benjamin.andrew.stephens / githubweb
  668. Changed the variable up2_vp2_factor to up2_sfc_coef in all files — rhodesk / githubweb
  669. I added an option to improve dry, convecting boundary layers. — Vince Larson / githubweb
  670. This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2.  In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1.  This makes the terms in these equations more consistent with the terms in the wp2 equation.  I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped). — Vince Larson / githubweb
  671. Changed surface to sfc in all instances where requested — rhodesk / githubweb
  672. Undid sfc change in stats_sfc_module.F90 — noreply / githubweb
  673. Undid sfc change to grid_class.F90 — noreply / githubweb
  674. Undid sfc change in numerical_check.F90 — noreply / githubweb
  675. Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129 — Gunther Huebler / githubweb
  676. Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  677. Fixed typo bug. larson-group/cam#129 — Gunther Huebler / githubweb
  678. Pushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  679. More pushing loops down. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  680. More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  681. More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  682. Adding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129 — Gunther Huebler / githubweb
  683. More loop pushing, all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  684. Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions. — Gunther Huebler / githubweb
  685. Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled. — Gunther Huebler / githubweb
  686. Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129 — Gunther Huebler / githubweb
  687. Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  688. Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  689. Performance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  690. Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  691. Reducing operations. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  692. Adding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  693. Some small cleanup, all just formatting. larson-group/cam#129 — Gunther Huebler / githubweb
  694. Changed ustar from an array to a scalar issue #909 — rhodesk / githubweb
  695. Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909 — rhodesk / githubweb
  696. Created new subroutine and ensured it's BFB. All cases run sucessfully #909 — rhodesk / githubweb
  697. added in missing flag which was causing memory errors #909 — rhodesk / githubweb
  698. confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909 — rhodesk / githubweb
  699. Update stats_zm_module.F90 — noreply / githubweb
  700. Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129 — Gunther Huebler / githubweb
  701. Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  702. Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  703. Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  704. Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129 — Gunther Huebler / githubweb
  705. Reformatted mixing length to be more compliant with the coding standard #909 — rhodesk / githubweb
  706. added a reference to new subroutine #909 — rhodesk / githubweb
  707. Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
  708. Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
  709. Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
  710. Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
  711. Pushing loops related to pdf_params down. larson-group/cam#129 — Gunther Huebler / githubweb
  712. clubb warnings introduced from merge have been removed #909 — rhodesk / githubweb
  713. Changed safeguard threshold in sigma_sqd_w. — rhodesk / githubweb
  714. Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. — 59519056+bstephens82 / githubweb
  715. Adding new coefficient to control the wp3 pressure diffusion term. — 59519056+bstephens82 / githubweb
  716. Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. — 59519056+bstephens82 / githubweb
  717. Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. — 59519056+bstephens82 / githubweb
  718. Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). — 59519056+bstephens82 / githubweb
  719. These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. — 59519056+bstephens82 / githubweb
  720. Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form.  This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. — 59519056+bstephens82 / githubweb
  721. Added intent comments for the following files: — rhodesk / githubweb
  722. Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core.  Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs).  This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated. — benjamin.andrew.stephens / githubweb
  723. Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90. — benjamin.andrew.stephens / githubweb
  724. Fixed comment regarding wp3 splatting term. — benjamin.andrew.stephens / githubweb
  725. Added intent comments. — rhodesk / githubweb
  726. Added intent comments. — rhodesk / githubweb
  727. Added intent comments for advance_xp2_xpyp_module.F90. — rhodesk / githubweb
  728. Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface. — 59519056+bstephens82 / githubweb
  729. Deleting comments around the old "magic number" for the near-surface clipping. — 59519056+bstephens82 / githubweb
  730. Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928. — Gunther Huebler / githubweb
  731. Changed some elements of clubb to allow for better script execution — rhodesk / githubweb
  732. Fixed clubb not compiling — rhodesk / githubweb
  733. Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
  734. Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
  735. Reverted changes to clubb_api. For #886 — rhodesk / githubweb
  736. Replacing use gr statements with feeding gr throught the arg list. — rhodesk / githubweb
  737. Adding proper indentation to needed files. — rhodesk / githubweb
  738. Fixing spacing issue on blank lines. #886 — rhodesk / githubweb
  739. Fixed comment changes. #886 — rhodesk / githubweb
  740. Fixed incorrect spacing on use — rhodesk / githubweb
  741. Revert "Fixed incorrect spacing on use" — rhodesk / githubweb
  742. Fixed spacing — rhodesk / githubweb
  743. Fixed spacing going too far — rhodesk / githubweb
  744. Fixed comments being pushed over — rhodesk / githubweb
  745. Fixed not all variables being indented properly — rhodesk / githubweb
  746. Fixed indentation going beyond variables — rhodesk / githubweb
  747. Fixed file_functions indentation being off — rhodesk / githubweb
  748. Fixed indentation on operations being wrong — rhodesk / githubweb
  749. Reverted incorrect changes to new_pdf and new_hybrid_pdf — rhodesk / githubweb
  750. Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
  751. Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
  752. Removing gr as a module variable from grid_class. — rhodesk / githubweb
  753. Removing gr as a module variable from grid_class. — rhodesk / githubweb
  754. Fixing typo in stats_zm_module.F90.  Background:  Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases.  It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit.  This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced.  However, since the budget balance test still found the variable, it kept passing successfully.  This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format. — benjamin.andrew.stephens / githubweb
  755. Fixing a typo from an earlier commit. — noreply / githubweb
  756. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  757. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  758. Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB. — rhodesk / githubweb
  759. The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken. — rhodesk / githubweb
  760. Add error header for CLUBB in CAM — noreply / githubweb
  761. Fixing the ordering of gr in the clubb_api arg list for affected subroutines. — rhodesk / githubweb
  762. Fixing coding standard violations — rhodesk / githubweb
  763. Improving error messages in setup_clubb_core. larson-group/e3sm#38 — Gunther Huebler / githubweb
  764. Feeding stats variables through the argument lists of needed subroutines. — 72510114+RhodesKeegan / githubweb
  765. Fixing spacing issues along with placing the stats varibales on their own lines. — 72510114+RhodesKeegan / githubweb
  766. Changing more subroutines to include stats vars in their arg lists. — 72510114+RhodesKeegan / githubweb
  767. Fixing incorrect subroutine arg list — 72510114+RhodesKeegan / githubweb
  768. Fixing host models not compiling. — 72510114+RhodesKeegan / githubweb
  769. Fixing argument list so that way the coding standard is upheld. — 72510114+RhodesKeegan / githubweb
  770. I changed the name to calc_responder_driver because I thought that — bmg2 / githubweb
  771. Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978.  Related to #920. — 59519056+bstephens82 / githubweb
  772. Fixing comment for the wp2_term_pr_dfsn subroutine.  Related to #920. — 59519056+bstephens82 / githubweb
  773. Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. — 59519056+bstephens82 / githubweb
  774. Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues.  Related to #920. — 59519056+bstephens82 / githubweb
  775. Fixing some comments. — 59519056+bstephens82 / githubweb
  776. Correcting a typo bug and adding some descriptive comments to two new variables.  This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. — benjamin.andrew.stephens / githubweb
  777. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
  778. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
  779. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  780. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  781. Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation.  Related to #920. — 59519056+bstephens82 / githubweb
  782. Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine.  Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. — 59519056+bstephens82 / githubweb
  783. Removing l_interp_prescribed_params from setup_clubb_pdf_params. — rhodesk / githubweb
  784. Adding comments labeling subroutine calls with intent. — rhodesk / githubweb
  785. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
  786. Removing unnecessary constant from use statement — noreply / githubweb
  787. Eliminating l_nu_grid_dependent as requested. — rhodesk / githubweb
  788. Eliminating l_use_buoy_mod_Km_zm. — rhodesk / githubweb
  789. Eliminating l_iter_xp2_xpyp flag. — rhodesk / githubweb
  790. Eliminating l_apply_rule_to_pdf_params flag. — rhodesk / githubweb
  791. Eliminating l_ub_const_deriv flag. — rhodesk / githubweb
  792. Eliminating l_equation_21 flag. — rhodesk / githubweb
  793. Eliminating l_wp3_2nd_buoyancy flag. — rhodesk / githubweb
  794. Eliminating l_refine_grid_in_cloud and l_interactive_refined. — rhodesk / githubweb
  795. Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds — rhodesk / githubweb
  796. Eliminating l_use_wp3_pr3 flag. — rhodesk / githubweb
  797. Eliminating l_clip_semi_implicit flag. — rhodesk / githubweb
  798. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
  799. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  800. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  801. Eliminating l_include_ice and sat_ice_ratio. — rhodesk / githubweb
  802. Eliminating l_update_pressure flag. — rhodesk / githubweb

#25 (Aug 18, 2021, 3:36:09 AM)

  1. Reflecting changes made to clubb in host models — rhodesk / githubweb
  2. Raw-copy updating components/cam/src/physics/clubb — LarsonGroupSysAdmin / githubweb

#24 (Aug 17, 2021, 9:29:24 AM)

  1. Raw-copy updating components/cam/src/physics/clubb — LarsonGroupSysAdmin / githubweb
  2. Raw-copy updating components/cam/src/physics/silhs — LarsonGroupSysAdmin / githubweb
  3. Swapping out old intel varible pathing script for the new intel version. — pbroels / githubweb

#23 (Aug 14, 2021, 3:36:10 AM)

  1. Commiting to test host models — 72510114+RhodesKeegan / githubweb
  2. Reverting changes to clubb and silhs — 72510114+RhodesKeegan / githubweb

#22 (Aug 13, 2021, 3:36:08 AM)

  1. Eliminating l_use_wp3_pr3 flag. — rhodesk / githubweb
  2. Eliminating l_clip_semi_implicit flag. — rhodesk / githubweb
  3. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb

#21 (Aug 12, 2021, 3:36:07 AM)

  1. Eliminating l_apply_rule_to_pdf_params flag. — rhodesk / githubweb
  2. Eliminating l_ub_const_deriv flag. — rhodesk / githubweb
  3. Eliminating l_equation_21 flag. — rhodesk / githubweb
  4. Eliminating l_wp3_2nd_buoyancy flag. — rhodesk / githubweb
  5. Eliminating l_refine_grid_in_cloud and l_interactive_refined. — rhodesk / githubweb
  6. Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds — rhodesk / githubweb

#20 (Aug 11, 2021, 11:50:37 AM)

  1. Eliminating l_nu_grid_dependent as requested. — rhodesk / githubweb
  2. Eliminating l_use_buoy_mod_Km_zm. — rhodesk / githubweb
  3. Eliminating l_iter_xp2_xpyp flag. — rhodesk / githubweb

#18 (Aug 4, 2021, 3:36:08 AM)

  1. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
  2. Removing unnecessary constant from use statement — noreply / githubweb
  3. Update the diagnostic. Put white boxes on global plot for all regions. Issue #36. — guozhun / githubweb

#17 (Aug 3, 2021, 3:36:09 AM)

  1. Adding comments labeling subroutine calls with intent. — rhodesk / githubweb

#16 (Jul 31, 2021, 3:36:07 AM)

  1. Removing l_interp_prescribed_params from setup_clubb_pdf_params. — rhodesk / githubweb

#15 (Jul 30, 2021, 3:36:07 AM)

  1. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  2. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  3. Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation.  Related to #920. — 59519056+bstephens82 / githubweb
  4. Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine.  Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. — 59519056+bstephens82 / githubweb

#14 (Jul 28, 2021, 3:36:06 AM)

  1. Feeding stats variables to needed subroutines — 72510114+RhodesKeegan / githubweb
  2. Fixing compiliation errors — 72510114+RhodesKeegan / githubweb
  3. Fixing compiliation errors — 72510114+RhodesKeegan / githubweb
  4. Reflecting changes to nightly tests clubb_intr — 72510114+RhodesKeegan / githubweb
  5. Removing updated clubb and silhs directories — 72510114+RhodesKeegan / githubweb
  6. Fixing incorrect coding standard — 72510114+RhodesKeegan / githubweb
  7. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
  8. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb

#13 (Jul 27, 2021, 3:35:08 AM)

  1. Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978.  Related to #920. — 59519056+bstephens82 / githubweb
  2. Fixing comment for the wp2_term_pr_dfsn subroutine.  Related to #920. — 59519056+bstephens82 / githubweb
  3. Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. — 59519056+bstephens82 / githubweb
  4. Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues.  Related to #920. — 59519056+bstephens82 / githubweb
  5. Fixing some comments. — 59519056+bstephens82 / githubweb
  6. Correcting a typo bug and adding some descriptive comments to two new variables.  This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. — benjamin.andrew.stephens / githubweb