Skip to content
Success

Changes

Summary

  1. Adding if around allocation and adding call for fields to be output, these are both to prevent runtime bugs (details)
  2. Threadpublic (#1133) (details)
  3. Threadpublic (#1133) (details)
  4. Making compatible with latest clubb changes. (details)
Commit 5f63282539ac5158547226772ef4b94aed12fd40 by Gunther Huebler
Adding if around allocation and adding call for fields to be output, these are both to prevent runtime bugs
The file was modified components/eam/src/physics/cam/clubb_intr.F90 (diff)
Commit 69a0500429869014c93503d18cff3ccfd516dc6d by noreply
Threadpublic (#1133)

* Initial threadprivate removals and simple changes.

* model flags update, incomplete

* Some updates, almost working

* Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags

* Accompanying changes to flags lists

* Changes to corrrelation array setup

* Adding more flag checking

* Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit

* Adding saturation parameters to api

* Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB).

* Removing accidentally commited files.

* Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference.

* Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING

* Starting array_vars changes.

* No more global scalar indices

* Starting to remove hydromet indices

* Finished the annoying part with the microphysics interfaces.

* No more global variables in array_index. All cases BFB relative to last commit.

* No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon.

* Added nan checking before overriding default value for Ncnp2_on_Ncnm2

* Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol.

* open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0

* Adding better error messages to stats_init

* The nvidia compiler does not like zero size arrays.

* Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init.

* Reverting accidental changes to clubb_thread_test

* Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata

* Adding new types to _api

* Fixing erroneous name changes.

* Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7

* Removing print

* QuadTune: updates setup in order to read in 30x30
regional files automatically.

For #910.

* Updating the code to set the bottom of the thermodynamic level grid for
diffusion at thermodynamic level 2 -- the first level above the surface.

This is being done in preparation for ghostless gridding.

* Commit to enforce a fixed-point boundary condition of wp3=0 at
thermodynamic level k = 2, the first above-ground thermodynamic level.

This is being done in preparation for ghostless gridding.

This commit is bc.

Results are much more similar to the previous results than using
using zero-flux as the lower boundary condition for wp3.

* With wp3 now being set to a fixed-point boundary condition value
of 0 at the current thermodynamic level 2 (first t-lev above the
surface), it is not necessary to loop over level 2 within the code
for each wp3 term.

This commit is BIT_CHANGING, but only for the wp3 budget terms
(e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change
the actual answer. All other variables are bit-for-bit identical.

* Removing omp parallel test line

* Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2

---------

Co-authored-by: vlarson <vlarson@uwm.edu>
Co-authored-by: bmg929 <bmg2@uwm.edu>
The file was modified advance_windm_edsclrm_module.F90 (diff)
The file was modified new_hybrid_pdf_main.F90 (diff)
The file was modified stats_zm_module.F90 (diff)
The file was modified stats_zt_module.F90 (diff)
The file was modified corr_varnce_module.F90 (diff)
The file was modified index_mapping.F90 (diff)
The file was modified advance_xp3_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified sponge_layer_damping.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified parameters_model.F90 (diff)
The file was modified model_flags.F90 (diff)
The file was modified array_index.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
The file was modified clip_explicit.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified precipitation_fraction.F90 (diff)
The file was modified error_code.F90 (diff)
The file was modified output_netcdf.F90 (diff)
The file was modified stat_file_module.F90 (diff)
The file was modified diagnose_correlations_module.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified mixing_length.F90 (diff)
The file was modified setup_clubb_pdf_params.F90 (diff)
The file was modified sfc_varnce_module.F90 (diff)
The file was modified fill_holes.F90 (diff)
The file was modified numerical_check.F90 (diff)
The file was modified adg1_adg2_3d_luhar_pdf.F90 (diff)
The file was modified saturation.F90 (diff)
Commit 14c8636ab5c46f3f20204fae38b1eeb765bc804c by noreply
Threadpublic (#1133)

* Initial threadprivate removals and simple changes.

* model flags update, incomplete

* Some updates, almost working

* Added saturation_formula and l_host_applies_sfc_fluxes to clubb_config_flags

* Accompanying changes to flags lists

* Changes to corrrelation array setup

* Adding more flag checking

* Forgot to set l_host_applies_sfc_fluxes in initialize_clubb_config_flags_type and commit adding l_implemented to the argument loit

* Adding saturation parameters to api

* Most of the way through passing sclr_dim, hydromet_dim, edsclr_dim, and sclr_tol through arguemnt lists. Moved first_write breaking silhs stats aparently, and bit changing due to the way we were writing sclr_tol for cases that have sclr_dim=0 (arm different, gabls2 BFB).

* Removing accidentally commited files.

* Fixed silhs output, all cases BFB but sclr_tol is saved differently to stats files in cases where sclr_dim = 0, so this is bc also bc:fb20458d5212b007c79c17613201af637bbc3d7e since that introduced the difference.

* Changing stats logicals back to false, only set to true for testing. So technically BIT_CHANGING

* Starting array_vars changes.

* No more global scalar indices

* Starting to remove hydromet indices

* Finished the annoying part with the microphysics interfaces.

* No more global variables in array_index. All cases BFB relative to last commit.

* No more global pdf_dim, Ncnp2_on_Ncnm2 now set via argument list, and added temporary hydromet_dim_glob because I thought it would fix a bug but it didn't, it might in the future though, so I left it in for now, it will be removed soon.

* Added nan checking before overriding default value for Ncnp2_on_Ncnm2

* Finished hydromet_dim argument listing and removed global versions of it as well as sclr_dim, edsclr_dim, and sclr_tol.

* open_netcdf_for_writing does nothing if nvars=0 for a stats file, which is understandable, but now that we call first_write immediately after we need that also to check for nvar=0

* Adding better error messages to stats_init

* The nvidia compiler does not like zero size arrays.

* Adding defaults for scalar arrays values in clubb driver, and adding an error check after calling stats_init.

* Reverting accidental changes to clubb_thread_test

* Changing name of scarr/scalar_array to sclr_idx and hydromet_array to hm_metadata

* Adding new types to _api

* Fixing erroneous name changes.

* Fixing bug introduced in 65987c8a77496f7bb10bfd28717345b1f63de1b7

* Removing print

* QuadTune: updates setup in order to read in 30x30
regional files automatically.

For #910.

* Updating the code to set the bottom of the thermodynamic level grid for
diffusion at thermodynamic level 2 -- the first level above the surface.

This is being done in preparation for ghostless gridding.

* Commit to enforce a fixed-point boundary condition of wp3=0 at
thermodynamic level k = 2, the first above-ground thermodynamic level.

This is being done in preparation for ghostless gridding.

This commit is bc.

Results are much more similar to the previous results than using
using zero-flux as the lower boundary condition for wp3.

* With wp3 now being set to a fixed-point boundary condition value
of 0 at the current thermodynamic level 2 (first t-lev above the
surface), it is not necessary to loop over level 2 within the code
for each wp3 term.

This commit is BIT_CHANGING, but only for the wp3 budget terms
(e.g. wp3_ta) in the zt output file at level k = 2. It doesn't change
the actual answer. All other variables are bit-for-bit identical.

* Removing omp parallel test line

* Removing parameter declarion around l_quintic_poly_interp. Having this be a parameter causes bit changes when using -O2

---------

Co-authored-by: vlarson <vlarson@uwm.edu>
Co-authored-by: bmg929 <bmg2@uwm.edu>
The file was modified silhs_importance_sample_module.F90 (diff)
The file was modified transform_to_pdf_module.F90 (diff)
The file was modified latin_hypercube_driver_module.F90 (diff)
The file was modified output_2D_samples_module.F90 (diff)
The file was modified silhs_api_module.F90 (diff)
Commit ba7ed42d545ad511fe53aa45900746100b35d7fb by Gunther Huebler
Making compatible with latest clubb changes.
The file was modified components/eam/src/physics/cam/subcol_SILHS.F90 (diff)
The file was modified components/eam/src/physics/cam/clubb_intr.F90 (diff)