Skip to content
Success

Changes

Summary

  1. Moved the ghost-point setting of xm(1) = xm(2) to the last line (details)
  2. Optional arguments are just best sometimes (#1150) (details)
Commit 13811b3b0775ce0412d5ca84a1c0e8787e3823f6 by bmg2
Moved the ghost-point setting of xm(1) = xm(2) to the last line
of the subroutine so this command doesn't get overwritten.

This is technically BIT_CHANGING because it alters rtm (and some
rtm-related calculations) at the ghost point, but it is not
answer changing.

This is being done in preparation for ghost point removal.
The file was modified advance_xm_wpxp_module.F90 (diff)
Commit 6db5d3c85dd296d8ccafe66f5e7e20b241d37188 by noreply
Optional arguments are just best sometimes (#1150)

* Adding optional argument to zm2zt/zt2zm to act as threshold. This cuts down on lots of bulk and reduces the chances of breaking the GPU code. All BFB.

* Removing TODO

* Replacing hardcoded 0.0_core_rknd with zero_threshold
The file was modified advance_windm_edsclrm_module.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified mixing_length.F90 (diff)
The file was modified calc_pressure.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified advance_xp3_module.F90 (diff)
The file was modified grid_class.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified setup_clubb_pdf_params.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)