Skip to content
Sign in
Failed

Changes

Summary

  1. Bring readiopdata changes into master (#1343) (details)
  2. Previous commit improved the robustness of -override option and teased out a couple bugs in tests, causing them to fail. This adds the ability to specify which namelist an override goes in if there's no associated key to replace, the failing tests can be fixed by making use of this. One test is fixed here, and the other needed a change in a BFB config hosted on the jenkins server. (details)
Commit 4aa411aa309abec014934f1589d435a83a9a4bec by noreply
Bring readiopdata changes into master (#1343)

* Brought changes from readiopdata2 onto modern master branch

 - Currently code successfully compiles but fails to run

* Fixed errors, allowing for both cases to be run and plotted!

 - fixed variable names in .in files

* Fixes, add ifdef UWM_MISC statements, and changed alt_type/theta_type

* Added l_readiopdata into ALL bomex model.in files

* Code improvements

 - Fixed source code compilation check warnings

 - Checked and updated parameter order

 - All code I changed now has intent in/out labeled on calls

 - Found more instances of alt_type and theta_type to be renamed in clubb_jax and clubb_python

 - readiopdata_core_module.F90 moved into a folder to prepare for git subtrees

* Change to be identical to sam_clubb readiopdata_core_module and a fix in arm_0003

* Fix order of operations to fix cgils cases
The file was modifiedsrc/Benchmark_cases/arm_3year.F90 (diff)
The file was modifiedsrc/Input_fields/CMakeLists.txt (diff)
The file was modifiedsrc/Input_fields/sounding.F90 (diff)
The file was modifiedinput/case_setups/bomex_model.in (diff)
The file was modifiedsrc/clubb_driver.F90 (diff)
The file was modifiedutilities/case_setup/sclr_sounding_conversion.F90 (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/prescribe_forcings_module_wrapper.F90 (diff)
The file was modifiedsrc/Benchmark_cases/bomex.F90 (diff)
The file was modifiedclubb_python_driver/io/sounding.py (diff)
The file was addedinput/case_setups/BOMEX_5day_4scam.nc
The file was addedinput/case_setups/bomex_5day_4scam_model.in
The file was modifiedsrc/Benchmark_cases/arm.F90 (diff)
The file was addedsrc/readiopdata_core/readiopdata_core_module.F90
The file was modifiedsrc/Benchmark_cases/arm_0003.F90 (diff)
The file was addedsrc/readiopdata_module.F90
The file was modifiedsrc/Input_fields/hydrostatic_module.F90 (diff)
The file was modifiedsrc/Benchmark_cases/prescribe_forcings.F90 (diff)
The file was modifiedsrc/Benchmark_cases/sfc_flux.F90 (diff)
The file was modifiedclubb_jax/io/sounding.py (diff)
The file was modifiedcmake/utils/CPPDefinitions.cmake (diff)
The file was modifiedsrc/Input_fields/input_interpret.F90 (diff)
The file was modifiedclubb_jax/clubb_case_initalization.py (diff)
The file was modifiedclubb_python_driver/clubb_case_initalization.py (diff)
The file was modifiedsrc/Benchmark_cases/time_dependent_input.F90 (diff)
Commit 1f4ec8993842ad7859cefecdfab5e067b07c53fa by Gunther Huebler
Previous commit improved the robustness of -override option and teased out a couple bugs in tests, causing them to fail. This adds the ability to specify which namelist an override goes in if there's no associated key to replace, the failing tests can be fixed by making use of this. One test is fixed here, and the other needed a change in a BFB config hosted on the jenkins server.
The file was addedutilities/pytests/test_create_case_namelist.py
The file was modifiedutilities/create_case_namelist.py (diff)
The file was modifiedtests/run_silhs_test.py (diff)
The file was modifiedrun_scripts/run_scm.py (diff)