Skip to content
Success

Changes

Summary

  1. Setting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway. (details)
  2. Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core.  Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs).  This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated. (details)
Commit e76e585977733881be1a7e0dc5463a473f6dab90 by benjamin.andrew.stephens
Setting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway.

This is BIT_CHANGING.

See https://github.com/larson-group/e3sm/issues/6.
The file was modified configurable_model_flags.in (diff)
Commit e4f82e1b3305f7216e84599127b6cd77ee518c29 by benjamin.andrew.stephens
Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core.  Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs).  This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated.

See #920.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)