Skip to content
Failed

Changes

Summary

  1. Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. (details)
  2. Adding new coefficient to control the wp3 pressure diffusion term. (details)
  3. Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. (details)
  4. Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. (details)
  5. Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). (details)
  6. These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. (details)
  7. Adding new coefficient to control the wp3 pressure diffusion term. (details)
  8. Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form.  This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. (details)
  9. These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. (details)
  10. Added intent comments for the following files: (details)
Commit 37095bf5ace54791fd4db1161ba1f8e010cb9ac2 by 59519056+bstephens82
Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen.
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified stats_zt_module.F90 (diff)
The file was modified stats_variables.F90 (diff)
Commit bc7ddc176b62b69e5f4d20e730795946851ea82e by 59519056+bstephens82
Adding new coefficient to control the wp3 pressure diffusion term.
The file was modified clubb_api_module.F90 (diff)
The file was modified parameters_tunable.F90 (diff)
The file was modified parameter_indices.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
Commit 96e5f1e5197fb6e1e353d02f5b211b1e8c5f96af by 59519056+bstephens82
Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms.
The file was modified advance_wp2_wp3_module.F90 (diff)
Commit 6126e2953143ab61f74665b3922ee4cc94894fae by 59519056+bstephens82
Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo.
The file was modified stats_clubb_utilities.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
Commit 0566da01bc8cc1fa3a19f92f3b19f1a4d453839d by 59519056+bstephens82
Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output).

See #884.
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified parameters_tunable.F90 (diff)
The file was modified parameter_indices.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
Commit 45aa88a48da8927786467626eea335eea48498bc by 59519056+bstephens82
These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.

The new variables are also added to pyplotgen as part of VariableGroupWs.py where wp4 is found.

See #920.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
The file was modified stats_zm_module.F90 (diff)
The file was modified stats_variables.F90 (diff)
Commit f93e240972461676abf906e01b37399306126ead by 59519056+bstephens82
Adding new coefficient to control the wp3 pressure diffusion term.
The file was modified tunable_parameters.in (diff)
Commit 12176c345358d78a4d827cf2b6e7abdbaec0ea8c by 59519056+bstephens82
Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form.  This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch.

See #920.
The file was modified advance_wp2_wp3_module.F90 (diff)
Commit 35540475b191c71945e840eb1b1d43b19ef48512 by 59519056+bstephens82
These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.

The new variables are also added to pyplotgen as part of VariableGroupWs.py where wp4 is found.

See #920.
The file was modified tunable_parameters.in (diff)
Commit 1dbc0bf3a0b130e9c249a7142eefba732e17b1e7 by rhodesk
Added intent comments for the following files:
advance_clubb_core_module, advance_helper_module, and advance_windm_edsclrm_module.
These changes are BFB.
For ticket #924.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified interpolation.F90 (diff)
The file was modified advance_windm_edsclrm_module.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified stats_type_utilities.F90 (diff)
The file was modified calc_pressure.F90 (diff)