Skip to content
Sign in
Success

#328 (May 2, 2024, 3:04:06 AM)

Started 2 yr 5 mo ago
Took 25 min

Started by an SCM change

Revision: 3319ad8bfd74d7829cdf03a0ac7813c22d4094c5
Repository: https://github.com/larson-group/sam_clubb.git
  • refs/remotes/origin/master
Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.
( d6ca5b0 )
Gunther Huebler at
Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.
( c2849fa )
Gunther Huebler at
Making compatible with latest clubb changes.
( ecc32fd )
Gunther Huebler at