Skip to content
Sign in
Builds

Changes

#493 (Oct 20, 2026, 3:03:09 AM)

Clubb params 1d to 2d fix (#1392)
( ba52dc6 )
noreply at

#492 (Oct 14, 2026, 3:03:08 AM)

Fixed bug in cubic equation solve function. Only relevant if pdf is L… (#1387)
( 76464de )
noreply at

#491 (Oct 13, 2026, 3:03:06 AM)

Fix arm97+l do expldiff rtm thlm+set edsclrm f early (#1386)
( 9cb7901 )
noreply at
host model change for clubb PR #1386 (#182)
( 7b66560 )
noreply at

#490 (Oct 5, 2026, 3:03:07 AM)

Jax silhs (#1372)
( d0b2c1b )
noreply at
Update SILHS initialization for deterministic sampling flag (#181)
( 89f2d1d )
noreply at

#489 (Oct 4, 2026, 3:03:07 AM)

Serialize NetCDF statistics output across OpenMP threads
( f62b1d8 )
Gunther Huebler at

#488 (Oct 1, 2026, 3:03:07 AM)

Rename derived-parameter routine across CLUBB interfaces
( 268985e )
Gunther Huebler at
Use renamed CLUBB derived-parameter API in SAM (#180)
( 0585b6c )
noreply at

#487 (Sep 29, 2026, 3:03:06 AM)

Remove upsilon 0 and 1 if branches (#1365)
( 7c257a5 )
noreply at

#486 (Sep 23, 2026, 3:03:08 AM)

F90 fix multicol+l add dycore grid (#1363)
( 74c8f59 )
noreply at

#485 (Sep 17, 2026, 3:03:06 AM)

Test different f90 vs jax flags (#1357)
( 954344c )
noreply at

#484 (Sep 16, 2026, 3:03:09 AM)

Fixing microphys bug that has been around for quite a while. This happened when making clubb standalone use multiple columns, and only affects columns other than the first. This is BIT_CHANGING, but only for microphysics cases using multiple columns (#1358)
( e7f80b0 )
noreply at
Fixing microphys bug that has been around for quite a while. This happened when making clubb standalone use multiple columns, and only affects columns other than the first. This is BIT_CHANGING, but only for microphysics cases using multiple columns (#1358)
( 91c9f5e )
noreply at

#483 (Sep 8, 2026, 3:03:09 AM)

Little OpenACC fixes for microphys code RESOLVED:900681c91bdbdf8d6cd069bab01663ebac1a3279
( 7c7b3ac )
Gunther Huebler at

#482 (Sep 6, 2026, 3:03:09 AM)

Microphys loop push (#1355)
( a2e87e0 )
noreply at
Microphys loop push (#1355)
( d2dcdb6 )
noreply at
Adapt SAM SILHS callers to multicolumn CLUBB APIs (#179)
( c92d725 )
noreply at

#481 (Sep 3, 2026, 3:03:06 AM)

Clubb JAX (#1351)
( faeef51 )
noreply at

#480 (Aug 25, 2026, 3:03:06 AM)

Remove a blank line in order to trigger nightly tests
( a593094 )
noreply at

#479 (Aug 22, 2026, 3:03:08 AM)

Updates to readiopdata_core and corresponding calls (#178)
( 4462a5f )
noreply at
Add blank line to trigger gitUpdateScripts
( e8f6ee6 )
noreply at

#478 (Aug 21, 2026, 3:03:06 AM)

Improve Dash workflows and broker services (#1342)
( 6bea768 )
noreply at
Improve Dash workflows and broker services (#1342)
( 56d859f )
noreply at

#477 (Aug 11, 2026, 3:03:06 AM)

Fill holes tab (#1339)
( 2197d8a )
noreply at

#476 (Aug 5, 2026, 3:03:08 AM)

Mainly dash updates and a little source changes to improve parameter/flag checking. See https://github.com/larson-group/clubb/pull/1336 for details
( dbf6a1d )
Gunther Huebler at
Update SAM for CLUBB validation API (#177)
( b42c20d )
noreply at

#475 (Jul 28, 2026, 3:03:09 AM)

Fixing bug in advance_xp3 code. This is BFB because advance_xp3 is hardcoded to false.
( 9cf7967 )
Gunther Huebler at

#474 (Jul 26, 2026, 3:03:07 AM)

Setting l_diag_Lscale_from_tau to false by default, and changing it to true in the flag set list the run_bindiff_w_flags test uses so that we keep testing the tau code nightly. This flag changes answers, so this is BIT_CHANGING.
( 6c4e8ff )
Gunther Huebler at
Setting l_diag_Lscale_from_tau to false by default, and changing it to true in the flag set list the run_bindiff_w_flags test uses so that we keep testing the tau code nightly. This flag changes answers, so this is BIT_CHANGING.
( b3576ee )
Gunther Huebler at
Removing the l_tke_aniso flag
( d8be3bb )
Gunther Huebler at
Removing the l_tke_aniso flag
( c3da867 )
Gunther Huebler at
Update SAM CLUBB flag interface (#172)
( 369aa74 )
noreply at

#472 (Jul 14, 2026, 3:03:06 AM)

Removed option to disable silhs
( c9c43ea )
Trevor Hancock at

#471 (Jul 11, 2026, 3:03:10 AM)

Removed option to disable netcdf (#1331)
( f4c907c )
noreply at
Removed option to disable silhs (#1332)
( 18ebfd4 )
noreply at

#470 (Jul 8, 2026, 3:03:08 AM)

Clubb timer upgrade (#1328)
( 2bb406e )
noreply at

#469 (Jul 7, 2026, 3:03:10 AM)

Tuner additions (#1324)
( b6b675d )
noreply at
Remove old SVN version control identifier ($Id$) from tunable_parameters.in
( a7809fa )
noreply at
Raw copy update: input/parameter_and_flag_configs/default -> CLUBB_PARAMETERS; branch: master
( 4bb5f99 )
root at
Delete CLUBB_PARAMETERS directory in order to reset the git subtree history
( a18d1e0 )
noreply at
Remove blank line to test git update scripts
( efe60f9 )
noreply at

#468 (Jul 3, 2026, 3:03:10 AM)

Making compatible with clubb directory renaming from https://github.com/larson-group/clubb/pull/1324
( e853849 )
Gunther Huebler at

#467 (Jun 26, 2026, 3:03:09 AM)

Removing ifdefs that are only for E3SM and only on a specific machine
( 7ea5f3a )
Gunther Huebler at
Removing the CLUBBND_CAM option, not sure what it was for, it's not defined in this repo or any of our host model repos
( 35b109b )
Gunther Huebler at
Removing unused variables
( 1d62572 )
Gunther Huebler at

#466 (Jun 20, 2026, 3:03:09 AM)

Clubb loss driver (#1303)
( 24c744a )
noreply at
Clubb loss driver (#1303)
( b6515b0 )
noreply at

#465 (Jun 10, 2026, 3:03:06 AM)

Removed/Deleted GrADS (.ctl, .dat) file format and reference to it (#1310)
( a815349 )
noreply at

#463 (Jun 4, 2026, 3:03:08 AM)

Clubb organization part3 (#1306)
( ddf0dd0 )
noreply at

#462 (May 28, 2026, 3:03:09 AM)

Removing unneccesary wp2_zt conversion that should've been removed already, but was accidentally added back in the last PR when trying to split BFB from non-BFB changes. This was an unused local variable so this does not affect anything.
( 0b6d240 )
Gunther Huebler at

#461 (May 27, 2026, 3:03:08 AM)

Clubb organization part2 (#1304)
( 72b3ab7 )
noreply at

#460 (May 20, 2026, 3:03:06 AM)

Removing a couple variables from openacc statements to fix the clubb_driver_test - these were causing stats errors on the GPU for chi and chip2. This is technically BIT_CHANGING.
( af96de4 )
Gunther Huebler at

#459 (May 19, 2026, 3:03:09 AM)

Clubb organization part1 (#1302)
( 3e00314 )
noreply at

#458 (May 15, 2026, 3:03:06 AM)

This fixes the GPU BFB test that failed due to stats-only differences in rtm_ed and thlm_ed, and as a result is technically BIT_CHANGING. Also, the BFB with varying flags failed because flag set 1 changed to use the lapack solvers since the custom ones it set before are now default. RESOLVED:34c6bb07afb6e445f60ea87dcc632969086f9fa1
( f32ccd8 )
Gunther Huebler at

#457 (May 14, 2026, 3:03:07 AM)

advance_clubb_core cleanup (#1301)
( 3d23573 )
noreply at

#456 (May 6, 2026, 3:03:07 AM)

Making compatible with latest clubb changes
( b082396 )
Gunther Huebler at
Fixing python api and python/jax driver. Also fixing bug that caused non-BFBness in stats outputs (only upwp_cl/vpwp_cl) when using l_predict_upwp_vpwp=.false., and adding ulimit -s 8388608 to fix GPU test (though it's unclear why exactly we need this all of a sudden for this test). RESOLVED:643d128a5613019595aecd643f1028e937ad4b76 RESOLVED:f146255f50732c445ccbd012ca45888a9ce44d0b, and since this changes stats this is technically BIT_CHANGING"
( 17a8ced )
Gunther Huebler at

#455 (May 5, 2026, 3:03:06 AM)

Clip covar simplifications (#1297)
( 0cac48d )
noreply at

#454 (Apr 9, 2026, 3:03:07 AM)

Remove line to test python scripts
( e441799 )
noreply at
Add blank line to test python scripts
( 67261c9 )
noreply at

#453 (Apr 8, 2026, 3:03:08 AM)

Print the fact that the LES KK micro run turns off CLUBB
( 568b45b )
noreply at
Adding err_info back to stats_end_timestep_api
( d270660 )
Gunther Huebler at
Fixing monoflux limiter test - there was a comment that was split across lines, which broke the test
( da324d9 )
Gunther Huebler at
Removing unused variable
( b60dc21 )
Gunther Huebler at

#452 (Apr 7, 2026, 3:03:07 AM)

Standards fix (#1288)
( 1f8ac54 )
noreply at
Standards fix (#1288)
( aaaa795 )
noreply at
Standards fix (#1288)
( 412e42d )
noreply at
Remove blank line to trigger git update script
( 2a35d01 )
noreply at
Added blank line to trigger git update scripts
( c9a2bfa )
noreply at
Removed blank line to trigger git update scripts
( c2aaf0d )
noreply at
Add blank line to trigger git update scripts
( 38d3752 )
noreply at
Add blank line to trigger git update scripts
( 379669d )
noreply at
Remove gitignore to trigger git update scripts
( 6f63b7e )
noreply at
Ensure empty folders exist via .gitignore
( 7d9ed8d )
root at

#451 (Apr 6, 2026, 3:03:07 AM)

Making run_bindiff_w_flags.py faster by calling run_scm.py directly and parallelizing over all cases/flag sets, rather than just calling run_scm_all.py and parallelizing over each flag batch. Also fixing a little stats bug that caused the time string to have weird trailing characters, and removing a little states print
( abb82f5 )
Gunther Huebler at

#450 (Mar 24, 2026, 3:03:09 AM)

Little Fix (#1287)
( c0491ff )
noreply at

#449 (Mar 23, 2026, 3:03:07 AM)

GPUizing most of radiation code
( 6b992b6 )
Gunther Huebler at

#448 (Mar 19, 2026, 3:03:05 AM)

Clubb radiation update (#1283)
( 4c3e62e )
noreply at
Dash app improvements (#1280)
( 154d87c )
noreply at

#447 (Mar 18, 2026, 3:03:08 AM)

ADG1_w_closure consistency fix (#1282)
( e088908 )
noreply at
Fixing clubb_error_handling_gfortran_test (#1281)
( 8c9f81a )
noreply at

#446 (Mar 16, 2026, 3:03:07 AM)

Stability fix (#1276)
( 4e8a58b )
noreply at

#445 (Mar 14, 2026, 3:03:06 AM)

New solvers by default (#1275) - BIT_CHANGING
( ba8a5be )
noreply at
Add blank line in order to trigger git updates (issue #848)
( 156f7a7 )
noreply at
Added blank line
( b955bcd )
Trevor Hancock at
Remove Id tag from LY93_pdf.F90 in order to trigger git update scripts
( 6f52a83 )
noreply at
Remove unnecessary comments from est_kessler_microphys_module
( f9d5c3e )
noreply at

#444 (Mar 12, 2026, 3:03:07 AM)

New solvers by default (#1275) - BIT_CHANGING
( f1a6ede )
noreply at

#443 (Mar 11, 2026, 3:03:07 AM)

Autoupdated tunable_parameters
( 7abdc05 )
root at

#442 (Mar 3, 2026, 3:03:07 AM)

Add blank line to test python scripts
( c309d7a )
noreply at
Added blank line to test python update scripts
( 0cdf887 )
noreply at

#441 (Feb 24, 2026, 3:03:07 AM)

Added blank line to test new python scripts
( e1212e4 )
Trevor Hancock at
Added a space to test new python update scripts
( 3e65f59 )
Trevor Hancock at
Fixed space to match Clubb spacing
( 200f3c1 )
Trevor Hancock at

#440 (Feb 17, 2026, 11:43:18 PM)

New stats system (#1270)
( ca2eb41 )
noreply at
New stats system (#1270)
( 00e0c2f )
noreply at
Fixing fire tuner
( 231830e )
Gunther Huebler at
Update to make compatible with new stats. (#169)
( 9338ba9 )
noreply at

#439 (Feb 12, 2026, 3:03:07 AM)

Removed blank line to test python update scripts
( 5505ad9 )
Trevor Hancock at
Added empty folders (with .gitignore files because git doesn't allow empty folders)
( f244d2d )
Cole Pickett at
Fixed double space to test updateClubbMorrison.py python script
( 8a87662 )
Trevor Hancock at

#438 (Feb 10, 2026, 3:03:09 AM)

Added empty line to test update scripts
( d29406c )
Cole Pickett at

#437 (Feb 6, 2026, 3:03:11 AM)

Moving wp2sclrp, wpsclrp2, wpsclrprtp, and wpsclrpthlp to the zt netcdf output file, since those are zt variables. Also adding a missing variable, rcm_in_cloud, to all_stats.in and correcting a missing comma bug. This is technically BIT_CHANGING because the variables are moving files, but the stored data is identical from 1:nzt - the nzm level just had garbage for those variables and is now gone. (#1271)
( 48b789e )
noreply at

#436 (Jan 10, 2026, 3:03:07 AM)

GPU fixed and cgils_s6 fix
( a7e3b71 )
Gunther Huebler at
More small bug fixes
( f52566e )
Gunther Huebler at
Forgot to rename flags
( fc3660b )
Gunther Huebler at
Removing extra acc end statement
( 0aea68b )
Gunther Huebler at

#435 (Jan 9, 2026, 3:03:07 AM)

Non trad coriolis (#1267)
( 7a1bb75 )
noreply at
Non trad coriolis (#1267)
( c3271dd )
noreply at
Making changes needed for clubb's new non traditional coriolis update (#168)
( 6fde246 )
noreply at

#434 (Dec 18, 2025, 3:03:07 AM)

Fixes for fill_holes and edsclr code (#1266)
( 058f1a7 )
noreply at

#433 (Dec 11, 2025, 3:03:09 AM)

Grid reverse matrix test (#1265)
( b084a98 )
noreply at

#432 (Dec 6, 2025, 3:03:09 AM)

BIT_CHANGING bug fix for the penta_lu solver, only BC when using penta_solve_method=2 (#1264)
( 419df6e )
noreply at
Bicgstab addition (#1261)
( c77842f )
noreply at
Small bug fix to make gfortran+debug happy, without the _core_rknd this could be a potential type error
( 74514b3 )
Gunther Huebler at

#431 (Nov 24, 2025, 3:03:10 AM)

Making update_xp2_mc work with either grid mode (#1263)
( a3ea9b9 )
noreply at
Improving variable name
( f738022 )
Gunther Huebler at
Small bug fix, but this is BIT_CHANGING because it affects stats output. Some zm fields (w_1_zm, w_2_zm, varnce_w_1_zm, varnce_w_2_zm, and mixt_frac_zm) were all nan in the netcdf output when l_call_pdf_closure_twice=.false., because those come from pdf_params_zm.
( 5fa665e )
Gunther Huebler at

#430 (Nov 18, 2025, 3:03:07 AM)

Removing accidentally added files
( a144bd2 )
Gunther Huebler at

#429 (Nov 16, 2025, 3:03:09 AM)

Making clubb_at_least_debug_level not a device routine. It confuses the poor little nvidia compiler when compiling inside cam. Also making the compile script a little more robust.
( 1e5a08c )
Gunther Huebler at

#428 (Nov 14, 2025, 3:03:09 AM)

New fill_holes methods (#1262)
( 5f24af9 )
noreply at
New fill_holes methods (#1262)
( 8aa1a13 )
noreply at
Making compatible with new version of clubb (#167)
( d54a1aa )
noreply at
Small bug fix in fill_holes_parallel on GPU
( 6df93a7 )
Gunther Huebler at

#427 (Oct 5, 2025, 9:55:48 PM)

Clubb driver upgrades part2 (#1257)
( 6061db3 )
noreply at
Clubb driver upgrades part2 (#1257)
( 65c0ff8 )
noreply at
Compatibility upgrades (#166)
( e907949 )
noreply at

#426 (Oct 3, 2025, 3:03:07 AM)

Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true.
( 406e74e )
Gunther Huebler at
thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint.
( 895048c )
Gunther Huebler at

#425 (Oct 2, 2025, 3:03:06 AM)

Making the l_random_k_lh_start set the random generator seed before generating a random. This should fix the generalized grid test, which failed for the only flag set that turned on l_random_k_lh_start. Before, the test passed because we used the same random seed for all timesteps, preventing differences in the random call. But now we use a different seed each timestep, causing differences. To ensure reproducibility, we use the seed each timestep to generate rand_pool, which is an effective solution, but we need to do that for the rand_integer_in_range call in the l_random_k_lh_start code for the same reason. Since this does change the random that comes out, this is BIT_CHANGING, but only for runs using both SILHS and l_random_k_lh_start=.true.
( 50f5a9a )
Gunther Huebler at

#424 (Oct 1, 2025, 3:03:06 AM)

SILHS reproducibility (#1258)
( c65ac4c )
noreply at

#423 (Sep 28, 2025, 3:03:08 AM)

Change tolerance in way that affects only single precision builds (#1256)
( 06d501c )
noreply at

#422 (Sep 27, 2025, 3:03:08 AM)

Remove module vars from grid_adaptation_module (#1255)
( 4660a60 )
noreply at

#421 (Sep 26, 2025, 3:03:08 AM)

Precip frac fix (#1254)
( f68b263 )
noreply at

#420 (Sep 25, 2025, 3:03:08 AM)

The cmake update (#1253)
( 98d8c48 )
noreply at
The cmake update (#1253)
( 3c612a8 )
noreply at
The cmake update (#1253)
( 9ab3888 )
noreply at

#419 (Sep 24, 2025, 3:03:08 AM)

Adding expldiff budget terms for thlm and rtm (#1252)
( 123a31f )
noreply at

#418 (May 23, 2025, 3:03:07 AM)

fix precision error of reals
( 177ee20 )
noreply at
rename grid_adaptation and remapping modules
( 0ae10ff )
0-freundlich-adenin at
add fix for grid generalization
( 3481c17 )
0-freundlich-adenin at

#417 (May 22, 2025, 3:03:08 AM)

Merge grid adaptation implementation (#1249)
( b558b03 )
noreply at

#416 (May 21, 2025, 3:03:09 AM)

zm and zt were mixed up in the error prints argument list.
( a1ccb74 )
bmg2 at

#415 (May 14, 2025, 3:03:10 AM)

Removed simple wrappers from clubb_api_module (#1245)
( 49db55b )
noreply at
Removed simple wrappers from clubb_api_module (#1245)
( c7ab3b9 )
noreply at

#414 (May 10, 2025, 3:03:09 AM)

Fixed and equalized NaN checks in lapack_wrap (#1246)
( e36dc57 )
noreply at

#413 (May 7, 2025, 3:03:12 AM)

Cleaning up some grid generalization issues that were found within
( a986aeb )
bmg2 at

#412 (May 3, 2025, 3:03:06 AM)

Run scm fixes (#1244)
( ed8cf99 )
noreply at

#411 (May 2, 2025, 3:03:07 AM)

Removed renaming operators `=>` and wrapper subroutines from silhs_api_module (#1240)
( 32a5fe0 )
noreply at

#410 (Apr 26, 2025, 3:03:09 AM)

Running CLUBB with l_stability_correct_tau_zm = .true. now requires
( a58963f )
bmg2 at
Running CLUBB with l_stability_correct_tau_zm = .true. now requires
( f479639 )
bmg2 at
These changes were accidentally made during the previous commit. The are
( 75c64ae )
bmg2 at
These changes were accidentally made during the previous commit. The are
( a3ac065 )
bmg2 at

#409 (Apr 25, 2025, 3:03:10 AM)

Err code gpu fix (#1241)
( f922df0 )
noreply at

#408 (Apr 24, 2025, 3:03:06 AM)

Err code struct (#1238)
( 3d241e5 )
noreply at
Err code struct (#1238)
( 1a4c3cc )
noreply at
Update clubb_sgs.F90 to incorporate err_info (#165)
( cfd9835 )
noreply at

#407 (Apr 23, 2025, 3:03:06 AM)

I updated adj_low_res_nu for use with a generalized grid. It is
( 38c8aa0 )
bmg2 at

#406 (Apr 10, 2025, 3:03:09 AM)

Clubb silhs gg (#1239)
( 55eae9b )
noreply at
Clubb silhs gg (#1239)
( 22f5d49 )
noreply at
Updating calls to generate_silhs_sample_api for recent changes to
( 3cf84e9 )
bmg2 at

#405 (Mar 28, 2025, 3:03:06 AM)

Clubb driver upgrades (#1225)
( 92f350d )
noreply at

#404 (Mar 24, 2025, 3:03:06 AM)

Clubb test correct gg (#1237)
( 685fa70 )
noreply at

#403 (Mar 12, 2025, 3:03:08 AM)

The generalized grid test should not output a clubb fatal error when it
( 8d394f9 )
bmg2 at

#402 (Mar 8, 2025, 3:03:08 AM)

Revert "I have no idea if it's appropriate to include gr in this statment,"
( d13c904 )
bmg2 at
I discovered that I inadvertently change an $acc statement that
( c39543a )
bmg2 at

#401 (Mar 6, 2025, 3:03:08 AM)

Eliminate GOTO statement in stats_clubb_utilities (#1233)
( 997f029 )
noreply at
Added some missing acc parallel statments around some the loops
( c65a1ea )
bmg2 at
Fixed a bug
( 1f2eea8 )
bmg2 at
I have no idea if it's appropriate to include gr in this statment,
( ba693e0 )
bmg2 at

#400 (Mar 5, 2025, 3:03:09 AM)

I changed the variable type within grid function flip from dp to
( d080994 )
bmg2 at
Fixed a compiling issue with CAM-CLUBB.
( 781a8ec )
bmg2 at
Hopefully this helps the cpu vs. gpu tests.
( b7d4154 )
bmg2 at

#399 (Mar 4, 2025, 3:03:10 AM)

Updated calls to some CLUBB subroutines in the wake of recent CLUBB
( 9638720 )
bmg2 at

#398 (Mar 2, 2025, 3:03:07 AM)

Generalized grid (#1230)
( c4ffc94 )
noreply at

#397 (Feb 28, 2025, 3:03:09 AM)

Prevent SAM from bypassing clubb_api_module (#164)
( ed05f23 )
noreply at

#396 (Feb 27, 2025, 3:03:10 AM)

Removed renaming operators `=>` from clubb_api_module (#1232)
( 2b0f47b )
noreply at
Removed renaming operators `=>` from clubb_api_module (#1232)
( 2456131 )
noreply at

#395 (Feb 22, 2025, 3:03:06 AM)

Getting rid of a couple of worthless lines of code. It's possible this
( cdc77c1 )
bmg2 at
Should just delete instead of commenting out.
( fd21380 )
bmg2 at

#394 (Feb 21, 2025, 3:03:07 AM)

Revert clubb api module changes (#1228)
( 2913cd9 )
noreply at
Adapt SAM to removal of module var err_code (#163)
( b01ec96 )
noreply at
Fixed equality check in pdf_closure_module (#1229)
( 20aceea )
noreply at
add dycore grid with conservative remapping scheme
( bdaeacd )
noreply at
add dycore grid with conservative remapping scheme
( 1c98244 )
noreply at
add two new flags (#162)
( 692fea3 )
noreply at

#393 (Feb 20, 2025, 3:03:08 AM)

Remove err code (#1218)
( 7379430 )
noreply at
Remove err code (#1218)
( 8c82ca7 )
noreply at
Renamed check_res to err_code in numerical_check.F90 for consistency (#1227)
( a79e744 )
noreply at

#392 (Feb 19, 2025, 3:03:08 AM)

Set l_wp2_fill_holes_tke to true by default (#1226)
( d74095b )
noreply at
Set l_wp2_fill_holes_tke to true by default (#1226)
( dee28ec )
noreply at

#391 (Feb 8, 2025, 3:03:06 AM)

Swapping the loop order on a few kernels, I found this faster for the nvhpc compiler and it's BFB
( 7cd9143 )
Gunther Huebler at

#390 (Feb 4, 2025, 3:03:10 AM)

Monoflux GPU optimization (#1221)
( 784f0b9 )
noreply at

#389 (Jan 18, 2025, 3:03:05 AM)

Fix flag l_wp2_fill_holes_tke (#161)
( 6550e81 )
noreply at

#388 (Jan 17, 2025, 3:03:08 AM)

Added new hole-filling method which takes TKE from up2 and vp2 (#1217)
( 0c7bd6c )
noreply at
Added new hole-filling method which takes TKE from up2 and vp2 (#1217)
( d6fe9f7 )
noreply at

#387 (Dec 20, 2024, 3:03:05 AM)

Fix binormal correlation clipping (#1199)
( 1d49bab )
noreply at

#386 (Dec 17, 2024, 3:03:08 AM)

Changing a couple loop limits in mono flux limiter.
( 99f0cbc )
bmg2 at

#385 (Dec 14, 2024, 3:03:05 AM)

Recoded a loop within the mono flux limiter so that it's written
( 6696222 )
bmg2 at
Changed some variable names so that it is clear that, while they contain
( c4c8195 )
bmg2 at
Within the mono flux limiter, a thermodynamic-level variable needed to
( 39ebca2 )
bmg2 at
I forgot to add the new variable to the Atlantic Coast Conference
( 016a671 )
bmg2 at

#384 (Dec 7, 2024, 3:03:07 AM)

Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216)
( 52e5a51 )
noreply at
Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216)
( 94b5979 )
noreply at

#383 (Dec 6, 2024, 3:03:08 AM)

Added up2 and vp2 to calculation of wp2_min_array (#1215)
( 4e0d13d )
noreply at

#382 (Dec 5, 2024, 3:03:09 AM)

Reduced the upper bound for wp2_min_array to 1.0 (#1214)
( 23cb94c )
noreply at

#381 (Dec 4, 2024, 3:03:10 AM)

Likely non-bit-changing housekeeping (#1213)
( c5312bc )
noreply at

#380 (Nov 23, 2024, 3:03:06 AM)

Multi col output update (#1211)
( 9ae63da )
noreply at

#379 (Nov 20, 2024, 3:03:09 AM)

Making compatible with latest clubb changes
( 2e436ed )
Gunther Huebler at

#378 (Nov 19, 2024, 3:03:09 AM)

Clubb Driver Semi GPUization Part4 (#1209)
( 855c567 )
noreply at
Clubb Driver Semi GPUization Part4 (#1209)
( 474436d )
noreply at

#377 (Nov 13, 2024, 3:03:07 AM)

Multi Column Mirror Test (#1206)
( 8c6a252 )
noreply at

#376 (Nov 12, 2024, 3:03:08 AM)

As part of generalizing the code to work with both an ascending and
( 0c81e03 )
bmg2 at

#375 (Nov 9, 2024, 3:03:06 AM)

Making a correction to the doubled plus sign from commit a1fcfe8.
( 3da14a5 )
bmg2 at

#374 (Nov 8, 2024, 3:03:07 AM)

Moving Lscale from an acc create statement inside clubb to the acc output statement in clubb_api. This is bug fix that is BIT_CHANGING, but only for silhs cases running on the GPU. Also using this to add BIT_CHANGING:aff1bb12551c5b3a8ab1c4d773ef5c17fb96c53b, as that commit was BC but just missing the message.
( 3e8029a )
Gunther Huebler at
Various Small Tweaks (#1205)
( c30ea55 )
noreply at
Making compatible with latest clubb changes
( cd016ad )
Gunther Huebler at

#373 (Nov 5, 2024, 3:03:09 AM)

Prescribe Forcings GPUization (#1204)
( 2bcbfda )
noreply at

#372 (Oct 25, 2024, 3:03:07 AM)

I am making the loops for the wp3 ta term (using ADG1 PDF) symmetric.
( 9072b68 )
bmg2 at

#371 (Oct 17, 2024, 3:03:06 AM)

Making compatible with latest clubb changes
( 13f2ada )
Gunther Huebler at
Multicol CLUBB (#1193)
( 40c21ae )
noreply at
Multicol CLUBB (#1193)
( 75daf98 )
noreply at
Multicol CLUBB (#1193)
( 80f1ba8 )
noreply at

#370 (Oct 11, 2024, 3:03:07 AM)

Added min_max_smth_mag as a Fortran parameter to constants_clubb.F90 (#1192)
( 7d6f4a0 )
noreply at

#369 (Oct 9, 2024, 3:03:08 AM)

add Lscale intent(out) to advance_clubb_core and advance_clubb_core_api (#1190)
( 5d86ccb )
noreply at
add Lscale to advance_clubb_core_api call. For larson-group/clubb#1166 (#160)
( 3778077 )
noreply at

#368 (Oct 8, 2024, 3:03:09 AM)

Mono Flux Optimizations (#1189)
( 414ffbb )
noreply at

#367 (Oct 5, 2024, 3:03:07 AM)

refactoring to remove compiler warnings (#1187)
( e25a2a1 )
noreply at
refactoring to remove compiler warnings (#1187)
( ade7da0 )
noreply at
remove unused dummy arguments (#159)
( f6d9d57 )
noreply at
I am copying the round-off level changes made to grid weights
( 919336b )
bmg2 at

#366 (Oct 4, 2024, 3:03:07 AM)

Ri zm calc cleanup (#1186)
( 0e78da1 )
noreply at
Monoflux test (#1188)
( b66228d )
noreply at
Fixing bug. This loop has a vertical dependency prevent the use of collapse(2). See https://github.com/larson-group/cam/issues/175\#issuecomment-2261283301
( 86ad303 )
Gunther Huebler at

#365 (Oct 3, 2024, 3:03:08 AM)

New/new_hybrid PDF Stats Removal (#1185)
( 2e1a300 )
noreply at
Copyout Nuke (#1182)
( 83e87d0 )
noreply at

#364 (Sep 27, 2024, 3:03:09 AM)

Remove radf variable from CLUBB call
( 2ef3f37 )
noreply at
Remove radf variable from call to CLUBB
( e2a3ade )
noreply at

#363 (Sep 26, 2024, 3:03:10 AM)

Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack.
( f0871e6 )
Gunther Huebler at
Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack.
( 034fb23 )
Gunther Huebler at

#362 (Sep 25, 2024, 3:03:05 AM)

reduce compiler warnings (#1180)
( c3912e0 )
noreply at
reduce compiler warnings (#1180)
( 004d3f5 )
noreply at

#361 (Sep 21, 2024, 3:03:06 AM)

refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)
( af499c0 )
noreply at
refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)
( d52dc47 )
noreply at

#360 (Sep 20, 2024, 3:03:09 AM)

Removing duplicate definition of edsclr when CLUBB_CAM is defined.
( fd8b678 )
Gunther Huebler at
Ri zm calc6 (#1177)
( afaafca )
noreply at

#359 (Sep 18, 2024, 3:03:07 AM)

change loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173)
( 3ab47e7 )
noreply at
Ri zm calc5 (#1175)
( 77d7293 )
noreply at

#358 (Sep 12, 2024, 3:03:09 AM)

Change variables from a1 and a3 to a1_coef and a3_coef
( c631c7d )
Vince Larson at

#357 (Sep 6, 2024, 3:03:06 AM)

Well, this will probably anger the Grim Reaper, but I have finally
( 4cbb7d1 )
bmg2 at

#356 (Sep 3, 2024, 3:03:09 AM)

Ri zm calc4 (#1168)
( 841d3a1 )
noreply at

#355 (Aug 30, 2024, 3:03:07 AM)

Ri_zm calc (Part 4) - Implementing calc_Ri_zm (#1160)
( 5d6de8e )
noreply at

#354 (Aug 27, 2024, 3:03:09 AM)

Variable name correction in acc data statement.
( 5063ce5 )
Gunther Huebler at
Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine.
( 8553509 )
Gunther Huebler at
Making radf size correct in api and clubb_driver.
( c571fcf )
Gunther Huebler at

#353 (Aug 24, 2024, 3:03:07 AM)

Updated for ghostless version of CLUBB.
( 641a3da )
bmg2 at
Updating to the latest version of CLUBB.
( 5436192 )
bmg2 at

#352 (Aug 23, 2024, 3:03:06 AM)

Clubb ghost exorcism (#1159)
( 90c9747 )
noreply at
Clubb ghost exorcism (#1159)
( 3b4700e )
noreply at

#351 (Aug 17, 2024, 3:03:08 AM)

Nightly clubb plots (#1167)
( 0c35bdb )
noreply at

#350 (Aug 9, 2024, 3:03:09 AM)

Editing the LES setup script to give instructions for UCAR computers.
( 639a292 )
benjamin.andrew.stephens at
Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)
( d135c3d )
noreply at
Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)
( a38c908 )
noreply at
Moving PosInf to clubb_model_settings.F90
( 9153bbb )
Gunther Huebler at

#349 (Aug 8, 2024, 3:03:10 AM)

Fixing mpirun command in the derecho and casper batch scripts.
( e2e09f6 )
benjamin.andrew.stephens at

#348 (Aug 1, 2024, 3:03:09 AM)

Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175
( c304d15 )
Gunther Huebler at
Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.
( 32a74a3 )
Gunther Huebler at
Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.
( 55c6276 )
Gunther Huebler at

#347 (Jul 31, 2024, 3:03:10 AM)

removing cheyenne-related content and adding new content for
( 4016cd1 )
benjamin.andrew.stephens at

#346 (Jul 20, 2024, 3:03:08 AM)

Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp.
( 23f82fd )
bmg2 at
Fixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175
( 9109926 )
Gunther Huebler at

#345 (Jul 19, 2024, 3:03:08 AM)

In my previous commit, I changed the domain of the maxloc commands
( fd2a66a )
bmg2 at
This commit brings the stats output from the all cases run with
( 0df6710 )
bmg2 at
Committing a change that will initialize this set of variables
( 3e891b5 )
bmg2 at

#344 (Jul 18, 2024, 3:03:09 AM)

There were furhter issues found with the k_lh_start code.
( 6bb6d06 )
bmg2 at
Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)
( 8662dc2 )
noreply at

#343 (Jul 17, 2024, 3:03:09 AM)

I am committing changes to stats output for cloud_cover, rcm_in_layer,
( fddad94 )
bmg2 at

#342 (Jul 15, 2024, 3:03:09 AM)

I am updating the SILHS code that calculates k_lh_start to work
( 916b5a9 )
bmg2 at

#341 (Jul 12, 2024, 3:03:09 AM)

This code in adj_low_res_nu was using the ghost point when
( c5fc4e5 )
bmg2 at

#340 (Jul 11, 2024, 3:36:03 PM)

Spack updates (#156)
( 3a5ba59 )
noreply at

#339 (Jul 3, 2024, 3:03:08 AM)

Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)
( 1af8762 )
noreply at

#338 (Jun 21, 2024, 3:03:10 AM)

Adds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3e
( 9620588 )
noreply at

#337 (Jun 20, 2024, 3:03:05 AM)

Ri zm calc (Part 1) - Combine and move call to calc_brunt_vaisala_freq_sqd (#1154)
( d5fb86b )
noreply at
Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155)
( 323b344 )
noreply at

#336 (Jun 5, 2024, 3:03:06 AM)

Making the only change required to make clubb run with openacc in cam.
( 6ab1681 )
Gunther Huebler at

#335 (Jun 4, 2024, 3:03:07 AM)

Making the f in f90 capital for consistency.
( 3d2c815 )
Gunther Huebler at

#334 (May 30, 2024, 3:03:10 AM)

The variable rc_coef_zm needed to be passed in and saved from
( 27bcd97 )
bmg2 at

#333 (May 17, 2024, 3:04:08 AM)

Fixing a bug. Does not change default results.
( c7232ab )
bmg2 at

#332 (May 16, 2024, 3:04:09 AM)

Fixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs.
( 805374a )
Gunther Huebler at

#331 (May 14, 2024, 3:04:07 AM)

gr%zm should be used here instead of gr%zt, since these are
( 0ce993b )
bmg2 at
Thermodynamic-level (zt) values should be used with zt-variable
( 8800078 )
bmg2 at

#330 (May 4, 2024, 3:04:08 AM)

Adding extra exclamation to acc statement to comment it out.
( 243d18e )
Gunther Huebler at

#329 (May 3, 2024, 3:04:09 AM)

I am committing code that effectively ignores the values of certain
( 0e6f459 )
bmg2 at
I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the
( 4b4adc8 )
bmg2 at

#328 (May 2, 2024, 3:04:06 AM)

Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.
( d6ca5b0 )
Gunther Huebler at
Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.
( c2849fa )
Gunther Huebler at
Making compatible with latest clubb changes.
( ecc32fd )
Gunther Huebler at

#327 (May 1, 2024, 3:04:07 AM)

Moved the ghost-point setting of xm(1) = xm(2) to the last line
( 13811b3 )
bmg2 at
Optional arguments are just best sometimes (#1150)
( 6db5d3c )
noreply at

#326 (Apr 27, 2024, 3:04:08 AM)

I'm changing the way ddzt handles the derivative over momentum level 1.
( f3b2d7a )
bmg2 at

#325 (Apr 20, 2024, 3:03:09 AM)

Changing the linear interpolation in the zt2zm function at momentum
( 15e15c3 )
bmg2 at

#324 (Apr 19, 2024, 3:03:05 AM)

Committing some thresholding around positive-definite fields after
( 1a044ef )
bmg2 at

#323 (Apr 14, 2024, 3:03:09 AM)

I am committing a stats change to the ghost point values of zt
( a9608e5 )
bmg2 at

#322 (Apr 12, 2024, 3:03:06 AM)

This commit is being made to keep the stats zt output from the
( 04935f9 )
bmg2 at
I am committing a bug fix to the code that calculates mixed Brunt
( 76244e0 )
bmg2 at

#321 (Apr 11, 2024, 3:03:08 AM)

While it doesn't affect results, I fixed what appears to be an
( 09e6e72 )
bmg2 at
I am updating the loop in subroutine diagnose_xpwp so that it doesn't
( 5694aa6 )
bmg2 at

#320 (Apr 7, 2024, 3:03:09 AM)

The code that advances um and vm when l_predict_upwp_vpwp is turned off
( 68d7df9 )
bmg2 at
It was discovered that the location where the ghost point values
( c73af29 )
bmg2 at
It was discovered that the location where the ghost point values
( 79a203f )
bmg2 at
I accidentally committed a couple things in the previous commit
( 4fae617 )
bmg2 at

#319 (Apr 6, 2024, 3:03:08 AM)

At the ghost point below the surface, which does not matter in
( 9e61ef0 )
bmg2 at

#318 (Apr 2, 2024, 3:03:09 AM)

Fixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false.
( a39122d )
Gunther Huebler at
Making compatible with latest clubb changes.
( e9e1784 )
Gunther Huebler at

#317 (Apr 1, 2024, 3:03:10 AM)

Putting ngrdcol in clubb_params (#1147)
( 215f23f )
noreply at

#314 (Mar 25, 2024, 3:03:07 AM)

Adding sum part to comment
( 2211b4a )
Gunther Huebler at

#313 (Mar 23, 2024, 3:03:07 AM)

Adding comment to explain unusual code choice.
( b3370ac )
Gunther Huebler at

#312 (Mar 19, 2024, 3:03:06 AM)

OpenMP Optimizations (#1146)
( e46bd6a )
noreply at

#311 (Mar 6, 2024, 3:03:07 AM)

Removes comment about Numerical Recipes
( 09d7b40 )
noreply at

#310 (Feb 16, 2024, 3:03:08 AM)

Small acc tweaks (#1144)
( 4e3c5f2 )
noreply at

#309 (Feb 15, 2024, 3:03:08 AM)

Add blank line in order to trigger Jenkins tests for CAM
( 9719713 )
noreply at

#308 (Feb 14, 2024, 3:03:09 AM)

fixing bug, name of wm_zt was left as "wm"
( 7533e5f )
Vince Larson at

#307 (Feb 9, 2024, 3:03:07 AM)

adding equals sign cuz I've had it up to here with this typo!
( aa0b574 )
benjamin.andrew.stephens at

#306 (Feb 8, 2024, 3:03:10 AM)

Fixing a bug where the Lscale used in calculating the damping
( f66e6de )
bmg2 at

#305 (Feb 1, 2024, 3:03:10 AM)

This is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\#issuecomment-1865156979.
( d6d0448 )
Gunther Huebler at
Removing backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\#issuecomment-1910844013
( 89925a4 )
Gunther Huebler at

#304 (Jan 25, 2024, 3:03:06 AM)

Now that the value of wp3 is being set to a boundary value of 0
( 623ed86 )
bmg2 at

#303 (Jan 22, 2024, 3:03:06 AM)

Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.
( a1fd38a )
Gunther Huebler at
Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.
( 4b9838a )
Gunther Huebler at

#302 (Jan 19, 2024, 3:03:17 AM)

Fixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139
( ce785a9 )
Gunther Huebler at
Slight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139
( e27a93a )
Gunther Huebler at
Fixing small GPU stats bug
( 33a2cb6 )
Gunther Huebler at
Changing xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it.
( cf82ace )
Gunther Huebler at

#301 (Jan 12, 2024, 3:03:06 AM)

I am altering the mean advection code in preparation for ghost point
( 830db1e )
bmg2 at

#300 (Jan 10, 2024, 3:03:08 AM)

Setting l_smooth_Heaviside_tau_wpxp to .true. by default
( 9b85ea4 )
Gunther Huebler at

#299 (Jan 9, 2024, 3:03:09 AM)

Adding new argument list variables to openacc copyin statements
( f759e61 )
Gunther Huebler at

#298 (Jan 5, 2024, 3:03:08 AM)

Removing awkward nan check in favor of a default for Ncnp2_on_Ncnm2
( 6d345f4 )
Gunther Huebler at
Fixing bug by changing saturation_equation to match namelist argument, also adding it to namelist.
( 0f0ec05 )
Gunther Huebler at

#297 (Jan 4, 2024, 3:03:07 AM)

Threadpublic (#1133)
( 69a0500 )
noreply at
Threadpublic (#1133)
( 35fc46d )
noreply at
Threadpublic (#1133)
( 14c8636 )
noreply at
Making compatible with latest clubb change.
( b5bc5fa )
Gunther Huebler at

#296 (Dec 22, 2023, 3:03:10 AM)

With wp3 now being set to a fixed-point boundary condition value
( 39e110e )
bmg2 at

#295 (Dec 19, 2023, 3:03:08 AM)

Updating the code to set the bottom of the thermodynamic level grid for
( 20d6130 )
Brian Griffin at
Commit to enforce a fixed-point boundary condition of wp3=0 at
( cebdb21 )
Brian Griffin at

#294 (Dec 13, 2023, 3:03:08 AM)

Added new Brunt-Väisälä frequency plots to pyplotgen's VariableGroupTaus
( 3ba52c6 )
Vince Larson at
Adds commas to fix bug
( 59de6e1 )
noreply at

#293 (Dec 9, 2023, 3:03:06 AM)

Adding boundary conditions for the wp3_term_ta_ADG1_lhs subroutine.
( 22b99ad )
Brian Griffin at
For single loop vectors, removing the "collapse(2)" from the acc statements.
( 961f848 )
Brian Griffin at

#292 (Nov 29, 2023, 3:03:10 AM)

Re-adjusted cap for invrs_tau_wpxp in src/CLUBB_core/mixing_length.F90
( 46dce38 )
Steffen Domke at

#291 (Nov 17, 2023, 3:03:09 AM)

Added non-trapezoidal zm interpolation for cloud_frac (#1127)
( 71caa87 )
noreply at

#290 (Nov 15, 2023, 3:03:10 AM)

Changing order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING.
( 94ceac8 )
Gunther Huebler at
Setting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126
( 80f7ee0 )
Gunther Huebler at
BIT_CHANGING! Updated taus code calculations - CLUBB ticket #1115 (#1125)
( 55b6329 )
noreply at

#289 (Nov 11, 2023, 3:03:09 AM)

Making work with latest clubb changes.
( 1b990bc )
Gunther Huebler at
Changing stat_indices to stats_metadata_type
( c42bb74 )
Gunther Huebler at
New Stats Indices Type (#1118)
( 0eb82e3 )
noreply at
New Stats Indices Type (#1118)
( 1fff41b )
noreply at

#288 (Nov 10, 2023, 3:03:08 AM)

Z displace tunable (#1122)
( 3e0adc1 )
noreply at
Z displace tunable (#1122)
( 9d0394c )
noreply at
Update clubb_sgs.F90
( dbb2eec )
42725900+domkesteffen at

#287 (Nov 9, 2023, 3:03:10 AM)

Updated CLUBB so that adj_low_res_nu (which can be called on its own
( f7c02bb )
bmg2 at
Updated the CLUBB interface for recent changes to CLUBB.
( e522e51 )
bmg2 at
Removing begin_height and end_height as outputs from setup_grid. They
( 6e985b7 )
bmg2 at
Updated for recent changes to CLUBB.
( 933ddce )
bmg2 at

#286 (Nov 1, 2023, 3:03:08 AM)

Latest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119)
( 22872a5 )
noreply at
BIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120)
( 337f2b0 )
noreply at

#285 (Oct 25, 2023, 3:03:08 AM)

Finally removing scratch variables. (#1116)
( 9ca3f47 )
noreply at

#284 (Oct 20, 2023, 3:03:08 AM)

Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106)
( 4ebc702 )
noreply at
BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102
( 395023c )
noreply at
BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108)
( 7afb2bd )
noreply at
Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109)
( 5256cf0 )
noreply at
Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110)
( 0735b8d )
noreply at
BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111)
( 62e5353 )
noreply at
Tunable Richardson number exponent - CLUBB ticket #1102 (#1114)
( 4263da9 )
noreply at
Tunable Richardson number exponent - CLUBB ticket #1102 (#1114)
( e59f773 )
noreply at
Deletes svn id tag, will trigger host-model nightly tests.
( 1a7e15e )
noreply at
Remove svn id tag in order to trigger nightly tests.
( 8be88d0 )
noreply at
Removed 3rd svn id tag in order to trigger nightly tests
( ffdd91c )
noreply at

#283 (Oct 19, 2023, 3:03:10 AM)

Add library calls to allow SAM to compile with new icx intel compiler (#154)
( d95570b )
noreply at

#281 (Oct 18, 2023, 3:03:08 AM)

Raw-copy updating SRC/CLUBB
( 949f506 )
LarsonGroupSysAdmin at
Update clubb_sgs.F90
( 833289f )
42725900+domkesteffen at

#280 (Oct 14, 2023, 3:03:07 AM)

Raw-copy updating SRC/CLUBB
( da7fedc )
root at
Raw-copy updating CLUBB_PARAMETERS
( a94a7af )
root at

#279 (Aug 2, 2023, 3:03:08 AM)

Adding wp_coef and wp_coef_zt to acc data statements.
( 6fa34ce )
Gunther Huebler at
Bv efold bit changing (#1095)
( c0fdc2b )
noreply at

#278 (Jul 26, 2023, 3:03:08 AM)

Bit changing changes (#1104)
( e9ae50f )
noreply at

#277 (Jul 19, 2023, 3:03:10 AM)

Openacc tweaks and cleanup 2 (#1099)
( 1238826 )
noreply at

#276 (Jul 16, 2023, 3:03:07 AM)

Loop to `nz-1` instead of `nz` because upper boundary condition
( 40e8eb8 )
noreply at

#275 (Jul 12, 2023, 3:03:06 AM)

Openacc tweaks and cleanup (#1097)
( 08cf4c7 )
noreply at

#274 (Jul 11, 2023, 3:03:10 AM)

Making compatible with latest clubb changes.
( 4fc849e )
Gunther Huebler at

#273 (Jul 6, 2023, 3:03:08 AM)

Changing "Fnc" to "fnc" for consistency and easy search.
( 42253d9 )
benjamin.andrew.stephens at
Memory usage optimizations (#1091)
( a10584a )
noreply at

#272 (Jun 30, 2023, 3:03:09 AM)

Added bv_efold changes for CLUBB API calls
( 919d552 )
Vince Larson at

#271 (Jun 28, 2023, 3:03:06 AM)

CLUBB ticket #1069: (#1092)
( 20ca5ca )
noreply at
CLUBB ticket #1069: (#1092)
( e35cb4b )
noreply at

#270 (Jun 21, 2023, 3:03:10 AM)

Data movement improvement (#1089)
( 63cc96a )
noreply at

#269 (Jun 14, 2023, 3:03:09 AM)

Moving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088)
( 543091c )
noreply at

#268 (Jun 9, 2023, 3:03:09 AM)

advance_xp2_xpyp with explicitly managed memory (#1086)
( 78ebf2f )
noreply at
advance_windm_edsclrm with explicitly managed memory (#1087)
( 3f3703f )
noreply at

#267 (Jun 7, 2023, 3:03:10 AM)

advance_wp2_wp3 with explicitly managed memory (#1085)
( f5f1d7a )
noreply at

#266 (Jun 3, 2023, 3:03:10 AM)

GPUizing most of advance_clubb_core (#1084)
( c7c530d )
noreply at

#265 (May 31, 2023, 3:03:08 AM)

GPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083)
( 8287750 )
noreply at

#264 (May 14, 2023, 3:03:07 AM)

making changes to trigger autoudpate for test, these commits do nothing
( a7df383 )
cernikt at
making changes to trigger autoudpate for test, these commits do nothing
( c5d2547 )
cernikt at
Here is another commit that changes nothing
( 571c3fa )
cernikt at
Here is another commit that changes nothing
( 10561ea )
cernikt at
change to trigger updates
( 81f82f5 )
cernikt at
change to calc pressure to trigger autoupdate
( c2e0cf0 )
cernikt at

#263 (May 7, 2023, 3:03:10 AM)

Removed Space From clip_explicit
( a9af25e )
cernikt at

#262 (May 4, 2023, 3:03:08 AM)

Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code.
( 3daa325 )
benjamin.andrew.stephens at
Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code.
( e462b21 )
benjamin.andrew.stephens at

#261 (May 3, 2023, 3:03:08 AM)

Calc sfc varnce GPUization (#1081)
( 08475cf )
noreply at

#260 (May 2, 2023, 3:03:08 AM)

Making CLUBB's splatting scheme implicit and smoother (#1075)
( e7a5c0c )
noreply at

#259 (May 1, 2023, 3:03:09 AM)

adding an update that changes nothing and is just a test for the autoupdate script
( fa86672 )
cernikt at

#258 (Apr 24, 2023, 3:03:10 AM)

changing tunable_parameters
( 7b3e07a )
cernikt at
changing tunable_parameters
( 75f7b52 )
cernikt at
changing tunable_parameters
( f0d6b74 )
cernikt at
This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797
( fb9b5e1 )
cernikt at
This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797
( 0dbf4fc )
cernikt at
this is another commit that cahnges nothing that will trigger the gitUpdate scripts
( 8360118 )
cernikt at

#257 (Apr 22, 2023, 3:03:08 AM)

GPUizing Various Small Routines (#1080)
( e12416a )
noreply at

#256 (Apr 20, 2023, 3:03:07 AM)

Lscale GPUization (#1079)
( 40a65a5 )
noreply at
gfortran does not like intent(out) specifiers for functions.
( 7094e36 )
Gunther Huebler at

#255 (Apr 8, 2023, 3:03:08 AM)

Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test.
( c3bec18 )
Gunther Huebler at

#254 (Apr 6, 2023, 2:07:12 PM)

Advance xm wpxp gpuization (#1077)
( 781ef9d )
noreply at
Small tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems.
( 4e5ef28 )
Gunther Huebler at
Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard.
( 9552ab4 )
Gunther Huebler at

#252 (Apr 5, 2023, 3:03:08 AM)

This commit contains code changes to implement modifications on limiters in three places:
( 16fcc9b )
bmg2 at
This commit contains code changes to implement modifications on limiters in three places:
( bbdd1ad )
bmg2 at
Updated for recent changes to CLUBB.
( 0c36e4d )
bmg2 at

#251 (Apr 1, 2023, 3:03:10 AM)

Code changes to implement modificiations on wp3 clippings
( 7435d1c )
bmg2 at
Code changes to implement modificiations on wp3 clippings
( 43c7d40 )
bmg2 at

#250 (Mar 25, 2023, 3:03:07 AM)

Small GPU fixes (#1076)
( adba51a )
noreply at

#249 (Mar 23, 2023, 3:03:08 AM)

Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2.
( f635d22 )
Gunther Huebler at

#248 (Mar 17, 2023, 3:03:07 AM)

Moving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break.
( 6dd01b5 )
Gunther Huebler at

#247 (Mar 15, 2023, 3:03:08 AM)

Pdf closure driver gpuization (#1071)
( 1463a2c )
noreply at

#246 (Mar 14, 2023, 3:03:08 AM)

Making 'a_const' into a CLUBB tunable parameter. (#1072)
( e2ffb73 )
noreply at
Making 'a_const' into a CLUBB tunable parameter. (#1072)
( ea8e240 )
noreply at
Updating for changes to CLUBB. See PR #1072.
( a1e67ef )
benjamin.andrew.stephens at

#245 (Mar 10, 2023, 3:03:06 AM)

Implements Thomas Toniazzo's bug fix for spike removal
( fdf4541 )
noreply at

#244 (Mar 9, 2023, 3:03:07 AM)

Gpu updates (#1070)
( 61ea0db )
noreply at

#243 (Mar 1, 2023, 3:03:09 AM)

Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068)
( 9085177 )
noreply at

#242 (Feb 28, 2023, 3:03:06 AM)

Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly.
( 2cfb412 )
37674341+huebleruwm at

#241 (Feb 18, 2023, 3:03:08 AM)

Adding wp3_on_wp2_cfl_num to CLUBB's output stats.
( 74d62d9 )
bmg2 at

#240 (Feb 9, 2023, 3:03:08 AM)

Porting pdf_closure subroutine with OpenACC (#1059)
( 0273255 )
noreply at

#239 (Feb 8, 2023, 3:03:06 AM)

GPUizing some helping procedures.
( 4ed2ca7 )
37674341+huebleruwm at
Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory.
( 5543d4f )
37674341+huebleruwm at

#238 (Feb 5, 2023, 3:03:11 AM)

Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1
( 6f870bb )
Gunther Huebler at

#237 (Feb 3, 2023, 3:03:09 AM)

Pushing column loop into calculate_thvm
( ef8ea9d )
37674341+huebleruwm at
Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926.
( b0a3a8f )
37674341+huebleruwm at

#236 (Jan 26, 2023, 3:03:10 AM)

GPUizing sat_mixrat_ice_2D.
( e0a9c3d )
37674341+huebleruwm at

#235 (Jan 25, 2023, 3:03:10 AM)

Adding OpenACC data directives for mixing length and adg routines
( 79e3b2b )
Vince Larson at
Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general.
( 466f229 )
Gunther Huebler at

#234 (Jan 20, 2023, 3:03:09 AM)

Breaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051)
( 9f86ec3 )
noreply at
Adding tridiag_lu solver (#1056)
( a5ae081 )
noreply at

#233 (Jan 19, 2023, 3:03:08 AM)

Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)
( 38b63ff )
noreply at

#232 (Jan 13, 2023, 3:03:10 AM)

Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)
( 21426fe )
noreply at

#231 (Jan 12, 2023, 3:03:09 AM)

Pushing column loop into lapack wrap.
( 38f9da3 )
37674341+huebleruwm at

#230 (Dec 10, 2022, 3:03:09 AM)

I can now safely remove all the "ifdef E3SM" statements from CLUBB's
( 936783d )
bmg2 at

#229 (Dec 8, 2022, 3:03:05 AM)

ADG1_pdf_driver subroutine port with OpenACC
( ac76c76 )
37674341+huebleruwm at
Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049
( 512e68b )
37674341+huebleruwm at

#228 (Nov 29, 2022, 3:03:07 AM)

I added "smooth" max clipping for invrs_tau_shear, which is a variable
( 65b7c1d )
bmg2 at

#227 (Nov 25, 2022, 3:03:07 AM)

Replacing $ with & in namelist definition to make consistent.
( 9e641b5 )
Gunther Huebler at

#226 (Nov 24, 2022, 3:03:08 AM)

Making compatible with latest clubb changes.
( ece8104 )
Gunther Huebler at
Adding capability to change matrix solving method via clubb_config_flags.
( 127883c )
37674341+huebleruwm at
Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones.
( d849386 )
37674341+huebleruwm at
Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024.
( 4588198 )
37674341+huebleruwm at
Adding capability to change matrix solving method via clubb_config_flags.
( dfe3de1 )
37674341+huebleruwm at

#225 (Nov 23, 2022, 3:03:05 AM)

Steffens tuner fixer branch (#1041)
( 269513e )
noreply at

#224 (Nov 22, 2022, 3:03:08 AM)

A different way of dealing with monotonic flux limiter spikes (#1046)
( 5baacd7 )
noreply at

#223 (Nov 17, 2022, 3:03:07 AM)

Making interface for matrix solvers.
( 952c923 )
37674341+huebleruwm at
Making tridag tridiag everywhere, making sol soln, and adding intent comments.
( 6d88c22 )
37674341+huebleruwm at

#222 (Nov 9, 2022, 3:03:07 AM)

Minor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043)
( 200706b )
noreply at

#220 (Oct 15, 2022, 3:03:09 AM)

Creating new flags to control monotonic flux limiter (#1039)
( f30bf0d )
noreply at
Creating new flags to control monotonic flux limiter (#1039)
( f508c31 )
noreply at
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/1039.
( 2c455c0 )
59519056+bstephens82 at
I am adding cloudy_updraft_frac and cloudy_downdraft_frac as
( 3bdab2c )
bmg2 at
Updating SAM-CLUBB for the latest changes to the call to
( e8059d3 )
bmg2 at

#219 (Oct 14, 2022, 3:03:06 AM)

Updating monotonic flux limiter code to remove spikes. (#1038)
( 4ba46bf )
noreply at

#218 (Oct 11, 2022, 3:03:07 AM)

Adds commented-out line that prevents the monotonic flux
( 7e89465 )
noreply at

#217 (Oct 10, 2022, 11:17:00 AM)

Namelists need to be closed with a '/', and omitting it will break many tests.
( b3d012f )
Gunther Huebler at
Making save variables in the multicol code threadprivate, this fixes the openmp test. Also changing the way we name and save the multicol output, this allows the parallel run to run with multiple columns. I've reflected the changes in comments where relevant. larson-group/clubb#1033
( d1147f6 )
Gunther Huebler at

#216 (Oct 6, 2022, 3:03:08 AM)

Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.
( b480b13 )
37674341+huebleruwm at
Updating column num input in config flags. larson-group/clubb#1033
( 88c58d4 )
37674341+huebleruwm at
Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.
( fb2e676 )
37674341+huebleruwm at
Adding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033
( 8241377 )
37674341+huebleruwm at

#215 (Sep 10, 2022, 3:03:06 AM)

Adding initial subroutine calc_ice_cloud_frac_component.
( bf79a8d )
37674341+huebleruwm at
Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972
( 60041d7 )
37674341+huebleruwm at
Comment update
( 448112a )
37674341+huebleruwm at
Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines.
( f2673f5 )
37674341+huebleruwm at

#214 (Sep 8, 2022, 3:03:10 AM)

Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972
( 0972044 )
37674341+huebleruwm at
Adding comments.
( a865626 )
37674341+huebleruwm at

#213 (Sep 1, 2022, 3:03:07 AM)

Making compatible with latest clubb change.
( b0a22e3 )
Gunther Huebler at

#212 (Aug 31, 2022, 3:03:09 AM)

Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972.
( ab4282b )
37674341+huebleruwm at
Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972
( b0eeb2e )
37674341+huebleruwm at
Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972
( 0a21a67 )
37674341+huebleruwm at
Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972
( 18677b4 )
37674341+huebleruwm at

#211 (Aug 18, 2022, 3:03:08 AM)

I have optimized the new w_up_in_cloud and w_down_in_cloud code by
( 493cf3a )
bmg2 at

#210 (Aug 17, 2022, 3:03:10 AM)

I altered the w_up_in_cloud and w_down_in_cloud code so that a
( a7de6b0 )
bmg2 at

#209 (Aug 16, 2022, 3:28:58 PM)

adding line to fix mpi configuration in micro drizzle test
( c3df4b3 )
cernikt at

#207 (Aug 16, 2022, 3:03:07 AM)

I changed the w_up_in_cloud code in 2 ways:
( 9434be0 )
bmg2 at
I added stats output for w_down_in_cloud to all_stats.in.
( d0bd6bf )
bmg2 at
Modified for the latest changes to CLUBB.
( 429cdca )
bmg2 at

#205 (Jul 20, 2022, 3:03:06 AM)

Fixing a bug in mono_flux_limiter.F90. (#1026)
( 8d3e454 )
noreply at
Fixing a bug.
( fde756a )
bmg2 at

#204 (Jun 22, 2022, 3:03:07 AM)

Fixing units in stats_zt_module.F90
( ed460b8 )
noreply at

#203 (Jun 18, 2022, 3:03:08 AM)

Making linear_interpolated_azt_2D and linear_interpolated_azm_2D subroutines just to avoid a needless data copy.
( add842c )
37674341+huebleruwm at
Making update_xp2_mc 2D and creating interface for 1D calls.
( dc9e57e )
37674341+huebleruwm at

#202 (Jun 16, 2022, 3:03:08 AM)

Pushing loop into fill_holes.
( 61e346b )
37674341+huebleruwm at
Forgot small change.
( 77f12fc )
37674341+huebleruwm at
Making compatible with latest clubb change.
( 27148d1 )
Gunther Huebler at

#201 (Jun 14, 2022, 3:03:07 AM)

Hardcoding 1 into uses of gr arrays where single column versions of gr is used.
( 2813c59 )
Gunther Huebler at

#200 (Jun 11, 2022, 3:03:09 AM)

Adding column index to gr arrays, hard coding to 1 since sam only uses single column calls.
( a5246bd )
Gunther Huebler at
Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it.
( b283dca )
37674341+huebleruwm at
Pushing column loop into mean advection procedures.
( 64ef912 )
37674341+huebleruwm at
Little loop push
( 76b6a7a )
37674341+huebleruwm at
Moving above/below index of grid weights to last dimension.
( dd7ed27 )
37674341+huebleruwm at

#199 (Jun 10, 2022, 3:03:08 AM)

Makefile came with a few other accidental changes, these have been corrected.
( 32cdf1e )
cernikt at
The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB.
( fece466 )
37674341+huebleruwm at
The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB.
( dcb05d4 )
37674341+huebleruwm at

#198 (Jun 9, 2022, 9:14:29 AM)

added -heap-arrays tag to FFlags on Makefile to fix jenkins testing error
( f705e8f )
cernikt at

#197 (Jun 8, 2022, 3:03:07 AM)

Lots of small loop pushes
( d31bd73 )
37674341+huebleruwm at
Small bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run.
( a64cacf )
37674341+huebleruwm at
Small refactoring to mfl_xm_lhs, just removing need to pass in gr.
( fcfffe1 )
37674341+huebleruwm at
Final loop pushes needed before the grid change.
( 9f6a4e3 )
37674341+huebleruwm at
Replacing use of gr with nz
( 3fbfd62 )
37674341+huebleruwm at
Replacing use of gr with nz
( dfe7ab7 )
37674341+huebleruwm at

#195 (Jun 3, 2022, 3:03:08 AM)

Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value.
( 69aaa53 )
Gunther Huebler at
Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types.
( 02455ed )
Gunther Huebler at

#194 (Jun 2, 2022, 3:03:07 AM)

The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.
( 7bc6f76 )
Gunther Huebler at
Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.
( de73c4e )
Gunther Huebler at
Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).
( 3643c78 )
Gunther Huebler at
Making compatible with latest clubb change.
( b709f9e )
Gunther Huebler at
Making 2D versions of setup_grid and setup_parameters.
( c623b91 )
Gunther Huebler at

#193 (Jun 1, 2022, 3:03:07 AM)

Almost final loop pushes (#1012)
( db5164b )
noreply at
Making compatible with latest clubb change.
( 9701c20 )
Gunther Huebler at
Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014)
( 113beb1 )
noreply at

#192 (May 28, 2022, 3:03:10 AM)

Constructing rcm within SILHS (as rcm_pdf) (#1011)
( e3cdb98 )
noreply at
Constructing rcm within SILHS (as rcm_pdf) (#1011)
( f6c58ab )
noreply at
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4.
( 56d698f )
benjamin.andrew.stephens at

#191 (May 26, 2022, 3:03:06 AM)

removed SAM_CLUBB_standards.tex, SAM_CLUBB.tex, SAM_code_notes.tex, and SAM6.10_guide.doc larson-group/sys_admin#622
( 312b71b )
cernikt at
COrrecting a couple of omissions from when I was renaming the shear_driven case to "neutral".
( 4a5bf18 )
benjamin.andrew.stephens at

#190 (May 14, 2022, 3:03:09 AM)

Added ability to apply smooth min max functions in mixing_length.F90
( 612b58c )
68997723+JanGrn at
Updated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965
( 2d9fdaf )
68997723+JanGrn at
Checked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965
( f050454 )
68997723+JanGrn at
Added test cases to smooth_min_max_tests.F90 and updated documentation.
( d540581 )
68997723+JanGrn at

#189 (May 12, 2022, 3:03:08 AM)

Renaming the new case from SHEAR_DRIVEN to NEUTRAL, and associated mentions in files.
( c8881c3 )
benjamin.andrew.stephens at

#188 (May 6, 2022, 3:03:11 AM)

Renamed smth_range to heaviside_smth_range
( 592d69e )
68997723+JanGrn at
Added tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes.
( c9ccb33 )
68997723+JanGrn at
Implemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0.
( e68c14b )
68997723+JanGrn at
Changed priorities of total normalized variation stats, included error handling in total normalized variation stats.
( 36748fb )
68997723+JanGrn at
Renamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls.
( 28fb91c )
68997723+JanGrn at
Gunthers branch 2 (#1002)
( 8b65b74 )
noreply at
Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail.
( 488bf54 )
68997723+JanGrn at

#187 (May 4, 2022, 3:03:07 AM)

Gunthers branch (#999)
( e2ec97e )
noreply at

#186 (Apr 28, 2022, 3:03:11 AM)

Adding in comments to the Jenkinsfiles to clarify advanced syntax usage and commands with unclear purpose.
( 99eb7c1 )
pbroels at

#185 (Apr 27, 2022, 3:03:10 AM)

Small bug fix.
( 587b19e )
Gunther Huebler at
Another similar small bug fix.
( f6bb40b )
Gunther Huebler at

#184 (Apr 26, 2022, 3:03:09 AM)

Various simple changes to improve performance. All bit-for-bit.
( 027ddbb )
Gunther Huebler at
Pushing loop into calc_stability_correction.
( 9fbc4c9 )
Gunther Huebler at

#183 (Apr 22, 2022, 3:03:08 AM)

Gunthers branch (#996)
( 22792d6 )
noreply at

#182 (Apr 21, 2022, 3:03:08 AM)

Renaming folder and script as well as adding test Jenkinsfile.
( 9054a94 )
pbroels at
Fixing cutt off lines and spelling mistakes.
( 5befef8 )
noreply at

#181 (Apr 15, 2022, 3:03:11 AM)

Interfacing SAM-CLUBB with the latest version of CLUBB.
( 1cc3b81 )
bmg2 at
Updated code so that it actually compiles and runs.
( 00240a4 )
bmg2 at

#180 (Apr 13, 2022, 3:03:10 AM)

I added the code for the l_linearize_pbl_winds flag that was originally
( d18ee7f )
bmg2 at
I added the code for the l_linearize_pbl_winds flag that was originally
( ca343cd )
bmg2 at

#179 (Apr 6, 2022, 3:03:07 AM)

Added idiot-proofing to print a warning message when l_diag_Lscale_from_tau
( ccb8a9a )
bmg2 at
Updating the call to setup_clubb_core_api based on changes found
( aa0517b )
bmg2 at

#178 (Apr 1, 2022, 3:03:07 AM)

Adding samClubbCodeCopy.bash to the jenkins directory for testing Clubb changes. larson-group/sys_admin#768
( 04d5762 )
pbroels at

#177 (Mar 30, 2022, 3:03:10 AM)

Added a3_coef_min to the list of CLUBB's tunable parameter and then
( 36dbc89 )
bmg2 at
Added a3_coef_min to the list of CLUBB's tunable parameter and then
( ddd10ab )
bmg2 at
Updated SAM-CLUBB for CLUBB's new tunable parameter a3_coef_min
( 2e26ab7 )
bmg2 at

#176 (Mar 26, 2022, 3:03:07 AM)

I added l_relax_clipping to CLUBB's config flags.
( 2d1a62e )
bmg2 at
I added l_relax_clipping to CLUBB's config flags.
( 60d82ef )
bmg2 at
I am updating clubb_sgs.F90 for the addition of the l_enable_relaxed_clipping
( 6f784ab )
bmg2 at
Forgot to add l_enable_relaxed_clipping to the namelist readible flags.
( 1685619 )
bmg2 at

#175 (Mar 21, 2022, 3:03:09 AM)

Adding files and updates necessary to run new neutral, shear_driven case in SAM. The case
( dd61130 )
Vince Larson at

#174 (Mar 18, 2022, 3:03:09 AM)

Changed the UTIL Makefile to use ifort rather than sunf95 to allow nightly tests to run.
( 2bdeb60 )
pbroels at

#173 (Mar 17, 2022, 3:03:07 AM)

Removes a blank line in order to trigger merge with E3SM
( 6216b8e )
noreply at
Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972
( e71c3c2 )
37674341+huebleruwm at
Replacing the i loop iterator for scalars with sclr.
( 2422347 )
37674341+huebleruwm at
Pushing loop into advance_xp2_wpxp.
( 0e20498 )
37674341+huebleruwm at
Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats.
( 548c000 )
37674341+huebleruwm at
Moving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call.
( b042151 )
37674341+huebleruwm at
Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way.
( 8c8f3fa )
37674341+huebleruwm at
Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn.
( d2b10e7 )
37674341+huebleruwm at
Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp.
( ecf2720 )
37674341+huebleruwm at

#172 (Mar 15, 2022, 3:03:06 AM)

Increasing HBUF_MAX_LENGTH to 2000 to account for increase in vaiables.
( 978ffa3 )
noreply at
Adds a blank line to trigger git merge with E3SM
( 960a16c )
noreply at

#171 (Mar 11, 2022, 3:03:09 AM)

Removing data copies that we don't need anymore. This still runs correctly on GPUs.
( f078452 )
37674341+huebleruwm at
Making clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible.
( 8abf9d8 )
37674341+huebleruwm at
No more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols.
( 7d2d3a8 )
37674341+huebleruwm at

#170 (Mar 10, 2022, 3:03:09 AM)

Changing microphysics file to UWM from 1MOM for the carson nightly tests.
( f3c3443 )
pbroels at

#169 (Mar 2, 2022, 3:03:09 AM)

Making setup_pdf_parameters accept ngrdcols size arrays of stats and grid types.
( bc3082f )
Gunther Huebler at
Forgot two small changes. larson-group/cam#129
( 8decd62 )
Gunther Huebler at
Removing need for data copies. larson-group/cam#129
( 6a574df )
Gunther Huebler at
Changing column loop index from j to i. larson-group/cam#129
( a21672f )
Gunther Huebler at

#167 (Feb 26, 2022, 3:03:06 AM)

Implementations of smooth min, max and heaviside function. Added G-Unit tests
( fd4c092 )
68997723+JanGrn at

#166 (Feb 25, 2022, 3:03:06 AM)

Fixing small bug that breaks runs with scalars.
( 0984f81 )
Gunther Huebler at

#165 (Feb 24, 2022, 3:03:12 AM)

Gunthers branch (#989)
( ed18e64 )
noreply at

#164 (Feb 22, 2022, 3:03:09 AM)

Refactoring to remove need for global stats scratch variables. (#988)
( 5c71aa3 )
noreply at

#163 (Feb 18, 2022, 3:03:07 AM)

Pushing loop into solve_xm_wpxp_with_single_lhs (#986)
( 76ade90 )
noreply at

#162 (Feb 17, 2022, 3:03:06 AM)

Adding 2D version of zt2zm and zm2zt to clubb_api
( 402036c )
Gunther Huebler at

#161 (Feb 14, 2022, 2:18:21 PM)

Fixing test deleting log file before it can be read.
( c8294bf )
pbroels at

#160 (Feb 14, 2022, 12:12:05 PM)

Adding in Post Step log reporting to ensure we recieve log output even on failed runs.
( 2329041 )
pbroels at
Fixing syntax errror in the jenkins file.
( a1df97e )
pbroels at

#155 (Feb 10, 2022, 3:03:08 AM)

Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing.
( 775ab37 )
Gunther Huebler at

#154 (Feb 5, 2022, 3:03:07 AM)

Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972
( bcda3f8 )
Gunther Huebler at
Pushing column loop into local functions. larson-group/clubb#972
( 0a7b2cd )
Gunther Huebler at

#153 (Feb 4, 2022, 3:03:06 AM)

I added a subroutine that prints that values of all PDF parameters in
( df7da80 )
bmg2 at
Small changes and a loop push. larson-group/clubb#972
( 445f590 )
Gunther Huebler at
Pushing loop into advance_xm_wpxp. larson-group/clubb#972
( c9f575d )
Gunther Huebler at
Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972
( eb106af )
Gunther Huebler at

#152 (Feb 3, 2022, 3:03:08 AM)

Fixed small bug that slipped through because the G_unit tests use nz=1.
( 7f7db11 )
Gunther Huebler at
Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972
( 3c97bd6 )
Gunther Huebler at

#151 (Feb 2, 2022, 3:03:09 AM)

Pushing column index into zm2zt and zt2zm. larson-group/clubb#972
( f1154ae )
Gunther Huebler at
Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972
( 932c80e )
Gunther Huebler at
A variety of small loop pushing. larson-group/clubb#972
( a3665db )
Gunther Huebler at

#150 (Jan 29, 2022, 3:03:22 AM)

Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972
( aa44cb5 )
Gunther Huebler at
Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972
( 5088c10 )
Gunther Huebler at

#149 (Jan 28, 2022, 3:03:23 AM)

I am updating ice_supersat_frac to be an intent(inout) variable for
( 0201571 )
bmg2 at
Updated for recent changes to CLUBB
( 8f11502 )
bmg2 at

#148 (Jan 27, 2022, 3:03:25 AM)

We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972
( 376d0e4 )
Gunther Huebler at

#147 (Jan 26, 2022, 3:03:23 AM)

Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972
( af9c183 )
Gunther Huebler at
Making a commit that officially places the call to the PDF in the "post"
( c0b2297 )
bmg2 at
Making a commit that officially places the call to the PDF in the "post"
( 48bc009 )
bmg2 at
Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972
( f1c5452 )
Gunther Huebler at
Forgot an & symbol.
( 07b04af )
Gunther Huebler at

#146 (Jan 25, 2022, 3:03:23 AM)

Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972
( 2c6b628 )
Gunther Huebler at

#145 (Jan 22, 2022, 3:03:25 AM)

Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972
( d55d2cb )
Gunther Huebler at
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence
( fabb386 )
bmg2 at
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence
( e3d21ef )
bmg2 at

#144 (Jan 21, 2022, 3:03:23 AM)

Breaking up column loop in advance_clubb_core. larson-group/clubb#972
( 0bae8e4 )
Gunther Huebler at

#143 (Jan 20, 2022, 3:03:24 AM)

Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972
( 946ca54 )
Gunther Huebler at
Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972
( 7e6744f )
Gunther Huebler at

#142 (Jan 19, 2022, 3:03:24 AM)

adapted SAM because CLUBB API changed
( 8782d78 )
jan.gruenenwald at
Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972
( 4d506fc )
Gunther Huebler at

#141 (Jan 17, 2022, 3:03:24 AM)

Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm
( d8836de )
noreply at
Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm
( 099d241 )
noreply at

#140 (Jan 15, 2022, 3:03:23 AM)

Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that
( 03f14dd )
bmg2 at
Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that
( 766f9e3 )
bmg2 at

#139 (Jan 14, 2022, 3:03:24 AM)

This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing.
( 7ec140f )
Gunther Huebler at
Changing the value of C_invrs_tau_shear from 0.02 to 0.15.
( 5bf9927 )
bmg2 at
Changing the value of C_invrs_tau_shear from 0.02 to 0.15.
( fd648cb )
bmg2 at
Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true.
( 04279f6 )
Gunther Huebler at

#138 (Jan 13, 2022, 3:03:23 AM)

Making some paramters_silhs variables available from the silhs api
( 3db947c )
Gunther Huebler at
Comment out setting of fatal error
( 65acb9b )
noreply at

#137 (Jan 12, 2022, 3:03:26 AM)

Making api version of setup_grid. larson-group/clubb#972
( f3942b8 )
Gunther Huebler at

#136 (Jan 11, 2022, 3:03:25 AM)

Insert print about overwriting default flags with namelist values
( af2e320 )
noreply at
Insert print about overwriting default parameters with namelist values
( 8f22583 )
noreply at

#135 (Jan 7, 2022, 3:03:23 AM)

Fixing the sam_clubb_silhs_gfortran build by locally making wp3 the
( 867b23c )
bmg2 at

#134 (Dec 30, 2021, 3:03:22 AM)

I am adding more arguments to the argument list for advance_clubb_core
( af8d232 )
bmg2 at
Updating SAM-CLUBB for the latest additions to the call to advance_clubb_core_api
( 7cd8548 )
bmg2 at

#133 (Dec 29, 2021, 3:03:24 AM)

Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core.
( 1e234f5 )
bmg2 at
Now that uprcp and vprcp have been passed through advance_clubb_core,
( aa0da18 )
bmg2 at

#132 (Dec 21, 2021, 3:03:22 AM)

Adding new file to describe in detail SAM's wp2 and wp3 budgets.
( cb4f848 )
benjamin.andrew.stephens at
Fixing an array definition issue that created a problem with the PGI
( c252044 )
benjamin.andrew.stephens at

#131 (Dec 18, 2021, 3:03:22 AM)

Updates relevant to reproducing results for Stephens, Larson, and Mironov 2022.
( db3e00a )
59519056+bstephens82 at
Adding comments to described SAM's pressure variable.
( c1a85d4 )
59519056+bstephens82 at
These changes allow you to call the 4 clubb "advance" subroutines in any
( fe10a39 )
Brian Griffin at
Placing the order variables in a nice, convenient place for testing use.
( da7e393 )
Brian Griffin at
I reordered advance_clubb_core so that the "Advance xp3" (which is a
( 8aae767 )
Brian Griffin at
I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx
( 89ceef8 )
Brian Griffin at
I am indenting the portion of the code where the advance subroutines
( 51776de )
Brian Griffin at
Temporarily commenting out the idiot proofing in order to run some tests ...
( 9ffac7f )
Brian Griffin at
Now official reinstating the idiot-proofing and turning off the
( c587754 )
bmg2 at
I am committing some idiot proofing in regards to the advance
( b778226 )
bmg2 at
Updated for the latest version of CLUBB.
( a39e2f8 )
bmg2 at

#130 (Dec 17, 2021, 3:03:23 AM)

Updating RUNDATA/lst so that the new stats I added in https://github.com/larson-group/sam_clubb/commit/72a614957aa439ae75dbf8be6b4870a7a4c48c4b will be output.
( ce4f8f4 )
benjamin.andrew.stephens at

#129 (Dec 4, 2021, 3:03:23 AM)

Remove clipping from a3_coef.
( fcf74be )
noreply at

#128 (Dec 3, 2021, 3:03:25 AM)

See ticket
( 69a9f21 )
jan.gruenenwald at
added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
( f743922 )
jan.gruenenwald at
See respective messages on the issue 958 on date 10/12/2021
( 24ab4b2 )
jan.gruenenwald at
See respective messages on the issue 958 on date 10/12/2021
( d7b6d7e )
jan.gruenenwald at
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
( 5aad62f )
jan.gruenenwald at
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
( 0918704 )
jan.gruenenwald at
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
( a197aba )
jan.gruenenwald at
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
( 81d326f )
jan.gruenenwald at
fixed a typo in pdf_closure_module.f90, line 1284
( dc3c4b8 )
jan.gruenenwald at
fixed compiler warning regarding w_up_in_cloud
( e157255 )
jan.gruenenwald at

#127 (Dec 1, 2021, 3:03:27 AM)

Adding some additional statistics output relevant to Stephens Larson Mironov 2022 paper.
( 72a6149 )
benjamin.andrew.stephens at

#126 (Nov 16, 2021, 3:03:07 AM)

Passing w_up_in_cloud out of advance_clubb_core
( a3f3633 )
bmg2 at
Updating SAM-CLUBB for the most recent version of CLUBB.
( 692c17a )
bmg2 at

#125 (Nov 12, 2021, 3:03:10 AM)

See ticket
( 3c50292 )
68997723+JanGrn at
added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
( a75256d )
68997723+JanGrn at
See respective messages on the issue 958 on date 10/12/2021
( a83e91f )
68997723+JanGrn at
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
( 0ba99cd )
68997723+JanGrn at
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
( f4f2682 )
68997723+JanGrn at
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
( 2b90c41 )
68997723+JanGrn at
See respective messages on the issue 958 on date 10/12/2021
( 3c42c31 )
68997723+JanGrn at
fixed a typo in pdf_closure_module.f90, line 1284
( e235fe7 )
68997723+JanGrn at
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
( b18ed8a )
68997723+JanGrn at

#124 (Nov 7, 2021, 3:03:08 AM)

Updating for changes to CLUBB code.
( 25d3434 )
bmg2 at

#123 (Nov 6, 2021, 3:03:07 AM)

I have turned the nu_vert_res_dep family of variables into a derived
( 0c99971 )
bmg2 at

#122 (Nov 2, 2021, 3:03:06 AM)

Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.
( 43b0e9b )
benjamin.andrew.stephens at
This commit fixes SAM to work with the new version of CLUBB.
( a5d1059 )
bmg2 at

#121 (Oct 31, 2021, 3:03:08 AM)

I forgot to add this necessary subroutine call to the clubb API.
( 3cc2a48 )
bmg2 at

#120 (Oct 30, 2021, 3:03:07 AM)

I have passed clubb_params down into advance_xm_wpxp_module.F90.
( ecf50b7 )
bmg2 at
I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.
( b33af07 )
bmg2 at
I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90
( 724a970 )
bmg2 at
Passing down more of CLUBB's tunable parameters.
( 9ac836f )
bmg2 at
I accidentally removed an important comment in the previous commit.
( 7b95057 )
bmg2 at
Passing down more CLUBB tunable parameters.
( 835d3d3 )
bmg2 at
More passing down CLUBB parameters ... whoop-de-doo
( b65e4cf )
bmg2 at
Passing down more tunable parameters and removing references to
( 351cc9a )
bmg2 at
Handling the abomination that is lmin.
( 40e8749 )
bmg2 at
Passing tunable parameters into the new tau code.
( c8cadb5 )
bmg2 at
Passed down more parameters. Results are bit-for-bit.
( e6aa931 )
bmg2 at
Passing through more clubb parameters. Bit-for-bit
( d07f2f6 )
bmg2 at
Passing down CLUBB's tunable parameters into the setup_pdf_parameters and
( 704eedf )
bmg2 at
Passing down CLUBB's tunable parameters into the remainder of the
( 62d3645 )
bmg2 at
I passed down the forgotten thlp2_rad_coef tunable parameter.
( 4031524 )
bmg2 at
I am passing down the forgotten parameter, altitude threshold, in
( 24592ec )
bmg2 at
I am committing the final stage of the "pass-down params" project.
( 48d34a4 )
bmg2 at
I am committing the final stage of the "pass-down params" project.
( a59d8a9 )
bmg2 at
Adding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.
( e21f336 )
59519056+bstephens82 at
Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.
( 575d6fe )
59519056+bstephens82 at
Adding comments for clarity.
( b1a5dc6 )
59519056+bstephens82 at

#119 (Oct 28, 2021, 3:03:08 AM)

Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/968.
( 0fac716 )
benjamin.andrew.stephens at
Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.
( bda6b42 )
59519056+bstephens82 at
Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.
( 12ac897 )
59519056+bstephens82 at
Updates as requested to the l_use_tke_in_K_dfsn code:
( fecf90b )
59519056+bstephens82 at
Updates as requested to the l_use_tke_in_K_dfsn code:
( 6cc56f4 )
59519056+bstephens82 at

#118 (Oct 27, 2021, 3:03:07 AM)

Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.
( 59c9045 )
benjamin.andrew.stephens at

#117 (Oct 23, 2021, 3:03:11 AM)

These updates incorporate some of Shixuan Zhang's changes, including:
( 2ee6d2a )
benjamin.andrew.stephens at

#116 (Oct 15, 2021, 3:03:09 AM)

Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.
( db75841 )
benjamin.andrew.stephens at

#115 (Oct 13, 2021, 3:03:11 AM)

Removing line to trigger the nightly tests for all repos.
( 3c883d2 )
noreply at

#113 (Oct 5, 2021, 3:03:08 AM)

Add a blank line to trigger nightly tests.
( 860a184 )
noreply at

#111 (Oct 2, 2021, 3:03:07 AM)

Updates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example.
( 0f9530e )
59519056+bstephens82 at
Changing the name of dummy_1d variables for clarity.
( 4a3fe32 )
59519056+bstephens82 at

#110 (Sep 25, 2021, 3:03:06 AM)

I am fixing a bug that was introduced in 6b0348e, where the logical
( 3f42742 )
bmg2 at

#109 (Sep 17, 2021, 3:03:07 AM)

Adding a more direct calculation of W2PRESDFSN, which differs slightly from W2PRES near the surface but is very similar aloft.
( 529f3c7 )
benjamin.andrew.stephens at

#108 (Sep 16, 2021, 3:03:06 AM)

Add space to trigger nightly tests. For larson-group/sys_admin#755.
( 579ae7b )
noreply at

#107 (Sep 14, 2021, 3:03:08 AM)

Remove space to trigger autoupdate. larson-group/sys_admin#755
( a7a1f10 )
noreply at

#106 (Sep 12, 2021, 3:03:10 AM)

Adding space to trigger autoupdate. larson-group/sys_admin#755
( ed5bed1 )
Gunther Huebler at

#105 (Sep 11, 2021, 3:03:08 AM)

Adding space to trigger autoupdate. larson-group/sys_admin#755
( 3b29c31 )
Gunther Huebler at

#104 (Sep 4, 2021, 3:03:05 AM)

Removing a couple of unused parameters from use statement.
( b248205 )
noreply at
Pushing k loop down through clip_variance_level.
( ed78e34 )
rhodesk at
Udpates to make it possible for us to keep certain parameters equal to each other during tuning.
( 747e30b )
59519056+bstephens82 at
Further tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included.
( c787271 )
59519056+bstephens82 at
Updating some comments related to the tuner updates.
( 6884811 )
59519056+bstephens82 at

#103 (Sep 3, 2021, 3:03:09 AM)

Pushing k loop down through clip_variance_level.
( dafbfbd )
rhodesk at
Udpates to make it possible for us to keep certain parameters equal to each other during tuning.
( 72b5c72 )
59519056+bstephens82 at
Further tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included.
( 9414601 )
59519056+bstephens82 at
Updating some comments related to the tuner updates.
( 5c73ee7 )
59519056+bstephens82 at

#102 (Sep 2, 2021, 3:03:07 AM)

Removing a couple of unused parameters from use statement.
( 1016f8e )
noreply at

#101 (Sep 1, 2021, 3:03:10 AM)

Eliminating l_single_C2_Skw flag.
( d6771b9 )
72510114+RhodesKeegan at
Eliminating l_single_C2_Skw flag.
( ccf7091 )
72510114+RhodesKeegan at
Eliminating l_single_C2_Skw flag.
( fff3319 )
72510114+RhodesKeegan at
Eliminating l_include_ice and sat_ice_ratio.
( 6a1e090 )
rhodesk at
Eliminating l_update_pressure flag.
( 5a57001 )
rhodesk at
Eliminating l_update_pressure flag.
( 4288227 )
rhodesk at
Eliminating l_upwind_wpxp_ta flag.
( d0851f0 )
rhodesk at
Eliminating l_upwind_wpxp_ta flag.
( 90c963c )
rhodesk at
Updating the surface clipping coefficient...
( 0578ed5 )
noreply at
Adding in l_vary_convect_depth as requested.
( 64c2cdc )
72510114+RhodesKeegan at
Adding in l_vary_convect_depth as requested.
( 79fac5d )
72510114+RhodesKeegan at

#100 (Aug 31, 2021, 3:03:08 AM)

Adding in l_vary_convect_depth as requested.
( cebe3ad )
72510114+RhodesKeegan at
Adding in l_vary_convect_depth as requested.
( 616d74e )
72510114+RhodesKeegan at
Reflecting changes made to clubb in host models
( 91fe7ec )
72510114+RhodesKeegan at
Adding clubb directory for testing
( c467eb4 )
72510114+RhodesKeegan at
Removing clubb and silhs directory for tonight's merge
( d95f964 )
72510114+RhodesKeegan at
Add new common module that exposes internal methods
( 45537d7 )
isenfireldc at
Add module-level statements for subroutines
( 049da38 )
isenfireldc at
Fix issues that came from moving subroutines to the common module
( 25a4153 )
isenfireldc at
Add input file and dimensions to readiopdata_common
( 1a1daf9 )
isenfireldc at
Add surface variables to readiopdata_common
( eb9682b )
isenfireldc at
Add time/pressure variables to readiopdata_common
( 93688a0 )
isenfireldc at
Add soundings to readiopdata_common
( e34335b )
isenfireldc at
Add remaining surface and sounding code to readiopdata_common
( fa8c6ca )
isenfireldc at
Remove unnecessary arguments from readiopdata_common
( c18a0fe )
isenfireldc at
Rename readiopdata_common to readiopdata_core
( 130223f )
isenfireldc at
Rename readiopdata_core subroutine to readiopdata_core_snd
( 44c0408 )
isenfireldc at
Create readiopdata_core_dims subroutine
( 2848d31 )
isenfireldc at
Create readiopdata_core_sfc subroutine
( 6b96e86 )
isenfireldc at
Clean up readiopdata_core
( 4af5c52 )
isenfireldc at
Create readiopdata_core_frc subroutine
( 91e8e70 )
isenfireldc at
Fix readiopdata_core for use as a shared module in clubb
( 1d78296 )
isenfireldc at
Change comparison operators to match clubb standard
( 55c77b1 )
isenfireldc at
Change file name in print statements to readiopdata_core_module.F90
( d5fd643 )
isenfireldc at
Move readiopdata_core_module.F90 to a subdirectory for use with git-subtree
( d94bfc2 )
isenfireldc at
Add SRC/READIOPDATA_CORE to build paths
( 0de6a42 )
isenfireldc at

#99 (Aug 26, 2021, 3:03:09 AM)

Updating the surface clipping coefficient...
( 8a6392b )
noreply at

#98 (Aug 21, 2021, 3:03:08 AM)

Eliminating l_upwind_wpxp_ta flag.
( 83e7c97 )
rhodesk at
Eliminating l_upwind_wpxp_ta flag.
( 61659cb )
rhodesk at
Reflecting changes made to clubb in host models
( 2e8254c )
rhodesk at

#97 (Aug 19, 2021, 3:03:09 AM)

For clubb:ticket:770, the Oracle compiler was throwing a floating point exception here. wpxp2 and xp2 were being fed in as Nans.
( 78cfb14 )
weberjk at
The new file calc_roots.F90 contains functions that solve for the roots of a
( 23b83be )
bmg2 at
I tweaked the precipitation fraction code so that the weighted ith PDF component
( cea3875 )
bmg2 at
For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j.
( 8dd9969 )
raut at
I updated pdf_closure_module.F90 by integrating changes I made in the
( 0f34241 )
bmg2 at
For cam:ticket:36:
( ab2e384 )
raut at
For cam:ticket:36#comment:132, I removed `gr` from the use statement in `setup_grid_heights_api`.
( e917230 )
raut at
For clubb:ticket:773, I fixed some unsoundness in our code regarding kinds, specifically in `parameters_model.F90` and `endian.F90`.
( 0f06bb5 )
raut at
For cam:ticket:41, the change in clubb:r7921 should be applied to the trunk as well.
( e6bacda )
raut at
For clubb:ticket:775:
( e48ac26 )
raut at
For clubb:ticket:775:
( de48143 )
raut at
Misc. code cleanup
( dd1186e )
raut at
I am updating default CLUBB to use the same hydrometeor PDF parameters that are
( 6915abd )
bmg2 at
For cam:ticket:50:
( b52d3ab )
raut at
For cam:ticket:52:
( c4366bf )
raut at
For cam:ticket:52, I added some parameter indices to the API.
( afd3529 )
raut at
I forgot a parameter!
( cd647d1 )
raut at
For clubb:ticket:753:
( 61f401a )
raut at
For clubb:ticket:782:
( 5de08c8 )
raut at
I forgot a flag.
( 1e6552e )
raut at
For clubb:ticket:782:
( 5d19029 )
raut at
For cam:ticket:55, I added some parameters to CLUBB's API.
( 68c3829 )
raut at
For cam:ticket:55:
( 26ad189 )
raut at
I cleaned up some warnings from the Mac compiler. (build:14977)
( 56f87be )
raut at
For clubb:ticket:785, I renamed `initvars` to `clubb_params_nl`.
( 8025ab1 )
raut at
For clubb:ticket:785:
( 1889cc7 )
raut at
For clubb:ticket:779:
( c44ad43 )
raut at
For clubb:ticket:786:
( cac8541 )
raut at
For clubb:ticket:786:
( 2be0615 )
raut at
For clubb:ticket:782, I added all CLUBB's parameter indices to the API.
( 76ffc1e )
raut at
helpful note
( 3a6793e )
raut at
more helpful note
( 4d2d0eb )
raut at
most helpful note
( ee33663 )
raut at
For cam:ticket:56:
( 72529d6 )
raut at
While working on cam:ticket:59, I noticed that `tau_N2_zm` is computed twice. I removed one computation.
( c6500cf )
raut at
Dat crazy indentation, though...
( cb412fb )
raut at
For cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`.
( fb63f26 )
raut at
For cam:ticket:59:
( 42e5348 )
raut at
For cam:ticket:59:
( 1851678 )
raut at
For cam:ticket:59:
( 29d9ce8 )
raut at
For cam:ticket:59, I added a new output for Richardson number.
( c32284c )
raut at
For cam:ticket:59:
( 9d61a8b )
raut at
Per cam:ticket:59#comment:21, using `T_in_K_zm` in "the formula".
( 9e60795 )
raut at
For cam:ticket:59.
( 7682bbc )
raut at
For cam:ticket:59 I renamed `Richardson_no` to `Richardson_num`.
( f82218e )
raut at
For cam:ticket:59, I added kludgy statistical output for `brunt_vaisala_freq_sqd`.
( c74225d )
raut at
For cam:ticket:59:
( 6047390 )
raut at
For cam:ticket:59:
( 197f846 )
raut at
For cam:ticket:59:
( 193b235 )
raut at
For cam:ticket:59.
( c7d55c7 )
raut at
For cam:ticket:59:
( 0522c9f )
raut at
Apparently, I didn't have to jump through the hoop of declaring a separate profile to use in the `max` statement.
( 4f0028b )
raut at
For cam:ticket:59:
( 33af548 )
raut at
For cam:ticket:59:
( d685dd9 )
raut at
For cam:ticket:59:
( c48216a )
raut at
For clubb:ticket:782:
( 0f756d7 )
raut at
For cam:ticket:59:
( fabce99 )
raut at
For cam:ticket:59:
( d47e922 )
raut at
For cam:ticket:59:
( cc7ff03 )
raut at
For cam:ticket:59:
( 2107752 )
raut at
For clubb:ticket:782:
( 97c8425 )
raut at
For cam:ticket:59:
( 491b13f )
raut at
For cam:ticket:59, I fixed bugs in the `l_use_C7_Richardson=T` vertical averaging code:
( 78b1837 )
raut at
I adjusted a comment.
( 922aa61 )
raut at
For clubb:ticket:788:
( 0fceb83 )
raut at
For cam:ticket:59:
( 65085f8 )
raut at
For clubb:ticket:788:
( f6f7a5a )
raut at
For clubb:ticket:788:
( 11fdf54 )
raut at
For clubb:ticket:788:
( 206f048 )
raut at
For clubb:ticket:788:
( 4e1247d )
raut at
For clubb:ticket:788:
( 43a1c71 )
raut at
Renamed C7 to Cx in appropriate places.
( a962121 )
raut at
For cam:ticket:59:
( 71e67a0 )
raut at
For cam:ticket:59:
( d49aa6e )
raut at
I made it a default to use 0 instead of cloud_frac_min in the B.V. frequency calculation.
( b5cf8ff )
raut at
For cam:ticket:67:
( be1c310 )
raut at
For cam:ticket:67:
( 9241d31 )
raut at
Code improvements.
( a65a271 )
raut at
Vince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more!
( 1241c93 )
raut at
For cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used.
( bb6808a )
raut at
Fixed a comment.
( aa8a3d9 )
raut at
For clubb:ticket:788:
( 4457ce7 )
raut at
For clubb:ticket:792:
( 942ecdc )
raut at
For clubb:ticket:792:
( 842f477 )
raut at
For clubb:ticket:792, I added more initializations for uninitialized variables.
( 5097bb3 )
raut at
When l_avg_Lscale is turned on but the plume-centered calculation is disabled,
( afa64ca )
bmg2 at
For clubb:ticket:792:
( eb0be92 )
raut at
For clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output.
( 3137b73 )
raut at
I renamed RH_postPDF to rel_humidity.
( f61e904 )
raut at
For clubb:ticket:792. rsat actually should be recomputed here before output, because it will change if `l_rcm_supersat_adj = T`.
( 2b9c0ab )
raut at
For clubb:ticket:792. I am reusing the `rel_humidity` variable for output, for no particular reason.
( b5e36c5 )
raut at
For clubb:ticket:792!!!! I set `l_rcm_supersat_adj = T` by default, in both source code and namelist.
( f0c489f )
raut at
As requested, I am adding a warning message (debug level 1) when spurious supersaturation is removed.
( 85557a0 )
raut at
Comment.
( 5a524a2 )
raut at
For clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010).
( 421941e )
raut at
I removed a spurious print statement.
( 3cd7861 )
raut at
For cam:ticket:73:
( e20752a )
raut at
I am beginning to generalize the sponge damping code so that it can be applied to
( 644805c )
bmg2 at
I have added all the coding infrastructure to perform sponge damping (and record
( 0c83cee )
bmg2 at
( bde6e65 )
Vince Larson at
clubb:ticket:796
( b6c2764 )
roessle9 at
I added some parameter value checking in subroutine setup_parameters.
( a3ffb88 )
bmg2 at
I finally have a standalone version of the new subroutine, generate_pdf_params,
( c0f7107 )
bmg2 at
Some code within advance_clubb_core that is found within CAM_CLUBB preprocessor
( f5ee4a5 )
bmg2 at
The perturbation Lscale code requires rtm_frz, thlm_frz, and pdf_params_frz to
( 33092de )
bmg2 at
I added a missing intent(out) statement.
( 617c5f2 )
bmg2 at
I have interfaced the new subroutine containing all of the PDF closure-related
( 7cc27e3 )
bmg2 at
I got rid of some variables that were brought into advance_clubb_core by use statements
( 1cece97 )
bmg2 at
I cleaned up more compiler warnings for unused variables. The warnings came from g95.
( 74d4f7f )
bmg2 at
I have added a second call to subroutine generate_pdf_params. This one occurs
( 65844ec )
bmg2 at
I moved the setting of qclvar and thlprcp_out to after the second call to
( 652b8ad )
bmg2 at
I have declared the l_use_ice_latent option and the l_call_pdf_closure_twice
( f2b2a33 )
bmg2 at
I added a local cslculation of sigma_sqd_w near the top of subroutine
( 66ed30c )
bmg2 at
I am changing the inputs and outputs of subroutine advance_clubb_core so that
( 5d635a9 )
bmg2 at
I added code so that stats that are internal to subroutine generate_pdf_params
( 090114c )
bmg2 at
I have updated subroutine advance_clubb_core so that pdf_params_zm is now passed
( 582c3bf )
bmg2 at
Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical
( cdaeea6 )
savva at
Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical
( 2d21676 )
savva at
( 729952d )
Vince Larson at
( 129209e )
Vince Larson at
I added a new subroutine, init_pdf_params, to pdf_parameter_module.F90.
( f613fb4 )
bmg2 at
I renamed the subroutine pack_pdf_params found in setup_clubb_pdf_params.F90
( baeba52 )
bmg2 at
I am now using the new subroutine init_pdf_params to initialize the
( 92d5747 )
bmg2 at
I removed the CAM_CLUBB preprocessor directives from pack_pdf_params_api,
( 149845b )
bmg2 at
clubb:ticket:800 -- Changed fatal errors statements to debug level 0.
( 0e6ad4f )
savva at
I updated CLUBB stats so that wpthvp, wp2thvp, rtpthvp, and thlpthvp
( 8907a37 )
bmg2 at
I have added the coding infrastructure to output additional statistics
( cf19b99 )
bmg2 at
This is a bug fix for the Sun compiler. The variables pdf_params_zm and
( 7975090 )
bmg2 at
I am updating the hydrometeor PDF code to set mu_hm_1 and
( da1e6e9 )
bmg2 at
Running the Bitten tests.
( 2849e9e )
bmg2 at
I added some comments so that CLUBB-SILHS would be consistent with
( eb63cc3 )
Vince Larson at
As a first step, I changed all instances of rrtthl to corr_rt_thl_1.
( 1bdf138 )
bmg2 at
I have added corr_rt_thl_2 to the code to go along with corr_rt_thl_2.
( 2f64d7d )
bmg2 at
I have added some code to add corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2
( 9e72781 )
bmg2 at
I added new statistics to the CLUBB _zt output files, specifically corr_w_rt_1, corr_w_rt_2,
( 5c7d2be )
bmg2 at
I am updating the equations for wp2rtp, wp2thlp, wprtp2, and wpthlp2 to include
( d854c55 )
bmg2 at
I am adding a special function to calculate the within-component correlation of
( 65c599a )
bmg2 at
I added variables corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2
( ec0c789 )
bmg2 at
I am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to type
( c5840a1 )
bmg2 at
Now that the PDF component correlations of w and chi, as well as w and eta,
( a1089ad )
bmg2 at
I am adding statistical output for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1,
( ab1a600 )
bmg2 at
I am changing the name of the flag l_fix_chi_eta_correlations to
( 8ca31cc )
bmg2 at
The two component normal (double Gaussian) PDF used by CLUBB will now be
( 5779b39 )
bmg2 at
I moved the checking of the options for the PDF call placement to subroutine
( 8edb870 )
bmg2 at
I am altering setup PDF parameters to be able to read in the values of
( 26a1ae6 )
bmg2 at
I am adding the new file new_pdf.F90 to the CLUBB core directory. So far, it
( c07ab5c )
bmg2 at
I am adding a large amount of code to the new PDF. I have filled in the driver
( ce75f5c )
bmg2 at
I am adding code to the new PDF that calculates the minimum and maximum
( 85308f4 )
bmg2 at
I added a new iiPDF entry for the new PDF, and I neatened some of the current
( 11d7a9d )
bmg2 at
I added an option to call the new PDF from subroutine pdf_closure.
( 7ae91ab )
bmg2 at
I had to add checking for the new PDF so someone does not try to run it
( df45d68 )
bmg2 at
I made a couple changes to (1) initialize two variables that aren't used by the
( 250072e )
bmg2 at
I added a conditional to the subroutine that sets the responder parameters.
( 122a9c1 )
bmg2 at
I have added the beginnings of a new unit test for the PDF parameters.
( 7760911 )
bmg2 at
I have updated the PDF parameter unit test to make a call to the full PDF (for
( 82a034d )
bmg2 at
I have added a feature to the PDF parameter unit tests which allows the user
( 8e60988 )
bmg2 at
In the setter variable description and subprograms, I made a name change from
( df8d597 )
bmg2 at
I have updated the method of calculating the setter variable so that mu_x_1
( f191465 )
bmg2 at
I added primarily some more documentation and notes.
( 2dcf994 )
bmg2 at
I added some more comments documenting the code.
( e81daa5 )
bmg2 at
I got rid of some of the expressions that a script might try to flag as
( 46632b4 )
bmg2 at
I added much more documentation about the responder variable. Specifically,
( b7a9edf )
bmg2 at
I am adding the new file, original_pdf.F90, as the new home for the ADG1, ADG2,
( 96dd4a8 )
bmg2 at
I have now switched the PDF closure code over to calling the code that had been
( e454327 )
bmg2 at
I updated the documentation in the code comments for the setter method and
( 1a2c52b )
bmg2 at
I added a comment.
( 1b93dd6 )
bmg2 at
I added a new function, calc_comp_corrs_binormal, to pdf_utilities.F90. This
( 9638dae )
bmg2 at
I added some more descriptive comments and a new function that calculates the
( 512906b )
bmg2 at
I updated the code so that coef_sigma_x_1_sqd and coef_sigma_x_2_sqd are passed
( 376bd21 )
bmg2 at
I fixed a mistake.
( ec87600 )
bmg2 at
I have added code to call the new function that calculates wp4 implicitly from
( 060c2e9 )
bmg2 at
I moved the calculations of wp2xp (wp2rtp and wp2thlp), wp4, and wpxp2 (wprtp2
( a5753cc )
bmg2 at
I added another function to the new PDF. This function helps to calculate
( 5384d9d )
bmg2 at
I added a special case for the wpxp2 implicit code.
( a104dde )
bmg2 at
Back in clubb:r8409, the PDF component correlations of w and rt and w and
( b20f067 )
bmg2 at
I added a subroutine that calculates the implicit and explicit portions of the
( 315aa47 )
bmg2 at
I renamed original_pdf.F90 as adg1_adg2_3d_luhar_pdf.F90.
( 682b816 )
bmg2 at
I added statistical output for F_w, F_rt, F_thl, min_F_w, max_F_w, min_F_rt,
( 16b439a )
bmg2 at
I split the new PDF into two files. I added a new file that currently houses
( 14cd918 )
bmg2 at
I clipped temperature within the Goff-Gratch functions for saturation over liquid and ice.
( 7fa72c4 )
Vince Larson at
I initialized some output variables in order to prevent a runtime error.
( 2056a9a )
bmg2 at
I made a sub-driver level subroutine for the calculations necessary for a
( d6bbb28 )
bmg2 at
I added code to allow the variable (of w, rt, or theta-l) with the greatest
( 09094b5 )
bmg2 at
I added calls to the functions and subroutines that calculate the implicit and
( b8df0b0 )
bmg2 at
I changed coef_wp2xp_explicit (coef_wp2rtp_explicit and coef_wp2thlp_explicit)
( 7963938 )
bmg2 at
I am adding a new file for the new trivariate skewness-dependent analaytic
( 58cd28c )
bmg2 at
I fixed a bug in the new Trivariate skewness-dependent analytic double Gaussian
( 628c9cc )
bmg2 at
In order for the TSDADG PDF to work correctly, when Skx * sgn( <w'x'> ) >= 0,
( 514ef09 )
bmg2 at
In order to clarify coding in CLUBB, I am moving a block of code that is
( 1be6007 )
bmg2 at
I am fixing a bug where rtp2 and thlp2 (and sclrp2) were not preserved when
( 284816e )
bmg2 at
I updated the TSDADG PDF by adding the responding variable description, the
( f254c05 )
bmg2 at
When ADG1 or ADG2 are not used, we have to set alpha_rt, alpha_thl, and
( 8c5f2d2 )
bmg2 at
I am calling the new TSDADG PDF from subroutine pdf_closure.
( 82e4512 )
bmg2 at
Clarity changes to the new TSDADG PDF.
( 9e30e75 )
bmg2 at
I added some references to the CLUBB-SILHS tech doc.
( 4f8df90 )
Vince Larson at
I fixed a bug in the calculation of PDF component variances in the new TSDADG
( d619f5f )
bmg2 at
I added more references to the CLUBB-SILHS tech doc.
( 19feff7 )
Vince Larson at
I have set the tunable parameters F_x and zeta_x to skewness functions for the
( 98527ca )
bmg2 at
I needed to increase the limit of nvarmax_zt so that LBA (and other
( ccc0b6d )
bmg2 at
I changed the URL references to the CLUBB-SILHS overview document.
( 1043095 )
Vince Larson at
Changed variable and subroutine names, see ticket 810 and 811
( 5d4fb30 )
hoc_browser at
I have added the Lewellen and Yoh (1993) PDF to CLUBB for testing and comparison
( 87941ba )
bmg2 at
Fixed line length exceding 100 characters warnings
( 1551446 )
Gunther Huebler at
Changed the arrangement of variables in the subroutine compute_mixing_length as well as calls to it clubb:ticket:815
( cf54191 )
Gunther Huebler at
Fixed lines exceeding 100 characters warnings clubb:ticket:815
( 1261bdb )
Gunther Huebler at
I added an option to incorporate the buoyancy term into CLUBB's eddy diffusivity for momentum.
( b9d643f )
Vince Larson at
I added c_K10 as a tuning parameter in front of the new momentum eddy diffusivity.
( 7dbb977 )
Vince Larson at
Removed unused parameters to clear warnings clubb:ticket:803
( 852d264 )
Gunther Huebler at
I multiplied the eddy diffusivity for momentum by a skewness-dependent factor
( a63e4c8 )
Vince Larson at
I changed the way that F_rt and F_thl are set in the new PDF. They are now set
( c5944a9 )
bmg2 at
I changed the flag setting on the new PDF so that it always uses w as the setter
( 085d3f5 )
bmg2 at
Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803
( ae9ae3e )
Gunther Huebler at
Improved binary search algorithm clubb:ticket:818
( 0f8a60b )
Gunther Huebler at
Added warning messages to function binary_search clubb:ticket:818
( 1cbe16f )
Gunther Huebler at
Removed unused variables causing warnings clubb:ticket:803
( 6f7801d )
Gunther Huebler at
I updated the call to the new PDF so that Skrt and Skthl are intent INOUT
( 32948e0 )
bmg2 at
Removed many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803
( 1911423 )
Gunther Huebler at
I am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90. This
( d56edc5 )
bmg2 at
I finished adding the units to the variable descriptions in
( fd7aa20 )
bmg2 at
The calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>,
( 5c5313f )
bmg2 at
I added the tunable or adjustable parameters for the new PDF to CLUBB's list
( e6afdac )
bmg2 at
Fixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803
( 3a41920 )
Gunther Huebler at
I am committing a line of code that limits the adjusted correlation of rt and
( 4200fe3 )
bmg2 at
I implemented a new method to handle cumulus momentum fluxes.
( 8dc0d79 )
Vince Larson at
Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804
( 3290e0e )
Gunther Huebler at
Removed file anl_erf.F90, it is no longer used
( 67891bd )
Gunther Huebler at
I am altering the solution to the wp3 predictive equation to calculate the
( 496afc4 )
bmg2 at
I fixed the problem with the wp3 budgets as a result of r8584. The budgets in
( 58ac531 )
bmg2 at
I altered the names of the turbulent advection functions that are closed by
( 0908a71 )
bmg2 at
I added a couple comments about how the discretization of the turbulent
( 54acce1 )
bmg2 at
I added the function that sets up the implicit calculation of the wp3 turbulent
( 6bbed2e )
bmg2 at
I added a function that calculates the explicit form of the wp3 turbulent
( 60e6f11 )
bmg2 at
I am adding a function to calculate the turbulent advection of wpxp explicitly.
( 821c06b )
bmg2 at
I am adding a function to calculate the turbulent advection of xp2 and xpyp
( 5234cd6 )
bmg2 at
I interfaced the wp3 explicit turbulent advection code with CLUBB. It is
( 1864200 )
bmg2 at
I am interfacing the wpxp explicit turbulent advection option with the rest of
( 48ea03a )
bmg2 at
I fixed a small bug with the explicit turbulent advection option for wpxp.
( 7d58047 )
bmg2 at
I am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code.
( ecda710 )
bmg2 at
I added the l_explicit_turbulent_adv_* family of flags to the new PDF, for some
( 4c69f1b )
bmg2 at
I am packing up the implicit coefficients and explicit terms calculated by the
( 199de59 )
bmg2 at
Made epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804
( a891045 )
Gunther Huebler at
I made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90.
( 6d734fc )
bmg2 at
I have completed interfacing the implicit form of the wp3 turbulent advection
( 1624553 )
bmg2 at
When the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advection
( 42c5e04 )
bmg2 at
I cleaned up the Skx_module and added an additional function,
( f645a7f )
bmg2 at
I fixed a bug in the calculation of scalar skewness. It was being set to 0,
( 0f015a9 )
bmg2 at
I moved the location of the LG 2005 ansatz to calculate xp3 because it would be
( bce8224 )
bmg2 at
I reverted clubb:r8611 because (1) having the code in the other location
( a85dc94 )
bmg2 at
I have added a new function, term_ta_new_pdf_lhs, to
( 5eb6a87 )
bmg2 at
I have linked the implicit turbulent advection code for rtp2 and thlp2 to the
( 1a64aba )
bmg2 at
I have added a new file that has two options for handling the xp3 term for
( 32ef7b3 )
bmg2 at
I have interface the new xp3 code to the rest of CLUBB. It can be turned on
( 36fc76e )
bmg2 at
I added a driver level subroutine for the new advance xp3 code. This will make
( 817b7d5 )
bmg2 at
I added budget stats for rtp3 and thlp3 to CLUBB.
( 7d820dc )
bmg2 at
I am adding code that allows the turbulent advection of wpxp to be treated
( ddc181f )
bmg2 at
Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code.
( 3f1dc0d )
Gunther Huebler at
Various small comment removals and returned some functionality to api interface clubb:ticket:800
( 771489f )
Gunther Huebler at
A variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800
( e825a91 )
Gunther Huebler at
This is the first part of a two-part change. I am updating plotgen plots so
( cd544c5 )
bmg2 at
In part 2 of this two part commit, I have added rc_coef to the list of
( 59d3974 )
bmg2 at
Various debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800
( a53242d )
Gunther Huebler at
Check negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800
( 534a0c7 )
Gunther Huebler at
I'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800
( 5c4a849 )
Gunther Huebler at
Changed calls to parameterization check to work with the new check negative implementation clubb:ticket:800
( 5594fe9 )
Gunther Huebler at
( 0838560 )
Gunther Huebler at
Removed rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800
( 710b86b )
Gunther Huebler at
Changed error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800
( 7819819 )
Gunther Huebler at
Fixed unused variable warnings related to error code changes
( 13831ab )
Gunther Huebler at
I am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to account
( df6f429 )
bmg2 at
Added error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to keep track of error messages is multithreaded scenarios clubb:ticket:800
( 8da2c41 )
Gunther Huebler at
In r8659, I accidentally overwrote some code. This commit restores the prior
( 0ac6d77 )
bmg2 at
Sigh
( 7d6bf06 )
bmg2 at
Added clubb debug level checks to error checking statements clubb:ticket:800
( 0a5bae7 )
Gunther Huebler at
Changed many stop commands to return commands and added more err_code checks clubb:ticket:800
( 8dd2efb )
Gunther Huebler at
Reverted api changes that broke SAM and WRF
( 9312238 )
Gunther Huebler at
I am adding the semi-implicit formulation of wprtpthlp, which is the turbulent
( 9fb1e0e )
bmg2 at
I am adding output statistics for the implicit and semi-implicit coefficients
( 3edb1f2 )
bmg2 at
I corrected the units on a couple of implicit coefficients.
( a934169 )
bmg2 at
I fixed a bug.
( ce15cc8 )
bmg2 at
Removed failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800
( 82b8e1b )
Gunther Huebler at
Removed reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800
( 5a5297f )
Gunther Huebler at
I am fixing a bug with the CLUBB tuner. Variables that were allocated at the
( 9ceaa37 )
bmg2 at
Completed the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800
( 7a2fad4 )
Gunther Huebler at
Made all debug levels produce the same output, see clubb:ticket:823
( e5907f8 )
Gunther Huebler at
I am moving type variable implicit_coefs_terms from new_pdf_main.F90 to
( ac9622b )
bmg2 at
Modified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802
( 7d18837 )
Gunther Huebler at
Added checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802
( eabe48e )
Gunther Huebler at
This should fix the thlm out of bounds error on clubb:ticket:828
( f8e787b )
Gunther Huebler at
I changed the name of type variable new_pdf_implct_coefs_terms to
( 59dd7cd )
bmg2 at
Changed T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828
( 3a824d4 )
Gunther Huebler at
I added a flag option to clip the (large, negative) effects of microphysics on
( b1accae )
bmg2 at
I added a flag option to calculate the minimum threshold for xp2 (rtp2 and
( 313ad51 )
bmg2 at
I added a special max magnitude correlation for fluxes wprtp and wpthlp. This
( f41025c )
bmg2 at
Made better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more information
( 75959a4 )
Gunther Huebler at
This commit sets C8b=0.02, changes the non-linear damping on wp3
( e3d58ba )
Vince Larson at
Added a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829
( 10a9678 )
Gunther Huebler at
I am adding a general purpose function for the turbulent advection of CLUBB's
( cee383b )
bmg2 at
I added/changed a couple comments for the rhs portion of the generalized
( 8229ba9 )
bmg2 at
The turbulent advection file that handles turbulent advection for predictive
( 203d790 )
bmg2 at
I added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, that
( 74d40e3 )
bmg2 at
Whoops, I forgot to make wpxpyp_zm and xpyp intent (in).
( 94d2e20 )
bmg2 at
Added functionality to make the hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830
( 67dcf4b )
Gunther Huebler at
I am updating the code that advances predictive variances and covariances in
( 6fcdeee )
bmg2 at
Renamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830
( fb8065e )
Gunther Huebler at
I am updating the code that advances predictive scalar fluxes (<w'x'>) in
( 0249e99 )
bmg2 at
As a first step toward having code that can clip mean values of hydrometeor
( 84eb73b )
bmg2 at
init_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562
( 0a518f3 )
Gunther Huebler at
I have now interfaced the subroutine that I made out of the code that clips
( 8900041 )
bmg2 at
I added new code that clips the overall correlation of w and rt or the overall
( e31aae7 )
bmg2 at
I added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which are
( d4e0f94 )
bmg2 at
Made clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800
( 9216aa9 )
Gunther Huebler at
Reverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800
( dd55be4 )
Gunther Huebler at
Fixed nightly tests
( 095ae79 )
Gunther Huebler at
I have added code to allow C2 to be adjusted by multiplying by the greater of
( 5a2c7c7 )
bmg2 at
I moved the location of the declaration and setting of new model flags to
( 6c918c0 )
bmg2 at
Improved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834
( 41c69ab )
Gunther Huebler at
Fixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834
( 47cc48c )
Gunther Huebler at
Actually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834
( 1d391de )
Gunther Huebler at
Optimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834
( 2186e36 )
Gunther Huebler at
Reverted stats_clubb_utilities, accidental commit
( 2527ef4 )
Gunther Huebler at
This should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837
( 6e57d21 )
Gunther Huebler at
( 29ebdfc )
Vince Larson at
Impoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834
( 934865a )
Gunther Huebler at
This commit implements the effects of splatting on wp3.
( 39398fe )
Vince Larson at
I am making the first step toward committing code that allows for the option
( 16b36fb )
bmg2 at
I added code to allow the option of predicting upwp and vpwp by using the
( c7c4a87 )
bmg2 at
I took the liberty of upgrading CLUBB's PDF closure and related code to a vector
( 5f3450b )
bmg2 at
I updated the monotonic flux limiter to account for vector variables u and v.
( d06277e )
bmg2 at
I am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output.
( 1712c2e )
bmg2 at
In r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic flux
( e332712 )
bmg2 at
I am turning on the l_predict_upwp_vpwp code!
( 667c9ea )
bmg2 at
Improved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834
( 7bdde8b )
Gunther Huebler at
Improved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834
( a62d534 )
Gunther Huebler at
Changed the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834
( a6b375b )
Gunther Huebler at
Added grid_class to the dependency lists of the pdf files that were changed in commit 8773
( 94a340e )
Gunther Huebler at
Accidental commit, undoing 8783
( 57ccb47 )
Gunther Huebler at
I am changing the default setting of flags l_min_wp2_from_corr_wx and
( b6174f6 )
Brian Griffin at
Modified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834
( 26007da )
Gunther Huebler at
Removed print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases.
( 25761f9 )
Gunther Huebler at
Changed the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834
( 72b36ee )
Gunther Huebler at
I am adding source code for the introduction of budgets for predictive upwp
( 8d6e915 )
Brian Griffin at
Improved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834
( 8b6e616 )
Gunther Huebler at
Improved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834
( 85d980e )
Gunther Huebler at
Modified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834
( 2b2c951 )
Gunther Huebler at
Copied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834
( 4a6c294 )
Gunther Huebler at
Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834
( a711776 )
Gunther Huebler at
Improved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834
( 647260c )
Gunther Huebler at
I made the surface splatting terms conservative. That is, I subtracted from wp2_sfc
( 8a9a8dd )
Vince Larson at
I added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2.
( 523ca23 )
Vince Larson at
This commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero). Hence it is BIT_CHANGING.
( 64a6fbc )
Vince Larson at
Added functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834
( f61d995 )
Gunther Huebler at
Update advance_clubb_core_module.F90
( e6ef3b8 )
noreply at
I clipped sigma_sqd_w to prevent interpolated values of it
( f28cdc7 )
Vince Larson at
I added a new option to diagnose the dissipation time scale, tau, first
( fe9d815 )
Vince Larson at
I found a new way to diagnose upthvp. Instead of using a bound on correlations, it relies
( 6fbc9a4 )
Vince Larson at
introducing error into clubb core for testing larson-group/sys_admin#533
( 970984d )
mcfadd34 at
reverting error that was introduced larson-group/sys_admin#533
( ab452ae )
mcfadd34 at
I am briefly changing some of the flag and parameter settings in CLUBB
( fd04a51 )
bmg2 at
Revert "I am briefly changing some of the flag and parameter settings in CLUBB"
( 9a2cfb9 )
bmg2 at
I added a couple of comments reminding users to change the conditions in
( 8b4636b )
bmg2 at
Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""
( 37c8f1b )
bmg2 at
Revert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"""
( 66cc940 )
bmg2 at
I committed a subroutine, diagnose_upxp, that calculates
( 4c7b25b )
Vince Larson at
Improved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834
( 6edf0ad )
Gunther Huebler at
I am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a large
( ec1fb66 )
bmg2 at
I am updating the code within setup_clubb_pdf_parameters.F90 in order to take
( b19476b )
bmg2 at
To diagnose uprcp using CLUBB's PDF machinery,
( ae02afd )
Vince Larson at
Continuing with diagnosis of uprcp using CLUBB's PDF,
( 6873c26 )
Vince Larson at
More code to diagnose uprcp using CLUBB's PDF.
( d2812cc )
Vince Larson at
Correction for the last uprcp-related commit:
( 7e26b5b )
Vince Larson at
I am correcting the code so that the Nightly Uninitialized Variables Test
( 2e9ec34 )
bmg2 at
I am continuing to pull parts of setup_pdf_parameters outside of a large "do"
( 559b1e4 )
bmg2 at
I am pulling statistical output subroutine pdf_param_ln_hm_stats outside
( 495d473 )
bmg2 at
Changing the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope.
( ab433cf )
Gunther Huebler at
commenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566
( 460f055 )
mcfadd34 at
uncommenting threadprivate larson-group/sys_admin#566
( 5659e7c )
mcfadd34 at
I have changed the structure of setup_pdf_parameters so that the subroutine that
( 2820b91 )
bmg2 at
Returned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING.
( 79a4333 )
Gunther Huebler at
I am turning on the new calculation of uprcp that uses CLUBB's PDF.
( 49feb76 )
Vince Larson at
I modified the code in setup_clubb_pdf_params.F90 to use only one call to
( 4cea0a0 )
bmg2 at
I am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch to
( 26acd1f )
bmg2 at
I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch
( cd39923 )
bmg2 at
I temporarily set l_clip_extreme_chi_sample_pts back to false in the
( f8c3b05 )
bmg2 at
Revert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the"
( d0fdb43 )
bmg2 at
I improved the error messages when LU decomp. fails within
( 719a2e3 )
bmg2 at
Improved error message prints in advance_xm_wpxp.
( 9bdd16b )
bmg2 at
I added improved LHS and RHS print statements when a LU decomp. error occurs
( 9ebad48 )
bmg2 at
I added params_list to the list of variables that are accessible through
( e89d13d )
bmg2 at
I am making the first step for updating the code that calculates sigma_sqd_w.
( 2dcd21b )
bmg2 at
I added a log-law height dependence to the code that diagnoses
( 20c0f6a )
Vince Larson at
I added fill_holes_hydromet_api to clubb_api_module.F90.
( 5c39d24 )
bmg2 at
I added a new python script, check_for_missing_threadprivate.py,
( 1dd81ac )
Vince Larson at
Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834
( 72bfbae )
Gunther Huebler at
Fixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834
( 2f805be )
Gunther Huebler at
Added temp test file
( fae81b1 )
noreply at
Remove test file
( cb11bc2 )
noreply at
Adding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical.
( 300de16 )
Gunther Huebler at
Optimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases.
( 25e23c9 )
Gunther Huebler at
ticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequency
( 7fd2d93 )
guozhun at
Modifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855
( 1f2facc )
Gunther Huebler at
Replacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855
( 7036e85 )
Gunther Huebler at
Making procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855
( a674448 )
Gunther Huebler at
Missed one
( 3d127ce )
Gunther Huebler at
I have added a new file, calc_pressure.F90, which contains code for initializing
( e6b21ea )
bmg2 at
I updated CLUBB so that pressure is updated after mean fields have been
( 402505b )
bmg2 at
Removing gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855
( db9f324 )
Gunther Huebler at
Forgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855
( 427b92e )
Gunther Huebler at
issue #842
( 2d45481 )
guozhun at
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively.
( db0b8dc )
guozhun at
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively.
( ea09dc1 )
guozhun at
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842)
( feaaa15 )
guozhun at
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842)
( e3ffdf5 )
guozhun at
Update tunable_parameters.in
( bec3a82 )
noreply at
Update advance_clubb_core_module.F90
( 5e7fdb3 )
noreply at
We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly)
( b3c3dc6 )
guozhun at
We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly)
( 3ac916c )
guozhun at
Efficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855
( 185f2fe )
Gunther Huebler at
This should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855
( 4e11b0a )
Gunther Huebler at
An additional damping is added to the invrs_tau term in the C8 equation. ticket #842
( 11e94b2 )
guozhun at
An additional damping is added to the invrs_tau term in the C8 equation. ticket #842
( 5bd7c2c )
guozhun at
Adding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations.
( 26d56dd )
Gunther Huebler at
We use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8.
( 2b59527 )
guozhun at
Changing ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855
( 80905eb )
Gunther Huebler at
Pulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855
( 7d01c36 )
Gunther Huebler at
Renaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855
( a60a7de )
Gunther Huebler at
Efficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855.
( 915547c )
Gunther Huebler at
Modifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855
( 1f578b3 )
Gunther Huebler at
Refactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855
( 4504e3b )
Gunther Huebler at
Update advance_clubb_core_module.F90
( eb88df1 )
noreply at
Update advance_clubb_core_module.F90
( 62f72f1 )
noreply at
I switched on direct diagnosis of tau rather than Lscale.
( ae9c733 )
Vince Larson at
I switched on direct diagnosis of tau rather than Lscale.
( c034fc2 )
Vince Larson at
I updated the pressure initialization for cases that use sounding that is given
( a3f5913 )
bmg2 at
I changed the function calculate_thvm from a pre-defined vector of size nz to
( e573fab )
bmg2 at
I updated the calculation of thvm in advance_clubb_core to use the
( 51a86a3 )
bmg2 at
Adding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler.
( 9a3e6d3 )
Gunther Huebler at
Adding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855
( 9735280 )
Gunther Huebler at
Changing where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626
( 8e208d5 )
Gunther Huebler at
I am committing a test where I changed subroutine ADG1_w_closure
( 41a78a1 )
bmg2 at
Changing determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862
( 02066c0 )
Gunther Huebler at
Finally fixing line length error in pdf_closure
( e7c7ca6 )
Gunther Huebler at
Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861
( 3cdd4d6 )
Gunther Huebler at
Adding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862
( feb1fe6 )
Gunther Huebler at
This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc.
( f165ae4 )
guozhun at
This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc.
( d7186c7 )
guozhun at
Update advance_helper_module.F90
( ac21054 )
noreply at
Update advance_clubb_core_module.F90
( 61228ff )
noreply at
Update advance_helper_module.F90
( 9c87ac3 )
noreply at
Adding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626
( c11c788 )
Gunther Huebler at
I am adding a file for the new hybrid PDF, which combines the w equation set
( 74b9225 )
bmg2 at
I updated the function to calculate the implicit coefficient for the wp4 term,
( 6ae78a6 )
bmg2 at
I made some changes to new_hybrid_pdf.F90 so that it would compile in its
( 1cfb745 )
bmg2 at
I edited that subroutine that calculates the implicit coefficient and explicit
( 9636e0e )
bmg2 at
I updated the subroutine that calculates the implicit coefficient and explicit
( 91d3418 )
bmg2 at
Replaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves.
( 9b7da5a )
nselke at
I am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the new
( b535997 )
bmg2 at
I worked more the functions for the new hybrid PDF.
( d03f5db )
bmg2 at
Refactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855
( 3b3fa0f )
Gunther Huebler at
I changed all the PDF utility functions in pdf_utilities.F90 to elemental
( 7b4d6d7 )
bmg2 at
I forgot a "then" to go with an "elseif".
( fc7dd9a )
bmg2 at
Adding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855
( 09460e5 )
Gunther Huebler at
Adding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855
( a6bf3fc )
Gunther Huebler at
Refactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855
( 4e3165f )
Gunther Huebler at
I am continuing to build the driver subroutine for the new hybrid PDF.
( 9e77b1a )
bmg2 at
I am continuing to work on the driver file for the new hybrid PDF.
( 2636b91 )
bmg2 at
I have completed the main parts of the driver subroutine for the new hybrid PDF.
( 19bfff3 )
bmg2 at
The code for the new hybrid PDF now compiles.
( 363763a )
bmg2 at
I added an entry for the new hybrid PDF.
( bd601ca )
bmg2 at
I have added the new hybrid PDF to the G unit tests.
( 79f0955 )
bmg2 at
Mathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0.
( b222dcb )
bmg2 at
I added code to interface the call to the new hybrid PDF with pdf_closure
( 8cfdc21 )
bmg2 at
I interfaced the implicit coefficients and explicit terms used in the turbulent
( 2b6ff6c )
bmg2 at
I fixed a small error. The code compiles again now.
( e2bbcec )
bmg2 at
Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group
( e19fe08 )
pbroels at
I have added code that allows CLUBB to run interactively using the new hybrid
( a1c0be9 )
bmg2 at
I am updating the subroutine that calculates PDF component means and standard
( c5a755b )
bmg2 at
I placed proper thresholding on interpolated up2 and interpolated vp2
( 6486d46 )
bmg2 at
I added a limiter to keep the maximum magnitude of the correlations of
( f66969b )
bmg2 at
I upgraded Nc_Ncn_eqns.F90 to use elemental functions.
( d647c75 )
bmg2 at
The new hybrid PDF also uses this bit of code that sets the correlation
( 0bbfad6 )
bmg2 at
I made modifications to the new hybrid PDF so that that calculation of F_w
( 4b68266 )
bmg2 at
I added the ability to handle scalars interactively to the new hybrid PDF.
( b401721 )
bmg2 at
I found a couple of spots in the new hybrid PDF where I needed to add
( a775bd9 )
bmg2 at
I added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90.
( 916c1f7 )
bmg2 at
I am setting the zeta variance ratio to 1 (symmetric design) by
( 6b6b492 )
bmg2 at
The variable type implicit_coefs_terms needs to be made public
( afb54c3 )
bmg2 at
I changed the value of the coefficient in the F_w equation to 0.45
( e62b062 )
bmg2 at
I am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_core
( 7a9ffd8 )
bmg2 at
I have started the process of adding the coding infrastructure
( e9b0850 )
bmg2 at
I have completed the addition of the ability to use different up2
( f48d9ab )
bmg2 at
I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856
( 6fa1cf9 )
nselke at
I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856
( c691ceb )
nselke at
I made the l_calc_w_corr code (turned off by default) run again by
( a3fa5e1 )
bmg2 at
I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute.
( f5c0f86 )
nselke at
I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute.
( ff07bc5 )
nselke at
I have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac',
( 780fe29 )
nselke at
I continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm',
( 37be56d )
nselke at
I continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm',
( 9b71f7d )
nselke at
I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp',
( 63bfc28 )
nselke at
Finished altering argument lists. This commit covers the final seven flags, which are in different namelists.
( 3d7dd80 )
nselke at
I introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type.
( e27846e )
nselke at
I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856
( 976026d )
nselke at
I fed pdf_params_frz into subroutine advance_clubb_core
( cd4f009 )
Vince Larson at
Adding error code to arguement list of non-api routines where it was included in the api version.
( b7b3438 )
Gunther Huebler at
Moving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal.
( 3108bbd )
Gunther Huebler at
Added use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public.
( 0cfd69b )
Steffen Domke at
I have fixed the warnings for lines exceeding 100 characters.
( 8105cfd )
nselke at
Passing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity.
( 234b88f )
Gunther Huebler at
Trivial update to test if cams autoupdate works
( 11b3792 )
noreply at
Revert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch"
( 6b20ec2 )
bmg2 at
I placed E3SM preprocessor commands around E3SM-specific code in
( 1b3ce36 )
bmg2 at
Restoring assertion check for the vertical correlation calculation. larson-group/clubb#869
( 167b63c )
Gunther Huebler at
Changing the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869
( c927e76 )
Gunther Huebler at
I added E3SM's clubb_ parameters that can be read in from the
( e6f8822 )
bmg2 at
I added the remainder the clubb_ terms that were added previously to
( 01cd689 )
bmg2 at
Changing error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869
( 27ac5d4 )
Gunther Huebler at
Small updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869
( b6025d4 )
Gunther Huebler at
Redoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869
( 5f9e2a7 )
Gunther Huebler at
Adding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869
( 1f9d2ab )
Gunther Huebler at
Simple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869
( c58014f )
Gunther Huebler at
Small performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869
( 8e5716b )
Gunther Huebler at
Removing lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869
( faf11c1 )
Gunther Huebler at
Update latin_hypercube_driver_module.F90
( 5b5269b )
noreply at
Update parameters_tunable.F90
( dfe257f )
noreply at
GPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869
( b6b18c6 )
Gunther Huebler at
Making some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869
( b7c5204 )
Gunther Huebler at
I changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874
( bde68d8 )
nselke at
I added the new l_update_pressure configurable flag to clubb_config_flags.
( f4cbd72 )
bmg2 at
I added the new l_update_pressure configurable flag to clubb_config_flags.
( 081305f )
bmg2 at
I added some code I used in the special input fields branch to make
( a32a63a )
bmg2 at
An improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875]
( 9225a01 )
guozhun at
I revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874.
( 0dca127 )
nselke at
I got rid of the "allocatable", "allocate", and "deallocate" statements
( 64b5afb )
bmg2 at
I placed an ifndef CLUBB_CAM preprocessor flag around the code in
( 279fab7 )
bmg2 at
I reduced the minimum possible value of lmin from 4.0 to 1.0.
( 25b8367 )
noreply at
I made a print/write statement debug level 3
( 5a748b3 )
noreply at
I made a second print/write statement debug level 3
( a050d6a )
noreply at
I fix a print/write statement debug level3. For #755 and #800
( f1873bd )
guozhun at
I am replacing the "use" statements that referenced
( f581583 )
bmg2 at
I "brought back the stats" by passing the stats from advance_clubb_core
( 0f67628 )
bmg2 at
Removing the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref)
( dd9ad18 )
bmg2 at
Results were changed yesterday for some cases because thlprcp was
( 7a05c93 )
bmg2 at
I have resolved all the issues surrounding recent CLUBB commits that
( 6f41957 )
bmg2 at
I removed code that stops a run if the output time step is less than a minute.
( 3603a68 )
noreply at
I removed references to variables_prognostic_module and
( 5249de8 )
bmg2 at
Fixed a boo-boo.
( 3b091ac )
bmg2 at
I set `l_diag_Lscale_from_tau = .true.` in source code
( 36fe4d3 )
noreply at
I removed references to variable_diagnostic_module for various Kessler
( 29ad608 )
bmg2 at
I removed the reference to use variables_diagnostic_module for Kh_zm
( 06e6739 )
bmg2 at
Removed a reference to variables_diagnostic_module for Kh_zm in
( 6f2f593 )
bmg2 at
I am able to remove references to variables_prognostic_module and
( efec25c )
bmg2 at
I removed the l_use_ice_latent flag from the code, and along with it
( 752666b )
bmg2 at
I removed the l_use_ice_latent flag from the code, and along with it
( f36fde9 )
bmg2 at
I have completed the project of removing variables_prognostic_module
( e81b40a )
bmg2 at
I added some missing threadprivate statements
( 1bdd34c )
noreply at
I have taken the code from wp2_term_ta_all and placed it in the subroutine
( e2826f0 )
bmg2 at
I am updating wp3_term_ta_new_pdf_lhs to use the optimized code from
( e0d3027 )
bmg2 at
This commit is BIT_CHANGING. It makes the parameter values in parameters_tunable.F90 agree with those in tunable_parameters.in
( df5510e )
benjamin.andrew.stephens at
I am making the change of using tau_wp2_zm to damp up2 and vp2,
( 249ed5d )
bmg2 at
I have added the integer flags iiPDF_type and ipdf_call_placement
( a59618b )
bmg2 at
I have added the integer flags iiPDF_type and ipdf_call_placement
( d4e1cc7 )
bmg2 at
I am going to make primary PDF type options and primary PDF call
( 935b507 )
bmg2 at
I added E3SM customizations to CLUBB's master branch. This is meant
( 03a057f )
bmg2 at
I am updating the clubb_ list of namelist parameters used in E3SM
( 1d96100 )
bmg2 at
Typo
( 3a2dcd5 )
bmg2 at
Fixed more typos
( ca809e2 )
bmg2 at
I am changing the new hybrid PDF's calculation of F_w to use
( 29c5dd3 )
bmg2 at
I updated the xp3 calculation for PDF types other than ADG1.
( bfde3dd )
bmg2 at
This xp3_coef_ parameters produce new hybrid PDF results similar to the old
( b9a3fc1 )
bmg2 at
I added the 2 new parameters in the simple xp3 equation (for PDF
( 17b61c2 )
bmg2 at
I added the 2 new parameters in the simple xp3 equation (for PDF
( c0b9007 )
bmg2 at
I have combined the wp3_term_ta_ADG1_lhs and wp3_term_ta_ADG1_lhs_all
( ec26fc2 )
bmg2 at
I added the partially upwinded implementation of the wp3 turbulent advection
( 306b627 )
bmg2 at
Removed unused module imports
( 8d6af15 )
isenfireldc at
Removed unused module imports
( 95246a5 )
isenfireldc at
Removed a comma that I missed while removing unused imports (#878)
( 5aff710 )
isenfireldc at
I am adding l_partial_upwind_wp3 to the list of clubb_config_flags.
( 5714762 )
bmg2 at
I am adding l_partial_upwind_wp3 to the list of clubb_config_flags.
( bca7290 )
bmg2 at
Deprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129
( 6e6f394 )
Gunther Huebler at
Adding clubb case files that were missed from last commit larson-group/cam#129
( 53e11d4 )
Gunther Huebler at
I started the process of paring 2 subprograms back down to 1 in
( 0564f82 )
bmg2 at
I pared two more sets of equivalent subprograms down to 1 (each).
( 8b33c3e )
bmg2 at
Paring down 2 equivalent subprograms to 1 again.
( 034ddd2 )
bmg2 at
I condensed two more sets of doubled subprograms down to 1 (each)
( 9a48a69 )
bmg2 at
Reduced two more sets of "doubled" subprograms down.
( f621109 )
bmg2 at
Updating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129
( c1b8935 )
Gunther Huebler at
Adding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129
( 456aaaa )
Gunther Huebler at
I updated CLUBB's copyright date range.
( 097dc46 )
noreply at
Adding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129
( 9301e56 )
Gunther Huebler at
Removed unused parameters [-Wunused-parameter]
( bca9c6c )
isenfireldc at
Removed unused parameters [-Wunused-parameter]
( 449ee02 )
isenfireldc at
Taking more duplicated subprograms and paring them down to 1.
( 632fe0c )
bmg2 at
Replaced real checks with an epsilon approach [-Wcompare-reals]
( 9d86e03 )
isenfireldc at
Replaced real checks with an epsilon approach [-Wcompare-reals]
( fc37520 )
isenfireldc at
Removed unused imports [-Wunused-parameter]
( 4b370fe )
isenfireldc at
Removed unused imports [-Wunused-parameter]
( 6847aef )
isenfireldc at
Removed styleguide violations from my code
( 05f7499 )
isenfireldc at
Fixed a backwards epsilon comparison from 8e8e71e
( 6cf01d6 )
isenfireldc at
Removed the "doubling" of the remainder of the subprograms from
( d9c9f90 )
bmg2 at
Changing epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878
( 22eea6c )
Gunther Huebler at
Small changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129
( 9cf48dc )
Gunther Huebler at
Changed the length of solve_type_str to 20 [-Wcharacter-trucation]
( 483e2dd )
isenfireldc at
Removed unused arguments [-Wunused-dummy-argument]
( f10b9dd )
isenfireldc at
Removed unused arguments [-Wunused-dummy-argument]
( 7f8e266 )
isenfireldc at
Removed unused variables [-Wunused-variable]
( 08c14a7 )
isenfireldc at
Removed unused variables [-Wunused-variable]
( 0368ceb )
isenfireldc at
I have tidied up advance_wp2_wp3_module.F90, and I have removed all doubled
( fe8a2cc )
bmg2 at
Removed continue and undid edits to _api fuction signatures
( d8bc455 )
isenfireldc at
Removed continue and undid edits to _api fuction signatures
( d7e922c )
isenfireldc at
I handled the "doubled" subprograms in turbulent_adv_pdf.F90.
( 914eb7d )
bmg2 at
Making change explained in larson-group/clubb#878
( 6bdf293 )
Gunther Huebler at
Removed some unused variables (ifort)
( a5ab148 )
isenfireldc at
Removed some unused variables (ifort)
( 3f2c343 )
isenfireldc at
Adding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129
( e842d00 )
Gunther Huebler at
Removed unused import [-Wunused-variable]
( 8a2c248 )
isenfireldc at
Removes unused function calc_cloud_frac [-Wunused-function]
( 5bb7214 )
isenfireldc at
Fixes style issue
( c97ab5e )
isenfireldc at
Removed import without only as it was unused
( 7baba2d )
isenfireldc at
Adds mpishorthand back with only, it appears to be used somewhere
( 8391e30 )
isenfireldc at
I have pared two subprograms down to one again, this time for the
( 206d072 )
bmg2 at
I pared down subprogram pairs again, this time for mean advection.
( 4df2dce )
bmg2 at
I added altitude_threshold to the list of CLUBB's tunable parameters.
( 0a804e3 )
bmg2 at
I added altitude_threshold to the list of CLUBB's tunable parameters.
( ebcd262 )
bmg2 at
Updating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots.
( afdb66e )
strike at
Updating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be).
( 7466fd8 )
strike at
Adds more debug lines
( 4e98f88 )
isenfireldc at
Removes debug lines
( e3e4966 )
isenfireldc at
Adds debug lines and changes format
( 27cebcd )
isenfireldc at
Modifies debug line
( e69122b )
isenfireldc at
Modifies debug line
( 5224402 )
isenfireldc at
Initialize ncf%ntimes to 0 when opening netcdf for writing
( 5c207cd )
isenfireldc at
Removes debug lines
( 2855a9a )
isenfireldc at
Changes length of units variable in stat_file_module from 20 to 25
( 1d2c330 )
isenfireldc at
This commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true. A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines.
( e39f3a9 )
benjamin.andrew.stephens at
Adding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close. This will aid in implementing the SILHS 2D output subroutines in host models. The new API subroutines necessitated some minor changes in clubb_driver.F90 as well. Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo).
( f299530 )
benjamin.andrew.stephens at
I updated the stats code in setup_clubb_pdf_params.F90 and in
( faaa09a )
bmg2 at
I updated the stats code in setup_clubb_pdf_params.F90 and in
( b61ffdb )
bmg2 at
This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information.
( e0f1e9b )
benjamin.andrew.stephens at
This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information.
( 6482c64 )
benjamin.andrew.stephens at
Undoing accidental find and replace. larson-group/cam#129
( 4fabcab )
Gunther Huebler at
Updated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832
( 835b96e )
nchief at
Fix super serious 1 character bug that broke all of the things
( 16a52f1 )
strike at
I am committing Zhun's changes to the CLUBB portion of his
( 0918815 )
bmg2 at
I modified tunable_parameters.in to use some of the parameter values that
( 27379d1 )
bmg2 at
Update stats_zm_module.F90
( 121e67c )
noreply at
I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max
( b65048d )
bmg2 at
I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max
( 9b55d6c )
bmg2 at
I connected the new tunable parameters to advance_helper_module.F90.
( 8d20eb1 )
bmg2 at
I added l_use_shear_Richardson to CLUBB's configurable model flags.
( 8494d30 )
bmg2 at
I added l_use_shear_Richardson to CLUBB's configurable model flags.
( 25ed680 )
bmg2 at
Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs.
( b0bbc88 )
benjamin.andrew.stephens at
Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs.
( 3dc70ce )
benjamin.andrew.stephens at
I forgot to add rtp2_clip_coef to tunable_parameters.in (this doesn't affect
( 5886ca8 )
bmg2 at
In order to prevent dycoms2_rf02_so from crashing,
( 954c6c2 )
Vince Larson at
I updated the recording of the budget terms for upwp_pr4 and vpwp_pr4.
( e65f260 )
Vince Larson at
Adding the smooth_min and smooth_max functions to the repo. These are not yet implemented in CLUBB but are now available for use and testing. See issue #894.
( cacdab6 )
benjamin.andrew.stephens at
Adding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions. See issue #894.
( c2066af )
benjamin.andrew.stephens at
Modifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129
( 13f11f1 )
Gunther Huebler at
This commit replaces division by tau with multiplication by inverse tau in most cases. It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files. Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine.
( 51f8757 )
benjamin.andrew.stephens at
I am committing a bug fix to the invrs_tau_zm equation that was
( d08fdc3 )
bmg2 at
CLUBB and pyplotgen changes:
( fc1a137 )
benjamin.andrew.stephens at
I fixed the LMM stepping bug that was affecting E3SM (because
( dc88808 )
bmg2 at
Fixed alignment.
( 378b990 )
bmg2 at
This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90.
( df97ac5 )
benjamin.andrew.stephens at
This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90.
( ad70857 )
benjamin.andrew.stephens at
Update parameter_indices.F90
( 034049b )
noreply at
Setting parameters and flags to be consistent with the CLUBB repo prior to the October 8 commit merging some E3SM code (https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). This should help to basically recover the plots from before the merge, which is useful for single-column model testing.
( f1d2e79 )
benjamin.andrew.stephens at
Update model_flags.F90
( 3992f76 )
noreply at
Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884.
( 13cf016 )
benjamin.andrew.stephens at
Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884.
( e17eed6 )
benjamin.andrew.stephens at
Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901.
( 217a618 )
benjamin.andrew.stephens at
Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901.
( f1213e1 )
benjamin.andrew.stephens at
I am now passing vert_decorr_coef into SILHS instead of involving
( 7e1baf2 )
bmg2 at
This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39). Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before. I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up).
( 74bc7b1 )
benjamin.andrew.stephens at
Adding a test to make sure new C_uu_buoy parameter is within the valid range. See #901.
( 4af03a6 )
benjamin.andrew.stephens at
This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files.
( 9fd71af )
benjamin.andrew.stephens at
This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files.
( 405016e )
benjamin.andrew.stephens at
This will allow for a better interface of SILHS parameter
( 7a13d2a )
bmg2 at
Fixed a preprocessor command.
( 7bd738c )
bmg2 at
I'm adding the api entry for read_silhs_parameters, called
( 50254f8 )
bmg2 at
Revert "I'm adding the api entry for read_silhs_parameters, called"
( ad27d2d )
bmg2 at
Revert "Fixed a preprocessor command."
( 9672d18 )
bmg2 at
Revert "This will allow for a better interface of SILHS parameter"
( 56af2a0 )
bmg2 at
I updated silhs_api_module so that vert_decorr_coef is publically available
( bf77152 )
bmg2 at
Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902.
( 91ac578 )
benjamin.andrew.stephens at
Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902.
( 4165ae0 )
benjamin.andrew.stephens at
Update configurable_model_flags.in
( 41b3781 )
noreply at
Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term.
( bdc11ca )
benjamin.andrew.stephens at
Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term.
( 3e838cd )
benjamin.andrew.stephens at
Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129
( 63c8e9a )
Gunther Huebler at
Update parameters_tunable.F90
( 76c180d )
noreply at
Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129
( 0ad9f3a )
Gunther Huebler at
Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129
( 0f7d70b )
Gunther Huebler at
Changes non-success `stop` statements to `error stop`
( 76854da )
Vince Larson at
Changes non-success `stop` statements to `error stop`
( a4ddd4f )
Vince Larson at
Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902.
( d985b8a )
59519056+bstephens82 at
Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902.
( dd28907 )
59519056+bstephens82 at
Turning on wp3 pr_turb term.
( 8aebfdf )
benjamin.andrew.stephens at
Turning on wp3 pr_turb term.
( e50b65d )
benjamin.andrew.stephens at
Changed the variable up2_vp2_factor to up2_sfc_coef in all files
( f9dd235 )
rhodesk at
Changed the variable up2_vp2_factor to up2_sfc_coef in all files
( 1a0959d )
rhodesk at
I added an option to improve dry, convecting boundary layers.
( 13d8c61 )
Vince Larson at
This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2. In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1. This makes the terms in these equations more consistent with the terms in the wp2 equation. I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped).
( e5caa86 )
Vince Larson at
Changed surface to sfc in all instances where requested
( df7d548 )
rhodesk at
Undid sfc change in stats_sfc_module.F90
( b963c2e )
noreply at
Undid sfc change to grid_class.F90
( b47281e )
noreply at
Undid sfc change in numerical_check.F90
( ee6b368 )
noreply at
Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129
( 5a8b661 )
Gunther Huebler at
Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129
( 626a34a )
Gunther Huebler at
Fixed typo bug. larson-group/cam#129
( e1ca5e1 )
Gunther Huebler at
Pushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129
( 83811d1 )
Gunther Huebler at
More pushing loops down. All bit-for-bit. larson-group/cam#129
( 7d3c765 )
Gunther Huebler at
More loop pushing. All bit-for-bit. larson-group/cam#129
( 8a392e2 )
Gunther Huebler at
More loop pushing. All bit-for-bit. larson-group/cam#129
( 5eea93b )
Gunther Huebler at
Adding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129
( ddd03bf )
Gunther Huebler at
More loop pushing, all bit-for-bit. larson-group/cam#129
( 3dfd524 )
Gunther Huebler at
Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions.
( 20d8d29 )
Gunther Huebler at
Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled.
( 459d33c )
Gunther Huebler at
Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129
( 836ef0b )
Gunther Huebler at
Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129
( 81f99a7 )
Gunther Huebler at
Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129
( 6392e9c )
Gunther Huebler at
Performance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129
( ca2f078 )
Gunther Huebler at
Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129
( 06ffbc2 )
Gunther Huebler at
Reducing operations. All bit-for-bit. larson-group/cam#129
( 746f45a )
Gunther Huebler at
Adding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129
( 0b60550 )
Gunther Huebler at
Some small cleanup, all just formatting. larson-group/cam#129
( 75c4cd9 )
Gunther Huebler at
Changed ustar from an array to a scalar issue #909
( 3dafc67 )
rhodesk at
Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909
( 3c65841 )
rhodesk at
Created new subroutine and ensured it's BFB. All cases run sucessfully #909
( 083074d )
rhodesk at
added in missing flag which was causing memory errors #909
( cc9e3f1 )
rhodesk at
confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909
( 5630905 )
rhodesk at
Update stats_zm_module.F90
( 2838d3a )
noreply at
Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129
( bb689e8 )
Gunther Huebler at
Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129
( a8e1b16 )
Gunther Huebler at
Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129
( 8a23c35 )
Gunther Huebler at
Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129
( 9291cc6 )
Gunther Huebler at
Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129
( 411f4fc )
Gunther Huebler at
Reformatted mixing length to be more compliant with the coding standard #909
( 5733151 )
rhodesk at
added a reference to new subroutine #909
( 9dbd2b3 )
rhodesk at
Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129
( e32474f )
Gunther Huebler at
Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129
( 435b6db )
Gunther Huebler at
Fixing lines that exceed 100 characters.
( 3343847 )
Gunther Huebler at
Fixing lines that exceed 100 characters.
( 2914cd2 )
Gunther Huebler at
Pushing loops related to pdf_params down. larson-group/cam#129
( 6cccc97 )
Gunther Huebler at
clubb warnings introduced from merge have been removed #909
( f1f64bd )
rhodesk at
Changed safeguard threshold in sigma_sqd_w.
( c4b005c )
rhodesk at
Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen.
( 0ff19bb )
59519056+bstephens82 at
Adding new coefficient to control the wp3 pressure diffusion term.
( f45b148 )
59519056+bstephens82 at
Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms.
( 2bb6466 )
59519056+bstephens82 at
Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo.
( f31e107 )
59519056+bstephens82 at
Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output).
( 940e82e )
59519056+bstephens82 at
These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.
( de3c925 )
59519056+bstephens82 at
Adding new coefficient to control the wp3 pressure diffusion term.
( a52e22d )
59519056+bstephens82 at
Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch.
( 3e4c7b2 )
59519056+bstephens82 at
These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.
( 65a6862 )
59519056+bstephens82 at
Added intent comments for the following files:
( 3c6fc8d )
rhodesk at
Setting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway.
( b4a6c7c )
benjamin.andrew.stephens at
Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core. Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs). This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated.
( 0799b15 )
benjamin.andrew.stephens at
Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90.
( 4637d2f )
benjamin.andrew.stephens at
Fixed comment regarding wp3 splatting term.
( 4856129 )
benjamin.andrew.stephens at
Added intent comments.
( 9833dff )
rhodesk at
Added intent comments.
( 6559732 )
rhodesk at
Added intent comments for advance_xp2_xpyp_module.F90.
( d774cff )
rhodesk at
Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface.
( 7e0741b )
59519056+bstephens82 at
Deleting comments around the old "magic number" for the near-surface clipping.
( dbe9250 )
59519056+bstephens82 at
Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928.
( 332f11b )
Gunther Huebler at
Changed some elements of clubb to allow for better script execution
( 242a464 )
rhodesk at
Fixed clubb not compiling
( 153d245 )
rhodesk at
Feeding gr through the arg list where need only in the CLUBB_core dir.
( fdcdbc1 )
rhodesk at
Feeding gr through the arg list where need only in the CLUBB_core dir.
( b8be270 )
rhodesk at
Reverted changes to clubb_api. For #886
( 0b40866 )
rhodesk at
Replacing use gr statements with feeding gr throught the arg list.
( ac4315a )
rhodesk at
Adding proper indentation to needed files.
( b2e07ae )
rhodesk at
Fixing spacing issue on blank lines. #886
( 682a70d )
rhodesk at
Fixed comment changes. #886
( 68a2ab4 )
rhodesk at
Fixed incorrect spacing on use
( 24d2d6e )
rhodesk at
Revert "Fixed incorrect spacing on use"
( 5427e21 )
rhodesk at
Fixed spacing
( c3e9211 )
rhodesk at
Fixed spacing going too far
( 2e02d7f )
rhodesk at
Fixed comments being pushed over
( d3b117d )
rhodesk at
Fixed not all variables being indented properly
( fe3ae73 )
rhodesk at
Fixed indentation going beyond variables
( a593cc9 )
rhodesk at
Fixed file_functions indentation being off
( 9b94563 )
rhodesk at
Fixed indentation on operations being wrong
( 1e40b9d )
rhodesk at
Reverted incorrect changes to new_pdf and new_hybrid_pdf
( e9a76e1 )
rhodesk at
Fixed spacing issue when adding in gr. BFB identical. For #886.
( 1651f27 )
rhodesk at
Fixed spacing issue when adding in gr. BFB identical. For #886.
( e79fc26 )
rhodesk at
Removing gr as a module variable from grid_class.
( 7bda97a )
rhodesk at
Removing gr as a module variable from grid_class.
( fc2e13e )
rhodesk at
Fixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format.
( 8601df2 )
benjamin.andrew.stephens at
Fixing a typo from an earlier commit.
( 1978bbc )
noreply at
Feeding gr through arg list for functions outside of CLUBB_core.
( 09858d3 )
rhodesk at
Feeding gr through arg list for functions outside of CLUBB_core.
( 24bc682 )
rhodesk at
Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB.
( 7c6ca69 )
rhodesk at
The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken.
( 5127df8 )
rhodesk at
Add error header for CLUBB in CAM
( a147663 )
noreply at
Fixing the ordering of gr in the clubb_api arg list for affected subroutines.
( cd3da20 )
rhodesk at
Fixing coding standard violations
( fd4054c )
rhodesk at
Improving error messages in setup_clubb_core. larson-group/e3sm#38
( 479e56b )
Gunther Huebler at
Feeding stats variables through the argument lists of needed subroutines.
( 0295787 )
72510114+RhodesKeegan at
Fixing spacing issues along with placing the stats varibales on their own lines.
( 6eef921 )
72510114+RhodesKeegan at
Changing more subroutines to include stats vars in their arg lists.
( d5fbfd0 )
72510114+RhodesKeegan at
Fixing incorrect subroutine arg list
( 77d0af2 )
72510114+RhodesKeegan at
Fixing host models not compiling.
( d13ff64 )
72510114+RhodesKeegan at
Fixing argument list so that way the coding standard is upheld.
( ccebf94 )
72510114+RhodesKeegan at
I changed the name to calc_responder_driver because I thought that
( 3521e3a )
bmg2 at
Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.
( 9804df9 )
59519056+bstephens82 at
Fixing comment for the wp2_term_pr_dfsn subroutine. Related to #920.
( c65a56c )
59519056+bstephens82 at
Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920.
( 467f228 )
59519056+bstephens82 at
Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920.
( 98f49a6 )
59519056+bstephens82 at
Fixing some comments.
( 4b64520 )
59519056+bstephens82 at
Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.
( 28673d8 )
59519056+bstephens82 at
Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.
( 523614e )
benjamin.andrew.stephens at
Moving the stats variables to module variables of clubb_driver.
( 0a931b8 )
72510114+RhodesKeegan at
Moving the stats variables to module variables of clubb_driver.
( bad9a3e )
72510114+RhodesKeegan at
Fixing coding standard viloation of lines exceeding 100 characters.
( 82f133b )
rhodesk at
Fixing coding standard viloation of lines exceeding 100 characters.
( be45e73 )
rhodesk at
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.
( bd7552a )
59519056+bstephens82 at
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.
( b8bad9e )
59519056+bstephens82 at
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.
( 82a9bae )
59519056+bstephens82 at
Removing l_interp_prescribed_params from setup_clubb_pdf_params.
( 34cf74a )
rhodesk at
Adding comments labeling subroutine calls with intent.
( e4741e2 )
rhodesk at
Adding intent labels for subroutines throughout clubb.
( fb672a1 )
rhodesk at
Removing unnecessary constant from use statement
( dea9cab )
noreply at
Eliminating l_nu_grid_dependent as requested.
( dc17ecf )
rhodesk at
Eliminating l_use_buoy_mod_Km_zm.
( c22a22b )
rhodesk at
Eliminating l_iter_xp2_xpyp flag.
( 0e8980b )
rhodesk at
Eliminating l_apply_rule_to_pdf_params flag.
( bafa3df )
rhodesk at
Eliminating l_ub_const_deriv flag.
( 80351a9 )
rhodesk at
Eliminating l_equation_21 flag.
( 5861ea0 )
rhodesk at
Eliminating l_wp3_2nd_buoyancy flag.
( 1725bbe )
rhodesk at
Eliminating l_refine_grid_in_cloud and l_interactive_refined.
( 895a8f6 )
rhodesk at
Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds
( 7cbdaaf )
rhodesk at
Eliminating l_use_wp3_pr3 flag.
( a17efb4 )
rhodesk at
Eliminating l_clip_semi_implicit flag.
( 9241858 )
rhodesk at
Adding intent labels for subroutines throughout clubb.
( 5235047 )
rhodesk at
Eliminating l_single_C2_Skw flag.
( 51022e2 )
72510114+RhodesKeegan at
Eliminating l_single_C2_Skw flag.
( f71a21b )
72510114+RhodesKeegan at
Eliminating l_single_C2_Skw flag.
( 35ae5cd )
72510114+RhodesKeegan at
Eliminating l_include_ice and sat_ice_ratio.
( 0154499 )
rhodesk at
Eliminating l_update_pressure flag.
( 87fade1 )
rhodesk at
Eliminating l_update_pressure flag.
( 5fc3ff6 )
rhodesk at

#96 (Aug 18, 2021, 3:03:09 AM)

Reflecting changes made to clubb in host models
( 824cf34 )
rhodesk at
Raw-copy updating SRC/CLUBB
( 8c8a358 )
LarsonGroupSysAdmin at

#95 (Aug 17, 2021, 9:29:31 AM)

Raw-copy updating SRC/CLUBB
( c0e9615 )
root at
Raw-copy updating SRC/SILHS
( 95fbefb )
root at
Swapping out old intel variable set script for new intel script.
( 23fd1d1 )
pbroels at

#94 (Aug 14, 2021, 3:03:09 AM)

Commiting to test host models
( 4d22b66 )
72510114+RhodesKeegan at
Fixing compilation error
( 4eaf492 )
72510114+RhodesKeegan at
Reverting changes made to clubb and silhs
( 81de9ac )
72510114+RhodesKeegan at

#93 (Aug 13, 2021, 3:03:07 AM)

Eliminating l_use_wp3_pr3 flag.
( 96b8289 )
rhodesk at
Eliminating l_clip_semi_implicit flag.
( 4bf75cc )
rhodesk at
Adding intent labels for subroutines throughout clubb.
( c500b18 )
rhodesk at

#92 (Aug 12, 2021, 3:03:07 AM)

Eliminating l_apply_rule_to_pdf_params flag.
( 76a87a6 )
rhodesk at
Eliminating l_ub_const_deriv flag.
( 5d26a06 )
rhodesk at
Eliminating l_equation_21 flag.
( 8eafa1e )
rhodesk at
Eliminating l_wp3_2nd_buoyancy flag.
( 277403a )
rhodesk at
Eliminating l_refine_grid_in_cloud and l_interactive_refined.
( 9072ea2 )
rhodesk at
Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds
( bf0a2f0 )
rhodesk at

#91 (Aug 11, 2021, 2:53:06 PM)

Adding new intel environment file to oth run and compile step. larson-group/sys_admin#750
( 1f154cc )
pbroels at
Fixing error in previous commit.
( 914ca8f )
pbroels at

#90 (Aug 11, 2021, 3:03:09 AM)

Eliminating l_nu_grid_dependent as requested.
( 31547c8 )
rhodesk at
Eliminating l_use_buoy_mod_Km_zm.
( 6e5b373 )
rhodesk at
Eliminating l_iter_xp2_xpyp flag.
( c77d1e6 )
rhodesk at

#89 (Aug 4, 2021, 3:03:08 AM)

Adding intent labels for subroutines throughout clubb.
( 8ae8997 )
rhodesk at
Removing unnecessary constant from use statement
( de50619 )
noreply at

#88 (Aug 3, 2021, 3:03:09 AM)

Adding comments labeling subroutine calls with intent.
( 3f4568e )
rhodesk at

#87 (Jul 31, 2021, 3:03:07 AM)

Removing l_interp_prescribed_params from setup_clubb_pdf_params.
( d7fab3c )
rhodesk at
Changes readiopdata_module to use nf90 subroutines
( b0a3323 )
isenfireldc at
Switches nf_real to nf90_real
( 1e61599 )
isenfireldc at
Replaces nf_get_var_<type> family with nf90_get_var
( 3e986f6 )
isenfireldc at
Moves more calls to nf90
( a6701b0 )
isenfireldc at
Replace nf_inq_dimlen with nf90_inquire_dimension
( 3fceded )
isenfireldc at
Replace nf_inq_dimname with nf90_inquire_dimension
( 4b7c9ec )
isenfireldc at
Replace nf_get_vara_ subroutines with nf90_get_var
( 99ca297 )
isenfireldc at
Remove `include netcdf.inc` statements
( 4a7f100 )
isenfireldc at
Remove redundant code
( 5ed0296 )
isenfireldc at
Use nf90_inquire_dimension to manually set count value for nf90_get_var
( 29270c4 )
isenfireldc at
Add workaround for k=1
( d3bc298 )
isenfireldc at
Switch to using nf90_inquire_variable to find information to allocate var
( ed8cda0 )
isenfireldc at
Fix manual specification of values
( 99de4b8 )
isenfireldc at
Fix issues with deallocation of variables
( e48261f )
isenfireldc at
Rewrite some of get_netcdf_var2d_real
( 597e579 )
isenfireldc at
Add deallocate statement to get_netcdf_var2d_real after change
( e2ff191 )
isenfireldc at
Remove unused variable 'length' in get_netcdf_var*d_real
( f94721b )
isenfireldc at
Add statement to ensure dplevs initializes with zeroed values
( 4fda5fb )
isenfireldc at
Revert "Add workaround for k=1"
( ab9e44d )
isenfireldc at
Update comments and variable names as requested
( c39e5b3 )
isenfireldc at
Fix comments
( ee6f68d )
isenfireldc at
Set intent of var back to inout, as in the case of dplevs, it may not assign all values
( b81c696 )
isenfireldc at
Remove some of the old variables from get_netcdf_var2d_real
( 029a7cf )
isenfireldc at

#86 (Jul 30, 2021, 3:03:07 AM)

Fixing coding standard viloation of lines exceeding 100 characters.
( e542998 )
rhodesk at
Fixing coding standard viloation of lines exceeding 100 characters.
( d5bdc8f )
rhodesk at
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.
( b1418c5 )
59519056+bstephens82 at
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.
( 3c12f9c )
59519056+bstephens82 at
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.
( 1899d62 )
59519056+bstephens82 at

#85 (Jul 28, 2021, 3:03:06 AM)

Commiting to test host models
( 0b7fcc2 )
72510114+RhodesKeegan at
Passing stats variables through required subroutines.
( f3641b7 )
72510114+RhodesKeegan at
Fixing compiliation errors
( 8549b41 )
72510114+RhodesKeegan at
Fixing compiliation errors
( 732481c )
72510114+RhodesKeegan at
Fixing compiliation errors
( 5c54149 )
72510114+RhodesKeegan at
Fixing compilation errors
( cb01e8e )
72510114+RhodesKeegan at
Fixing compiliation errors
( f76e3b6 )
72510114+RhodesKeegan at
Fixing compiliation errors
( 38f6f53 )
72510114+RhodesKeegan at
Fixing compilation errors
( 6486aee )
72510114+RhodesKeegan at
Fixing compilation errors
( 52333b1 )
72510114+RhodesKeegan at
Fixing compilation status
( 762813a )
72510114+RhodesKeegan at
Fixing compilation errors
( 890c9ba )
72510114+RhodesKeegan at
Removing updated clubb and silhs directories
( d93991f )
72510114+RhodesKeegan at
Fixing files that were incorrectly changed
( a11793c )
72510114+RhodesKeegan at
Adding comments explaining subroutineoverloading
( 8dd0adc )
72510114+RhodesKeegan at
Moving the stats variables to module variables of clubb_driver.
( 3e33479 )
72510114+RhodesKeegan at
Moving the stats variables to module variables of clubb_driver.
( 29b6903 )
72510114+RhodesKeegan at

#84 (Jul 27, 2021, 3:03:07 AM)

Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.
( c777521 )
59519056+bstephens82 at
Fixing comment for the wp2_term_pr_dfsn subroutine. Related to #920.
( 9da282e )
59519056+bstephens82 at
Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920.
( f6dcf59 )
59519056+bstephens82 at
Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920.
( bdfc25a )
59519056+bstephens82 at
Fixing some comments.
( c1c60fe )
59519056+bstephens82 at
Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.
( d3fd7f7 )
59519056+bstephens82 at
Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.
( 2a15f13 )
benjamin.andrew.stephens at

#83 (Jul 24, 2021, 3:03:08 AM)

I changed the name to calc_responder_driver because I thought that
( 9c99e3f )
bmg2 at

#82 (Jul 23, 2021, 3:03:08 AM)

Feeding stats variables through the argument lists of needed subroutines.
( 61af70f )
72510114+RhodesKeegan at
Fixing spacing issues along with placing the stats varibales on their own lines.
( b910074 )
72510114+RhodesKeegan at
Changing more subroutines to include stats vars in their arg lists.
( e204022 )
72510114+RhodesKeegan at
Fixing incorrect subroutine arg list
( ac1df97 )
72510114+RhodesKeegan at
Fixing host models not compiling.
( d8a773b )
72510114+RhodesKeegan at
Fixing argument list so that way the coding standard is upheld.
( f88352a )
72510114+RhodesKeegan at

#81 (Jul 21, 2021, 3:03:09 AM)

Saving logs for each run for troubleshooting. larson-group/sys_admin#735
( 919ab68 )
pbroels at
Changing command order to ensure the log copy completes. larson-group/sys_admin#735
( 2f6be5f )
pbroels at

#80 (Jul 20, 2021, 3:03:08 AM)

Adding wp3_ta and wp3_tp terms to SAM output. See #141.
( 4e816a3 )
59519056+bstephens82 at
Some minor updates to the new W3TA and W3TP terms.
( 9e83580 )
59519056+bstephens82 at
Editing names in RUNDATA/lst.
( 554c02b )
59519056+bstephens82 at

#79 (Jul 9, 2021, 3:03:08 AM)

Changing directory names and conditional variable names to match new test names. larson-group/sys_admin#735
( 8a9a127 )
pbroels at