Status

Changes

Console Output

Polling Log

Git Build Data

Pipeline Overview

Pipeline Steps

Previous Build

Next Build

#97 (Aug 19, 2021, 3:03:09 AM)

Started 5 yr 2 mo ago

Took 22 min

	Started by an SCM change
	Revision: c6e4c32114cbd0f9c6a62aba56ebc3c76d990ff5 Repository: https://github.com/larson-group/sam_clubb.git refs/remotes/origin/master

For clubb:ticket:770, the Oracle compiler was throwing a floating point exception here. wpxp2 and xp2 were being fed in as Nans.

weberjk at 1:54 PM 7/10/15

The new file calc_roots.F90 contains functions that solve for the roots of a

bmg2 at 1:38 PM 7/14/15

I tweaked the precipitation fraction code so that the weighted ith PDF component

bmg2 at 12:54 PM 7/28/15

For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j.

raut at 11:30 PM 8/11/15

I updated pdf_closure_module.F90 by integrating changes I made in the

bmg2 at 11:29 AM 9/18/15

For cam:ticket:36:

raut at 6:36 PM 10/29/15

For cam:ticket:36#comment:132, I removed `gr` from the use statement in `setup_grid_heights_api`.

raut at 2:32 PM 11/2/15

For clubb:ticket:773, I fixed some unsoundness in our code regarding kinds, specifically in `parameters_model.F90` and `endian.F90`.

raut at 10:01 PM 11/6/15

For cam:ticket:41, the change in clubb:r7921 should be applied to the trunk as well.

raut at 5:55 PM 11/20/15

For clubb:ticket:775:

raut at 7:29 PM 11/23/15

For clubb:ticket:775:

raut at 2:05 PM 11/27/15

Misc. code cleanup

raut at 2:08 PM 11/27/15

I am updating default CLUBB to use the same hydrometeor PDF parameters that are

bmg2 at 4:02 PM 12/31/15

For cam:ticket:50:

raut at 7:21 PM 1/28/16

For cam:ticket:52:

raut at 3:52 PM 2/17/16

For cam:ticket:52, I added some parameter indices to the API.

raut at 4:23 PM 2/17/16

I forgot a parameter!

raut at 4:36 PM 2/17/16

For clubb:ticket:753:

raut at 7:08 PM 2/21/16

For clubb:ticket:782:

raut at 7:26 PM 2/22/16

I forgot a flag.

raut at 7:28 PM 2/22/16

For clubb:ticket:782:

raut at 2:36 PM 2/23/16

For cam:ticket:55, I added some parameters to CLUBB's API.

raut at 4:58 PM 2/23/16

For cam:ticket:55:

raut at 5:15 PM 2/23/16

I cleaned up some warnings from the Mac compiler. (build:14977)

raut at 4:42 PM 3/3/16

For clubb:ticket:785, I renamed `initvars` to `clubb_params_nl`.

raut at 5:57 PM 3/9/16

For clubb:ticket:785:

raut at 6:07 PM 3/9/16

For clubb:ticket:779:

raut at 6:54 PM 3/11/16

For clubb:ticket:786:

raut at 5:28 PM 3/21/16

For clubb:ticket:786:

raut at 3:14 PM 3/24/16

For clubb:ticket:782, I added all CLUBB's parameter indices to the API.

raut at 5:10 PM 4/5/16

raut at 6:34 PM 4/5/16

more helpful note

raut at 6:36 PM 4/5/16

most helpful note

raut at 6:40 PM 4/5/16

For cam:ticket:56:

raut at 2:47 PM 4/15/16

While working on cam:ticket:59, I noticed that `tau_N2_zm` is computed twice. I removed one computation.

raut at 6:40 PM 4/25/16

Dat crazy indentation, though...

raut at 7:06 PM 4/25/16

For cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`.

raut at 2:13 PM 4/26/16

For cam:ticket:59:

raut at 6:38 PM 4/26/16

For cam:ticket:59:

raut at 5:01 PM 4/28/16

For cam:ticket:59:

raut at 5:45 PM 4/28/16

For cam:ticket:59, I added a new output for Richardson number.

raut at 9:14 PM 4/28/16

For cam:ticket:59:

raut at 4:29 PM 4/29/16

Per cam:ticket:59#comment:21, using `T_in_K_zm` in "the formula".

raut at 4:32 PM 4/29/16

For cam:ticket:59.

raut at 4:40 PM 4/29/16

For cam:ticket:59 I renamed `Richardson_no` to `Richardson_num`.

raut at 11:44 AM 5/2/16

For cam:ticket:59, I added kludgy statistical output for `brunt_vaisala_freq_sqd`.

raut at 6:28 PM 5/2/16

For cam:ticket:59:

raut at 4:13 PM 5/6/16

For cam:ticket:59:

raut at 4:31 PM 5/6/16

For cam:ticket:59:

raut at 8:17 PM 5/9/16

For cam:ticket:59.

raut at 5:09 PM 5/11/16

For cam:ticket:59:

raut at 9:00 PM 5/11/16

Apparently, I didn't have to jump through the hoop of declaring a separate profile to use in the `max` statement.

raut at 9:04 PM 5/11/16

For cam:ticket:59:

raut at 3:58 PM 5/12/16

For cam:ticket:59:

raut at 4:37 PM 5/12/16

For cam:ticket:59:

raut at 5:52 PM 5/12/16

For clubb:ticket:782:

raut at 3:54 PM 5/17/16

For cam:ticket:59:

raut at 6:29 PM 5/17/16

For cam:ticket:59:

raut at 11:58 AM 5/18/16

For cam:ticket:59:

raut at 3:44 PM 5/18/16

For cam:ticket:59:

raut at 3:59 PM 5/18/16

For clubb:ticket:782:

raut at 9:42 PM 5/18/16

For cam:ticket:59:

raut at 6:26 PM 5/19/16

For cam:ticket:59, I fixed bugs in the `l_use_C7_Richardson=T` vertical averaging code:

raut at 4:20 PM 5/24/16

I adjusted a comment.

raut at 5:05 PM 5/24/16

For clubb:ticket:788:

raut at 7:59 PM 5/24/16

For cam:ticket:59:

raut at 1:38 PM 5/25/16

For clubb:ticket:788:

raut at 9:16 PM 5/26/16

For clubb:ticket:788:

raut at 11:24 AM 5/30/16

For clubb:ticket:788:

raut at 12:18 PM 5/30/16

For clubb:ticket:788:

raut at 12:30 PM 5/30/16

For clubb:ticket:788:

raut at 9:14 PM 5/31/16

Renamed C7 to Cx in appropriate places.

raut at 1:15 PM 6/9/16

For cam:ticket:59:

raut at 2:42 PM 6/10/16

For cam:ticket:59:

raut at 7:59 PM 6/10/16

I made it a default to use 0 instead of cloud_frac_min in the B.V. frequency calculation.

raut at 2:12 PM 6/12/16

For cam:ticket:67:

raut at 5:36 PM 7/7/16

For cam:ticket:67:

raut at 6:13 PM 7/7/16

Code improvements.

raut at 6:32 PM 7/7/16

Vince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more!

raut at 6:43 PM 7/7/16

For cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used.

raut at 1:02 PM 7/13/16

Fixed a comment.

raut at 1:18 PM 7/13/16

For clubb:ticket:788:

raut at 7:11 PM 7/15/16

For clubb:ticket:792:

raut at 4:07 PM 7/18/16

For clubb:ticket:792:

raut at 7:38 PM 7/18/16

For clubb:ticket:792, I added more initializations for uninitialized variables.

raut at 1:10 PM 7/19/16

When l_avg_Lscale is turned on but the plume-centered calculation is disabled,

bmg2 at 2:38 PM 7/19/16

For clubb:ticket:792:

raut at 5:08 PM 7/19/16

For clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output.

raut at 5:35 PM 7/19/16

I renamed RH_postPDF to rel_humidity.

raut at 6:32 PM 7/19/16

For clubb:ticket:792. rsat actually should be recomputed here before output, because it will change if `l_rcm_supersat_adj = T`.

raut at 8:19 PM 7/19/16

For clubb:ticket:792. I am reusing the `rel_humidity` variable for output, for no particular reason.

raut at 8:25 PM 7/19/16

For clubb:ticket:792!!!! I set `l_rcm_supersat_adj = T` by default, in both source code and namelist.

raut at 8:31 PM 7/19/16

As requested, I am adding a warning message (debug level 1) when spurious supersaturation is removed.

raut at 8:45 PM 7/19/16

raut at 8:46 PM 7/19/16

For clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010).

raut at 10:27 AM 7/20/16

I removed a spurious print statement.

raut at 11:23 AM 7/20/16

For cam:ticket:73:

raut at 1:48 PM 7/21/16

I am beginning to generalize the sponge damping code so that it can be applied to

bmg2 at 6:44 PM 8/3/16

I have added all the coding infrastructure to perform sponge damping (and record

bmg2 at 6:35 PM 8/4/16

Vince Larson at 9:30 AM 9/29/16

clubb:ticket:796

roessle9 at 9:10 AM 10/18/16

I added some parameter value checking in subroutine setup_parameters.

bmg2 at 3:32 PM 10/18/16

I finally have a standalone version of the new subroutine, generate_pdf_params,

bmg2 at 1:13 AM 12/1/16

Some code within advance_clubb_core that is found within CAM_CLUBB preprocessor

bmg2 at 1:38 AM 12/1/16

The perturbation Lscale code requires rtm_frz, thlm_frz, and pdf_params_frz to

bmg2 at 2:37 AM 12/1/16

I added a missing intent(out) statement.

bmg2 at 2:46 AM 12/1/16

I have interfaced the new subroutine containing all of the PDF closure-related

bmg2 at 12:04 PM 12/1/16

I got rid of some variables that were brought into advance_clubb_core by use statements

bmg2 at 12:29 PM 12/1/16

I cleaned up more compiler warnings for unused variables. The warnings came from g95.

bmg2 at 12:41 PM 12/1/16

I have added a second call to subroutine generate_pdf_params. This one occurs

bmg2 at 10:38 AM 12/2/16

I moved the setting of qclvar and thlprcp_out to after the second call to

bmg2 at 12:06 PM 12/2/16

I have declared the l_use_ice_latent option and the l_call_pdf_closure_twice

bmg2 at 12:42 PM 12/2/16

I added a local cslculation of sigma_sqd_w near the top of subroutine

bmg2 at 1:04 PM 12/2/16

I am changing the inputs and outputs of subroutine advance_clubb_core so that

bmg2 at 2:20 PM 12/2/16

I added code so that stats that are internal to subroutine generate_pdf_params

bmg2 at 11:22 AM 12/3/16

I have updated subroutine advance_clubb_core so that pdf_params_zm is now passed

bmg2 at 2:59 PM 12/13/16

Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical

savva at 2:20 AM 1/11/17

Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical

savva at 11:59 PM 1/12/17

Vince Larson at 2:26 PM 1/20/17

Vince Larson at 9:59 AM 1/23/17

I added a new subroutine, init_pdf_params, to pdf_parameter_module.F90.

bmg2 at 4:33 PM 1/25/17

I renamed the subroutine pack_pdf_params found in setup_clubb_pdf_params.F90

bmg2 at 5:01 PM 1/25/17

I am now using the new subroutine init_pdf_params to initialize the

bmg2 at 5:21 PM 1/25/17

I removed the CAM_CLUBB preprocessor directives from pack_pdf_params_api,

bmg2 at 5:39 PM 1/25/17

clubb:ticket:800 -- Changed fatal errors statements to debug level 0.

savva at 8:18 PM 2/9/17

I updated CLUBB stats so that wpthvp, wp2thvp, rtpthvp, and thlpthvp

bmg2 at 1:46 PM 2/21/17

I have added the coding infrastructure to output additional statistics

bmg2 at 1:13 PM 2/23/17

This is a bug fix for the Sun compiler. The variables pdf_params_zm and

bmg2 at 3:19 PM 2/25/17

I am updating the hydrometeor PDF code to set mu_hm_1 and

bmg2 at 12:17 AM 2/26/17

Running the Bitten tests.

bmg2 at 11:57 PM 2/28/17

I added some comments so that CLUBB-SILHS would be consistent with

Vince Larson at 12:38 PM 5/5/17

As a first step, I changed all instances of rrtthl to corr_rt_thl_1.

bmg2 at 4:57 PM 7/14/17

I have added corr_rt_thl_2 to the code to go along with corr_rt_thl_2.

bmg2 at 5:34 PM 7/14/17

I have added some code to add corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2

bmg2 at 12:43 AM 7/20/17

I added new statistics to the CLUBB _zt output files, specifically corr_w_rt_1, corr_w_rt_2,

bmg2 at 8:40 PM 7/20/17

I am updating the equations for wp2rtp, wp2thlp, wprtp2, and wpthlp2 to include

bmg2 at 4:08 PM 7/25/17

I am adding a special function to calculate the within-component correlation of

bmg2 at 9:54 PM 7/26/17

I added variables corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2

bmg2 at 12:50 AM 7/27/17

I am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to type

bmg2 at 4:26 PM 8/2/17

Now that the PDF component correlations of w and chi, as well as w and eta,

bmg2 at 5:47 PM 8/2/17

I am adding statistical output for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1,

bmg2 at 6:27 PM 8/2/17

I am changing the name of the flag l_fix_chi_eta_correlations to

bmg2 at 7:22 PM 8/2/17

The two component normal (double Gaussian) PDF used by CLUBB will now be

bmg2 at 1:31 AM 8/4/17

I moved the checking of the options for the PDF call placement to subroutine

bmg2 at 6:00 PM 8/4/17

I am altering setup PDF parameters to be able to read in the values of

bmg2 at 2:49 PM 8/10/17

I am adding the new file new_pdf.F90 to the CLUBB core directory. So far, it

bmg2 at 9:42 PM 8/16/17

I am adding a large amount of code to the new PDF. I have filled in the driver

bmg2 at 10:58 PM 8/19/17

I am adding code to the new PDF that calculates the minimum and maximum

bmg2 at 3:17 PM 8/29/17

I added a new iiPDF entry for the new PDF, and I neatened some of the current

bmg2 at 4:50 PM 8/29/17

I added an option to call the new PDF from subroutine pdf_closure.

bmg2 at 5:04 PM 8/29/17

I had to add checking for the new PDF so someone does not try to run it

bmg2 at 5:24 PM 8/29/17

I made a couple changes to (1) initialize two variables that aren't used by the

bmg2 at 9:48 AM 8/30/17

I added a conditional to the subroutine that sets the responder parameters.

bmg2 at 12:31 PM 8/30/17

I have added the beginnings of a new unit test for the PDF parameters.

bmg2 at 1:11 AM 9/2/17

I have updated the PDF parameter unit test to make a call to the full PDF (for

bmg2 at 5:13 PM 9/6/17

I have added a feature to the PDF parameter unit tests which allows the user

bmg2 at 1:34 AM 9/7/17

In the setter variable description and subprograms, I made a name change from

bmg2 at 10:53 PM 9/7/17

I have updated the method of calculating the setter variable so that mu_x_1

bmg2 at 11:59 PM 9/7/17

I added primarily some more documentation and notes.

bmg2 at 12:12 AM 9/9/17

I added some more comments documenting the code.

bmg2 at 9:55 AM 9/11/17

I got rid of some of the expressions that a script might try to flag as

bmg2 at 12:47 PM 9/11/17

I added much more documentation about the responder variable. Specifically,

bmg2 at 5:35 PM 9/12/17

I am adding the new file, original_pdf.F90, as the new home for the ADG1, ADG2,

bmg2 at 1:44 AM 9/14/17

I have now switched the PDF closure code over to calling the code that had been

bmg2 at 11:25 AM 9/14/17

I updated the documentation in the code comments for the setter method and

bmg2 at 10:01 PM 9/16/17

I added a comment.

bmg2 at 10:08 PM 9/16/17

I added a new function, calc_comp_corrs_binormal, to pdf_utilities.F90. This

bmg2 at 4:26 PM 9/19/17

I added some more descriptive comments and a new function that calculates the

bmg2 at 1:10 AM 9/20/17

I updated the code so that coef_sigma_x_1_sqd and coef_sigma_x_2_sqd are passed

bmg2 at 10:42 PM 9/20/17

I fixed a mistake.

bmg2 at 10:47 PM 9/20/17

I have added code to call the new function that calculates wp4 implicitly from

bmg2 at 11:54 PM 9/21/17

I moved the calculations of wp2xp (wp2rtp and wp2thlp), wp4, and wpxp2 (wprtp2

bmg2 at 12:42 AM 9/22/17

I added another function to the new PDF. This function helps to calculate

bmg2 at 1:27 AM 9/24/17

I added a special case for the wpxp2 implicit code.

bmg2 at 4:20 PM 9/26/17

Back in clubb:r8409, the PDF component correlations of w and rt and w and

bmg2 at 5:29 PM 9/26/17

I added a subroutine that calculates the implicit and explicit portions of the

bmg2 at 10:10 PM 9/27/17

I renamed original_pdf.F90 as adg1_adg2_3d_luhar_pdf.F90.

bmg2 at 10:21 PM 9/27/17

I added statistical output for F_w, F_rt, F_thl, min_F_w, max_F_w, min_F_rt,

bmg2 at 7:09 PM 9/28/17

I split the new PDF into two files. I added a new file that currently houses

bmg2 at 12:52 AM 9/29/17

I clipped temperature within the Goff-Gratch functions for saturation over liquid and ice.

Vince Larson at 9:50 AM 10/4/17

I initialized some output variables in order to prevent a runtime error.

bmg2 at 7:45 PM 10/4/17

I made a sub-driver level subroutine for the calculations necessary for a

bmg2 at 11:17 PM 10/4/17

I added code to allow the variable (of w, rt, or theta-l) with the greatest

bmg2 at 8:09 PM 10/6/17

I added calls to the functions and subroutines that calculate the implicit and

bmg2 at 1:13 AM 10/7/17

I changed coef_wp2xp_explicit (coef_wp2rtp_explicit and coef_wp2thlp_explicit)

bmg2 at 3:12 PM 10/14/17

I am adding a new file for the new trivariate skewness-dependent analaytic

bmg2 at 6:16 PM 10/14/17

I fixed a bug in the new Trivariate skewness-dependent analytic double Gaussian

bmg2 at 10:15 PM 10/17/17

In order for the TSDADG PDF to work correctly, when Skx * sgn( <w'x'> ) >= 0,

bmg2 at 11:57 PM 10/17/17

In order to clarify coding in CLUBB, I am moving a block of code that is

bmg2 at 5:38 PM 10/24/17

I am fixing a bug where rtp2 and thlp2 (and sclrp2) were not preserved when

bmg2 at 1:33 AM 10/27/17

I updated the TSDADG PDF by adding the responding variable description, the

bmg2 at 1:38 AM 10/27/17

When ADG1 or ADG2 are not used, we have to set alpha_rt, alpha_thl, and

bmg2 at 5:07 PM 10/27/17

I am calling the new TSDADG PDF from subroutine pdf_closure.

bmg2 at 5:43 PM 10/27/17

Clarity changes to the new TSDADG PDF.

bmg2 at 6:16 PM 10/27/17

I added some references to the CLUBB-SILHS tech doc.

Vince Larson at 5:26 PM 10/30/17

I fixed a bug in the calculation of PDF component variances in the new TSDADG

bmg2 at 6:43 PM 11/2/17

I added more references to the CLUBB-SILHS tech doc.

Vince Larson at 3:25 PM 11/3/17

I have set the tunable parameters F_x and zeta_x to skewness functions for the

bmg2 at 1:22 AM 11/8/17

I needed to increase the limit of nvarmax_zt so that LBA (and other

bmg2 at 6:32 PM 11/9/17

I changed the URL references to the CLUBB-SILHS overview document.

Vince Larson at 8:47 AM 11/13/17

Changed variable and subroutine names, see ticket 810 and 811

hoc_browser at 8:03 PM 11/17/17

I have added the Lewellen and Yoh (1993) PDF to CLUBB for testing and comparison

bmg2 at 4:32 PM 11/21/17

Fixed line length exceding 100 characters warnings

Gunther Huebler at 6:25 PM 11/21/17

Changed the arrangement of variables in the subroutine compute_mixing_length as well as calls to it clubb:ticket:815

Gunther Huebler at 5:54 PM 12/1/17

Fixed lines exceeding 100 characters warnings clubb:ticket:815

Gunther Huebler at 11:59 AM 12/4/17

I added an option to incorporate the buoyancy term into CLUBB's eddy diffusivity for momentum.

Vince Larson at 11:26 AM 12/12/17

I added c_K10 as a tuning parameter in front of the new momentum eddy diffusivity.

Vince Larson at 11:35 AM 12/12/17

Removed unused parameters to clear warnings clubb:ticket:803

Gunther Huebler at 7:37 PM 1/4/18

I multiplied the eddy diffusivity for momentum by a skewness-dependent factor

Vince Larson at 4:53 PM 1/8/18

I changed the way that F_rt and F_thl are set in the new PDF. They are now set

bmg2 at 11:51 PM 1/8/18

I changed the flag setting on the new PDF so that it always uses w as the setter

bmg2 at 11:59 PM 1/8/18

Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803

Gunther Huebler at 6:50 PM 1/17/18

Improved binary search algorithm clubb:ticket:818

Gunther Huebler at 7:08 PM 1/19/18

Added warning messages to function binary_search clubb:ticket:818

Gunther Huebler at 4:47 PM 1/22/18

Removed unused variables causing warnings clubb:ticket:803

Gunther Huebler at 5:01 PM 1/22/18

I updated the call to the new PDF so that Skrt and Skthl are intent INOUT

bmg2 at 12:25 AM 1/23/18

Removed many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803

Gunther Huebler at 4:23 PM 1/24/18

I am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90. This

bmg2 at 3:08 PM 1/25/18

I finished adding the units to the variable descriptions in

bmg2 at 3:13 PM 1/25/18

The calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>,

bmg2 at 4:58 PM 1/25/18

I added the tunable or adjustable parameters for the new PDF to CLUBB's list

bmg2 at 6:03 PM 1/27/18

Fixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803

Gunther Huebler at 6:29 PM 2/5/18

I am committing a line of code that limits the adjusted correlation of rt and

bmg2 at 11:28 PM 2/6/18

I implemented a new method to handle cumulus momentum fluxes.

Vince Larson at 2:20 PM 2/9/18

Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804

Gunther Huebler at 7:56 PM 2/21/18

Removed file anl_erf.F90, it is no longer used

Gunther Huebler at 7:59 PM 2/21/18

I am altering the solution to the wp3 predictive equation to calculate the

bmg2 at 1:26 AM 2/27/18

I fixed the problem with the wp3 budgets as a result of r8584. The budgets in

bmg2 at 10:35 PM 2/27/18

I altered the names of the turbulent advection functions that are closed by

bmg2 at 3:47 PM 3/1/18

I added a couple comments about how the discretization of the turbulent

bmg2 at 4:01 PM 3/1/18

I added the function that sets up the implicit calculation of the wp3 turbulent

bmg2 at 1:42 AM 3/2/18

I added a function that calculates the explicit form of the wp3 turbulent

bmg2 at 8:35 PM 3/2/18

I am adding a function to calculate the turbulent advection of wpxp explicitly.

bmg2 at 2:22 PM 3/5/18

I am adding a function to calculate the turbulent advection of xp2 and xpyp

bmg2 at 3:55 PM 3/5/18

I interfaced the wp3 explicit turbulent advection code with CLUBB. It is

bmg2 at 10:26 PM 3/5/18

I am interfacing the wpxp explicit turbulent advection option with the rest of

bmg2 at 11:45 PM 3/6/18

I fixed a small bug with the explicit turbulent advection option for wpxp.

bmg2 at 2:00 PM 3/7/18

I am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code.

bmg2 at 4:39 PM 3/7/18

I added the l_explicit_turbulent_adv_* family of flags to the new PDF, for some

bmg2 at 5:31 PM 3/8/18

I am packing up the implicit coefficients and explicit terms calculated by the

bmg2 at 4:50 PM 3/13/18

Made epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804

Gunther Huebler at 6:15 PM 3/13/18

I made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90.

bmg2 at 1:36 PM 3/14/18

I have completed interfacing the implicit form of the wp3 turbulent advection

bmg2 at 5:38 PM 3/14/18

When the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advection

bmg2 at 6:11 PM 3/14/18

I cleaned up the Skx_module and added an additional function,

bmg2 at 3:52 PM 3/15/18

I fixed a bug in the calculation of scalar skewness. It was being set to 0,

bmg2 at 5:02 PM 3/15/18

I moved the location of the LG 2005 ansatz to calculate xp3 because it would be

bmg2 at 5:20 PM 3/15/18

I reverted clubb:r8611 because (1) having the code in the other location

bmg2 at 8:48 PM 3/16/18

I have added a new function, term_ta_new_pdf_lhs, to

bmg2 at 6:31 PM 3/19/18

I have linked the implicit turbulent advection code for rtp2 and thlp2 to the

bmg2 at 10:37 PM 3/20/18

I have added a new file that has two options for handling the xp3 term for

bmg2 at 10:46 PM 3/24/18

I have interface the new xp3 code to the rest of CLUBB. It can be turned on

bmg2 at 12:00 AM 3/25/18

I added a driver level subroutine for the new advance xp3 code. This will make

bmg2 at 3:28 PM 3/28/18

I added budget stats for rtp3 and thlp3 to CLUBB.

bmg2 at 5:28 PM 3/28/18

I am adding code that allows the turbulent advection of wpxp to be treated

bmg2 at 6:32 PM 4/6/18

Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code.

Gunther Huebler at 3:52 PM 4/19/18

Various small comment removals and returned some functionality to api interface clubb:ticket:800

Gunther Huebler at 6:41 PM 4/20/18

A variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800

Gunther Huebler at 6:51 PM 4/24/18

This is the first part of a two-part change. I am updating plotgen plots so

bmg2 at 3:51 PM 4/25/18

In part 2 of this two part commit, I have added rc_coef to the list of

bmg2 at 11:12 PM 4/25/18

Various debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800

Gunther Huebler at 6:35 PM 4/26/18

Check negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800

Gunther Huebler at 6:09 PM 4/27/18

I'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800

Gunther Huebler at 7:19 PM 5/1/18

Changed calls to parameterization check to work with the new check negative implementation clubb:ticket:800

Gunther Huebler at 7:22 PM 5/1/18

Gunther Huebler at 7:23 PM 5/1/18

Removed rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800

Gunther Huebler at 2:19 PM 5/2/18

Changed error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800

Gunther Huebler at 4:43 PM 5/3/18

Fixed unused variable warnings related to error code changes

Gunther Huebler at 5:22 PM 5/3/18

I am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to account

bmg2 at 6:35 PM 5/4/18

Added error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to keep track of error messages is multithreaded scenarios clubb:ticket:800

Gunther Huebler at 12:57 PM 5/7/18

In r8659, I accidentally overwrote some code. This commit restores the prior

bmg2 at 2:53 PM 5/8/18

bmg2 at 2:54 PM 5/8/18

Added clubb debug level checks to error checking statements clubb:ticket:800

Gunther Huebler at 3:21 PM 5/10/18

Changed many stop commands to return commands and added more err_code checks clubb:ticket:800

Gunther Huebler at 7:57 PM 5/11/18

Reverted api changes that broke SAM and WRF

Gunther Huebler at 6:32 PM 5/15/18

I am adding the semi-implicit formulation of wprtpthlp, which is the turbulent

bmg2 at 3:19 PM 5/21/18

I am adding output statistics for the implicit and semi-implicit coefficients

bmg2 at 1:52 PM 5/22/18

I corrected the units on a couple of implicit coefficients.

bmg2 at 1:56 PM 5/22/18

bmg2 at 6:35 PM 5/24/18

Removed failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800

Gunther Huebler at 8:07 PM 5/24/18

Removed reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800

Gunther Huebler at 7:33 PM 5/25/18

I am fixing a bug with the CLUBB tuner. Variables that were allocated at the

bmg2 at 1:07 PM 5/31/18

Completed the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800

Gunther Huebler at 1:47 PM 5/31/18

Made all debug levels produce the same output, see clubb:ticket:823

Gunther Huebler at 1:56 PM 6/5/18

I am moving type variable implicit_coefs_terms from new_pdf_main.F90 to

bmg2 at 3:04 PM 6/7/18

Modified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802

Gunther Huebler at 8:09 PM 6/14/18

Added checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802

Gunther Huebler at 11:02 PM 6/15/18

This should fix the thlm out of bounds error on clubb:ticket:828

Gunther Huebler at 11:11 PM 6/15/18

I changed the name of type variable new_pdf_implct_coefs_terms to

bmg2 at 1:46 PM 6/18/18

Changed T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828

Gunther Huebler at 5:04 PM 6/18/18

I added a flag option to clip the (large, negative) effects of microphysics on

bmg2 at 9:37 AM 6/25/18

I added a flag option to calculate the minimum threshold for xp2 (rtp2 and

bmg2 at 12:20 PM 6/25/18

I added a special max magnitude correlation for fluxes wprtp and wpthlp. This

bmg2 at 1:00 PM 6/26/18

Made better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more information

Gunther Huebler at 10:17 PM 6/28/18

This commit sets C8b=0.02, changes the non-linear damping on wp3

Vince Larson at 2:25 PM 7/2/18

Added a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829

Gunther Huebler at 7:28 PM 7/5/18

I am adding a general purpose function for the turbulent advection of CLUBB's

bmg2 at 5:43 PM 7/6/18

I added/changed a couple comments for the rhs portion of the generalized

bmg2 at 5:58 PM 7/6/18

The turbulent advection file that handles turbulent advection for predictive

bmg2 at 1:53 PM 7/9/18

I added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, that

bmg2 at 5:48 PM 7/10/18

Whoops, I forgot to make wpxpyp_zm and xpyp intent (in).

bmg2 at 5:53 PM 7/10/18

Added functionality to make the hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830

Gunther Huebler at 10:18 PM 7/12/18

I am updating the code that advances predictive variances and covariances in

bmg2 at 11:54 PM 7/12/18

Renamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830

Gunther Huebler at 2:04 PM 7/16/18

I am updating the code that advances predictive scalar fluxes (<w'x'>) in

bmg2 at 4:00 PM 7/18/18

As a first step toward having code that can clip mean values of hydrometeor

bmg2 at 6:12 PM 7/18/18

init_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562

Gunther Huebler at 8:32 PM 7/18/18

I have now interfaced the subroutine that I made out of the code that clips

bmg2 at 2:58 PM 7/19/18

I added new code that clips the overall correlation of w and rt or the overall

bmg2 at 12:09 AM 7/25/18

I added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which are

bmg2 at 4:35 PM 7/25/18

Made clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800

Gunther Huebler at 9:29 PM 7/25/18

Reverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800

Gunther Huebler at 9:33 PM 7/25/18

Fixed nightly tests

Gunther Huebler at 12:38 PM 7/26/18

I have added code to allow C2 to be adjusted by multiplying by the greater of

bmg2 at 4:27 PM 7/27/18

I moved the location of the declaration and setting of new model flags to

bmg2 at 6:26 PM 7/28/18

Improved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834

Gunther Huebler at 5:54 PM 7/31/18

Fixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834

Gunther Huebler at 7:32 PM 8/1/18

Actually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834

Gunther Huebler at 1:59 PM 8/2/18

Optimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834

Gunther Huebler at 3:29 PM 8/7/18

Reverted stats_clubb_utilities, accidental commit

Gunther Huebler at 3:30 PM 8/7/18

This should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837

Gunther Huebler at 8:21 PM 8/8/18

Vince Larson at 10:55 AM 8/9/18

Impoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834

Gunther Huebler at 7:36 PM 8/10/18

This commit implements the effects of splatting on wp3.

Vince Larson at 5:54 PM 8/11/18

I am making the first step toward committing code that allows for the option

bmg2 at 11:10 PM 8/13/18

I added code to allow the option of predicting upwp and vpwp by using the

bmg2 at 12:00 AM 8/14/18

I took the liberty of upgrading CLUBB's PDF closure and related code to a vector

bmg2 at 1:15 PM 8/14/18

I updated the monotonic flux limiter to account for vector variables u and v.

bmg2 at 3:25 PM 8/14/18

I am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output.

bmg2 at 4:38 PM 8/14/18

In r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic flux

bmg2 at 4:42 PM 8/14/18

I am turning on the l_predict_upwp_vpwp code!

bmg2 at 5:18 PM 8/14/18

Improved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834

Gunther Huebler at 3:53 PM 8/15/18

Improved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834

Gunther Huebler at 4:57 PM 8/15/18

Changed the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834

Gunther Huebler at 5:50 PM 8/15/18

Added grid_class to the dependency lists of the pdf files that were changed in commit 8773

Gunther Huebler at 2:35 PM 8/16/18

Accidental commit, undoing 8783

Gunther Huebler at 2:37 PM 8/16/18

I am changing the default setting of flags l_min_wp2_from_corr_wx and

Brian Griffin at 11:22 AM 8/28/18

Modified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834

Gunther Huebler at 5:41 PM 8/29/18

Removed print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases.

Gunther Huebler at 6:32 PM 8/29/18

Changed the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834

Gunther Huebler at 8:07 PM 8/29/18

I am adding source code for the introduction of budgets for predictive upwp

Brian Griffin at 1:51 PM 8/30/18

Improved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834

Gunther Huebler at 6:33 PM 8/30/18

Improved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834

Gunther Huebler at 7:56 PM 8/30/18

Modified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834

Gunther Huebler at 5:05 PM 8/31/18

Copied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834

Gunther Huebler at 6:13 PM 8/31/18

Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834

Gunther Huebler at 7:14 PM 8/31/18

Improved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834

Gunther Huebler at 8:29 PM 9/4/18

I made the surface splatting terms conservative. That is, I subtracted from wp2_sfc

Vince Larson at 3:38 PM 9/13/18

I added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2.

Vince Larson at 12:10 PM 9/17/18

This commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero). Hence it is BIT_CHANGING.

Vince Larson at 10:22 AM 9/21/18

Added functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834

Gunther Huebler at 3:39 PM 9/21/18

Update advance_clubb_core_module.F90

noreply at 4:06 PM 9/24/18

I clipped sigma_sqd_w to prevent interpolated values of it

Vince Larson at 3:17 PM 10/7/18

I added a new option to diagnose the dissipation time scale, tau, first

Vince Larson at 12:15 PM 10/16/18

I found a new way to diagnose upthvp. Instead of using a bound on correlations, it relies

Vince Larson at 3:32 PM 10/31/18

introducing error into clubb core for testing larson-group/sys_admin#533

mcfadd34 at 9:32 AM 11/9/18

reverting error that was introduced larson-group/sys_admin#533

mcfadd34 at 12:31 PM 11/9/18

I am briefly changing some of the flag and parameter settings in CLUBB

bmg2 at 1:44 PM 11/13/18

Revert "I am briefly changing some of the flag and parameter settings in CLUBB"

bmg2 at 2:02 PM 11/13/18

I added a couple of comments reminding users to change the conditions in

bmg2 at 4:55 PM 11/21/18

Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""

bmg2 at 5:51 PM 12/5/18

Revert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"""

bmg2 at 6:01 PM 12/5/18

I committed a subroutine, diagnose_upxp, that calculates

Vince Larson at 12:05 PM 12/18/18

Improved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834

Gunther Huebler at 6:39 PM 12/20/18

I am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a large

bmg2 at 7:01 PM 12/22/18

I am updating the code within setup_clubb_pdf_parameters.F90 in order to take

bmg2 at 4:30 PM 1/2/19

To diagnose uprcp using CLUBB's PDF machinery,

Vince Larson at 12:24 PM 1/3/19

Continuing with diagnosis of uprcp using CLUBB's PDF,

Vince Larson at 11:52 AM 1/4/19

More code to diagnose uprcp using CLUBB's PDF.

Vince Larson at 12:10 PM 1/5/19

Correction for the last uprcp-related commit:

Vince Larson at 1:04 PM 1/5/19

I am correcting the code so that the Nightly Uninitialized Variables Test

bmg2 at 5:25 PM 1/8/19

I am continuing to pull parts of setup_pdf_parameters outside of a large "do"

bmg2 at 5:13 PM 1/9/19

I am pulling statistical output subroutine pdf_param_ln_hm_stats outside

bmg2 at 12:53 PM 1/10/19

Changing the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope.

Gunther Huebler at 6:25 PM 1/11/19

commenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566

mcfadd34 at 9:35 AM 1/15/19

uncommenting threadprivate larson-group/sys_admin#566

mcfadd34 at 10:27 AM 1/15/19

I have changed the structure of setup_pdf_parameters so that the subroutine that

bmg2 at 5:10 PM 1/15/19

Returned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING.

Gunther Huebler at 3:02 PM 1/17/19

I am turning on the new calculation of uprcp that uses CLUBB's PDF.

Vince Larson at 4:18 PM 1/18/19

I modified the code in setup_clubb_pdf_params.F90 to use only one call to

bmg2 at 4:11 PM 1/24/19

I am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch to

bmg2 at 7:24 AM 1/30/19

I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch

bmg2 at 11:28 AM 1/30/19

I temporarily set l_clip_extreme_chi_sample_pts back to false in the

bmg2 at 3:59 PM 1/30/19

Revert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the"

bmg2 at 10:31 AM 2/9/19

I improved the error messages when LU decomp. fails within

bmg2 at 5:16 PM 3/8/19

Improved error message prints in advance_xm_wpxp.

bmg2 at 1:21 PM 3/13/19

I added improved LHS and RHS print statements when a LU decomp. error occurs

bmg2 at 10:34 PM 3/13/19

I added params_list to the list of variables that are accessible through

bmg2 at 11:11 PM 3/13/19

I am making the first step for updating the code that calculates sigma_sqd_w.

bmg2 at 12:45 PM 3/28/19

I added a log-law height dependence to the code that diagnoses

Vince Larson at 4:41 PM 3/30/19

I added fill_holes_hydromet_api to clubb_api_module.F90.

bmg2 at 9:40 PM 4/24/19

I added a new python script, check_for_missing_threadprivate.py,

Vince Larson at 9:54 AM 5/21/19

Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834

Gunther Huebler at 4:39 PM 5/28/19

Fixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834

Gunther Huebler at 6:49 PM 5/29/19

Added temp test file

noreply at 9:36 AM 5/31/19

Remove test file

noreply at 9:46 AM 5/31/19

Adding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical.

Gunther Huebler at 6:57 PM 6/28/19

Optimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases.

Gunther Huebler at 6:08 PM 7/1/19

ticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequency

guozhun at 2:40 PM 7/3/19

Modifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855

Gunther Huebler at 6:37 PM 7/11/19

Replacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855

Gunther Huebler at 1:41 PM 7/12/19

Making procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855

Gunther Huebler at 7:04 PM 7/12/19

Gunther Huebler at 7:08 PM 7/12/19

I have added a new file, calc_pressure.F90, which contains code for initializing

bmg2 at 8:00 PM 7/16/19

I updated CLUBB so that pressure is updated after mean fields have been

bmg2 at 9:19 PM 7/17/19

Removing gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855

Gunther Huebler at 5:15 PM 7/22/19

Forgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855

Gunther Huebler at 6:38 PM 7/22/19

guozhun at 5:15 PM 7/23/19

We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively.

guozhun at 11:43 AM 7/24/19

We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively.

guozhun at 11:43 AM 7/24/19

We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842)

guozhun at 11:46 AM 7/24/19

We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842)

guozhun at 11:46 AM 7/24/19

Update tunable_parameters.in

noreply at 11:55 AM 7/24/19

Update advance_clubb_core_module.F90

noreply at 12:22 PM 7/24/19

We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly)

guozhun at 6:45 PM 7/25/19

We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly)

guozhun at 6:45 PM 7/25/19

Efficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855

Gunther Huebler at 1:47 PM 7/26/19

This should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855

Gunther Huebler at 2:06 PM 7/29/19

An additional damping is added to the invrs_tau term in the C8 equation. ticket #842

guozhun at 2:15 PM 7/29/19

An additional damping is added to the invrs_tau term in the C8 equation. ticket #842

guozhun at 2:15 PM 7/29/19

Adding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations.

Gunther Huebler at 3:12 PM 7/29/19

We use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8.

guozhun at 7:21 PM 7/30/19

Changing ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855

Gunther Huebler at 2:24 PM 7/31/19

Pulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855

Gunther Huebler at 5:20 PM 7/31/19

Renaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855

Gunther Huebler at 5:23 PM 7/31/19

Efficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855.

Gunther Huebler at 4:51 PM 8/1/19

Modifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855

Gunther Huebler at 8:12 PM 8/1/19

Refactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855

Gunther Huebler at 6:17 PM 8/7/19

Update advance_clubb_core_module.F90

noreply at 5:36 PM 8/8/19

Update advance_clubb_core_module.F90

noreply at 5:39 PM 8/8/19

I switched on direct diagnosis of tau rather than Lscale.

Vince Larson at 3:23 PM 8/9/19

I switched on direct diagnosis of tau rather than Lscale.

Vince Larson at 3:23 PM 8/9/19

I updated the pressure initialization for cases that use sounding that is given

bmg2 at 11:30 AM 8/12/19

I changed the function calculate_thvm from a pre-defined vector of size nz to

bmg2 at 2:43 PM 8/12/19

I updated the calculation of thvm in advance_clubb_core to use the

bmg2 at 3:07 PM 8/12/19

Adding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler.

Gunther Huebler at 5:52 PM 8/12/19

Adding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855

Gunther Huebler at 7:57 PM 8/12/19

Changing where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626

Gunther Huebler at 3:12 PM 8/14/19

I am committing a test where I changed subroutine ADG1_w_closure

bmg2 at 11:33 AM 8/15/19

Changing determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862

Gunther Huebler at 2:42 PM 8/21/19

Finally fixing line length error in pdf_closure

Gunther Huebler at 5:55 PM 8/21/19

Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861

Gunther Huebler at 6:37 PM 8/23/19

Adding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862

Gunther Huebler at 2:16 PM 8/28/19

This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc.

guozhun at 6:06 PM 9/6/19

This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc.

guozhun at 6:06 PM 9/6/19

Update advance_helper_module.F90

noreply at 12:26 PM 9/8/19

Update advance_clubb_core_module.F90

noreply at 12:28 PM 9/8/19

Update advance_helper_module.F90

noreply at 10:46 AM 9/9/19

Adding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626

Gunther Huebler at 12:17 PM 9/9/19

I am adding a file for the new hybrid PDF, which combines the w equation set

bmg2 at 3:58 PM 9/16/19

I updated the function to calculate the implicit coefficient for the wp4 term,

bmg2 at 5:19 PM 9/16/19

I made some changes to new_hybrid_pdf.F90 so that it would compile in its

bmg2 at 9:11 AM 9/17/19

I edited that subroutine that calculates the implicit coefficient and explicit

bmg2 at 1:13 PM 9/17/19

I updated the subroutine that calculates the implicit coefficient and explicit

bmg2 at 5:22 PM 9/17/19

Replaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves.

nselke at 9:39 AM 9/20/19

I am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the new

bmg2 at 11:11 AM 9/24/19

I worked more the functions for the new hybrid PDF.

bmg2 at 1:04 PM 9/26/19

Refactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855

Gunther Huebler at 5:07 PM 10/4/19

I changed all the PDF utility functions in pdf_utilities.F90 to elemental

bmg2 at 7:50 AM 10/8/19

I forgot a "then" to go with an "elseif".

bmg2 at 8:24 AM 10/8/19

Adding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855

Gunther Huebler at 4:29 PM 10/8/19

Adding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855

Gunther Huebler at 7:13 PM 10/8/19

Refactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855

Gunther Huebler at 4:57 PM 10/11/19

I am continuing to build the driver subroutine for the new hybrid PDF.

bmg2 at 9:04 AM 10/15/19

I am continuing to work on the driver file for the new hybrid PDF.

bmg2 at 11:51 AM 10/16/19

I have completed the main parts of the driver subroutine for the new hybrid PDF.

bmg2 at 7:45 AM 10/17/19

The code for the new hybrid PDF now compiles.

bmg2 at 9:57 AM 10/17/19

I added an entry for the new hybrid PDF.

bmg2 at 9:59 AM 10/17/19

I have added the new hybrid PDF to the G unit tests.

bmg2 at 2:08 PM 10/17/19

Mathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0.

bmg2 at 3:44 PM 10/17/19

I added code to interface the call to the new hybrid PDF with pdf_closure

bmg2 at 11:36 AM 10/18/19

I interfaced the implicit coefficients and explicit terms used in the turbulent

bmg2 at 7:07 PM 10/19/19

I fixed a small error. The code compiles again now.

bmg2 at 7:12 PM 10/19/19

Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group

pbroels at 12:01 PM 10/24/19

I have added code that allows CLUBB to run interactively using the new hybrid

bmg2 at 5:35 PM 10/24/19

I am updating the subroutine that calculates PDF component means and standard

bmg2 at 11:07 AM 10/25/19

I placed proper thresholding on interpolated up2 and interpolated vp2

bmg2 at 3:01 PM 10/25/19

I added a limiter to keep the maximum magnitude of the correlations of

bmg2 at 4:41 PM 10/25/19

I upgraded Nc_Ncn_eqns.F90 to use elemental functions.

bmg2 at 8:20 AM 10/26/19

The new hybrid PDF also uses this bit of code that sets the correlation

bmg2 at 8:44 AM 10/26/19

I made modifications to the new hybrid PDF so that that calculation of F_w

bmg2 at 9:03 AM 10/29/19

I added the ability to handle scalars interactively to the new hybrid PDF.

bmg2 at 3:33 PM 10/30/19

I found a couple of spots in the new hybrid PDF where I needed to add

bmg2 at 4:37 PM 10/30/19

I added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90.

bmg2 at 5:50 PM 10/30/19

I am setting the zeta variance ratio to 1 (symmetric design) by

bmg2 at 9:04 AM 10/31/19

The variable type implicit_coefs_terms needs to be made public

bmg2 at 5:04 PM 10/31/19

I changed the value of the coefficient in the F_w equation to 0.45

bmg2 at 6:49 PM 10/31/19

I am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_core

bmg2 at 10:19 AM 11/2/19

I have started the process of adding the coding infrastructure

bmg2 at 1:57 PM 11/8/19

I have completed the addition of the ability to use different up2

bmg2 at 8:57 AM 11/9/19

I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856

nselke at 3:28 PM 11/12/19

I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856

nselke at 3:28 PM 11/12/19

I made the l_calc_w_corr code (turned off by default) run again by

bmg2 at 4:19 PM 11/12/19

I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute.

nselke at 10:54 AM 11/14/19

I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute.

nselke at 10:54 AM 11/14/19

I have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac',

nselke at 4:51 PM 11/14/19

I continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm',

nselke at 12:36 PM 11/15/19

I continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm',

nselke at 5:08 PM 11/15/19

I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp',

nselke at 12:55 PM 11/21/19

Finished altering argument lists. This commit covers the final seven flags, which are in different namelists.

nselke at 6:12 PM 11/21/19

I introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type.

nselke at 10:26 AM 11/26/19

I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856

nselke at 4:52 PM 12/10/19

I fed pdf_params_frz into subroutine advance_clubb_core

Vince Larson at 12:53 PM 12/13/19

Adding error code to arguement list of non-api routines where it was included in the api version.

Gunther Huebler at 7:56 PM 12/13/19

Moving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal.

Gunther Huebler at 4:31 PM 12/17/19

Added use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public.

Steffen Domke at 2:10 PM 12/18/19

I have fixed the warnings for lines exceeding 100 characters.

nselke at 9:27 AM 12/20/19

Passing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity.

Gunther Huebler at 4:29 PM 12/20/19

Trivial update to test if cams autoupdate works

noreply at 2:00 PM 1/9/20

Revert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch"

bmg2 at 12:14 AM 1/11/20

I placed E3SM preprocessor commands around E3SM-specific code in

bmg2 at 3:18 PM 1/14/20

Restoring assertion check for the vertical correlation calculation. larson-group/clubb#869

Gunther Huebler at 3:01 PM 1/15/20

Changing the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869

Gunther Huebler at 7:39 PM 1/15/20

I added E3SM's clubb_ parameters that can be read in from the

bmg2 at 2:44 PM 1/16/20

I added the remainder the clubb_ terms that were added previously to

bmg2 at 4:53 PM 1/16/20

Changing error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869

Gunther Huebler at 3:38 PM 1/21/20

Small updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869

Gunther Huebler at 11:38 AM 1/22/20

Redoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869

Gunther Huebler at 12:02 PM 1/22/20

Adding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869

Gunther Huebler at 2:18 PM 1/24/20

Simple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869

Gunther Huebler at 2:58 PM 1/24/20

Small performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869

Gunther Huebler at 1:29 PM 1/28/20

Removing lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869

Gunther Huebler at 5:15 PM 1/28/20

Update latin_hypercube_driver_module.F90

noreply at 1:55 PM 1/30/20

Update parameters_tunable.F90

noreply at 1:56 PM 1/30/20

GPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869

Gunther Huebler at 2:51 PM 2/6/20

Making some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869

Gunther Huebler at 5:14 PM 2/6/20

I changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874

nselke at 5:20 PM 2/14/20

I added the new l_update_pressure configurable flag to clubb_config_flags.

bmg2 at 8:58 AM 2/15/20

I added the new l_update_pressure configurable flag to clubb_config_flags.

bmg2 at 8:58 AM 2/15/20

I added some code I used in the special input fields branch to make

bmg2 at 1:47 PM 2/20/20

An improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875]

guozhun at 10:44 AM 3/14/20

I revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874.

nselke at 11:42 AM 3/14/20

I got rid of the "allocatable", "allocate", and "deallocate" statements

bmg2 at 12:29 PM 3/19/20

I placed an ifndef CLUBB_CAM preprocessor flag around the code in

bmg2 at 12:40 AM 3/20/20

I reduced the minimum possible value of lmin from 4.0 to 1.0.

noreply at 8:39 AM 3/30/20

I made a print/write statement debug level 3

noreply at 11:40 AM 3/30/20

I made a second print/write statement debug level 3

noreply at 11:44 AM 3/30/20

I fix a print/write statement debug level3. For #755 and #800

guozhun at 11:51 AM 3/30/20

I am replacing the "use" statements that referenced

bmg2 at 4:05 PM 4/13/20

I "brought back the stats" by passing the stats from advance_clubb_core

bmg2 at 8:24 PM 4/13/20

Removing the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref)

bmg2 at 1:29 PM 4/14/20

Results were changed yesterday for some cases because thlprcp was

bmg2 at 3:20 PM 4/14/20

I have resolved all the issues surrounding recent CLUBB commits that

bmg2 at 6:37 PM 4/15/20

I removed code that stops a run if the output time step is less than a minute.

noreply at 5:07 PM 4/25/20

I removed references to variables_prognostic_module and

bmg2 at 6:07 PM 4/29/20

Fixed a boo-boo.

bmg2 at 3:43 PM 4/30/20

I set `l_diag_Lscale_from_tau = .true.` in source code

noreply at 5:00 PM 4/30/20

I removed references to variable_diagnostic_module for various Kessler

bmg2 at 3:59 PM 5/4/20

I removed the reference to use variables_diagnostic_module for Kh_zm

bmg2 at 5:43 PM 5/4/20

Removed a reference to variables_diagnostic_module for Kh_zm in

bmg2 at 6:42 PM 5/4/20

I am able to remove references to variables_prognostic_module and

bmg2 at 7:12 PM 5/4/20

I removed the l_use_ice_latent flag from the code, and along with it

bmg2 at 11:49 AM 5/5/20

I removed the l_use_ice_latent flag from the code, and along with it

bmg2 at 11:49 AM 5/5/20

I have completed the project of removing variables_prognostic_module

bmg2 at 7:41 PM 5/8/20

I added some missing threadprivate statements

noreply at 6:40 PM 5/10/20

I have taken the code from wp2_term_ta_all and placed it in the subroutine

bmg2 at 7:43 PM 5/18/20

I am updating wp3_term_ta_new_pdf_lhs to use the optimized code from

bmg2 at 5:58 PM 5/19/20

This commit is BIT_CHANGING. It makes the parameter values in parameters_tunable.F90 agree with those in tunable_parameters.in

benjamin.andrew.stephens at 10:07 AM 5/27/20

I am making the change of using tau_wp2_zm to damp up2 and vp2,

bmg2 at 2:36 PM 6/3/20

I have added the integer flags iiPDF_type and ipdf_call_placement

bmg2 at 11:20 AM 6/11/20

I have added the integer flags iiPDF_type and ipdf_call_placement

bmg2 at 11:20 AM 6/11/20

I am going to make primary PDF type options and primary PDF call

bmg2 at 2:49 PM 6/11/20

I added E3SM customizations to CLUBB's master branch. This is meant

bmg2 at 3:34 PM 6/15/20

I am updating the clubb_ list of namelist parameters used in E3SM

bmg2 at 12:01 PM 6/18/20

bmg2 at 12:06 PM 6/18/20

Fixed more typos

bmg2 at 12:11 PM 6/18/20

I am changing the new hybrid PDF's calculation of F_w to use

bmg2 at 4:52 PM 6/18/20

I updated the xp3 calculation for PDF types other than ADG1.

bmg2 at 3:27 PM 6/22/20

This xp3_coef_ parameters produce new hybrid PDF results similar to the old

bmg2 at 9:32 AM 6/23/20

I added the 2 new parameters in the simple xp3 equation (for PDF

bmg2 at 1:33 PM 6/23/20

I added the 2 new parameters in the simple xp3 equation (for PDF

bmg2 at 1:33 PM 6/23/20

I have combined the wp3_term_ta_ADG1_lhs and wp3_term_ta_ADG1_lhs_all

bmg2 at 3:10 PM 7/9/20

I added the partially upwinded implementation of the wp3 turbulent advection

bmg2 at 7:16 PM 7/9/20

Removed unused module imports

isenfireldc at 11:24 PM 7/9/20

Removed unused module imports

isenfireldc at 11:24 PM 7/9/20

Removed a comma that I missed while removing unused imports (#878)

isenfireldc at 12:23 AM 7/10/20

I am adding l_partial_upwind_wp3 to the list of clubb_config_flags.

bmg2 at 1:30 PM 7/10/20

I am adding l_partial_upwind_wp3 to the list of clubb_config_flags.

bmg2 at 1:30 PM 7/10/20

Deprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129

Gunther Huebler at 6:33 PM 7/14/20

Adding clubb case files that were missed from last commit larson-group/cam#129

Gunther Huebler at 12:58 PM 7/15/20

I started the process of paring 2 subprograms back down to 1 in

bmg2 at 3:29 PM 7/15/20

I pared two more sets of equivalent subprograms down to 1 (each).

bmg2 at 4:55 PM 7/15/20

Paring down 2 equivalent subprograms to 1 again.

bmg2 at 6:35 PM 7/15/20

I condensed two more sets of doubled subprograms down to 1 (each)

bmg2 at 1:22 AM 7/17/20

Reduced two more sets of "doubled" subprograms down.

bmg2 at 1:20 PM 7/17/20

Updating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129

Gunther Huebler at 5:09 PM 7/17/20

Adding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129

Gunther Huebler at 5:59 PM 7/17/20

I updated CLUBB's copyright date range.

noreply at 9:58 AM 7/19/20

Adding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129

Gunther Huebler at 4:10 PM 7/20/20

Removed unused parameters [-Wunused-parameter]

isenfireldc at 11:12 AM 7/21/20

Removed unused parameters [-Wunused-parameter]

isenfireldc at 11:12 AM 7/21/20

Taking more duplicated subprograms and paring them down to 1.

bmg2 at 1:13 PM 7/22/20

Replaced real checks with an epsilon approach [-Wcompare-reals]

isenfireldc at 4:16 PM 7/22/20

Replaced real checks with an epsilon approach [-Wcompare-reals]

isenfireldc at 4:16 PM 7/22/20

Removed unused imports [-Wunused-parameter]

isenfireldc at 5:16 PM 7/22/20

Removed unused imports [-Wunused-parameter]

isenfireldc at 5:16 PM 7/22/20

Removed styleguide violations from my code

isenfireldc at 5:45 PM 7/22/20

Fixed a backwards epsilon comparison from 8e8e71e

isenfireldc at 11:05 AM 7/23/20

Removed the "doubling" of the remainder of the subprograms from

bmg2 at 12:37 PM 7/23/20

Changing epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878

Gunther Huebler at 4:41 PM 7/23/20

Small changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129

Gunther Huebler at 5:39 PM 7/23/20

Changed the length of solve_type_str to 20 [-Wcharacter-trucation]

isenfireldc at 11:31 AM 7/24/20

Removed unused arguments [-Wunused-dummy-argument]

isenfireldc at 2:39 PM 7/24/20

Removed unused arguments [-Wunused-dummy-argument]

isenfireldc at 2:39 PM 7/24/20

Removed unused variables [-Wunused-variable]

isenfireldc at 3:26 PM 7/24/20

Removed unused variables [-Wunused-variable]

isenfireldc at 3:26 PM 7/24/20

I have tidied up advance_wp2_wp3_module.F90, and I have removed all doubled

bmg2 at 11:35 PM 7/24/20

Removed continue and undid edits to _api fuction signatures

isenfireldc at 11:29 AM 7/27/20

Removed continue and undid edits to _api fuction signatures

isenfireldc at 11:29 AM 7/27/20

I handled the "doubled" subprograms in turbulent_adv_pdf.F90.

bmg2 at 5:24 PM 7/27/20

Making change explained in larson-group/clubb#878

Gunther Huebler at 6:03 PM 7/28/20

Removed some unused variables (ifort)

isenfireldc at 1:03 PM 7/29/20

Removed some unused variables (ifort)

isenfireldc at 1:03 PM 7/29/20

Adding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129

Gunther Huebler at 5:46 PM 7/29/20

Removed unused import [-Wunused-variable]

isenfireldc at 11:33 AM 7/30/20

Removes unused function calc_cloud_frac [-Wunused-function]

isenfireldc at 4:42 PM 8/5/20

Fixes style issue

isenfireldc at 5:55 PM 8/5/20

Removed import without only as it was unused

isenfireldc at 6:11 PM 8/5/20

Adds mpishorthand back with only, it appears to be used somewhere

isenfireldc at 10:23 AM 8/6/20

I have pared two subprograms down to one again, this time for the

bmg2 at 12:53 PM 8/14/20

I pared down subprogram pairs again, this time for mean advection.

bmg2 at 11:58 AM 8/17/20

I added altitude_threshold to the list of CLUBB's tunable parameters.

bmg2 at 1:39 PM 8/17/20

I added altitude_threshold to the list of CLUBB's tunable parameters.

bmg2 at 1:39 PM 8/17/20

Updating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots.

strike at 3:17 PM 8/19/20

Updating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be).

strike at 2:04 PM 8/20/20

Adds more debug lines

isenfireldc at 5:50 PM 8/24/20

Removes debug lines

isenfireldc at 5:57 PM 8/24/20

Adds debug lines and changes format

isenfireldc at 2:16 PM 8/25/20

Modifies debug line

isenfireldc at 2:38 PM 8/25/20

Modifies debug line

isenfireldc at 3:46 PM 8/25/20

Initialize ncf%ntimes to 0 when opening netcdf for writing

isenfireldc at 3:00 PM 8/26/20

Removes debug lines

isenfireldc at 3:36 PM 8/26/20

Changes length of units variable in stat_file_module from 20 to 25

isenfireldc at 2:16 PM 8/27/20

This commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true. A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines.

benjamin.andrew.stephens at 10:29 AM 9/17/20

Adding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close. This will aid in implementing the SILHS 2D output subroutines in host models. The new API subroutines necessitated some minor changes in clubb_driver.F90 as well. Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo).

benjamin.andrew.stephens at 12:33 PM 9/18/20

I updated the stats code in setup_clubb_pdf_params.F90 and in

bmg2 at 3:25 AM 9/23/20

I updated the stats code in setup_clubb_pdf_params.F90 and in

bmg2 at 3:25 AM 9/23/20

This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information.

benjamin.andrew.stephens at 8:12 AM 9/29/20

This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information.

benjamin.andrew.stephens at 8:12 AM 9/29/20

Undoing accidental find and replace. larson-group/cam#129

Gunther Huebler at 2:29 PM 9/29/20

Updated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832

nchief at 12:23 PM 10/2/20

Fix super serious 1 character bug that broke all of the things

strike at 9:58 AM 10/3/20

I am committing Zhun's changes to the CLUBB portion of his

bmg2 at 7:49 PM 10/8/20

I modified tunable_parameters.in to use some of the parameter values that

bmg2 at 5:29 PM 10/26/20

Update stats_zm_module.F90

noreply at 8:49 AM 11/3/20

I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max

bmg2 at 1:24 PM 11/6/20

I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max

bmg2 at 1:24 PM 11/6/20

I connected the new tunable parameters to advance_helper_module.F90.

bmg2 at 1:30 PM 11/6/20

I added l_use_shear_Richardson to CLUBB's configurable model flags.

bmg2 at 7:06 PM 11/18/20

I added l_use_shear_Richardson to CLUBB's configurable model flags.

bmg2 at 7:06 PM 11/18/20

Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs.

benjamin.andrew.stephens at 8:31 AM 11/23/20

Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs.

benjamin.andrew.stephens at 8:31 AM 11/23/20

I forgot to add rtp2_clip_coef to tunable_parameters.in (this doesn't affect

bmg2 at 12:20 PM 11/25/20

In order to prevent dycoms2_rf02_so from crashing,

Vince Larson at 3:10 PM 11/25/20

I updated the recording of the budget terms for upwp_pr4 and vpwp_pr4.

Vince Larson at 3:16 PM 11/25/20

Adding the smooth_min and smooth_max functions to the repo. These are not yet implemented in CLUBB but are now available for use and testing. See issue #894.

benjamin.andrew.stephens at 1:07 PM 11/30/20

Adding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions. See issue #894.

benjamin.andrew.stephens at 3:49 PM 11/30/20

Modifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129

Gunther Huebler at 2:56 PM 12/1/20

This commit replaces division by tau with multiplication by inverse tau in most cases. It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files. Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine.

benjamin.andrew.stephens at 9:48 AM 12/10/20

I am committing a bug fix to the invrs_tau_zm equation that was

bmg2 at 5:08 PM 12/10/20

CLUBB and pyplotgen changes:

benjamin.andrew.stephens at 4:22 PM 12/14/20

I fixed the LMM stepping bug that was affecting E3SM (because

bmg2 at 6:35 PM 12/16/20

Fixed alignment.

bmg2 at 6:40 PM 12/16/20

This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90.

benjamin.andrew.stephens at 11:12 AM 12/17/20

This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90.

benjamin.andrew.stephens at 11:12 AM 12/17/20

Update parameter_indices.F90

noreply at 3:10 PM 12/17/20

Setting parameters and flags to be consistent with the CLUBB repo prior to the October 8 commit merging some E3SM code (https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). This should help to basically recover the plots from before the merge, which is useful for single-column model testing.

benjamin.andrew.stephens at 2:16 PM 12/18/20

Update model_flags.F90

noreply at 3:01 PM 12/18/20

Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884.

benjamin.andrew.stephens at 12:10 PM 1/11/21

Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884.

benjamin.andrew.stephens at 12:10 PM 1/11/21

Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901.

benjamin.andrew.stephens at 3:04 PM 1/14/21

Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901.

benjamin.andrew.stephens at 3:04 PM 1/14/21

I am now passing vert_decorr_coef into SILHS instead of involving

bmg2 at 10:49 PM 1/14/21

This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39). Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before. I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up).

benjamin.andrew.stephens at 1:51 PM 1/15/21

Adding a test to make sure new C_uu_buoy parameter is within the valid range. See #901.

benjamin.andrew.stephens at 12:02 PM 1/19/21

This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files.

benjamin.andrew.stephens at 3:02 PM 1/20/21

This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files.

benjamin.andrew.stephens at 3:02 PM 1/20/21

This will allow for a better interface of SILHS parameter

bmg2 at 5:00 PM 1/21/21

Fixed a preprocessor command.

bmg2 at 5:11 PM 1/21/21

I'm adding the api entry for read_silhs_parameters, called

bmg2 at 10:14 PM 1/21/21

Revert "I'm adding the api entry for read_silhs_parameters, called"

bmg2 at 3:04 PM 1/25/21

Revert "Fixed a preprocessor command."

bmg2 at 3:04 PM 1/25/21

Revert "This will allow for a better interface of SILHS parameter"

bmg2 at 3:04 PM 1/25/21

I updated silhs_api_module so that vert_decorr_coef is publically available

bmg2 at 3:16 PM 1/25/21

Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902.

benjamin.andrew.stephens at 9:20 AM 1/26/21

Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902.

benjamin.andrew.stephens at 9:20 AM 1/26/21

Update configurable_model_flags.in

noreply at 10:44 AM 1/26/21

Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term.

benjamin.andrew.stephens at 1:38 PM 1/27/21

Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term.

benjamin.andrew.stephens at 1:38 PM 1/27/21

Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129

Gunther Huebler at 3:43 PM 1/27/21

Update parameters_tunable.F90

noreply at 7:22 AM 1/28/21

Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129

Gunther Huebler at 5:19 PM 2/4/21

Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129

Gunther Huebler at 2:08 PM 2/16/21

Changes non-success `stop` statements to `error stop`

Vince Larson at 8:28 PM 2/20/21

Changes non-success `stop` statements to `error stop`

Vince Larson at 8:28 PM 2/20/21

Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902.

59519056+bstephens82 at 1:23 PM 2/26/21

Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902.

59519056+bstephens82 at 1:23 PM 2/26/21

Turning on wp3 pr_turb term.

benjamin.andrew.stephens at 1:14 PM 3/1/21

Turning on wp3 pr_turb term.

benjamin.andrew.stephens at 1:14 PM 3/1/21

Changed the variable up2_vp2_factor to up2_sfc_coef in all files

rhodesk at 5:55 PM 3/6/21

Changed the variable up2_vp2_factor to up2_sfc_coef in all files

rhodesk at 5:55 PM 3/6/21

I added an option to improve dry, convecting boundary layers.

Vince Larson at 3:09 PM 3/9/21

This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2. In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1. This makes the terms in these equations more consistent with the terms in the wp2 equation. I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped).

Vince Larson at 8:08 AM 3/17/21

Changed surface to sfc in all instances where requested

rhodesk at 3:42 PM 3/18/21

Undid sfc change in stats_sfc_module.F90

noreply at 4:23 PM 3/18/21

Undid sfc change to grid_class.F90

noreply at 4:23 PM 3/18/21

Undid sfc change in numerical_check.F90

noreply at 4:24 PM 3/18/21

Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129

Gunther Huebler at 5:02 PM 3/24/21

Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129

Gunther Huebler at 7:34 PM 3/24/21

Fixed typo bug. larson-group/cam#129

Gunther Huebler at 7:34 PM 3/24/21

Pushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129

Gunther Huebler at 4:53 PM 3/26/21

More pushing loops down. All bit-for-bit. larson-group/cam#129

Gunther Huebler at 7:17 PM 3/30/21

More loop pushing. All bit-for-bit. larson-group/cam#129

Gunther Huebler at 4:39 PM 3/31/21

More loop pushing. All bit-for-bit. larson-group/cam#129

Gunther Huebler at 3:20 PM 4/1/21

Adding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129

Gunther Huebler at 2:12 PM 4/6/21

More loop pushing, all bit-for-bit. larson-group/cam#129

Gunther Huebler at 6:28 PM 4/6/21

Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions.

Gunther Huebler at 6:30 PM 4/6/21

Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled.

Gunther Huebler at 1:24 PM 4/7/21

Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129

Gunther Huebler at 4:15 PM 4/8/21

Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129

Gunther Huebler at 6:02 PM 4/8/21

Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129

Gunther Huebler at 6:02 PM 4/8/21

Performance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129

Gunther Huebler at 3:07 PM 4/9/21

Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129

Gunther Huebler at 3:29 PM 4/9/21

Reducing operations. All bit-for-bit. larson-group/cam#129

Gunther Huebler at 3:54 PM 4/9/21

Adding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129

Gunther Huebler at 5:29 PM 4/9/21

Some small cleanup, all just formatting. larson-group/cam#129

Gunther Huebler at 7:27 PM 4/9/21

Changed ustar from an array to a scalar issue #909

rhodesk at 11:27 AM 4/10/21

Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909

rhodesk at 1:24 PM 4/10/21

Created new subroutine and ensured it's BFB. All cases run sucessfully #909

rhodesk at 3:58 PM 4/10/21

added in missing flag which was causing memory errors #909

rhodesk at 10:50 AM 4/17/21

confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909

rhodesk at 12:16 PM 4/17/21

Update stats_zm_module.F90

noreply at 3:11 PM 4/21/21

Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129

Gunther Huebler at 4:39 PM 4/21/21

Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129

Gunther Huebler at 8:16 PM 4/22/21

Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129

Gunther Huebler at 8:16 PM 4/22/21

Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129

Gunther Huebler at 6:24 PM 4/23/21

Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129

Gunther Huebler at 7:13 PM 4/23/21

Reformatted mixing length to be more compliant with the coding standard #909

rhodesk at 3:27 PM 4/27/21

added a reference to new subroutine #909

rhodesk at 3:35 PM 4/27/21

Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129

Gunther Huebler at 3:33 PM 4/29/21

Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129

Gunther Huebler at 3:33 PM 4/29/21

Fixing lines that exceed 100 characters.

Gunther Huebler at 4:34 PM 4/29/21

Fixing lines that exceed 100 characters.

Gunther Huebler at 4:34 PM 4/29/21

Pushing loops related to pdf_params down. larson-group/cam#129

Gunther Huebler at 5:31 PM 4/29/21

clubb warnings introduced from merge have been removed #909

rhodesk at 4:41 PM 5/3/21

Changed safeguard threshold in sigma_sqd_w.

rhodesk at 4:54 PM 5/4/21

Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen.

59519056+bstephens82 at 8:33 AM 5/11/21

Adding new coefficient to control the wp3 pressure diffusion term.

59519056+bstephens82 at 8:33 AM 5/11/21

Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms.

59519056+bstephens82 at 8:33 AM 5/11/21

Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo.

59519056+bstephens82 at 8:33 AM 5/11/21

Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output).

59519056+bstephens82 at 8:33 AM 5/11/21

These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.

59519056+bstephens82 at 8:33 AM 5/11/21

Adding new coefficient to control the wp3 pressure diffusion term.

59519056+bstephens82 at 8:33 AM 5/11/21

Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch.

59519056+bstephens82 at 8:33 AM 5/11/21

These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.

59519056+bstephens82 at 8:33 AM 5/11/21

Added intent comments for the following files:

rhodesk at 3:57 PM 5/11/21

Setting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway.

benjamin.andrew.stephens at 4:26 PM 5/12/21

Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core. Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs). This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated.

benjamin.andrew.stephens at 8:06 PM 5/12/21

Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90.

benjamin.andrew.stephens at 8:13 AM 5/13/21

Fixed comment regarding wp3 splatting term.

benjamin.andrew.stephens at 11:04 AM 5/13/21

Added intent comments.

rhodesk at 1:00 PM 5/22/21

Added intent comments.

rhodesk at 2:16 PM 5/22/21

Added intent comments for advance_xp2_xpyp_module.F90.

rhodesk at 2:53 PM 5/22/21

Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface.

59519056+bstephens82 at 9:04 AM 5/25/21

Deleting comments around the old "magic number" for the near-surface clipping.

59519056+bstephens82 at 9:04 AM 5/25/21

Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928.

Gunther Huebler at 2:50 PM 5/28/21

Changed some elements of clubb to allow for better script execution

rhodesk at 10:42 AM 6/2/21

Fixed clubb not compiling

rhodesk at 11:38 AM 6/2/21

Feeding gr through the arg list where need only in the CLUBB_core dir.

rhodesk at 12:38 PM 6/3/21

Feeding gr through the arg list where need only in the CLUBB_core dir.

rhodesk at 12:38 PM 6/3/21

Reverted changes to clubb_api. For #886

rhodesk at 1:37 PM 6/3/21

Replacing use gr statements with feeding gr throught the arg list.

rhodesk at 10:44 AM 6/4/21

Adding proper indentation to needed files.

rhodesk at 11:39 AM 6/7/21

Fixing spacing issue on blank lines. #886

rhodesk at 12:42 PM 6/7/21

Fixed comment changes. #886

rhodesk at 1:39 PM 6/7/21

Fixed incorrect spacing on use

rhodesk at 1:45 PM 6/7/21

Revert "Fixed incorrect spacing on use"

rhodesk at 1:58 PM 6/7/21

rhodesk at 2:03 PM 6/7/21

Fixed spacing going too far

rhodesk at 2:28 PM 6/7/21

Fixed comments being pushed over

rhodesk at 2:43 PM 6/7/21

Fixed not all variables being indented properly

rhodesk at 8:48 AM 6/8/21

Fixed indentation going beyond variables

rhodesk at 8:55 AM 6/8/21

Fixed file_functions indentation being off

rhodesk at 9:06 AM 6/8/21

Fixed indentation on operations being wrong

rhodesk at 9:22 AM 6/8/21

Reverted incorrect changes to new_pdf and new_hybrid_pdf

rhodesk at 9:34 AM 6/8/21

Fixed spacing issue when adding in gr. BFB identical. For #886.

rhodesk at 11:00 AM 6/8/21

Fixed spacing issue when adding in gr. BFB identical. For #886.

rhodesk at 11:00 AM 6/8/21

Removing gr as a module variable from grid_class.

rhodesk at 5:07 PM 6/14/21

Removing gr as a module variable from grid_class.

rhodesk at 5:07 PM 6/14/21

Fixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format.

benjamin.andrew.stephens at 9:40 AM 6/16/21

Fixing a typo from an earlier commit.

noreply at 9:58 AM 6/16/21

Feeding gr through arg list for functions outside of CLUBB_core.

rhodesk at 10:27 AM 6/21/21

Feeding gr through arg list for functions outside of CLUBB_core.

rhodesk at 10:27 AM 6/21/21

Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB.

rhodesk at 2:49 PM 6/24/21

The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken.

rhodesk at 12:19 PM 6/25/21

Add error header for CLUBB in CAM

noreply at 1:18 PM 6/30/21

Fixing the ordering of gr in the clubb_api arg list for affected subroutines.

rhodesk at 9:21 AM 7/1/21

Fixing coding standard violations

rhodesk at 12:23 PM 7/1/21

Improving error messages in setup_clubb_core. larson-group/e3sm#38

Gunther Huebler at 5:25 PM 7/7/21

Feeding stats variables through the argument lists of needed subroutines.

72510114+RhodesKeegan at 12:07 PM 7/22/21

Fixing spacing issues along with placing the stats varibales on their own lines.

72510114+RhodesKeegan at 12:07 PM 7/22/21

Changing more subroutines to include stats vars in their arg lists.

72510114+RhodesKeegan at 12:07 PM 7/22/21

Fixing incorrect subroutine arg list

72510114+RhodesKeegan at 12:07 PM 7/22/21

Fixing host models not compiling.

72510114+RhodesKeegan at 12:07 PM 7/22/21

Fixing argument list so that way the coding standard is upheld.

72510114+RhodesKeegan at 12:07 PM 7/22/21

I changed the name to calc_responder_driver because I thought that

bmg2 at 3:26 PM 7/23/21

Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.

59519056+bstephens82 at 1:22 PM 7/26/21

Fixing comment for the wp2_term_pr_dfsn subroutine. Related to #920.

59519056+bstephens82 at 1:22 PM 7/26/21

Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920.

59519056+bstephens82 at 1:22 PM 7/26/21

Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920.

59519056+bstephens82 at 1:22 PM 7/26/21

Fixing some comments.

59519056+bstephens82 at 1:22 PM 7/26/21

Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.

59519056+bstephens82 at 1:22 PM 7/26/21

Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.

benjamin.andrew.stephens at 3:26 PM 7/26/21

Moving the stats variables to module variables of clubb_driver.

72510114+RhodesKeegan at 1:12 PM 7/27/21

Moving the stats variables to module variables of clubb_driver.

72510114+RhodesKeegan at 1:12 PM 7/27/21

Fixing coding standard viloation of lines exceeding 100 characters.

rhodesk at 9:30 AM 7/29/21

Fixing coding standard viloation of lines exceeding 100 characters.

rhodesk at 9:30 AM 7/29/21

Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.

59519056+bstephens82 at 12:28 PM 7/29/21

Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.

59519056+bstephens82 at 12:28 PM 7/29/21

Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.

59519056+bstephens82 at 12:28 PM 7/29/21

Removing l_interp_prescribed_params from setup_clubb_pdf_params.

rhodesk at 9:22 AM 7/30/21

Adding comments labeling subroutine calls with intent.

rhodesk at 12:57 PM 8/2/21

Adding intent labels for subroutines throughout clubb.

rhodesk at 11:37 AM 8/3/21

Removing unnecessary constant from use statement

noreply at 11:43 AM 8/3/21

Eliminating l_nu_grid_dependent as requested.

rhodesk at 12:52 PM 8/10/21

Eliminating l_use_buoy_mod_Km_zm.

rhodesk at 1:37 PM 8/10/21

Eliminating l_iter_xp2_xpyp flag.

rhodesk at 2:33 PM 8/10/21

Eliminating l_apply_rule_to_pdf_params flag.

rhodesk at 12:21 PM 8/11/21

Eliminating l_ub_const_deriv flag.

rhodesk at 12:41 PM 8/11/21

Eliminating l_equation_21 flag.

rhodesk at 1:14 PM 8/11/21

Eliminating l_wp3_2nd_buoyancy flag.

rhodesk at 2:00 PM 8/11/21

Eliminating l_refine_grid_in_cloud and l_interactive_refined.

rhodesk at 2:32 PM 8/11/21

Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds

rhodesk at 3:26 PM 8/11/21

Eliminating l_use_wp3_pr3 flag.

rhodesk at 9:12 AM 8/12/21

Eliminating l_clip_semi_implicit flag.

rhodesk at 10:21 AM 8/12/21

Adding intent labels for subroutines throughout clubb.

rhodesk at 10:47 AM 8/12/21

Eliminating l_single_C2_Skw flag.

72510114+RhodesKeegan at 2:06 PM 8/13/21

Eliminating l_single_C2_Skw flag.

72510114+RhodesKeegan at 2:06 PM 8/13/21

Eliminating l_single_C2_Skw flag.

72510114+RhodesKeegan at 2:06 PM 8/13/21

Eliminating l_include_ice and sat_ice_ratio.

rhodesk at 2:37 PM 8/13/21

Eliminating l_update_pressure flag.

rhodesk at 10:26 AM 8/17/21

Eliminating l_update_pressure flag.

rhodesk at 10:26 AM 8/17/21