Skip to content
Success

Changes

Summary

  1. Fixing incorret paths and log file names in previous commit that caused wrf tests on jenkins to fail. larson-group/sys_admin#735 (details)
  2. Feeding stats variables through the argument lists of needed subroutines. (details)
  3. Fixing spacing issues along with placing the stats varibales on their own lines. (details)
  4. Changing more subroutines to include stats vars in their arg lists. (details)
  5. Fixing incorrect subroutine arg list (details)
  6. Fixing host models not compiling. (details)
  7. Fixing argument list so that way the coding standard is upheld. (details)
Commit 4af95c8f37821cb5ec139506ceaab14c65c72d3b by pbroels
Fixing incorret paths and log file names in previous commit that caused wrf tests on jenkins to fail. larson-group/sys_admin#735
The file was modified jenkins_tests/wrf_clubb_silhs_parallel_ifort/Jenkinsfile (diff)
The file was modified jenkins_tests/wrf_clubb_ifort_build/Jenkinsfile (diff)
The file was modified jenkins_tests/wrf_clubb_silhs_restart_ifort/Jenkinsfile (diff)
The file was modified jenkins_tests/wrf_katrina_sim_ifort/Jenkinsfile (diff)
Commit 61af70f562515d7c7949fa73fbd2b1da4f9de6ca by 72510114+RhodesKeegan
Feeding stats variables through the argument lists of needed subroutines.
The purpose of this commit is to prep clubb for having all stats variables be
fed through the argument list in the entirety of clubb and host models where needed.
This is for ticket #733.
Results have been confirmed to be BFB identical.
The file was modified advance_windm_edsclrm_module.F90 (diff)
The file was modified clip_explicit.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified stats_zm_module.F90 (diff)
The file was modified stats_zt_module.F90 (diff)
The file was modified stats_rad_zm_module.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified precipitation_fraction.F90 (diff)
The file was modified stats_sfc_module.F90 (diff)
The file was modified advance_xp3_module.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified stats_rad_zt_module.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified setup_clubb_pdf_params.F90 (diff)
The file was modified fill_holes.F90 (diff)
The file was modified mono_flux_limiter.F90 (diff)
Commit b91007425d019313599cd51b4605d4cef67df218 by 72510114+RhodesKeegan
Fixing spacing issues along with placing the stats varibales on their own lines.
Additionally, this commit relabels arg list intent along with the intent of stats vars.
Stats variables are still not in the correct spot in the arg list as per the standard,
however, they are on their own line where they are correctly labeled.
For ticket #733.
Results are confirmed BFB identical.
The file was modified advance_windm_edsclrm_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified mono_flux_limiter.F90 (diff)
The file was modified stats_zm_module.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified stats_zt_module.F90 (diff)
The file was modified stats_rad_zm_module.F90 (diff)
The file was modified stats_sfc_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified setup_clubb_pdf_params.F90 (diff)
The file was modified clip_explicit.F90 (diff)
The file was modified stats_rad_zt_module.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified advance_xp3_module.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
The file was modified fill_holes.F90 (diff)
The file was modified precipitation_fraction.F90 (diff)
Commit e204022d72462f620e16610f3b1b381c59d518bb by 72510114+RhodesKeegan
Changing more subroutines to include stats vars in their arg lists.
There were a few subroutines that were not detected on the first script
for subroutines that would need to be changed. This commit picks up on
those subroutines and correctly makes the change.
Additionally, this commit also makes the stats vars show up in the same
spot consistantly throughout all affected subroutines.
For ticket #733.
Results are confirmed BFB identical.
The file was modified mixing_length.F90 (diff)
The file was modified stats_lh_sfc_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified advance_windm_edsclrm_module.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
The file was modified setup_clubb_pdf_params.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified mono_flux_limiter.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified stats_lh_zt_module.F90 (diff)
Commit ac1df97e26a56cf3f37510ac01c528f4d08b4c4f by 72510114+RhodesKeegan
Fixing incorrect subroutine arg list
The file was modified clubb_api_module.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
Commit d8a773b6951a8ca27220f67101cdddb147393be5 by 72510114+RhodesKeegan
Fixing host models not compiling.
Host models now compile.
For ticket #733
Results remain BFB identical.
The file was modified clubb_api_module.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
Commit f88352a23a161658184472e7d2d0fa5d61bdb5cd by 72510114+RhodesKeegan
Fixing argument list so that way the coding standard is upheld.
For ticket #733.
Results remain BFB identical.
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified advance_windm_edsclrm_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified mono_flux_limiter.F90 (diff)
The file was modified setup_clubb_pdf_params.F90 (diff)
The file was modified mixing_length.F90 (diff)
The file was modified fill_holes.F90 (diff)
The file was modified stats_zt_module.F90 (diff)
The file was modified clip_explicit.F90 (diff)
The file was modified stats_lh_sfc_module.F90 (diff)
The file was modified stats_rad_zt_module.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
The file was modified stats_zm_module.F90 (diff)
The file was modified advance_xp3_module.F90 (diff)
The file was modified stats_lh_zt_module.F90 (diff)
The file was modified stats_sfc_module.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified stats_rad_zm_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified precipitation_fraction.F90 (diff)