Skip to content
Changes
- Fixes for fill_holes and edsclr code (#1266)
—
noreply /
githubweb
- Grid reverse matrix test (#1265)
—
noreply /
githubweb
- BIT_CHANGING bug fix for the penta_lu solver, only BC when using penta_solve_method=2 (#1264)
—
noreply /
githubweb
- Bicgstab addition (#1261)
—
noreply /
githubweb
- Small bug fix to make gfortran+debug happy, without the _core_rknd this could be a potential type error
—
Gunther Huebler /
githubweb
- Making update_xp2_mc work with either grid mode (#1263)
—
noreply /
githubweb
- Improving variable name
—
Gunther Huebler /
githubweb
- Small bug fix, but this is BIT_CHANGING because it affects stats output. Some zm fields (w_1_zm, w_2_zm, varnce_w_1_zm, varnce_w_2_zm, and mixt_frac_zm) were all nan in the netcdf output when l_call_pdf_closure_twice=.false., because those come from pdf_params_zm.
—
Gunther Huebler /
githubweb
- Removing accidentally added files
—
Gunther Huebler /
githubweb
- Making clubb_at_least_debug_level not a device routine. It confuses the poor little nvidia compiler when compiling inside cam. Also making the compile script a little more robust.
—
Gunther Huebler /
githubweb
- New fill_holes methods (#1262)
—
noreply /
githubweb
- New fill_holes methods (#1262)
—
noreply /
githubweb
- Making compatible with new version of clubb (#167)
—
noreply /
githubweb
- Small bug fix in fill_holes_parallel on GPU
—
Gunther Huebler /
githubweb
- Clubb driver upgrades part2 (#1257)
—
noreply /
githubweb
- Clubb driver upgrades part2 (#1257)
—
noreply /
githubweb
- Compatibility upgrades (#166)
—
noreply /
githubweb
- Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true.
—
Gunther Huebler /
githubweb
- thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint.
—
Gunther Huebler /
githubweb
- Making the l_random_k_lh_start set the random generator seed before generating a random. This should fix the generalized grid test, which failed for the only flag set that turned on l_random_k_lh_start. Before, the test passed because we used the same random seed for all timesteps, preventing differences in the random call. But now we use a different seed each timestep, causing differences. To ensure reproducibility, we use the seed each timestep to generate rand_pool, which is an effective solution, but we need to do that for the rand_integer_in_range call in the l_random_k_lh_start code for the same reason. Since this does change the random that comes out, this is BIT_CHANGING, but only for runs using both SILHS and l_random_k_lh_start=.true.
—
Gunther Huebler /
githubweb
- SILHS reproducibility (#1258)
—
noreply /
githubweb
- Change tolerance in way that affects only single precision builds (#1256)
—
noreply /
githubweb
- Remove module vars from grid_adaptation_module (#1255)
—
noreply /
githubweb
- Precip frac fix (#1254)
—
noreply /
githubweb
- The cmake update (#1253)
—
noreply /
githubweb
- The cmake update (#1253)
—
noreply /
githubweb
- The cmake update (#1253)
—
noreply /
githubweb
- Adding expldiff budget terms for thlm and rtm (#1252)
—
noreply /
githubweb
- fix precision error of reals
—
noreply /
githubweb
- rename grid_adaptation and remapping modules
—
0-freundlich-adenin /
githubweb
- add fix for grid generalization
—
0-freundlich-adenin /
githubweb
- Merge grid adaptation implementation (#1249)
—
noreply /
githubweb
- zm and zt were mixed up in the error prints argument list.
—
bmg2 /
githubweb
- Removed simple wrappers from clubb_api_module (#1245)
—
noreply /
githubweb
- Removed simple wrappers from clubb_api_module (#1245)
—
noreply /
githubweb
- Fixed and equalized NaN checks in lapack_wrap (#1246)
—
noreply /
githubweb
- Cleaning up some grid generalization issues that were found within
—
bmg2 /
githubweb
- Run scm fixes (#1244)
—
noreply /
githubweb
- Removed renaming operators `=>` and wrapper subroutines from silhs_api_module (#1240)
—
noreply /
githubweb
- Running CLUBB with l_stability_correct_tau_zm = .true. now requires
—
bmg2 /
githubweb
- Running CLUBB with l_stability_correct_tau_zm = .true. now requires
—
bmg2 /
githubweb
- These changes were accidentally made during the previous commit. The are
—
bmg2 /
githubweb
- These changes were accidentally made during the previous commit. The are
—
bmg2 /
githubweb
- Err code gpu fix (#1241)
—
noreply /
githubweb
- Err code struct (#1238)
—
noreply /
githubweb
- Err code struct (#1238)
—
noreply /
githubweb
- Update clubb_sgs.F90 to incorporate err_info (#165)
—
noreply /
githubweb
- I updated adj_low_res_nu for use with a generalized grid. It is
—
bmg2 /
githubweb
- Clubb silhs gg (#1239)
—
noreply /
githubweb
- Clubb silhs gg (#1239)
—
noreply /
githubweb
- Updating calls to generate_silhs_sample_api for recent changes to
—
bmg2 /
githubweb
- Clubb driver upgrades (#1225)
—
noreply /
githubweb
- Clubb test correct gg (#1237)
—
noreply /
githubweb
- The generalized grid test should not output a clubb fatal error when it
—
bmg2 /
githubweb
- Revert "I have no idea if it's appropriate to include gr in this statment,"
—
bmg2 /
githubweb
- I discovered that I inadvertently change an $acc statement that
—
bmg2 /
githubweb
- Eliminate GOTO statement in stats_clubb_utilities (#1233)
—
noreply /
githubweb
- Added some missing acc parallel statments around some the loops
—
bmg2 /
githubweb
- Fixed a bug
—
bmg2 /
githubweb
- I have no idea if it's appropriate to include gr in this statment,
—
bmg2 /
githubweb
- I changed the variable type within grid function flip from dp to
—
bmg2 /
githubweb
- Fixed a compiling issue with CAM-CLUBB.
—
bmg2 /
githubweb
- Hopefully this helps the cpu vs. gpu tests.
—
bmg2 /
githubweb
- Updated calls to some CLUBB subroutines in the wake of recent CLUBB
—
bmg2 /
githubweb
- Generalized grid (#1230)
—
noreply /
githubweb
- Prevent SAM from bypassing clubb_api_module (#164)
—
noreply /
githubweb
- Removed renaming operators `=>` from clubb_api_module (#1232)
—
noreply /
githubweb
- Removed renaming operators `=>` from clubb_api_module (#1232)
—
noreply /
githubweb
- Getting rid of a couple of worthless lines of code. It's possible this
—
bmg2 /
githubweb
- Should just delete instead of commenting out.
—
bmg2 /
githubweb
- Fixed equality check in pdf_closure_module (#1229)
—
noreply /
githubweb
- add dycore grid with conservative remapping scheme
—
noreply /
githubweb
- add dycore grid with conservative remapping scheme
—
noreply /
githubweb
- add two new flags (#162)
—
noreply /
githubweb
- Adapt SAM to removal of module var err_code (#163)
—
noreply /
githubweb
- Revert clubb api module changes (#1228)
—
noreply /
githubweb
- Remove err code (#1218)
—
noreply /
githubweb
- Remove err code (#1218)
—
noreply /
githubweb
- Renamed check_res to err_code in numerical_check.F90 for consistency (#1227)
—
noreply /
githubweb
- Set l_wp2_fill_holes_tke to true by default (#1226)
—
noreply /
githubweb
- Set l_wp2_fill_holes_tke to true by default (#1226)
—
noreply /
githubweb
- Swapping the loop order on a few kernels, I found this faster for the nvhpc compiler and it's BFB
—
Gunther Huebler /
githubweb
- Monoflux GPU optimization (#1221)
—
noreply /
githubweb
- Fix flag l_wp2_fill_holes_tke (#161)
—
noreply /
githubweb
- Added new hole-filling method which takes TKE from up2 and vp2 (#1217)
—
noreply /
githubweb
- Added new hole-filling method which takes TKE from up2 and vp2 (#1217)
—
noreply /
githubweb
- Fix binormal correlation clipping (#1199)
—
noreply /
githubweb
- Changing a couple loop limits in mono flux limiter.
—
bmg2 /
githubweb
- Recoded a loop within the mono flux limiter so that it's written
—
bmg2 /
githubweb
- Changed some variable names so that it is clear that, while they contain
—
bmg2 /
githubweb
- Within the mono flux limiter, a thermodynamic-level variable needed to
—
bmg2 /
githubweb
- I forgot to add the new variable to the Atlantic Coast Conference
—
bmg2 /
githubweb
- Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216)
—
noreply /
githubweb
- Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216)
—
noreply /
githubweb
- Added up2 and vp2 to calculation of wp2_min_array (#1215)
—
noreply /
githubweb
- Reduced the upper bound for wp2_min_array to 1.0 (#1214)
—
noreply /
githubweb
- Likely non-bit-changing housekeeping (#1213)
—
noreply /
githubweb
- Multi col output update (#1211)
—
noreply /
githubweb
- Making compatible with latest clubb changes
—
Gunther Huebler /
githubweb
- Clubb Driver Semi GPUization Part4 (#1209)
—
noreply /
githubweb
- Clubb Driver Semi GPUization Part4 (#1209)
—
noreply /
githubweb
- Multi Column Mirror Test (#1206)
—
noreply /
githubweb
- As part of generalizing the code to work with both an ascending and
—
bmg2 /
githubweb
- Making a correction to the doubled plus sign from commit a1fcfe8.
—
bmg2 /
githubweb
- Moving Lscale from an acc create statement inside clubb to the acc output statement in clubb_api. This is bug fix that is BIT_CHANGING, but only for silhs cases running on the GPU. Also using this to add BIT_CHANGING:aff1bb12551c5b3a8ab1c4d773ef5c17fb96c53b, as that commit was BC but just missing the message.
—
Gunther Huebler /
githubweb
- Various Small Tweaks (#1205)
—
noreply /
githubweb
- Making compatible with latest clubb changes
—
Gunther Huebler /
githubweb
- Prescribe Forcings GPUization (#1204)
—
noreply /
githubweb
- I am making the loops for the wp3 ta term (using ADG1 PDF) symmetric.
—
bmg2 /
githubweb
- Making compatible with latest clubb changes
—
Gunther Huebler /
githubweb
- Multicol CLUBB (#1193)
—
noreply /
githubweb
- Multicol CLUBB (#1193)
—
noreply /
githubweb
- Multicol CLUBB (#1193)
—
noreply /
githubweb
- Added min_max_smth_mag as a Fortran parameter to constants_clubb.F90 (#1192)
—
noreply /
githubweb
- add Lscale intent(out) to advance_clubb_core and advance_clubb_core_api (#1190)
—
noreply /
githubweb
- add Lscale to advance_clubb_core_api call. For larson-group/clubb#1166 (#160)
—
noreply /
githubweb
- Mono Flux Optimizations (#1189)
—
noreply /
githubweb
- refactoring to remove compiler warnings (#1187)
—
noreply /
githubweb
- refactoring to remove compiler warnings (#1187)
—
noreply /
githubweb
- remove unused dummy arguments (#159)
—
noreply /
githubweb
- I am copying the round-off level changes made to grid weights
—
bmg2 /
githubweb
- Ri zm calc cleanup (#1186)
—
noreply /
githubweb
- Monoflux test (#1188)
—
noreply /
githubweb
- Fixing bug. This loop has a vertical dependency prevent the use of collapse(2). See https://github.com/larson-group/cam/issues/175\#issuecomment-2261283301
—
Gunther Huebler /
githubweb
- New/new_hybrid PDF Stats Removal (#1185)
—
noreply /
githubweb
- Copyout Nuke (#1182)
—
noreply /
githubweb
- Remove radf variable from CLUBB call
—
noreply /
githubweb
- Remove radf variable from call to CLUBB
—
noreply /
githubweb
- Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack.
—
Gunther Huebler /
githubweb
- Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack.
—
Gunther Huebler /
githubweb
- reduce compiler warnings (#1180)
—
noreply /
githubweb
- reduce compiler warnings (#1180)
—
noreply /
githubweb
- refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)
—
noreply /
githubweb
- refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)
—
noreply /
githubweb
- Removing duplicate definition of edsclr when CLUBB_CAM is defined.
—
Gunther Huebler /
githubweb
- Ri zm calc6 (#1177)
—
noreply /
githubweb
- change loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173)
—
noreply /
githubweb
- Ri zm calc5 (#1175)
—
noreply /
githubweb
- Change variables from a1 and a3 to a1_coef and a3_coef
—
Vince Larson /
githubweb
- Well, this will probably anger the Grim Reaper, but I have finally
—
bmg2 /
githubweb
- Ri zm calc4 (#1168)
—
noreply /
githubweb
- Ri_zm calc (Part 4) - Implementing calc_Ri_zm (#1160)
—
noreply /
githubweb
- Variable name correction in acc data statement.
—
Gunther Huebler /
githubweb
- Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine.
—
Gunther Huebler /
githubweb
- Making radf size correct in api and clubb_driver.
—
Gunther Huebler /
githubweb
- Updated for ghostless version of CLUBB.
—
bmg2 /
githubweb
- Updating to the latest version of CLUBB.
—
bmg2 /
githubweb
- Clubb ghost exorcism (#1159)
—
noreply /
githubweb
- Clubb ghost exorcism (#1159)
—
noreply /
githubweb
- Nightly clubb plots (#1167)
—
noreply /
githubweb
- Editing the LES setup script to give instructions for UCAR computers.
—
benjamin.andrew.stephens /
githubweb
- Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)
—
noreply /
githubweb
- Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)
—
noreply /
githubweb
- Moving PosInf to clubb_model_settings.F90
—
Gunther Huebler /
githubweb
- Fixing mpirun command in the derecho and casper batch scripts.
—
benjamin.andrew.stephens /
githubweb
- Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175
—
Gunther Huebler /
githubweb
- Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.
—
Gunther Huebler /
githubweb
- Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.
—
Gunther Huebler /
githubweb
- removing cheyenne-related content and adding new content for
—
benjamin.andrew.stephens /
githubweb
- Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp.
—
bmg2 /
githubweb
- Fixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175
—
Gunther Huebler /
githubweb
- In my previous commit, I changed the domain of the maxloc commands
—
bmg2 /
githubweb
- This commit brings the stats output from the all cases run with
—
bmg2 /
githubweb
- Committing a change that will initialize this set of variables
—
bmg2 /
githubweb
- There were furhter issues found with the k_lh_start code.
—
bmg2 /
githubweb
- Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)
—
noreply /
githubweb
- I am committing changes to stats output for cloud_cover, rcm_in_layer,
—
bmg2 /
githubweb
- I am updating the SILHS code that calculates k_lh_start to work
—
bmg2 /
githubweb
- This code in adj_low_res_nu was using the ghost point when
—
bmg2 /
githubweb
- Spack updates (#156)
—
noreply /
githubweb