Skip to content
Success

Changes

Summary

  1. Pushing k loop down through clip_variance_level. (details)
  2. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. (details)
  3. Updates to improve error checking for the tuner, updates to comments. (details)
  4. Getting rid of a duplication of code. (details)
  5. Updating name of l_vary_params_together flag to l_keep_params_equal, since this is probably more clear and also is more consistent with my comments in the code. (details)
  6. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. (details)
  7. Removing an old comment (details)
  8. Updating some comments related to the tuner updates. (details)
  9. Update README (details)
  10. Minor updates requested in pull request: renaming a variable and adding some comments. (details)
Commit 645764ff028a78e5856d60fd0efd81fe958b31b5 by rhodesk
Pushing k loop down through clip_variance_level.
This change is for the files advance_wp2_wp3_module and advance_xp2_xpyp_module.
In order to make this change, I added a new variable in the upper-level subroutine
that is an array version of the variable 'threshold' and passed it along to the lower subroutine.
The loop is still present in order to calculate the values of threshold, however, the calls
to the subroutine is outside of the loop. The only calculations inside the loop is for
and intrensic function, max.
All results are BFB identical for default case along with l_stats_samp being set to true.
For ticket #951.
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/clip_explicit.F90 (diff)
Commit 15b0b34248cb2472b5bfa40a709675aacfde434d by 59519056+bstephens82
Udpates to make it possible for us to keep certain parameters equal to each other during tuning.

Includes:

* a new subroutine in parameters_tunable.F90 that will read a new namelist in the error_*.in files
* updates to src/error.F90 to make sure the intended parameters are held equal throughout the tuning run
* updates to src.error.F90 to print the variables that were held equal at the end of the tuning run, together with their beginning and ending values, and updates to ensure that the new tuned values are copied into the new paramters_tunable_*.in file so they can be used for plotting or restarting the tuner.
* includes several simple error checks

See #939.
The file was modified src/error.F90 (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_nd.in (diff)
The file was modified input_misc/tuner/error_all.in (diff)
The file was modified input_misc/tuner/error_atex.in (diff)
The file was modified input_misc/tuner/error_bomex.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf01.in (diff)
The file was modified input_misc/tuner/error_fire.in (diff)
The file was modified input_misc/tuner/error_arm.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_ds.in (diff)
The file was modified input_misc/tuner/error_gabls3_night.in (diff)
The file was modified input_misc/tuner/error_rico.in (diff)
The file was modified input_misc/tuner/error_wangara.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_do.in (diff)
The file was modified input_misc/tuner/error_gabls2.in (diff)
The file was modified input_misc/tuner/error_lba.in (diff)
The file was modified input_misc/tuner/error_nov11_altocu.in (diff)
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified input_misc/tuner/error_arm_97.in (diff)
The file was modified input_misc/tuner/error_ticket_756.in (diff)
Commit 3fd43e54aeb0fe3ed07b3f2b3809384c26c6308f by 59519056+bstephens82
Updates to improve error checking for the tuner, updates to comments.

See #939.
The file was modified src/error.F90 (diff)
Commit 5d3968225001bcf65b88819bf5d44112dfd55520 by 59519056+bstephens82
Getting rid of a duplication of code.
The file was modified src/error.F90 (diff)
Commit f616391b15b456b19250596e2ba716f2e711ddef by 59519056+bstephens82
Updating name of l_vary_params_together flag to l_keep_params_equal, since this is probably more clear and also is more consistent with my comments in the code.
The file was modified input_misc/tuner/error_gabls2.in (diff)
The file was modified src/error.F90 (diff)
The file was modified input_misc/tuner/error_nov11_altocu.in (diff)
The file was modified input_misc/tuner/error_all.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf01.in (diff)
The file was modified input_misc/tuner/error_arm_97.in (diff)
The file was modified input_misc/tuner/error_bomex.in (diff)
The file was modified input_misc/tuner/error_rico.in (diff)
The file was modified input_misc/tuner/error_arm.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_nd.in (diff)
The file was modified input_misc/tuner/error_lba.in (diff)
The file was modified input_misc/tuner/error_fire.in (diff)
The file was modified input_misc/tuner/error_atex.in (diff)
The file was modified input_misc/tuner/error_gabls3_night.in (diff)
The file was modified input_misc/tuner/error_wangara.in (diff)
The file was modified input_misc/tuner/error_ticket_756.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_ds.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_do.in (diff)
Commit 7b4081bc1e9df47f4f74472a5f5fe8aa148fc752 by 59519056+bstephens82
Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included.

See #939.
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_ds.in (diff)
The file was modified src/error.F90 (diff)
The file was modified input_misc/tuner/error_ticket_756.in (diff)
The file was modified input_misc/tuner/error_wangara.in (diff)
The file was modified input_misc/tuner/error_gabls3_night.in (diff)
The file was modified src/clubb_tuner.F90 (diff)
The file was modified input_misc/tuner/error_arm_97.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_nd.in (diff)
The file was modified input_misc/tuner/error_rico.in (diff)
The file was modified input_misc/tuner/error_bomex.in (diff)
The file was modified input_misc/tuner/error_all.in (diff)
The file was modified input_misc/tuner/error_lba.in (diff)
The file was modified input_misc/tuner/error_atex.in (diff)
The file was modified input_misc/tuner/error_fire.in (diff)
The file was modified input_misc/tuner/error_nov11_altocu.in (diff)
The file was modified input_misc/tuner/error_arm.in (diff)
The file was modified input_misc/tuner/error_gabls2.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf01.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_do.in (diff)
The file was modified src/error.F90 (diff)
Commit b26df4032b67b87fa59e706f469b3f6c72b586e9 by 59519056+bstephens82
Updating some comments related to the tuner updates.

See #939.
The file was modified input_misc/tuner/README (diff)
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified input_misc/tuner/README (diff)
Commit 6958fdf7eb63f23251745b86ce05fb0e631f6258 by 59519056+bstephens82
Minor updates requested in pull request: renaming a variable and adding some comments.

See #939.
The file was modified src/error.F90 (diff)