Skip to content
Changes
- Adding Morrison_microphys folder inside Microphys and reflecting change in compilation files. This is to make this new structure work with the way we include Morrison code, which is brought in from sam_clubb via the updateClubbMorrison.sh found in sys_admin/gitUpdateScripts/
—
Gunther Huebler /
githubweb
- Clubb driver upgrades part2 (#1257)
—
noreply /
githubweb
- Must add -fopenmp back for now, since this is used for the openmp test and it also broke the BFB tests for an obnoxious reason - that test compiles each commit without cleaning the build, so the baseline commit had -fopenmp and compiled with openmp stuff enabled, but then the subsequent commits had it turned off, but no changes in the files, so it didn't recompile with it off, and only turned it off in the linking stage, causing a build error. RESOLVED:320551df13ee84bdb9280db0be788a36e1f03494 RESOLVED:6c0201d44694fadf7f4bb0d4d58c3a9871096a22 RESOLVED:26644de2ea83ee6335b273f54dd57afc8f6f4b0c
—
Gunther Huebler /
githubweb
- Adding -Mstack_arrays to the nvfortran flags causes us to use more stack space, which means we need to allow processes to use more stack space (when using lots of columns, since that increases memory footprint). We do by using using 'ulimit BIGNUMBER'.
—
Gunther Huebler /
githubweb
- Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true.
—
Gunther Huebler /
githubweb
- Modifying compiler configurations (mainly optimization level) in order to prepare for switching scipts and tests to cmake, specifically separating out this BIT_CHANGING commit from the rest
—
Gunther Huebler /
githubweb
- thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint.
—
Gunther Huebler /
githubweb
- Making restart test not overwrite time_initial. The time_initial should be defined by the _model.in file and not overwritten, but this script was setting time_initial to time_restart, which resulted in the initial iteration value (iinit) to be 1 in the restart regardless of the restart time.
—
Gunther Huebler /
githubweb
- Making the l_random_k_lh_start set the random generator seed before generating a random. This should fix the generalized grid test, which failed for the only flag set that turned on l_random_k_lh_start. Before, the test passed because we used the same random seed for all timesteps, preventing differences in the random call. But now we use a different seed each timestep, causing differences. To ensure reproducibility, we use the seed each timestep to generate rand_pool, which is an effective solution, but we need to do that for the rand_integer_in_range call in the l_random_k_lh_start code for the same reason. Since this does change the random that comes out, this is BIT_CHANGING, but only for runs using both SILHS and l_random_k_lh_start=.true.
—
Gunther Huebler /
githubweb
- SILHS reproducibility (#1258)
—
noreply /
githubweb
- Bug fix. This is BIT_CHANGING, but only on GPUs and only when l_soil_veg=.true. (which is only gabls3 currently).
—
Gunther Huebler /
githubweb
- Change tolerance in way that affects only single precision builds (#1256)
—
noreply /
githubweb
- Remove module vars from grid_adaptation_module (#1255)
—
noreply /
githubweb
- Precip frac fix (#1254)
—
noreply /
githubweb
- The cmake update (#1253)
—
noreply /
githubweb
- Making cmake only optionally use ninja. Now we only use it if it's available.
—
Gunther Huebler /
githubweb
- Adding expldiff budget terms for thlm and rtm (#1252)
—
noreply /
githubweb
- Raw-copy updating src/Morrison_microphys
—
Cole Pickett /
githubweb
- Increase lh_num_samples to 64 for LBA case
—
noreply /
githubweb
- Update License.txt in order to note that BIT_CHANGING:b5ec2335bc0cf95dbbe1f48a0043bb792a72d3c6
—
noreply /
githubweb
- Clean out clubb_G_unit_reverse_dir_grid_test folder before running Jenkins test
—
noreply /
githubweb
- Finished my notes, documentation, and instructions for the generalized
—
bmg2 /
githubweb
- I start adding some notes on grid generalization.
—
bmg2 /
githubweb
- fix precision error of reals
—
noreply /
githubweb
- rename grid_adaptation and remapping modules
—
0-freundlich-adenin /
githubweb
- add fix for grid generalization
—
0-freundlich-adenin /
githubweb
- Merge grid adaptation implementation (#1249)
—
noreply /
githubweb
- I am adding pass/fail statements specific to the generalized grid test
—
bmg2 /
githubweb
- For the long-duration clubb_generalized_vertical_grid_test, I am
—
bmg2 /
githubweb
- zm and zt were mixed up in the error prints argument list.
—
bmg2 /
githubweb
- I updated run_bindiff_w_flags_config_host_flags to add flag set 3,
—
bmg2 /
githubweb
- Fix jenkins clubb error handling output (#1247)
—
noreply /
githubweb
- Removed simple wrappers from clubb_api_module (#1245)
—
noreply /
githubweb
- Fixed and equalized NaN checks in lapack_wrap (#1246)
—
noreply /
githubweb
- Cleaning up some grid generalization issues that were found within
—
bmg2 /
githubweb
- Run scm fixes (#1244)
—
noreply /
githubweb
- I am adding a new .json file for host model flags. Flag set 1 consists
—
bmg2 /
githubweb
- I am adding a Jenkinsfile for a new CLUBB generalized vertical
—
bmg2 /
githubweb
- I am adding a second set of host flags as part of the generalized
—
bmg2 /
githubweb
- Fixing an error in the previous commit. (lol, good ol' find and replace)
—
bmg2 /
githubweb
- Removed renaming operators `=>` and wrapper subroutines from silhs_api_module (#1240)
—
noreply /
githubweb
- Changing readme to add BIT_CHANGING:71eb9b3c5fd65c33905f17be8476a1dea89a2511 since that commit was a bug fix, so technically it was bit changing.
—
Gunther Huebler /
githubweb
- Small bug fix that has somehow gone unfound until recently. RESOLVED:f9d92113871bdf87b5e3147db6740ab654dc0967
—
Gunther Huebler /
githubweb
- Technically, the following two commits are not BFB
—
noreply /
githubweb
- Running CLUBB with l_stability_correct_tau_zm = .true. now requires
—
bmg2 /
githubweb
- These changes were accidentally made during the previous commit. The are
—
bmg2 /
githubweb
- Fix segfault involving initialization of CLUBB when l_add_dycore_grid=F
—
Steffen Domke /
githubweb
- Removed unnecessary print statements in clubb_driver
—
Steffen Domke /
githubweb
- Err code gpu fix (#1241)
—
noreply /
githubweb
- Err code struct (#1238)
—
noreply /
githubweb
- Fix that causes BFB GPU tests to break. We need to copy these variables to the CPU before outputtin to disk. It's very unclear why the BFB GPU test ever passed without this.
—
Gunther Huebler /
githubweb
- I updated adj_low_res_nu for use with a generalized grid. It is
—
bmg2 /
githubweb
- Since the call to adj_low_res_nu is not tested by CLUBB's main
—
bmg2 /
githubweb
- Add a blank line to README in order to note BIT_CHANGING:969bc4aa2a1db2664c0f92b98d2df5544c554c32
—
noreply /
githubweb
- Clubb silhs gg (#1239)
—
noreply /
githubweb
- Third hotfix of the day. This last change teased out a sneaky potentially fatal bug for cases using l_cloud_sed=.true., making this a BIT_CHANGING fix. Also need to include BIT_CHANGING:13ad3cfe7872df2fe91250265f4a81baa621a882 because that was a fix to a fatal bug in some cases. Also including some other small fixes that weren't breaking any tests, but might've caused problems in the future.
—
Gunther Huebler /
githubweb
- Removing accidentally added file.
—
Gunther Huebler /
githubweb
- Second hot fix for more _init variables that need to be copied in. RESOLVED:ed9ae72a5eb28dbc036dd3e14b9312eea840feac
—
Gunther Huebler /
githubweb
- Hot fix to GPU code. These _init variables need to be copied to the GPU
—
Gunther Huebler /
githubweb
- Clubb driver upgrades (#1225)
—
noreply /
githubweb
- QuadTune: Read in obs for custom metrics automatically from obs file.
—
Vince Larson /
githubweb
- QuadTune: Rename "setUpInputs" to "setUpConfig". Rename other variables. Improve comments in quadtune_driver.py.
—
Vince Larson /
githubweb
- QuadTune: Create config file where a user can input "namelist" info about his obs and simulations. Also add an example config file so that the user can keep multiple namelists. Do minor refactorings.
—
Vince Larson /
githubweb
- QuadTune: Rename "linSoln" to "globTuned" in order to denote the global simulation result after tuning. Add docstrings to more functions.
—
Vince Larson /
githubweb
- Clubb test correct gg (#1237)
—
noreply /
githubweb
- QuadTune: Move import statements to top of file. Move abbreviateParamsNames to set_up_inputs. Neaten source code a bit.
—
Vince Larson /
githubweb
- QuadTune: Set plot-type flags in set_up_inputs.py and then feed them into create_nonbootstrap_figs.py.
—
Vince Larson /
githubweb
- QuadTune: Improve plot titles, add (a), (b), (c) to subpanels, etc.
—
Vince Larson /
githubweb
- QuadTune: Remove dependence of QuadTune code on file analyze_sensitivity_matrix.py.
—
Vince Larson /
githubweb
- QuadTune: Rename files.
—
Vince Larson /
githubweb
- QuadTune: Shut off bootstrap fig display, set useBootstrap=F, and improved fonts on scatterplots.
—
Vince Larson /
githubweb
- Updating the Jenkinsfile for the CLUBB generalized vertical grid test
—
bmg2 /
githubweb
- Revert "When the run_clubb_w_varying_flags.py script is running a generalized"
—
bmg2 /
githubweb
- One of the previous issues with this python script is that it
—
bmg2 /
githubweb
- I am setting the exit_code for the python script to be based on
—
bmg2 /
githubweb
- I added some helpful print statements and imported "sys" for the
—
bmg2 /
githubweb
- Changing the generalized vertical grid Jenkins test to use the new
—
bmg2 /
githubweb
- When the run_clubb_w_varying_flags.py script is running a generalized
—
bmg2 /
githubweb
- I added a stripped down version of the run_bindiff_w_flags.py script
—
bmg2 /
githubweb
- The generalized grid test should not output a clubb fatal error when it
—
bmg2 /
githubweb
- Revert "I have no idea if it's appropriate to include gr in this statment,"
—
bmg2 /
githubweb
- Added a special G unit Jenkins test for the Reverse Direction
—
bmg2 /
githubweb
- I accidentally committed G_unit_tests.in as part of my previous commit.
—
bmg2 /
githubweb
- I forgot to update the test name in the Jenkinsfile.
—
bmg2 /
githubweb
- I discovered that I inadvertently change an $acc statement that
—
bmg2 /
githubweb
- Eliminate GOTO statement in stats_clubb_utilities (#1233)
—
noreply /
githubweb
- Updated Jenkins api_commitment_test to python3 (#1235)
—
noreply /
githubweb
- Fixed Jenkins api_commitment_test (#1236)
—
noreply /
githubweb
- Added some missing acc parallel statments around some the loops
—
bmg2 /
githubweb
- Fixed a bug
—
bmg2 /
githubweb
- I have no idea if it's appropriate to include gr in this statment,
—
bmg2 /
githubweb
- I changed the variable type within grid function flip from dp to
—
bmg2 /
githubweb
- Fixed a compiling issue with CAM-CLUBB.
—
bmg2 /
githubweb
- Hopefully this helps the cpu vs. gpu tests.
—
bmg2 /
githubweb
- There were some flips inside the stats code for BUGSrad that required
—
bmg2 /
githubweb
- Updated calls to some CLUBB subroutines in the wake of recent CLUBB
—
bmg2 /
githubweb
- Generalized grid (#1230)
—
noreply /
githubweb
- Regrouped to decrease the total number of runs.
—
bmg2 /
githubweb
- Added a .json file for run_bindiff_w_flags that checks most of
—
bmg2 /
githubweb
- add requirements file for run_bindiff_w_flags script
—
noreply /
githubweb
- Removed renaming operators `=>` from clubb_api_module (#1232)
—
noreply /
githubweb
- fix variable l_sfc_already_initialized (#1231)
—
noreply /
githubweb
- Getting rid of a couple of worthless lines of code. It's possible this
—
bmg2 /
githubweb
- Should just delete instead of commenting out.
—
bmg2 /
githubweb
- Revert clubb api module changes (#1228)
—
noreply /
githubweb
- Fixed equality check in pdf_closure_module (#1229)
—
noreply /
githubweb
- add dycore grid with conservative remapping scheme
—
noreply /
githubweb
- Remove err code (#1218)
—
noreply /
githubweb
- Renamed check_res to err_code in numerical_check.F90 for consistency (#1227)
—
noreply /
githubweb
- Set l_wp2_fill_holes_tke to true by default (#1226)
—
noreply /
githubweb
- BIT_CHANGING bug fix that only affects l_t_dependent cases running with multiple columns, I detected this with cgils cases, but I'm not sure how it slipped through initially.
—
Gunther Huebler /
githubweb
- QuadTune: Made plot_PcSensMap work when len(varPrefixes) > 1.
—
Vince Larson /
githubweb
- QuadTune: Merge in bootstrap sampling
—
noreply /
githubweb
- Swapping the loop order on a few kernels, I found this faster for the nvhpc compiler and it's BFB
—
Gunther Huebler /
githubweb
- Monoflux GPU optimization (#1221)
—
noreply /
githubweb
- QuadTune: Add useLongTitle option, which adds extra information on the plotted quantity, if desired.
—
Vince Larson /
githubweb
- QuadTune: Plot bias instead of negative bias on metricsBarChart and bias-vs-sensitivity plots.
—
Vince Larson /
githubweb
- QuadTune: On matrix-eqn bar chart, plot only extraMetricsToPlot. Add sens-bias scatterplot of only extraMetricsToPlot. In parameter increments bar chart, change absolute values to squares.
—
Vince Larson /
githubweb
- Slightly relaxing the convergence criteria to fix convergence test.
—
Gunther Huebler /
githubweb
- Finally fixing gpu_diffness test (#1219)
—
noreply /
githubweb
- Added new hole-filling method which takes TKE from up2 and vp2 (#1217)
—
noreply /
githubweb
- Fix binormal correlation clipping (#1199)
—
noreply /
githubweb
- QuadTune: Remedy loss function and facilitate plotting of special, non-20x20 regions (DYCOMS, HAWAII, etc.).
—
Vince Larson /
githubweb
- Changing a couple loop limits in mono flux limiter.
—
bmg2 /
githubweb
- Recoded a loop within the mono flux limiter so that it's written
—
bmg2 /
githubweb
- Changed some variable names so that it is clear that, while they contain
—
bmg2 /
githubweb
- Within the mono flux limiter, a thermodynamic-level variable needed to
—
bmg2 /
githubweb
- I forgot to add the new variable to the Atlantic Coast Conference
—
bmg2 /
githubweb
- QuadTune: Include special regions (DYCOMS, HAWAII, etc.), in addition to 20x20 regions. However, the weights are set to epsilon, which wrecks the loss calculation. This will have to be remedied later.
—
Vince Larson /
githubweb
- QuadTune: Add map plots of "linSoln" output from global E3SM runs.
—
Vince Larson /
githubweb
- Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216)
—
noreply /
githubweb
- Added up2 and vp2 to calculation of wp2_min_array (#1215)
—
noreply /
githubweb
- QuadTune: Add bar chart showing linear vs. nonlinear contributions of each parameter.
—
Vince Larson /
githubweb
- QuadTune: 1) Add bar chart that shows |metric_changes| due to each parameter. 2) Fix colorbars on maps. 3) Allow download of hi-res figures. 4) Make background of scatterplots grey.
—
Vince Larson /
githubweb
- Reduced the upper bound for wp2_min_array to 1.0 (#1214)
—
noreply /
githubweb
- Likely non-bit-changing housekeeping (#1213)
—
noreply /
githubweb
- Fix pyplotgen timeheight cmaps (#1212)
—
noreply /
githubweb
- QuadTune: 1) Change coloring of scatterpoints to represent either loss changes or residuals. 2) Add map of residuals to complement map of bias.
—
Vince Larson /
githubweb
- QuadTune: Added colorbars to regional map plots.
—
Vince Larson /
githubweb
- Multi col output update (#1211)
—
noreply /
githubweb
- QuadTune: Plot a map of the change in the loss function for each region.
—
Vince Larson /
githubweb
- Fixed time-height plot colormaps (#1210)
—
noreply /
githubweb
- Clubb Driver Semi GPUization Part4 (#1209)
—
noreply /
githubweb