Skip to content
Changes
- Fixes for fill_holes and edsclr code (#1266)
—
noreply /
githubweb
- Grid reverse matrix test (#1265)
—
noreply /
githubweb
- Add blank line to README.
—
noreply /
githubweb
- BIT_CHANGING bug fix for the penta_lu solver, only BC when using penta_solve_method=2 (#1264)
—
noreply /
githubweb
- Bicgstab addition (#1261)
—
noreply /
githubweb
- Small bug fix to make gfortran+debug happy, without the _core_rknd this could be a potential type error
—
Gunther Huebler /
githubweb
- Making update_xp2_mc work with either grid mode (#1263)
—
noreply /
githubweb
- Improving variable name
—
Gunther Huebler /
githubweb
- Small bug fix, but this is BIT_CHANGING because it affects stats output. Some zm fields (w_1_zm, w_2_zm, varnce_w_1_zm, varnce_w_2_zm, and mixt_frac_zm) were all nan in the netcdf output when l_call_pdf_closure_twice=.false., because those come from pdf_params_zm.
—
Gunther Huebler /
githubweb
- Removing accidentally added files
—
Gunther Huebler /
githubweb
- Making clubb_at_least_debug_level not a device routine. It confuses the poor little nvidia compiler when compiling inside cam. Also making the compile script a little more robust.
—
Gunther Huebler /
githubweb
- New fill_holes methods (#1262)
—
noreply /
githubweb
- Making compatible with new version of clubb (#167)
—
noreply /
githubweb
- Small bug fix in fill_holes_parallel on GPU
—
Gunther Huebler /
githubweb
- Adding Morrison_microphys folder inside Microphys and reflecting change in compilation files. This is to make this new structure work with the way we include Morrison code, which is brought in from sam_clubb via the updateClubbMorrison.sh found in sys_admin/gitUpdateScripts/
—
Gunther Huebler /
githubweb
- Clubb driver upgrades part2 (#1257)
—
noreply /
githubweb
- Must add -fopenmp back for now, since this is used for the openmp test and it also broke the BFB tests for an obnoxious reason - that test compiles each commit without cleaning the build, so the baseline commit had -fopenmp and compiled with openmp stuff enabled, but then the subsequent commits had it turned off, but no changes in the files, so it didn't recompile with it off, and only turned it off in the linking stage, causing a build error. RESOLVED:320551df13ee84bdb9280db0be788a36e1f03494 RESOLVED:6c0201d44694fadf7f4bb0d4d58c3a9871096a22 RESOLVED:26644de2ea83ee6335b273f54dd57afc8f6f4b0c
—
Gunther Huebler /
githubweb
- Adding -Mstack_arrays to the nvfortran flags causes us to use more stack space, which means we need to allow processes to use more stack space (when using lots of columns, since that increases memory footprint). We do by using using 'ulimit BIGNUMBER'.
—
Gunther Huebler /
githubweb
- Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true.
—
Gunther Huebler /
githubweb
- Modifying compiler configurations (mainly optimization level) in order to prepare for switching scipts and tests to cmake, specifically separating out this BIT_CHANGING commit from the rest
—
Gunther Huebler /
githubweb
- thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint.
—
Gunther Huebler /
githubweb
- Making restart test not overwrite time_initial. The time_initial should be defined by the _model.in file and not overwritten, but this script was setting time_initial to time_restart, which resulted in the initial iteration value (iinit) to be 1 in the restart regardless of the restart time.
—
Gunther Huebler /
githubweb
- Making the l_random_k_lh_start set the random generator seed before generating a random. This should fix the generalized grid test, which failed for the only flag set that turned on l_random_k_lh_start. Before, the test passed because we used the same random seed for all timesteps, preventing differences in the random call. But now we use a different seed each timestep, causing differences. To ensure reproducibility, we use the seed each timestep to generate rand_pool, which is an effective solution, but we need to do that for the rand_integer_in_range call in the l_random_k_lh_start code for the same reason. Since this does change the random that comes out, this is BIT_CHANGING, but only for runs using both SILHS and l_random_k_lh_start=.true.
—
Gunther Huebler /
githubweb
- SILHS reproducibility (#1258)
—
noreply /
githubweb
- Bug fix. This is BIT_CHANGING, but only on GPUs and only when l_soil_veg=.true. (which is only gabls3 currently).
—
Gunther Huebler /
githubweb
- Change tolerance in way that affects only single precision builds (#1256)
—
noreply /
githubweb
- Remove module vars from grid_adaptation_module (#1255)
—
noreply /
githubweb
- Precip frac fix (#1254)
—
noreply /
githubweb
- The cmake update (#1253)
—
noreply /
githubweb
- Making cmake only optionally use ninja. Now we only use it if it's available.
—
Gunther Huebler /
githubweb
- Adding expldiff budget terms for thlm and rtm (#1252)
—
noreply /
githubweb
- Raw-copy updating src/Morrison_microphys
—
Cole Pickett /
githubweb
- Increase lh_num_samples to 64 for LBA case
—
noreply /
githubweb
- Update License.txt in order to note that BIT_CHANGING:b5ec2335bc0cf95dbbe1f48a0043bb792a72d3c6
—
noreply /
githubweb
- Clean out clubb_G_unit_reverse_dir_grid_test folder before running Jenkins test
—
noreply /
githubweb
- Finished my notes, documentation, and instructions for the generalized
—
bmg2 /
githubweb
- I start adding some notes on grid generalization.
—
bmg2 /
githubweb
- fix precision error of reals
—
noreply /
githubweb
- rename grid_adaptation and remapping modules
—
0-freundlich-adenin /
githubweb
- add fix for grid generalization
—
0-freundlich-adenin /
githubweb
- Merge grid adaptation implementation (#1249)
—
noreply /
githubweb
- I am adding pass/fail statements specific to the generalized grid test
—
bmg2 /
githubweb
- For the long-duration clubb_generalized_vertical_grid_test, I am
—
bmg2 /
githubweb
- zm and zt were mixed up in the error prints argument list.
—
bmg2 /
githubweb
- I updated run_bindiff_w_flags_config_host_flags to add flag set 3,
—
bmg2 /
githubweb
- Fix jenkins clubb error handling output (#1247)
—
noreply /
githubweb
- Removed simple wrappers from clubb_api_module (#1245)
—
noreply /
githubweb
- Fixed and equalized NaN checks in lapack_wrap (#1246)
—
noreply /
githubweb
- Cleaning up some grid generalization issues that were found within
—
bmg2 /
githubweb
- Run scm fixes (#1244)
—
noreply /
githubweb
- I am adding a new .json file for host model flags. Flag set 1 consists
—
bmg2 /
githubweb
- I am adding a Jenkinsfile for a new CLUBB generalized vertical
—
bmg2 /
githubweb
- I am adding a second set of host flags as part of the generalized
—
bmg2 /
githubweb
- Fixing an error in the previous commit. (lol, good ol' find and replace)
—
bmg2 /
githubweb
- Removed renaming operators `=>` and wrapper subroutines from silhs_api_module (#1240)
—
noreply /
githubweb
- Changing readme to add BIT_CHANGING:71eb9b3c5fd65c33905f17be8476a1dea89a2511 since that commit was a bug fix, so technically it was bit changing.
—
Gunther Huebler /
githubweb
- Small bug fix that has somehow gone unfound until recently. RESOLVED:f9d92113871bdf87b5e3147db6740ab654dc0967
—
Gunther Huebler /
githubweb
- Technically, the following two commits are not BFB
—
noreply /
githubweb
- Running CLUBB with l_stability_correct_tau_zm = .true. now requires
—
bmg2 /
githubweb
- These changes were accidentally made during the previous commit. The are
—
bmg2 /
githubweb
- Err code gpu fix (#1241)
—
noreply /
githubweb
- Fix segfault involving initialization of CLUBB when l_add_dycore_grid=F
—
Steffen Domke /
githubweb
- Removed unnecessary print statements in clubb_driver
—
Steffen Domke /
githubweb
- Err code struct (#1238)
—
noreply /
githubweb
- Fix that causes BFB GPU tests to break. We need to copy these variables to the CPU before outputtin to disk. It's very unclear why the BFB GPU test ever passed without this.
—
Gunther Huebler /
githubweb
- I updated adj_low_res_nu for use with a generalized grid. It is
—
bmg2 /
githubweb
- Since the call to adj_low_res_nu is not tested by CLUBB's main
—
bmg2 /
githubweb
- Add a blank line to README in order to note BIT_CHANGING:969bc4aa2a1db2664c0f92b98d2df5544c554c32
—
noreply /
githubweb
- Clubb silhs gg (#1239)
—
noreply /
githubweb
- Second hot fix for more _init variables that need to be copied in. RESOLVED:ed9ae72a5eb28dbc036dd3e14b9312eea840feac
—
Gunther Huebler /
githubweb
- Third hotfix of the day. This last change teased out a sneaky potentially fatal bug for cases using l_cloud_sed=.true., making this a BIT_CHANGING fix. Also need to include BIT_CHANGING:13ad3cfe7872df2fe91250265f4a81baa621a882 because that was a fix to a fatal bug in some cases. Also including some other small fixes that weren't breaking any tests, but might've caused problems in the future.
—
Gunther Huebler /
githubweb
- Removing accidentally added file.
—
Gunther Huebler /
githubweb
- Clubb driver upgrades (#1225)
—
noreply /
githubweb
- Hot fix to GPU code. These _init variables need to be copied to the GPU
—
Gunther Huebler /
githubweb
- QuadTune: Read in obs for custom metrics automatically from obs file.
—
Vince Larson /
githubweb
- QuadTune: Rename "setUpInputs" to "setUpConfig". Rename other variables. Improve comments in quadtune_driver.py.
—
Vince Larson /
githubweb
- QuadTune: Create config file where a user can input "namelist" info about his obs and simulations. Also add an example config file so that the user can keep multiple namelists. Do minor refactorings.
—
Vince Larson /
githubweb
- QuadTune: Rename "linSoln" to "globTuned" in order to denote the global simulation result after tuning. Add docstrings to more functions.
—
Vince Larson /
githubweb
- Clubb test correct gg (#1237)
—
noreply /
githubweb
- QuadTune: Move import statements to top of file. Move abbreviateParamsNames to set_up_inputs. Neaten source code a bit.
—
Vince Larson /
githubweb
- QuadTune: Set plot-type flags in set_up_inputs.py and then feed them into create_nonbootstrap_figs.py.
—
Vince Larson /
githubweb
- QuadTune: Improve plot titles, add (a), (b), (c) to subpanels, etc.
—
Vince Larson /
githubweb
- QuadTune: Remove dependence of QuadTune code on file analyze_sensitivity_matrix.py.
—
Vince Larson /
githubweb
- QuadTune: Rename files.
—
Vince Larson /
githubweb
- QuadTune: Shut off bootstrap fig display, set useBootstrap=F, and improved fonts on scatterplots.
—
Vince Larson /
githubweb
- Updating the Jenkinsfile for the CLUBB generalized vertical grid test
—
bmg2 /
githubweb
- Revert "When the run_clubb_w_varying_flags.py script is running a generalized"
—
bmg2 /
githubweb
- One of the previous issues with this python script is that it
—
bmg2 /
githubweb
- I am setting the exit_code for the python script to be based on
—
bmg2 /
githubweb
- I added some helpful print statements and imported "sys" for the
—
bmg2 /
githubweb
- Changing the generalized vertical grid Jenkins test to use the new
—
bmg2 /
githubweb
- When the run_clubb_w_varying_flags.py script is running a generalized
—
bmg2 /
githubweb
- I added a stripped down version of the run_bindiff_w_flags.py script
—
bmg2 /
githubweb
- The generalized grid test should not output a clubb fatal error when it
—
bmg2 /
githubweb
- Revert "I have no idea if it's appropriate to include gr in this statment,"
—
bmg2 /
githubweb
- Added a special G unit Jenkins test for the Reverse Direction
—
bmg2 /
githubweb
- I accidentally committed G_unit_tests.in as part of my previous commit.
—
bmg2 /
githubweb
- I forgot to update the test name in the Jenkinsfile.
—
bmg2 /
githubweb
- I discovered that I inadvertently change an $acc statement that
—
bmg2 /
githubweb
- Eliminate GOTO statement in stats_clubb_utilities (#1233)
—
noreply /
githubweb
- Updated Jenkins api_commitment_test to python3 (#1235)
—
noreply /
githubweb
- Fixed Jenkins api_commitment_test (#1236)
—
noreply /
githubweb
- Added some missing acc parallel statments around some the loops
—
bmg2 /
githubweb
- Fixed a bug
—
bmg2 /
githubweb
- I have no idea if it's appropriate to include gr in this statment,
—
bmg2 /
githubweb
- I changed the variable type within grid function flip from dp to
—
bmg2 /
githubweb
- Fixed a compiling issue with CAM-CLUBB.
—
bmg2 /
githubweb
- Hopefully this helps the cpu vs. gpu tests.
—
bmg2 /
githubweb
- There were some flips inside the stats code for BUGSrad that required
—
bmg2 /
githubweb
- Updated calls to some CLUBB subroutines in the wake of recent CLUBB
—
bmg2 /
githubweb
- Generalized grid (#1230)
—
noreply /
githubweb
- Regrouped to decrease the total number of runs.
—
bmg2 /
githubweb
- Added a .json file for run_bindiff_w_flags that checks most of
—
bmg2 /
githubweb
- add requirements file for run_bindiff_w_flags script
—
noreply /
githubweb
- Removed renaming operators `=>` from clubb_api_module (#1232)
—
noreply /
githubweb
- fix variable l_sfc_already_initialized (#1231)
—
noreply /
githubweb
- Getting rid of a couple of worthless lines of code. It's possible this
—
bmg2 /
githubweb
- Should just delete instead of commenting out.
—
bmg2 /
githubweb
- Revert clubb api module changes (#1228)
—
noreply /
githubweb
- Fixed equality check in pdf_closure_module (#1229)
—
noreply /
githubweb
- add dycore grid with conservative remapping scheme
—
noreply /
githubweb
- Remove err code (#1218)
—
noreply /
githubweb
- Renamed check_res to err_code in numerical_check.F90 for consistency (#1227)
—
noreply /
githubweb
- Set l_wp2_fill_holes_tke to true by default (#1226)
—
noreply /
githubweb
- BIT_CHANGING bug fix that only affects l_t_dependent cases running with multiple columns, I detected this with cgils cases, but I'm not sure how it slipped through initially.
—
Gunther Huebler /
githubweb
- QuadTune: Made plot_PcSensMap work when len(varPrefixes) > 1.
—
Vince Larson /
githubweb
- QuadTune: Merge in bootstrap sampling
—
noreply /
githubweb
- Swapping the loop order on a few kernels, I found this faster for the nvhpc compiler and it's BFB
—
Gunther Huebler /
githubweb
- Monoflux GPU optimization (#1221)
—
noreply /
githubweb
- QuadTune: Add useLongTitle option, which adds extra information on the plotted quantity, if desired.
—
Vince Larson /
githubweb
- QuadTune: Plot bias instead of negative bias on metricsBarChart and bias-vs-sensitivity plots.
—
Vince Larson /
githubweb
- QuadTune: On matrix-eqn bar chart, plot only extraMetricsToPlot. Add sens-bias scatterplot of only extraMetricsToPlot. In parameter increments bar chart, change absolute values to squares.
—
Vince Larson /
githubweb
- Slightly relaxing the convergence criteria to fix convergence test.
—
Gunther Huebler /
githubweb
- Finally fixing gpu_diffness test (#1219)
—
noreply /
githubweb
- Added new hole-filling method which takes TKE from up2 and vp2 (#1217)
—
noreply /
githubweb
- Fix binormal correlation clipping (#1199)
—
noreply /
githubweb
- QuadTune: Remedy loss function and facilitate plotting of special, non-20x20 regions (DYCOMS, HAWAII, etc.).
—
Vince Larson /
githubweb
- Changing a couple loop limits in mono flux limiter.
—
bmg2 /
githubweb
- Recoded a loop within the mono flux limiter so that it's written
—
bmg2 /
githubweb
- Changed some variable names so that it is clear that, while they contain
—
bmg2 /
githubweb
- Within the mono flux limiter, a thermodynamic-level variable needed to
—
bmg2 /
githubweb
- I forgot to add the new variable to the Atlantic Coast Conference
—
bmg2 /
githubweb
- QuadTune: Include special regions (DYCOMS, HAWAII, etc.), in addition to 20x20 regions. However, the weights are set to epsilon, which wrecks the loss calculation. This will have to be remedied later.
—
Vince Larson /
githubweb
- QuadTune: Add map plots of "linSoln" output from global E3SM runs.
—
Vince Larson /
githubweb
- Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216)
—
noreply /
githubweb
- Added up2 and vp2 to calculation of wp2_min_array (#1215)
—
noreply /
githubweb
- QuadTune: Add bar chart showing linear vs. nonlinear contributions of each parameter.
—
Vince Larson /
githubweb
- QuadTune: 1) Add bar chart that shows |metric_changes| due to each parameter. 2) Fix colorbars on maps. 3) Allow download of hi-res figures. 4) Make background of scatterplots grey.
—
Vince Larson /
githubweb
- Reduced the upper bound for wp2_min_array to 1.0 (#1214)
—
noreply /
githubweb
- Likely non-bit-changing housekeeping (#1213)
—
noreply /
githubweb
- Fix pyplotgen timeheight cmaps (#1212)
—
noreply /
githubweb
- QuadTune: 1) Change coloring of scatterpoints to represent either loss changes or residuals. 2) Add map of residuals to complement map of bias.
—
Vince Larson /
githubweb
- QuadTune: Added colorbars to regional map plots.
—
Vince Larson /
githubweb
- Multi col output update (#1211)
—
noreply /
githubweb
- QuadTune: Plot a map of the change in the loss function for each region.
—
Vince Larson /
githubweb
- Fixed time-height plot colormaps (#1210)
—
noreply /
githubweb
- Clubb Driver Semi GPUization Part4 (#1209)
—
noreply /
githubweb
- Multi Column Mirror Test (#1206)
—
noreply /
githubweb
- As part of generalizing the code to work with both an ascending and
—
bmg2 /
githubweb
- QuadTune: 1) Create new plot that shows tuning tradeoffs via U dot bias. 2) Improve bar chart showing the mean contribution of different parameters.
—
Vince Larson /
githubweb
- Making a correction to the doubled plus sign from commit a1fcfe8.
—
bmg2 /
githubweb
- Moving Lscale from an acc create statement inside clubb to the acc output statement in clubb_api. This is bug fix that is BIT_CHANGING, but only for silhs cases running on the GPU. Also using this to add BIT_CHANGING:aff1bb12551c5b3a8ab1c4d773ef5c17fb96c53b, as that commit was BC but just missing the message.
—
Gunther Huebler /
githubweb
- Various Small Tweaks (#1205)
—
noreply /
githubweb
- QuadTune: Plot orange x on threeDot panels in order to represent what change QuadTune actually wants to make to the metrics.
—
Vince Larson /
githubweb
- Prescribe Forcings GPUization (#1204)
—
noreply /
githubweb
- QuadTune: Fix commit bug and add numXBoxes.
—
Vince Larson /
githubweb
- Prescribe forcings loop pushing (#1201)
—
noreply /
githubweb
- BIT_CHANGING bug fix with soil veg (#1200)
—
noreply /
githubweb
- QuadTune: Break out loss function contributions by metric and plot the metrics with the greatest improvements and degradations.
—
Vince Larson /
githubweb
- QuadTune: Break out loss function contributions by metric and plot the metrics with the greatest improvements and degradations.
—
Vince Larson /
githubweb
- Small improvements to bindiff script.
—
Gunther Huebler /
githubweb
- QuadTune: Create 2 new plots.
—
Vince Larson /
githubweb
- QuadTune: Display maps of the first 4 SVD patterns using dash, rather than make_subplots.
—
Vince Larson /
githubweb
- I am making the loops for the wp3 ta term (using ADG1 PDF) symmetric.
—
bmg2 /
githubweb
- QuadTune: 1) Add beginnings of maps of SVD pattern, although this task is unfinished. 2) Normalize all regions by global mean, rather than normalizing each region separately. 3) Make sensitivities signed in sensitivity versus bias scatterplot.
—
Vince Larson /
githubweb
- Add sam bv calc (#1141)
—
noreply /
githubweb
- Updates to jenkins scripts.
—
Gunther Huebler /
githubweb
- Updating script usage in plot tests.
—
Gunther Huebler /
githubweb
- remove Lscale, Lscale_up and Lscale_down from stat_fields_reader and restart_clubb call and remove recalculation of Lscale Ticket #1166 (#1197)
—
noreply /
githubweb
- Adding multi_col cases to run_bindiff.py and adding new multicol BFBness test.
—
Gunther Huebler /
githubweb
- Renaming some jenkins tests and making them use a new directory
—
Gunther Huebler /
githubweb
- Changing test name to indicate that it runs on GPUs.
—
Gunther Huebler /
githubweb
- QuadTune: Use SVD to approximate the sensitivity matrix, `normlzdSensMatrixPoly`, and curvature matrix, `normlzdCurvMatrix`.
—
Vince Larson /
githubweb
- Fix time height plots (#1196)
—
noreply /
githubweb
- QuadTune: De-bias matrix before calculating parameter correlations, add comments about definition of residual, include metric name in hover text.
—
Vince Larson /
githubweb
- QuadTune: De-bias matrix before calculating parameter correlations, add comments about definition of residual, include metric name in hover text.
—
Vince Larson /
githubweb
- QuadTune: Revise PCA biplot and clarify how variables are masked.
—
Vince Larson /
githubweb
- add run_bindiff_w_flags.py script. #1181 pull request #1194
—
noreply /
githubweb
- Multicol CLUBB (#1193)
—
noreply /
githubweb
- Added rcm-background to pyplotgen animations (#1195)
—
noreply /
githubweb
- QuadTune: Allow QuadTune to simultaneously tune for multiple 20x20 fields, e.g., SWCF, LWCF, and PRECT.
—
Vince Larson /
githubweb
- Added min_max_smth_mag as a Fortran parameter to constants_clubb.F90 (#1192)
—
noreply /
githubweb
- QuadTune: Create SVD plot, start to add checks on global means (unfinished), and start to add capability to include multiple fields (SWCF, LWCF, etc.) in metrics (unfinished).
—
Vince Larson /
githubweb
- add Lscale intent(out) to advance_clubb_core and advance_clubb_core_api (#1190)
—
noreply /
githubweb
- Bindiff script (#1191)
—
noreply /
githubweb
- Mono Flux Optimizations (#1189)
—
noreply /
githubweb
- refactoring to remove compiler warnings (#1187)
—
noreply /
githubweb
- Added requirements.txt for running the sens_matrix_dashboard.
—
hasenau2 /
githubweb
- QuadTune: Introduce new utility function to create scatterplots and plot first 2 SVD components.
—
Vince Larson /
githubweb
- I am copying the round-off level changes made to grid weights
—
bmg2 /
githubweb
- Ri zm calc cleanup (#1186)
—
noreply /
githubweb
- Monoflux test (#1188)
—
noreply /
githubweb
- Fixing bug. This loop has a vertical dependency prevent the use of collapse(2). See https://github.com/larson-group/cam/issues/175\#issuecomment-2261283301
—
Gunther Huebler /
githubweb
- Small bug fix
—
Gunther Huebler /
githubweb
- New/new_hybrid PDF Stats Removal (#1185)
—
noreply /
githubweb
- Copyout Nuke (#1182)
—
noreply /
githubweb
- QuadTune: Print leverage values and make other minor refactorings.
—
Vince Larson /
githubweb
- Remove radf variable from CLUBB call
—
noreply /
githubweb
- Initializing total_mismatches to zero.
—
Gunther Huebler /
githubweb
- Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack.
—
Gunther Huebler /
githubweb
- QuadTune: Add check of global-mean SWCF OBS, plus clean up unneeded comments.
—
Vince Larson /
githubweb
- reduce compiler warnings (#1180)
—
noreply /
githubweb
- QuadTune: Add check of global-mean SWCF.
—
Vince Larson /
githubweb
- refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179)
—
noreply /
githubweb
- Removing duplicate definition of edsclr when CLUBB_CAM is defined.
—
Gunther Huebler /
githubweb
- Ri zm calc6 (#1177)
—
noreply /
githubweb
- change loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173)
—
noreply /
githubweb
- Ri zm calc5 (#1175)
—
noreply /
githubweb
- QuadTune: Add column parameter vector and equals sign to sens matrix equation plot.
—
Vince Larson /
githubweb
- Updating tuner code to include an option to save all netcdf files (#1171)
—
noreply /
githubweb
- Update documentation for QuadTune.
—
noreply /
githubweb
- Change variables from a1 and a3 to a1_coef and a3_coef
—
Vince Larson /
githubweb
- Update README so that it mentions run_bindiff_all.py
—
noreply /
githubweb
- Well, this will probably anger the Grim Reaper, but I have finally
—
bmg2 /
githubweb
- QuadTune: Use quadratic programming to calculate the smallest dparam needed to debias 2 regions.
—
Vince Larson /
githubweb
- Ri zm calc4 (#1168)
—
noreply /
githubweb
- Ri_zm calc (Part 4) - Implementing calc_Ri_zm (#1160)
—
noreply /
githubweb
- Updates pyplotgen's readme
—
noreply /
githubweb
- change opencv requirement to use headless and update Pillow minor
—
0-freundlich-adenin /
githubweb
- QuadTune: Plots subsets of 20x20-degree regions.
—
Vince Larson /
githubweb
- Small bugs fix in bugsrad code. This was only caught when compiling with intel debug and using '-warn all', which compares interface dimensions/declaration between files.
—
Gunther Huebler /
githubweb
- Variable name correction in acc data statement.
—
Gunther Huebler /
githubweb
- Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine.
—
Gunther Huebler /
githubweb
- Making radf size correct in api and clubb_driver.
—
Gunther Huebler /
githubweb
- Updated for ghostless version of CLUBB.
—
bmg2 /
githubweb
- Raw-copy updating src/Morrison_microphys
—
Cole Pickett /
githubweb
- Clubb ghost exorcism (#1159)
—
noreply /
githubweb
- Updated the README to explain the grid notations gr%nzm and gr%nzt,
—
bmg2 /
githubweb
- Slight variable name change in attempt to get the Update Master Output step to run.
—
Gunther Huebler /
githubweb
- Nightly clubb plots (#1167)
—
noreply /
githubweb
- Changing openacc to openmp migration repo to a fork with a change to switch the order of copyins and copies. This is to allow us to only copyin the pdf_params structure, but copy the internal arrays. When the copying of the internal arrays happens first, followed by the copyin of the structure, we overwrite the pointers to the internal arrays on the GPU version of the structure. Hence why we want the copyins to precede the copy statements.
—
Gunther Huebler /
githubweb
- Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)
—
noreply /
githubweb
- Moving PosInf to clubb_model_settings.F90
—
Gunther Huebler /
githubweb
- Updating input fields so that the zt2zm function is used for
—
bmg2 /
githubweb
- Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175
—
Gunther Huebler /
githubweb
- Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.
—
Gunther Huebler /
githubweb
- Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.
—
Gunther Huebler /
githubweb
- When l_vert_avg_closure is enabled, the flags l_call_pdf_closure_twice,
—
bmg2 /
githubweb
- Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp.
—
bmg2 /
githubweb
- Fixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175
—
Gunther Huebler /
githubweb
- Updates README so that I can note that BIT_CHANGING:9ca167aa8b04cbebe4a1177a72f13731454e1e11
—
noreply /
githubweb
- Committing a change that will initialize this set of variables
—
bmg2 /
githubweb
- There were furhter issues found with the k_lh_start code.
—
bmg2 /
githubweb
- Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)
—
noreply /
githubweb
- In my previous commit, I changed the domain of the maxloc commands
—
bmg2 /
githubweb
- This commit brings the stats output from the all cases run with
—
bmg2 /
githubweb
- Setting the value of K_hm to 0 at the non-interactive upper and lower
—
bmg2 /
githubweb
- I am committing changes to stats output for cloud_cover, rcm_in_layer,
—
bmg2 /
githubweb
- QuadTune: Adds arrow plot and plot of bias vs. a diagnostic field such as U10.
—
Vince Larson /
githubweb
- I am making this commit because, as part of deghosting, I discovered 2
—
bmg2 /
githubweb
- I am updating the snowslope output stat so it matches bit-for-bit
—
bmg2 /
githubweb
- I am updating the SILHS code that calculates k_lh_start to work
—
bmg2 /
githubweb
- This technically BIT_CHANGING commit is being made to keep results in
—
bmg2 /
githubweb
- Replacing pgi references with nvhpc, and adding nvhpc_debug config script along with new jenkins tests.
—
Gunther Huebler /
githubweb
- Removing flag meant for gpu debugging.
—
Gunther Huebler /
githubweb
- This code in adj_low_res_nu was using the ghost point when
—
bmg2 /
githubweb
- Making jenkins bit diff tests only run on carson. This is because these tests are defined by a file we store on carson that needs to be updated after each test.
—
Gunther Huebler /
githubweb
- Making our mkl compile config work directly in the compile script rather than relying on a correspondence with the config files. Also settig main config scripts to use new ifx compiler.
—
Gunther Huebler /
githubweb
- Removing allocatable status of some variables. These need not be declared allocatable and ifx seems to have a problem with it. The allocatable status is an artifact from when we had these as arrays of initially unknown size.
—
Gunther Huebler /
githubweb
- Fixing the run agent to be carson, since it has the only GPU capable of running with openmp gpu offloading.
—
Gunther Huebler /
githubweb
- Spack updates (#1158)
—
noreply /
githubweb
- Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)
—
noreply /
githubweb
- Testing the new module system with our GPU diffness test. See https://github.com/larson-group/sys_admin/issues/829
—
Gunther Huebler /
githubweb
- The module system is setup via paths in /etc/profile.d/larson-group.sh, so we need to source it. https://github.com/larson-group/sys_admin/issues/829
—
Gunther Huebler /
githubweb
- Fixing bug in jenkinsfiles.
—
Gunther Huebler /
githubweb
- QuadTune: Feeds in 20degree_CAM_TAUS_202404 runs.
—
Vince Larson /
githubweb
- QuadTune: Feeds in 20degree_CAM_TAUS_2020404, take 2.
—
Vince Larson /
githubweb
- Updated the turbulent sedimentation code to account for ghost point
—
bmg2 /
githubweb
- This commit fixes 2 issues in regards to hydrometeor sedimentation:
—
bmg2 /
githubweb
- Adds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3e
—
noreply /
githubweb
- QuadTune: Adds more flags to toggle plots.
—
Vince Larson /
githubweb
- Ri zm calc (Part 1) - Combine and move call to calc_brunt_vaisala_freq_sqd (#1154)
—
noreply /
githubweb
- Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155)
—
noreply /
githubweb
- QuadTune: Uses flags to shut off calculations for unwanted plots.
—
Vince Larson /
githubweb
- Making CPU vs GPU jenkins test compare openmp code also.
—
Gunther Huebler /
githubweb
- This allows the conversion script to be called anywhere.
—
Gunther Huebler /
githubweb
- Fixing bug in jenkinsfiles.
—
Gunther Huebler /
githubweb
- QuadTune: Clarifies some plot titles.
—
Vince Larson /
githubweb
- QuadTune: Customizes metrics shown in parameter adjustment bar chart.
—
Vince Larson /
githubweb
- QuadTune: Customizes inputs to threeDotFig.
—
Vince Larson /
githubweb
- I fixed a bug where the array declarations for X_mixt_comp_all_levs,
—
bmg2 /
githubweb
- QuadTune: Removes LWCF and PRECT from 2-point dpMin plot.
—
Vince Larson /
githubweb
- Making the only change required to make clubb run with openacc in cam.
—
Gunther Huebler /
githubweb
- QuadTune: Moves plotting code to new fnc, createFigs.
—
Vince Larson /
githubweb
- Making the f in f90 capital for consistency.
—
Gunther Huebler /
githubweb
- Surrounding print statement with debug flag check.
—
Gunther Huebler /
githubweb
- Making multicol diffness script rely on the largest difference detected, rather the the sum/total of differences. This is essentially to relax the cpu vs gpu diffness test because mpace_b is noisey and often causes the test to fail for innocent bit changing commits. Looking at the largest difference does have the advantage of the check being less sensitive to case differences, such as number of timesteps, vertical levels, number of columns, etc.
—
Gunther Huebler /
githubweb
- The variable rc_coef_zm needed to be passed in and saved from
—
bmg2 /
githubweb
- QuadTune: Brings in CAM regional files.
—
Vince Larson /
githubweb
- Fixing a bug. Does not change default results.
—
bmg2 /
githubweb
- Fixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs.
—
Gunther Huebler /
githubweb
- gr%zm should be used here instead of gr%zt, since these are
—
bmg2 /
githubweb
- Thermodynamic-level (zt) values should be used with zt-variable
—
bmg2 /
githubweb
- Jupyter Notebooks for proving formulas (#1151)
—
noreply /
githubweb
- Adding extra exclamation to acc statement to comment it out.
—
Gunther Huebler /
githubweb
- Making compatible with latest clubb changes.
—
Gunther Huebler /
githubweb
- I am committing code that effectively ignores the values of certain
—
bmg2 /
githubweb
- I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the
—
bmg2 /
githubweb
- Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.
—
Gunther Huebler /
githubweb
- Raw-copy updating src/Morrison_microphys
—
Cole Pickett /
githubweb
- Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.
—
Gunther Huebler /
githubweb
- Moved the ghost-point setting of xm(1) = xm(2) to the last line
—
bmg2 /
githubweb
- Optional arguments are just best sometimes (#1150)
—
noreply /
githubweb
- Adding space to include BIT_CHANGING:84588a46852a812266d19e36a8220f71ad56043a. This (https://github.com/larson-group/clubb/commit/84588a46852a812266d19e36a8220f71ad56043a) is described as not bit changing, but that seems to depend on the compiler version and some flags. The bin diff tests detected differences in only twp_ice when using e3sm flags on nelson, and both e3sm flags and default flags on carson.
—
Gunther Huebler /
githubweb
- I'm changing the way ddzt handles the derivative over momentum level 1.
—
bmg2 /
githubweb
- Changing the linear interpolation in the zt2zm function at momentum
—
bmg2 /
githubweb
- Committing some thresholding around positive-definite fields after
—
bmg2 /
githubweb
- I am committing a stats change to the ghost point values of zt
—
bmg2 /
githubweb
- Adding -noacc to nvhpc openmp config script, sometimes nvhpc compiles acc code automatically, and this shuts it off.
—
Gunther Huebler /
githubweb
- I am committing a bug fix to the code that calculates mixed Brunt
—
bmg2 /
githubweb
- While it doesn't affect results, I fixed what appears to be an
—
bmg2 /
githubweb
- I am updating the loop in subroutine diagnose_xpwp so that it doesn't
—
bmg2 /
githubweb
- This commit is being made to keep the stats zt output from the
—
bmg2 /
githubweb
- Making change to add RESOLVED:a492228d3adfed56f8777d12176fcd7d165260f6, which was technically bit changing because it undid changes to the config flags AND was tested relative to the previous commit (which introduced the flag changes) because that one was labelled as bit changing.
—
Gunther Huebler /
githubweb
- It was discovered that the location where the ghost point values
—
bmg2 /
githubweb
- I accidentally committed a couple things in the previous commit
—
bmg2 /
githubweb
- Pushing loop into calc_ref_z_linear_thvm to prevent erroneous inlining optimizations by nvfortran. This is BFB on nvhpc 24.3 with -O0 and BFB on nvhpc 22.5 with -O2. https://github.com/larson-group/clubb/issues/1148
—
Gunther Huebler /
githubweb
- Making commit to test jenkins.
—
Gunther Huebler /
githubweb
- The code that advances um and vm when l_predict_upwp_vpwp is turned off
—
bmg2 /
githubweb
- At the ghost point below the surface, which does not matter in
—
bmg2 /
githubweb
- Fixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false.
—
Gunther Huebler /
githubweb
- Adding space to make commit because last commit RESOLVED:35d228ebbb66b1463f30659321cd4f7d76adffa2
—
Gunther Huebler /
githubweb
- Fixing a bug. These directives get added when running the ACC to OMP conversion script. I'm unsure how I accidentally commited this, and equally unsure of how only one file is affected. This was found while debugging the clubb thread test
—
Gunther Huebler /
githubweb
- Putting ngrdcol in clubb_params (#1147)
—
noreply /
githubweb