Skip to content
Success

Changes

Summary

  1. Add blank line to trigger Jenkins tests (details)
  2. Fixed bug in cubic equation solve function. Only relevant if pdf is L… (#1387) (details)
Commit af934ad3986d77e381919822755fc51a0168849f by noreply
Add blank line to trigger Jenkins tests
The file was modifiedREADME (diff)
Commit a8c952996409f8c94d6a28714171145ed7d2c2ae by noreply
Fixed bug in cubic equation solve function. Only relevant if pdf is L… (#1387)

* Fixed bug in cubic equation solve function. Only relevant if pdf is Luhar or iiPDF_type=4

Therefore technically BIT_CHANGING...
The bug existed because the old code used the principal cube root
which has an imaginary part for negative bases.
The fix is to simply calc: -|w|**(1/3) for negative real numbers.

* Replaced determinant with discriminant

Verified via a new Fortran unit test and also manually checked with wolfram alpha.
There is no way to actually run this code :/
would only work for iiPDF_types: iiPDF_3D_Luhar = 3 and iiPDF_3D_Luhar = 3
(and those are currently (Oct 2026) broken )
The file was modifiedsrc/G_unit_tests.F90 (diff)
The file was modifiedsrc/G_unit_test_types/CMakeLists.txt (diff)
The file was modifiedinput_misc/G_unit_tests.in (diff)
The file was addedsrc/G_unit_test_types/cubic_solve_tests.F90
The file was modifiedsrc/CLUBB_core/calc_roots.F90 (diff)
The file was modifiedtests/run_G_unit_tests.py (diff)