Skip to content
Success

Changes

Summary

  1. refactoring to remove compiler warnings (#1187) (details)
  2. refactoring to remove compiler warnings (#1187) (details)
  3. remove unused dummy arguments (#182) (details)
  4. I am copying the round-off level changes made to grid weights (details)
Commit e25a2a10f127157f8f597674d2b1a2478dc96a7c by noreply
refactoring to remove compiler warnings (#1187)

* refactor code to remove warnings for exceeding 100 characters per line

* remove unused variables

* remove unused parameters #1174

* fix for the GPU

* remove new unused parameters

* remove unused dummy arguments

* make small changes to reduce compiler warnings

* put solve_name back in as input variable to band_solve methods

* combine intent in and out parameters from calc_trapezoid_zm and calc_trapezoid_zt to intent inout parameters

* remove unused functions init_parameters_999 and sat_vapor_press_ice_*

* remove unused dummy arguments

* fix merge error

* remove unnecessary loop
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified parameters_tunable.F90 (diff)
The file was modified saturation.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified fill_holes.F90 (diff)
Commit ade7da06f81dbd0fc358fb9ca8e63a50b9538664 by noreply
refactoring to remove compiler warnings (#1187)

* refactor code to remove warnings for exceeding 100 characters per line

* remove unused variables

* remove unused parameters #1174

* fix for the GPU

* remove new unused parameters

* remove unused dummy arguments

* make small changes to reduce compiler warnings

* put solve_name back in as input variable to band_solve methods

* combine intent in and out parameters from calc_trapezoid_zm and calc_trapezoid_zt to intent inout parameters

* remove unused functions init_parameters_999 and sat_vapor_press_ice_*

* remove unused dummy arguments

* fix merge error

* remove unnecessary loop
The file was modified silhs_api_module.F90 (diff)
Commit 07ecf4a3bc8df6091e7820434d4ccc473e5dcb05 by noreply
remove unused dummy arguments (#182)

These CAM changes correspond to CLUBB changes larson-group/clubb#1174 and larson-group/clubb#1187.
The file was modified src/physics/cam/clubb_intr.F90 (diff)
The file was modified src/physics/cam/subcol_SILHS.F90 (diff)
Commit 919336b9bc062541373a38408c9db3bc104f92e0 by bmg2
I am copying the round-off level changes made to grid weights
and grid interpolation functions from the generalized_grid branch
over to the master branch. This is being done ahead of merging
code from the master over to the generalized_grid branch.

This code is necessary to get results in the generalized grid
branch bit-for-bit between ascending and descending grid
directions when optimization is set to -O0.

This change produces changes at the numerical round-off level
in the affected calculations, making this commit BIT_CHANGING.

Plots show lines overlap for almost all cases besides the most
sensitive cases (ARM 97, TWP ICE, etc. -- looking at those
shows you how much of a difference a simple numerical round-off
can make).
The file was modified grid_class.F90 (diff)