Skip to content
Success

Changes

Summary

  1. Set `clubb_l_min_xp2_from_corr_wx = T` (details)
  2. Remove blank line in order to resolve (details)
  3. Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. (details)
  4. Now that uprcp and vprcp have been passed through advance_clubb_core, (details)
  5. I am adding more arguments to the argument list for advance_clubb_core (details)
  6. I am updating clubb_intr.F90 to account for new changes to the call (details)
  7. Fixed a goof. (details)
Commit 3e914cd46fbdbe4b2f76d36a49d99647dbd14b6f by noreply
Set `clubb_l_min_xp2_from_corr_wx = T`

and also set `clubb_l_min_wp2_from_corr_wx  = T`.  These are the correct settings
when `enable_relaxed_clipping = F`.  This code change is BIT_CHANGING.

For larson-group/clubb#846.
The file was modified bld/namelist_files/namelist_defaults_cam.xml (diff)
Commit ec7f7e65d116a8c30f6a6d2a6cbec61ec4d8b244 by noreply
Remove blank line in order to resolve

cam_coarse_res_bin_diff_regression_gfortran_test in Jenkins.
CAM was stopping because some idiot-proofing was blocking
the former flag settings, namely, `clubb_l_min_xp2_from_corr_wx = F`,
`clubb_l_min_wp2_from_corr_wx  = F`.  These values are now blocked
when `enable_relaxed_clipping = F`.

RESOLVED:45c07c927222e38de62dfe513875a416652866cc
RESOLVED:03b5534cf8ee3458340690cf5c15092844416d08

For larson-group/clubb#846.
The file was modified run_scripts/run_scam.bash (diff)
Commit 1e234f56b4722f109ec9d657776244a94dadfc18 by bmg2
Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
Commit aa0da18281105ee85a148af1640952342bc058ec by bmg2
Now that uprcp and vprcp have been passed through advance_clubb_core,
I can get rid of this idiot-proofing code that stops the run when
l_predict_upwp_vpwp is enabled and the PDF is in the "post" position.
The file was modified advance_clubb_core_module.F90 (diff)
Commit af8d23225e3393b52c07fbe123f01444d14124f0 by bmg2
I am adding more arguments to the argument list for advance_clubb_core
so that the model now runs with the PDF in the post position.

Result from this change are still bit-for-bit.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
Commit 9b0a9c2e869a0a687ea291ace9d3371a3210e642 by bmg2
I am updating clubb_intr.F90 to account for new changes to the call
to advance_clubb_core.
The file was modified src/physics/cam/clubb_intr.F90 (diff)
The file was modified src/physics/cam/clubb_intr.F90 (diff)