Skip to content
Success

Changes

Summary

  1. Revert clubb api module changes (#1228) (details)
  2. Adapt SAM to removal of module var err_code (#163) (details)
  3. Fixed equality check in pdf_closure_module (#1229) (details)
  4. add dycore grid with conservative remapping scheme (details)
  5. add dycore grid with conservative remapping scheme (details)
  6. add two new flags (#162) (details)
Commit 2913cd9a5b791c1e7248d2ad7dcfd89cfc9a2d0e by noreply
Revert clubb api module changes (#1228)

* Revert intent changes to err_code_api in clubb_api_module to stay consistent with host models
CLUBB ticket #975

Reverted changes in advance_clubb_core_api and to corresponding call in run_clubb

Since the module variable is not used anywhere anymore, we can also remove it from the module
The file was modified error_code.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
Commit b01ec967ae9e76504bd52b9f188c0330311406d0 by noreply
Adapt SAM to removal of module var err_code (#163)

Changed signature of stats_init_api
The file was modified SRC/SGS_CLUBB/clubb_sgs.F90 (diff)
Commit 20aceeaecd53a592cea775ac5def92cea74294bd by noreply
Fixed equality check in pdf_closure_module (#1229)

CLUBB ticket #975

WRF detected this error. Fixed it.
The file was modified pdf_closure_module.F90 (diff)
Commit bdaeacdc2600446ad65b582e5fdef98b97b6e8a8 by noreply
add dycore grid with conservative remapping scheme

* add tunable parameter interp_from_dycore_grid_method

* add dycore interpolation to atex case with conservative remapping by ullrich

* remove new gpu commands

* add acc annotation for gpu

* remove acc annotation again

* add acc annotation for parallel loop

* add acc annotations for parallel loop execution

* change remapping subroutine to take number of levels and levels as input instead of whole grid object

* add more general functions to interpolate

* add and refactor functions for remapping values given on zm levels

* fix compiler errors and refactoring to stay under 100 chars per line

* remove TODOs and used new interpolating function in interpolate_forcings

* add functions for adaptive grid generation and grid density function normalization

* add conservative ullrich remapping to cases with forcing time dependent inputs

* add grid adaptation and flag

* clean up and add warning for case when remapping from dycore flag cannot be used

* some refactoring

* add logical flag for dycore and renamed flags for dycore and grid adaptation

* remove ifdefs

* refactoring

* add units

* changed Lscale to inverse

---------

Co-authored-by: Steffen Carstensen <steffenc34@icloud.com>
The file was modified model_flags.F90 (diff)
The file was modified interpolation.F90 (diff)
The file was addedgrid_adaptation.F90
Commit 1c982448ebe93bd19f91fd62be6efc83f6394066 by noreply
add dycore grid with conservative remapping scheme

* add tunable parameter interp_from_dycore_grid_method

* add dycore interpolation to atex case with conservative remapping by ullrich

* remove new gpu commands

* add acc annotation for gpu

* remove acc annotation again

* add acc annotation for parallel loop

* add acc annotations for parallel loop execution

* change remapping subroutine to take number of levels and levels as input instead of whole grid object

* add more general functions to interpolate

* add and refactor functions for remapping values given on zm levels

* fix compiler errors and refactoring to stay under 100 chars per line

* remove TODOs and used new interpolating function in interpolate_forcings

* add functions for adaptive grid generation and grid density function normalization

* add conservative ullrich remapping to cases with forcing time dependent inputs

* add grid adaptation and flag

* clean up and add warning for case when remapping from dycore flag cannot be used

* some refactoring

* add logical flag for dycore and renamed flags for dycore and grid adaptation

* remove ifdefs

* refactoring

* add units

* changed Lscale to inverse

---------

Co-authored-by: Steffen Carstensen <steffenc34@icloud.com>
The file was modified configurable_model_flags.in (diff)
Commit 692fea3213dd74d61ad7a6570eeace23b08ea2c3 by noreply
add two new flags (#162)

* add two new flags

* revert changes to configurable_model_flags.in

* revert indentation

* add logical flag for dycore and renamed flags for dycore and grid adaptation
The file was modified SRC/SGS_CLUBB/clubb_sgs.F90 (diff)