Skip to content
Sign in
Success

Changes

Summary

  1. Updating python contract audit to better detect API arg list discrepancies from the underlying fortran arg lists. Also adding a temporary handoff file and improving the python api fix shortcut (details)
  2. Our argument_contract_audit.py script checks if the python_api matches the underlying fortran - this makes it more strict, and fixes many of the inconsistencies it found. (details)
  3. advance_clubb_core.py cleanup and removing strange compat_kwargs usages that seem like artifacts of laziness (details)
  4. Improving audit script even more, fixing issues it found. Also making advance_clubb_core.py nice and making an LLM shortcut for how to repeat the process (details)
  5. Building varying flags bindiff into run_bindiff_all.py, this just makes sense and helps fix the varying flags BFB test (details)
Commit 1ba1f81f6b41e649dfe497947dc4c22c69f38f6c by Gunther Huebler
Updating python contract audit to better detect API arg list discrepancies from the underlying fortran arg lists. Also adding a temporary handoff file and improving the python api fix shortcut

(cherry picked from commit 47106db56945d6d0c1f962cc77d205db99d60f4f)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/stats_clubb_utilities_wrapper.F90 (diff)
The file was modifiedclubb_python_api/tests/argument_list_enforcer/argument_contract_audit.py (diff)
The file was modifiedclubb_python_driver/advance_clubb_core.py (diff)
The file was modifiedclubb_jax/advance_clubb_to_end.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_clubb_core.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_xp3.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_stats_accumulate.py (diff)
The file was modifiedclubb_jax/advance_clubb_core.py (diff)
The file was addedLLM_prompts/python_api_audit_handoff.md
The file was modifiedclubb_python_api/tests/test_call_tree_advance_wp2_wp3.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_xm_wpxp.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/advance_xp3_module_wrapper.F90 (diff)
The file was modifiedclubb_python_api/clubb_f2py.pyf (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/stats_clubb_utilities.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/advance_xp2_xpyp_module_wrapper.F90 (diff)
The file was modifiedclubb_python_api/tests/test_argument_contract_audit.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_xm_wpxp.py (diff)
The file was modifiedclubb_jax/clubb_case_initalization.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_wp2_wp3.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/advance_wp2_wp3_module_wrapper.F90 (diff)
The file was modifiedLLM_prompts/update_python_api_and_drivers.md (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_xp2_xpyp.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_core.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_xp3.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_xp2_xpyp.py (diff)
The file was modifiedclubb_python_driver/advance_clubb_to_end.py (diff)
The file was modifiedclubb_python_driver/clubb_case_initalization.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/numerical_check.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/advance_xm_wpxp_module_wrapper.F90 (diff)
Commit 0da14a07a2ef02d9517c80c18d0a3a285dc08d04 by Gunther Huebler
Our argument_contract_audit.py script checks if the python_api matches the underlying fortran - this makes it more strict, and fixes many of the inconsistencies it found.

(cherry picked from commit f5c3b99d56499acc2a706cf024dd802f73030dd2)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/pdf_parameter_module.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/sfc_varnce_module.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/remapping_module.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_mixing_length.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/corr_varnce_module.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/sigma_sqd_w_module.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/new_hybrid_pdf_wrapper.F90 (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/turbulent_adv_pdf.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/new_tsdadg_pdf_wrapper.F90 (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_pdf.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/new_pdf_wrapper.F90 (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_xm_wpxp.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/adg1_adg2_3d_luhar_pdf_wrapper.F90 (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_turbulent_adv_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/stats_netcdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_pdf_main.py (diff)
The file was modifiedclubb_python_api/tests/argument_list_enforcer/argument_contract_audit.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/ly93_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/matrix_solver_wrapper.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/pdf_closure.py (diff)
The file was modifiedclubb_python_driver/radiation.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/numerical_check.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/radiation_module_wrapper.F90 (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/parameters_tunable.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/penta_bicgstab_solver.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_hybrid_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/pos_definite_module.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/saturation.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_clubb_core.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_splat.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/err_info_type_module.py (diff)
The file was modifiedclubb_python_api/clubb_f2py.pyf (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_tsdadg_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/calc_pressure.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_wp2_wp3.py (diff)
The file was modifiedclubb_python_api/tests/test_advance_core_subs.py (diff)
The file was modifiedclubb_python_api/tests/test_argument_contract_audit.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/ly93_pdf_wrapper.F90 (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_xp3.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/skx_module.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/adg1_adg2_3d_luhar_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/radiation.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/grid_class.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/stats_clubb_utilities.py (diff)
The file was modifiedclubb_python_api/clubb_python/prescribe_forcings.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/mono_flux_limiter.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/sponge_layer_damping_wrapper.F90 (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_hybrid_pdf_main.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_windm_edsclrm.py (diff)
The file was removedLLM_prompts/python_api_audit_handoff.md
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_helper.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/clip_explicit.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_corr_varnce_module.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/diffusion.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_numerical_check.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_xp2_xpyp.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/mixing_length.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/sponge_layer_damping.py (diff)
Commit e73f5d17f344ccfbf4741d978a7e0dd60a06fb25 by Gunther Huebler
advance_clubb_core.py cleanup and removing strange compat_kwargs usages that seem like artifacts of laziness

(cherry picked from commit 9056400901e270333b80ee8f66af055d395b8020)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/remapping_module.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_xp2_xpyp.py (diff)
The file was modifiedclubb_python_api/tests/test_advance_core_subs.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_hybrid_pdf_main.py (diff)
The file was modifiedclubb_python_api/clubb_f2py.pyf (diff)
The file was modifiedclubb_python_api/clubb_python/prescribe_forcings.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_core.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/mixing_length_wrapper.F90 (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/diffusion.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_transport.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/pdf_closure_module_wrapper.F90 (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_luhar.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/matrix_solver_wrapper.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_new_tsdadg.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/advance_wp2_wp3_module_wrapper.F90 (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_sponge.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/ly93_pdf.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_precipitation_fraction.py (diff)
The file was modifiedclubb_jax/clubb_case_initalization.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_mixing_length.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_mono_flux.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_skx.py (diff)
The file was modifiedclubb_python_driver/advance_clubb_core.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_xm_wpxp.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_new_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/skx_module.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/pdf_closure.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_xp3.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/stats_netcdf.py (diff)
The file was modifiedclubb_python_driver/advance_clubb_to_end.py (diff)
The file was modifiedclubb_python_api/tests/test_init_pressure.py (diff)
The file was modifiedclubb_python_api/clubb_python/clubb_api.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_clubb_core.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_xp2_xpyp.py (diff)
The file was modifiedclubb_python_api/tests/test_udt_return_contract.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_remap.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_ly93.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_new_hybrid_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_hybrid_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/radiation.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/pdf_parameter_module.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_windm_edsclrm.py (diff)
The file was modifiedclubb_python_api/tests/test_stats.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/mixing_length.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/err_info_type_module.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/calc_pressure.py (diff)
The file was modifiedclubb_python_api/tests/argument_list_enforcer/argument_contract_audit.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_stats_accumulate.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_helper.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/sponge_layer_damping.py (diff)
The file was modifiedclubb_python_driver/clubb_case_initalization.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/new_hybrid_pdf_main_wrapper.F90 (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/adg1_adg2_3d_luhar_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_wp2_wp3.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_tsdadg_pdf.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_wp2_wp3.py (diff)
Commit 1fa8fdebc019e2807e0031f7233ef85243f80ad6 by Gunther Huebler
Improving audit script even more, fixing issues it found. Also making advance_clubb_core.py nice and making an LLM shortcut for how to repeat the process

(cherry picked from commit 25b41435d7bfbbe03f2736440bdcbf4330f863ab)
The file was modifiedclubb_python_api/tests/test_call_tree_luhar.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_xp2_xpyp.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/mixing_length.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_mixing_length.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/parameters_tunable.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/matrix_solver_wrapper.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_precipitation_fraction.py (diff)
The file was modifiedclubb_jax/clubb_case_initalization.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/loss_driver.py (diff)
The file was modifiedclubb_jax/advance_clubb_core.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_pdf_closure_driver.py (diff)
The file was modifiedclubb_python_api/tests/test_advance_core_subs.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_mono_flux.py (diff)
The file was modifiedLLM_prompts/SHORTCUTS.md (diff)
The file was modifiedclubb_python_api/clubb_python/clubb_api.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/diffusion.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_hybrid_pdf_main.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/mono_flux_limiter.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_xm_wpxp.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/pdf_parameter_module.py (diff)
The file was modifiedclubb_python_api/f2py_fortran_wrappers/clubb_loss_driver_wrapper.F90 (diff)
The file was addedLLM_prompts/port_underlying_fortran_to_other_languages.md
The file was modifiedclubb_python_api/tests/test_call_tree_stats_accumulate.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_xp2_xpyp.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_clubb_core.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_wp2_wp3.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_new_pdf.py (diff)
The file was modifiedclubb_python_api/clubb_python/prescribe_forcings.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/error_code.py (diff)
The file was modifiedclubb_python_api/tests/test_argument_contract_audit.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/sponge_layer_damping.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_windm_edsclrm.py (diff)
The file was modifiedclubb_jax/advance_clubb_to_end.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/adg1_adg2_3d_luhar_pdf.py (diff)
The file was modifiedclubb_python_driver/advance_clubb_to_end.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_advance_xp3.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/new_pdf_main.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/stats_netcdf.py (diff)
The file was modifiedclubb_python_driver/clubb_case_initalization.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/pdf_closure.py (diff)
The file was modifiedclubb_python_api/tests/argument_list_enforcer/argument_contract_audit.py (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/remapping_module.py (diff)
The file was modifiedclubb_python_driver/advance_clubb_core.py (diff)
The file was modifiedclubb_python_api/tests/test_call_tree_matrix_solver_wrapper.py (diff)
The file was modifiedclubb_python_api/tests/test_stats.py (diff)
The file was modifiedclubb_python_api/clubb_f2py.pyf (diff)
The file was modifiedclubb_python_api/clubb_python/CLUBB_core/advance_wp2_wp3.py (diff)
Commit 7c083496c42caa1b7d18c781134f0cc18ae94748 by Gunther Huebler
Building varying flags bindiff into run_bindiff_all.py, this just makes sense and helps fix the varying flags BFB test
The file was modifiedtests/run_bindiff_w_flags.py (diff)
The file was modifiedtests/README (diff)
The file was modifiedrun_scripts/run_bindiff_all.py (diff)
The file was modifiedrun_scripts/README (diff)