Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. (details)
Moving the stats variables to module variables of clubb_driver. (details)
Adding new Jenkinsfile for new bit diff test for clubb. larson-group/e3sm#38 (details)
Making Jenkinsfile not a directory... larson-group/e3sm#38 (details)
Changing job name in jenkins file. larson-group/e3sm#38 (details)
Reverting accidental change to Jenkinsfile. larson-group/e3sm#38 (details)
Updating new Jenkinsfile. larson-group/e3sm#38 (details)
Updating Jenkinsfile because sys_admin files changed names. (details)
Modifying run_full_api_diagnostics.bash, create_module_table.py, and usage_analyzer.py to create and save tables similar to the nightly tests. larson-group/sys_admin#749 (details)
Modigying jenkins test to display tables after test run. larson-group/sys_admin#749 (details)
Fixing coding standard viloation of lines exceeding 100 characters. (details)
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. (details)
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. (details)
Adding the new pressure-related terms, wp2_pr_dfsn and wp3_pr_tp, to the --sam-style-budgets option in Pyplotgen. (details)
Removing l_interp_prescribed_params from setup_clubb_pdf_params. (details)
Modifying run_timestep_tests.bash to run only 10 minute and above timesteps and exit immediately if the 10 mintue timestep fails. larson-group/sys_admin#749 (details)
Adding new timestep test to clubb jenkins tests. larson-group/sys_admin#749 (details)
Fixing false printing of "All cases ran to completion." (details)
Updating clubb_tuner.F90 to resolve an issue where the optimized tunable_parameter_*.in file was not being created by default. Now it will always be created when the tuner is run, as it should be. (details)
Placing line breaks in the new error message and minor wording updates. (details)
Adding comments labeling subroutine calls with intent. (details)
Removing dependency on /home/pub and moving it to /home/jenkins larson-group/sys_admin#735 (details)
Adding some new, but still simple, parsing capabilities to input_netcdf.F90 so that the tuner will not crash if netcdf dates are in a slightly different format. Now, instead of assuming the format of the string, the code will search for the positions of the two hyphens and the two colons and get the date and time based on that. (details)
Adding some spaces to make the code a little nicer. (details)
Adding comments and renaming variables per Vince's comments. Some minor cleaning. (details)
Adding intent labels for subroutines throughout clubb. (details)
Removing unnecessary constant from use statement (details)
Updates to help run multiple tuner cases. The date/time assertion check in error.F90 was not working correctly for multiple cases, since instead of updating the CLUBB date/time based on the case, it was just using one CLUBB case for all LES cases and crashing. (details)
Fixing the ordering of gr in the clubb_api arg list for affected subroutines. Additionally, this commit removes the clubb code standard violation of exceeding more the 100 characters per line. Lastly, the grid typing is being added to clubb_api_module as a public variable so that the host models have access to the type without having to bypass the api For ticket #886.
Feeding stats variables through the argument lists of needed subroutines. The purpose of this commit is to prep clubb for having all stats variables be fed through the argument list in the entirety of clubb and host models where needed. This is for ticket #733. Results have been confirmed to be BFB identical.
Fixing spacing issues along with placing the stats varibales on their own lines. Additionally, this commit relabels arg list intent along with the intent of stats vars. Stats variables are still not in the correct spot in the arg list as per the standard, however, they are on their own line where they are correctly labeled. For ticket #733. Results are confirmed BFB identical.
Changing more subroutines to include stats vars in their arg lists. There were a few subroutines that were not detected on the first script for subroutines that would need to be changed. This commit picks up on those subroutines and correctly makes the change. Additionally, this commit also makes the stats vars show up in the same spot consistantly throughout all affected subroutines. For ticket #733. Results are confirmed BFB identical.
Add new plots and calculations to dashboard. These include a weighted bias ratio that tells us how much the tuner's recommendation is expected to improve the fit. It also includes an estimate of the overall sensitivity of each metric, i.e., how "unbudgeable" the metric is. It also automatically deletes the smallest singular values. Finally, it includes an option to leave uninteresting metrics at their default values, but this option is commented out for now.
Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.
This is BIT_CHANGING, but only because it will introduce some new output variables in the netcdf files. It will not affect results currently since the pressure diffusion coefficient is set to zero.
Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.
Moving the stats variables to module variables of clubb_driver. This change means I had to modify clubb_api_module's arg list along with other arg lists throughout clubb. Everything compiles and results remain BFB identical. For ticket #733.
Modifying run_full_api_diagnostics.bash, create_module_table.py, and usage_analyzer.py to create and save tables similar to the nightly tests. larson-group/sys_admin#749
Fixing coding standard viloation of lines exceeding 100 characters. Violations were introduced as a result of changes made by ticket #733, this commit resolves the coding standard violations. Results BFB identical.
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.
This is not set up to change results currently, since the coefficient of the new term is zero, but it is BIT_CHANGING since it will include new output in the netcdf files.
Also includes updates to pyplotgen to accommodate the new term.
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.
Removing l_interp_prescribed_params from setup_clubb_pdf_params. The flag has been removed and so has any code underneat a logic statement involving this statement unless it has multiple flags. The else statement in the if block involving this flag has been set to execute without an if block. For ticket #916 Results are BFB identical. Additionally, complex logic statements with the use of more flags had those flags adjusted and BFB results were also confirmed with these changes.
Modifying run_timestep_tests.bash to run only 10 minute and above timesteps and exit immediately if the 10 mintue timestep fails. larson-group/sys_admin#749
Updating clubb_tuner.F90 to resolve an issue where the optimized tunable_parameter_*.in file was not being created by default. Now it will always be created when the tuner is run, as it should be.
Also updating a number of input_misc/tuner/error_*.in tuner setup files to ensure that C1 is not tuned by default. If C1 is tuned but C14 is fixed, this causes CLUBB to crash since it requires C1=C14.
Adding some new, but still simple, parsing capabilities to input_netcdf.F90 so that the tuner will not crash if netcdf dates are in a slightly different format. Now, instead of assuming the format of the string, the code will search for the positions of the two hyphens and the two colons and get the date and time based on that.
Adding intent labels for subroutines throughout clubb. All calls to subroutines now have intent comments next to them all the way up through stats_sfc_module. Results are BFB identical. For ticket #942.
Updates to help run multiple tuner cases. The date/time assertion check in error.F90 was not working correctly for multiple cases, since instead of updating the CLUBB date/time based on the case, it was just using one CLUBB case for all LES cases and crashing.
Attempt to add error bars to the metrics predictions by the tuner dashboard. However, I'm not sure if it's correct to use mean-sigma values for all parameters. I also need to add shading of error bounds.
![[Jenkins]](/jenkins/static/57c8a776/images/svgs/logo.svg){kind=logo}
