Skip to content
Success

Changes

Summary

  1. Removing a couple of unused parameters from use statement. (details)
  2. Pushing k loop down through clip_variance_level. (details)
  3. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. (details)
  4. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. (details)
  5. Updating some comments related to the tuner updates. (details)
Commit b24820513db462e4a5b1cae18b4a901d7e9bd8a2 by noreply
Removing a couple of unused parameters from use statement.

These are not caught by the gfortran compiler for whatever reason but the ifort compiler warned about them.
The file was modified advance_clubb_core_module.F90 (diff)
Commit ed78e345853d9af1f71e7300220392469b690b67 by rhodesk
Pushing k loop down through clip_variance_level.
This change is for the files advance_wp2_wp3_module and advance_xp2_xpyp_module.
In order to make this change, I added a new variable in the upper-level subroutine
that is an array version of the variable 'threshold' and passed it along to the lower subroutine.
The loop is still present in order to calculate the values of threshold, however, the calls
to the subroutine is outside of the loop. The only calculations inside the loop is for
and intrensic function, max.
All results are BFB identical for default case along with l_stats_samp being set to true.
For ticket #951.
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified clip_explicit.F90 (diff)
Commit 747e30bcbd918a4dde0b1491b3ebfeaebdac9b59 by 59519056+bstephens82
Udpates to make it possible for us to keep certain parameters equal to each other during tuning.

Includes:

* a new subroutine in parameters_tunable.F90 that will read a new namelist in the error_*.in files
* updates to src/error.F90 to make sure the intended parameters are held equal throughout the tuning run
* updates to src.error.F90 to print the variables that were held equal at the end of the tuning run, together with their beginning and ending values, and updates to ensure that the new tuned values are copied into the new paramters_tunable_*.in file so they can be used for plotting or restarting the tuner.
* includes several simple error checks

See #939.
The file was modified parameters_tunable.F90 (diff)
Commit c787271c923e08a7bfa8db303bfee6588f840abf by 59519056+bstephens82
Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included.

See #939.
The file was modified parameters_tunable.F90 (diff)
Commit 68848116981910e70725c5fcc14d78e78f3f87ed by 59519056+bstephens82
Updating some comments related to the tuner updates.

See #939.
The file was modified parameters_tunable.F90 (diff)