Skip to content
[Jenkins]Jenkins
log in

Changes

#420 (Apr 24, 2025, 3:25:06 AM)

  1. Err code struct (#1238) — noreply / githubweb
  2. Err code struct (#1238) — noreply / githubweb
  3. Update clubb_sgs.F90 to incorporate err_info (#165) — noreply / githubweb

#419 (Apr 23, 2025, 3:25:07 AM)

  1. I updated adj_low_res_nu for use with a generalized grid. It is — bmg2 / githubweb

#418 (Apr 10, 2025, 3:25:09 AM)

  1. Clubb silhs gg (#1239) — noreply / githubweb
  2. Clubb silhs gg (#1239) — noreply / githubweb

#417 (Apr 9, 2025, 1:34:16 PM)

  1. Updating calls to generate_silhs_sample_api for recent changes to — bmg2 / githubweb

#416 (Mar 28, 2025, 3:25:06 AM)

  1. Clubb driver upgrades (#1225) — noreply / githubweb

#415 (Mar 24, 2025, 3:25:06 AM)

  1. Clubb test correct gg (#1237) — noreply / githubweb

#414 (Mar 12, 2025, 3:25:08 AM)

  1. The generalized grid test should not output a clubb fatal error when it — bmg2 / githubweb

#413 (Mar 8, 2025, 3:25:08 AM)

  1. Revert "I have no idea if it's appropriate to include gr in this statment," — bmg2 / githubweb
  2. I discovered that I inadvertently change an $acc statement that — bmg2 / githubweb

#412 (Mar 6, 2025, 3:25:09 AM)

  1. Eliminate GOTO statement in stats_clubb_utilities (#1233) — noreply / githubweb
  2. Added some missing acc parallel statments around some the loops — bmg2 / githubweb
  3. Fixed a bug — bmg2 / githubweb
  4. I have no idea if it's appropriate to include gr in this statment, — bmg2 / githubweb

#411 (Mar 5, 2025, 3:25:09 AM)

  1. I changed the variable type within grid function flip from dp to — bmg2 / githubweb
  2. Fixed a compiling issue with CAM-CLUBB. — bmg2 / githubweb
  3. Hopefully this helps the cpu vs. gpu tests. — bmg2 / githubweb

#410 (Mar 3, 2025, 10:14:06 AM)

  1. Updated calls to some CLUBB subroutines in the wake of recent CLUBB — bmg2 / githubweb

#409 (Mar 2, 2025, 3:25:07 AM)

  1. Generalized grid (#1230) — noreply / githubweb

#408 (Feb 27, 2025, 11:59:09 AM)

  1. Prevent SAM from bypassing clubb_api_module (#164) — noreply / githubweb

#407 (Feb 27, 2025, 3:25:10 AM)

  1. Removed renaming operators `=>` from clubb_api_module (#1232) — noreply / githubweb
  2. Removed renaming operators `=>` from clubb_api_module (#1232) — noreply / githubweb

#406 (Feb 22, 2025, 3:25:06 AM)

  1. Getting rid of a couple of worthless lines of code. It's possible this — bmg2 / githubweb
  2. Should just delete instead of commenting out. — bmg2 / githubweb

#405 (Feb 21, 2025, 3:25:07 AM)

  1. Fixed equality check in pdf_closure_module (#1229) — noreply / githubweb
  2. add dycore grid with conservative remapping scheme — noreply / githubweb
  3. add dycore grid with conservative remapping scheme — noreply / githubweb
  4. add two new flags (#162) — noreply / githubweb

#404 (Feb 20, 2025, 12:48:07 PM)

  1. Adapt SAM to removal of module var err_code (#163) — noreply / githubweb

#403 (Feb 20, 2025, 12:37:20 PM)

  1. Revert clubb api module changes (#1228) — noreply / githubweb

#402 (Feb 20, 2025, 3:25:08 AM)

  1. Remove err code (#1218) — noreply / githubweb
  2. Remove err code (#1218) — noreply / githubweb
  3. Renamed check_res to err_code in numerical_check.F90 for consistency (#1227) — noreply / githubweb

#401 (Feb 19, 2025, 3:25:09 AM)

  1. Set l_wp2_fill_holes_tke to true by default (#1226) — noreply / githubweb
  2. Set l_wp2_fill_holes_tke to true by default (#1226) — noreply / githubweb

#400 (Feb 8, 2025, 3:25:06 AM)

  1. Swapping the loop order on a few kernels, I found this faster for the nvhpc compiler and it's BFB — Gunther Huebler / githubweb

#399 (Feb 4, 2025, 3:25:10 AM)

  1. Monoflux GPU optimization (#1221) — noreply / githubweb

#398 (Jan 18, 2025, 3:25:05 AM)

  1. Fix flag l_wp2_fill_holes_tke (#161) — noreply / githubweb

#396 (Jan 17, 2025, 3:27:40 AM)

  1. Added new hole-filling method which takes TKE from up2 and vp2 (#1217) — noreply / githubweb
  2. Added new hole-filling method which takes TKE from up2 and vp2 (#1217) — noreply / githubweb

#395 (Dec 20, 2024, 3:25:05 AM)

  1. Fix binormal correlation clipping (#1199) — noreply / githubweb

#394 (Dec 17, 2024, 3:25:08 AM)

  1. Changing a couple loop limits in mono flux limiter. — bmg2 / githubweb

#393 (Dec 14, 2024, 3:25:06 AM)

  1. Recoded a loop within the mono flux limiter so that it's written — bmg2 / githubweb
  2. Changed some variable names so that it is clear that, while they contain — bmg2 / githubweb
  3. Within the mono flux limiter, a thermodynamic-level variable needed to — bmg2 / githubweb
  4. I forgot to add the new variable to the Atlantic Coast Conference — bmg2 / githubweb

#392 (Dec 7, 2024, 3:25:07 AM)

  1. Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216) — noreply / githubweb
  2. Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216) — noreply / githubweb

#391 (Dec 6, 2024, 3:25:08 AM)

  1. Added up2 and vp2 to calculation of wp2_min_array (#1215) — noreply / githubweb

#390 (Dec 5, 2024, 3:25:09 AM)

  1. Reduced the upper bound for wp2_min_array to 1.0 (#1214) — noreply / githubweb

#389 (Dec 4, 2024, 3:25:10 AM)

  1. Likely non-bit-changing housekeeping (#1213) — noreply / githubweb

#388 (Nov 23, 2024, 3:25:06 AM)

  1. Multi col output update (#1211) — noreply / githubweb

#387 (Nov 19, 2024, 12:39:50 PM)

  1. Making compatible with latest clubb changes — Gunther Huebler / githubweb

#386 (Nov 19, 2024, 3:25:05 AM)

  1. Clubb Driver Semi GPUization Part4 (#1209) — noreply / githubweb
  2. Clubb Driver Semi GPUization Part4 (#1209) — noreply / githubweb

#385 (Nov 13, 2024, 3:25:07 AM)

  1. Multi Column Mirror Test (#1206) — noreply / githubweb

#384 (Nov 12, 2024, 3:25:08 AM)

  1. As part of generalizing the code to work with both an ascending and — bmg2 / githubweb

#383 (Nov 9, 2024, 3:25:06 AM)

  1. Making a correction to the doubled plus sign from commit a1fcfe8. — bmg2 / githubweb

#382 (Nov 8, 2024, 3:25:07 AM)

  1. Moving Lscale from an acc create statement inside clubb to the acc output statement in clubb_api. This is bug fix that is BIT_CHANGING, but only for silhs cases running on the GPU. Also using this to add BIT_CHANGING:aff1bb12551c5b3a8ab1c4d773ef5c17fb96c53b, as that commit was BC but just missing the message. — Gunther Huebler / githubweb
  2. Various Small Tweaks (#1205) — noreply / githubweb
  3. Making compatible with latest clubb changes — Gunther Huebler / githubweb

#381 (Nov 5, 2024, 3:25:09 AM)

  1. Prescribe Forcings GPUization (#1204) — noreply / githubweb

#380 (Oct 25, 2024, 3:25:07 AM)

  1. I am making the loops for the wp3 ta term (using ADG1 PDF) symmetric. — bmg2 / githubweb

#379 (Oct 17, 2024, 3:25:06 AM)

  1. Making compatible with latest clubb changes — Gunther Huebler / githubweb
  2. Multicol CLUBB (#1193) — noreply / githubweb
  3. Multicol CLUBB (#1193) — noreply / githubweb
  4. Multicol CLUBB (#1193) — noreply / githubweb

#378 (Oct 11, 2024, 3:25:07 AM)

  1. Added min_max_smth_mag as a Fortran parameter to constants_clubb.F90 (#1192) — noreply / githubweb

#377 (Oct 9, 2024, 3:25:08 AM)

  1. add Lscale intent(out) to advance_clubb_core and advance_clubb_core_api (#1190) — noreply / githubweb
  2. add Lscale to advance_clubb_core_api call. For larson-group/clubb#1166 (#160) — noreply / githubweb

#376 (Oct 8, 2024, 3:25:09 AM)

  1. Mono Flux Optimizations  (#1189) — noreply / githubweb

#375 (Oct 5, 2024, 3:25:07 AM)

  1. refactoring to remove compiler warnings (#1187) — noreply / githubweb
  2. refactoring to remove compiler warnings (#1187) — noreply / githubweb
  3. remove unused dummy arguments (#159) — noreply / githubweb
  4. I am copying the round-off level changes made to grid weights — bmg2 / githubweb

#374 (Oct 4, 2024, 3:25:08 AM)

  1. Ri zm calc cleanup (#1186) — noreply / githubweb
  2. Monoflux test (#1188) — noreply / githubweb
  3. Fixing bug. This loop has a vertical dependency prevent the use of collapse(2). See https://github.com/larson-group/cam/issues/175\#issuecomment-2261283301 — Gunther Huebler / githubweb

#373 (Oct 3, 2024, 3:25:08 AM)

  1. New/new_hybrid PDF Stats Removal (#1185) — noreply / githubweb
  2. Copyout Nuke (#1182) — noreply / githubweb

#372 (Sep 27, 2024, 3:25:09 AM)

  1. Remove radf variable from CLUBB call — noreply / githubweb
  2. Remove radf variable from call to CLUBB — noreply / githubweb

#371 (Sep 26, 2024, 3:25:10 AM)

  1. Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack. — Gunther Huebler / githubweb
  2. Removing the target attributes wherever possible. These are artifacts from when gr and the the stats types were globals, and got naively copied when these were pushed through the call stack. — Gunther Huebler / githubweb

#370 (Sep 25, 2024, 3:25:05 AM)

  1. reduce compiler warnings (#1180) — noreply / githubweb
  2. reduce compiler warnings (#1180) — noreply / githubweb

#369 (Sep 21, 2024, 3:25:06 AM)

  1. refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179) — noreply / githubweb
  2. refactor code to remove compiler warnings for exceeding 100 characters per line and unused variables and parameters (#1179) — noreply / githubweb

#368 (Sep 20, 2024, 3:25:09 AM)

  1. Removing duplicate definition of edsclr when CLUBB_CAM is defined. — Gunther Huebler / githubweb
  2. Ri zm calc6 (#1177) — noreply / githubweb

#367 (Sep 18, 2024, 3:25:07 AM)

  1. change loop index to sclr and edsclr for sclr_dim and edsclr_dim (#1173) — noreply / githubweb
  2. Ri zm calc5 (#1175) — noreply / githubweb

#366 (Sep 12, 2024, 3:25:09 AM)

  1. Change variables from a1 and a3 to a1_coef and a3_coef — Vince Larson / githubweb

#365 (Sep 6, 2024, 3:25:06 AM)

  1. Well, this will probably anger the Grim Reaper, but I have finally — bmg2 / githubweb

#364 (Sep 3, 2024, 3:25:09 AM)

  1. Ri zm calc4 (#1168) — noreply / githubweb

#363 (Aug 30, 2024, 3:25:08 AM)

  1. Ri_zm calc (Part 4) - Implementing calc_Ri_zm (#1160) — noreply / githubweb

#362 (Aug 27, 2024, 3:25:10 AM)

  1. Variable name correction in acc data statement. — Gunther Huebler / githubweb
  2. Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine. — Gunther Huebler / githubweb
  3. Making radf size correct in api and clubb_driver. — Gunther Huebler / githubweb

#361 (Aug 23, 2024, 11:13:45 AM)

  1. Updated for ghostless version of CLUBB. — bmg2 / githubweb
  2. Updating to the latest version of CLUBB. — bmg2 / githubweb

#360 (Aug 23, 2024, 3:25:06 AM)

  1. Clubb ghost exorcism (#1159) — noreply / githubweb
  2. Clubb ghost exorcism (#1159) — noreply / githubweb

#359 (Aug 17, 2024, 3:25:08 AM)

  1. Nightly clubb plots (#1167) — noreply / githubweb

#358 (Aug 9, 2024, 3:25:09 AM)

  1. Editing the LES setup script to give instructions for UCAR computers. — benjamin.andrew.stephens / githubweb
  2. Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161) — noreply / githubweb
  3. Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161) — noreply / githubweb
  4. Moving PosInf to clubb_model_settings.F90 — Gunther Huebler / githubweb

#357 (Aug 8, 2024, 3:25:10 AM)

  1. Fixing mpirun command in the derecho and casper batch scripts. — benjamin.andrew.stephens / githubweb

#356 (Aug 1, 2024, 3:25:09 AM)

  1. Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175 — Gunther Huebler / githubweb
  2. Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats. — Gunther Huebler / githubweb
  3. Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test. — Gunther Huebler / githubweb

#355 (Jul 31, 2024, 3:25:10 AM)

  1. removing cheyenne-related content and adding new content for — benjamin.andrew.stephens / githubweb

#354 (Jul 20, 2024, 3:25:07 AM)

  1. Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp. — bmg2 / githubweb
  2. Fixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175 — Gunther Huebler / githubweb

#353 (Jul 19, 2024, 3:25:08 AM)

  1. In my previous commit, I changed the domain of the maxloc commands — bmg2 / githubweb
  2. This commit brings the stats output from the all cases run with — bmg2 / githubweb
  3. Committing a change that will initialize this set of variables — bmg2 / githubweb

#352 (Jul 18, 2024, 3:25:09 AM)

  1. There were furhter issues found with the k_lh_start code. — bmg2 / githubweb
  2. Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157) — noreply / githubweb

#351 (Jul 17, 2024, 3:25:09 AM)

  1. I am committing changes to stats output for cloud_cover, rcm_in_layer, — bmg2 / githubweb

#350 (Jul 15, 2024, 3:25:09 AM)

  1. I am updating the SILHS code that calculates k_lh_start to work — bmg2 / githubweb

#349 (Jul 12, 2024, 3:25:09 AM)

  1. This code in adj_low_res_nu was using the ghost point when — bmg2 / githubweb

#348 (Jul 11, 2024, 3:36:03 PM)

  1. Spack updates (#156) — noreply / githubweb

#347 (Jul 3, 2024, 3:25:09 AM)

  1. Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156) — noreply / githubweb

#346 (Jun 21, 2024, 3:25:10 AM)

  1. Adds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3e — noreply / githubweb

#345 (Jun 20, 2024, 3:25:06 AM)

  1. Ri zm calc (Part 1) - Combine and move call to  calc_brunt_vaisala_freq_sqd (#1154) — noreply / githubweb
  2. Ri_zm calc (Part 1.5) - Adjusted signature of diagnose_Lscale_from_tau #1145 (#1155) — noreply / githubweb

#344 (Jun 5, 2024, 3:25:06 AM)

  1. Making the only change required to make clubb run with openacc in cam. — Gunther Huebler / githubweb

#343 (Jun 4, 2024, 3:25:07 AM)

  1. Making the f in f90 capital for consistency. — Gunther Huebler / githubweb

#342 (May 30, 2024, 3:25:10 AM)

  1. The variable rc_coef_zm needed to be passed in and saved from — bmg2 / githubweb

#341 (May 17, 2024, 3:26:08 AM)

  1. Fixing a bug. Does not change default results. — bmg2 / githubweb

#340 (May 16, 2024, 3:26:09 AM)

  1. Fixing small GPU bug in advance_xm, also fixing a bug with sclrpthvp that's only detectable when were running 1 column on GPUs. — Gunther Huebler / githubweb

#339 (May 14, 2024, 3:26:07 AM)

  1. gr%zm should be used here instead of gr%zt, since these are — bmg2 / githubweb
  2. Thermodynamic-level (zt) values should be used with zt-variable — bmg2 / githubweb

#338 (May 4, 2024, 3:26:08 AM)

  1. Adding extra exclamation to acc statement to comment it out. — Gunther Huebler / githubweb

#337 (May 3, 2024, 3:26:09 AM)

  1. I am committing code that effectively ignores the values of certain — bmg2 / githubweb
  2. I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the — bmg2 / githubweb

#336 (May 2, 2024, 3:26:06 AM)

  1. Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. — Gunther Huebler / githubweb
  2. Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. — Gunther Huebler / githubweb
  3. Making compatible with latest clubb changes. — Gunther Huebler / githubweb

#335 (May 1, 2024, 3:26:07 AM)

  1. Moved the ghost-point setting of xm(1) = xm(2) to the last line — bmg2 / githubweb
  2. Optional arguments are just best sometimes (#1150) — noreply / githubweb

#334 (Apr 27, 2024, 3:26:08 AM)

  1. I'm changing the way ddzt handles the derivative over momentum level 1. — bmg2 / githubweb

#333 (Apr 20, 2024, 3:25:09 AM)

  1. Changing the linear interpolation in the zt2zm function at momentum — bmg2 / githubweb

#332 (Apr 19, 2024, 3:25:06 AM)

  1. Committing some thresholding around positive-definite fields after — bmg2 / githubweb

#331 (Apr 14, 2024, 3:25:09 AM)

  1. I am committing a stats change to the ghost point values of zt — bmg2 / githubweb

#330 (Apr 12, 2024, 3:25:06 AM)

  1. This commit is being made to keep the stats zt output from the — bmg2 / githubweb
  2. I am committing a bug fix to the code that calculates mixed Brunt — bmg2 / githubweb

#329 (Apr 11, 2024, 3:25:08 AM)

  1. While it doesn't affect results, I fixed what appears to be an — bmg2 / githubweb
  2. I am updating the loop in subroutine diagnose_xpwp so that it doesn't — bmg2 / githubweb

#328 (Apr 7, 2024, 3:25:09 AM)

  1. The code that advances um and vm when l_predict_upwp_vpwp is turned off — bmg2 / githubweb
  2. It was discovered that the location where the ghost point values — bmg2 / githubweb
  3. It was discovered that the location where the ghost point values — bmg2 / githubweb
  4. I accidentally committed a couple things in the previous commit — bmg2 / githubweb

#327 (Apr 6, 2024, 3:25:08 AM)

  1. At the ghost point below the surface, which does not matter in — bmg2 / githubweb

#326 (Apr 2, 2024, 3:25:09 AM)

  1. Fixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false. — Gunther Huebler / githubweb

#325 (Apr 1, 2024, 2:53:45 PM)

  1. Making compatible with latest clubb changes. — Gunther Huebler / githubweb

#324 (Apr 1, 2024, 3:25:10 AM)

  1. Putting ngrdcol in clubb_params (#1147) — noreply / githubweb

#317 (Mar 25, 2024, 3:25:08 AM)

  1. Adding sum part to comment — Gunther Huebler / githubweb

#316 (Mar 23, 2024, 3:25:07 AM)

  1. Adding comment to explain unusual code choice. — Gunther Huebler / githubweb

#315 (Mar 19, 2024, 3:25:07 AM)

  1. OpenMP Optimizations (#1146) — noreply / githubweb

#314 (Mar 6, 2024, 3:25:08 AM)

  1. Removes comment about Numerical Recipes — noreply / githubweb

#313 (Feb 16, 2024, 3:25:09 AM)

  1. Small acc tweaks (#1144) — noreply / githubweb

#312 (Feb 15, 2024, 3:25:09 AM)

  1. Add blank line in order to trigger Jenkins tests for CAM — noreply / githubweb

#311 (Feb 14, 2024, 3:25:09 AM)

  1. fixing bug, name of wm_zt was left as "wm" — Vince Larson / githubweb

#310 (Feb 9, 2024, 3:25:08 AM)

  1. adding equals sign cuz I've had it up to here with this typo! — benjamin.andrew.stephens / githubweb

#309 (Feb 8, 2024, 3:25:10 AM)

  1. Fixing a bug where the Lscale used in calculating the damping — bmg2 / githubweb

#308 (Feb 1, 2024, 3:25:11 AM)

  1. This is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\#issuecomment-1865156979. — Gunther Huebler / githubweb
  2. Removing backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\#issuecomment-1910844013 — Gunther Huebler / githubweb

#307 (Jan 25, 2024, 3:25:07 AM)

  1. Now that the value of wp3 is being set to a boundary value of 0 — bmg2 / githubweb

#306 (Jan 22, 2024, 3:25:06 AM)

  1. Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs. — Gunther Huebler / githubweb
  2. Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs. — Gunther Huebler / githubweb

#305 (Jan 19, 2024, 3:25:18 AM)

  1. Fixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139 — Gunther Huebler / githubweb
  2. Slight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139 — Gunther Huebler / githubweb
  3. Fixing small GPU stats bug — Gunther Huebler / githubweb
  4. Changing xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it. — Gunther Huebler / githubweb

#304 (Jan 12, 2024, 3:25:07 AM)

  1. I am altering the mean advection code in preparation for ghost point — bmg2 / githubweb

#303 (Jan 10, 2024, 3:25:08 AM)

  1. Setting l_smooth_Heaviside_tau_wpxp to .true. by default — Gunther Huebler / githubweb

#302 (Jan 9, 2024, 3:25:10 AM)

  1. Adding new argument list variables to openacc copyin statements — Gunther Huebler / githubweb

#301 (Jan 5, 2024, 3:25:09 AM)

  1. Removing awkward nan check in favor of a default for Ncnp2_on_Ncnm2 — Gunther Huebler / githubweb

#300 (Jan 4, 2024, 5:14:46 PM)

  1. Fixing bug by changing saturation_equation to match namelist argument, also adding it to namelist. — Gunther Huebler / githubweb

#299 (Jan 4, 2024, 3:25:07 AM)

  1. Threadpublic (#1133) — noreply / githubweb
  2. Threadpublic (#1133) — noreply / githubweb
  3. Threadpublic (#1133) — noreply / githubweb
  4. Making compatible with latest clubb change. — Gunther Huebler / githubweb

#298 (Dec 22, 2023, 3:25:06 AM)

  1. With wp3 now being set to a fixed-point boundary condition value — bmg2 / githubweb

#297 (Dec 19, 2023, 3:25:09 AM)

  1. Updating the code to set the bottom of the thermodynamic level grid for — Brian Griffin / githubweb
  2. Commit to enforce a fixed-point boundary condition of wp3=0 at — Brian Griffin / githubweb

#296 (Dec 13, 2023, 3:25:08 AM)

  1. Added new Brunt-Väisälä frequency plots to pyplotgen's VariableGroupTaus — Vince Larson / githubweb
  2. Adds commas to fix bug — noreply / githubweb

#295 (Dec 9, 2023, 3:25:07 AM)

  1. Adding boundary conditions for the wp3_term_ta_ADG1_lhs subroutine. — Brian Griffin / githubweb
  2. For single loop vectors, removing the "collapse(2)" from the acc statements. — Brian Griffin / githubweb

#294 (Nov 29, 2023, 3:25:10 AM)

  1. Re-adjusted cap for invrs_tau_wpxp in src/CLUBB_core/mixing_length.F90 — Steffen Domke / githubweb

#293 (Nov 17, 2023, 3:25:09 AM)

  1. Added non-trapezoidal zm interpolation for cloud_frac (#1127) — noreply / githubweb

#292 (Nov 15, 2023, 3:25:10 AM)

  1. Changing order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING. — Gunther Huebler / githubweb
  2. Setting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126 — Gunther Huebler / githubweb
  3. BIT_CHANGING! Updated taus code calculations - CLUBB ticket #1115 (#1125) — noreply / githubweb

#291 (Nov 11, 2023, 3:25:09 AM)

  1. Making work with latest clubb changes. — Gunther Huebler / githubweb
  2. Changing stat_indices to stats_metadata_type — Gunther Huebler / githubweb
  3. New Stats Indices Type (#1118) — noreply / githubweb
  4. New Stats Indices Type (#1118) — noreply / githubweb

#290 (Nov 10, 2023, 3:25:08 AM)

  1. Z displace tunable (#1122) — noreply / githubweb
  2. Z displace tunable (#1122) — noreply / githubweb
  3. Update clubb_sgs.F90 — 42725900+domkesteffen / githubweb

#289 (Nov 9, 2023, 3:25:10 AM)

  1. Updated CLUBB so that adj_low_res_nu (which can be called on its own — bmg2 / githubweb
  2. Updated the CLUBB interface for recent changes to CLUBB. — bmg2 / githubweb
  3. Removing begin_height and end_height as outputs from setup_grid. They — bmg2 / githubweb
  4. Updated for recent changes to CLUBB. — bmg2 / githubweb

#288 (Nov 1, 2023, 3:25:08 AM)

  1. Latest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119) — noreply / githubweb
  2. BIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120) — noreply / githubweb

#287 (Oct 25, 2023, 3:25:08 AM)

  1. Finally removing scratch variables. (#1116) — noreply / githubweb

#286 (Oct 20, 2023, 3:25:08 AM)

  1. Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106) — noreply / githubweb
  2. BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102 — noreply / githubweb
  3. BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108) — noreply / githubweb
  4. Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109) — noreply / githubweb
  5. Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110) — noreply / githubweb
  6. BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111) — noreply / githubweb
  7. Tunable Richardson number exponent - CLUBB ticket #1102 (#1114) — noreply / githubweb
  8. Tunable Richardson number exponent - CLUBB ticket #1102 (#1114) — noreply / githubweb
  9. Deletes svn id tag, will trigger host-model nightly tests. — noreply / githubweb
  10. Remove svn id tag in order to trigger nightly tests. — noreply / githubweb
  11. Removed 3rd svn id tag in order to trigger nightly tests — noreply / githubweb

#285 (Oct 19, 2023, 3:25:10 AM)

  1. Add library calls to allow SAM to compile with new icx intel compiler (#154) — noreply / githubweb

#284 (Oct 17, 2023, 2:22:23 PM)

  1. Raw-copy updating SRC/CLUBB — LarsonGroupSysAdmin / githubweb
  2. Update clubb_sgs.F90 — 42725900+domkesteffen / githubweb

#283 (Oct 14, 2023, 3:25:07 AM)

  1. Raw-copy updating SRC/CLUBB — root / githubweb
  2. Raw-copy updating CLUBB_PARAMETERS — root / githubweb

#282 (Aug 2, 2023, 3:25:07 AM)

  1. Adding wp_coef and wp_coef_zt to acc data statements. — Gunther Huebler / githubweb
  2. Bv efold bit changing (#1095) — noreply / githubweb

#281 (Jul 26, 2023, 3:25:09 AM)

  1. Bit changing changes (#1104) — noreply / githubweb

#280 (Jul 19, 2023, 3:25:11 AM)

  1. Openacc tweaks and cleanup 2 (#1099) — noreply / githubweb

#279 (Jul 16, 2023, 3:25:07 AM)

  1. Loop to `nz-1` instead of `nz` because upper boundary condition — noreply / githubweb

#278 (Jul 12, 2023, 3:25:06 AM)

  1. Openacc tweaks and cleanup (#1097) — noreply / githubweb

#277 (Jul 11, 2023, 3:25:10 AM)

  1. Making compatible with latest clubb changes. — Gunther Huebler / githubweb

#276 (Jul 6, 2023, 3:25:08 AM)

  1. Changing "Fnc" to "fnc" for consistency and easy search. — benjamin.andrew.stephens / githubweb
  2. Memory usage optimizations (#1091) — noreply / githubweb

#275 (Jun 30, 2023, 3:25:09 AM)

  1. Added bv_efold changes for CLUBB API calls — Vince Larson / githubweb

#274 (Jun 28, 2023, 3:25:06 AM)

  1. CLUBB ticket #1069: (#1092) — noreply / githubweb
  2. CLUBB ticket #1069: (#1092) — noreply / githubweb

#273 (Jun 21, 2023, 3:25:10 AM)

  1. Data movement improvement (#1089) — noreply / githubweb

#272 (Jun 14, 2023, 3:25:09 AM)

  1. Moving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088) — noreply / githubweb

#271 (Jun 9, 2023, 3:25:09 AM)

  1. advance_xp2_xpyp with explicitly managed memory (#1086) — noreply / githubweb
  2. advance_windm_edsclrm with explicitly managed memory (#1087) — noreply / githubweb

#270 (Jun 7, 2023, 3:25:10 AM)

  1. advance_wp2_wp3 with explicitly managed memory  (#1085) — noreply / githubweb

#269 (Jun 3, 2023, 3:25:10 AM)

  1. GPUizing most of advance_clubb_core (#1084) — noreply / githubweb

#268 (May 31, 2023, 3:25:08 AM)

  1. GPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083) — noreply / githubweb

#267 (May 14, 2023, 3:25:07 AM)

  1. making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
  2. making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
  3. Here is another commit that changes nothing — cernikt / githubweb
  4. Here is another commit that changes nothing — cernikt / githubweb
  5. change to trigger updates — cernikt / githubweb
  6. change to calc pressure to trigger autoupdate — cernikt / githubweb

#266 (May 7, 2023, 3:25:10 AM)

  1. Removed Space From clip_explicit — cernikt / githubweb

#265 (May 4, 2023, 3:25:09 AM)

  1. Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code. — benjamin.andrew.stephens / githubweb
  2. Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code. — benjamin.andrew.stephens / githubweb

#264 (May 3, 2023, 3:25:08 AM)

  1. Calc sfc varnce GPUization (#1081) — noreply / githubweb

#263 (May 2, 2023, 3:25:09 AM)

  1. Making CLUBB's splatting scheme implicit and smoother (#1075) — noreply / githubweb

#262 (May 1, 2023, 3:25:09 AM)

  1. adding an update that changes nothing and is just a test for the autoupdate script — cernikt / githubweb

#261 (Apr 24, 2023, 3:25:10 AM)

  1. changing tunable_parameters — cernikt / githubweb
  2. changing tunable_parameters — cernikt / githubweb
  3. changing tunable_parameters — cernikt / githubweb
  4. This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
  5. This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
  6. this is another commit that cahnges nothing that will trigger the gitUpdate scripts — cernikt / githubweb

#260 (Apr 22, 2023, 3:25:08 AM)

  1. GPUizing Various Small Routines (#1080) — noreply / githubweb

#259 (Apr 20, 2023, 3:25:07 AM)

  1. Lscale GPUization (#1079) — noreply / githubweb
  2. gfortran does not like intent(out) specifiers for functions. — Gunther Huebler / githubweb

#258 (Apr 8, 2023, 3:25:08 AM)

  1. Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test. — Gunther Huebler / githubweb

#257 (Apr 6, 2023, 2:07:11 PM)

  1. Advance xm wpxp gpuization (#1077) — noreply / githubweb
  2. Small tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems. — Gunther Huebler / githubweb
  3. Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard. — Gunther Huebler / githubweb

#255 (Apr 4, 2023, 4:55:39 PM)

  1. This commit contains code changes to implement modifications on limiters in three places: — bmg2 / githubweb
  2. This commit contains code changes to implement modifications on limiters in three places: — bmg2 / githubweb
  3. Updated for recent changes to CLUBB. — bmg2 / githubweb

#254 (Apr 1, 2023, 3:25:10 AM)

  1. Code changes to implement modificiations on wp3 clippings — bmg2 / githubweb
  2. Code changes to implement modificiations on wp3 clippings — bmg2 / githubweb

#253 (Mar 25, 2023, 3:25:07 AM)

  1. Small GPU fixes (#1076) — noreply / githubweb

#252 (Mar 23, 2023, 3:25:06 AM)

  1. Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2. — Gunther Huebler / githubweb

#251 (Mar 17, 2023, 3:25:07 AM)

  1. Moving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break. — Gunther Huebler / githubweb

#250 (Mar 15, 2023, 3:25:08 AM)

  1. Pdf closure driver gpuization (#1071) — noreply / githubweb

#249 (Mar 14, 2023, 3:25:09 AM)

  1. Making 'a_const' into a CLUBB tunable parameter. (#1072) — noreply / githubweb
  2. Making 'a_const' into a CLUBB tunable parameter. (#1072) — noreply / githubweb
  3. Updating for changes to CLUBB.  See PR #1072. — benjamin.andrew.stephens / githubweb

#248 (Mar 10, 2023, 3:25:06 AM)

  1. Implements Thomas Toniazzo's bug fix for spike removal — noreply / githubweb

#247 (Mar 9, 2023, 3:25:07 AM)

  1. Gpu updates (#1070) — noreply / githubweb

#246 (Mar 1, 2023, 3:25:10 AM)

  1. Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068) — noreply / githubweb

#245 (Feb 28, 2023, 3:25:06 AM)

  1. Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly. — 37674341+huebleruwm / githubweb

#244 (Feb 18, 2023, 3:25:09 AM)

  1. Adding wp3_on_wp2_cfl_num to CLUBB's output stats. — bmg2 / githubweb

#243 (Feb 9, 2023, 3:25:08 AM)

  1. Porting pdf_closure subroutine with OpenACC (#1059) — noreply / githubweb

#242 (Feb 8, 2023, 3:25:07 AM)

  1. GPUizing some helping procedures. — 37674341+huebleruwm / githubweb
  2. Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory. — 37674341+huebleruwm / githubweb

#241 (Feb 5, 2023, 3:25:06 AM)

  1. Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1 — Gunther Huebler / githubweb

#240 (Feb 3, 2023, 3:25:10 AM)

  1. Pushing column loop into calculate_thvm — 37674341+huebleruwm / githubweb
  2. Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926. — 37674341+huebleruwm / githubweb

#239 (Jan 26, 2023, 3:25:10 AM)

  1. GPUizing sat_mixrat_ice_2D. — 37674341+huebleruwm / githubweb

#238 (Jan 25, 2023, 3:25:10 AM)

  1. Adding OpenACC data directives for mixing length and adg routines — Vince Larson / githubweb
  2. Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general. — Gunther Huebler / githubweb

#237 (Jan 20, 2023, 3:25:09 AM)

  1. Breaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051) — noreply / githubweb
  2. Adding tridiag_lu solver (#1056) — noreply / githubweb

#236 (Jan 19, 2023, 3:25:08 AM)

  1. Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) — noreply / githubweb

#235 (Jan 13, 2023, 3:25:10 AM)

  1. Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052) — noreply / githubweb

#234 (Jan 12, 2023, 3:25:09 AM)

  1. Pushing column loop into lapack wrap. — 37674341+huebleruwm / githubweb

#233 (Dec 10, 2022, 3:25:09 AM)

  1. I can now safely remove all the "ifdef E3SM" statements from CLUBB's — bmg2 / githubweb

#232 (Dec 8, 2022, 3:25:06 AM)

  1. ADG1_pdf_driver subroutine port with OpenACC — 37674341+huebleruwm / githubweb
  2. Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049 — 37674341+huebleruwm / githubweb

#231 (Nov 29, 2022, 3:25:07 AM)

  1. I added "smooth" max clipping for invrs_tau_shear, which is a variable — bmg2 / githubweb

#230 (Nov 25, 2022, 3:25:07 AM)

  1. Replacing $ with & in namelist definition to make consistent. — Gunther Huebler / githubweb

#229 (Nov 24, 2022, 3:25:09 AM)

  1. Making compatible with latest clubb changes. — Gunther Huebler / githubweb
  2. Adding capability to change matrix solving method via clubb_config_flags. — 37674341+huebleruwm / githubweb
  3. Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones. — 37674341+huebleruwm / githubweb
  4. Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024. — 37674341+huebleruwm / githubweb
  5. Adding capability to change matrix solving method via clubb_config_flags. — 37674341+huebleruwm / githubweb

#228 (Nov 23, 2022, 3:25:05 AM)

  1. Steffens tuner fixer branch (#1041) — noreply / githubweb

#227 (Nov 22, 2022, 3:25:08 AM)

  1. A different way of dealing with monotonic flux limiter spikes (#1046) — noreply / githubweb

#226 (Nov 17, 2022, 3:25:07 AM)

  1. Making interface for matrix solvers. — 37674341+huebleruwm / githubweb
  2. Making tridag tridiag everywhere, making sol soln, and adding intent comments. — 37674341+huebleruwm / githubweb

#225 (Nov 9, 2022, 3:25:07 AM)

  1. Minor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043) — noreply / githubweb

#223 (Oct 15, 2022, 3:25:09 AM)

  1. Creating new flags to control monotonic flux limiter (#1039) — noreply / githubweb
  2. Creating new flags to control monotonic flux limiter (#1039) — noreply / githubweb
  3. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/1039. — 59519056+bstephens82 / githubweb
  4. I am adding cloudy_updraft_frac and cloudy_downdraft_frac as — bmg2 / githubweb
  5. Updating SAM-CLUBB for the latest changes to the call to — bmg2 / githubweb

#222 (Oct 14, 2022, 3:25:06 AM)

  1. Updating monotonic flux limiter code to remove spikes. (#1038) — noreply / githubweb

#221 (Oct 11, 2022, 3:25:07 AM)

  1. Adds commented-out line that prevents the monotonic flux — noreply / githubweb

#220 (Oct 10, 2022, 11:16:57 AM)

  1. Namelists need to be closed with a '/', and omitting it will break many tests. — Gunther Huebler / githubweb
  2. Making save variables in the multicol code threadprivate, this fixes the openmp test. Also changing the way we name and save the multicol output, this allows the parallel run to run with multiple columns. I've reflected the changes in comments where relevant. larson-group/clubb#1033 — Gunther Huebler / githubweb

#219 (Oct 6, 2022, 3:25:08 AM)

  1. Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical. — 37674341+huebleruwm / githubweb
  2. Updating column num input in config flags. larson-group/clubb#1033 — 37674341+huebleruwm / githubweb
  3. Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical. — 37674341+huebleruwm / githubweb
  4. Adding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033 — 37674341+huebleruwm / githubweb

#218 (Sep 10, 2022, 3:25:06 AM)

  1. Adding initial subroutine calc_ice_cloud_frac_component. — 37674341+huebleruwm / githubweb
  2. Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  3. Comment update — 37674341+huebleruwm / githubweb
  4. Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines. — 37674341+huebleruwm / githubweb

#217 (Sep 8, 2022, 3:25:05 AM)

  1. Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  2. Adding comments. — 37674341+huebleruwm / githubweb

#216 (Aug 31, 2022, 1:28:42 PM)

  1. Making compatible with latest clubb change. — Gunther Huebler / githubweb

#215 (Aug 31, 2022, 3:25:09 AM)

  1. Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972. — 37674341+huebleruwm / githubweb
  2. Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  3. Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  4. Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb

#214 (Aug 18, 2022, 3:25:08 AM)

  1. I have optimized the new w_up_in_cloud and w_down_in_cloud code by — bmg2 / githubweb

#213 (Aug 17, 2022, 3:25:10 AM)

  1. adding line to fix mpi configuration in micro drizzle test — cernikt / githubweb
  2. I altered the w_up_in_cloud and w_down_in_cloud code so that a — bmg2 / githubweb

#212 (Aug 16, 2022, 3:25:07 AM)

  1. I changed the w_up_in_cloud code in 2 ways: — bmg2 / githubweb
  2. I added stats output for w_down_in_cloud to all_stats.in. — bmg2 / githubweb
  3. Modified for the latest changes to CLUBB. — bmg2 / githubweb

#211 (Jul 20, 2022, 3:25:07 AM)

  1. Fixing a bug in mono_flux_limiter.F90. (#1026) — noreply / githubweb
  2. Fixing a bug. — bmg2 / githubweb

#210 (Jun 22, 2022, 3:25:08 AM)

  1. Fixing units in stats_zt_module.F90 — noreply / githubweb

#209 (Jun 18, 2022, 3:25:08 AM)

  1. Making linear_interpolated_azt_2D and linear_interpolated_azm_2D subroutines just to avoid a needless data copy. — 37674341+huebleruwm / githubweb
  2. Making update_xp2_mc 2D and creating interface for 1D calls. — 37674341+huebleruwm / githubweb

#208 (Jun 16, 2022, 3:25:08 AM)

  1. Pushing loop into fill_holes. — 37674341+huebleruwm / githubweb
  2. Forgot small change. — 37674341+huebleruwm / githubweb
  3. Making compatible with latest clubb change. — Gunther Huebler / githubweb

#207 (Jun 13, 2022, 12:49:36 PM)

  1. Hardcoding 1 into uses of gr arrays where single column versions of gr is used. — Gunther Huebler / githubweb

#206 (Jun 11, 2022, 3:25:09 AM)

  1. Adding column index to gr arrays, hard coding to 1 since sam only uses single column calls. — Gunther Huebler / githubweb
  2. Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it. — 37674341+huebleruwm / githubweb
  3. Pushing column loop into mean advection procedures. — 37674341+huebleruwm / githubweb
  4. Little loop push — 37674341+huebleruwm / githubweb
  5. Moving above/below index of grid weights to last dimension. — 37674341+huebleruwm / githubweb

#205 (Jun 10, 2022, 3:25:08 AM)

  1. added -heap-arrays tag to FFlags on Makefile to fix jenkins testing error — cernikt / githubweb
  2. Makefile came with a few other accidental changes, these have been corrected. — cernikt / githubweb
  3. The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb
  4. The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb

#204 (Jun 8, 2022, 3:25:08 AM)

  1. Lots of small loop pushes — 37674341+huebleruwm / githubweb
  2. Small bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run. — 37674341+huebleruwm / githubweb
  3. Small refactoring to mfl_xm_lhs, just removing need to pass in gr. — 37674341+huebleruwm / githubweb
  4. Final loop pushes needed before the grid change. — 37674341+huebleruwm / githubweb
  5. Replacing use of gr with nz — 37674341+huebleruwm / githubweb
  6. Replacing use of gr with nz — 37674341+huebleruwm / githubweb

#202 (Jun 3, 2022, 3:25:08 AM)

  1. Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value. — Gunther Huebler / githubweb
  2. Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types. — Gunther Huebler / githubweb

#201 (Jun 2, 2022, 3:25:07 AM)

  1. The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. — Gunther Huebler / githubweb
  2. Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version. — Gunther Huebler / githubweb
  3. Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). — Gunther Huebler / githubweb
  4. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  5. Making 2D versions of setup_grid and setup_parameters. — Gunther Huebler / githubweb

#200 (Jun 1, 2022, 3:25:07 AM)

  1. Almost final loop pushes (#1012) — noreply / githubweb
  2. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  3. Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) — noreply / githubweb

#199 (May 28, 2022, 3:25:11 AM)

  1. Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
  2. Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
  3. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4. — benjamin.andrew.stephens / githubweb

#198 (May 26, 2022, 3:25:09 AM)

  1. removed SAM_CLUBB_standards.tex, SAM_CLUBB.tex, SAM_code_notes.tex, and SAM6.10_guide.doc larson-group/sys_admin#622 — cernikt / githubweb
  2. COrrecting a couple of omissions from when I was renaming the shear_driven case to "neutral". — benjamin.andrew.stephens / githubweb

#197 (May 14, 2022, 3:25:09 AM)

  1. Added ability to apply smooth min max functions in mixing_length.F90 — 68997723+JanGrn / githubweb
  2. Updated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
  3. Checked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
  4. Added test cases to smooth_min_max_tests.F90 and updated documentation. — 68997723+JanGrn / githubweb

#196 (May 12, 2022, 3:25:08 AM)

  1. Renaming the new case from SHEAR_DRIVEN to NEUTRAL, and associated mentions in files. — benjamin.andrew.stephens / githubweb

#195 (May 6, 2022, 3:25:11 AM)

  1. Renamed smth_range to heaviside_smth_range — 68997723+JanGrn / githubweb
  2. Added tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes. — 68997723+JanGrn / githubweb
  3. Implemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0. — 68997723+JanGrn / githubweb
  4. Changed priorities of total normalized variation stats, included error handling in total normalized variation stats. — 68997723+JanGrn / githubweb
  5. Renamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls. — 68997723+JanGrn / githubweb
  6. Gunthers branch 2 (#1002) — noreply / githubweb
  7. Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail. — 68997723+JanGrn / githubweb

#194 (May 4, 2022, 3:25:07 AM)

  1. Gunthers branch (#999) — noreply / githubweb

#193 (Apr 28, 2022, 3:25:11 AM)

  1. Adding in comments to the Jenkinsfiles to clarify advanced syntax usage and commands with unclear purpose. — pbroels / githubweb

#192 (Apr 27, 2022, 3:25:10 AM)

  1. Small bug fix. — Gunther Huebler / githubweb
  2. Another similar small bug fix. — Gunther Huebler / githubweb

#191 (Apr 26, 2022, 3:25:09 AM)

  1. Various simple changes to improve performance. All bit-for-bit. — Gunther Huebler / githubweb
  2. Pushing loop into calc_stability_correction. — Gunther Huebler / githubweb

#190 (Apr 22, 2022, 3:25:08 AM)

  1. Gunthers branch (#996) — noreply / githubweb

#189 (Apr 21, 2022, 3:25:08 AM)

  1. Renaming folder and script as well as adding test Jenkinsfile. — pbroels / githubweb
  2. Fixing cutt off lines and spelling mistakes. — noreply / githubweb

#188 (Apr 15, 2022, 3:25:06 AM)

  1. Interfacing SAM-CLUBB with the latest version of CLUBB. — bmg2 / githubweb
  2. Updated code so that it actually compiles and runs. — bmg2 / githubweb

#187 (Apr 13, 2022, 3:25:10 AM)

  1. I added the code for the l_linearize_pbl_winds flag that was originally — bmg2 / githubweb
  2. I added the code for the l_linearize_pbl_winds flag that was originally — bmg2 / githubweb

#186 (Apr 6, 2022, 3:25:07 AM)

  1. Added idiot-proofing to print a warning message when l_diag_Lscale_from_tau — bmg2 / githubweb
  2. Updating the call to setup_clubb_core_api based on changes found — bmg2 / githubweb

#185 (Apr 1, 2022, 3:25:07 AM)

  1. Adding samClubbCodeCopy.bash to the jenkins directory for testing Clubb changes. larson-group/sys_admin#768 — pbroels / githubweb

#184 (Mar 30, 2022, 3:25:06 AM)

  1. Added a3_coef_min to the list of CLUBB's tunable parameter and then — bmg2 / githubweb
  2. Added a3_coef_min to the list of CLUBB's tunable parameter and then — bmg2 / githubweb
  3. Updated SAM-CLUBB for CLUBB's new tunable parameter a3_coef_min — bmg2 / githubweb

#183 (Mar 26, 2022, 3:25:07 AM)

  1. I added l_relax_clipping to CLUBB's config flags. — bmg2 / githubweb
  2. I added l_relax_clipping to CLUBB's config flags. — bmg2 / githubweb
  3. I am updating clubb_sgs.F90 for the addition of the l_enable_relaxed_clipping — bmg2 / githubweb
  4. Forgot to add l_enable_relaxed_clipping to the namelist readible flags. — bmg2 / githubweb

#182 (Mar 21, 2022, 3:25:10 AM)

  1. Adding files and updates necessary to run new neutral, shear_driven case in SAM.  The case — Vince Larson / githubweb

#181 (Mar 18, 2022, 3:25:09 AM)

  1. Changed the UTIL Makefile to use ifort rather than sunf95 to allow nightly tests to run. — pbroels / githubweb

#180 (Mar 17, 2022, 3:25:07 AM)

  1. Removes a blank line in order to trigger merge with E3SM — noreply / githubweb
  2. Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  3. Replacing the i loop iterator for scalars with sclr. — 37674341+huebleruwm / githubweb
  4. Pushing loop into advance_xp2_wpxp. — 37674341+huebleruwm / githubweb
  5. Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats. — 37674341+huebleruwm / githubweb
  6. Moving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call. — 37674341+huebleruwm / githubweb
  7. Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way. — 37674341+huebleruwm / githubweb
  8. Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn. — 37674341+huebleruwm / githubweb
  9. Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp. — 37674341+huebleruwm / githubweb

#179 (Mar 15, 2022, 3:25:06 AM)

  1. Increasing HBUF_MAX_LENGTH to 2000 to account for increase in vaiables. — noreply / githubweb
  2. Adds a blank line to trigger git merge with E3SM — noreply / githubweb

#178 (Mar 11, 2022, 3:25:09 AM)

  1. Removing data copies that we don't need anymore. This still runs correctly on GPUs. — 37674341+huebleruwm / githubweb
  2. Making clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible. — 37674341+huebleruwm / githubweb
  3. No more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols. — 37674341+huebleruwm / githubweb

#177 (Mar 10, 2022, 3:25:09 AM)

  1. Changing microphysics file to UWM from 1MOM for the carson nightly tests. — pbroels / githubweb

#176 (Mar 2, 2022, 3:25:09 AM)

  1. Making setup_pdf_parameters accept ngrdcols size arrays of stats and grid types. — Gunther Huebler / githubweb
  2. Forgot two small changes. larson-group/cam#129 — Gunther Huebler / githubweb
  3. Removing need for data copies. larson-group/cam#129 — Gunther Huebler / githubweb
  4. Changing column loop index from j to i. larson-group/cam#129 — Gunther Huebler / githubweb

#174 (Feb 26, 2022, 3:25:07 AM)

  1. Implementations of smooth min, max and heaviside function. Added G-Unit tests — 68997723+JanGrn / githubweb

#173 (Feb 25, 2022, 3:25:06 AM)

  1. Fixing small bug that breaks runs with scalars. — Gunther Huebler / githubweb

#172 (Feb 24, 2022, 3:25:07 AM)

  1. Gunthers branch (#989) — noreply / githubweb

#171 (Feb 22, 2022, 3:25:09 AM)

  1. Refactoring to remove need for global stats scratch variables. (#988) — noreply / githubweb

#170 (Feb 18, 2022, 3:25:08 AM)

  1. Pushing loop into solve_xm_wpxp_with_single_lhs (#986) — noreply / githubweb

#169 (Feb 17, 2022, 3:25:06 AM)

  1. Adding 2D version of zt2zm and zm2zt to clubb_api — Gunther Huebler / githubweb

#168 (Feb 14, 2022, 2:18:20 PM)

  1. Fixing test deleting log file before it can be read. — pbroels / githubweb

#167 (Feb 14, 2022, 12:12:04 PM)

  1. Adding in Post Step log reporting to ensure we recieve log output even on failed runs. — pbroels / githubweb
  2. Fixing syntax errror in the jenkins file. — pbroels / githubweb

#162 (Feb 10, 2022, 3:25:08 AM)

  1. Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing. — Gunther Huebler / githubweb

#161 (Feb 5, 2022, 3:25:07 AM)

  1. Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Pushing column loop into local functions. larson-group/clubb#972 — Gunther Huebler / githubweb

#160 (Feb 4, 2022, 3:25:07 AM)

  1. I added a subroutine that prints that values of all PDF parameters in — bmg2 / githubweb
  2. Small changes and a loop push. larson-group/clubb#972 — Gunther Huebler / githubweb
  3. Pushing loop into advance_xm_wpxp. larson-group/clubb#972 — Gunther Huebler / githubweb
  4. Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 — Gunther Huebler / githubweb

#159 (Feb 3, 2022, 3:25:09 AM)

  1. Fixed small bug that slipped through because the G_unit tests use nz=1. — Gunther Huebler / githubweb
  2. Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 — Gunther Huebler / githubweb

#158 (Feb 2, 2022, 3:25:09 AM)

  1. Pushing column index into zm2zt and zt2zm. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 — Gunther Huebler / githubweb
  3. A variety of small loop pushing. larson-group/clubb#972 — Gunther Huebler / githubweb

#157 (Jan 29, 2022, 3:25:22 AM)

  1. Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 — Gunther Huebler / githubweb

#156 (Jan 28, 2022, 3:25:24 AM)

  1. I am updating ice_supersat_frac to be an intent(inout) variable for — bmg2 / githubweb
  2. Updated for recent changes to CLUBB — bmg2 / githubweb

#155 (Jan 27, 2022, 3:25:25 AM)

  1. We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 — Gunther Huebler / githubweb

#154 (Jan 26, 2022, 3:25:23 AM)

  1. Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Making a commit that officially places the call to the PDF in the "post" — bmg2 / githubweb
  3. Making a commit that officially places the call to the PDF in the "post" — bmg2 / githubweb
  4. Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 — Gunther Huebler / githubweb
  5. Forgot an & symbol. — Gunther Huebler / githubweb

#153 (Jan 25, 2022, 3:25:23 AM)

  1. Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb

#152 (Jan 22, 2022, 3:25:25 AM)

  1. Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence — bmg2 / githubweb
  3. I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence — bmg2 / githubweb

#151 (Jan 21, 2022, 3:25:23 AM)

  1. Breaking up column loop in advance_clubb_core. larson-group/clubb#972 — Gunther Huebler / githubweb

#150 (Jan 20, 2022, 3:25:24 AM)

  1. Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 — Gunther Huebler / githubweb
  2. Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 — Gunther Huebler / githubweb

#149 (Jan 19, 2022, 3:25:24 AM)

  1. Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 — Gunther Huebler / githubweb

#148 (Jan 18, 2022, 10:28:37 AM)

  1. adapted SAM because CLUBB API changed — jan.gruenenwald / githubweb

#147 (Jan 17, 2022, 3:25:24 AM)

  1. Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm — noreply / githubweb
  2. Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm — noreply / githubweb

#146 (Jan 15, 2022, 3:25:24 AM)

  1. Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that — bmg2 / githubweb
  2. Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that — bmg2 / githubweb

#145 (Jan 14, 2022, 3:25:24 AM)

  1. This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. — Gunther Huebler / githubweb
  2. Changing the value of C_invrs_tau_shear from 0.02 to 0.15. — bmg2 / githubweb
  3. Changing the value of C_invrs_tau_shear from 0.02 to 0.15. — bmg2 / githubweb
  4. Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. — Gunther Huebler / githubweb

#144 (Jan 13, 2022, 3:25:25 AM)

  1. Making some paramters_silhs variables available from the silhs api — Gunther Huebler / githubweb
  2. Comment out setting of fatal error — noreply / githubweb

#143 (Jan 12, 2022, 3:25:26 AM)

  1. Making api version of setup_grid. larson-group/clubb#972 — Gunther Huebler / githubweb

#142 (Jan 11, 2022, 3:25:25 AM)

  1. Insert print about overwriting default flags with namelist values — noreply / githubweb
  2. Insert print about overwriting default parameters with namelist values — noreply / githubweb

#141 (Jan 6, 2022, 3:24:20 PM)

  1. Fixing the sam_clubb_silhs_gfortran build by locally making wp3 the — bmg2 / githubweb

#140 (Dec 30, 2021, 3:25:22 AM)

  1. I am adding more arguments to the argument list for advance_clubb_core — bmg2 / githubweb
  2. Updating SAM-CLUBB for the latest additions to the call to advance_clubb_core_api — bmg2 / githubweb

#139 (Dec 29, 2021, 3:25:24 AM)

  1. Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. — bmg2 / githubweb
  2. Now that uprcp and vprcp have been passed through advance_clubb_core, — bmg2 / githubweb

#138 (Dec 20, 2021, 2:34:02 PM)

  1. Adding new file to describe in detail SAM's wp2 and wp3 budgets. — benjamin.andrew.stephens / githubweb
  2. Fixing an array definition issue that created a problem with the PGI — benjamin.andrew.stephens / githubweb

#137 (Dec 18, 2021, 3:25:25 AM)

  1. Updates relevant to reproducing results for Stephens, Larson, and Mironov 2022. — 59519056+bstephens82 / githubweb
  2. Adding comments to described SAM's pressure variable. — 59519056+bstephens82 / githubweb
  3. These changes allow you to call the 4 clubb "advance" subroutines in any — Brian Griffin / githubweb
  4. Placing the order variables in a nice, convenient place for testing use. — Brian Griffin / githubweb
  5. I reordered advance_clubb_core so that the "Advance xp3" (which is a — Brian Griffin / githubweb
  6. I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx — Brian Griffin / githubweb
  7. I am indenting the portion of the code where the advance subroutines — Brian Griffin / githubweb
  8. Temporarily commenting out the idiot proofing in order to run some tests ... — Brian Griffin / githubweb
  9. Now official reinstating the idiot-proofing and turning off the — bmg2 / githubweb
  10. I am committing some idiot proofing in regards to the advance — bmg2 / githubweb
  11. Updated for the latest version of CLUBB. — bmg2 / githubweb

#136 (Dec 17, 2021, 3:25:23 AM)

  1. Updating RUNDATA/lst so that the new stats I added in https://github.com/larson-group/sam_clubb/commit/72a614957aa439ae75dbf8be6b4870a7a4c48c4b will be output. — benjamin.andrew.stephens / githubweb

#135 (Dec 4, 2021, 3:25:25 AM)

  1. Remove clipping from a3_coef. — noreply / githubweb

#134 (Dec 3, 2021, 3:25:25 AM)

  1. See ticket — jan.gruenenwald / githubweb
  2. added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — jan.gruenenwald / githubweb
  3. See respective messages on the issue 958 on date 10/12/2021 — jan.gruenenwald / githubweb
  4. See respective messages on the issue 958 on date 10/12/2021 — jan.gruenenwald / githubweb
  5. Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — jan.gruenenwald / githubweb
  6. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — jan.gruenenwald / githubweb
  7. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — jan.gruenenwald / githubweb
  8. Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — jan.gruenenwald / githubweb
  9. fixed a typo in pdf_closure_module.f90, line 1284 — jan.gruenenwald / githubweb
  10. fixed compiler warning regarding w_up_in_cloud — jan.gruenenwald / githubweb

#133 (Dec 1, 2021, 3:25:27 AM)

  1. Adding some additional statistics output relevant to Stephens Larson Mironov 2022 paper. — benjamin.andrew.stephens / githubweb

#132 (Nov 16, 2021, 3:25:07 AM)

  1. Passing w_up_in_cloud out of advance_clubb_core — bmg2 / githubweb
  2. Updating SAM-CLUBB for the most recent version of CLUBB. — bmg2 / githubweb

#131 (Nov 12, 2021, 3:25:11 AM)

  1. See ticket — 68997723+JanGrn / githubweb
  2. added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — 68997723+JanGrn / githubweb
  3. See respective messages on the issue 958 on date 10/12/2021 — 68997723+JanGrn / githubweb
  4. Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — 68997723+JanGrn / githubweb
  5. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — 68997723+JanGrn / githubweb
  6. Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — 68997723+JanGrn / githubweb
  7. See respective messages on the issue 958 on date 10/12/2021 — 68997723+JanGrn / githubweb
  8. fixed a typo in pdf_closure_module.f90, line 1284 — 68997723+JanGrn / githubweb
  9. Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — 68997723+JanGrn / githubweb

#130 (Nov 6, 2021, 4:25:52 AM)

  1. Updating for changes to CLUBB code. — bmg2 / githubweb

#129 (Nov 6, 2021, 3:25:07 AM)

  1. I have turned the nu_vert_res_dep family of variables into a derived — bmg2 / githubweb

#128 (Nov 2, 2021, 3:25:11 AM)

  1. Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690.  There was some overcounting of the relevant terms. — benjamin.andrew.stephens / githubweb
  2. This commit fixes SAM to work with the new version of CLUBB. — bmg2 / githubweb

#127 (Oct 31, 2021, 3:25:08 AM)

  1. I forgot to add this necessary subroutine call to the clubb API. — bmg2 / githubweb

#126 (Oct 30, 2021, 3:25:07 AM)

  1. I have passed clubb_params down into advance_xm_wpxp_module.F90. — bmg2 / githubweb
  2. I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. — bmg2 / githubweb
  3. I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 — bmg2 / githubweb
  4. Passing down more of CLUBB's tunable parameters. — bmg2 / githubweb
  5. I accidentally removed an important comment in the previous commit. — bmg2 / githubweb
  6. Passing down more CLUBB tunable parameters. — bmg2 / githubweb
  7. More passing down CLUBB parameters ... whoop-de-doo — bmg2 / githubweb
  8. Passing down more tunable parameters and removing references to — bmg2 / githubweb
  9. Handling the abomination that is lmin. — bmg2 / githubweb
  10. Passing tunable parameters into the new tau code. — bmg2 / githubweb
  11. Passed down more parameters. Results are bit-for-bit. — bmg2 / githubweb
  12. Passing through more clubb parameters. Bit-for-bit — bmg2 / githubweb
  13. Passing down CLUBB's tunable parameters into the setup_pdf_parameters and — bmg2 / githubweb
  14. Passing down CLUBB's tunable parameters into the remainder of the — bmg2 / githubweb
  15. I passed down the forgotten thlp2_rad_coef tunable parameter. — bmg2 / githubweb
  16. I am passing down the forgotten parameter, altitude threshold, in — bmg2 / githubweb
  17. I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
  18. I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
  19. Adding an option to use invrs_tau_N2_iso for C4 terms.  The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233).  The flag is currently set to false so results will be b4b. — 59519056+bstephens82 / githubweb
  20. Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion.  This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. — 59519056+bstephens82 / githubweb
  21. Adding comments for clarity. — 59519056+bstephens82 / githubweb

#125 (Oct 28, 2021, 3:25:08 AM)

  1. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/968. — benjamin.andrew.stephens / githubweb
  2. Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3.  Relevant to CLUBB issue #920. — 59519056+bstephens82 / githubweb
  3. Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3.  Relevant to CLUBB issue #920. — 59519056+bstephens82 / githubweb
  4. Updates as requested to the l_use_tke_in_K_dfsn code: — 59519056+bstephens82 / githubweb
  5. Updates as requested to the l_use_tke_in_K_dfsn code: — 59519056+bstephens82 / githubweb

#124 (Oct 27, 2021, 3:25:07 AM)

  1. Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test.  I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. — benjamin.andrew.stephens / githubweb

#123 (Oct 23, 2021, 3:25:11 AM)

  1. These updates incorporate some of Shixuan Zhang's changes, including: — benjamin.andrew.stephens / githubweb

#122 (Oct 15, 2021, 3:25:09 AM)

  1. Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix.  I included comments to describe why this was done.  Results are b4b. — benjamin.andrew.stephens / githubweb

#121 (Oct 13, 2021, 3:25:11 AM)

  1. Removing line to trigger the nightly tests for all repos. — noreply / githubweb

#120 (Oct 5, 2021, 3:25:08 AM)

  1. Add a blank line to trigger nightly tests. — noreply / githubweb

#119 (Oct 2, 2021, 3:25:07 AM)

  1. Updates to separate out C4 and C14 in advance_xp2 module.  This will make it easier to control which invrs_tau_* variable multiplies each term for example. — 59519056+bstephens82 / githubweb
  2. Changing the name of dummy_1d variables for clarity. — 59519056+bstephens82 / githubweb

#118 (Sep 25, 2021, 3:25:06 AM)

  1. I am fixing a bug that was introduced in 6b0348e, where the logical — bmg2 / githubweb

#117 (Sep 17, 2021, 3:25:07 AM)

  1. Adding a more direct calculation of W2PRESDFSN, which differs slightly from W2PRES near the surface but is very similar aloft. — benjamin.andrew.stephens / githubweb

#116 (Sep 16, 2021, 3:25:06 AM)

  1. Add space to trigger nightly tests.  For larson-group/sys_admin#755. — noreply / githubweb

#115 (Sep 14, 2021, 3:25:08 AM)

  1. Remove space to trigger autoupdate. larson-group/sys_admin#755 — noreply / githubweb

#114 (Sep 12, 2021, 3:25:10 AM)

  1. Adding space to trigger autoupdate. larson-group/sys_admin#755 — Gunther Huebler / githubweb

#113 (Sep 11, 2021, 3:25:08 AM)

  1. Adding space to trigger autoupdate. larson-group/sys_admin#755 — Gunther Huebler / githubweb

#112 (Sep 4, 2021, 3:25:05 AM)

  1. Removing a couple of unused parameters from use statement. — noreply / githubweb
  2. Pushing k loop down through clip_variance_level. — rhodesk / githubweb
  3. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. — 59519056+bstephens82 / githubweb
  4. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. — 59519056+bstephens82 / githubweb
  5. Updating some comments related to the tuner updates. — 59519056+bstephens82 / githubweb

#111 (Sep 3, 2021, 3:25:09 AM)

  1. Pushing k loop down through clip_variance_level. — rhodesk / githubweb
  2. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. — 59519056+bstephens82 / githubweb
  3. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. — 59519056+bstephens82 / githubweb
  4. Updating some comments related to the tuner updates. — 59519056+bstephens82 / githubweb

#110 (Sep 2, 2021, 3:25:07 AM)

  1. Removing a couple of unused parameters from use statement. — noreply / githubweb

#109 (Sep 1, 2021, 3:25:10 AM)

  1. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  2. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  3. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  4. Eliminating l_include_ice and sat_ice_ratio. — rhodesk / githubweb
  5. Eliminating l_update_pressure flag. — rhodesk / githubweb
  6. Eliminating l_update_pressure flag. — rhodesk / githubweb
  7. Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
  8. Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
  9. Updating the surface clipping coefficient... — noreply / githubweb
  10. Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb
  11. Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb

#108 (Aug 31, 2021, 3:25:08 AM)

  1. Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb
  2. Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb
  3. Reflecting changes made to clubb in host models — 72510114+RhodesKeegan / githubweb
  4. Adding clubb directory for testing — 72510114+RhodesKeegan / githubweb
  5. Removing clubb and silhs directory for tonight's merge — 72510114+RhodesKeegan / githubweb
  6. Add new common module that exposes internal methods — isenfireldc / githubweb
  7. Add module-level statements for subroutines — isenfireldc / githubweb
  8. Fix issues that came from moving subroutines to the common module — isenfireldc / githubweb
  9. Add input file and dimensions to readiopdata_common — isenfireldc / githubweb
  10. Add surface variables to readiopdata_common — isenfireldc / githubweb
  11. Add time/pressure variables to readiopdata_common — isenfireldc / githubweb
  12. Add soundings to readiopdata_common — isenfireldc / githubweb
  13. Add remaining surface and sounding code to readiopdata_common — isenfireldc / githubweb
  14. Remove unnecessary arguments from readiopdata_common — isenfireldc / githubweb
  15. Rename readiopdata_common to readiopdata_core — isenfireldc / githubweb
  16. Rename readiopdata_core subroutine to readiopdata_core_snd — isenfireldc / githubweb
  17. Create readiopdata_core_dims subroutine — isenfireldc / githubweb
  18. Create readiopdata_core_sfc subroutine — isenfireldc / githubweb
  19. Clean up readiopdata_core — isenfireldc / githubweb
  20. Create readiopdata_core_frc subroutine — isenfireldc / githubweb
  21. Fix readiopdata_core for use as a shared module in clubb — isenfireldc / githubweb
  22. Change comparison operators to match clubb standard — isenfireldc / githubweb
  23. Change file name in print statements to readiopdata_core_module.F90 — isenfireldc / githubweb
  24. Move readiopdata_core_module.F90 to a subdirectory for use with git-subtree — isenfireldc / githubweb
  25. Add SRC/READIOPDATA_CORE to build paths — isenfireldc / githubweb

#107 (Aug 26, 2021, 3:25:09 AM)

  1. Updating the surface clipping coefficient... — noreply / githubweb

#106 (Aug 21, 2021, 3:25:09 AM)

  1. Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
  2. Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
  3. Reflecting changes made to clubb in host models — rhodesk / githubweb

#105 (Aug 19, 2021, 3:25:09 AM)

  1. For clubb:ticket:770, the Oracle compiler was throwing a floating point exception here. wpxp2 and xp2 were being fed in as Nans. — weberjk / githubweb
  2. The new file calc_roots.F90 contains functions that solve for the roots of a — bmg2 / githubweb
  3. I tweaked the precipitation fraction code so that the weighted ith PDF component — bmg2 / githubweb
  4. For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j. — raut / githubweb
  5. I updated pdf_closure_module.F90 by integrating changes I made in the — bmg2 / githubweb
  6. For cam:ticket:36: — raut / githubweb
  7. For cam:ticket:36#comment:132, I removed `gr` from the use statement in `setup_grid_heights_api`. — raut / githubweb
  8. For clubb:ticket:773, I fixed some unsoundness in our code regarding kinds, specifically in `parameters_model.F90` and `endian.F90`. — raut / githubweb
  9. For cam:ticket:41, the change in clubb:r7921 should be applied to the trunk as well. — raut / githubweb
  10. For clubb:ticket:775: — raut / githubweb
  11. For clubb:ticket:775: — raut / githubweb
  12. Misc. code cleanup — raut / githubweb
  13. I am updating default CLUBB to use the same hydrometeor PDF parameters that are — bmg2 / githubweb
  14. For cam:ticket:50: — raut / githubweb
  15. For cam:ticket:52: — raut / githubweb
  16. For cam:ticket:52, I added some parameter indices to the API. — raut / githubweb
  17. I forgot a parameter! — raut / githubweb
  18. For clubb:ticket:753: — raut / githubweb
  19. For clubb:ticket:782: — raut / githubweb
  20. I forgot a flag. — raut / githubweb
  21. For clubb:ticket:782: — raut / githubweb
  22. For cam:ticket:55, I added some parameters to CLUBB's API. — raut / githubweb
  23. For cam:ticket:55: — raut / githubweb
  24. I cleaned up some warnings from the Mac compiler. (build:14977) — raut / githubweb
  25. For clubb:ticket:785, I renamed `initvars` to `clubb_params_nl`. — raut / githubweb
  26. For clubb:ticket:785: — raut / githubweb
  27. For clubb:ticket:779: — raut / githubweb
  28. For clubb:ticket:786: — raut / githubweb
  29. For clubb:ticket:786: — raut / githubweb
  30. For clubb:ticket:782, I added all CLUBB's parameter indices to the API. — raut / githubweb
  31. helpful note — raut / githubweb
  32. more helpful note — raut / githubweb
  33. most helpful note — raut / githubweb
  34. For cam:ticket:56: — raut / githubweb
  35. While working on cam:ticket:59, I noticed that `tau_N2_zm` is computed twice. I removed one computation. — raut / githubweb
  36. Dat crazy indentation, though... — raut / githubweb
  37. For cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`. — raut / githubweb
  38. For cam:ticket:59: — raut / githubweb
  39. For cam:ticket:59: — raut / githubweb
  40. For cam:ticket:59: — raut / githubweb
  41. For cam:ticket:59, I added a new output for Richardson number. — raut / githubweb
  42. For cam:ticket:59: — raut / githubweb
  43. Per cam:ticket:59#comment:21, using `T_in_K_zm` in "the formula". — raut / githubweb
  44. For cam:ticket:59. — raut / githubweb
  45. For cam:ticket:59 I renamed `Richardson_no` to `Richardson_num`. — raut / githubweb
  46. For cam:ticket:59, I added kludgy statistical output for `brunt_vaisala_freq_sqd`. — raut / githubweb
  47. For cam:ticket:59: — raut / githubweb
  48. For cam:ticket:59: — raut / githubweb
  49. For cam:ticket:59: — raut / githubweb
  50. For cam:ticket:59. — raut / githubweb
  51. For cam:ticket:59: — raut / githubweb
  52. Apparently, I didn't have to jump through the hoop of declaring a separate profile to use in the `max` statement. — raut / githubweb
  53. For cam:ticket:59: — raut / githubweb
  54. For cam:ticket:59: — raut / githubweb
  55. For cam:ticket:59: — raut / githubweb
  56. For clubb:ticket:782: — raut / githubweb
  57. For cam:ticket:59: — raut / githubweb
  58. For cam:ticket:59: — raut / githubweb
  59. For cam:ticket:59: — raut / githubweb
  60. For cam:ticket:59: — raut / githubweb
  61. For clubb:ticket:782: — raut / githubweb
  62. For cam:ticket:59: — raut / githubweb
  63. For cam:ticket:59, I fixed bugs in the `l_use_C7_Richardson=T` vertical averaging code: — raut / githubweb
  64. I adjusted a comment. — raut / githubweb
  65. For clubb:ticket:788: — raut / githubweb
  66. For cam:ticket:59: — raut / githubweb
  67. For clubb:ticket:788: — raut / githubweb
  68. For clubb:ticket:788: — raut / githubweb
  69. For clubb:ticket:788: — raut / githubweb
  70. For clubb:ticket:788: — raut / githubweb
  71. For clubb:ticket:788: — raut / githubweb
  72. Renamed C7 to Cx in appropriate places. — raut / githubweb
  73. For cam:ticket:59: — raut / githubweb
  74. For cam:ticket:59: — raut / githubweb
  75. I made it a default to use 0 instead of cloud_frac_min in the B.V. frequency calculation. — raut / githubweb
  76. For cam:ticket:67: — raut / githubweb
  77. For cam:ticket:67: — raut / githubweb
  78. Code improvements. — raut / githubweb
  79. Vince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more! — raut / githubweb
  80. For cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used. — raut / githubweb
  81. Fixed a comment. — raut / githubweb
  82. For clubb:ticket:788: — raut / githubweb
  83. For clubb:ticket:792: — raut / githubweb
  84. For clubb:ticket:792: — raut / githubweb
  85. For clubb:ticket:792, I added more initializations for uninitialized variables. — raut / githubweb
  86. When l_avg_Lscale is turned on but the plume-centered calculation is disabled, — bmg2 / githubweb
  87. For clubb:ticket:792: — raut / githubweb
  88. For clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output. — raut / githubweb
  89. I renamed RH_postPDF to rel_humidity. — raut / githubweb
  90. For clubb:ticket:792. rsat actually should be recomputed here before output, because it will change if `l_rcm_supersat_adj = T`. — raut / githubweb
  91. For clubb:ticket:792. I am reusing the `rel_humidity` variable for output, for no particular reason. — raut / githubweb
  92. For clubb:ticket:792!!!! I set `l_rcm_supersat_adj = T` by default, in both source code and namelist. — raut / githubweb
  93. As requested, I am adding a warning message (debug level 1) when spurious supersaturation is removed. — raut / githubweb
  94. Comment. — raut / githubweb
  95. For clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010). — raut / githubweb
  96. I removed a spurious print statement. — raut / githubweb
  97. For cam:ticket:73: — raut / githubweb
  98. I am beginning to generalize the sponge damping code so that it can be applied to — bmg2 / githubweb
  99. I have added all the coding infrastructure to perform sponge damping (and record — bmg2 / githubweb
  100. — Vince Larson / githubweb
  101. clubb:ticket:796 — roessle9 / githubweb
  102. I added some parameter value checking in subroutine setup_parameters. — bmg2 / githubweb
  103. I finally have a standalone version of the new subroutine, generate_pdf_params, — bmg2 / githubweb
  104. Some code within advance_clubb_core that is found within CAM_CLUBB preprocessor — bmg2 / githubweb
  105. The perturbation Lscale code requires rtm_frz, thlm_frz, and pdf_params_frz to — bmg2 / githubweb
  106. I added a missing intent(out) statement. — bmg2 / githubweb
  107. I have interfaced the new subroutine containing all of the PDF closure-related — bmg2 / githubweb
  108. I got rid of some variables that were brought into advance_clubb_core by use statements — bmg2 / githubweb
  109. I cleaned up more compiler warnings for unused variables.  The warnings came from g95. — bmg2 / githubweb
  110. I have added a second call to subroutine generate_pdf_params.  This one occurs — bmg2 / githubweb
  111. I moved the setting of qclvar and thlprcp_out to after the second call to — bmg2 / githubweb
  112. I have declared the l_use_ice_latent option and the l_call_pdf_closure_twice — bmg2 / githubweb
  113. I added a local cslculation of sigma_sqd_w near the top of subroutine — bmg2 / githubweb
  114. I am changing the inputs and outputs of subroutine advance_clubb_core so that — bmg2 / githubweb
  115. I added code so that stats that are internal to subroutine generate_pdf_params — bmg2 / githubweb
  116. I have updated subroutine advance_clubb_core so that pdf_params_zm is now passed — bmg2 / githubweb
  117. Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical — savva / githubweb
  118. Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical — savva / githubweb
  119. — Vince Larson / githubweb
  120. — Vince Larson / githubweb
  121. I added a new subroutine, init_pdf_params, to pdf_parameter_module.F90. — bmg2 / githubweb
  122. I renamed the subroutine pack_pdf_params found in setup_clubb_pdf_params.F90 — bmg2 / githubweb
  123. I am now using the new subroutine init_pdf_params to initialize the — bmg2 / githubweb
  124. I removed the CAM_CLUBB preprocessor directives from pack_pdf_params_api, — bmg2 / githubweb
  125. clubb:ticket:800 -- Changed fatal errors statements to debug level 0. — savva / githubweb
  126. I updated CLUBB stats so that wpthvp, wp2thvp, rtpthvp, and thlpthvp — bmg2 / githubweb
  127. I have added the coding infrastructure to output additional statistics — bmg2 / githubweb
  128. This is a bug fix for the Sun compiler.  The variables pdf_params_zm and — bmg2 / githubweb
  129. I am updating the hydrometeor PDF code to set mu_hm_1 and — bmg2 / githubweb
  130. Running the Bitten tests. — bmg2 / githubweb
  131. I added some comments so that CLUBB-SILHS would be consistent with — Vince Larson / githubweb
  132. As a first step, I changed all instances of rrtthl to corr_rt_thl_1. — bmg2 / githubweb
  133. I have added corr_rt_thl_2 to the code to go along with corr_rt_thl_2. — bmg2 / githubweb
  134. I have added some code to add corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2 — bmg2 / githubweb
  135. I added new statistics to the CLUBB _zt output files, specifically corr_w_rt_1, corr_w_rt_2, — bmg2 / githubweb
  136. I am updating the equations for wp2rtp, wp2thlp, wprtp2, and wpthlp2 to include — bmg2 / githubweb
  137. I am adding a special function to calculate the within-component correlation of — bmg2 / githubweb
  138. I added variables corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 — bmg2 / githubweb
  139. I am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to type — bmg2 / githubweb
  140. Now that the PDF component correlations of w and chi, as well as w and eta, — bmg2 / githubweb
  141. I am adding statistical output for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, — bmg2 / githubweb
  142. I am changing the name of the flag l_fix_chi_eta_correlations to — bmg2 / githubweb
  143. The two component normal (double Gaussian) PDF used by CLUBB will now be — bmg2 / githubweb
  144. I moved the checking of the options for the PDF call placement to subroutine — bmg2 / githubweb
  145. I am altering setup PDF parameters to be able to read in the values of — bmg2 / githubweb
  146. I am adding the new file new_pdf.F90 to the CLUBB core directory.  So far, it — bmg2 / githubweb
  147. I am adding a large amount of code to the new PDF.  I have filled in the driver — bmg2 / githubweb
  148. I am adding code to the new PDF that calculates the minimum and maximum — bmg2 / githubweb
  149. I added a new iiPDF entry for the new PDF, and I neatened some of the current — bmg2 / githubweb
  150. I added an option to call the new PDF from subroutine pdf_closure. — bmg2 / githubweb
  151. I had to add checking for the new PDF so someone does not try to run it — bmg2 / githubweb
  152. I made a couple changes to (1) initialize two variables that aren't used by the — bmg2 / githubweb
  153. I added a conditional to the subroutine that sets the responder parameters. — bmg2 / githubweb
  154. I have added the beginnings of a new unit test for the PDF parameters. — bmg2 / githubweb
  155. I have updated the PDF parameter unit test to make a call to the full PDF (for — bmg2 / githubweb
  156. I have added a feature to the PDF parameter unit tests which allows the user — bmg2 / githubweb
  157. In the setter variable description and subprograms, I made a name change from — bmg2 / githubweb
  158. I have updated the method of calculating the setter variable so that mu_x_1 — bmg2 / githubweb
  159. I added primarily some more documentation and notes. — bmg2 / githubweb
  160. I added some more comments documenting the code. — bmg2 / githubweb
  161. I got rid of some of the expressions that a script might try to flag as — bmg2 / githubweb
  162. I added much more documentation about the responder variable.  Specifically, — bmg2 / githubweb
  163. I am adding the new file, original_pdf.F90, as the new home for the ADG1, ADG2, — bmg2 / githubweb
  164. I have now switched the PDF closure code over to calling the code that had been — bmg2 / githubweb
  165. I updated the documentation in the code comments for the setter method and — bmg2 / githubweb
  166. I added a comment. — bmg2 / githubweb
  167. I added a new function, calc_comp_corrs_binormal, to pdf_utilities.F90.  This — bmg2 / githubweb
  168. I added some more descriptive comments and a new function that calculates the — bmg2 / githubweb
  169. I updated the code so that coef_sigma_x_1_sqd and coef_sigma_x_2_sqd are passed — bmg2 / githubweb
  170. I fixed a mistake. — bmg2 / githubweb
  171. I have added code to call the new function that calculates wp4 implicitly from — bmg2 / githubweb
  172. I moved the calculations of wp2xp (wp2rtp and wp2thlp), wp4, and wpxp2 (wprtp2 — bmg2 / githubweb
  173. I added another function to the new PDF.  This function helps to calculate — bmg2 / githubweb
  174. I added a special case for the wpxp2 implicit code. — bmg2 / githubweb
  175. Back in clubb:r8409, the PDF component correlations of w and rt and w and — bmg2 / githubweb
  176. I added a subroutine that calculates the implicit and explicit portions of the — bmg2 / githubweb
  177. I renamed original_pdf.F90 as adg1_adg2_3d_luhar_pdf.F90. — bmg2 / githubweb
  178. I added statistical output for F_w, F_rt, F_thl, min_F_w, max_F_w, min_F_rt, — bmg2 / githubweb
  179. I split the new PDF into two files.  I added a new file that currently houses — bmg2 / githubweb
  180. I clipped temperature within the Goff-Gratch functions for saturation over liquid and ice. — Vince Larson / githubweb
  181. I initialized some output variables in order to prevent a runtime error. — bmg2 / githubweb
  182. I made a sub-driver level subroutine for the calculations necessary for a — bmg2 / githubweb
  183. I added code to allow the variable (of w, rt, or theta-l) with the greatest — bmg2 / githubweb
  184. I added calls to the functions and subroutines that calculate the implicit and — bmg2 / githubweb
  185. I changed coef_wp2xp_explicit (coef_wp2rtp_explicit and coef_wp2thlp_explicit) — bmg2 / githubweb
  186. I am adding a new file for the new trivariate skewness-dependent analaytic — bmg2 / githubweb
  187. I fixed a bug in the new Trivariate skewness-dependent analytic double Gaussian — bmg2 / githubweb
  188. In order for the TSDADG PDF to work correctly, when Skx * sgn( <w'x'> ) >= 0, — bmg2 / githubweb
  189. In order to clarify coding in CLUBB, I am moving a block of code that is — bmg2 / githubweb
  190. I am fixing a bug where rtp2 and thlp2 (and sclrp2) were not preserved when — bmg2 / githubweb
  191. I updated the TSDADG PDF by adding the responding variable description, the — bmg2 / githubweb
  192. When ADG1 or ADG2 are not used, we have to set alpha_rt, alpha_thl, and — bmg2 / githubweb
  193. I am calling the new TSDADG PDF from subroutine pdf_closure. — bmg2 / githubweb
  194. Clarity changes to the new TSDADG PDF. — bmg2 / githubweb
  195. I added some references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
  196. I fixed a bug in the calculation of PDF component variances in the new TSDADG — bmg2 / githubweb
  197. I added more references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
  198. I have set the tunable parameters F_x and zeta_x to skewness functions for the — bmg2 / githubweb
  199. I needed to increase the limit of nvarmax_zt so that LBA (and other — bmg2 / githubweb
  200. I changed the URL references to the CLUBB-SILHS overview document. — Vince Larson / githubweb
  201. Changed variable and subroutine names, see ticket 810 and 811 — hoc_browser / githubweb
  202. I have added the Lewellen and Yoh (1993) PDF to CLUBB for testing and comparison — bmg2 / githubweb
  203. Fixed line length exceding 100 characters warnings — Gunther Huebler / githubweb
  204. Changed the arrangement of variables in the subroutine compute_mixing_length as well as calls to it clubb:ticket:815 — Gunther Huebler / githubweb
  205. Fixed lines exceeding 100 characters warnings clubb:ticket:815 — Gunther Huebler / githubweb
  206. I added an option to incorporate the buoyancy term into CLUBB's eddy diffusivity for momentum. — Vince Larson / githubweb
  207. I added c_K10 as a tuning parameter in front of the new momentum eddy diffusivity. — Vince Larson / githubweb
  208. Removed unused parameters to clear warnings clubb:ticket:803 — Gunther Huebler / githubweb
  209. I multiplied the eddy diffusivity for momentum by a skewness-dependent factor — Vince Larson / githubweb
  210. I changed the way that F_rt and F_thl are set in the new PDF.  They are now set — bmg2 / githubweb
  211. I changed the flag setting on the new PDF so that it always uses w as the setter — bmg2 / githubweb
  212. Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803 — Gunther Huebler / githubweb
  213. Improved binary search algorithm clubb:ticket:818 — Gunther Huebler / githubweb
  214. Added warning messages to function binary_search clubb:ticket:818 — Gunther Huebler / githubweb
  215. Removed unused variables causing warnings clubb:ticket:803 — Gunther Huebler / githubweb
  216. I updated the call to the new PDF so that Skrt and Skthl are intent INOUT — bmg2 / githubweb
  217. Removed many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803 — Gunther Huebler / githubweb
  218. I am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90.  This — bmg2 / githubweb
  219. I finished adding the units to the variable descriptions in — bmg2 / githubweb
  220. The calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>, — bmg2 / githubweb
  221. I added the tunable or adjustable parameters for the new PDF to CLUBB's list — bmg2 / githubweb
  222. Fixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803 — Gunther Huebler / githubweb
  223. I am committing a line of code that limits the adjusted correlation of rt and — bmg2 / githubweb
  224. I implemented a new method to handle cumulus momentum fluxes. — Vince Larson / githubweb
  225. Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804 — Gunther Huebler / githubweb
  226. Removed file anl_erf.F90, it is no longer used — Gunther Huebler / githubweb
  227. I am altering the solution to the wp3 predictive equation to calculate the — bmg2 / githubweb
  228. I fixed the problem with the wp3 budgets as a result of r8584.  The budgets in — bmg2 / githubweb
  229. I altered the names of the turbulent advection functions that are closed by — bmg2 / githubweb
  230. I added a couple comments about how the discretization of the turbulent — bmg2 / githubweb
  231. I added the function that sets up the implicit calculation of the wp3 turbulent — bmg2 / githubweb
  232. I added a function that calculates the explicit form of the wp3 turbulent — bmg2 / githubweb
  233. I am adding a function to calculate the turbulent advection of wpxp explicitly. — bmg2 / githubweb
  234. I am adding a function to calculate the turbulent advection of xp2 and xpyp — bmg2 / githubweb
  235. I interfaced the wp3 explicit turbulent advection code with CLUBB.  It is — bmg2 / githubweb
  236. I am interfacing the wpxp explicit turbulent advection option with the rest of — bmg2 / githubweb
  237. I fixed a small bug with the explicit turbulent advection option for wpxp. — bmg2 / githubweb
  238. I am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code. — bmg2 / githubweb
  239. I added the l_explicit_turbulent_adv_* family of flags to the new PDF, for some — bmg2 / githubweb
  240. I am packing up the implicit coefficients and explicit terms calculated by the — bmg2 / githubweb
  241. Made epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804 — Gunther Huebler / githubweb
  242. I made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90. — bmg2 / githubweb
  243. I have completed interfacing the implicit form of the wp3 turbulent advection — bmg2 / githubweb
  244. When the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advection — bmg2 / githubweb
  245. I cleaned up the Skx_module and added an additional function, — bmg2 / githubweb
  246. I fixed a bug in the calculation of scalar skewness.  It was being set to 0, — bmg2 / githubweb
  247. I moved the location of the LG 2005 ansatz to calculate xp3 because it would be — bmg2 / githubweb
  248. I reverted clubb:r8611 because (1) having the code in the other location — bmg2 / githubweb
  249. I have added a new function, term_ta_new_pdf_lhs, to — bmg2 / githubweb
  250. I have linked the implicit turbulent advection code for rtp2 and thlp2 to the — bmg2 / githubweb
  251. I have added a new file that has two options for handling the xp3 term for — bmg2 / githubweb
  252. I have interface the new xp3 code to the rest of CLUBB.  It can be turned on — bmg2 / githubweb
  253. I added a driver level subroutine for the new advance xp3 code.  This will make — bmg2 / githubweb
  254. I added budget stats for rtp3 and thlp3 to CLUBB. — bmg2 / githubweb
  255. I am adding code that allows the turbulent advection of wpxp to be treated — bmg2 / githubweb
  256. Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code. — Gunther Huebler / githubweb
  257. Various small comment removals and returned some functionality to api interface clubb:ticket:800 — Gunther Huebler / githubweb
  258. A variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800 — Gunther Huebler / githubweb
  259. This is the first part of a two-part change.  I am updating plotgen plots so — bmg2 / githubweb
  260. In part 2 of this two part commit, I have added rc_coef to the list of — bmg2 / githubweb
  261. Various debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800 — Gunther Huebler / githubweb
  262. Check negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800 — Gunther Huebler / githubweb
  263. I'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800 — Gunther Huebler / githubweb
  264. Changed calls to parameterization check to work with the new check negative implementation clubb:ticket:800 — Gunther Huebler / githubweb
  265. — Gunther Huebler / githubweb
  266. Removed rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800 — Gunther Huebler / githubweb
  267. Changed error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800 — Gunther Huebler / githubweb
  268. Fixed unused variable warnings related to error code changes — Gunther Huebler / githubweb
  269. I am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to account — bmg2 / githubweb
  270. Added error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to  keep track of error messages is multithreaded scenarios clubb:ticket:800 — Gunther Huebler / githubweb
  271. In r8659, I accidentally overwrote some code.  This commit restores the prior — bmg2 / githubweb
  272. Sigh — bmg2 / githubweb
  273. Added clubb debug level checks to error checking statements clubb:ticket:800 — Gunther Huebler / githubweb
  274. Changed many stop commands to return commands and added more err_code checks clubb:ticket:800 — Gunther Huebler / githubweb
  275. Reverted api changes that broke SAM and WRF — Gunther Huebler / githubweb
  276. I am adding the semi-implicit formulation of wprtpthlp, which is the turbulent — bmg2 / githubweb
  277. I am adding output statistics for the implicit and semi-implicit coefficients — bmg2 / githubweb
  278. I corrected the units on a couple of implicit coefficients. — bmg2 / githubweb
  279. I fixed a bug. — bmg2 / githubweb
  280. Removed failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
  281. Removed reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
  282. I am fixing a bug with the CLUBB tuner.  Variables that were allocated at the — bmg2 / githubweb
  283. Completed the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800 — Gunther Huebler / githubweb
  284. Made all debug levels produce the same output, see clubb:ticket:823 — Gunther Huebler / githubweb
  285. I am moving type variable implicit_coefs_terms from new_pdf_main.F90 to — bmg2 / githubweb
  286. Modified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802 — Gunther Huebler / githubweb
  287. Added checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802 — Gunther Huebler / githubweb
  288. This should fix the thlm out of bounds error on clubb:ticket:828 — Gunther Huebler / githubweb
  289. I changed the name of type variable new_pdf_implct_coefs_terms to — bmg2 / githubweb
  290. Changed T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828 — Gunther Huebler / githubweb
  291. I added a flag option to clip the (large, negative) effects of microphysics on — bmg2 / githubweb
  292. I added a flag option to calculate the minimum threshold for xp2 (rtp2 and — bmg2 / githubweb
  293. I added a special max magnitude correlation for fluxes wprtp and wpthlp.  This — bmg2 / githubweb
  294. Made better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more information — Gunther Huebler / githubweb
  295. This commit sets C8b=0.02, changes the non-linear damping on wp3 — Vince Larson / githubweb
  296. Added a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829 — Gunther Huebler / githubweb
  297. I am adding a general purpose function for the turbulent advection of CLUBB's — bmg2 / githubweb
  298. I added/changed a couple comments for the rhs portion of the generalized — bmg2 / githubweb
  299. The turbulent advection file that handles turbulent advection for predictive — bmg2 / githubweb
  300. I added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, that — bmg2 / githubweb
  301. Whoops, I forgot to make wpxpyp_zm and xpyp intent (in). — bmg2 / githubweb
  302. Added functionality to make the  hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830 — Gunther Huebler / githubweb
  303. I am updating the code that advances predictive variances and covariances in — bmg2 / githubweb
  304. Renamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830 — Gunther Huebler / githubweb
  305. I am updating the code that advances predictive scalar fluxes (<w'x'>) in — bmg2 / githubweb
  306. As a first step toward having code that can clip mean values of hydrometeor — bmg2 / githubweb
  307. init_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562 — Gunther Huebler / githubweb
  308. I have now interfaced the subroutine that I made out of the code that clips — bmg2 / githubweb
  309. I added new code that clips the overall correlation of w and rt or the overall — bmg2 / githubweb
  310. I added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which are — bmg2 / githubweb
  311. Made clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800 — Gunther Huebler / githubweb
  312. Reverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800 — Gunther Huebler / githubweb
  313. Fixed nightly tests — Gunther Huebler / githubweb
  314. I have added code to allow C2 to be adjusted by multiplying by the greater of — bmg2 / githubweb
  315. I moved the location of the declaration and setting of new model flags to — bmg2 / githubweb
  316. Improved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834 — Gunther Huebler / githubweb
  317. Fixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834 — Gunther Huebler / githubweb
  318. Actually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
  319. Optimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
  320. Reverted stats_clubb_utilities, accidental commit — Gunther Huebler / githubweb
  321. This should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837 — Gunther Huebler / githubweb
  322. — Vince Larson / githubweb
  323. Impoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834 — Gunther Huebler / githubweb
  324. This commit implements the effects of splatting on wp3. — Vince Larson / githubweb
  325. I am making the first step toward committing code that allows for the option — bmg2 / githubweb
  326. I added code to allow the option of predicting upwp and vpwp by using the — bmg2 / githubweb
  327. I took the liberty of upgrading CLUBB's PDF closure and related code to a vector — bmg2 / githubweb
  328. I updated the monotonic flux limiter to account for vector variables u and v. — bmg2 / githubweb
  329. I am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output. — bmg2 / githubweb
  330. In r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic flux — bmg2 / githubweb
  331. I am turning on the l_predict_upwp_vpwp code! — bmg2 / githubweb
  332. Improved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834 — Gunther Huebler / githubweb
  333. Improved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834 — Gunther Huebler / githubweb
  334. Changed the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834 — Gunther Huebler / githubweb
  335. Added grid_class to the dependency lists of the pdf files that were changed in commit 8773 — Gunther Huebler / githubweb
  336. Accidental commit, undoing 8783 — Gunther Huebler / githubweb
  337. I am changing the default setting of flags l_min_wp2_from_corr_wx and — Brian Griffin / githubweb
  338. Modified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834 — Gunther Huebler / githubweb
  339. Removed print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases. — Gunther Huebler / githubweb
  340. Changed the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834 — Gunther Huebler / githubweb
  341. I am adding source code for the introduction of budgets for predictive upwp — Brian Griffin / githubweb
  342. Improved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834 — Gunther Huebler / githubweb
  343. Improved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834 — Gunther Huebler / githubweb
  344. Modified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834 — Gunther Huebler / githubweb
  345. Copied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834 — Gunther Huebler / githubweb
  346. Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834 — Gunther Huebler / githubweb
  347. Improved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834 — Gunther Huebler / githubweb
  348. I made the surface splatting terms conservative.  That is, I subtracted from wp2_sfc — Vince Larson / githubweb
  349. I added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2. — Vince Larson / githubweb
  350. This commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero).  Hence it is BIT_CHANGING. — Vince Larson / githubweb
  351. Added functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834 — Gunther Huebler / githubweb
  352. Update advance_clubb_core_module.F90 — noreply / githubweb
  353. I clipped sigma_sqd_w to prevent interpolated values of it — Vince Larson / githubweb
  354. I added a new option to diagnose the dissipation time scale, tau, first — Vince Larson / githubweb
  355. I found a new way to diagnose upthvp.  Instead of using a bound on correlations, it relies — Vince Larson / githubweb
  356. introducing error into clubb core for testing larson-group/sys_admin#533 — mcfadd34 / githubweb
  357. reverting error that was introduced larson-group/sys_admin#533 — mcfadd34 / githubweb
  358. I am briefly changing some of the flag and parameter settings in CLUBB — bmg2 / githubweb
  359. Revert "I am briefly changing some of the flag and parameter settings in CLUBB" — bmg2 / githubweb
  360. I added a couple of comments reminding users to change the conditions in — bmg2 / githubweb
  361. Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"" — bmg2 / githubweb
  362. Revert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""" — bmg2 / githubweb
  363. I committed a subroutine, diagnose_upxp, that calculates — Vince Larson / githubweb
  364. Improved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834 — Gunther Huebler / githubweb
  365. I am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a large — bmg2 / githubweb
  366. I am updating the code within setup_clubb_pdf_parameters.F90 in order to take — bmg2 / githubweb
  367. To diagnose uprcp using CLUBB's PDF machinery, — Vince Larson / githubweb
  368. Continuing with diagnosis of uprcp using CLUBB's PDF, — Vince Larson / githubweb
  369. More code to diagnose uprcp using CLUBB's PDF. — Vince Larson / githubweb
  370. Correction for the last uprcp-related commit: — Vince Larson / githubweb
  371. I am correcting the code so that the Nightly Uninitialized Variables Test — bmg2 / githubweb
  372. I am continuing to pull parts of setup_pdf_parameters outside of a large "do" — bmg2 / githubweb
  373. I am pulling statistical output subroutine pdf_param_ln_hm_stats outside — bmg2 / githubweb
  374. Changing the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope. — Gunther Huebler / githubweb
  375. commenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566 — mcfadd34 / githubweb
  376. uncommenting threadprivate larson-group/sys_admin#566 — mcfadd34 / githubweb
  377. I have changed the structure of setup_pdf_parameters so that the subroutine that — bmg2 / githubweb
  378. Returned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING. — Gunther Huebler / githubweb
  379. I am turning on the new calculation of uprcp that uses CLUBB's PDF. — Vince Larson / githubweb
  380. I modified the code in setup_clubb_pdf_params.F90 to use only one call to — bmg2 / githubweb
  381. I am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch to — bmg2 / githubweb
  382. I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch — bmg2 / githubweb
  383. I temporarily set l_clip_extreme_chi_sample_pts back to false in the — bmg2 / githubweb
  384. Revert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the" — bmg2 / githubweb
  385. I improved the error messages when LU decomp. fails within — bmg2 / githubweb
  386. Improved error message prints in advance_xm_wpxp. — bmg2 / githubweb
  387. I added improved LHS and RHS print statements when a LU decomp. error occurs — bmg2 / githubweb
  388. I added params_list to the list of variables that are accessible through — bmg2 / githubweb
  389. I am making the first step for updating the code that calculates sigma_sqd_w. — bmg2 / githubweb
  390. I added a log-law height dependence to the code that diagnoses — Vince Larson / githubweb
  391. I added fill_holes_hydromet_api to clubb_api_module.F90. — bmg2 / githubweb
  392. I added a new python script, check_for_missing_threadprivate.py, — Vince Larson / githubweb
  393. Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834 — Gunther Huebler / githubweb
  394. Fixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834 — Gunther Huebler / githubweb
  395. Added temp test file — noreply / githubweb
  396. Remove test file — noreply / githubweb
  397. Adding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical. — Gunther Huebler / githubweb
  398. Optimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases. — Gunther Huebler / githubweb
  399. ticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequency — guozhun / githubweb
  400. Modifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855 — Gunther Huebler / githubweb
  401. Replacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855 — Gunther Huebler / githubweb
  402. Making procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855 — Gunther Huebler / githubweb
  403. Missed one — Gunther Huebler / githubweb
  404. I have added a new file, calc_pressure.F90, which contains code for initializing — bmg2 / githubweb
  405. I updated CLUBB so that pressure is updated after mean fields have been — bmg2 / githubweb
  406. Removing gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855 — Gunther Huebler / githubweb
  407. Forgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855 — Gunther Huebler / githubweb
  408. issue #842 — guozhun / githubweb
  409. We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. — guozhun / githubweb
  410. We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. — guozhun / githubweb
  411. We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842) — guozhun / githubweb
  412. We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842) — guozhun / githubweb
  413. Update tunable_parameters.in — noreply / githubweb
  414. Update advance_clubb_core_module.F90 — noreply / githubweb
  415. We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly) — guozhun / githubweb
  416. We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly) — guozhun / githubweb
  417. Efficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855 — Gunther Huebler / githubweb
  418. This should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855 — Gunther Huebler / githubweb
  419. An additional damping is added to the invrs_tau term in the C8 equation. ticket #842 — guozhun / githubweb
  420. An additional damping is added to the invrs_tau term in the C8 equation. ticket #842 — guozhun / githubweb
  421. Adding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations. — Gunther Huebler / githubweb
  422. We use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8. — guozhun / githubweb
  423. Changing ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855 — Gunther Huebler / githubweb
  424. Pulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855 — Gunther Huebler / githubweb
  425. Renaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855 — Gunther Huebler / githubweb
  426. Efficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855. — Gunther Huebler / githubweb
  427. Modifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855 — Gunther Huebler / githubweb
  428. Refactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855 — Gunther Huebler / githubweb
  429. Update advance_clubb_core_module.F90 — noreply / githubweb
  430. Update advance_clubb_core_module.F90 — noreply / githubweb
  431. I switched on direct diagnosis of tau rather than Lscale. — Vince Larson / githubweb
  432. I switched on direct diagnosis of tau rather than Lscale. — Vince Larson / githubweb
  433. I updated the pressure initialization for cases that use sounding that is given — bmg2 / githubweb
  434. I changed the function calculate_thvm from a pre-defined vector of size nz to — bmg2 / githubweb
  435. I updated the calculation of thvm in advance_clubb_core to use the — bmg2 / githubweb
  436. Adding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler. — Gunther Huebler / githubweb
  437. Adding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855 — Gunther Huebler / githubweb
  438. Changing where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626 — Gunther Huebler / githubweb
  439. I am committing a test where I changed subroutine ADG1_w_closure — bmg2 / githubweb
  440. Changing determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862 — Gunther Huebler / githubweb
  441. Finally fixing line length error in pdf_closure — Gunther Huebler / githubweb
  442. Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861 — Gunther Huebler / githubweb
  443. Adding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862 — Gunther Huebler / githubweb
  444. This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc. — guozhun / githubweb
  445. This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc. — guozhun / githubweb
  446. Update advance_helper_module.F90 — noreply / githubweb
  447. Update advance_clubb_core_module.F90 — noreply / githubweb
  448. Update advance_helper_module.F90 — noreply / githubweb
  449. Adding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626 — Gunther Huebler / githubweb
  450. I am adding a file for the new hybrid PDF, which combines the w equation set — bmg2 / githubweb
  451. I updated the function to calculate the implicit coefficient for the wp4 term, — bmg2 / githubweb
  452. I made some changes to new_hybrid_pdf.F90 so that it would compile in its — bmg2 / githubweb
  453. I edited that subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
  454. I updated the subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
  455. Replaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves. — nselke / githubweb
  456. I am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the new — bmg2 / githubweb
  457. I worked more the functions for the new hybrid PDF. — bmg2 / githubweb
  458. Refactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855 — Gunther Huebler / githubweb
  459. I changed all the PDF utility functions in pdf_utilities.F90 to elemental — bmg2 / githubweb
  460. I forgot a "then" to go with an "elseif". — bmg2 / githubweb
  461. Adding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855 — Gunther Huebler / githubweb
  462. Adding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855 — Gunther Huebler / githubweb
  463. Refactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855 — Gunther Huebler / githubweb
  464. I am continuing to build the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
  465. I am continuing to work on the driver file for the new hybrid PDF. — bmg2 / githubweb
  466. I have completed the main parts of the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
  467. The code for the new hybrid PDF now compiles. — bmg2 / githubweb
  468. I added an entry for the new hybrid PDF. — bmg2 / githubweb
  469. I have added the new hybrid PDF to the G unit tests. — bmg2 / githubweb
  470. Mathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0. — bmg2 / githubweb
  471. I added code to interface the call to the new hybrid PDF with pdf_closure — bmg2 / githubweb
  472. I interfaced the implicit coefficients and explicit terms used in the turbulent — bmg2 / githubweb
  473. I fixed a small error.  The code compiles again now. — bmg2 / githubweb
  474. Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group — pbroels / githubweb
  475. I have added code that allows CLUBB to run interactively using the new hybrid — bmg2 / githubweb
  476. I am updating the subroutine that calculates PDF component means and standard — bmg2 / githubweb
  477. I placed proper thresholding on interpolated up2 and interpolated vp2 — bmg2 / githubweb
  478. I added a limiter to keep the maximum magnitude of the correlations of — bmg2 / githubweb
  479. I upgraded Nc_Ncn_eqns.F90 to use elemental functions. — bmg2 / githubweb
  480. The new hybrid PDF also uses this bit of code that sets the correlation — bmg2 / githubweb
  481. I made modifications to the new hybrid PDF so that that calculation of F_w — bmg2 / githubweb
  482. I added the ability to handle scalars interactively to the new hybrid PDF. — bmg2 / githubweb
  483. I found a couple of spots in the new hybrid PDF where I needed to add — bmg2 / githubweb
  484. I added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90. — bmg2 / githubweb
  485. I am setting the zeta variance ratio to 1 (symmetric design) by — bmg2 / githubweb
  486. The variable type implicit_coefs_terms needs to be made public — bmg2 / githubweb
  487. I changed the value of the coefficient in the F_w equation to 0.45 — bmg2 / githubweb
  488. I am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_core — bmg2 / githubweb
  489. I have started the process of adding the coding infrastructure — bmg2 / githubweb
  490. I have completed the addition of the ability to use different up2 — bmg2 / githubweb
  491. I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856 — nselke / githubweb
  492. I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856 — nselke / githubweb
  493. I made the l_calc_w_corr code (turned off by default) run again by — bmg2 / githubweb
  494. I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute. — nselke / githubweb
  495. I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute. — nselke / githubweb
  496. I have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac', — nselke / githubweb
  497. I continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm', — nselke / githubweb
  498. I continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm', — nselke / githubweb
  499. I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp', — nselke / githubweb
  500. Finished altering argument lists. This commit covers the final seven flags, which are in different namelists. — nselke / githubweb
  501. I introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type. — nselke / githubweb
  502. I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856 — nselke / githubweb
  503. I fed pdf_params_frz into subroutine advance_clubb_core — Vince Larson / githubweb
  504. Adding error code to arguement list of non-api routines where it was included in the api version. — Gunther Huebler / githubweb
  505. Moving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal. — Gunther Huebler / githubweb
  506. Added use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public. — Steffen Domke / githubweb
  507. I have fixed the warnings for lines exceeding 100 characters. — nselke / githubweb
  508. Passing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity. — Gunther Huebler / githubweb
  509. Trivial update to test if cams autoupdate works — noreply / githubweb
  510. Revert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch" — bmg2 / githubweb
  511. I placed E3SM preprocessor commands around E3SM-specific code in — bmg2 / githubweb
  512. Restoring assertion check for the vertical correlation calculation. larson-group/clubb#869 — Gunther Huebler / githubweb
  513. Changing the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869 — Gunther Huebler / githubweb
  514. I added E3SM's clubb_ parameters that can be read in from the — bmg2 / githubweb
  515. I added the remainder the clubb_ terms that were added previously to — bmg2 / githubweb
  516. Changing error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869 — Gunther Huebler / githubweb
  517. Small updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  518. Redoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  519. Adding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
  520. Simple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
  521. Small performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  522. Removing lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869 — Gunther Huebler / githubweb
  523. Update latin_hypercube_driver_module.F90 — noreply / githubweb
  524. Update parameters_tunable.F90 — noreply / githubweb
  525. GPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  526. Making some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
  527. I changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874 — nselke / githubweb
  528. I added the new l_update_pressure configurable flag to clubb_config_flags. — bmg2 / githubweb
  529. I added the new l_update_pressure configurable flag to clubb_config_flags. — bmg2 / githubweb
  530. I added some code I used in the special input fields branch to make — bmg2 / githubweb
  531. An improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875] — guozhun / githubweb
  532. I revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874. — nselke / githubweb
  533. I got rid of the "allocatable", "allocate", and "deallocate" statements — bmg2 / githubweb
  534. I placed an ifndef CLUBB_CAM preprocessor flag around the code in — bmg2 / githubweb
  535. I reduced the minimum possible value of lmin from 4.0 to 1.0. — noreply / githubweb
  536. I made a print/write statement debug level 3 — noreply / githubweb
  537. I made a second print/write statement debug level 3 — noreply / githubweb
  538. I fix a print/write statement debug level3. For #755 and #800 — guozhun / githubweb
  539. I am replacing the "use" statements that referenced — bmg2 / githubweb
  540. I "brought back the stats" by passing the stats from advance_clubb_core — bmg2 / githubweb
  541. Removing the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref) — bmg2 / githubweb
  542. Results were changed yesterday for some cases because thlprcp was — bmg2 / githubweb
  543. I have resolved all the issues surrounding recent CLUBB commits that — bmg2 / githubweb
  544. I removed code that stops a run if the output time step is less than a minute. — noreply / githubweb
  545. I removed references to variables_prognostic_module and — bmg2 / githubweb
  546. Fixed a boo-boo. — bmg2 / githubweb
  547. I set `l_diag_Lscale_from_tau = .true.` in source code — noreply / githubweb
  548. I removed references to variable_diagnostic_module for various Kessler — bmg2 / githubweb
  549. I removed the reference to use variables_diagnostic_module for Kh_zm — bmg2 / githubweb
  550. Removed a reference to variables_diagnostic_module for Kh_zm in — bmg2 / githubweb
  551. I am able to remove references to variables_prognostic_module and — bmg2 / githubweb
  552. I removed the l_use_ice_latent flag from the code, and along with it — bmg2 / githubweb
  553. I removed the l_use_ice_latent flag from the code, and along with it — bmg2 / githubweb
  554. I have completed the project of removing variables_prognostic_module — bmg2 / githubweb
  555. I added some missing threadprivate statements — noreply / githubweb
  556. I have taken the code from wp2_term_ta_all and placed it in the subroutine — bmg2 / githubweb
  557. I am updating wp3_term_ta_new_pdf_lhs to use the optimized code from — bmg2 / githubweb
  558. This commit is BIT_CHANGING.  It makes the parameter values in parameters_tunable.F90 agree with those in tunable_parameters.in — benjamin.andrew.stephens / githubweb
  559. I am making the change of using tau_wp2_zm to damp up2 and vp2, — bmg2 / githubweb
  560. I have added the integer flags iiPDF_type and ipdf_call_placement — bmg2 / githubweb
  561. I have added the integer flags iiPDF_type and ipdf_call_placement — bmg2 / githubweb
  562. I am going to make primary PDF type options and primary PDF call — bmg2 / githubweb
  563. I added E3SM customizations to CLUBB's master branch.  This is meant — bmg2 / githubweb
  564. I am updating the clubb_ list of namelist parameters used in E3SM — bmg2 / githubweb
  565. Typo — bmg2 / githubweb
  566. Fixed more typos — bmg2 / githubweb
  567. I am changing the new hybrid PDF's calculation of F_w to use — bmg2 / githubweb
  568. I updated the xp3 calculation for PDF types other than ADG1. — bmg2 / githubweb
  569. This xp3_coef_ parameters produce new hybrid PDF results similar to the old — bmg2 / githubweb
  570. I added the 2 new parameters in the simple xp3 equation (for PDF — bmg2 / githubweb
  571. I added the 2 new parameters in the simple xp3 equation (for PDF — bmg2 / githubweb
  572. I have combined the wp3_term_ta_ADG1_lhs and wp3_term_ta_ADG1_lhs_all — bmg2 / githubweb
  573. I added the partially upwinded implementation of the wp3 turbulent advection — bmg2 / githubweb
  574. Removed unused module imports — isenfireldc / githubweb
  575. Removed unused module imports — isenfireldc / githubweb
  576. Removed a comma that I missed while removing unused imports (#878) — isenfireldc / githubweb
  577. I am adding l_partial_upwind_wp3 to the list of clubb_config_flags. — bmg2 / githubweb
  578. I am adding l_partial_upwind_wp3 to the list of clubb_config_flags. — bmg2 / githubweb
  579. Deprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129 — Gunther Huebler / githubweb
  580. Adding clubb case files that were missed from last commit larson-group/cam#129 — Gunther Huebler / githubweb
  581. I started the process of paring 2 subprograms back down to 1 in — bmg2 / githubweb
  582. I pared two more sets of equivalent subprograms down to 1 (each). — bmg2 / githubweb
  583. Paring down 2 equivalent subprograms to 1 again. — bmg2 / githubweb
  584. I condensed two more sets of doubled subprograms down to 1 (each) — bmg2 / githubweb
  585. Reduced two more sets of "doubled" subprograms down. — bmg2 / githubweb
  586. Updating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129 — Gunther Huebler / githubweb
  587. Adding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129 — Gunther Huebler / githubweb
  588. I updated CLUBB's copyright date range. — noreply / githubweb
  589. Adding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129 — Gunther Huebler / githubweb
  590. Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
  591. Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
  592. Taking more duplicated subprograms and paring them down to 1. — bmg2 / githubweb
  593. Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
  594. Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
  595. Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
  596. Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
  597. Removed styleguide violations from my code — isenfireldc / githubweb
  598. Fixed a backwards epsilon comparison from 8e8e71e — isenfireldc / githubweb
  599. Removed the "doubling" of the remainder of the subprograms from — bmg2 / githubweb
  600. Changing epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878 — Gunther Huebler / githubweb
  601. Small changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129 — Gunther Huebler / githubweb
  602. Changed the length of solve_type_str to 20 [-Wcharacter-trucation] — isenfireldc / githubweb
  603. Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
  604. Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
  605. Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
  606. Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
  607. I have tidied up advance_wp2_wp3_module.F90, and I have removed all doubled — bmg2 / githubweb
  608. Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
  609. Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
  610. I handled the "doubled" subprograms in turbulent_adv_pdf.F90. — bmg2 / githubweb
  611. Making change explained in larson-group/clubb#878 — Gunther Huebler / githubweb
  612. Removed some unused variables (ifort) — isenfireldc / githubweb
  613. Removed some unused variables (ifort) — isenfireldc / githubweb
  614. Adding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129 — Gunther Huebler / githubweb
  615. Removed unused import [-Wunused-variable] — isenfireldc / githubweb
  616. Removes unused function calc_cloud_frac [-Wunused-function] — isenfireldc / githubweb
  617. Fixes style issue — isenfireldc / githubweb
  618. Removed import without only as it was unused — isenfireldc / githubweb
  619. Adds mpishorthand back with only, it appears to be used somewhere — isenfireldc / githubweb
  620. I have pared two subprograms down to one again, this time for the — bmg2 / githubweb
  621. I pared down subprogram pairs again, this time for mean advection. — bmg2 / githubweb
  622. I added altitude_threshold to the list of CLUBB's tunable parameters. — bmg2 / githubweb
  623. I added altitude_threshold to the list of CLUBB's tunable parameters. — bmg2 / githubweb
  624. Updating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots. — strike / githubweb
  625. Updating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be). — strike / githubweb
  626. Adds more debug lines — isenfireldc / githubweb
  627. Removes debug lines — isenfireldc / githubweb
  628. Adds debug lines and changes format — isenfireldc / githubweb
  629. Modifies debug line — isenfireldc / githubweb
  630. Modifies debug line — isenfireldc / githubweb
  631. Initialize ncf%ntimes to 0 when opening netcdf for writing — isenfireldc / githubweb
  632. Removes debug lines — isenfireldc / githubweb
  633. Changes length of units variable in stat_file_module from 20 to 25 — isenfireldc / githubweb
  634. This commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true.  A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines. — benjamin.andrew.stephens / githubweb
  635. Adding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close.  This will aid in implementing the SILHS 2D output subroutines in host models.  The new API subroutines necessitated some minor changes in clubb_driver.F90 as well.  Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo). — benjamin.andrew.stephens / githubweb
  636. I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
  637. I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
  638. This commit primarily overhauls the way the 2D SILHS samples are output to netCDF.  Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file.  Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
  639. This commit primarily overhauls the way the 2D SILHS samples are output to netCDF.  Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file.  Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
  640. Undoing accidental find and replace. larson-group/cam#129 — Gunther Huebler / githubweb
  641. Updated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832 — nchief / githubweb
  642. Fix super serious 1 character bug that broke all of the things — strike / githubweb
  643. I am committing Zhun's changes to the CLUBB portion of his — bmg2 / githubweb
  644. I modified tunable_parameters.in to use some of the parameter values that — bmg2 / githubweb
  645. Update stats_zm_module.F90 — noreply / githubweb
  646. I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max — bmg2 / githubweb
  647. I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max — bmg2 / githubweb
  648. I connected the new tunable parameters to advance_helper_module.F90. — bmg2 / githubweb
  649. I added l_use_shear_Richardson to CLUBB's configurable model flags. — bmg2 / githubweb
  650. I added l_use_shear_Richardson to CLUBB's configurable model flags. — bmg2 / githubweb
  651. Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp.  This is intended to help smooth high-frequency oscillations.  Flag is set to false by default so has no impact on standard runs. — benjamin.andrew.stephens / githubweb
  652. Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp.  This is intended to help smooth high-frequency oscillations.  Flag is set to false by default so has no impact on standard runs. — benjamin.andrew.stephens / githubweb
  653. I forgot to add rtp2_clip_coef to tunable_parameters.in (this doesn't affect — bmg2 / githubweb
  654. In order to prevent dycoms2_rf02_so from crashing, — Vince Larson / githubweb
  655. I updated the recording of the budget terms for upwp_pr4 and vpwp_pr4. — Vince Larson / githubweb
  656. Adding the smooth_min and smooth_max functions to the repo.  These are not yet implemented in CLUBB but are now available for use and testing. See issue #894. — benjamin.andrew.stephens / githubweb
  657. Adding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions.  See issue #894. — benjamin.andrew.stephens / githubweb
  658. Modifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129 — Gunther Huebler / githubweb
  659. This commit replaces division by tau with multiplication by inverse tau in most cases.  It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files.  Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine. — benjamin.andrew.stephens / githubweb
  660. I am committing a bug fix to the invrs_tau_zm equation that was — bmg2 / githubweb
  661. CLUBB and pyplotgen changes: — benjamin.andrew.stephens / githubweb
  662. I fixed the LMM stepping bug that was affecting E3SM (because — bmg2 / githubweb
  663. Fixed alignment. — bmg2 / githubweb
  664. This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code.  The primary code changes are in advance_clubb_core_module.F90. — benjamin.andrew.stephens / githubweb
  665. This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code.  The primary code changes are in advance_clubb_core_module.F90. — benjamin.andrew.stephens / githubweb
  666. Update parameter_indices.F90 — noreply / githubweb
  667. Setting parameters and flags to be consistent with the CLUBB repo prior to the October 8 commit merging some E3SM code (https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795).  This should help to basically recover the plots from before the merge, which is useful for single-column model testing. — benjamin.andrew.stephens / githubweb
  668. Update model_flags.F90 — noreply / githubweb
  669. Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3).  See issue #884. — benjamin.andrew.stephens / githubweb
  670. Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3).  See issue #884. — benjamin.andrew.stephens / githubweb
  671. Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced.  See https://github.com/larson-group/clubb/issues/901. — benjamin.andrew.stephens / githubweb
  672. Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced.  See https://github.com/larson-group/clubb/issues/901. — benjamin.andrew.stephens / githubweb
  673. I am now passing vert_decorr_coef into SILHS instead of involving — bmg2 / githubweb
  674. This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39).  Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before.  I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up). — benjamin.andrew.stephens / githubweb
  675. Adding a test to make sure new C_uu_buoy parameter is within the valid range. See #901. — benjamin.andrew.stephens / githubweb
  676. This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb".  The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. — benjamin.andrew.stephens / githubweb
  677. This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb".  The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. — benjamin.andrew.stephens / githubweb
  678. This will allow for a better interface of SILHS parameter — bmg2 / githubweb
  679. Fixed a preprocessor command. — bmg2 / githubweb
  680. I'm adding the api entry for read_silhs_parameters, called — bmg2 / githubweb
  681. Revert "I'm adding the api entry for read_silhs_parameters, called" — bmg2 / githubweb
  682. Revert "Fixed a preprocessor command." — bmg2 / githubweb
  683. Revert "This will allow for a better interface of SILHS parameter" — bmg2 / githubweb
  684. I updated silhs_api_module so that vert_decorr_coef is publically available — bmg2 / githubweb
  685. Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code.  The flag is set to false by default so results are unaffected.  See #902. — benjamin.andrew.stephens / githubweb
  686. Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code.  The flag is set to false by default so results are unaffected.  See #902. — benjamin.andrew.stephens / githubweb
  687. Update configurable_model_flags.in — noreply / githubweb
  688. Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. — benjamin.andrew.stephens / githubweb
  689. Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. — benjamin.andrew.stephens / githubweb
  690. Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129 — Gunther Huebler / githubweb
  691. Update parameters_tunable.F90 — noreply / githubweb
  692. Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129 — Gunther Huebler / githubweb
  693. Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129 — Gunther Huebler / githubweb
  694. Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
  695. Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
  696. Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch.  See #902. — 59519056+bstephens82 / githubweb
  697. Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch.  See #902. — 59519056+bstephens82 / githubweb
  698. Turning on wp3 pr_turb term. — benjamin.andrew.stephens / githubweb
  699. Turning on wp3 pr_turb term. — benjamin.andrew.stephens / githubweb
  700. Changed the variable up2_vp2_factor to up2_sfc_coef in all files — rhodesk / githubweb
  701. Changed the variable up2_vp2_factor to up2_sfc_coef in all files — rhodesk / githubweb
  702. I added an option to improve dry, convecting boundary layers. — Vince Larson / githubweb
  703. This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2.  In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1.  This makes the terms in these equations more consistent with the terms in the wp2 equation.  I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped). — Vince Larson / githubweb
  704. Changed surface to sfc in all instances where requested — rhodesk / githubweb
  705. Undid sfc change in stats_sfc_module.F90 — noreply / githubweb
  706. Undid sfc change to grid_class.F90 — noreply / githubweb
  707. Undid sfc change in numerical_check.F90 — noreply / githubweb
  708. Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129 — Gunther Huebler / githubweb
  709. Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  710. Fixed typo bug. larson-group/cam#129 — Gunther Huebler / githubweb
  711. Pushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  712. More pushing loops down. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  713. More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  714. More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  715. Adding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129 — Gunther Huebler / githubweb
  716. More loop pushing, all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  717. Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions. — Gunther Huebler / githubweb
  718. Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled. — Gunther Huebler / githubweb
  719. Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129 — Gunther Huebler / githubweb
  720. Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  721. Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  722. Performance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  723. Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  724. Reducing operations. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  725. Adding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  726. Some small cleanup, all just formatting. larson-group/cam#129 — Gunther Huebler / githubweb
  727. Changed ustar from an array to a scalar issue #909 — rhodesk / githubweb
  728. Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909 — rhodesk / githubweb
  729. Created new subroutine and ensured it's BFB. All cases run sucessfully #909 — rhodesk / githubweb
  730. added in missing flag which was causing memory errors #909 — rhodesk / githubweb
  731. confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909 — rhodesk / githubweb
  732. Update stats_zm_module.F90 — noreply / githubweb
  733. Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129 — Gunther Huebler / githubweb
  734. Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  735. Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  736. Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  737. Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129 — Gunther Huebler / githubweb
  738. Reformatted mixing length to be more compliant with the coding standard #909 — rhodesk / githubweb
  739. added a reference to new subroutine #909 — rhodesk / githubweb
  740. Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
  741. Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
  742. Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
  743. Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
  744. Pushing loops related to pdf_params down. larson-group/cam#129 — Gunther Huebler / githubweb
  745. clubb warnings introduced from merge have been removed #909 — rhodesk / githubweb
  746. Changed safeguard threshold in sigma_sqd_w. — rhodesk / githubweb
  747. Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. — 59519056+bstephens82 / githubweb
  748. Adding new coefficient to control the wp3 pressure diffusion term. — 59519056+bstephens82 / githubweb
  749. Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. — 59519056+bstephens82 / githubweb
  750. Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. — 59519056+bstephens82 / githubweb
  751. Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). — 59519056+bstephens82 / githubweb
  752. These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. — 59519056+bstephens82 / githubweb
  753. Adding new coefficient to control the wp3 pressure diffusion term. — 59519056+bstephens82 / githubweb
  754. Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form.  This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. — 59519056+bstephens82 / githubweb
  755. These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. — 59519056+bstephens82 / githubweb
  756. Added intent comments for the following files: — rhodesk / githubweb
  757. Setting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway. — benjamin.andrew.stephens / githubweb
  758. Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core.  Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs).  This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated. — benjamin.andrew.stephens / githubweb
  759. Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90. — benjamin.andrew.stephens / githubweb
  760. Fixed comment regarding wp3 splatting term. — benjamin.andrew.stephens / githubweb
  761. Added intent comments. — rhodesk / githubweb
  762. Added intent comments. — rhodesk / githubweb
  763. Added intent comments for advance_xp2_xpyp_module.F90. — rhodesk / githubweb
  764. Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface. — 59519056+bstephens82 / githubweb
  765. Deleting comments around the old "magic number" for the near-surface clipping. — 59519056+bstephens82 / githubweb
  766. Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928. — Gunther Huebler / githubweb
  767. Changed some elements of clubb to allow for better script execution — rhodesk / githubweb
  768. Fixed clubb not compiling — rhodesk / githubweb
  769. Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
  770. Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
  771. Reverted changes to clubb_api. For #886 — rhodesk / githubweb
  772. Replacing use gr statements with feeding gr throught the arg list. — rhodesk / githubweb
  773. Adding proper indentation to needed files. — rhodesk / githubweb
  774. Fixing spacing issue on blank lines. #886 — rhodesk / githubweb
  775. Fixed comment changes. #886 — rhodesk / githubweb
  776. Fixed incorrect spacing on use — rhodesk / githubweb
  777. Revert "Fixed incorrect spacing on use" — rhodesk / githubweb
  778. Fixed spacing — rhodesk / githubweb
  779. Fixed spacing going too far — rhodesk / githubweb
  780. Fixed comments being pushed over — rhodesk / githubweb
  781. Fixed not all variables being indented properly — rhodesk / githubweb
  782. Fixed indentation going beyond variables — rhodesk / githubweb
  783. Fixed file_functions indentation being off — rhodesk / githubweb
  784. Fixed indentation on operations being wrong — rhodesk / githubweb
  785. Reverted incorrect changes to new_pdf and new_hybrid_pdf — rhodesk / githubweb
  786. Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
  787. Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
  788. Removing gr as a module variable from grid_class. — rhodesk / githubweb
  789. Removing gr as a module variable from grid_class. — rhodesk / githubweb
  790. Fixing typo in stats_zm_module.F90.  Background:  Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases.  It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit.  This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced.  However, since the budget balance test still found the variable, it kept passing successfully.  This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format. — benjamin.andrew.stephens / githubweb
  791. Fixing a typo from an earlier commit. — noreply / githubweb
  792. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  793. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  794. Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB. — rhodesk / githubweb
  795. The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken. — rhodesk / githubweb
  796. Add error header for CLUBB in CAM — noreply / githubweb
  797. Fixing the ordering of gr in the clubb_api arg list for affected subroutines. — rhodesk / githubweb
  798. Fixing coding standard violations — rhodesk / githubweb
  799. Improving error messages in setup_clubb_core. larson-group/e3sm#38 — Gunther Huebler / githubweb
  800. Feeding stats variables through the argument lists of needed subroutines. — 72510114+RhodesKeegan / githubweb
  801. Fixing spacing issues along with placing the stats varibales on their own lines. — 72510114+RhodesKeegan / githubweb
  802. Changing more subroutines to include stats vars in their arg lists. — 72510114+RhodesKeegan / githubweb
  803. Fixing incorrect subroutine arg list — 72510114+RhodesKeegan / githubweb
  804. Fixing host models not compiling. — 72510114+RhodesKeegan / githubweb
  805. Fixing argument list so that way the coding standard is upheld. — 72510114+RhodesKeegan / githubweb
  806. I changed the name to calc_responder_driver because I thought that — bmg2 / githubweb
  807. Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978.  Related to #920. — 59519056+bstephens82 / githubweb
  808. Fixing comment for the wp2_term_pr_dfsn subroutine.  Related to #920. — 59519056+bstephens82 / githubweb
  809. Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. — 59519056+bstephens82 / githubweb
  810. Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues.  Related to #920. — 59519056+bstephens82 / githubweb
  811. Fixing some comments. — 59519056+bstephens82 / githubweb
  812. Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978.  Related to #920. — 59519056+bstephens82 / githubweb
  813. Correcting a typo bug and adding some descriptive comments to two new variables.  This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. — benjamin.andrew.stephens / githubweb
  814. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
  815. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
  816. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  817. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  818. Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation.  Related to #920. — 59519056+bstephens82 / githubweb
  819. Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine.  Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. — 59519056+bstephens82 / githubweb
  820. Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation.  Related to #920. — 59519056+bstephens82 / githubweb
  821. Removing l_interp_prescribed_params from setup_clubb_pdf_params. — rhodesk / githubweb
  822. Adding comments labeling subroutine calls with intent. — rhodesk / githubweb
  823. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
  824. Removing unnecessary constant from use statement — noreply / githubweb
  825. Eliminating l_nu_grid_dependent as requested. — rhodesk / githubweb
  826. Eliminating l_use_buoy_mod_Km_zm. — rhodesk / githubweb
  827. Eliminating l_iter_xp2_xpyp flag. — rhodesk / githubweb
  828. Eliminating l_apply_rule_to_pdf_params flag. — rhodesk / githubweb
  829. Eliminating l_ub_const_deriv flag. — rhodesk / githubweb
  830. Eliminating l_equation_21 flag. — rhodesk / githubweb
  831. Eliminating l_wp3_2nd_buoyancy flag. — rhodesk / githubweb
  832. Eliminating l_refine_grid_in_cloud and l_interactive_refined. — rhodesk / githubweb
  833. Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds — rhodesk / githubweb
  834. Eliminating l_use_wp3_pr3 flag. — rhodesk / githubweb
  835. Eliminating l_clip_semi_implicit flag. — rhodesk / githubweb
  836. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
  837. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  838. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  839. Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
  840. Eliminating l_include_ice and sat_ice_ratio. — rhodesk / githubweb
  841. Eliminating l_update_pressure flag. — rhodesk / githubweb
  842. Eliminating l_update_pressure flag. — rhodesk / githubweb

#104 (Aug 18, 2021, 3:25:09 AM)

  1. Reflecting changes made to clubb in host models — rhodesk / githubweb
  2. Raw-copy updating SRC/CLUBB — LarsonGroupSysAdmin / githubweb

#103 (Aug 17, 2021, 9:29:29 AM)

  1. Swapping out old intel variable set script for new intel script. — pbroels / githubweb

#102 (Aug 17, 2021, 9:09:15 AM)

  1. Raw-copy updating SRC/CLUBB — root / githubweb
  2. Raw-copy updating SRC/SILHS — root / githubweb

#101 (Aug 14, 2021, 3:25:09 AM)

  1. Commiting to test host models — 72510114+RhodesKeegan / githubweb
  2. Fixing compilation error — 72510114+RhodesKeegan / githubweb
  3. Reverting changes made to clubb and silhs — 72510114+RhodesKeegan / githubweb

#100 (Aug 13, 2021, 3:25:08 AM)

  1. Eliminating l_use_wp3_pr3 flag. — rhodesk / githubweb
  2. Eliminating l_clip_semi_implicit flag. — rhodesk / githubweb
  3. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb

#99 (Aug 12, 2021, 3:25:07 AM)

  1. Eliminating l_apply_rule_to_pdf_params flag. — rhodesk / githubweb
  2. Eliminating l_ub_const_deriv flag. — rhodesk / githubweb
  3. Eliminating l_equation_21 flag. — rhodesk / githubweb
  4. Adding new intel environment file to oth run and compile step. larson-group/sys_admin#750 — pbroels / githubweb
  5. Fixing error in previous commit. — pbroels / githubweb
  6. Eliminating l_wp3_2nd_buoyancy flag. — rhodesk / githubweb
  7. Eliminating l_refine_grid_in_cloud and l_interactive_refined. — rhodesk / githubweb
  8. Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds — rhodesk / githubweb

#98 (Aug 11, 2021, 3:25:09 AM)

  1. Eliminating l_nu_grid_dependent as requested. — rhodesk / githubweb
  2. Eliminating l_use_buoy_mod_Km_zm. — rhodesk / githubweb
  3. Eliminating l_iter_xp2_xpyp flag. — rhodesk / githubweb

#97 (Aug 4, 2021, 3:25:08 AM)

  1. Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
  2. Removing unnecessary constant from use statement — noreply / githubweb

#96 (Aug 3, 2021, 3:25:09 AM)

  1. Adding comments labeling subroutine calls with intent. — rhodesk / githubweb

#95 (Jul 31, 2021, 3:25:07 AM)

  1. Removing l_interp_prescribed_params from setup_clubb_pdf_params. — rhodesk / githubweb
  2. Changes readiopdata_module to use nf90 subroutines — isenfireldc / githubweb
  3. Switches nf_real to nf90_real — isenfireldc / githubweb
  4. Replaces nf_get_var_<type> family with nf90_get_var — isenfireldc / githubweb
  5. Moves more calls to nf90 — isenfireldc / githubweb
  6. Replace nf_inq_dimlen with nf90_inquire_dimension — isenfireldc / githubweb
  7. Replace nf_inq_dimname with nf90_inquire_dimension — isenfireldc / githubweb
  8. Replace nf_get_vara_ subroutines with nf90_get_var — isenfireldc / githubweb
  9. Remove `include netcdf.inc` statements — isenfireldc / githubweb
  10. Remove redundant code — isenfireldc / githubweb
  11. Use nf90_inquire_dimension to manually set count value for nf90_get_var — isenfireldc / githubweb
  12. Add workaround for k=1 — isenfireldc / githubweb
  13. Switch to using nf90_inquire_variable to find information to allocate var — isenfireldc / githubweb
  14. Fix manual specification of values — isenfireldc / githubweb
  15. Fix issues with deallocation of variables — isenfireldc / githubweb
  16. Rewrite some of get_netcdf_var2d_real — isenfireldc / githubweb
  17. Add deallocate statement to get_netcdf_var2d_real after change — isenfireldc / githubweb
  18. Remove unused variable 'length' in get_netcdf_var*d_real — isenfireldc / githubweb
  19. Add statement to ensure dplevs initializes with zeroed values — isenfireldc / githubweb
  20. Revert "Add workaround for k=1" — isenfireldc / githubweb
  21. Update comments and variable names as requested — isenfireldc / githubweb
  22. Fix comments — isenfireldc / githubweb
  23. Set intent of var back to inout, as in the case of dplevs, it may not assign all values — isenfireldc / githubweb
  24. Remove some of the old variables from get_netcdf_var2d_real — isenfireldc / githubweb

#94 (Jul 30, 2021, 3:25:07 AM)

  1. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  2. Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
  3. Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation.  Related to #920. — 59519056+bstephens82 / githubweb
  4. Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine.  Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. — 59519056+bstephens82 / githubweb
  5. Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation.  Related to #920. — 59519056+bstephens82 / githubweb

#93 (Jul 28, 2021, 3:25:06 AM)

  1. Commiting to test host models — 72510114+RhodesKeegan / githubweb
  2. Passing stats variables through required subroutines. — 72510114+RhodesKeegan / githubweb
  3. Fixing compiliation errors — 72510114+RhodesKeegan / githubweb
  4. Fixing compiliation errors — 72510114+RhodesKeegan / githubweb
  5. Fixing compiliation errors — 72510114+RhodesKeegan / githubweb
  6. Fixing compilation errors — 72510114+RhodesKeegan / githubweb
  7. Fixing compiliation errors — 72510114+RhodesKeegan / githubweb
  8. Fixing compiliation errors — 72510114+RhodesKeegan / githubweb
  9. Fixing compilation errors — 72510114+RhodesKeegan / githubweb
  10. Fixing compilation errors — 72510114+RhodesKeegan / githubweb
  11. Fixing compilation status — 72510114+RhodesKeegan / githubweb
  12. Fixing compilation errors — 72510114+RhodesKeegan / githubweb
  13. Removing updated clubb and silhs directories — 72510114+RhodesKeegan / githubweb
  14. Fixing files that were incorrectly changed — 72510114+RhodesKeegan / githubweb
  15. Adding comments explaining subroutineoverloading — 72510114+RhodesKeegan / githubweb
  16. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
  17. Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb

#92 (Jul 27, 2021, 3:25:07 AM)

  1. Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978.  Related to #920. — 59519056+bstephens82 / githubweb
  2. Fixing comment for the wp2_term_pr_dfsn subroutine.  Related to #920. — 59519056+bstephens82 / githubweb
  3. Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. — 59519056+bstephens82 / githubweb
  4. Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues.  Related to #920. — 59519056+bstephens82 / githubweb
  5. Fixing some comments. — 59519056+bstephens82 / githubweb
  6. Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978.  Related to #920. — 59519056+bstephens82 / githubweb
  7. Correcting a typo bug and adding some descriptive comments to two new variables.  This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. — benjamin.andrew.stephens / githubweb

#91 (Jul 24, 2021, 3:25:08 AM)

  1. I changed the name to calc_responder_driver because I thought that — bmg2 / githubweb

#90 (Jul 23, 2021, 3:25:08 AM)

  1. Feeding stats variables through the argument lists of needed subroutines. — 72510114+RhodesKeegan / githubweb
  2. Fixing spacing issues along with placing the stats varibales on their own lines. — 72510114+RhodesKeegan / githubweb
  3. Changing more subroutines to include stats vars in their arg lists. — 72510114+RhodesKeegan / githubweb
  4. Fixing incorrect subroutine arg list — 72510114+RhodesKeegan / githubweb
  5. Fixing host models not compiling. — 72510114+RhodesKeegan / githubweb
  6. Fixing argument list so that way the coding standard is upheld. — 72510114+RhodesKeegan / githubweb

#89 (Jul 21, 2021, 3:25:09 AM)

  1. Saving logs for each run for troubleshooting. larson-group/sys_admin#735 — pbroels / githubweb
  2. Changing command order to ensure the log copy completes. larson-group/sys_admin#735 — pbroels / githubweb

#88 (Jul 20, 2021, 3:25:08 AM)

  1. Adding wp3_ta and wp3_tp terms to SAM output. See #141. — 59519056+bstephens82 / githubweb
  2. Some minor updates to the new W3TA and W3TP terms. — 59519056+bstephens82 / githubweb
  3. Editing names in RUNDATA/lst. — 59519056+bstephens82 / githubweb

#87 (Jul 9, 2021, 3:25:08 AM)

  1. Changing directory names and conditional variable names to match new test names. larson-group/sys_admin#735 — pbroels / githubweb

#86 (Jul 8, 2021, 3:25:07 AM)

  1. Improving error messages in setup_clubb_core. larson-group/e3sm#38 — Gunther Huebler / githubweb

#85 (Jul 3, 2021, 3:25:07 AM)

  1. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  2. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  3. Reflecting changes made to clubb_api_module's subroutine's argument lists. #886. — rhodesk / githubweb
  4. Defining gr at the top level main as a local variable and feeding it down as needed. — rhodesk / githubweb
  5. Adding grid_config file — rhodesk / githubweb
  6. Fixing certain instances of gr missing from clubb_sgs.F90. — rhodesk / githubweb
  7. Adding references to gr as needed — rhodesk / githubweb
  8. Adding references to gr where needed — rhodesk / githubweb
  9. Adding in preprocessor directives so that way sam compiles without clubb. — rhodesk / githubweb
  10. Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB. — rhodesk / githubweb
  11. Fixed make file being broke — rhodesk / githubweb
  12. The purpose of this commit is to check and see if the changes to sam's version of clubb is going to cause some sort of error when clubb's changes get merged into sam. Please ignore this commit unless something horrible happens tommorow morning in which case this commit is the reason why everything broke. — rhodesk / githubweb
  13. The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken. — rhodesk / githubweb
  14. Reverted changes to clubb files — rhodesk / githubweb
  15. Adding name specific functionality to prevent workspace removal and emails. larson-group/sys_admin#735 — pbroels / githubweb
  16. Fixing syntax error preventing jenkins tests from running. larson-group/sys_admin#727 — pbroels / githubweb
  17. Add error header for CLUBB in CAM — noreply / githubweb
  18. Adding some preprocessor directives — noreply / githubweb
  19. Fixing the ordering of gr in the arg list and dropping usage of grid_class. — rhodesk / githubweb
  20. Fixing the ordering of gr in the clubb_api arg list for affected subroutines. — rhodesk / githubweb
  21. Fixing coding standard violations — rhodesk / githubweb
  22. Changes that will make the WANGARA case run successfully in SAM-CLUBB and SAM-LES modes. — 59519056+bstephens82 / githubweb
  23. Adding comments to README and updating prm.les. — 59519056+bstephens82 / githubweb
  24. A few more updates to Wangara case: increasing top height to ~3200m, and removing a few lines from "lsf" file to be consistent with CLUBB (see commit https://github.com/larson-group/clubb/commit/381f3bdb88f44996263d03501401562e39717b25). — 59519056+bstephens82 / githubweb

#84 (Jul 2, 2021, 10:45:33 AM)

  1. Adding some preprocessor directives — noreply / githubweb
  2. Changes that will make the WANGARA case run successfully in SAM-CLUBB and SAM-LES modes. — 59519056+bstephens82 / githubweb
  3. Adding comments to README and updating prm.les. — 59519056+bstephens82 / githubweb
  4. A few more updates to Wangara case: increasing top height to ~3200m, and removing a few lines from "lsf" file to be consistent with CLUBB (see commit https://github.com/larson-group/clubb/commit/381f3bdb88f44996263d03501401562e39717b25). — 59519056+bstephens82 / githubweb

#82 (Jul 2, 2021, 3:25:12 AM)

  1. Changes that will make the WANGARA case run successfully in SAM-CLUBB and SAM-LES modes. — 59519056+bstephens82 / githubweb
  2. Adding comments to README and updating prm.les. — 59519056+bstephens82 / githubweb
  3. A few more updates to Wangara case: increasing top height to ~3200m, and removing a few lines from "lsf" file to be consistent with CLUBB (see commit https://github.com/larson-group/clubb/commit/381f3bdb88f44996263d03501401562e39717b25). — 59519056+bstephens82 / githubweb

#81 (Jul 1, 2021, 2:57:29 PM)

  1. Adding comments to README and updating prm.les. — benjamin.andrew.stephens / githubweb
  2. A few more updates to Wangara case: increasing top height to ~3200m, and removing a few lines from "lsf" file to be consistent with CLUBB (see commit https://github.com/larson-group/clubb/commit/381f3bdb88f44996263d03501401562e39717b25). — benjamin.andrew.stephens / githubweb

#80 (Jul 1, 2021, 11:36:08 AM)

  1. Adding some preprocessor directives — noreply / githubweb

#79 (Jul 1, 2021, 3:25:12 AM)

  1. Add error header for CLUBB in CAM — noreply / githubweb

#77 (Jun 30, 2021, 11:49:39 AM)

  1. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  2. Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
  3. Reflecting changes made to clubb_api_module's subroutine's argument lists. #886. — rhodesk / githubweb
  4. Defining gr at the top level main as a local variable and feeding it down as needed. — rhodesk / githubweb
  5. Adding grid_config file — rhodesk / githubweb
  6. Fixing certain instances of gr missing from clubb_sgs.F90. — rhodesk / githubweb
  7. Adding references to gr as needed — rhodesk / githubweb
  8. Adding references to gr where needed — rhodesk / githubweb
  9. Adding in preprocessor directives so that way sam compiles without clubb. — rhodesk / githubweb
  10. Fixed make file being broke — rhodesk / githubweb
  11. Reverted changes to clubb files — rhodesk / githubweb
  12. Adding name specific functionality to prevent workspace removal and emails. larson-group/sys_admin#735 — pbroels / githubweb
  13. Fixing syntax error preventing jenkins tests from running. larson-group/sys_admin#727 — pbroels / githubweb

#75 (Jun 29, 2021, 10:24:28 AM)

  1. Reverted changes to clubb files — rhodesk / githubweb

#73 (Jun 28, 2021, 2:13:43 PM)

  1. Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB. — rhodesk / githubweb
  2. The purpose of this commit is to check and see if the changes to sam's version of clubb is going to cause some sort of error when clubb's changes get merged into sam. Please ignore this commit unless something horrible happens tommorow morning in which case this commit is the reason why everything broke. — rhodesk / githubweb
  3. The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken. — rhodesk / githubweb

#68 (Jun 24, 2021, 11:56:03 AM)

  1. Adding in preprocessor directives so that way sam compiles without clubb. — rhodesk / githubweb

#67 (Jun 23, 2021, 12:14:52 PM)

  1. Adding references to gr as needed — rhodesk / githubweb
  2. Adding references to gr where needed — rhodesk / githubweb

#66 (Jun 23, 2021, 11:52:51 AM)

  1. Fixing certain instances of gr missing from clubb_sgs.F90. — rhodesk / githubweb

#65 (Jun 23, 2021, 10:39:59 AM)

  1. Adding grid_config file — rhodesk / githubweb

#64 (Jun 23, 2021, 10:31:39 AM)

  1. Defining gr at the top level main as a local variable and feeding it down as needed. — rhodesk / githubweb

#62 (Jun 18, 2021, 3:25:10 AM)

  1. Reverting overwritten changes. larson-group/sys_admin#723 — noreply / githubweb

#61 (Jun 17, 2021, 3:25:06 AM)

  1. Fixing typo in stats_zm_module.F90.  Background:  Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases.  It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit.  This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced.  However, since the budget balance test still found the variable, it kept passing successfully.  This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format. — benjamin.andrew.stephens / githubweb
  2. Fixing a typo from an earlier commit. — noreply / githubweb

#60 (Jun 16, 2021, 3:25:10 AM)

  1. Removing gr as a module variable from grid_class. — rhodesk / githubweb
  2. Removing gr as a module variable from grid_class. — rhodesk / githubweb
  3. Adding section to LES automation script that will copy the appropriate "grd" file into place for the DYCOMS_RF01 case. — benjamin.andrew.stephens / githubweb

#59 (Jun 11, 2021, 3:25:07 AM)

  1. Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
  2. Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
  3. Reverted changes to clubb_api. For #886 — rhodesk / githubweb
  4. Replacing use gr statements with feeding gr throught the arg list. — rhodesk / githubweb
  5. Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
  6. Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb

#58 (Jun 9, 2021, 3:25:08 AM)

  1. Adding proper indentation to needed files. — rhodesk / githubweb
  2. Fixing spacing issue on blank lines. #886 — rhodesk / githubweb
  3. Fixed comment changes. #886 — rhodesk / githubweb
  4. Fixed incorrect spacing on use — rhodesk / githubweb
  5. Revert "Fixed incorrect spacing on use" — rhodesk / githubweb
  6. Fixed spacing — rhodesk / githubweb
  7. Fixed spacing going too far — rhodesk / githubweb
  8. Fixed comments being pushed over — rhodesk / githubweb
  9. Fixed not all variables being indented properly — rhodesk / githubweb
  10. Fixed indentation going beyond variables — rhodesk / githubweb
  11. Fixed file_functions indentation being off — rhodesk / githubweb
  12. Fixed indentation on operations being wrong — rhodesk / githubweb
  13. Reverted incorrect changes to new_pdf and new_hybrid_pdf — rhodesk / githubweb

#56 (Jun 7, 2021, 3:10:23 PM)

  1. Replacing hardcoded references to environment variables with variable from larson-group.sh. larson-group/sys_admin#742 — pbroels / githubweb
  2. Reverting unintended changes. — noreply / githubweb

#54 (Jun 5, 2021, 3:25:10 AM)

  1. Adding capability for SAM to read configurable_model_flags.in at runtime (both the CLUBB and SILHS flags). — 59519056+bstephens82 / githubweb
  2. Removing l_lh_importance_sampling flag from the DYCOMS_RF02 "prm" file and setting things up so that flag is always read from configurable_model_flags.in.  The flag has the same setting either way so this is just cleaner. — 59519056+bstephens82 / githubweb

#53 (Jun 3, 2021, 3:25:08 AM)

  1. Changed some elements of clubb to allow for better script execution — rhodesk / githubweb
  2. Fixed clubb not compiling — rhodesk / githubweb
  3. Remove -lacml from Makefile — isenfireldc / githubweb

#52 (May 29, 2021, 3:25:11 AM)

  1. Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928. — Gunther Huebler / githubweb

#51 (May 26, 2021, 3:25:07 AM)

  1. Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface. — 59519056+bstephens82 / githubweb
  2. Deleting comments around the old "magic number" for the near-surface clipping. — 59519056+bstephens82 / githubweb

#50 (May 23, 2021, 3:25:09 AM)

  1. Added intent comments. — rhodesk / githubweb
  2. Added intent comments. — rhodesk / githubweb
  3. Added intent comments for advance_xp2_xpyp_module.F90. — rhodesk / githubweb

#49 (May 14, 2021, 3:25:08 AM)

  1. Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90. — benjamin.andrew.stephens / githubweb
  2. Fixed comment regarding wp3 splatting term. — benjamin.andrew.stephens / githubweb

#48 (May 13, 2021, 3:25:06 AM)

  1. Setting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway. — benjamin.andrew.stephens / githubweb
  2. Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core.  Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs).  This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated. — benjamin.andrew.stephens / githubweb

#47 (May 12, 2021, 3:25:08 AM)

  1. Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. — 59519056+bstephens82 / githubweb
  2. Adding new coefficient to control the wp3 pressure diffusion term. — 59519056+bstephens82 / githubweb
  3. Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. — 59519056+bstephens82 / githubweb
  4. Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. — 59519056+bstephens82 / githubweb
  5. Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). — 59519056+bstephens82 / githubweb
  6. These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. — 59519056+bstephens82 / githubweb
  7. Adding new coefficient to control the wp3 pressure diffusion term. — 59519056+bstephens82 / githubweb
  8. Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form.  This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. — 59519056+bstephens82 / githubweb
  9. These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. — 59519056+bstephens82 / githubweb
  10. Added intent comments for the following files: — rhodesk / githubweb

#46 (May 5, 2021, 3:25:11 AM)

  1. Changed safeguard threshold in sigma_sqd_w. — rhodesk / githubweb

#45 (May 4, 2021, 3:25:07 AM)

  1. clubb warnings introduced from merge have been removed #909 — rhodesk / githubweb

#44 (May 1, 2021, 3:25:09 AM)

  1. Pushing loops related to pdf_params down. larson-group/cam#129 — Gunther Huebler / githubweb

#43 (Apr 30, 2021, 3:25:10 AM)

  1. Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
  2. Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
  3. Making compatible with clubb changes to pdf_params. larson-group/cam#129 — Gunther Huebler / githubweb
  4. Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
  5. Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb

#42 (Apr 28, 2021, 3:25:09 AM)

  1. Changed ustar from an array to a scalar issue #909 — rhodesk / githubweb
  2. Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909 — rhodesk / githubweb
  3. Created new subroutine and ensured it's BFB. All cases run sucessfully #909 — rhodesk / githubweb
  4. added in missing flag which was causing memory errors #909 — rhodesk / githubweb
  5. confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909 — rhodesk / githubweb
  6. Reformatted mixing length to be more compliant with the coding standard #909 — rhodesk / githubweb
  7. added a reference to new subroutine #909 — rhodesk / githubweb

#41 (Apr 27, 2021, 3:25:11 AM)

  1. Re-adding ifdef. This was added before in commit f054d47d365a889c2eeb3a9a35f79196f0697fb9, but was accidentally removed. larson-group/cam#129 — Gunther Huebler / githubweb

#40 (Apr 24, 2021, 3:25:10 AM)

  1. Adding ifdef around precip_fracs usage. This is needed to compile without -DSILHS, and is why the sam_clubb_pgi_build failed today. larson-group/cam#129 — Gunther Huebler / githubweb
  2. Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  3. Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129 — Gunther Huebler / githubweb
  4. Removing optional argument hydromet_pdf_params from call to setup_pdf_parameters_api. larson-group/cam#129 — Gunther Huebler / githubweb

#39 (Apr 23, 2021, 3:25:11 AM)

  1. Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  2. Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  3. Making compatible with newest clubb changes. larson-group/cam#129 — Gunther Huebler / githubweb

#38 (Apr 22, 2021, 3:25:07 AM)

  1. Update stats_zm_module.F90 — noreply / githubweb
  2. Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129 — Gunther Huebler / githubweb

#37 (Apr 16, 2021, 3:25:06 AM)

  1. This commit adds several new statistics output variables, including <w'^2p'>, and a new subroutine to compute bivariate 4th-order moments.  The new variables are added to the default RUNDATA/lst file. — benjamin.andrew.stephens / githubweb

#36 (Apr 13, 2021, 3:25:08 AM)

  1. Updating output variables with DIFF to DFSN to clarify that they are diffusion variables. — 59519056+bstephens82 / githubweb

#35 (Apr 10, 2021, 3:25:07 AM)

  1. Performance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  2. Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  3. Reducing operations. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  4. Adding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  5. Some small cleanup, all just formatting. larson-group/cam#129 — Gunther Huebler / githubweb

#34 (Apr 9, 2021, 3:25:06 AM)

  1. Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129 — Gunther Huebler / githubweb
  2. Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  3. Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  4. Making compatible with latest clubb changes. larson-group/cam#129 — Gunther Huebler / githubweb

#32 (Apr 8, 2021, 3:25:10 AM)

  1. Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled. — Gunther Huebler / githubweb

#31 (Apr 7, 2021, 3:25:06 AM)

  1. Adding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129 — Gunther Huebler / githubweb
  2. More loop pushing, all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  3. Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions. — Gunther Huebler / githubweb

#30 (Apr 2, 2021, 3:25:10 AM)

  1. Some changes to the code that will help run the CGILS_S12 case.  There are two special new files included for that case only, nudging.cgils and surface.cgils, which can be copied into place when needed, but the code should give the same results for all the normal cases. — 59519056+bstephens82 / githubweb
  2. Adding CGILS_S12 folder with setup files for that case, courtesy of Peter Blossey.  These files probably need some modification before use, since some parameters are not present in our model. — 59519056+bstephens82 / githubweb
  3. Further updates to help run the CGILS_S12 LES test case. — 59519056+bstephens82 / githubweb
  4. Minor adjustments to prm files for cgils_s12 case, also including a working copy of the prm file that reproduces our local results. — 59519056+bstephens82 / githubweb
  5. Editing the LES_setup script so that it automates everything to run the standard CGILS_S12 LES case.  Adding domain.f90.les and renaming the prm.ndgfix_new to prm.les so that the script will use these in the normal way. — 59519056+bstephens82 / githubweb
  6. Correcting some code in the LES setup script and fixing some comments in the cgils surface and nudging files. — 59519056+bstephens82 / githubweb
  7. Update README — 59519056+bstephens82 / githubweb
  8. Adding Peter Blossey's version of kurant.f90 (called kurant.cgils) in case it would ever be useful.  Updating README also to explain that file. — 59519056+bstephens82 / githubweb
  9. Adding some comments to clarify these changes. — 59519056+bstephens82 / githubweb
  10. More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb

#29 (Apr 1, 2021, 3:25:10 AM)

  1. More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb

#28 (Mar 31, 2021, 3:25:10 AM)

  1. More pushing loops down. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb

#27 (Mar 27, 2021, 3:25:11 AM)

  1. Pushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb

#26 (Mar 25, 2021, 3:25:10 AM)

  1. Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129 — Gunther Huebler / githubweb
  2. Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
  3. Fixed typo bug. larson-group/cam#129 — Gunther Huebler / githubweb

#25 (Mar 23, 2021, 3:25:09 AM)

  1. Changed surface to sfc in all instances where requested — rhodesk / githubweb
  2. Undid sfc change in stats_sfc_module.F90 — noreply / githubweb
  3. Undid sfc change to grid_class.F90 — noreply / githubweb
  4. Undid sfc change in numerical_check.F90 — noreply / githubweb

#23 (Mar 18, 2021, 3:25:09 AM)

  1. This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2.  In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1.  This makes the terms in these equations more consistent with the terms in the wp2 equation.  I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped). — Vince Larson / githubweb

#22 (Mar 10, 2021, 3:25:07 AM)

  1. I added an option to improve dry, convecting boundary layers. — Vince Larson / githubweb

#21 (Mar 7, 2021, 3:25:07 AM)

  1. Changed the variable up2_vp2_factor to up2_sfc_coef in all files — rhodesk / githubweb
  2. Changed the variable up2_vp2_factor to up2_sfc_coef in all files — rhodesk / githubweb

#20 (Mar 4, 2021, 3:25:06 AM)

  1. Adding a batch submission script for use with UCAR's Cheyenne computer. — benjamin.andrew.stephens / githubweb
  2. Adding some functionality relevant for UCAR's Cheyenne, including adding lines to LES_setup script that will active the Cheyenne section of the Makefile and copy over the batch submission script. — benjamin.andrew.stephens / githubweb

#19 (Mar 2, 2021, 3:25:06 AM)

  1. Turning on wp3 pr_turb term. — benjamin.andrew.stephens / githubweb
  2. Turning on wp3 pr_turb term. — benjamin.andrew.stephens / githubweb

#18 (Feb 28, 2021, 3:25:10 AM)

  1. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/issues/902. — benjamin.andrew.stephens / githubweb

#17 (Feb 27, 2021, 3:25:09 AM)

  1. Adding a section to the Makefile for running SAM-LES on Cheyenne.  See #131. — benjamin.andrew.stephens / githubweb
  2. Adding code to calculate W3 pressure decomposition terms W3PRESDIF (diffusion) and W3PRESSRC (scambling), see #131. — benjamin.andrew.stephens / githubweb
  3. Update lst — noreply / githubweb
  4. Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch.  See #902. — 59519056+bstephens82 / githubweb
  5. Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch.  See #902. — 59519056+bstephens82 / githubweb

#16 (Feb 21, 2021, 3:25:08 AM)

  1. Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
  2. Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb

#15 (Feb 17, 2021, 3:25:08 AM)

  1. Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129 — Gunther Huebler / githubweb

#14 (Feb 11, 2021, 3:25:07 AM)

  1. Adding email on fail functionaity to all tests. — pbroels / githubweb

#13 (Feb 5, 2021, 3:25:09 AM)

  1. Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129 — Gunther Huebler / githubweb
  2. Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129 — Gunther Huebler / githubweb
  3. Making compatible with clubb changes. larson-group/cam#129 — Gunther Huebler / githubweb

#12 (Jan 29, 2021, 3:06:11 AM)

  1. Update parameters_tunable.F90 — noreply / githubweb

#11 (Jan 28, 2021, 3:06:11 AM)

  1. Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. — benjamin.andrew.stephens / githubweb
  2. Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. — benjamin.andrew.stephens / githubweb

#10 (Jan 27, 2021, 3:06:09 AM)

  1. Setting momlepress3 equal to W3PRES and commenting out "W3REDIS" variable.  The W3 pressure budget terms were split improperly.  See #129. — benjamin.andrew.stephens / githubweb
  2. Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code.  The flag is set to false by default so results are unaffected.  See #902. — benjamin.andrew.stephens / githubweb
  3. Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code.  The flag is set to false by default so results are unaffected.  See #902. — benjamin.andrew.stephens / githubweb
  4. Update configurable_model_flags.in — noreply / githubweb
  5. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/issues/902. — benjamin.andrew.stephens / githubweb

#9 (Jan 26, 2021, 3:06:07 AM)

  1. Revert "I'm adding the api entry for read_silhs_parameters, called" — bmg2 / githubweb
  2. Revert "Fixed a preprocessor command." — bmg2 / githubweb
  3. Revert "This will allow for a better interface of SILHS parameter" — bmg2 / githubweb
  4. I updated silhs_api_module so that vert_decorr_coef is publically available — bmg2 / githubweb

#8 (Jan 22, 2021, 3:06:10 AM)

  1. This will allow for a better interface of SILHS parameter — bmg2 / githubweb
  2. Fixed a preprocessor command. — bmg2 / githubweb
  3. This will allow SAM-CLUBB to use the same value of vert_decorr_coef — bmg2 / githubweb
  4. I'm adding the api entry for read_silhs_parameters, called — bmg2 / githubweb

#7 (Jan 21, 2021, 3:06:09 AM)

  1. This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb".  The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. — benjamin.andrew.stephens / githubweb
  2. This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb".  The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. — benjamin.andrew.stephens / githubweb
  3. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/issues/901, also see commit https://github.com/larson-group/clubb/commit/73878700ca11afca77705ae383914fe04be0f72c. — benjamin.andrew.stephens / githubweb