Skip to content
Success

Changes

Summary

  1. Making multicolumn version of advance_clubb_core in clubb_driver that accepts a number of columns to run clubb with. All bit-for-bit output on standalone cases, so the first column is correct. (details)
  2. Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical. (details)
  3. Now the multicolumn netcdf output is correct. Adding comments too. larson-group/clubb#1033 (details)
  4. Made the multicolumn inout arrays save from timestep to timestep. This makes the extra columns more independent from the main column and allows differences in the extra columns to propagate more. larson-group/clubb#1033 (details)
  5. Adding some fields to tweak for extra columns. This might be sufficient, the netcdf data for the column is similar but visually different, and I tested with up to 64 columns and there wasn't any crashes. larson-group/clubb#1033 (details)
  6. Adding script to compare netcdf outputs. This will print the max absolute diff and max percent diff for each field. This is made specifically for the multicolumn netcdf output. The script is not done, but this is the basics of it. larson-group/clubb#1033 (details)
  7. Casting 0.0 to correct precision that format_date wants. (details)
  8. Updating script to compare netcdf output. larson-group/clubb#1033 (details)
  9. Updating column num input in config flags. larson-group/clubb#1033 (details)
  10. Adding small check to allow configurable_multi_column_nl to be optional. If configurable_multi_column_nl is omitted from configurable_model_flags, then we assume we only want 1 column and a warning is printed. larson-group/clubb#1033 (details)
  11. Small script update (details)
  12. Adding comments to script. (details)
  13. Adding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033 (details)
Commit b00b88f36d25ff0fc15c2e6c66e09b29f7e5fc07 by 37674341+huebleruwm
Making multicolumn version of advance_clubb_core in clubb_driver that accepts a number of columns to run clubb with. All bit-for-bit output on standalone cases, so the first column is correct.
The file was modified src/clubb_driver.F90 (diff)
Commit 52d5b77ea73abf368f0c947b448db59d05a7bf5b by 37674341+huebleruwm
Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/output_netcdf.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
Commit 8a6e980adc4fd5672287e789ee8f6248c8a58594 by 37674341+huebleruwm
Now the multicolumn netcdf output is correct. Adding comments too. larson-group/clubb#1033
The file was modified src/clubb_driver.F90 (diff)
Commit 83b151bdb131134d178f58521f468b9bb78b1e7e by 37674341+huebleruwm
Made the multicolumn inout arrays save from timestep to timestep. This makes the extra columns more independent from the main column and allows differences in the extra columns to propagate more. larson-group/clubb#1033
The file was modified src/clubb_driver.F90 (diff)
Commit 421981e323d84914a1fc2199030dc2d89b406d5c by 37674341+huebleruwm
Adding some fields to tweak for extra columns. This might be sufficient, the netcdf data for the column is similar but visually different, and I tested with up to 64 columns and there wasn't any crashes. larson-group/clubb#1033
The file was modified src/clubb_driver.F90 (diff)
Commit fd99b2bd5ba78d01880afc1887accd713fb39a30 by 37674341+huebleruwm
Adding script to compare netcdf outputs. This will print the max absolute diff and max percent diff for each field. This is made specifically for the multicolumn netcdf output. The script is not done, but this is the basics of it. larson-group/clubb#1033
The file was addedrun_scripts/check_multicol_error.py
Commit 970c22416c2751064f1e25d4a16024e3f126de2e by 37674341+huebleruwm
Casting 0.0 to correct precision that format_date wants.
The file was modified src/clubb_driver.F90 (diff)
Commit c25baf3b9171190aab0cba7f7c0564677871cd63 by 37674341+huebleruwm
Updating script to compare netcdf output. larson-group/clubb#1033
The file was modified run_scripts/check_multicol_error.py (diff)
Commit af14d54b5dbe942882bfa6b67513b8f3781c5afc by 37674341+huebleruwm
Updating column num input in config flags. larson-group/clubb#1033
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
Commit f2cfc4fcd4059a5f5eb2f50efb478f49f22f2476 by 37674341+huebleruwm
Adding small check to allow configurable_multi_column_nl to be optional. If configurable_multi_column_nl is omitted from configurable_model_flags, then we assume we only want 1 column and a warning is printed. larson-group/clubb#1033
The file was modified src/clubb_driver.F90 (diff)
The file was modified run_scripts/check_multicol_error.py (diff)
The file was modified run_scripts/check_multicol_error.py (diff)
Commit 72afa580969c647295ee087c7bf605c9bb6c01fe by 37674341+huebleruwm
Adding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033
The file was modified src/clubb_driver.F90 (diff)
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)