Skip to content
Success

Changes

Summary

  1. Feeding stats variables through the argument lists of needed subroutines. (details)
  2. Fixing spacing issues along with placing the stats varibales on their own lines. (details)
  3. Changing more subroutines to include stats vars in their arg lists. (details)
  4. Fixing incorrect subroutine arg list (details)
  5. Fixing host models not compiling. (details)
  6. Fixing argument list so that way the coding standard is upheld. (details)
Commit 5776f237f9093da79b6d73e31426eed6d546f826 by 72510114+RhodesKeegan
Feeding stats variables through the argument lists of needed subroutines.
The purpose of this commit is to prep clubb for having all stats variables be
fed through the argument list in the entirety of clubb and host models where needed.
This is for ticket #733.
Results have been confirmed to be BFB identical.
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xp3_module.F90 (diff)
The file was modified src/CLUBB_core/clip_explicit.F90 (diff)
The file was modified src/CLUBB_core/mono_flux_limiter.F90 (diff)
The file was modified src/microphys_driver.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/precipitation_fraction.F90 (diff)
The file was modified src/CLUBB_core/setup_clubb_pdf_params.F90 (diff)
The file was modified src/CLUBB_core/advance_helper_module.F90 (diff)
The file was modified src/CLUBB_core/stats_zt_module.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/advance_windm_edsclrm_module.F90 (diff)
The file was modified src/CLUBB_core/stats_rad_zm_module.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/stats_zm_module.F90 (diff)
The file was modified src/CLUBB_core/stats_sfc_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/stats_rad_zt_module.F90 (diff)
The file was modified src/CLUBB_core/fill_holes.F90 (diff)
The file was modified src/advance_microphys_module.F90 (diff)
Commit 5659a5e7a1c5b296e3b75462a4ea7b713cc3b81a by 72510114+RhodesKeegan
Fixing spacing issues along with placing the stats varibales on their own lines.
Additionally, this commit relabels arg list intent along with the intent of stats vars.
Stats variables are still not in the correct spot in the arg list as per the standard,
however, they are on their own line where they are correctly labeled.
For ticket #733.
Results are confirmed BFB identical.
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/clip_explicit.F90 (diff)
The file was modified src/CLUBB_core/stats_zt_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/advance_windm_edsclrm_module.F90 (diff)
The file was modified src/CLUBB_core/stats_sfc_module.F90 (diff)
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
The file was modified src/CLUBB_core/advance_xp3_module.F90 (diff)
The file was modified src/CLUBB_core/stats_rad_zm_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/precipitation_fraction.F90 (diff)
The file was modified src/CLUBB_core/fill_holes.F90 (diff)
The file was modified src/CLUBB_core/stats_rad_zt_module.F90 (diff)
The file was modified src/CLUBB_core/stats_zm_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/setup_clubb_pdf_params.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/advance_helper_module.F90 (diff)
The file was modified src/CLUBB_core/mono_flux_limiter.F90 (diff)
Commit 2450be63f0d03cfe2f866d4551f3bd1f675fa66c by 72510114+RhodesKeegan
Changing more subroutines to include stats vars in their arg lists.
There were a few subroutines that were not detected on the first script
for subroutines that would need to be changed. This commit picks up on
those subroutines and correctly makes the change.
Additionally, this commit also makes the stats vars show up in the same
spot consistantly throughout all affected subroutines.
For ticket #733.
Results are confirmed BFB identical.
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/mono_flux_limiter.F90 (diff)
The file was modified src/advance_microphys_module.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/setup_clubb_pdf_params.F90 (diff)
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/stats_lh_sfc_module.F90 (diff)
The file was modified src/CLUBB_core/stats_lh_zt_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/microphys_driver.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/mixing_length.F90 (diff)
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
The file was modified src/CLUBB_core/advance_windm_edsclrm_module.F90 (diff)
Commit cfbd34dcc44080c9ae674e3a050c665935e30575 by 72510114+RhodesKeegan
Fixing incorrect subroutine arg list
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
Commit 914e5a0c8bf3456b3b45a4c430c5d62a1632a84c by 72510114+RhodesKeegan
Fixing host models not compiling.
Host models now compile.
For ticket #733
Results remain BFB identical.
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
Commit 23323e4020d5fdd98345e43f7b86b2e384ca74a4 by 72510114+RhodesKeegan
Fixing argument list so that way the coding standard is upheld.
For ticket #733.
Results remain BFB identical.
The file was modified src/CLUBB_core/setup_clubb_pdf_params.F90 (diff)
The file was modified src/CLUBB_core/advance_windm_edsclrm_module.F90 (diff)
The file was modified src/CLUBB_core/fill_holes.F90 (diff)
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/stats_rad_zt_module.F90 (diff)
The file was modified src/CLUBB_core/stats_sfc_module.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/microphys_driver.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/advance_helper_module.F90 (diff)
The file was modified src/CLUBB_core/stats_lh_zt_module.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xp3_module.F90 (diff)
The file was modified src/CLUBB_core/clip_explicit.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/mixing_length.F90 (diff)
The file was modified src/CLUBB_core/stats_zm_module.F90 (diff)
The file was modified src/CLUBB_core/precipitation_fraction.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
The file was modified src/CLUBB_core/mono_flux_limiter.F90 (diff)
The file was modified src/CLUBB_core/stats_rad_zm_module.F90 (diff)
The file was modified src/CLUBB_core/stats_lh_sfc_module.F90 (diff)
The file was modified src/advance_microphys_module.F90 (diff)
The file was modified src/CLUBB_core/stats_zt_module.F90 (diff)