Skip to content
Failed

Changes

Summary

  1. A different way of dealing with monotonic flux limiter spikes (#1046) (details)
  2. Steffens tuner fixer branch (#1041) (details)
  3. Adding capability to change matrix solving method via clubb_config_flags. (details)
  4. Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones. (details)
  5. Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024. (details)
  6. Delete clubb.in (details)
  7. Delete error_diffs.txt (details)
  8. Adding capability to change matrix solving method via clubb_config_flags. (details)
  9. Removing unwanted files. (details)
  10. Replacing $ with & in namelist definition to make consistent. (details)
  11. Creates separate file for inputting data to the tuner (details)
  12. I added "smooth" max clipping for invrs_tau_shear, which is a variable (details)
Commit 81e8853ff0aaa5927cdd1d420489680fd28e4eb3 by noreply
A different way of dealing with monotonic flux limiter spikes (#1046)

* A different way of dealing with monotonic flux limiter spikes in CAM, by increasing the value
of thl_tol_mfl.  ALso reverts the earlier fix.  BIT_CHANGING.

See https://github.com/NCAR/amwg_dev/discussions/134#discussioncomment-4165447.

* Reducing value of thl_tol_mfl from 0.5 to 0.2.

This will be BIT_CHANGING.
The file was modified src/CLUBB_core/constants_clubb.F90 (diff)
The file was modified src/CLUBB_core/mono_flux_limiter.F90 (diff)
Commit 7c694ec0241527c624be7ada4de8f0a7b3f6b610 by noreply
Steffens tuner fixer branch (#1041)

* Clubb ticket #1025: Implemented changes dealing with pdf_params%thl1/2 and wp2 floating point errors occurring in tuning runs. BIT_CHANGING
- Added command-line option -t/--tuner to compile.bash which enables the -DTUNER compiler flag.
- Added line to gfortran compilation config file to easily disable openMP
- Added a couple error messages and cleaned up some instances of error handling in src/error.F90, src/clubb_driver.F90, and src/CLUBB_core/advance_clubb_core_module.F90
- Added global constant wp2_max in src/CLUBB_core/constants_clubb.F90 which sets the upper bound for wp2
- In pdf_closure, added sanity checks for pdf_params%thl1/2 (>=190K, <=1000K)
- Added debug warning in src/CLUBB_core/advance_wp2_wp3_module.F90 when wp2 is clipped.
- Added wp2_sfc clipping in src/CLUBB_core/sfc_varnce_module.F90
- Added debug_level_check to NaN check in clubb_driver.F90
- Added mention of the new compiler option to the README
The file was modified input_misc/tuner/error_four_cases.in (diff)
The file was modified src/CLUBB_core/constants_clubb.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/numerical_check.F90 (diff)
The file was modified src/error.F90 (diff)
The file was modified compile/compile.bash (diff)
The file was modified src/CLUBB_core/sfc_varnce_module.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified compile/config/linux_x86_64_gfortran.bash (diff)
The file was modified src/CLUBB_core/pdf_closure_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/clubb_tuner.F90 (diff)
The file was modified src/CLUBB_core/grid_class.F90 (diff)
The file was modified README (diff)
Commit 1a43597bdd06c12411ea8698c4f1f200efec7478 by 37674341+huebleruwm
Adding capability to change matrix solving method via clubb_config_flags.
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/CLUBB_core/matrix_solver_wrapper.F90 (diff)
The file was modified src/clubb_tuner.F90 (diff)
The file was addedrun_scripts/clubb.in
The file was modified src/CLUBB_core/model_flags.F90 (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was addedrun_scripts/diff.nc
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was addedrun_scripts/error_diffs.txt
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/advance_microphys_module.F90 (diff)
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/advance_windm_edsclrm_module.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/mono_flux_limiter.F90 (diff)
Commit a8f324c4ae9dc0526fb9a1e622e32c8c20a4e0de by 37674341+huebleruwm
Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones.
The file was modified src/CLUBB_core/matrix_solver_wrapper.F90 (diff)
Commit 3ebfa3db3b485a4f58bd654b25f8608c1aa7d7bd by 37674341+huebleruwm
Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024.
The file was modified src/CLUBB_core/penta_lu_solver.F90 (diff)
The file was removedrun_scripts/clubb.in
The file was removedrun_scripts/error_diffs.txt
Commit 33dd904e2f71c1cf801dbcdd71e8b796cc1c55f1 by 37674341+huebleruwm
Adding capability to change matrix solving method via clubb_config_flags.
The file was addedrun_scripts/clubb.in
The file was addedrun_scripts/error_diffs.txt
The file was removedrun_scripts/error_diffs.txt
The file was removedrun_scripts/clubb.in
The file was removedrun_scripts/diff.nc
Commit 61b4a67e170bc2243263ac19fb90b24f5a1e455b by Gunther Huebler
Replacing $ with & in namelist definition to make consistent.
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
Commit 216528613a53b626f93c97867ec2b69bb7ba9da1 by Vince Larson
Creates separate file for inputting data to the tuner
The file was modified utilities/sens_matrix/sens_matrix_dashboard.py (diff)
The file was addedutilities/sens_matrix/set_up_dashboard_inputs.py
Commit c50ab36d29f7c3cdbadbfa6cfa5cf935451e26a2 by bmg2
I added "smooth" max clipping for invrs_tau_shear, which is a variable
that is supposed to be positive definite, yet was obtaining negative
values at the model lower boundary owing to linear extension at the
boundaries as part of the linear interpolation call.

This change is BIT_CHANGING.
The file was modified src/CLUBB_core/mixing_length.F90 (diff)