Skip to content

Changes

#21 (Jun 27, 2023, 3:31:38 PM)

  1. Adding in a git clone step to the Cam Clubb Copy test. — pbroels / githubweb
  2. Trying out git command rather than checkout for cloning. — pbroels / githubweb
  3. Adding correct scm command and removed redundant run commond from end. — pbroels / githubweb
  4. Adding space because commit 26b7e8f8d7007f78d655b8fc15045015ce8d4790 fixed the jenkins test that were failing, but did not include the proper resolving messages. RESOLVED:7046396a59f73087323f04b267cd8614ff1653f2 RESOLVED:30559bb00c20ce8a8c21242272f6d16cecb12b45 RESOLVED:970b880d9144efe00ce9d6fa34bcd49a493ac65b RESOLVED:633e158c8e6d5818b39963e6836ef71c1489faf9 RESOLVED:4ae233813e39a8bc7e3b58e600c0f71103fff8b3 — Gunther Huebler / githubweb
  5. Gunthers branch (#996) — noreply / githubweb
  6. Various simple changes to improve performance. All bit-for-bit. — Gunther Huebler / githubweb
  7. Pushing loop into calc_stability_correction. — Gunther Huebler / githubweb
  8. Adding in comments to explaining the technical tricks and methods in each jenkins file so it is clear what they do and why they are there. — pbroels / githubweb
  9. Small bug fix. — Gunther Huebler / githubweb
  10. Another similar small bug fix. — Gunther Huebler / githubweb
  11. Gunthers branch (#999) — noreply / githubweb
  12. Renamed smth_range to heaviside_smth_range — 68997723+JanGrn / githubweb
  13. Added tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes. — 68997723+JanGrn / githubweb
  14. Implemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0. — 68997723+JanGrn / githubweb
  15. Changed priorities of total normalized variation stats, included error handling in total normalized variation stats. — 68997723+JanGrn / githubweb
  16. Renamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls. — 68997723+JanGrn / githubweb
  17. Gunthers branch 2 (#1002) — noreply / githubweb
  18. Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail. — 68997723+JanGrn / githubweb
  19. Added ability to apply smooth min max functions in mixing_length.F90 — 68997723+JanGrn / githubweb
  20. Updated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
  21. Checked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
  22. Added test cases to smooth_min_max_tests.F90 and updated documentation. — 68997723+JanGrn / githubweb
  23. Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
  24. Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
  25. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4. — benjamin.andrew.stephens / githubweb
  26. Almost final loop pushes (#1012) — noreply / githubweb
  27. Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) — noreply / githubweb
  28. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  29. This commit is not bit changing — noreply / githubweb
  30. The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. — Gunther Huebler / githubweb
  31. Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version. — Gunther Huebler / githubweb
  32. Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). — Gunther Huebler / githubweb
  33. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  34. Making 2D versions of setup_grid and setup_parameters. — Gunther Huebler / githubweb
  35. Now using 2D versions of setup_grid and setup_parameters — Gunther Huebler / githubweb
  36. Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value. — Gunther Huebler / githubweb
  37. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  38. Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types. — Gunther Huebler / githubweb
  39. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  40. Making silhs use the new 2D version of setup_grid. This also inadvertently fixes a bug added in commit c816bcbd4bb8b8cfa89aa9c0f976ee799cb795e2. The issue was that we used pver when we wanted pverp. — Gunther Huebler / githubweb
  41. Lots of small loop pushes — 37674341+huebleruwm / githubweb
  42. Small bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run. — 37674341+huebleruwm / githubweb
  43. Small refactoring to mfl_xm_lhs, just removing need to pass in gr. — 37674341+huebleruwm / githubweb
  44. Final loop pushes needed before the grid change. — 37674341+huebleruwm / githubweb
  45. Replacing use of gr with nz — 37674341+huebleruwm / githubweb
  46. Replacing use of gr with nz — 37674341+huebleruwm / githubweb
  47. Changing NETCDF path in jenkins test command. — pbroels / githubweb
  48. Modifying shell commands to be the more recognized version. |& should be understood by bash version >= 3.2.25 but that does not seem to be the case, so we're reverting it to the equivalent 2>&1 | — Gunther Huebler / githubweb
  49. Updating compiler config file — Gunther Huebler / githubweb
  50. Changing the cam_global_ERP_Ln9_gfortran_test jenkins test to specify the computer when configuring. — pbroels / githubweb
  51. The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb
  52. The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb
  53. Making compatible with latest clubb change. update_xp2_mc will be broken by this, but all we need to do to fix it is push the column loop into it. — Gunther Huebler / githubweb
  54. Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it. — 37674341+huebleruwm / githubweb
  55. Pushing column loop into mean advection procedures. — 37674341+huebleruwm / githubweb
  56. Little loop push — 37674341+huebleruwm / githubweb
  57. Moving above/below index of grid weights to last dimension. — 37674341+huebleruwm / githubweb
  58. Pushing loop into fill_holes. — 37674341+huebleruwm / githubweb
  59. Forgot small change. — 37674341+huebleruwm / githubweb
  60. Making linear_interpolated_azt_2D and linear_interpolated_azm_2D subroutines just to avoid a needless data copy. — 37674341+huebleruwm / githubweb
  61. Making update_xp2_mc 2D and creating interface for 1D calls. — 37674341+huebleruwm / githubweb
  62. Making use of new 2D call to update_xp2_mc — Gunther Huebler / githubweb
  63. Declaring local variables with state%ncol rather than pcols. This avoid occasional slicing and other complications. Also making everything in clubb_tend_cam follow the same indentation scheme. — Gunther Huebler / githubweb
  64. added ulimit tag to arm97 case of scam test to avoid stack overflow errors larson-group/sys_admin#781 — cernikt / githubweb
  65. Fixing units in stats_zt_module.F90 — noreply / githubweb
  66. Adding run script for gpu runs without silhs. The only thing making this a GPU script right now is that it's set for casper using nvhpc with acc flags, but there might be more settings in the future we want to add here. — Gunther Huebler / githubweb
  67. Compiler and machine scripts to include the lastest changes in the cime repo, but also keeping our custom configurations in. — Gunther Huebler / githubweb
  68. Adding compiler optioned needed to compile with latest gnu version. These were accidentally removed and caused tests to fail. RESOLVED:f98790fed7b9283cce7e9981d7e0c2be7fe8e3fb — Gunther Huebler / githubweb
  69. Fixing a bug in mono_flux_limiter.F90. (#1026) — noreply / githubweb
  70. Fixing a bug. — bmg2 / githubweb
  71. Renaming wpthlp_entermfl to wpthlp_enter_mfl to be consistent with the CLUBB repo. — benjamin.andrew.stephens / githubweb
  72. This commit is not bit changing, but the following commits were — noreply / githubweb
  73. This commit is not bit changing, but the following were — noreply / githubweb
  74. adding new jenkins test for ERP_ln9 with silhs configuration — cernikt / githubweb
  75. small change to cam_silhs_ERP test — cernikt / githubweb
  76. Added intel compiler configuration for nelson to support ncar debug flags test #144 — cernikt / githubweb
  77. Made new jenkins file for ncar debug test #144 — cernikt / githubweb
  78. Forgot to change a few paths #144 — cernikt / githubweb
  79. I changed the w_up_in_cloud code in 2 ways: — bmg2 / githubweb
  80. Possible fix to test error #144 — cernikt / githubweb
  81. I added stats output for w_down_in_cloud to all_stats.in. — bmg2 / githubweb
  82. Updating for the latest changes to CLUBB. — bmg2 / githubweb
  83. I altered the w_up_in_cloud and w_down_in_cloud code so that a — bmg2 / githubweb
  84. I have optimized the new w_up_in_cloud and w_down_in_cloud code by — bmg2 / githubweb
  85. Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972. — 37674341+huebleruwm / githubweb
  86. Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  87. Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  88. Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  89. Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  90. Adding comments. — 37674341+huebleruwm / githubweb
  91. Adding initial subroutine calc_ice_cloud_frac_component. — 37674341+huebleruwm / githubweb
  92. Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  93. Comment update — 37674341+huebleruwm / githubweb
  94. Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines. — 37674341+huebleruwm / githubweb
  95. Adding line to indicate BIT_CHANGING:0f8ff1baa73dd122911de7978d0067ad1fcc348b. This is because of actual bit changing commits, and is expected. See https://github.com/larson-group/clubb/pull/1034. — Gunther Huebler / githubweb
  96. Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical. — 37674341+huebleruwm / githubweb
  97. Adds commented-out line that prevents the monotonic flux — noreply / githubweb
  98. Updating monotonic flux limiter code to remove spikes. (#1038) — noreply / githubweb
  99. Creating new flags to control monotonic flux limiter (#1039) — noreply / githubweb
  100. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/1039. — 59519056+bstephens82 / githubweb
  101. I am adding cloudy_updraft_frac and cloudy_downdraft_frac as — bmg2 / githubweb
  102. Modified for changes to advance_clubb_core_api. — bmg2 / githubweb
  103. Minor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043) — noreply / githubweb
  104. Adding line to indicate BIT_CHANGING:5abaa74c4daad3b827fff70359563703a9152d1b. This is because of actual bit changing commits, and is expected — noreply / githubweb
  105. Making interface for matrix solvers. — 37674341+huebleruwm / githubweb
  106. Making tridag tridiag everywhere, making sol soln, and adding intent comments. — 37674341+huebleruwm / githubweb
  107. A different way of dealing with monotonic flux limiter spikes (#1046) — noreply / githubweb
  108. Steffens tuner fixer branch (#1041) — noreply / githubweb
  109. Adding space to file since previous commit was intentionally BIT_CHANGING:a466f958c140acbd260290c59213a96f3c049793. — Gunther Huebler / githubweb
  110. Adding capability to change matrix solving method via clubb_config_flags. — 37674341+huebleruwm / githubweb
  111. Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones. — 37674341+huebleruwm / githubweb
  112. Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024. — 37674341+huebleruwm / githubweb
  113. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  114. I added "smooth" max clipping for invrs_tau_shear, which is a variable — bmg2 / githubweb
  115. ADG1_pdf_driver subroutine port with OpenACC — 37674341+huebleruwm / githubweb
  116. Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049 — 37674341+huebleruwm / githubweb
  117. I can now safely remove all the "ifdef E3SM" statements from CLUBB's — bmg2 / githubweb
  118. Pushing column loop into lapack wrap. — 37674341+huebleruwm / githubweb
  119. Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052) — noreply / githubweb
  120. Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) — noreply / githubweb
  121. Breaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051) — noreply / githubweb
  122. Adding tridiag_lu solver (#1056) — noreply / githubweb
  123. Adding OpenACC data directives for mixing length and adg routines — Vince Larson / githubweb
  124. Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general. — Gunther Huebler / githubweb
  125. GPUizing sat_mixrat_ice_2D. — 37674341+huebleruwm / githubweb
  126. Pushing column loop into calculate_thvm — 37674341+huebleruwm / githubweb
  127. Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926. — 37674341+huebleruwm / githubweb
  128. Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1 — Gunther Huebler / githubweb
  129. GPUizing some helping procedures. — 37674341+huebleruwm / githubweb
  130. Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory. — 37674341+huebleruwm / githubweb
  131. Porting pdf_closure subroutine with OpenACC (#1059) — noreply / githubweb
  132. Adding wp3_on_wp2_cfl_num to CLUBB's output stats. — bmg2 / githubweb
  133. Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly. — 37674341+huebleruwm / githubweb
  134. Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068) — noreply / githubweb
  135. Gpu updates (#1070) — noreply / githubweb
  136. Implements Thomas Toniazzo's bug fix for spike removal — noreply / githubweb
  137. Making 'a_const' into a CLUBB tunable parameter. (#1072) — noreply / githubweb
  138. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/1072. — benjamin.andrew.stephens / githubweb
  139. Pdf closure driver gpuization (#1071) — noreply / githubweb
  140. Moving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break. — Gunther Huebler / githubweb
  141. Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2. — Gunther Huebler / githubweb
  142. Small GPU fixes (#1076) — noreply / githubweb
  143. Code changes to implement modificiations on wp3 clippings — bmg2 / githubweb
  144. This commit contains code changes to implement modifications on limiters in three places: — bmg2 / githubweb
  145. Updating for recent changes to CLUBB. — bmg2 / githubweb
  146. Advance xm wpxp gpuization (#1077) — noreply / githubweb
  147. Small tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems. — Gunther Huebler / githubweb
  148. Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard. — Gunther Huebler / githubweb
  149. Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test. — Gunther Huebler / githubweb
  150. Lscale GPUization (#1079) — noreply / githubweb
  151. gfortran does not like intent(out) specifiers for functions. — Gunther Huebler / githubweb
  152. GPUizing Various Small Routines (#1080) — noreply / githubweb
  153. This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
  154. This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
  155. this is another commit that cahnges nothing that will trigger the gitUpdate scripts — cernikt / githubweb
  156. adding an update that changes nothing and is just a test for the autoupdate script — cernikt / githubweb
  157. Making CLUBB's splatting scheme implicit and smoother (#1075) — noreply / githubweb
  158. Calc sfc varnce GPUization (#1081) — noreply / githubweb
  159. Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code. — benjamin.andrew.stephens / githubweb
  160. Removed Space From clip_explicit — cernikt / githubweb
  161. Autoupdated CLUBB_core — cernikt / githubweb
  162. making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
  163. making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
  164. Here is another commit that changes nothing — cernikt / githubweb
  165. Here is another commit that changes nothing — cernikt / githubweb
  166. change to trigger updates — cernikt / githubweb
  167. change to calc pressure to trigger autoupdate — cernikt / githubweb
  168. GPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083) — noreply / githubweb
  169. GPUizing most of advance_clubb_core (#1084) — noreply / githubweb
  170. advance_wp2_wp3 with explicitly managed memory  (#1085) — noreply / githubweb
  171. advance_xp2_xpyp with explicitly managed memory (#1086) — noreply / githubweb
  172. advance_windm_edsclrm with explicitly managed memory (#1087) — noreply / githubweb
  173. Moving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088) — noreply / githubweb
  174. Data movement improvement (#1089) — noreply / githubweb

#17 (Apr 20, 2022, 3:09:00 PM)

  1. Testing final format for test — pbroels / githubweb

#16 (Apr 20, 2022, 3:03:50 PM)

  1. Trying seperate more explicit git clone scheme and removed the final run command as it was unneeded — pbroels / githubweb

#15 (Apr 20, 2022, 2:33:16 PM)

  1. Adding in clone step. — pbroels / githubweb

#9 (Apr 19, 2022, 4:48:42 PM)

  1. Added code to interface with the latest version of CLUBB. — bmg2 / githubweb
  2. Adding _pert arrays to other advance_clubb_core call. — Gunther Huebler / githubweb

#7 (Apr 13, 2022, 4:50:21 PM)

  1. Adding in parameters for full runs. — pbroels / githubweb

#6 (Apr 13, 2022, 3:38:18 PM)

  1. Removing incorrect function calls for a Scripted pipeline. — pbroels / githubweb

#5 (Apr 13, 2022, 3:13:33 PM)

  1. I added the code for the l_linearize_pbl_winds flag that was originally — bmg2 / githubweb
  2. Trying scripted Pipeline syntax rather than Declarative syntax to test loading and running our current pipelines. — pbroels / githubweb

#4 (Apr 12, 2022, 4:50:43 PM)

  1. Adding in temp arguments for testing. — pbroels / githubweb

#3 (Apr 12, 2022, 4:43:56 PM)

  1. Fixing errors in previous change to allow script to work. — pbroels / githubweb

#2 (Apr 12, 2022, 4:40:17 PM)

  1. Changing syntax to load and run Jenkinsfile. — pbroels / githubweb