Putting other log file copy commands in try catch to prevent it from failing the step before cleaning the directory — pbroels / githubweb
The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb
The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb
Making compatible with latest clubb change. update_xp2_mc will be broken by this, but all we need to do to fix it is push the column loop into it. — Gunther Huebler / githubweb
Fixing small bug preventing compilation. — Gunther Huebler / githubweb
Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it. — 37674341+huebleruwm / githubweb
Pushing column loop into mean advection procedures. — 37674341+huebleruwm / githubweb
Little loop push — 37674341+huebleruwm / githubweb
Moving above/below index of grid weights to last dimension. — 37674341+huebleruwm / githubweb
Pushing loop into fill_holes. — 37674341+huebleruwm / githubweb
Forgot small change. — 37674341+huebleruwm / githubweb
Making linear_interpolated_azt_2D and linear_interpolated_azm_2D subroutines just to avoid a needless data copy. — 37674341+huebleruwm / githubweb
Making update_xp2_mc 2D and creating interface for 1D calls. — 37674341+huebleruwm / githubweb
Making use of new 2D call to update_xp2_mc — Gunther Huebler / githubweb
Fixing units in stats_zt_module.F90 — noreply / githubweb
Fixing a bug in mono_flux_limiter.F90. (#1026) — noreply / githubweb
Fixing a bug. — bmg2 / githubweb
I changed the w_up_in_cloud code in 2 ways: — bmg2 / githubweb
I added stats output for w_down_in_cloud to all_stats.in. — bmg2 / githubweb
Modifications for the latest CLUBB code changes. — bmg2 / githubweb
Adding w_down_in_cl to the E3SM stats output, as well. — bmg2 / githubweb
I altered the w_up_in_cloud and w_down_in_cloud code so that a — bmg2 / githubweb
I have optimized the new w_up_in_cloud and w_down_in_cloud code by — bmg2 / githubweb
Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972. — 37674341+huebleruwm / githubweb
Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
Adding comments. — 37674341+huebleruwm / githubweb
Adding initial subroutine calc_ice_cloud_frac_component. — 37674341+huebleruwm / githubweb
Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
Comment update — 37674341+huebleruwm / githubweb
Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines. — 37674341+huebleruwm / githubweb
Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical. — 37674341+huebleruwm / githubweb
I have updated the diagnostic. Main changes: 1. Merge Prof. Larson's tuner analyze_sensitivity_matrix. But domatrix is false by default, because the tuner is not the latest version. 2. Mergeing Kate's changes in function_pick_out.py. CAM's FV dycore can be handled. 3. Plotting profiles below 700hPa. 4. Merge Brian's flag for DJF mean. 5. Creating new regional files for tuner, see draw_plots_hoz_2D.py. — guozhun / githubweb
Plotting file for large scale variables. — guozhun / githubweb
Adds commented-out line that prevents the monotonic flux — noreply / githubweb
Updating monotonic flux limiter code to remove spikes. (#1038) — noreply / githubweb
Creating new flags to control monotonic flux limiter (#1039) — noreply / githubweb
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/1039. — 59519056+bstephens82 / githubweb
I am adding cloudy_updraft_frac and cloudy_downdraft_frac as — bmg2 / githubweb
Modified for changes made to call to advance_clubb_core_api. — bmg2 / githubweb
Minor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043) — noreply / githubweb
Making interface for matrix solvers. — 37674341+huebleruwm / githubweb
Making tridag tridiag everywhere, making sol soln, and adding intent comments. — 37674341+huebleruwm / githubweb
A different way of dealing with monotonic flux limiter spikes (#1046) — noreply / githubweb
Steffens tuner fixer branch (#1041) — noreply / githubweb
Making compatible with latest clubb changes. — Gunther Huebler / githubweb
Adding capability to change matrix solving method via clubb_config_flags. — 37674341+huebleruwm / githubweb
Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones. — 37674341+huebleruwm / githubweb
Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024. — 37674341+huebleruwm / githubweb
I added "smooth" max clipping for invrs_tau_shear, which is a variable — bmg2 / githubweb
ADG1_pdf_driver subroutine port with OpenACC — 37674341+huebleruwm / githubweb
Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049 — 37674341+huebleruwm / githubweb
I updated the clubb_intr.F90 file in the clubb_silhs_devel branch to — bmg2 / githubweb
I can now safely remove all the "ifdef E3SM" statements from CLUBB's — bmg2 / githubweb
Pushing column loop into lapack wrap. — 37674341+huebleruwm / githubweb
Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052) — noreply / githubweb
Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) — noreply / githubweb
Breaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051) — noreply / githubweb
Adding tridiag_lu solver (#1056) — noreply / githubweb
Adding OpenACC data directives for mixing length and adg routines — Vince Larson / githubweb
Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general. — Gunther Huebler / githubweb
GPUizing sat_mixrat_ice_2D. — 37674341+huebleruwm / githubweb
Pushing column loop into calculate_thvm — 37674341+huebleruwm / githubweb
Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926. — 37674341+huebleruwm / githubweb
Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1 — Gunther Huebler / githubweb
GPUizing some helping procedures. — 37674341+huebleruwm / githubweb
Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory. — 37674341+huebleruwm / githubweb
Porting pdf_closure subroutine with OpenACC (#1059) — noreply / githubweb
Adding wp3_on_wp2_cfl_num to CLUBB's output stats. — bmg2 / githubweb
Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly. — 37674341+huebleruwm / githubweb
Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068) — noreply / githubweb
Gpu updates (#1070) — noreply / githubweb
Implements Thomas Toniazzo's bug fix for spike removal — noreply / githubweb
Making 'a_const' into a CLUBB tunable parameter. (#1072) — noreply / githubweb
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/1072. — benjamin.andrew.stephens / githubweb
Pdf closure driver gpuization (#1071) — noreply / githubweb
Moving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break. — Gunther Huebler / githubweb
Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2. — Gunther Huebler / githubweb
Small GPU fixes (#1076) — noreply / githubweb
Code changes to implement modificiations on wp3 clippings — bmg2 / githubweb
This commit contains code changes to implement modifications on limiters in three places: — bmg2 / githubweb
Updated for recent changes to CLUBB. — bmg2 / githubweb
Advance xm wpxp gpuization (#1077) — noreply / githubweb
Small tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems. — Gunther Huebler / githubweb
Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard. — Gunther Huebler / githubweb
Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test. — Gunther Huebler / githubweb
Lscale GPUization (#1079) — noreply / githubweb
gfortran does not like intent(out) specifiers for functions. — Gunther Huebler / githubweb
GPUizing Various Small Routines (#1080) — noreply / githubweb
This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
this is another commit that cahnges nothing that will trigger the gitUpdate scripts — cernikt / githubweb
adding an update that changes nothing and is just a test for the autoupdate script — cernikt / githubweb
Making CLUBB's splatting scheme implicit and smoother (#1075) — noreply / githubweb
Calc sfc varnce GPUization (#1081) — noreply / githubweb
Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code. — benjamin.andrew.stephens / githubweb
Removed Space From clip_explicit — cernikt / githubweb
making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
Here is another commit that changes nothing — cernikt / githubweb
Here is another commit that changes nothing — cernikt / githubweb
change to trigger updates — cernikt / githubweb
change to calc pressure to trigger autoupdate — cernikt / githubweb

#75 (May 20, 2023, 10:20:08 AM)

made change to nightly script — cernikt / githubweb

#72 (May 16, 2023, 7:30:14 PM)

updated script — cernikt / githubweb

#69 (Jun 8, 2022, 1:05:21 PM)

Lots of small loop pushes — 37674341+huebleruwm / githubweb
Small bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run. — 37674341+huebleruwm / githubweb
Small refactoring to mfl_xm_lhs, just removing need to pass in gr. — 37674341+huebleruwm / githubweb
Final loop pushes needed before the grid change. — 37674341+huebleruwm / githubweb
Replacing use of gr with nz — 37674341+huebleruwm / githubweb
Replacing use of gr with nz — 37674341+huebleruwm / githubweb
edited config_compilers.xml nelson configuration flags to make it work on pop OS — cernikt / githubweb

#67 (Jun 7, 2022, 2:01:05 PM)

For clubb:ticket:786: — raut / githubweb
For clubb:ticket:786: — raut / githubweb
For clubb:ticket:782, I added all CLUBB's parameter indices to the API. — raut / githubweb
helpful note — raut / githubweb
more helpful note — raut / githubweb
most helpful note — raut / githubweb
For cam:ticket:56: — raut / githubweb
While working on cam:ticket:59, I noticed that `tau_N2_zm` is computed twice. I removed one computation. — raut / githubweb
Dat crazy indentation, though... — raut / githubweb
For cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`. — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59, I added a new output for Richardson number. — raut / githubweb
For cam:ticket:59: — raut / githubweb
Per cam:ticket:59#comment:21, using `T_in_K_zm` in "the formula". — raut / githubweb
For cam:ticket:59. — raut / githubweb
For cam:ticket:59 I renamed `Richardson_no` to `Richardson_num`. — raut / githubweb
For cam:ticket:59, I added kludgy statistical output for `brunt_vaisala_freq_sqd`. — raut / githubweb
I made an error message more verbose. — raut / githubweb
Still wanted to stop, though... — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59. — raut / githubweb
For cam:ticket:59: — raut / githubweb
Apparently, I didn't have to jump through the hoop of declaring a separate profile to use in the `max` statement. — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For clubb:ticket:782: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For clubb:ticket:782: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59, I fixed bugs in the `l_use_C7_Richardson=T` vertical averaging code: — raut / githubweb
I adjusted a comment. — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
Renamed C7 to Cx in appropriate places. — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
I made it a default to use 0 instead of cloud_frac_min in the B.V. frequency calculation. — raut / githubweb
For clubb:ticket:790: — raut / githubweb
I am setting `l_lh_normalize_weights=T` by default in both the source code and the namelist. — raut / githubweb
It is more robust to check the average of the sample point weights rather than the sum of the sample point weights for unity-ness. — raut / githubweb
For cam:ticket:67: — raut / githubweb
For cam:ticket:67: — raut / githubweb
Code improvements. — raut / githubweb
Vince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more! — raut / githubweb
For cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used. — raut / githubweb
Fixed a comment. — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:792: — raut / githubweb
For clubb:ticket:792: — raut / githubweb
For clubb:ticket:792, I added more initializations for uninitialized variables. — raut / githubweb
When l_avg_Lscale is turned on but the plume-centered calculation is disabled, — bmg2 / githubweb
For clubb:ticket:792: — raut / githubweb
For clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output. — raut / githubweb
I renamed RH_postPDF to rel_humidity. — raut / githubweb
For clubb:ticket:792. rsat actually should be recomputed here before output, because it will change if `l_rcm_supersat_adj = T`. — raut / githubweb
For clubb:ticket:792. I am reusing the `rel_humidity` variable for output, for no particular reason. — raut / githubweb
For clubb:ticket:792!!!! I set `l_rcm_supersat_adj = T` by default, in both source code and namelist. — raut / githubweb
As requested, I am adding a warning message (debug level 1) when spurious supersaturation is removed. — raut / githubweb
Comment. — raut / githubweb
For clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010). — raut / githubweb
I removed a spurious print statement. — raut / githubweb
For cam:ticket:73: — raut / githubweb
I am beginning to generalize the sponge damping code so that it can be applied to — bmg2 / githubweb
I have added all the coding infrastructure to perform sponge damping (and record — bmg2 / githubweb
— Vince Larson / githubweb
clubb:ticket:796 — roessle9 / githubweb
clubb:ticket:796 — roessle9 / githubweb
I added some parameter value checking in subroutine setup_parameters. — bmg2 / githubweb
clubb:ticket:796 — roessle9 / githubweb
I finally have a standalone version of the new subroutine, generate_pdf_params, — bmg2 / githubweb
Some code within advance_clubb_core that is found within CAM_CLUBB preprocessor — bmg2 / githubweb
The perturbation Lscale code requires rtm_frz, thlm_frz, and pdf_params_frz to — bmg2 / githubweb
I added a missing intent(out) statement. — bmg2 / githubweb
I have interfaced the new subroutine containing all of the PDF closure-related — bmg2 / githubweb
I got rid of some variables that were brought into advance_clubb_core by use statements — bmg2 / githubweb
I cleaned up more compiler warnings for unused variables. The warnings came from g95. — bmg2 / githubweb
I have added a second call to subroutine generate_pdf_params. This one occurs — bmg2 / githubweb
I moved the setting of qclvar and thlprcp_out to after the second call to — bmg2 / githubweb
I have declared the l_use_ice_latent option and the l_call_pdf_closure_twice — bmg2 / githubweb
I added a local cslculation of sigma_sqd_w near the top of subroutine — bmg2 / githubweb
I am changing the inputs and outputs of subroutine advance_clubb_core so that — bmg2 / githubweb
I added code so that stats that are internal to subroutine generate_pdf_params — bmg2 / githubweb
I have updated subroutine advance_clubb_core so that pdf_params_zm is now passed — bmg2 / githubweb
Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical — savva / githubweb
Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical — savva / githubweb
Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical — savva / githubweb
Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical — savva / githubweb
— Vince Larson / githubweb
— Vince Larson / githubweb
I added a new subroutine, init_pdf_params, to pdf_parameter_module.F90. — bmg2 / githubweb
I renamed the subroutine pack_pdf_params found in setup_clubb_pdf_params.F90 — bmg2 / githubweb
I am now using the new subroutine init_pdf_params to initialize the — bmg2 / githubweb
I removed the CAM_CLUBB preprocessor directives from pack_pdf_params_api, — bmg2 / githubweb
clubb:ticket:800 -- Changed fatal errors statements to debug level 0. — savva / githubweb
clubb:ticket:800 -- Changed fatal errors statements to debug level 0. — savva / githubweb
I updated CLUBB stats so that wpthvp, wp2thvp, rtpthvp, and thlpthvp — bmg2 / githubweb
I have added the coding infrastructure to output additional statistics — bmg2 / githubweb
This is a bug fix for the Sun compiler. The variables pdf_params_zm and — bmg2 / githubweb
I am updating the hydrometeor PDF code to set mu_hm_1 and — bmg2 / githubweb
Running the Bitten tests. — bmg2 / githubweb
I added some comments so that CLUBB-SILHS would be consistent with — Vince Larson / githubweb
I added some comments so that CLUBB-SILHS would be consistent with — Vince Larson / githubweb
clubb:ticket:805 — roessle9 / githubweb
clubb:ticket:805 — roessle9 / githubweb
clubb:ticket:805 — roessle9 / githubweb
For clubb:ticket:805, I made two changes: — Vince Larson / githubweb
As a first step, I changed all instances of rrtthl to corr_rt_thl_1. — bmg2 / githubweb
I have added corr_rt_thl_2 to the code to go along with corr_rt_thl_2. — bmg2 / githubweb
I have added some code to add corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2 — bmg2 / githubweb
I added new statistics to the CLUBB _zt output files, specifically corr_w_rt_1, corr_w_rt_2, — bmg2 / githubweb
I am updating the equations for wp2rtp, wp2thlp, wprtp2, and wpthlp2 to include — bmg2 / githubweb
I am adding a special function to calculate the within-component correlation of — bmg2 / githubweb
I added variables corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 — bmg2 / githubweb
I am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to type — bmg2 / githubweb
Now that the PDF component correlations of w and chi, as well as w and eta, — bmg2 / githubweb
I am adding statistical output for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, — bmg2 / githubweb
I am changing the name of the flag l_fix_chi_eta_correlations to — bmg2 / githubweb
The two component normal (double Gaussian) PDF used by CLUBB will now be — bmg2 / githubweb
I moved the checking of the options for the PDF call placement to subroutine — bmg2 / githubweb
I am altering setup PDF parameters to be able to read in the values of — bmg2 / githubweb
I am adding the new file new_pdf.F90 to the CLUBB core directory. So far, it — bmg2 / githubweb
I am adding a large amount of code to the new PDF. I have filled in the driver — bmg2 / githubweb
I am adding code to the new PDF that calculates the minimum and maximum — bmg2 / githubweb
I added a new iiPDF entry for the new PDF, and I neatened some of the current — bmg2 / githubweb
I added an option to call the new PDF from subroutine pdf_closure. — bmg2 / githubweb
I had to add checking for the new PDF so someone does not try to run it — bmg2 / githubweb
I made a couple changes to (1) initialize two variables that aren't used by the — bmg2 / githubweb
I added a conditional to the subroutine that sets the responder parameters. — bmg2 / githubweb
I have added the beginnings of a new unit test for the PDF parameters. — bmg2 / githubweb
I have updated the PDF parameter unit test to make a call to the full PDF (for — bmg2 / githubweb
I have added a feature to the PDF parameter unit tests which allows the user — bmg2 / githubweb
In the setter variable description and subprograms, I made a name change from — bmg2 / githubweb
I have updated the method of calculating the setter variable so that mu_x_1 — bmg2 / githubweb
I added primarily some more documentation and notes. — bmg2 / githubweb
I added some more comments documenting the code. — bmg2 / githubweb
I got rid of some of the expressions that a script might try to flag as — bmg2 / githubweb
I added much more documentation about the responder variable. Specifically, — bmg2 / githubweb
I am adding the new file, original_pdf.F90, as the new home for the ADG1, ADG2, — bmg2 / githubweb
I have now switched the PDF closure code over to calling the code that had been — bmg2 / githubweb
I updated the documentation in the code comments for the setter method and — bmg2 / githubweb
I added a comment. — bmg2 / githubweb
I added a new function, calc_comp_corrs_binormal, to pdf_utilities.F90. This — bmg2 / githubweb
I added some more descriptive comments and a new function that calculates the — bmg2 / githubweb
I updated the code so that coef_sigma_x_1_sqd and coef_sigma_x_2_sqd are passed — bmg2 / githubweb
I fixed a mistake. — bmg2 / githubweb
I have added code to call the new function that calculates wp4 implicitly from — bmg2 / githubweb
I moved the calculations of wp2xp (wp2rtp and wp2thlp), wp4, and wpxp2 (wprtp2 — bmg2 / githubweb
I added another function to the new PDF. This function helps to calculate — bmg2 / githubweb
I added a special case for the wpxp2 implicit code. — bmg2 / githubweb
Back in clubb:r8409, the PDF component correlations of w and rt and w and — bmg2 / githubweb
I added a subroutine that calculates the implicit and explicit portions of the — bmg2 / githubweb
I renamed original_pdf.F90 as adg1_adg2_3d_luhar_pdf.F90. — bmg2 / githubweb
I added statistical output for F_w, F_rt, F_thl, min_F_w, max_F_w, min_F_rt, — bmg2 / githubweb
I split the new PDF into two files. I added a new file that currently houses — bmg2 / githubweb
I clipped temperature within the Goff-Gratch functions for saturation over liquid and ice. — Vince Larson / githubweb
I initialized some output variables in order to prevent a runtime error. — bmg2 / githubweb
I made a sub-driver level subroutine for the calculations necessary for a — bmg2 / githubweb
I added code to allow the variable (of w, rt, or theta-l) with the greatest — bmg2 / githubweb
I added calls to the functions and subroutines that calculate the implicit and — bmg2 / githubweb
I changed coef_wp2xp_explicit (coef_wp2rtp_explicit and coef_wp2thlp_explicit) — bmg2 / githubweb
I am adding a new file for the new trivariate skewness-dependent analaytic — bmg2 / githubweb
I fixed a bug in the new Trivariate skewness-dependent analytic double Gaussian — bmg2 / githubweb
In order for the TSDADG PDF to work correctly, when Skx * sgn( <w'x'> ) >= 0, — bmg2 / githubweb
In order to clarify coding in CLUBB, I am moving a block of code that is — bmg2 / githubweb
I am fixing a bug where rtp2 and thlp2 (and sclrp2) were not preserved when — bmg2 / githubweb
I updated the TSDADG PDF by adding the responding variable description, the — bmg2 / githubweb
When ADG1 or ADG2 are not used, we have to set alpha_rt, alpha_thl, and — bmg2 / githubweb
I am calling the new TSDADG PDF from subroutine pdf_closure. — bmg2 / githubweb
Clarity changes to the new TSDADG PDF. — bmg2 / githubweb
I added some references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
I added some references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
I fixed a bug in the calculation of PDF component variances in the new TSDADG — bmg2 / githubweb
I added more references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
I added more references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
I added more links to the CLUBB-SILHS overview tech doc. — Vince Larson / githubweb
I have set the tunable parameters F_x and zeta_x to skewness functions for the — bmg2 / githubweb
I needed to increase the limit of nvarmax_zt so that LBA (and other — bmg2 / githubweb
I changed the URL references to the CLUBB-SILHS overview document. — Vince Larson / githubweb
I changed the URL references to the CLUBB-SILHS overview document. — Vince Larson / githubweb
Changed variable and subroutine names, see ticket 810 and 811 — hoc_browser / githubweb
Changed variable and subroutine names, see ticket 810 and 811 — hoc_browser / githubweb
I have added the Lewellen and Yoh (1993) PDF to CLUBB for testing and comparison — bmg2 / githubweb
Fixed line length exceding 100 characters warnings — Gunther Huebler / githubweb
Changed the arrangement of variables in the subroutine compute_mixing_length as well as calls to it clubb:ticket:815 — Gunther Huebler / githubweb
Fixed lines exceeding 100 characters warnings clubb:ticket:815 — Gunther Huebler / githubweb
I added an option to incorporate the buoyancy term into CLUBB's eddy diffusivity for momentum. — Vince Larson / githubweb
I added c_K10 as a tuning parameter in front of the new momentum eddy diffusivity. — Vince Larson / githubweb
Removed unused parameters to clear warnings clubb:ticket:803 — Gunther Huebler / githubweb
Removed unused parameters to clear warnings clubb:ticket:803 — Gunther Huebler / githubweb
I multiplied the eddy diffusivity for momentum by a skewness-dependent factor — Vince Larson / githubweb
I changed the way that F_rt and F_thl are set in the new PDF. They are now set — bmg2 / githubweb
I changed the flag setting on the new PDF so that it always uses w as the setter — bmg2 / githubweb
Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803 — Gunther Huebler / githubweb
Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803 — Gunther Huebler / githubweb
Improved binary search algorithm clubb:ticket:818 — Gunther Huebler / githubweb
Added warning messages to function binary_search clubb:ticket:818 — Gunther Huebler / githubweb
Removed unused variables causing warnings clubb:ticket:803 — Gunther Huebler / githubweb
I updated the call to the new PDF so that Skrt and Skthl are intent INOUT — bmg2 / githubweb
Removed many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803 — Gunther Huebler / githubweb
I am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90. This — bmg2 / githubweb
I finished adding the units to the variable descriptions in — bmg2 / githubweb
The calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>, — bmg2 / githubweb
I added the tunable or adjustable parameters for the new PDF to CLUBB's list — bmg2 / githubweb
Fixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803 — Gunther Huebler / githubweb
I am committing a line of code that limits the adjusted correlation of rt and — bmg2 / githubweb
I implemented a new method to handle cumulus momentum fluxes. — Vince Larson / githubweb
Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804 — Gunther Huebler / githubweb
Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804 — Gunther Huebler / githubweb
Removed file anl_erf.F90, it is no longer used — Gunther Huebler / githubweb
I am altering the solution to the wp3 predictive equation to calculate the — bmg2 / githubweb
I fixed the problem with the wp3 budgets as a result of r8584. The budgets in — bmg2 / githubweb
I altered the names of the turbulent advection functions that are closed by — bmg2 / githubweb
I added a couple comments about how the discretization of the turbulent — bmg2 / githubweb
I added the function that sets up the implicit calculation of the wp3 turbulent — bmg2 / githubweb
I added a function that calculates the explicit form of the wp3 turbulent — bmg2 / githubweb
I am adding a function to calculate the turbulent advection of wpxp explicitly. — bmg2 / githubweb
I am adding a function to calculate the turbulent advection of xp2 and xpyp — bmg2 / githubweb
I interfaced the wp3 explicit turbulent advection code with CLUBB. It is — bmg2 / githubweb
I am interfacing the wpxp explicit turbulent advection option with the rest of — bmg2 / githubweb
I fixed a small bug with the explicit turbulent advection option for wpxp. — bmg2 / githubweb
I am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code. — bmg2 / githubweb
I added the l_explicit_turbulent_adv_* family of flags to the new PDF, for some — bmg2 / githubweb
I am packing up the implicit coefficients and explicit terms calculated by the — bmg2 / githubweb
Made epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804 — Gunther Huebler / githubweb
I made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90. — bmg2 / githubweb
I have completed interfacing the implicit form of the wp3 turbulent advection — bmg2 / githubweb
When the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advection — bmg2 / githubweb
I cleaned up the Skx_module and added an additional function, — bmg2 / githubweb
I fixed a bug in the calculation of scalar skewness. It was being set to 0, — bmg2 / githubweb
I moved the location of the LG 2005 ansatz to calculate xp3 because it would be — bmg2 / githubweb
I reverted clubb:r8611 because (1) having the code in the other location — bmg2 / githubweb
I have added a new function, term_ta_new_pdf_lhs, to — bmg2 / githubweb
I have linked the implicit turbulent advection code for rtp2 and thlp2 to the — bmg2 / githubweb
I have added a new file that has two options for handling the xp3 term for — bmg2 / githubweb
I have interface the new xp3 code to the rest of CLUBB. It can be turned on — bmg2 / githubweb
I added a driver level subroutine for the new advance xp3 code. This will make — bmg2 / githubweb
I added budget stats for rtp3 and thlp3 to CLUBB. — bmg2 / githubweb
I am adding code that allows the turbulent advection of wpxp to be treated — bmg2 / githubweb
Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code. — Gunther Huebler / githubweb
Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code. — Gunther Huebler / githubweb
Various small comment removals and returned some functionality to api interface clubb:ticket:800 — Gunther Huebler / githubweb
A variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800 — Gunther Huebler / githubweb
This is the first part of a two-part change. I am updating plotgen plots so — bmg2 / githubweb
In part 2 of this two part commit, I have added rc_coef to the list of — bmg2 / githubweb
Various debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800 — Gunther Huebler / githubweb
Check negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800 — Gunther Huebler / githubweb
I'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800 — Gunther Huebler / githubweb
Changed calls to parameterization check to work with the new check negative implementation clubb:ticket:800 — Gunther Huebler / githubweb
— Gunther Huebler / githubweb
Removed rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800 — Gunther Huebler / githubweb
Changed error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800 — Gunther Huebler / githubweb
Fixed unused variable warnings related to error code changes — Gunther Huebler / githubweb
I am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to account — bmg2 / githubweb
Added error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to keep track of error messages is multithreaded scenarios clubb:ticket:800 — Gunther Huebler / githubweb
In r8659, I accidentally overwrote some code. This commit restores the prior — bmg2 / githubweb
Sigh — bmg2 / githubweb
Added clubb debug level checks to error checking statements clubb:ticket:800 — Gunther Huebler / githubweb
Changed many stop commands to return commands and added more err_code checks clubb:ticket:800 — Gunther Huebler / githubweb
Reverted api changes that broke SAM and WRF — Gunther Huebler / githubweb
I am adding the semi-implicit formulation of wprtpthlp, which is the turbulent — bmg2 / githubweb
I am adding output statistics for the implicit and semi-implicit coefficients — bmg2 / githubweb
I corrected the units on a couple of implicit coefficients. — bmg2 / githubweb
I fixed a bug. — bmg2 / githubweb
Removed failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
Removed reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
I am fixing a bug with the CLUBB tuner. Variables that were allocated at the — bmg2 / githubweb
Completed the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800 — Gunther Huebler / githubweb
Made all debug levels produce the same output, see clubb:ticket:823 — Gunther Huebler / githubweb
I am moving type variable implicit_coefs_terms from new_pdf_main.F90 to — bmg2 / githubweb
Modified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802 — Gunther Huebler / githubweb
Added checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802 — Gunther Huebler / githubweb
This should fix the thlm out of bounds error on clubb:ticket:828 — Gunther Huebler / githubweb
I changed the name of type variable new_pdf_implct_coefs_terms to — bmg2 / githubweb
Changed T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828 — Gunther Huebler / githubweb
I added a flag option to clip the (large, negative) effects of microphysics on — bmg2 / githubweb
I added a flag option to calculate the minimum threshold for xp2 (rtp2 and — bmg2 / githubweb
I added a special max magnitude correlation for fluxes wprtp and wpthlp. This — bmg2 / githubweb
Made better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more information — Gunther Huebler / githubweb
This commit sets C8b=0.02, changes the non-linear damping on wp3 — Vince Larson / githubweb
Added a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829 — Gunther Huebler / githubweb
I am adding a general purpose function for the turbulent advection of CLUBB's — bmg2 / githubweb
I added/changed a couple comments for the rhs portion of the generalized — bmg2 / githubweb
The turbulent advection file that handles turbulent advection for predictive — bmg2 / githubweb
I added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, that — bmg2 / githubweb
Whoops, I forgot to make wpxpyp_zm and xpyp intent (in). — bmg2 / githubweb
Added functionality to make the hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830 — Gunther Huebler / githubweb
I am updating the code that advances predictive variances and covariances in — bmg2 / githubweb
Renamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830 — Gunther Huebler / githubweb
I am updating the code that advances predictive scalar fluxes (<w'x'>) in — bmg2 / githubweb
As a first step toward having code that can clip mean values of hydrometeor — bmg2 / githubweb
init_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562 — Gunther Huebler / githubweb
I have now interfaced the subroutine that I made out of the code that clips — bmg2 / githubweb
I have added a call to the subroutine that clips hydrometeor concentrations from — bmg2 / githubweb
I added new code that clips the overall correlation of w and rt or the overall — bmg2 / githubweb
I added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which are — bmg2 / githubweb
Made clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800 — Gunther Huebler / githubweb
Reverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800 — Gunther Huebler / githubweb
Fixed nightly tests — Gunther Huebler / githubweb
I have added code to allow C2 to be adjusted by multiplying by the greater of — bmg2 / githubweb
I moved the location of the declaration and setting of new model flags to — bmg2 / githubweb
Improved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834 — Gunther Huebler / githubweb
Fixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834 — Gunther Huebler / githubweb
Actually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
Optimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
Reverted stats_clubb_utilities, accidental commit — Gunther Huebler / githubweb
This should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837 — Gunther Huebler / githubweb
— Vince Larson / githubweb
Impoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834 — Gunther Huebler / githubweb
This commit implements the effects of splatting on wp3. — Vince Larson / githubweb
I am making the first step toward committing code that allows for the option — bmg2 / githubweb
I added code to allow the option of predicting upwp and vpwp by using the — bmg2 / githubweb
I took the liberty of upgrading CLUBB's PDF closure and related code to a vector — bmg2 / githubweb
I updated the monotonic flux limiter to account for vector variables u and v. — bmg2 / githubweb
I am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output. — bmg2 / githubweb
In r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic flux — bmg2 / githubweb
I am turning on the l_predict_upwp_vpwp code! — bmg2 / githubweb
Improved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834 — Gunther Huebler / githubweb
Improved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834 — Gunther Huebler / githubweb
Changed the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834 — Gunther Huebler / githubweb
Added grid_class to the dependency lists of the pdf files that were changed in commit 8773 — Gunther Huebler / githubweb
Accidental commit, undoing 8783 — Gunther Huebler / githubweb
I am changing the default setting of flags l_min_wp2_from_corr_wx and — Brian Griffin / githubweb
Modified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834 — Gunther Huebler / githubweb
Removed print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases. — Gunther Huebler / githubweb
Changed the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834 — Gunther Huebler / githubweb
I am adding source code for the introduction of budgets for predictive upwp — Brian Griffin / githubweb
Improved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834 — Gunther Huebler / githubweb
Improved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834 — Gunther Huebler / githubweb
Modified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834 — Gunther Huebler / githubweb
Copied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834 — Gunther Huebler / githubweb
Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834 — Gunther Huebler / githubweb
Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834 — Gunther Huebler / githubweb
Improved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834 — Gunther Huebler / githubweb
I made the surface splatting terms conservative. That is, I subtracted from wp2_sfc — Vince Larson / githubweb
I added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2. — Vince Larson / githubweb
This commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero). Hence it is BIT_CHANGING. — Vince Larson / githubweb
Added functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834 — Gunther Huebler / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
Update latin_hypercube_driver_module.F90 — noreply / githubweb
I clipped sigma_sqd_w to prevent interpolated values of it — Vince Larson / githubweb
I added a new option to diagnose the dissipation time scale, tau, first — Vince Larson / githubweb
I found a new way to diagnose upthvp. Instead of using a bound on correlations, it relies — Vince Larson / githubweb
introducing error into clubb core for testing larson-group/sys_admin#533 — mcfadd34 / githubweb
reverting error that was introduced larson-group/sys_admin#533 — mcfadd34 / githubweb
I am briefly changing some of the flag and parameter settings in CLUBB — bmg2 / githubweb
Revert "I am briefly changing some of the flag and parameter settings in CLUBB" — bmg2 / githubweb
I am adding code that clips the sample point value of chi under — bmg2 / githubweb
I have updated the SILHS code to omit the assert_consistent_cf_component — bmg2 / githubweb
I added a couple of comments reminding users to change the conditions in — bmg2 / githubweb
I added a couple of comments reminding users to change the conditions in — bmg2 / githubweb
Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"" — bmg2 / githubweb
Revert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""" — bmg2 / githubweb
I committed a subroutine, diagnose_upxp, that calculates — Vince Larson / githubweb
Improved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834 — Gunther Huebler / githubweb
I am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a large — bmg2 / githubweb
I am updating the code within setup_clubb_pdf_parameters.F90 in order to take — bmg2 / githubweb
To diagnose uprcp using CLUBB's PDF machinery, — Vince Larson / githubweb
Continuing with diagnosis of uprcp using CLUBB's PDF, — Vince Larson / githubweb
More code to diagnose uprcp using CLUBB's PDF. — Vince Larson / githubweb
Correction for the last uprcp-related commit: — Vince Larson / githubweb
I am correcting the code so that the Nightly Uninitialized Variables Test — bmg2 / githubweb
I am continuing to pull parts of setup_pdf_parameters outside of a large "do" — bmg2 / githubweb
I am pulling statistical output subroutine pdf_param_ln_hm_stats outside — bmg2 / githubweb
Changing the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope. — Gunther Huebler / githubweb
commenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566 — mcfadd34 / githubweb
uncommenting threadprivate larson-group/sys_admin#566 — mcfadd34 / githubweb
I have changed the structure of setup_pdf_parameters so that the subroutine that — bmg2 / githubweb
Returned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING. — Gunther Huebler / githubweb
I am turning on the new calculation of uprcp that uses CLUBB's PDF. — Vince Larson / githubweb
I modified the code in setup_clubb_pdf_params.F90 to use only one call to — bmg2 / githubweb
I am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch to — bmg2 / githubweb
I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch — bmg2 / githubweb
I temporarily set l_clip_extreme_chi_sample_pts back to false in the — bmg2 / githubweb
Revert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the" — bmg2 / githubweb
The value of nz is passed into SILHS, so we don't need to use gr%nz. — bmg2 / githubweb
I improved the error messages when LU decomp. fails within — bmg2 / githubweb
Improved error message prints in advance_xm_wpxp. — bmg2 / githubweb
I added improved LHS and RHS print statements when a LU decomp. error occurs — bmg2 / githubweb
I added params_list to the list of variables that are accessible through — bmg2 / githubweb
I am making the first step for updating the code that calculates sigma_sqd_w. — bmg2 / githubweb
I added a log-law height dependence to the code that diagnoses — Vince Larson / githubweb
I added fill_holes_hydromet_api to clubb_api_module.F90. — bmg2 / githubweb
I added a new python script, check_for_missing_threadprivate.py, — Vince Larson / githubweb
Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834 — Gunther Huebler / githubweb
Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834 — Gunther Huebler / githubweb
Fixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834 — Gunther Huebler / githubweb
Added temp test file — noreply / githubweb
Remove test file — noreply / githubweb
Adding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical. — Gunther Huebler / githubweb
Optimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases. — Gunther Huebler / githubweb
ticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequency — guozhun / githubweb
Modifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855 — Gunther Huebler / githubweb
Replacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855 — Gunther Huebler / githubweb
Making procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855 — Gunther Huebler / githubweb
Missed one — Gunther Huebler / githubweb
I have added a new file, calc_pressure.F90, which contains code for initializing — bmg2 / githubweb
I updated CLUBB so that pressure is updated after mean fields have been — bmg2 / githubweb
Removing gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855 — Gunther Huebler / githubweb
Forgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855 — Gunther Huebler / githubweb
issue #842 — guozhun / githubweb
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. — guozhun / githubweb
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842) — guozhun / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly) — guozhun / githubweb
Efficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855 — Gunther Huebler / githubweb
This should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855 — Gunther Huebler / githubweb
An additional damping is added to the invrs_tau term in the C8 equation. ticket #842 — guozhun / githubweb
Adding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations. — Gunther Huebler / githubweb
We use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8. — guozhun / githubweb
Changing ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855 — Gunther Huebler / githubweb
Pulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855 — Gunther Huebler / githubweb
Renaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855 — Gunther Huebler / githubweb
Efficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855. — Gunther Huebler / githubweb
Modifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855 — Gunther Huebler / githubweb
Refactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855 — Gunther Huebler / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
I switched on direct diagnosis of tau rather than Lscale. — Vince Larson / githubweb
I updated the pressure initialization for cases that use sounding that is given — bmg2 / githubweb
I changed the function calculate_thvm from a pre-defined vector of size nz to — bmg2 / githubweb
I updated the calculation of thvm in advance_clubb_core to use the — bmg2 / githubweb
Adding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler. — Gunther Huebler / githubweb
Adding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855 — Gunther Huebler / githubweb
Changing where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626 — Gunther Huebler / githubweb
I am committing a test where I changed subroutine ADG1_w_closure — bmg2 / githubweb
Changing determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862 — Gunther Huebler / githubweb
Finally fixing line length error in pdf_closure — Gunther Huebler / githubweb
Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861 — Gunther Huebler / githubweb
Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861 — Gunther Huebler / githubweb
Adding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862 — Gunther Huebler / githubweb
This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc. — guozhun / githubweb
Update advance_helper_module.F90 — noreply / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
Update advance_helper_module.F90 — noreply / githubweb
Adding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626 — Gunther Huebler / githubweb
I am adding a file for the new hybrid PDF, which combines the w equation set — bmg2 / githubweb
I updated the function to calculate the implicit coefficient for the wp4 term, — bmg2 / githubweb
I made some changes to new_hybrid_pdf.F90 so that it would compile in its — bmg2 / githubweb
I edited that subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
I updated the subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
Replaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves. — nselke / githubweb
I am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the new — bmg2 / githubweb
I worked more the functions for the new hybrid PDF. — bmg2 / githubweb
Refactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855 — Gunther Huebler / githubweb
I changed all the PDF utility functions in pdf_utilities.F90 to elemental — bmg2 / githubweb
I forgot a "then" to go with an "elseif". — bmg2 / githubweb
Removed all use statements involving silhs flags from the SILHS files below the API level and putting the flags into the argument lists. — nselke / githubweb
Adding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855 — Gunther Huebler / githubweb
Adding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855 — Gunther Huebler / githubweb
Refactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855 — Gunther Huebler / githubweb
I am continuing to build the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
I am continuing to work on the driver file for the new hybrid PDF. — bmg2 / githubweb
I have completed the main parts of the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
The code for the new hybrid PDF now compiles. — bmg2 / githubweb
I added an entry for the new hybrid PDF. — bmg2 / githubweb
I have added the new hybrid PDF to the G unit tests. — bmg2 / githubweb
Mathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0. — bmg2 / githubweb
I added code to interface the call to the new hybrid PDF with pdf_closure — bmg2 / githubweb
I interfaced the implicit coefficients and explicit terms used in the turbulent — bmg2 / githubweb
I fixed a small error. The code compiles again now. — bmg2 / githubweb
Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group — pbroels / githubweb
Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group — pbroels / githubweb
Pushing down loops over transform_uniform_samples_to_pdf and resolving many if statments beforehand by copying values to new arrays with an additional sample index. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Replacing the lapack function with a simple loop to multiply a pdf_dim x pdf_dim array by a pdf_dim vector. The arrays are too small to justify using lapack. This ends up slightly faster and allows a lot more flexibility which is going to be needed shortly. This is BIT_CHANGING, but not answer changing. larson-group/clubb#869 — Gunther Huebler / githubweb
I have added code that allows CLUBB to run interactively using the new hybrid — bmg2 / githubweb
I am updating the subroutine that calculates PDF component means and standard — bmg2 / githubweb
I placed proper thresholding on interpolated up2 and interpolated vp2 — bmg2 / githubweb
I introduced the silhs_config_flags_type in clubb which now handles all SILHS config flags. — nselke / githubweb
I added a limiter to keep the maximum magnitude of the correlations of — bmg2 / githubweb
I upgraded Nc_Ncn_eqns.F90 to use elemental functions. — bmg2 / githubweb
The new hybrid PDF also uses this bit of code that sets the correlation — bmg2 / githubweb
I made modifications to the new hybrid PDF so that that calculation of F_w — bmg2 / githubweb
Minor clean-up. Writing 'Intent(in)' in call to 'generate_uniform_sample_at_k_lh_start' and adding descriptions for input and output arguments in 'initialize_silhs_config_flags_type(_api)' and 'set_default_silhs_config_flags(_api)'. #856 — nselke / githubweb
Fixed small typo I accidentally introduced in my last commit. — nselke / githubweb
I added the ability to handle scalars interactively to the new hybrid PDF. — bmg2 / githubweb
I found a couple of spots in the new hybrid PDF where I needed to add — bmg2 / githubweb
I added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90. — bmg2 / githubweb
The variable type implicit_coefs_terms needs to be made public — bmg2 / githubweb
I changed the value of the coefficient in the F_w equation to 0.45 — bmg2 / githubweb
I am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_core — bmg2 / githubweb
Replacing algorithm that calculates the inverse CDF. It's only accurate to single precision, so the uniform samples are clipped to be within a valid range for the algorithm to always be accurate. This is BIT_CHANGING for silhs enabled cases, but plots are visibly identical for rico_silhs. larson-group/clubb#869 — Gunther Huebler / githubweb
I have added a print subroutine for the SILHS configurable flags. #856 — nselke / githubweb
I have started the process of adding the coding infrastructure — bmg2 / githubweb
I have completed the addition of the ability to use different up2 — bmg2 / githubweb
I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856 — nselke / githubweb
I made the l_calc_w_corr code (turned off by default) run again by — bmg2 / githubweb
I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute. — nselke / githubweb
I have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac', — nselke / githubweb
I continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm', — nselke / githubweb
I continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm', — nselke / githubweb
Adding more clipping to the uniform sample values, and reducing the treshold. This is BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp', — nselke / githubweb
I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp', — nselke / githubweb
Changing values to use core_rknd precision. larson-group/clubb#869 — Gunther Huebler / githubweb
Cleaning up clip_transform_silhs_output and removing the X_nl_all_levs_raw variable. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Changing X_nl_all_levs to inout in clip_transform_silhs_output_api, this was missed in the last commit. larson-group/clubb#869 — Gunther Huebler / githubweb
Finished altering argument lists. This commit covers the final seven flags, which are in different namelists. — nselke / githubweb
Finished altering argument lists. This commit covers the final seven flags, which are in different namelists. — nselke / githubweb
Pushing a loop down and other small performance refactorings. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
I introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type. — nselke / githubweb
I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856 — nselke / githubweb
I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856 — nselke / githubweb
I have removed the 'rc_estimate' subroutine in 'src/SILHS/est_kessler_microphys_module.F90' because it was not working properly. I changed the 'autoconv_estimate' subroutine in the same file to be able to calculate both 'lh_AKm' and 'lh_rcm_avg' with it. I renamed that subroutine to 'calc_estimate'. #692 — nselke / githubweb
I fed pdf_params_frz into subroutine advance_clubb_core — Vince Larson / githubweb
Adding error code to arguement list of non-api routines where it was included in the api version. — Gunther Huebler / githubweb
Moving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal. — Gunther Huebler / githubweb
Added use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public. — Steffen Domke / githubweb
I have fixed the warnings for lines exceeding 100 characters. — nselke / githubweb
I have fixed the warnings for lines exceeding 100 characters. — nselke / githubweb
Passing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity. — Gunther Huebler / githubweb
Adding GPU code to portion of SILHS, and refactoring minor aspects of code structure. larson-group/clubb#869 — Gunther Huebler / githubweb
Removing problems. This should fix the compiler error. — Gunther Huebler / githubweb
Making subroutine to generate random samples and weights on CPU's, this will be accompanied by one for GPU's shortly. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Simplifiying call trees a bit, removing unused procedures, and creating a random pool to be used where random numbers were being used. This pool allows all randoms to be generated at the same time, which is better for CPUs and (as far as I know) the only decent way to do this on GPUs. Becuase of the different random numbers, this is BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
Trivial update to test if cams autoupdate works — noreply / githubweb
Changing clipping of uniform samples. This is the same fix from commit afe34fb444a47aa4cb8bcc8b9cbcaeceb0539c9f, but was accidentally reverted in commit 766a5934a8352a556ed5ba2cfeac6aa547f76f86. larson-group/clubb#869 — Gunther Huebler / githubweb
Commiting a space, because the last commit, be3699d840ed6bc3ff52dc5d397a74767ecdc414, is BIT_CHANGING. — Gunther Huebler / githubweb
Simplifying call tree some more, moving around where calculations are done so that GPU code doesn't have to be interrupted with data copies or CPU code. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Lots of GPUizing and reorganizing calls. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Revert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch" — bmg2 / githubweb
Moving sample point clipping to after the sampling drivers, rather than immediately after generate_uniform_lh_sample. This was causing sample points to end up out of range when compiling in single precision, which is why the nightly tests were failing for PGI. This should be BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
I placed E3SM preprocessor commands around E3SM-specific code in — bmg2 / githubweb
Restoring assertion check for the vertical correlation calculation. larson-group/clubb#869 — Gunther Huebler / githubweb
Changing the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869 — Gunther Huebler / githubweb
I added E3SM's clubb_ parameters that can be read in from the — bmg2 / githubweb
I added the remainder the clubb_ terms that were added previously to — bmg2 / githubweb
Changing error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869 — Gunther Huebler / githubweb
Small updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Redoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Adding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
Simple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
Small performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Removing lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869 — Gunther Huebler / githubweb
Update latin_hypercube_driver_module.F90 — noreply / githubweb
Update parameters_tunable.F90 — noreply / githubweb
GPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Making some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
I changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874 — nselke / githubweb
I added the new l_update_pressure configurable flag to clubb_config_flags. — bmg2 / githubweb
I added some code I used in the special input fields branch to make — bmg2 / githubweb
An improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875] — guozhun / githubweb
I revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874. — nselke / githubweb
I got rid of the "allocatable", "allocate", and "deallocate" statements — bmg2 / githubweb
I placed an ifndef CLUBB_CAM preprocessor flag around the code in — bmg2 / githubweb
I reduced the minimum possible value of lmin from 4.0 to 1.0. — noreply / githubweb
I made a print/write statement debug level 3 — noreply / githubweb
I made a second print/write statement debug level 3 — noreply / githubweb
I fix a print/write statement debug level3. For #755 and #800 — guozhun / githubweb
I am replacing the "use" statements that referenced — bmg2 / githubweb
I "brought back the stats" by passing the stats from advance_clubb_core — bmg2 / githubweb
Removing the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref) — bmg2 / githubweb
Results were changed yesterday for some cases because thlprcp was — bmg2 / githubweb
I have resolved all the issues surrounding recent CLUBB commits that — bmg2 / githubweb
I removed code that stops a run if the output time step is less than a minute. — noreply / githubweb
I removed references to variables_prognostic_module and — bmg2 / githubweb
Fixed a boo-boo. — bmg2 / githubweb
I set `l_diag_Lscale_from_tau = .true.` in source code — noreply / githubweb
I removed references to variable_diagnostic_module for various Kessler — bmg2 / githubweb
I removed the reference to use variables_diagnostic_module for Kh_zm — bmg2 / githubweb
Removed a reference to variables_diagnostic_module for Kh_zm in — bmg2 / githubweb
I am able to remove references to variables_prognostic_module and — bmg2 / githubweb
I removed the l_use_ice_latent flag from the code, and along with it — bmg2 / githubweb
I have completed the project of removing variables_prognostic_module — bmg2 / githubweb
I added some missing threadprivate statements — noreply / githubweb
I have taken the code from wp2_term_ta_all and placed it in the subroutine — bmg2 / githubweb
I am updating wp3_term_ta_new_pdf_lhs to use the optimized code from — bmg2 / githubweb
This commit is BIT_CHANGING. It makes the parameter values in parameters_tunable.F90 agree with those in tunable_parameters.in — benjamin.andrew.stephens / githubweb
I am making the change of using tau_wp2_zm to damp up2 and vp2, — bmg2 / githubweb
I have added the integer flags iiPDF_type and ipdf_call_placement — bmg2 / githubweb
I am going to make primary PDF type options and primary PDF call — bmg2 / githubweb
I added E3SM customizations to CLUBB's master branch. This is meant — bmg2 / githubweb
I am updating the clubb_ list of namelist parameters used in E3SM — bmg2 / githubweb
Typo — bmg2 / githubweb
Fixed more typos — bmg2 / githubweb
I am changing the new hybrid PDF's calculation of F_w to use — bmg2 / githubweb
I updated the xp3 calculation for PDF types other than ADG1. — bmg2 / githubweb
This xp3_coef_ parameters produce new hybrid PDF results similar to the old — bmg2 / githubweb
I added the 2 new parameters in the simple xp3 equation (for PDF — bmg2 / githubweb
I have combined the wp3_term_ta_ADG1_lhs and wp3_term_ta_ADG1_lhs_all — bmg2 / githubweb
I added the partially upwinded implementation of the wp3 turbulent advection — bmg2 / githubweb
Removed unused module imports — isenfireldc / githubweb
Removed unused module imports — isenfireldc / githubweb
Removed a comma that I missed while removing unused imports (#878) — isenfireldc / githubweb
I am adding l_partial_upwind_wp3 to the list of clubb_config_flags. — bmg2 / githubweb
Deprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129 — Gunther Huebler / githubweb
I started the process of paring 2 subprograms back down to 1 in — bmg2 / githubweb
I pared two more sets of equivalent subprograms down to 1 (each). — bmg2 / githubweb
Paring down 2 equivalent subprograms to 1 again. — bmg2 / githubweb
I condensed two more sets of doubled subprograms down to 1 (each) — bmg2 / githubweb
Reduced two more sets of "doubled" subprograms down. — bmg2 / githubweb
Updating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129 — Gunther Huebler / githubweb
Adding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129 — Gunther Huebler / githubweb
I updated CLUBB's copyright date range. — noreply / githubweb
Adding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129 — Gunther Huebler / githubweb
Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
Taking more duplicated subprograms and paring them down to 1. — bmg2 / githubweb
Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
Removed styleguide violations from my code — isenfireldc / githubweb
Fixed a backwards epsilon comparison from 8e8e71e — isenfireldc / githubweb
Removed the "doubling" of the remainder of the subprograms from — bmg2 / githubweb
Changing epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878 — Gunther Huebler / githubweb
Small changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129 — Gunther Huebler / githubweb
Changed the length of solve_type_str to 20 [-Wcharacter-trucation] — isenfireldc / githubweb
Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
I have tidied up advance_wp2_wp3_module.F90, and I have removed all doubled — bmg2 / githubweb
Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
I handled the "doubled" subprograms in turbulent_adv_pdf.F90. — bmg2 / githubweb
Making change explained in larson-group/clubb#878 — Gunther Huebler / githubweb
Removed some unused variables (ifort) — isenfireldc / githubweb
Removed some unused variables (ifort) — isenfireldc / githubweb
Adding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129 — Gunther Huebler / githubweb
Removed unused import [-Wunused-variable] — isenfireldc / githubweb
Removes unused function calc_cloud_frac [-Wunused-function] — isenfireldc / githubweb
Fixes style issue — isenfireldc / githubweb
Removed import without only as it was unused — isenfireldc / githubweb
Adds mpishorthand back with only, it appears to be used somewhere — isenfireldc / githubweb
I have pared two subprograms down to one again, this time for the — bmg2 / githubweb
I pared down subprogram pairs again, this time for mean advection. — bmg2 / githubweb
I added altitude_threshold to the list of CLUBB's tunable parameters. — bmg2 / githubweb
Updating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots. — strike / githubweb
Updating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be). — strike / githubweb
Adds more debug lines — isenfireldc / githubweb
Removes debug lines — isenfireldc / githubweb
Adds debug lines and changes format — isenfireldc / githubweb
Modifies debug line — isenfireldc / githubweb
Modifies debug line — isenfireldc / githubweb
Initialize ncf%ntimes to 0 when opening netcdf for writing — isenfireldc / githubweb
Removes debug lines — isenfireldc / githubweb
Changes length of units variable in stat_file_module from 20 to 25 — isenfireldc / githubweb
This commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true. A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines. — benjamin.andrew.stephens / githubweb
Adding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close. This will aid in implementing the SILHS 2D output subroutines in host models. The new API subroutines necessitated some minor changes in clubb_driver.F90 as well. Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo). — benjamin.andrew.stephens / githubweb
I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
Undoing accidental find and replace. larson-group/cam#129 — Gunther Huebler / githubweb
Updated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832 — nchief / githubweb
Fix super serious 1 character bug that broke all of the things — strike / githubweb
I am committing Zhun's changes to the CLUBB portion of his — bmg2 / githubweb
Update stats_zm_module.F90 — noreply / githubweb
I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max — bmg2 / githubweb
I connected the new tunable parameters to advance_helper_module.F90. — bmg2 / githubweb
I added l_use_shear_Richardson to CLUBB's configurable model flags. — bmg2 / githubweb
Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs. — benjamin.andrew.stephens / githubweb
In order to prevent dycoms2_rf02_so from crashing, — Vince Larson / githubweb
I updated the recording of the budget terms for upwp_pr4 and vpwp_pr4. — Vince Larson / githubweb
Adding the smooth_min and smooth_max functions to the repo. These are not yet implemented in CLUBB but are now available for use and testing. See issue #894. — benjamin.andrew.stephens / githubweb
Adding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions. See issue #894. — benjamin.andrew.stephens / githubweb
Modifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129 — Gunther Huebler / githubweb
This commit replaces division by tau with multiplication by inverse tau in most cases. It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files. Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine. — benjamin.andrew.stephens / githubweb
I am committing a bug fix to the invrs_tau_zm equation that was — bmg2 / githubweb
CLUBB and pyplotgen changes: — benjamin.andrew.stephens / githubweb
I fixed the LMM stepping bug that was affecting E3SM (because — bmg2 / githubweb
Fixed alignment. — bmg2 / githubweb
This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90. — benjamin.andrew.stephens / githubweb
Update parameter_indices.F90 — noreply / githubweb
Update model_flags.F90 — noreply / githubweb
Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884. — benjamin.andrew.stephens / githubweb
Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901. — benjamin.andrew.stephens / githubweb
I am now passing vert_decorr_coef into SILHS instead of involving — bmg2 / githubweb
This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39). Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before. I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up). — benjamin.andrew.stephens / githubweb
Adding a test to make sure new C_uu_buoy parameter is within the valid range. See #901. — benjamin.andrew.stephens / githubweb
This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. — benjamin.andrew.stephens / githubweb
This will allow for a better interface of SILHS parameter — bmg2 / githubweb
Fixed a preprocessor command. — bmg2 / githubweb
I'm adding the api entry for read_silhs_parameters, called — bmg2 / githubweb
Revert "I'm adding the api entry for read_silhs_parameters, called" — bmg2 / githubweb
Revert "Fixed a preprocessor command." — bmg2 / githubweb
Revert "This will allow for a better interface of SILHS parameter" — bmg2 / githubweb
I updated silhs_api_module so that vert_decorr_coef is publically available — bmg2 / githubweb
Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902. — benjamin.andrew.stephens / githubweb
Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. — benjamin.andrew.stephens / githubweb
Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129 — Gunther Huebler / githubweb
Update parameters_tunable.F90 — noreply / githubweb
Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129 — Gunther Huebler / githubweb
Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129 — Gunther Huebler / githubweb
Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902. — 59519056+bstephens82 / githubweb
Turning on wp3 pr_turb term. — benjamin.andrew.stephens / githubweb
Changed the variable up2_vp2_factor to up2_sfc_coef in all files — rhodesk / githubweb
I added an option to improve dry, convecting boundary layers. — Vince Larson / githubweb
This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2. In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1. This makes the terms in these equations more consistent with the terms in the wp2 equation. I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped). — Vince Larson / githubweb
Changed surface to sfc in all instances where requested — rhodesk / githubweb
Undid sfc change in stats_sfc_module.F90 — noreply / githubweb
Undid sfc change to grid_class.F90 — noreply / githubweb
Undid sfc change in numerical_check.F90 — noreply / githubweb
Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129 — Gunther Huebler / githubweb
Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Fixed typo bug. larson-group/cam#129 — Gunther Huebler / githubweb
Pushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
More pushing loops down. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Adding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129 — Gunther Huebler / githubweb
More loop pushing, all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions. — Gunther Huebler / githubweb
Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled. — Gunther Huebler / githubweb
Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129 — Gunther Huebler / githubweb
Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Performance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Reducing operations. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Adding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Some small cleanup, all just formatting. larson-group/cam#129 — Gunther Huebler / githubweb
Changed ustar from an array to a scalar issue #909 — rhodesk / githubweb
Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909 — rhodesk / githubweb
Created new subroutine and ensured it's BFB. All cases run sucessfully #909 — rhodesk / githubweb
added in missing flag which was causing memory errors #909 — rhodesk / githubweb
confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909 — rhodesk / githubweb
Update stats_zm_module.F90 — noreply / githubweb
Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129 — Gunther Huebler / githubweb
Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129 — Gunther Huebler / githubweb
Reformatted mixing length to be more compliant with the coding standard #909 — rhodesk / githubweb
added a reference to new subroutine #909 — rhodesk / githubweb
Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
Pushing loops related to pdf_params down. larson-group/cam#129 — Gunther Huebler / githubweb
clubb warnings introduced from merge have been removed #909 — rhodesk / githubweb
Changed safeguard threshold in sigma_sqd_w. — rhodesk / githubweb
Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. — 59519056+bstephens82 / githubweb
Adding new coefficient to control the wp3 pressure diffusion term. — 59519056+bstephens82 / githubweb
Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. — 59519056+bstephens82 / githubweb
Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. — 59519056+bstephens82 / githubweb
Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). — 59519056+bstephens82 / githubweb
These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. — 59519056+bstephens82 / githubweb
Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. — 59519056+bstephens82 / githubweb
Added intent comments for the following files: — rhodesk / githubweb
Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core. Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs). This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated. — benjamin.andrew.stephens / githubweb
Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90. — benjamin.andrew.stephens / githubweb
Fixed comment regarding wp3 splatting term. — benjamin.andrew.stephens / githubweb
Added intent comments. — rhodesk / githubweb
Added intent comments. — rhodesk / githubweb
Added intent comments for advance_xp2_xpyp_module.F90. — rhodesk / githubweb
Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface. — 59519056+bstephens82 / githubweb
Deleting comments around the old "magic number" for the near-surface clipping. — 59519056+bstephens82 / githubweb
Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928. — Gunther Huebler / githubweb
Changed some elements of clubb to allow for better script execution — rhodesk / githubweb
Fixed clubb not compiling — rhodesk / githubweb
Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
Reverted changes to clubb_api. For #886 — rhodesk / githubweb
Replacing use gr statements with feeding gr throught the arg list. — rhodesk / githubweb
Adding proper indentation to needed files. — rhodesk / githubweb
Fixing spacing issue on blank lines. #886 — rhodesk / githubweb
Fixed comment changes. #886 — rhodesk / githubweb
Fixed incorrect spacing on use — rhodesk / githubweb
Revert "Fixed incorrect spacing on use" — rhodesk / githubweb
Fixed spacing — rhodesk / githubweb
Fixed spacing going too far — rhodesk / githubweb
Fixed comments being pushed over — rhodesk / githubweb
Fixed not all variables being indented properly — rhodesk / githubweb
Fixed indentation going beyond variables — rhodesk / githubweb
Fixed file_functions indentation being off — rhodesk / githubweb
Fixed indentation on operations being wrong — rhodesk / githubweb
Reverted incorrect changes to new_pdf and new_hybrid_pdf — rhodesk / githubweb
Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
Removing gr as a module variable from grid_class. — rhodesk / githubweb
Removing gr as a module variable from grid_class. — rhodesk / githubweb
Fixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format. — benjamin.andrew.stephens / githubweb
Fixing a typo from an earlier commit. — noreply / githubweb
Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB. — rhodesk / githubweb
The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken. — rhodesk / githubweb
Add error header for CLUBB in CAM — noreply / githubweb
Fixing the ordering of gr in the clubb_api arg list for affected subroutines. — rhodesk / githubweb
Fixing coding standard violations — rhodesk / githubweb
Improving error messages in setup_clubb_core. larson-group/e3sm#38 — Gunther Huebler / githubweb
Feeding stats variables through the argument lists of needed subroutines. — 72510114+RhodesKeegan / githubweb
Fixing spacing issues along with placing the stats varibales on their own lines. — 72510114+RhodesKeegan / githubweb
Changing more subroutines to include stats vars in their arg lists. — 72510114+RhodesKeegan / githubweb
Fixing incorrect subroutine arg list — 72510114+RhodesKeegan / githubweb
Fixing host models not compiling. — 72510114+RhodesKeegan / githubweb
Fixing argument list so that way the coding standard is upheld. — 72510114+RhodesKeegan / githubweb
I changed the name to calc_responder_driver because I thought that — bmg2 / githubweb
Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920. — 59519056+bstephens82 / githubweb
Fixing comment for the wp2_term_pr_dfsn subroutine. Related to #920. — 59519056+bstephens82 / githubweb
Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. — 59519056+bstephens82 / githubweb
Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920. — 59519056+bstephens82 / githubweb
Fixing some comments. — 59519056+bstephens82 / githubweb
Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. — benjamin.andrew.stephens / githubweb
Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. — 59519056+bstephens82 / githubweb
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. — 59519056+bstephens82 / githubweb
Removing l_interp_prescribed_params from setup_clubb_pdf_params. — rhodesk / githubweb
Adding comments labeling subroutine calls with intent. — rhodesk / githubweb
Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
Removing unnecessary constant from use statement — noreply / githubweb
Eliminating l_nu_grid_dependent as requested. — rhodesk / githubweb
Eliminating l_use_buoy_mod_Km_zm. — rhodesk / githubweb
Eliminating l_iter_xp2_xpyp flag. — rhodesk / githubweb
Eliminating l_apply_rule_to_pdf_params flag. — rhodesk / githubweb
Eliminating l_ub_const_deriv flag. — rhodesk / githubweb
Eliminating l_equation_21 flag. — rhodesk / githubweb
Eliminating l_wp3_2nd_buoyancy flag. — rhodesk / githubweb
Eliminating l_refine_grid_in_cloud and l_interactive_refined. — rhodesk / githubweb
Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds — rhodesk / githubweb
Eliminating l_use_wp3_pr3 flag. — rhodesk / githubweb
Eliminating l_clip_semi_implicit flag. — rhodesk / githubweb
Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
Eliminating l_include_ice and sat_ice_ratio. — rhodesk / githubweb
Eliminating l_update_pressure flag. — rhodesk / githubweb
Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
Updating the surface clipping coefficient... — noreply / githubweb
Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb
Removing a couple of unused parameters from use statement. — noreply / githubweb
Pushing k loop down through clip_variance_level. — rhodesk / githubweb
Udpates to make it possible for us to keep certain parameters equal to each other during tuning. — 59519056+bstephens82 / githubweb
Further tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included. — 59519056+bstephens82 / githubweb
Updating some comments related to the tuner updates. — 59519056+bstephens82 / githubweb
I have passed clubb_params down into advance_xm_wpxp_module.F90. — bmg2 / githubweb
Adding space to trigger autoupdate. larson-group/sys_admin#755 — Gunther Huebler / githubweb
Remove space to trigger autoupdate. larson-group/sys_admin#755 — noreply / githubweb
Add space to trigger nightly tests. For larson-group/sys_admin#755. — noreply / githubweb
See ticket — jan.gruenenwald / githubweb
I am fixing a bug that was introduced in 6b0348e, where the logical — bmg2 / githubweb
I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. — bmg2 / githubweb
added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — jan.gruenenwald / githubweb
Updates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example. — 59519056+bstephens82 / githubweb
Changing the name of dummy_1d variables for clarity. — 59519056+bstephens82 / githubweb
I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 — bmg2 / githubweb
Add a blank line to trigger nightly tests. — noreply / githubweb
Passing down more of CLUBB's tunable parameters. — bmg2 / githubweb
I accidentally removed an important comment in the previous commit. — bmg2 / githubweb
Passing down more CLUBB tunable parameters. — bmg2 / githubweb
More passing down CLUBB parameters ... whoop-de-doo — bmg2 / githubweb
Passing down more tunable parameters and removing references to — bmg2 / githubweb
Removing line to trigger the nightly tests for all repos. — noreply / githubweb
See respective messages on the issue 958 on date 10/12/2021 — jan.gruenenwald / githubweb
Handling the abomination that is lmin. — bmg2 / githubweb
Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b. — benjamin.andrew.stephens / githubweb
Passing tunable parameters into the new tau code. — bmg2 / githubweb
Passed down more parameters. Results are bit-for-bit. — bmg2 / githubweb
Passing through more clubb parameters. Bit-for-bit — bmg2 / githubweb
Passing down CLUBB's tunable parameters into the setup_pdf_parameters and — bmg2 / githubweb
These updates incorporate some of Shixuan Zhang's changes, including: — benjamin.andrew.stephens / githubweb
Passing down CLUBB's tunable parameters into the remainder of the — bmg2 / githubweb
I passed down the forgotten thlp2_rad_coef tunable parameter. — bmg2 / githubweb
Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. — benjamin.andrew.stephens / githubweb
I am passing down the forgotten parameter, altitude threshold, in — bmg2 / githubweb
Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920. — 59519056+bstephens82 / githubweb
Updates as requested to the l_use_tke_in_K_dfsn code: — 59519056+bstephens82 / githubweb
I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
Adding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b. — 59519056+bstephens82 / githubweb
Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. — 59519056+bstephens82 / githubweb
Adding comments for clarity. — 59519056+bstephens82 / githubweb
I forgot to add this necessary subroutine call to the clubb API. — bmg2 / githubweb
Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms. — benjamin.andrew.stephens / githubweb
I have turned the nu_vert_res_dep family of variables into a derived — bmg2 / githubweb
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — jan.gruenenwald / githubweb
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — jan.gruenenwald / githubweb
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — jan.gruenenwald / githubweb
fixed a typo in pdf_closure_module.f90, line 1284 — jan.gruenenwald / githubweb
See ticket — 68997723+JanGrn / githubweb
added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — 68997723+JanGrn / githubweb
See respective messages on the issue 958 on date 10/12/2021 — 68997723+JanGrn / githubweb
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — 68997723+JanGrn / githubweb
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — 68997723+JanGrn / githubweb
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — 68997723+JanGrn / githubweb
fixed a typo in pdf_closure_module.f90, line 1284 — 68997723+JanGrn / githubweb
Passing w_up_in_cloud out of advance_clubb_core — bmg2 / githubweb
fixed compiler warning regarding w_up_in_cloud — jan.gruenenwald / githubweb
Remove clipping from a3_coef. — noreply / githubweb
These changes allow you to call the 4 clubb "advance" subroutines in any — Brian Griffin / githubweb
Placing the order variables in a nice, convenient place for testing use. — Brian Griffin / githubweb
I reordered advance_clubb_core so that the "Advance xp3" (which is a — Brian Griffin / githubweb
I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx — Brian Griffin / githubweb
I am indenting the portion of the code where the advance subroutines — Brian Griffin / githubweb
Temporarily commenting out the idiot proofing in order to run some tests ... — Brian Griffin / githubweb
Now official reinstating the idiot-proofing and turning off the — bmg2 / githubweb
I am committing some idiot proofing in regards to the advance — bmg2 / githubweb
Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. — bmg2 / githubweb
Now that uprcp and vprcp have been passed through advance_clubb_core, — bmg2 / githubweb
I am adding more arguments to the argument list for advance_clubb_core — bmg2 / githubweb
Insert print about overwriting default flags with namelist values — noreply / githubweb
Insert print about overwriting default parameters with namelist values — noreply / githubweb
Making api version of setup_grid. larson-group/clubb#972 — Gunther Huebler / githubweb
Making some paramters_silhs variables available from the silhs api — Gunther Huebler / githubweb
Comment out setting of fatal error — noreply / githubweb
This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. — Gunther Huebler / githubweb
Changing the value of C_invrs_tau_shear from 0.02 to 0.15. — bmg2 / githubweb
Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. — Gunther Huebler / githubweb
Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that — bmg2 / githubweb
Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm — noreply / githubweb
Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 — Gunther Huebler / githubweb
Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 — Gunther Huebler / githubweb
Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 — Gunther Huebler / githubweb
Breaking up column loop in advance_clubb_core. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence — bmg2 / githubweb
Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 — Gunther Huebler / githubweb
Making a commit that officially places the call to the PDF in the "post" — bmg2 / githubweb
Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 — Gunther Huebler / githubweb
Forgot an & symbol. — Gunther Huebler / githubweb
We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 — Gunther Huebler / githubweb
I am updating ice_supersat_frac to be an intent(inout) variable for — bmg2 / githubweb
Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 — Gunther Huebler / githubweb
Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing column index into zm2zt and zt2zm. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 — Gunther Huebler / githubweb
A variety of small loop pushing. larson-group/clubb#972 — Gunther Huebler / githubweb
Fixed small bug that slipped through because the G_unit tests use nz=1. — Gunther Huebler / githubweb
Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 — Gunther Huebler / githubweb
I added a subroutine that prints that values of all PDF parameters in — bmg2 / githubweb
Small changes and a loop push. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing loop into advance_xm_wpxp. larson-group/clubb#972 — Gunther Huebler / githubweb
Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 — Gunther Huebler / githubweb
Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing column loop into local functions. larson-group/clubb#972 — Gunther Huebler / githubweb
Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing. — Gunther Huebler / githubweb
Adding 2D version of zt2zm and zm2zt to clubb_api — Gunther Huebler / githubweb
Pushing loop into solve_xm_wpxp_with_single_lhs (#986) — noreply / githubweb
Refactoring to remove need for global stats scratch variables. (#988) — noreply / githubweb
Gunthers branch (#989) — noreply / githubweb
Fixing small bug that breaks runs with scalars. — Gunther Huebler / githubweb
Implementations of smooth min, max and heaviside function. Added G-Unit tests — 68997723+JanGrn / githubweb
Making setup_pdf_parameters accept ngrdcols size arrays of stats and grid types. — Gunther Huebler / githubweb
Forgot two small changes. larson-group/cam#129 — Gunther Huebler / githubweb
Removing need for data copies. larson-group/cam#129 — Gunther Huebler / githubweb
Changing column loop index from j to i. larson-group/cam#129 — Gunther Huebler / githubweb
Making compatible with latest clubb change. — Gunther Huebler / githubweb
Removing data copies that we don't need anymore. This still runs correctly on GPUs. — 37674341+huebleruwm / githubweb
Making clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible. — 37674341+huebleruwm / githubweb
No more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols. — 37674341+huebleruwm / githubweb
Raw-copy updating components/eam/src/physics/silhs — LarsonGroupSysAdmin / githubweb
Adds a blank line to trigger git merge with E3SM — noreply / githubweb
Removes a blank line in order to trigger merge with E3SM — noreply / githubweb
Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
Replacing the i loop iterator for scalars with sclr. — 37674341+huebleruwm / githubweb
Pushing loop into advance_xp2_wpxp. — 37674341+huebleruwm / githubweb
Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats. — 37674341+huebleruwm / githubweb
Moving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call. — 37674341+huebleruwm / githubweb
Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way. — 37674341+huebleruwm / githubweb
Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn. — 37674341+huebleruwm / githubweb
Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp. — 37674341+huebleruwm / githubweb
Changing Carson compiler definition to work for the Carson nightly tests. larson-group/sys_admin#763 — pbroels / githubweb
I added l_relax_clipping to CLUBB's config flags. — bmg2 / githubweb
Added the l_enable_relaxed_clipping interface to E3SM-CLUBB — bmg2 / githubweb
Added a3_coef_min to the list of CLUBB's tunable parameter and then — bmg2 / githubweb
Adding CLUBB's new a3_coef_min tunable parameter to the E3SM-CLUBB code. — bmg2 / githubweb
Adding e3smClubbCodeCopy.bash to the jenkins directory for testing Clubb changes. larson-group/sys_admin#768 — pbroels / githubweb
Added idiot-proofing to print a warning message when l_diag_Lscale_from_tau — bmg2 / githubweb
Updating the call to setup_clubb_core_api based on new CLUBB — bmg2 / githubweb
Breaking up column loop in clubb_tend_cam. — Gunther Huebler / githubweb
Commenting out sponge damping code. This is BIT_CHANGING. — Gunther Huebler / githubweb
This fixes a bug that was exposed when we switched to having pdf closure in the post position. pdf_params_chnk is the structure that keeps track of the pdf_params each timestep, and the single_col version is only a local variable we use to get pdf_params from clubb then save them into the chnk version. But we were not copying from the chnk version into the single_col version before calling clubb, so when pdf_closure is done in post, we had incorrect pdf_params as input. This is BIT_CHANGING. This will also be deleted in the next commit, it is mostly symbolic just to demonstrate what exactly the problem was. — Gunther Huebler / githubweb
Making clubb_tend_cam use the multi column version of clubb. This is bit-for-bit. — Gunther Huebler / githubweb
I added the code for the l_linearize_pbl_winds flag that was originally — bmg2 / githubweb
Updating E3SM for the latest version of CLUBB. — bmg2 / githubweb
Fixing small bug. This wasn't answer changing, but would cause a crash if we turned bound checking debug flags on. — Gunther Huebler / githubweb
Gunthers branch (#996) — noreply / githubweb
Adding in the jenkins file and updating names for the copy test. — pbroels / githubweb
Renaming directory to be consistant with other repos. — pbroels / githubweb
Various simple changes to improve performance. All bit-for-bit. — Gunther Huebler / githubweb
Pushing loop into calc_stability_correction. — Gunther Huebler / githubweb
Small bug fix. — Gunther Huebler / githubweb
Another similar small bug fix. — Gunther Huebler / githubweb
Adding in comments to explain confusing parts of the Jenkinsfiles. — pbroels / githubweb
Gunthers branch (#999) — noreply / githubweb
Renamed smth_range to heaviside_smth_range — 68997723+JanGrn / githubweb
Added tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes. — 68997723+JanGrn / githubweb
Implemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0. — 68997723+JanGrn / githubweb
Changed priorities of total normalized variation stats, included error handling in total normalized variation stats. — 68997723+JanGrn / githubweb
Renamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls. — 68997723+JanGrn / githubweb
Gunthers branch 2 (#1002) — noreply / githubweb
Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail. — 68997723+JanGrn / githubweb
Added ability to apply smooth min max functions in mixing_length.F90 — 68997723+JanGrn / githubweb
Updated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
Checked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
Added test cases to smooth_min_max_tests.F90 and updated documentation. — 68997723+JanGrn / githubweb
Made an update to use an optional (false by default) seasonal — bmg2 / githubweb
Added a E3SM diags run script that is set up for model vs. model — bmg2 / githubweb
Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4. — benjamin.andrew.stephens / githubweb
Almost final loop pushes (#1012) — noreply / githubweb
Making compatible with latest clubb change. — Gunther Huebler / githubweb
Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) — noreply / githubweb
The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. — Gunther Huebler / githubweb
Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version. — Gunther Huebler / githubweb
Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). — Gunther Huebler / githubweb
Making compatible with latest clubb change. — Gunther Huebler / githubweb
Making 2D versions of setup_grid and setup_parameters. — Gunther Huebler / githubweb
Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value. — Gunther Huebler / githubweb
Making compatible with latest clubb change. — Gunther Huebler / githubweb
Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types. — Gunther Huebler / githubweb
Making compatible with latest clubb change. — Gunther Huebler / githubweb
Fixing small bug preventing compilation. — Gunther Huebler / githubweb

#65 (Mar 9, 2022, 3:14:49 PM)

Making e3sm compatible with latest clubb updates. larson-group/clubb#972 — Gunther Huebler / githubweb
Changing log display steps to fit the new logs put out during the test. Also changed the ne4 test to display logs in the post step. — pbroels / githubweb

#64 (Mar 2, 2022, 5:13:18 PM)

Populating the samxx code. It passes standalone tests. — hannah6 / githubweb
Adding YAKL submodule — hannah6 / githubweb
YAKL fix — hannah6 / githubweb
Making it clear that cub is a library and defaulting it to the home directory. Getting rid of stale information from older README — hannah6 / githubweb
Working toward adding -crm samxx as an option — hannah6 / githubweb
samxx and yakl are building. Working through decoupling crm_physics and sam still. — hannah6 / githubweb
Forgot to add params_kind.F90 — hannah6 / githubweb
The model builds with samxx on the CPU now — hannah6 / githubweb
Changed sam/ interface to pass cam physics data in rather than accessing from sam/. samxx is still giving the wrong answer (evidenced by complaints in e3sm log). I need to find what's different between the tests and the runs — hannah6 / githubweb
Working to get the samxx fortran baseline the same as the sam/ fortran code — hannah6 / githubweb
Working to get the samxx fortran baseline the same as the sam/ fortran code — hannah6 / githubweb
Working to get the samxx fortran baseline the same as the sam/ fortran code — hannah6 / githubweb
Using original FFTs. standalone has machine precision similarity — hannah6 / githubweb
Fix F-MMFXX compset — hannah6 / githubweb
Working on a hardwired approach to GPU for now. As always, CMake is a dumpster fire. — hannah6 / githubweb
restricting new stuff to when gnugpu is used — hannah6 / githubweb
CUDA build works currently. Simulation seems to run successfully. Answer looks good. — hannah6 / githubweb
Add comments, wrap CUDA_FLAGS sm_70 in a test for the summit machine — hannah6 / githubweb
Found a nicer way to specify CUDA and CUDA_FLAGS through config_compilers.xml — hannah6 / githubweb
A change to how USE_CUDA is set to PARENT_SCOPE in CMakeLists.txt — hannah6 / githubweb
Removing a few duplicate summit gnugpu entries in config_compilers.xml. Also, moving the crm_ecpp_output_module.F90 file into sam and samxx separately. This breaks compilation, but I can't figure out why. — hannah6 / githubweb
Fixing the compilation bug. samxx is no longer trying to compile crm_ecpp_output_module.F90 and is leavng it to the libatm.a build instead. — hannah6 / githubweb
retabbing source files — hannah6 / githubweb
Using clang-format on the C++ code in samxx — hannah6 / githubweb
Revert "Using clang-format on the C++ code in samxx" — hannah6 / githubweb
using clang-format without all the submodules problems from before — hannah6 / githubweb
Revert "using clang-format without all the submodules problems from before" — hannah6 / githubweb
Reducing line length for samxx files — hannah6 / githubweb
better comment for MSA in crm_physics.F90 — hannah6 / githubweb
Apply MMF aerosol optics changes to samxx — hannah6 / githubweb
Adjust ifdefs to fix odd build error — hannah6 / githubweb
Fix build errors — whannah1 / githubweb
Add averaging step for crm_clear_rh — whannah1 / githubweb
Update mpas-source: fixes sea ice melt bug — akt / githubweb
Add semi-colon — whannah1 / githubweb
Fixing a build issue with non-CUDA builds — whannah1 / githubweb
Homme: Fix number of levels in SL trajectory DSS. — ambradl / githubweb
typo fix — whannah1 / githubweb
Homme: Grid total area diagnostic data in simulations. — ambradl / githubweb
Homme: Fix a performance bug in boundary exchange. — ambradl / githubweb
Rename clm testmods to elm — jacob / githubweb
Rename clm to elm in CIME — jacob / githubweb
Address PR comments — hannah6 / githubweb
Add activeTracerHorMixTendency to the timeSeriesStatsMonthlyOutput stream — jonbob / githubweb
Address more PR comments — hannah6 / githubweb
update mpas-source: compass only — mpetersen / githubweb
Homme: fix cmake warning when homme is built without pio support. — lbertag / githubweb
fates-nutrients: added site level mass balance tracking to phosphatase driven p uptake by plants. Cleaned up interface routines and where they call some routines from — rgknox / githubweb
Update CIME submodule again — jgfouca / githubweb
Update mpas-source: compiler flag changes — mpetersen / githubweb
Add CIME src path for MPAS builds — azamat / githubweb
add dam construction year for transient runs — tian.zhou / githubweb
small change — tian.zhou / githubweb
Fixes default compute interval for heat budget — luke.vanroekel / githubweb
Update mpas-source: fix landIceMask bug — mturner / githubweb
Fix format error — jonbob / githubweb
Homme: set default value for USE_MPIEXEC — lbertag / githubweb
Homme: correctly link to scorpio/scorpio_classic when building with pio support — lbertag / githubweb
Homme: remove un-needed (and problematic) deps in share_kokkos_ut — lbertag / githubweb
Homme: bug fix in col_ops_ut [packed reduction] — lbertag / githubweb
Replace CLM with ELM in allactive compsets — jacob / githubweb
Change CLM to ELM in config_pesall — jacob / githubweb
Replace CLM with ELM in F-cases — jacob / githubweb
Fix clear air RH variables in samxx — whannah1 / githubweb
Update mpas-source: bugfix 3rd order advection coeff — mturner / githubweb
Fixing machine files to automatically add -DYAKL_DEBUG to CXXFLAGS for debug runs, fix for debugging symbols and for duplicate CUDA flags — normanmr / githubweb
Homme: build homme_tool tests only if tool is enabled. — lbertag / githubweb
Update MMF tests — hannah6 / githubweb
Homme: fix random initialization of HybridVCoord — lbertag / githubweb
Homme: fix to TeamUtils, to accommodate league_size=0 — lbertag / githubweb
Update mpas-source submodule with updated MALI code — mhoffman / githubweb
Initial commits to support the mpas.gis1to10km mesh in a tri-grid configuration — mhoffman / githubweb
Change IG compset definition to use FO-MALI instead of SIA-MALI — mhoffman / githubweb
Replace albany_input.xml file with yaml version — mhoffman / githubweb
Update albany_input.yaml to use tpetra/MueLu — mhoffman / githubweb
Update version of Albany used by MALI on Cori — mhoffman / githubweb
Update logic for MALI_DYNAMIC to reflect True/False values — mhoffman / githubweb
Make MALI_DYNAMIC options uppercase — mhoffman / githubweb
Make A_BGWCYCL1850 compset use FO MALI — mhoffman / githubweb
Update namelist scripts to correspond to changes to Registry — mhoffman / githubweb
Update fsurdat for r05 grid at sim_year 2000 — mhoffman / githubweb
update albany_input.yaml file — mhoffman / githubweb
Change MALI input file for mpas.gis1to10km resolution — mhoffman / githubweb
Comment out option to write out Albany exo files by default. — mhoffman / githubweb
Script changes to allow input file and decomp files have different dates — mhoffman / githubweb
Make BG and IG compsets used Static MALI (but with Albany build) — mhoffman / githubweb
Disable calving in MALI by default — mhoffman / githubweb
Modify IGCLM45_MLI compset to use SIA — jonbob / githubweb
Checkout from master to reod the rebase — jonbob / githubweb
Update fsurdat for r05 grid at sim_year 2000 — jonbob / githubweb
Add last datafile changes to support new MALI implementation — jonbob / githubweb
fixed a bug in the previous commit related to incloud -> grid-mean conversion — kai.zhang / githubweb
Homme: Removed HOMMEXX_GB_CONFIG CPP logic — lbertag / githubweb
updated clubbv2 — zheng7 / githubweb
HOMME: update dirk weights in tstep 10 in theta-l_kokkos target — lbertag / githubweb
Another update — jgfouca / githubweb
Upgraded kokkos version to 3.2, and adjusted e3sm cmake logic — lbertag / githubweb
This fix is to address Wuyin's comments on the overall consistency between in-cloud & — kai.zhang / githubweb
fixing negative reservoir storage bug — tian.zhou / githubweb
Exclude default paths when looking for kokkos — lbertag / githubweb
Handling the C++14 requirement for yakl and samxx — normanmr / githubweb
Update MPAS-Source: Rayleigh damping fix and continuation line — mpetersen / githubweb
Updated LUT for alignment between iESM and ELM — gautam.bisht / githubweb
Updated comments for LUT v2 — gautam.bisht / githubweb
Increased precision of calculations and outputs — gautam.bisht / githubweb
Updated Makefile to help with compilation on Cori and Compy — gautam.bisht / githubweb
Updated makefile and cleaned up some precision issues — gautam.bisht / githubweb
Added high-precision rounding to stabilize outputs across machines — gautam.bisht / githubweb
Also rounding the harvest outputs — gautam.bisht / githubweb
Turned off debug output for default — gautam.bisht / githubweb
Added additional make message in Makefile — gautam.bisht / githubweb
Updated 1850 and 2015 initial file mcrop names in code — gautam.bisht / githubweb
Update run example to include current input file directory — gautam.bisht / githubweb
Updated land use translator to more easily do different scenarios — gautam.bisht / githubweb
Updated mksurfdata tools for new LUT — gautam.bisht / githubweb
Updated namelist defaults for mksrf_vegtyp — gautam.bisht / githubweb
Update clm namelist definition to include new land surface file rcp tags — gautam.bisht / githubweb
Updated the default historical file name — gautam.bisht / githubweb
rename WRMUnit%active to WRMUnit%active_stage — tian.zhou / githubweb
Changed kokkos version used for submodule — lbertag / githubweb
HOMME: Removed pointless macro link_to_kokkos — lbertag / githubweb
HOMME: fix Kokkos error in debug mode on Cuda — lbertag / githubweb
I updated the version of CLUBB and SILHS used in this NGD CLUBB SILHS branch — bmg2 / githubweb
Upload some modifications which allow better LBA. — bmg2 / githubweb
Upgrade budgets numlib and numice, as well as the diagnostic package. — bmg2 / githubweb
We added a simple detrainment scheme in clubb_intr.F90, in order to reduce SWCF over storm tack. — bmg2 / githubweb
Normal update of diagnostic_v2_0. — bmg2 / githubweb
change clubb_ipdf_call_placement — zheng7 / githubweb
Commit for newbase run. issue #18 — bmg2 / githubweb
Commit for newbase. We added a conserved detrainment code, snowfrc=0.1, rhmini=0.8. #18 — bmg2 / githubweb
In order to limite the tunable parameters, we changed the advance_clubb_core_module.F90 and run scritp. We can repeat the result of [caseB](https://carson.math.uwm.edu/larson-group/internal/E3SM_Global_output/output-20200316/) — bmg2 / githubweb
Change a magic number of altitude_threshold, it allows a deeper mixing layer. issue #18 — bmg2 / githubweb
We increase `altitude_threshold` from 100 to 300m that makes a deeper mixing layar and solves fog problems over stratocumuls regimes. Issue #18. — bmg2 / githubweb
This commit can repeat simulation B, in https://github.com/larson-group/E3SM/issues/18#issuecomment-622158613 — bmg2 / githubweb
I fixed a bug of PDF_PARAMS_FRZ. issue #18 — bmg2 / githubweb
git sucks — bmg2 / githubweb
Adds E3SM support for MPAS-Ocean/Sea-ice grid ECwISC30to60E1r2. — dcomeau / githubweb
Adding JRA support to ECwISC30to60E1r2 grid — dcomeau / githubweb
Correcting paths for mapping files — dcomeau / githubweb
Create draw_micro_budget.py — bmg2 / githubweb
Update CLUBB's Diagnostic Pack — bmg2 / githubweb
Update E3SM_CLUBB_diag.py — bmg2 / githubweb
Update MPAS-Source: COMPASS and documentation only — mpetersen / githubweb
clean up unnecessary comments — zheng7 / githubweb
We added a new formula for [invrs_tau_xp2](https://github.com/larson-group/E3SM/issues/18#issuecomment-636089345). The results of this commit is shown [here](https://github.com/larson-group/E3SM/issues/18#issuecomment-638331975). — bmg2 / githubweb
Finishing off the previous cherry-pick/merge. — bmg2 / githubweb
This commit can reproduce simulation C in https://github.com/larson-group/E3SM/issues/18#issuecomment-640086590. — bmg2 / githubweb
We tuned tau and its equations. This tuning has better ITCZ and a stronger contrast between SC and CU. Results is shown in D of https://github.com/larson-group/E3SM/issues/18#issuecomment-640708110 — bmg2 / githubweb
Script support for new EC30to60E2v2 ocean mesh — jonbob / githubweb
Update function_cal_mean.py — bmg2 / githubweb
update function_cal_mean.py for handling muli year — bmg2 / githubweb
Update E3SM_CLUBB_diag.py — bmg2 / githubweb
Update function_cal_mean.py — bmg2 / githubweb
Update function_pick_out.py — bmg2 / githubweb
We make a new Richardson related formula for invrs_tau_wpxp, in order to remove the `5`. This change makes a good distinction between CU and SC, result can be found in D of [plots](https://github.com/larson-group/E3SM/issues/18#issuecomment-657628303). — bmg2 / githubweb
Update CLUBB's diagnostic package. Now, making average for multiple years is allowed. Please set `nyear` in E3SM_CLUBB_diag.py. — bmg2 / githubweb
Clean up the codes of tau and Richardson number. issue #18 — bmg2 / githubweb
For EAM_tau and ZM. Issue #18 — bmg2 / githubweb
A run script for running tau and ZM. Issue #18 — bmg2 / githubweb
Clean up. — bmg2 / githubweb
EAM_tau_silhs run script. — bmg2 / githubweb
Repeat https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.zguo/eam_tau.n2p3_c151_pre1_fallp25_sgv_1d/ — bmg2 / githubweb
Remaping the SE to Lat-Lon — bmg2 / githubweb
Updating function_cal_mean.py to match exactly what is in Zhun's — bmg2 / githubweb
Run script for making global IOP files. — bmg2 / githubweb
Back to no-sgv run. — bmg2 / githubweb
Update Readme — bmg2 / githubweb
I modified the run_silhs_anvil_gust.csh runscript so that it runs — bmg2 / githubweb
I am adding the files necessary to run the AMWG postprocessing scripts on — bmg2 / githubweb
Within the context of my NGD CLUBB SILHS directory, I have changed the names, — bmg2 / githubweb
I committed some changes to my personal NGD CLUBB SILHS directory to set up — bmg2 / githubweb
I also changed the ne30 remapping file in my NGD CLUBB SILHS branch — bmg2 / githubweb
I added the environment file and run script for E3SM diags. — bmg2 / githubweb
I am also changing these remapping files over to my directory paths. — bmg2 / githubweb
Minor changes to postprocessing files. — bmg2 / githubweb
I updated E3SM to match recent changes made to CLUBB code. — bmg2 / githubweb
I removed l_use_ice_latent from the code, following recent changes to CLUBB. — bmg2 / githubweb
I am updating clubb_intr.F90 and subcol_SILHS.F90 based on recent — bmg2 / githubweb
I am updating E3SM-CLUBB for the addition of the l_partial_upwind_wp3 flag — bmg2 / githubweb
I altered the call to setup_pdf_parameters_api to pass in khzm, — bmg2 / githubweb
Changing code to work with newest silhs update. larson-group/cam#129 — bmg2 / githubweb
Partially reverting last commit. The solution was implemented in silhs_api. larson-group/cam#129 — bmg2 / githubweb
Making compatible with newest clubb changes. larson-group/cam#129 — bmg2 / githubweb
Bug fixes for land use translator and surface file creation — adivittorio / githubweb
Update the EC30to60E2r2 salinity restoring file name — jonbob / githubweb
Set GM-kappa to 600 for EC30to60E2r2 G-cases — jonbob / githubweb
cmake changes summit — oksanaguba / githubweb
cmake change summit — oksanaguba / githubweb
I altered parameters_tunable.F90 so that it looks more like the — bmg2 / githubweb
Clean up crm_history_init — hannah6 / githubweb
Fixing compilation errors in this branch. — bmg2 / githubweb
Fix MMF timing factor output — hannah6 / githubweb
Minor clm to elm changes. — jacob / githubweb
Change timing_factor to subcycle_factor — hannah6 / githubweb
Update CIME to master to bring in PR#3701 from ESMCI/jonbob/add-new-ocnice-grids — jonbob / githubweb
Change SP* history variables to MMF_* — hannah6 / githubweb
Homme: fixing errors reported by valgrind. — lbertag / githubweb
Homme: fixing bug related to diagnostic calls in prim_driver.cpp — lbertag / githubweb
anvil cmake changes — oksana.guba / githubweb
Homme: couple of fixes in preqx_kokkos to match preqx implementation — lbertag / githubweb
adds ICG support for EC30to60E2r02 — luke.vanroekel / githubweb
Homme: Adding HOMMEXX_BFB_TESTING to preqx and preqx_kokkos config files — lbertag / githubweb
Homme: bug fix in preqx_kokkos caar functor — lbertag / githubweb
I committed all the updated CLUBB namelist variables to — bmg2 / githubweb
typo — oksana.guba / githubweb
Update mpas-source: GM/Redi and surface buoyancy fixes — mpetersen / githubweb
Update to E3SM scrpts corresponding to mpas-ocean Registry changes — jonbob / githubweb
Changes to make everything run. — bmg2 / githubweb
Borrowing code from the master for namelist variables and printing — bmg2 / githubweb
Fixed a compilation error. — bmg2 / githubweb
Set mocStreamfunctionAM off by default for new EC30to60E2r2 mesh — jonbob / githubweb
adds default layout for EC6030E2r2 for compy — luke.vanroekel / githubweb
Revert "adds default layout for EC6030E2r2 for compy" — luke.vanroekel / githubweb
adds default layout for EC6030E2r2 for compy — luke.vanroekel / githubweb
Enable E3SM on Tulip — azamat / githubweb
I am making the remaining changes to parameter values necessary to — bmg2 / githubweb
I am committing the changes necessary to bring back the Lscale averaging — bmg2 / githubweb
A few more clm to elm mods — jacob / githubweb
Rename user_nl_clm in testdefs — jacob / githubweb
Rename clm to elm in config_archive — jacob / githubweb
Change ELM output to include "elm" string — jacob / githubweb
Update cime branch hash — jacob / githubweb
Update mpas-source: Added GPU macros to seaice core — akt / githubweb
Updating to Scorpio ver 1.1.3 — jayesh / githubweb
adding summit modules — oksanaguba / githubweb
mods to cmake and bash scripts to have flexibility in run/test scripts for modules, omp options, jsrun command — oksanaguba / githubweb
Update output file metdata with ELM — jacob / githubweb
Update README.txt — bmg2 / githubweb
A replay SCM run script. — bmg2 / githubweb
Professor and I added lines of code in order to find out the negative spike of T. — bmg2 / githubweb
Submit run should be kept as true. — bmg2 / githubweb
Reviving the standalone tests, and using sam/ fortran code rather than custom fortran code — whannah1 / githubweb
Switching to YAKL SimpleBounds for lower register usage on the GPU. Bug fix for previous implementation of crm_clear_rh. — whannah1 / githubweb
Update mpas-source: improved sea ice testing — akt / githubweb
remove crm_gpu test mod — whannah1 / githubweb
Fix saxx cpp_driver — whannah1 / githubweb
Update standalone test notes and env — whannah1 / githubweb
Homme: bug fix in preqx_kokkos, regarding un-initialized buffers — lbertag / githubweb
Change area_p to area — hannah6 / githubweb
Rebase cime changes — jacob / githubweb
Add MPAS-Seaice files for OpenMP or OpenACC offload — azamat / githubweb
Update paths for moved files — azamat / githubweb
Add netcdf to Tulip's LD_LIBRARY_PATH — azamat / githubweb
incremental: fixed flags for kokkos target; changes to have only kokkos targets on summit — oksanaguba / githubweb
Remove debugging lines in elm buildnml — jacob / githubweb
Replace CLM with ELM in a few pelayout entires — jacob / githubweb
Homme: Remove some debug-build output. — ambradl / githubweb
finish summit scripts — oksanaguba / githubweb
EAM: Remove dynamics' Q fields from SE dycore restart, leaving only Qdp. — ambradl / githubweb
change options for anvil bfb — oksana.guba / githubweb
addition of snicar for land and sea ice, 5 sea ice snow layers, and ITD snow redistribution — afroberts / githubweb
modify standalone conda commands — whannah1 / githubweb
Centralized definition of r8 for CRM code — whannah1 / githubweb
Address PR comments about private/public — whannah1 / githubweb
Update compy L pe-layout for trigrid with EC30to60 — jonbob / githubweb
Rename cam to eam — jacob / githubweb
Change submodule location for cosp2 and rrtmgp externals — jacob / githubweb
Rename cam testmods to eam — jacob / githubweb
Rename user_nl_cams in testmods — jacob / githubweb
Address PR comments — whannah1 / githubweb
Updating standalone framework — normanmr / githubweb
update mpas-source: Fix OMP Directives and Loop Bounds in Ocean — mpetersen / githubweb
Fixing a standalone bug with params_kind.F90 — normanmr / githubweb
I changed setup_clubb_pdf_params.F90 and latin_hypercube_driver_module.F90 — bmg2 / githubweb
Rename cam to eam in CIME — jacob / githubweb
Change CAM to EAM in allactive compsets — jacob / githubweb
Modify more cime_config files for eam — jacob / githubweb
Adjust other component config files for EAM — jacob / githubweb
Modify a few more testmods — jacob / githubweb
Rename cam to eam in ChemPreprocess.pm for paths to chem_proc and chemistry — wlin / githubweb
Rename cam to eam in machine Depends files for cmake — wlin / githubweb
update mpas-source: vertical transport in stage 1 — mpetersen / githubweb
Additions to Monthly output — mpetersen / githubweb
Fix scorpio submodules after bad merge — bhillma / githubweb
Update cime pointer — jacob / githubweb
revert some changes — oksana.guba / githubweb
Replace cam with eam in cmake files — jacob / githubweb
Updated fates interface bc structure for CNP — rgknox / githubweb
I added some documentation (comments/clean-up) and thresholding on dumr, dumnr, dums, and dumns. — bmg2 / githubweb
Add gmKappaScaling and gmBolusKappa — mpetersen / githubweb
Adds reservoir stratification to MOSART-heat. — gautam.bisht / githubweb
Switch to deafault E3SM V2 output — afroberts / githubweb
Update Depends files to new eam name — jgfouca / githubweb
Initial commit to prepend casename to mpas output files — jonbob / githubweb
fix a bug in ELM-Erosion — zeli.tan / githubweb
Change eam output files to use eam in name — jacob / githubweb
Update cime submodule — jacob / githubweb
Uses isnan from shr_infnan_mod — gautam.bisht / githubweb
inctease time limit for homme suite for anvil — oksana.guba / githubweb
Improve Travis debugging — lukasz / githubweb
Update ICG files for oEC60to30v3 so seaice has new number of snow levels — jonbob / githubweb
Rename .mod files in chem_proc to .in — ac.wlin / githubweb
update buildnml for E3SM V2 — ac.afroberts / githubweb
Change pattern matching of .mod to .in on setting chem_mods file — ac.wlin / githubweb
Update mpas-source: CVMix and GM updates — mpetersen / githubweb
Allow up to 10 atm tapes — harr152 / githubweb
Update bld scripts autogenerated from Registry changes — jonbob / githubweb
update to include monthly albedo by surface type, and pond fraction as default — ac.afroberts / githubweb
Update mpas-source: CVMix and GM updates — mpetersen / githubweb
Sending ALM as hlm_name to FATES instead of CLM — rgknox / githubweb
Change default for config_GM_Visbeck_alpha in coupled model — jonbob / githubweb
Change name of CAM_USER_MODS — jacob / githubweb
Add MMF_WTKE output variable — whannah1 / githubweb
change MMF_WTKE to MMF_TKEW — whannah1 / githubweb
Enable moentum feedback in SAM++ — whannah1 / githubweb
Fix MMF momentum feedback — whannah1 / githubweb
Apply dosurface change to fortran CRM — whannah1 / githubweb
Update eam global attributes — jacob / githubweb
Update elm global attributes — jacob / githubweb
Deallocate local vector that is not deallocated automatically — worleyph / githubweb
Adding big_number_finder.py to the postprocessing directory. — bmg2 / githubweb
update mpas-source: Modify ocean freezing temperature to match MPAS-Seaice — mpetersen / githubweb
Restart from existing land files that do not contain required variables for plant hydraulics. — gautam.bisht / githubweb
Add comments. — gautam.bisht / githubweb
Update bld scripts autogenerated from Registry changes — mpetersen / githubweb
Update config_open_ocean_freezing_temperature_coeff — mpetersen / githubweb
Increase field widths in atm_chunk_cost.txt — worleyph / githubweb
Compiler change after Tulip OS upgrade — azamat / githubweb
Adds support to put crops different landunits — gautam.bisht / githubweb
Fixes to fractions based on global run — gautam.bisht / githubweb
Fixes memory leak — gautam.bisht / githubweb
Add theta-SL-pg2 config for EAM Antarcrica RRM — ac.wlin / githubweb
Update mosart global attributes — jacob / githubweb
Add contact email to eam global attributes — jacob / githubweb
changes for skybridge bfb test — oksana.guba / githubweb
revert gitmodules formatting — oksana.guba / githubweb
Update ATM2LND_SMAP and other corrections — ac.wlin / githubweb
Finish moving cam to eam — jacob / githubweb
fixing new paths — oksana.guba / githubweb
Update ICG file datestamps for EC30to60E2r2 — jonbob / githubweb
I updated the E3SM-CLUBB plots to create a new directory called — bmg2 / githubweb
I updated the run_silhs_anvil_gust.csh runscript to include — bmg2 / githubweb
I have added the files necessary for running AMWG variability — bmg2 / githubweb
add avx=0 to anvil, skybridge optimized setup — oksana.guba / githubweb
Update fully coupled e3sm_prod test to v2 — jacob / githubweb
cice and cime changes for cime changes to rename CCSM_cppdefs to CIME_cppdefs. We are keeping both for right now (one is a copy of the other) to give models time to adjust) — wpcoomb / githubweb
changes to components/cmake/build_model.cmake for CIME_cppdefs file — wpcoomb / githubweb
changes to E3SM/components/eam/ for CIME_cppdefs — wpcoomb / githubweb
fixed up cice, elm, and mosart — wpcoomb / githubweb
Improved /components/cice/cime_config/buildlib — wpcoomb / githubweb
Improved /components/cice/cime_config/buildlib 2 — wpcoomb / githubweb
Improved /components/cice/cime_config/buildlib 3 — wpcoomb / githubweb
reverting avx_ver=0 from anvil and skybridge, causing wrong flags — oksana.guba / githubweb
Initial scripts support for new WC14to60E2r3 ocn/ice grid — jonbob / githubweb
Add WC14to60E2r3 grid description — jonbob / githubweb
Update mpas-ocean defaults for new WC14to60E2r3 grid — jonbob / githubweb
Update WC14to60 mapping and domain files — jonbob / githubweb
Add a separate grid for the 1900 spinup of this mesh — jonbob / githubweb
Set config_hmix_use_ref_cell_width to true for the WC14to60E2r3 grid — jonbob / githubweb
Update datestamp for WC14to60E2r3 ICG files — jonbob / githubweb
Update grid alias for WC14to60E2r3 to use EAM instead of CAM5 — jonbob / githubweb
Update docn config to add EAMe — jacob / githubweb
Remove UNICON pt1 - cime and build configure — whannah1 / githubweb
Remove UNICON pt2 - misc stuff outside physics — whannah1 / githubweb
Remove UNICON pt3 - general physics changes — whannah1 / githubweb
Remove UNICON pt4 - convection+micro+macro physics — whannah1 / githubweb
Update mapping and domain files for EC30to60E2r2 grid — jonbob / githubweb
Remove UNICON pt5 - unicon files — whannah1 / githubweb
Homme: using exclusively SIMD Vector for Scalar type. — lbertag / githubweb
Add pe-layout for T62_oEC60to30v3 DTESTM on sandiatoss3 on 4 nodes — jonbob / githubweb
Remove UNICON pt6 - fix micro/macro — whannah1 / githubweb
Remove trigmem — whannah1 / githubweb
Add history global att to eam — jacob / githubweb
Update elm global atts — jacob / githubweb
Update mosart global atts — jacob / githubweb
remove avx flag as it is resolved — oksana.guba / githubweb
Files for northamericax4v1pg2_r0125_WC14to60E2r3(_ICG) — ambradl / githubweb
Adjusting PE layouts for compy and a%ne0np4_northamericax4v1.pg2_l%.+_oi%WC14to60E2r3. — ambradl / githubweb
Update the 'L' (Large) default PE layout for compy and RRM V2. — ambradl / githubweb
NA-ocn WC RRM: Updates for CAM -> EAM. — ambradl / githubweb
Machine file changes for PNNL Sooty — balwindersingh / githubweb
Finish removing trigmem option — whannah1 / githubweb
Homme: Removed pointless include dir in share_kokkos_ut CMakeLists.txt — lbertag / githubweb
Homme: Setting kokkos arch in some mach file used for nightlies — lbertag / githubweb
Homme: enable unit tests only in BFB builds — lbertag / githubweb
Improved e3sm commits to 1)Open the new CIME_cppdefs file if the file exists 2)Open and read the old CCSM_cppdefs file if the system can not find the CIME_cppdefs file — wpcoomb / githubweb
Fixed white space. — wpcoomb / githubweb
Fixed white space.a — wpcoomb / githubweb
fixed some formatting — wpcoomb / githubweb
Homme: fixing some cmake logic regarding auto-enabling of targets — lbertag / githubweb
Move eam history attribute — jacob / githubweb
Homme: fixing odd non-bfb issue with Intel18 in Caar functor. — lbertag / githubweb
Update mpas-source: modify Eden Greatbatch length scale; clean up flags — mpetersen / githubweb
Add additional diagnostic outputs to track Sudden Stratospheric Warming events — harr152 / githubweb
Add auto-generated bld files corresponding to Registry changes — jonbob / githubweb
Fix cut-and-paste error that ended up with two single quotation marks — jonbob / githubweb
This simulation is BFB with the refactored code — balwindersingh / githubweb
Adds endrun calls for blocking radiation diagnostics — balwindersingh / githubweb
RRTMGP test runs fine at this point — balwindersingh / githubweb
Fixes the support for user-defined grid for ELM — gautam.bisht / githubweb
Adds a test for ELM_USRDAT resolution — gautam.bisht / githubweb
CRM tests run fine now — balwindersingh / githubweb
Added prescribed ice mode to MPAS-Seaice component — akt / githubweb
AMB fix for unused kokkos in mpas — oksana.guba / githubweb
NA-ocn WC RRM: XS PE layout for cori-knl just to get something going — ambrad / githubweb
Update mksurfdata defaults for 0.5x0.5 res and fix a small bug — divi553 / githubweb
Update mpas-source: Unreverted revert of MPAS-Seaice — akt / githubweb
Adv cime sha — wpcoomb / githubweb
Move new F-compset definition to EAM — jonbob / githubweb
Make build-namelist-section consistent with build-namelist — jonbob / githubweb
Add FC5AV1C-L-MPASSI compset — jonbob / githubweb
Homme, COMPOSE: Fix debug-build error. — ambradl / githubweb
Homme: Use 'any' instead of 'maxval'. — ambradl / githubweb
Add layouts for RRM v2 config on compy. — ndkeen / githubweb
Bring in hot fix to kokkos submodule, relative to CRAYPE linking — lbertag / githubweb
Renames local variable with clm to elm — gautam.bisht / githubweb
Update mpas-source: fixed prescribed ice bug in seaice with category thickness limits — akt / githubweb
Update again kokkos version, following bug fix — lbertag / githubweb
I changed cice/cime_config/buildlib/ to store — wpcoomb / githubweb
Cleaned up unnecessary if statement block. — wpcoomb / githubweb
Revert "Cleaned up unnecessary if statement block." — wpcoomb / githubweb
make SCM compatible with thetal dycore — bogensch / githubweb
Mass test: Double tol on CO2_FF global mass based on compy_pgi change. — ambradl / githubweb
bug fixes for working code — bogensch / githubweb
Adv cime sha to include PRs #3740 & #3741, — wpcoomb / githubweb
EAM: Use new rebin_fast in volc_radiation code and rework idxs. — ambradl / githubweb
Update mpas-source: fixed bug with index in prescribed ice in seaice — akt / githubweb
RRM: Add an XS Cori-KNL layout from Noel. — ambrad / githubweb
turn on xx tests — oksana.guba / githubweb
activating dynamic crop fraction when prognostic crop model is turned off — tian.zhou / githubweb
EAM: Remove some old comments. — ambradl / githubweb
Defense against use of user_nl_cam after renaming cam to eam — wlin / githubweb
first attempt to switch — oksana.guba / githubweb
Rename user_nl_cam in test allactive-v1cmip6 — wlin / githubweb
Remove two MOC flags — mpetersen / githubweb
Update mpas-source for moc update — mpetersen / githubweb
Add moc GM variables to monthly output — mpetersen / githubweb
bug fix for nitrogen fixation calculation for ECA — jinyuntang / githubweb
Scorpio version 1.1.4 — jayesh / githubweb
Add user_nl_mpassi for elm bgcexp testmod in order to pass automated tests — jonbob / githubweb
Remove support for Makefile-based builds for E3SM components — jgfouca / githubweb
another cime update — jgfouca / githubweb
For cori-knl, update PE layout for F compsets at ne4 resolution. — ndkeen / githubweb
Set fill values for radiation outputs — bhillma / githubweb
update flag to allow one-way irrigation, remove unused output, remove redundant comments, fix area fraction inconsistency for coastal irrigation — tian.zhou / githubweb
Add missing HR output for RRTMGP — bhillma / githubweb
another cime update — jgfouca / githubweb
Hommexx: setting vector size in eam builds — lbertag / githubweb
Hommexx: fix usage of HOMMEXX_CUDA_SHARE_BUFFER — lbertag / githubweb
Hommexx: fixed include path for Kokkos_Random.hpp — lbertag / githubweb
Hommexx: fix eam configure script for preqx_kokkos — lbertag / githubweb
Homme: fixed some cmake/compiler warnings — lbertag / githubweb
Homme: better handling of cxx homme session — lbertag / githubweb
update unit in the output — tian.zhou / githubweb
Homme: added interface to BoundaryExchange — lbertag / githubweb
Homme: adding HOMME_WITHOUT_PIOLIBRARY to compile definitions of executables — lbertag / githubweb
Homme: added macro to create a library for preqx_kokkos and theta-l_kokkos — lbertag / githubweb
Homme: store blas/lapack libs location in an internal cache var — lbertag / githubweb
Homme: created f2c module for kokkos targets, plus breaking up some functions — lbertag / githubweb
Homme: minor change in ElementsGeometry initialization — lbertag / githubweb
Homme: make some CAM ifdefs also check for SCREAM — lbertag / githubweb
Apply fixes to MMF too — bhillma / githubweb
Update mpas-source: Fix cmake for tool exes — mpetersen / githubweb
another cime update — jgfouca / githubweb
Homme: init cxx functors before copying data into views — lbertag / githubweb
Add timing to compiles and links — jgfouca / githubweb
make the code compatible with old MOSART parameter file — tian.zhou / githubweb
This is a rebased after cam->eam change — balwindersingh / githubweb
Rebased:Default case is working wih diags and it is BFB — balwindersingh / githubweb
Improve timing feature — jgfouca / githubweb
Preparations for resolving merge between FATES nutrient branch and hash 45c7a29 — rgknox / githubweb
change default settings for a thetal run — bogenschutz1 / githubweb
Incrementally rectifying conflicts with FATES-CLP and master through evaluating diffs — rgknox / githubweb
conflict resolutions between master and FATES-CNP — rgknox / githubweb
conflict resolutions between fates-cnp and master — rgknox / githubweb
conflict resolutions between fates-cnp and master — rgknox / githubweb
conflict resolutions between fates-cnp and master — rgknox / githubweb
conflict resolutions between fates-cnp and master — rgknox / githubweb
Rework timing so that it works with -jN — jgfouca / githubweb
conflict resolutions between fates-cnp and master — rgknox / githubweb
conflict resolutions between fates-cnp and master — rgknox / githubweb
updating fates submodule pointer to api 14 — rgknox / githubweb
Cleaned up clear_rh logic and fixed calcsize ifdef for modal_aero — balwindersingh / githubweb
Bug fix for prescribed aerosols — balwindersingh / githubweb
Removed some unused vars and use rad_cnst sigma — balwindersingh / githubweb
Everything still BFB, changes related to dgnum and voltonumb — balwindersingh / githubweb
still BFB, some cleanup — balwindersingh / githubweb
COMPASS only, New Mesh: EC15to60E2r4 — mpetersen / githubweb
Update cime and improve time format — jgfouca / githubweb
temporary refactor of the proper way q advection should be done, refactor on way — bogensch / githubweb
fixing build for mmfxx test — oksana.guba / githubweb
I am updating clubb_intr.F90, clubb_api_module, and subcol_SILHS.F90 — bmg2 / githubweb
Reworked logic for calcsize_diag, still BFB — balwindersingh / githubweb
minor cleanup, bfb — balwindersingh / githubweb
keep *elm-bgcexptests with preqx — oksana.guba / githubweb
make scm test use preqx — oksana.guba / githubweb
cleaned up update_mmr logic at some places and removed some pointers — balwindersingh / githubweb
Cleaned up update_mmr logic — balwindersingh / githubweb
Always turn on our wrapper — jgfouca / githubweb
Fixes build a build error — balwindersingh / githubweb
alternate way to do vertical advection — bogensch / githubweb
build namelist fix — tian.zhou / githubweb
refactor how the theta-l dycore handles the vertical advection to be more consistent — bogensch / githubweb
update comments and SE improvements — bogensch / githubweb
Homme: cmake fixes for library targets — lbertag / githubweb
bug fix for update_T logical — bogensch / githubweb
fix some spacing issues — bogensch / githubweb
Renames files — gautam.bisht / githubweb
Renames clm_drv to elm_drv — gautam.bisht / githubweb
Renames private subroutines — gautam.bisht / githubweb
Renames clm_finializedMod to elm_finializedMod — gautam.bisht / githubweb
Renames clm_initializeMod to elm_initializeMod — gautam.bisht / githubweb
Renames clm_instMod to elm_instMod — gautam.bisht / githubweb
Renames clm_interface_bgcType to elm_interface_bgcType — gautam.bisht / githubweb
Renames clm_interface_th_datatype to elm_interface_th_datatype — gautam.bisht / githubweb
Renames clm_interface_thType to elm_interface_thType — gautam.bisht / githubweb
Renames clm_interface_dataType to elm_interface_dataType — gautam.bisht / githubweb
Renames clm_interface_data_type to elm_interface_data_type — gautam.bisht / githubweb
Renames clm_inst_biogeochem/biogeophys to elm_inst_biogeochem/biogeophys — gautam.bisht / githubweb
Renames clm_interface_funcsMod to elm_interface_funcsMod — gautam.bisht / githubweb
Renames get_clm to get_elm — gautam.bisht / githubweb
Renames clm_bgc to elm_bgc — gautam.bisht / githubweb
Renames clm_pf_idata, clm_bgc_data, clm_idata to elm_pf_idata, elm_bgc_data, elm_idata — gautam.bisht / githubweb
Renames clm_varcon to elm_varcon — gautam.bisht / githubweb
Renames clm_varpar to elm_varpar — gautam.bisht / githubweb
Renames clm_varctl to elm_varctl — gautam.bisht / githubweb
Renames clm_varsur to elm_varsur — gautam.bisht / githubweb
Renames clm_nlUtilsMod to elm_nlUtilsMod — gautam.bisht / githubweb
Renames vic_clm_fract to vic_elm_fract — gautam.bisht / githubweb
Renames clm_cpl_indices to elm_cpl_indices — gautam.bisht / githubweb
Renames CLMFatesInterfaceMod to ELMFatesInterfaceMod — gautam.bisht / githubweb
Renames clm_varorb to elm_varorb — gautam.bisht / githubweb
Renames clm_domain_mct to elm_domain_mct — gautam.bisht / githubweb
Deletes test directories that are not used by E3SM — gautam.bisht / githubweb
Renames dom_clm to dom_elm — gautam.bisht / githubweb
Renames u10_clm_patch to u10_elm_patch — gautam.bisht / githubweb
Renames clmlevel to elmlevel — gautam.bisht / githubweb
Renames clmveg to elmveg — gautam.bisht / githubweb
Updates output message from CLM to ELM — gautam.bisht / githubweb
Renames tau_clm to tau_elm — gautam.bisht / githubweb
Renames clm_inparm to elm_inparm — gautam.bisht / githubweb
Renames multiple categories in namelist from clm to elm — gautam.bisht / githubweb
Changes multiple namelist options from CLM to ELM — gautam.bisht / githubweb
Changes CLM-PFLTORAN interface to ELM-PFLOTRAN interface — gautam.bisht / githubweb
Change clm_interface_data to elm_interface_data — gautam.bisht / githubweb
Changes CLM to ELM in interface for PFLOTRAN — gautam.bisht / githubweb
Changes CLM to ELM in initSubgridMod — gautam.bisht / githubweb
Changes CLM to ELM in timers — gautam.bisht / githubweb
Changes subroutine name — gautam.bisht / githubweb
Changes name of the option to merge crops — gautam.bisht / githubweb
Changes CLM to ELM in histFileMod — gautam.bisht / githubweb
Change user namelist name — gautam.bisht / githubweb
Changes BGC subroutine name from CLM to ELM — gautam.bisht / githubweb
Changes CLM to ELM in comments — gautam.bisht / githubweb
setup conusx4 res for theta — oksana.guba / githubweb
mpas-source: improve performance of diagnostics — mpetersen / githubweb
Fixing the constants being different in samxx than in sam. Diffs in standalone are much better now. — whannah1 / githubweb
Fixing fortran code bug in crm_clear_rh and mirroring in C++ code — whannah1 / githubweb
C++ code now gives correct results in standalone on the CPU — whannah1 / githubweb
Fix aqua compset for MMF w/ SAM++ — whannah1 / githubweb
Update MMF standalone test files — whannah1 / githubweb
Major bug fix - index error in SAM++ scalar diff — whannah1 / githubweb
CRM Kurant update — whannah1 / githubweb
Update perturb_t_magnitude in SAM++ — whannah1 / githubweb
Misc C++ casting and index updates — whannah1 / githubweb
rename dummy1 variable to temp_tend, which is more descriptive — bogensch / githubweb
This run script can reproduce good simulations for both SCM cases BOMEX and RF01. Issue #18. — bmg2 / githubweb
More 'state_debug_checks' in physpkg.F90, also output the location when we find bad value of state%t. — bmg2 / githubweb
fix mmf tests — oksana.guba / githubweb
Fixes namelist options for a test — gautam.bisht / githubweb
fixes the path surface dataset — gautam.bisht / githubweb
put SCM logical around SCM specific code block — bogensch / githubweb
Update mpas-source: updated sea ice with alignment of atmos coupling — akt / githubweb
typo fix — whannah1 / githubweb
Set PIO_ROOT=1 for ne30-coupled cases on sandiatoss3 — azamat / githubweb
remove SCM from SL tracer advection — bogensch / githubweb
travis: Print e3sm bldlog if build fails — jgfouca / githubweb
Move PIO_ROOT=1 mod to ERP testmod — azamat / githubweb
Fix build time calls — jgfouca / githubweb
Check time availability — jgfouca / githubweb
Another cime build fix — jgfouca / githubweb
Update cime again with new prov stuff — jgfouca / githubweb
further extration from SL transport in SCM — bogensch / githubweb
cleanup — bogensch / githubweb
whitespace issue fix — bogensch / githubweb
linebreak fix — bogensch / githubweb
final cime update — jgfouca / githubweb
remove unnecessary nu parameter from SCM namelist settings — bogensch / githubweb
Update ERP testmod — azamat / githubweb
switch theta-l dycore to tensorHV — mt / githubweb
all hgrid= conditions need a dyn_target= also — mt / githubweb
Increase MOSART restart file name lengths — azamat / githubweb
Add wcprod test mod — jacob / githubweb
Update Blues modules to nvhpc — azamat / githubweb
change 3 to 3.0 — oksana.guba / githubweb
Replace array reference argument with a scalar — worleyph / githubweb
Fix mis-declared variables — worleyph / githubweb
Explain why replacing array reference argument with a scalar — worleyph / githubweb
Add wcprod test mod for eam — jacob / githubweb
Update e3sm_prod suite to v2 cases — jacob / githubweb
Changes NTASKS for ELM-USRDAT test — gautam.bisht / githubweb
account name on bebop cluster has been renamed 'e3sm' — sarich / githubweb
Bug fix to account for snow backscattering in COSPv2 — wlin / githubweb
Fixes some comments and magic numbers — balwindersingh / githubweb
Pointed pointer to null — balwindersingh / githubweb
Fixes GNU bug differently to allow BFB results. — balwindersingh / githubweb
remove some of settings in ftype tests — oksana.guba / githubweb
make bgc tests use theta — oksana.guba / githubweb
Changes that address review comments — gautam.bisht / githubweb
Rebased again for cam->eam change(12/02/2020) — balwindersingh / githubweb
fixed a typo and removed a comment — balwindersingh / githubweb
Removed references to "cam" in comments about submodule paths — balwindersingh / githubweb
fixed typo and removed a reference to clm as well — balwindersingh / githubweb
Removes a file that was mistakenly added earlier — gautam.bisht / githubweb
Initialize mixing ratio when reading restarts — jayesh / githubweb
Removes clm4_0 and clm5_0 from compset namelist — gautam.bisht / githubweb
Updates the namelist build scripts — gautam.bisht / githubweb
Updates indenting — gautam.bisht / githubweb
Renames xml files — gautam.bisht / githubweb
Renames builds perl script — gautam.bisht / githubweb
Remove tests not used by ELM — gautam.bisht / githubweb
Removes script to determine verion of the model — gautam.bisht / githubweb
Removes clm4_0 — gautam.bisht / githubweb
Renames namelist options from CLM to ELM — gautam.bisht / githubweb
Moved new files into the eam directory structure — harr152 / githubweb
Fixes build options in few tests — gautam.bisht / githubweb
Add Chrysalis machine configuration — azamat / githubweb
Add new Chrysalis modules after storage upgrade — azamat / githubweb
Add omp master to a section of code in init that would otherwise have a race condition. — ndkeen / githubweb
Moved the shared nlev_tom variable initialization to be set only once by master thread. — ndkeen / githubweb
Init an array to zero. — ndkeen / githubweb
There were 3 other arrays that should also be set to zero before use, but these — ndkeen / githubweb
Move where the AOD arrays are initialized to zero. — ndkeen / githubweb
Fixes some strings, all dev tests pass with PGI on Compy — balwindersingh / githubweb
Converts integers to logicals in two if conditions — balwindersingh / githubweb
Bug fix in sea ice coupling file to use the same freezing temperature as — afroberts / githubweb
Switch on high-frequncy coupling in sea ice at 10 iterations — afroberts / githubweb
conflict resolution on cherry-pick — rgknox / githubweb
resolved conflicts on cherry-pick — rgknox / githubweb
Support for ne30np4pg2 in ELM — gautam.bisht / githubweb
This commit upgrades the version of CLUBB and SILHS found in Brian's NGD — bmg2 / githubweb
slightly modified logic on FATES and fixation — rgknox / githubweb
Reverting to older and simplified version of allocation before attempting to merge with master. — rgknox / githubweb
Add grid support for the new ne30np4.pg2 ELM files — jonbob / githubweb
initial start of whitespace fix — celdred / githubweb
does this work? — celdred / githubweb
seems to work — celdred / githubweb
almost there — celdred / githubweb
done! — celdred / githubweb
fixed broadcast order of use_fates — rgknox / githubweb
fixes for global norms mod and C++/Kokkos — celdred / githubweb
shallow water fix — celdred / githubweb
Add GNU modules — azamat / githubweb
fates api 14 — rgknox / githubweb
I updated the version of CLUBB-SILHS found in UWM's NGD E3SM-CLUBB-SILHS — bmg2 / githubweb
fixing _kokkos builds — oksana.guba / githubweb
Fixes compute wetdens logic — balwindersingh / githubweb
Advance cime to include GPTL process id update — azamat / githubweb
Rename LCRC paths from acme to e3sm and clean up — azamat / githubweb
fates cnp, minor fix to fire and n/p dep interpolations. — rgknox / githubweb
FATES API 14 fixes — rgknox / githubweb
update mpas-source: Add diagnostics module for GPU performance — mpetersen / githubweb
Unit testing fixes? — celdred / githubweb
Cleaned up Convective Variance Transport — whannah1 / githubweb
Initial C++ port of CVT — whannah1 / githubweb
C++ VT bug fixes — whannah1 / githubweb
VT Bug fix and summit config adjustment for PGI — whannah1 / githubweb
FATES coupling, temporarily disabling SOIL_ORDER read-ins when fates is on, due to lack of data in the 4x5 surfacefile. — rgknox / githubweb
fates api 14 cnp p1, nee coupling fix and comments fix — rgknox / githubweb
Minor VT updates — whannah1 / githubweb
pass moisture and temp scalars from ColumnDataType to FATES — glemieux / githubweb
Change MMF variance transport naming convention — whannah1 / githubweb
Updating to Scorpio v1.1.5 — jayesh / githubweb
fixed a typo in the fates test list — rgknox / githubweb
I updated the version of CLUBB-SILHS in the NGD E3SM-CLUBB-SILHS — bmg2 / githubweb
Fix PRNG for setperturb in SAM++ — whannah1 / githubweb
Update mpas-source: update seaice with ocean surface temperature bug fix — akt / githubweb
Add Circle CI test — lukasz / githubweb
Bug fix for crashing SAM++ VT cases — whannah1 / githubweb
Add history variables for large-scale VT forcing — whannah1 / githubweb
fix for gnu compiler — balwindersingh / githubweb
Add pelayouts for e3sm_prod WC case — azamat / githubweb
Fixes a threading issue — balwindersingh / githubweb
Minor cleanup — balwindersingh / githubweb
Change optimizations of modal_aero_calcsize.F90 to -O1 for Compy's PGI — balwindersingh / githubweb
Replace module removes with module swaps on Theta — azamat / githubweb
Changes ocean defaults to be consistent with WC v2 — luke.vanroekel / githubweb
enables MOC am — luke.vanroekel / githubweb
Update paths and module loads on Theta — azamat / githubweb
Update mpas-source: Fix bug with high freq coupling in MPAS-Seaice — akt / githubweb
Updates hgrid for 0.125x0.125 — gautam.bisht / githubweb
Add C++ FFT filter routine for VT — whannah1 / githubweb
Add code for sanity checking YAKL FFT — whannah1 / githubweb
Added fortran FFT sanity check code — whannah1 / githubweb
Minor clean up — whannah1 / githubweb
Update mpas-source: Updated sea ice emissivity — akt / githubweb
Add ne4 pelayout on Chrysalis — azamat / githubweb
Add HOMME machine file for Chrysalis — azamat / githubweb
fixed fates logic for decomp_verprofiles() call — rgknox / githubweb
fates: updated logic during capacitance-based phosphatase dynamics to move logical filters outside of loops (for performance). — rgknox / githubweb
Changed name of call ZeroUpscaled to ZeroForFates — rgknox / githubweb
removed obsolete print statement — rgknox / githubweb
Replace netcdf versions with versions used on Anvil — azamat / githubweb
updated name of zero-ing of column level datastructures when fates is on — rgknox / githubweb
removed temporary file AllocationMod.F90_new — rgknox / githubweb
updating fates submodule pointer to tag sci.1.43.2_api.14.2.0 — rgknox / githubweb
Removal of high-frequency coupling for V2 default sea ice coupling — afroberts / githubweb
makes parameter changes valid for EC30to60E2r2 only — luke.vanroekel / githubweb
Add IntelMPI modules on Chrysalis — azamat / githubweb
fixing unit tests and minor formatting — oksana.guba / githubweb
clean up — oksana.guba / githubweb
Add new compsets and atm use_case files for v2 — wlin / githubweb
Correct closing tag for some clubb params in use_case files. — wlin / githubweb
Add v2 setting for missing micro_mg_accre_enhan_fac — wlin / githubweb
Set default atmos parameters for v2 in existing compsets — wlin / githubweb
Update elm config_component to set proper use case for new compsets — wlin / githubweb
Fix CPP variable for filtered VT — hannah6 / githubweb
Using pointers to avoid unnecessary copies of data — balwindersingh / githubweb
Add support for chrysalis to provenance.py — worleyph / githubweb
Add job monitoring script for chrysalis — worleyph / githubweb
time level fix for SCM — bogensch / githubweb
fix spacing issues — bogensch / githubweb
Change default location for SAVE_TIMING_DIR on Chrysalis — worleyph / githubweb
Update mpas-source: Updated sea ice for algal grazing bug — akt / githubweb
minor bug fixes bring fates api to 14.2 — rgknox / githubweb
Remove I_MPI_ADJUST_ALLREDUCE=1 on Chrysalis — azamat / githubweb
I am trying to re-add the links to the externals that were in conflict during — bmg2 / githubweb
Trying to revert the remainder of these merge-conflicted externals to the — bmg2 / githubweb
Adding externals/YAKL to the list — bmg2 / githubweb
Remove FFT test scripts — whannah1 / githubweb
Remove ifdefs for MMF variance transport — whannah1 / githubweb
VT namelist change — whannah1 / githubweb
VT bug fix in configure — hannah6 / githubweb
I am making this commit to fix the recent merge of the E3SM master branch into — bmg2 / githubweb
Removing a duplicate print statement for all CLUBB tunable parameters. — bmg2 / githubweb
update comments — bogensch / githubweb
fix planar test directories — celdred / githubweb
I made changes necessary for postprocessing the updated output files, where — bmg2 / githubweb
Changing the E3SM-CLUBB plot files to account for the file naming convention — bmg2 / githubweb
Address PR comments — whannah1 / githubweb
Widen halo for Redi hmix computation — mpetersen / githubweb
VT bug fix — hannah6 / githubweb
Update CIME submodule — jgfouca / githubweb
Rename default v2 compsets and use_case files — wlin / githubweb
Set back the CIME commit to avoid PIO issues — jgfouca / githubweb
Clean up av1c/f series of compsets except *AV1C-L and FC5AV1C-H01A for nightly tests — wlin / githubweb
Rename namelist_defaults_cam.xml to namelist_defaults_eam.xml — wlin / githubweb
Add chrysalis prov — jgfouca / githubweb
Homme, SL: Add typedef to make SL transport run in a GPU build. — ambradl / githubweb
Homme, EAM: More details for dt_remap_factor and dt_tracer_factor. — ambradl / githubweb
Add new semi-implicit namelist groups to ocean namelist — mpetersen / githubweb
Update ocean build-namelist with new namelists for semi-implicit — mpetersen / githubweb
Add bfb thread mode for semi-implicit — mpetersen / githubweb
Update flag name — mpetersen / githubweb
Update mpas-source — mpetersen / githubweb
Adds support for NA RRM grid on ELM — gautam.bisht / githubweb
fix enax and twpx runs — oksana.guba / githubweb
Update mpas-o namelist definitions with output from automated scripts — jonbob / githubweb
update mpas-source: cosine bell test case — mpetersen / githubweb
Update mpas-source: Port ocean velocity to GPU — mturner / githubweb
Enable Cray compiler on Theta — azamat / githubweb
Use ceiling for number of job nodes — azamat / githubweb
Update modules — azamat / githubweb
Add cray compiler to ChemPreprocess.pm — azamat / githubweb
Update Cray compiler to cce/10.0.3 on Theta — azamat / githubweb
Remove darshan for Cray compiler on Theta — azamat / githubweb
Fixes a NBFB issue when clubb_use_sgv and zmconv_tp_fac are used — balwindersingh / githubweb
Add grid definition and maps for bi-grid NA RRM — tang30 / githubweb
mpas clean-up: remove compass/ocean, add doc template — mpetersen / githubweb
Adds support for NA RRM grid on ELM — tang30 / githubweb
Add gnu modules for intel-mpi on Chrysalis — azamat / githubweb
Updates the name of surface data files — gautam.bisht / githubweb
Updates the hgrid names — gautam.bisht / githubweb
More changes due to renmaing of hgrid — gautam.bisht / githubweb
I updated the version of CLUBB and SILHS in the latest E3SMv2 NGD — bmg2 / githubweb
Committed some E3SM-sided updates to work with the new version of CLUBB-SILHS. — bmg2 / githubweb
Enable test runs on compute nodes on Chrysalis — azamat / githubweb
Update HOMME cmake files on Chrysalis — azamat / githubweb
Reverted accidently modified vertical_diffusion.F90 file — balwindersingh / githubweb
Fix uninitialized pblt600 and replace a remaining FC5AV1C-04P2 test — wlin / githubweb
homme_tool fixes for interpolating NE1024 data — mt / githubweb
fix index bug — mt / githubweb
update cori.job script to use threads — mt / githubweb
Further updates to CLUBB, which will be "made official" later. — bmg2 / githubweb
I added subcol_SILHS_vert_decorr_coef to the namelist. — bmg2 / githubweb
I added subcol_SILHS_vert_decorr_coef to namelist_definition.xml. — bmg2 / githubweb
Add procs-per-node option to intel-mpi mpirun on Chrysalis — azamat / githubweb
Update mappy to gcc-8.1.0 to match summit — jgfouca / githubweb
Update mpas-source: fixed seaice column message threading bug — akt / githubweb
Modifying E3SM to work with the latest version of CLUBB-SILHS. — bmg2 / githubweb
Adding clubb_C_invrs_tau_wpxp_Ri and clubb_C_invrs_tau_wpxp_N2_thresh — bmg2 / githubweb
Consolidate v2 atm parameter values into a common default file — wlin / githubweb
Run intel-mpi with slurm srun on Chrysalis — azamat / githubweb
I am officially upgrading the version of CLUBB and SILHS used in E3SM to — bmg2 / githubweb
Altered the git commit hash in the run script to reflect the updated — bmg2 / githubweb
Resetting clubb_debug_level from 3 to 2 allows us to get rid of the — bmg2 / githubweb
Adds test SMS.northamericax4v1pg2_WC14to60E2r3_ICG.A_WCYCL1850S_CMIP6 — balwindersingh / githubweb
Simplify and use srun for homme on Chrysalis — azamat / githubweb
Updating to Scorpio ver 1.1.6 — jayesh / githubweb
Fix calc. for max. number of levels when using noI8 and update comments — worleyph / githubweb
Update mappy serial env — jgfouca / githubweb
I am changing TTEND_CLUBB back to STEND_CLUBB for use in output statistics. — bmg2 / githubweb
Some mods to the test, shell commands and the use case files — balwindersingh / githubweb
Removed some unused user_nl* files — balwindersingh / githubweb
Changes test name to remove "v2" — balwindersingh / githubweb
Update mpas-source: propagate ocn_diagnostics_variables to shared/ — mturner / githubweb
Update argument lists in ocn_comp_mct for recent MPAS-O changes — mturner / githubweb
Update CIME submodule — jgfouca / githubweb
I updated draw_clubb_budget.py to reflect the CLUBB stat name change — bmg2 / githubweb
Added history fields back with cosp turned on — balwindersingh / githubweb
Adds an "S" PE layout anvil — balwindersingh / githubweb
Update framework in mpas-source — mpetersen / githubweb
Update CXXFLAGS — azamat / githubweb
Use ocn_diagnostics_variables in ocn_comp_mct driver — mturner / githubweb
Explicitly specify UCX transport — jayesh / githubweb
Update mpas-source: finish propagating ocn_diagnostics_variables — mturner / githubweb
Update cime again to remove PIO performance degradation — jgfouca / githubweb
Fixes for F-EAMv1 and F-MMF1 compsets needed after phys name change — wlin / githubweb
Adding PE layouts for v2RRM on cori-knl — ndkeen / githubweb
I am cherry-picking git commit 6e2592c from January 13, 2021 and adding — bmg2 / githubweb
CIME submodule update — jgfouca / githubweb
update mpas-source: Move surface pressure and zMid before EOS — mpetersen / githubweb
Fix restart NBFB when clubb_ipdf_call_placement=2 — wlin / githubweb
implement esmt to samxx — xyuan / githubweb
fix dmdf_write typo — xyuan / githubweb
Add 2 degree mosart grid as option — jacob / githubweb
Add r2_r2 grid alias and r2 domain — jacob / githubweb
fix some VT implementation issues — xyuan / githubweb
CIME submodule update — jgfouca / githubweb
Remove _ICG ocn/ice grids, instead cue off compset option SPUNUP — jonbob / githubweb
Fix for aero_model when chem is none after phys namm change — wlin / githubweb
Hommexx: bug fix in RemapStateProvider — lbertag / githubweb
Hommexx: test also tracers in remap_theta_ut — lbertag / githubweb
Update mpas-source: Improved sea ice column error messages — akt / githubweb
Change from keying off %SPUNUP to including SOI in compset longname — jonbob / githubweb
I am altering P3 for SILHS by making changes equivalent to the — bmg2 / githubweb
Fix an issue that uses dcape related codes when ZM is not used — wlin / githubweb
Updates MPAS ocean and sea ice conditions — luke.vanroekel / githubweb
Updates defaults for EC30to60 and WC14 — luke.vanroekel / githubweb
update mpas-source: make ocean init mode optional — mpetersen / githubweb
Update E3SM bld scripts to reflect changes to the ocean Registry — mpetersen / githubweb
Remove the "-1900" grids as a mechanism for designating different ICs — jonbob / githubweb
I am exporting the fields from P3 microphysics that are necessary — bmg2 / githubweb
Add default layouts for G-cases using EC30to60 on anvil/chrysalis/compy — jonbob / githubweb
Add domain file for r2 — jacob / githubweb
update mpas-source: Fix core_ocean submodule checks in cmake — mpetersen / githubweb
for chrsyalis: initial set of PE layouts for RRMv2 — ndkeen / githubweb
Update default ne30-WC pelayout — azamat / githubweb
Default to a 60-node pelayout — azamat / githubweb
Update cray-specific flags — azamat / githubweb
Update FFLAGS and rename abort redeclarations — azamat / githubweb
Update cray modules — azamat / githubweb
unifies WC14 and EC30to60 del2 and del4 — luke.vanroekel / githubweb
Fix an issue in nudging code — shixuan.zhang / githubweb
Update mpas-ocean: Fixes shortwave absorption for shallow cells — mpetersen / githubweb
Allow time:point cell method — jacob / githubweb
update mpas-source: Simplify computing landIcePressure and vertical grid in ocean init mode — mpetersen / githubweb
Made changes necessary for CLUBB-SILHS-P3 to compile. — bmg2 / githubweb
Replace "+=" for grid related settings with "=" — jonbob / githubweb
Update mpas-source: seaice regional stats bug — akt / githubweb
eam h0 units CF compliance — zhang40 / githubweb
Allow standard_name on variable in EAM — jacob / githubweb
Add standard_names to some EAM output variables — jacob / githubweb
Add dummy args to the call of aircraft_emit_init for the crm version. — wlin / githubweb
Add more CMIP attributes — jacob / githubweb
Additional changes to crm/physpkg.F90 made to cam/physpkg.F90 in this PR — wlin / githubweb
Fix an issue in nudging code — shixuan.zhang / githubweb
update to topo generation tool — mt / githubweb
improve omp reduction — mt / githubweb
fix incorrect comment — mt / githubweb
remove SHARED omp directive — mt / githubweb
Add optional pattern matching for SOI in compset names — jonbob / githubweb
Remove some use_case files not used in v2 — wlin / githubweb
Fix standard_name for TGCLDCWP TGCLDLWP — jacob / githubweb
Add standard_names for FLUT, SWCF, LWCF, PRECC, PRECT — wlin / githubweb
Add ability to pass standard_name when defining history — jacob / githubweb
Remove standard_names for PRECC, PRECT, FLUT — wlin / githubweb
Make sure standard_name is output — jacob / githubweb
update mpas-source: Add Wright (1997) equation of state — mpetersen / githubweb
Update CIME submodule — jgfouca / githubweb
Cleanup of unused compsets and grids for v2 — wlin / githubweb
Update bld scripts to match changes in ocean core Registry — jonbob / githubweb
Updated for my changes so far to run P3. — bmg2 / githubweb
Add and update global attributies — jacob / githubweb
Add a couple of standard names — jacob / githubweb
Fix CF units and change spval — jacob / githubweb
Put back use_case 1850_cam5_av1c-04p2 to avoid diff of A_WCYCL1850 tests — wlin / githubweb
Update MOSART output for CF and CMIP — jacob / githubweb
Restore accidentally removed compset FSCM5A97 — wlin / githubweb
Update mpas-source: pgi syntax fix — mturner / githubweb
Run CircleCI on master branch only — lukasz / githubweb
update mpas-source: Removes shortwave energy conservation fix — mpetersen / githubweb
Remove 1950 and 2010 specific build-config entries — wlin / githubweb
Restore spval and fillvalue to 1.e36 — jacob / githubweb
Update mpas-ocean bld scripts to match changes to Registry — jonbob / githubweb
Reorder check for bgc and spunup options to get the correct ICs — jonbob / githubweb
update mpas-source: Fixes missing edgeSignOnCell in redi_term2 — mpetersen / githubweb
Run CircleCI on all branches — lukasz / githubweb
Updates WC14 and EC30to60 initial conditions — luke.vanroekel / githubweb
Get verbose output from case.build in CircleCI test — lukasz / githubweb
Corrected the name for compset alias F-EAM-RCEMIP — wlin / githubweb
update mpas-source: framework update — mpetersen / githubweb
Remove redundant compy G-case layout, use previous layout for new grid — jonbob / githubweb
More changes for running CLUBB-SILHS with P3 ... — bmg2 / githubweb
update mpas-source: stand-alone makefile addition — mpetersen / githubweb
update mpas-source: stand-alone ocean output to single precision — mpetersen / githubweb
Trying to get CLUBB-SILHS-P3 to run — bmg2 / githubweb
update mpas-source: Simplifies the shortwave fixer formulation — mpetersen / githubweb
Add bottomLayerShortwaveTemperatureFlux to timeSeriesStatsMonthlyOutput stream — jonbob / githubweb
Enable shortwave_energy_fixer by default — jonbob / githubweb
make vtheta_thresh a namelist variable — mt / githubweb
typo — mt / githubweb
improve comments — mt / githubweb
update mpas-source: sediment transport design document — mpetersen / githubweb
update mpas-source: cleanup of ocean split-explicit driver — mpetersen / githubweb
adjust constant — oksana.guba / githubweb
Updating to Scorpio version 1.2.0 — jayesh / githubweb
Update mpas-source: init mode case — mpetersen / githubweb
I have edited the P3 interface in an attempt to get everything working. — bmg2 / githubweb
I updated the checkout of scorpio so we'd have a bug fix. — bmg2 / githubweb
With these changes to some of the code in SILHS, CLUBB-SILHS-P3 finally runs to completion!! — bmg2 / githubweb
Edited so that the code still works with MG microphysics. — bmg2 / githubweb
I officially updated the code to read in version 4.1.1 of the P3 lookup tables. — bmg2 / githubweb
Fixed the memory bug. — bmg2 / githubweb
We made some code changes to get these runs in Issue 36, https://github.com/larson-group/e3sm/issues/36#issuecomment-831637272. 1) shut off the detrainment scheme in clubb_intr.F90, 2) reduce v_qit=v_nit by 2 in micro_p3.F90 — guozhun / githubweb
NGD_wP3.csh is the new script for Issue 36, https://github.com/larson-group/e3sm/issues/36#issuecomment-831637272. — guozhun / githubweb
C_invrs_tau_N2_wpxp_thresh = 2.3 for run D in Issue 36,https://github.com/larson-group/e3sm/issues/36#issuecomment-831637272. — guozhun / githubweb
Getting rid of uninitialized memory when P3 is used. — bmg2 / githubweb
Additional correction to go along with the previous commit. — bmg2 / githubweb
Update micro_p3.F90 — noreply / githubweb
I am officially committing the official fix to the memory bug that — bmg2 / githubweb
The path to cime in .gitmodules was not correct. — bmg2 / githubweb
Mopping up after the recent merge of the master. This version of the code actually runs now ... — bmg2 / githubweb
Adding F2010SC5-P3 compset — bmg2 / githubweb
Add CO2 mixing ratio to be consistent with CMIP6 compset — bmg2 / githubweb
Add run script for Compy; ne120 cld_macmic_num_steps = 6 — bmg2 / githubweb
Comment-out the explicit physical setting that are applied through the compset — bmg2 / githubweb
Add/remove IC for run script — bmg2 / githubweb
Removing gibberish added during the most recent cherry-pick merge. — bmg2 / githubweb
Adding the KK-2000/Accretion tuning params — bmg2 / githubweb
P3 + Cooper; Adding new flag to control the usage of Cooper scheme, while disable the Meyers scheme in <nucleate_ice.F90> — bmg2 / githubweb
Committing new runscripts — bmg2 / githubweb
Removing the setting of CLUBB stats output variables from the runscript — bmg2 / githubweb
Updated run script — bmg2 / githubweb
I am committing some small changes to my 1 degree run scripts. — bmg2 / githubweb
I added "seasonally continuous" and "seasonally discontinuous" functionality — bmg2 / githubweb
I am adding the run script for quarter degree production runs. — bmg2 / githubweb
I updated the version of CLUBB and SILHS to version b0feee8 from May 27, 2021. — bmg2 / githubweb
A by-hand redo of commit 814dc04 to the clubb_silhs_devel branch on Feb 4, 2021. — bmg2 / githubweb
This is a hand-merge of commit 9b7b8b6 to the clubb_silhs_devel branch on March 15, 2021. — bmg2 / githubweb
This is a hand re-do of commit e708e6e to the clubb_silhs_devel branch — bmg2 / githubweb
This is a by-hand redo of commit 2f1647c to the clubb_silhs_devel branch — bmg2 / githubweb
A by-hand redo of commit b4fd9aa to the clubb_silhs_devel branch from — bmg2 / githubweb
This is a by-hand cherry-pick of commit 0af8b9a (to the clubb_silhs_devel — bmg2 / githubweb
I am committing a by-hand cherry-pick of commit f3d5061 that was made to the — bmg2 / githubweb
I am committing a by-hand cherry-pick of revision 1f63abb from April 29, 2021, — bmg2 / githubweb
This is a by-hand cherry-pick of commit 853a408 from May 4, 2021, which — bmg2 / githubweb
I am committing a by-hand cherry-pick of commit 85ff2e6 from May 4, 2021, — bmg2 / githubweb
I am committing a by-hand cherry-pick of commit 33d4507 from May 4, 2021, — bmg2 / githubweb
I am committing a by-hand cherry-pick of commit 3482c3a from March 7, 2021, — bmg2 / githubweb
This by-hand cherry-pick is actually 2 cherry-picks for the price of 1!!! — bmg2 / githubweb
I am committing a by-hand cherry-pick of commit ad5378e from May 12, 2021, which — bmg2 / githubweb
Changing clubb_up2_vp2_factor to clubb_up2_sfc_coef to correspond with — bmg2 / githubweb
I am changing some of the run scripts to reflect a recent name change in CLUBB. — bmg2 / githubweb
I am updating runscripts based on a recent name change in CLUBB, where — bmg2 / githubweb
Fixed some whoopsies — bmg2 / githubweb
I am fixing the bug that reorded the column/subcolumn indices in state_sc. This — bmg2 / githubweb
I changed the tolerance on the snow balance error check in the land module — bmg2 / githubweb
Add module load per5-extras for cori machines — bmg2 / githubweb
P3 update and new compsets for AMIP simulations — bmg2 / githubweb
Add simplied v2 run script template run.F20TR-P3.template.sh — bmg2 / githubweb
Change pe-layout to 64x2 on 338 nodes for ne120 on cori-knl — bmg2 / githubweb
Fixed a typo and commented out a line to get the code to compile and run! — bmg2 / githubweb
Updated to use the correct finidat and fsurdat for a 0.25 degree production run. — bmg2 / githubweb
This run repeat the [simulation](https://github.com/larson-group/e3sm/issues/36#issuecomment-881690516). Parameters setting is suggested by the tunner. — guozhun / githubweb
Update the Machine files for Anvil. Issue #36. — guozhun / githubweb
Make two different production run files for the 0.25 degree simulations: — bmg2 / githubweb
Update NGD_wP3_1deg_prod_run.csh — noreply / githubweb
Update micro_p3.F90 — noreply / githubweb
Readying scripts for production runs using the final tuning. — bmg2 / githubweb
Renaming the 1 degree production run script to specify use on Anvil. — bmg2 / githubweb
New file name — bmg2 / githubweb
Updated for new AMIP run script, plus updated stats on 1 deg run script. — bmg2 / githubweb
Removing the offensive ZM variables out of the fincl5 list, allowing — bmg2 / githubweb
Added a special runscript for AMIP sstplus4K — bmg2 / githubweb
Change the dang name! — bmg2 / githubweb
Update NGD_wP3_1deg_prod_run_anvil.csh — noreply / githubweb
Changing clubb_rainevap_turb to false. — bmg2 / githubweb
Removing finidat (initial condition files) for the AMIP runs, following — bmg2 / githubweb
Adding the runscript for the 25 month control run for aerosol production. — bmg2 / githubweb
Added the script for the active end of the Aerosol-Cloud Interaction — bmg2 / githubweb
I am adding Zhun's remap_ne30pg2.csh script to the remap directory. — bmg2 / githubweb
Fixed an error — bmg2 / githubweb
Add files via upload — noreply / githubweb
Committing temporary changes — bmg2 / githubweb
Update NGD_wP3_1deg_prod_run_anvil.csh — noreply / githubweb
Update NGD_wP3_1deg_AMIP_prod_run_anvil.csh — noreply / githubweb
Update NGD_wP3_1deg_AMIP_sstplus4K_prod_run_anvil.csh — noreply / githubweb
Update micro_p3.F90 — noreply / githubweb
Update NGD_wP3_1deg_F2010-CTL_prod_run_anvil.csh — noreply / githubweb
Update NGD_wP3_1deg_F2010-piAEROSOL_prod_run_anvil.csh — noreply / githubweb
Update NGD_wP3_1deg_prod_sens.csh — noreply / githubweb
I am updating the version of CLUBB and SILHS used in E3SM to — bmg2 / githubweb
Made updates to both clubb_intr.F90 and subcol_SILHS.F90 in order — bmg2 / githubweb
I altered the nightly test run scripts to be consistent with what's — bmg2 / githubweb
Adding some additional files that need to be ported over from — bmg2 / githubweb
Fixing compilation bugs. — bmg2 / githubweb
Adding ifdef SILHS preprocessor flags around a conditional in subcol_SILHS.F90 — bmg2 / githubweb
Added analyze_sensitivity_matrix.py to the diagnostic_v2_0 directory. — bmg2 / githubweb
I am updating config_machines.xml and config_compilers.xml — bmg2 / githubweb
Fixed the bug where clubb_params was reported to have parameters that — bmg2 / githubweb
Change user namelist name from "user_nl_cam" to "user_nl_eam". — noreply / githubweb
Change "F_SCAM5" to "F_SCAM" and "-phys cam5" to "-phys default" — noreply / githubweb
Change "F_SCAM5" to "F_SCAM" and "-phys cam5" to "-phys default" — noreply / githubweb
Change "F_SCAM5" to "F_SCAM" and "-phys cam5" to "-phys default" — noreply / githubweb
Updating the nelson's FFLAGS in config_compilers.xml — noreply / githubweb
Revert "Updating the nelson's FFLAGS in config_compilers.xml" — bmg2 / githubweb
I am committing a "manual cherry-pick" of git commit 1b238fe to the clubb_silhs_devel — bmg2 / githubweb
Updating micro_p3_interface.F90 so that it compiles on Nelson with the gfortran compiler. — bmg2 / githubweb
Adding w_up_in_cloud to the pbuf, which will eventually allow it to be ported — bmg2 / githubweb
Adding statistical output for w_up_in_cloud (stat name W_UP_IN_CL_CLUBB). — bmg2 / githubweb
The stat output for w_up_in_cloud should be on thermodynamic levels ('lev') — bmg2 / githubweb
I am fixing some of the statistical output level listings for variable CLUBB — bmg2 / githubweb
I am updating the nightly E3SM SCM scripts (for BOMEX, DYCOMS-II RF01, — bmg2 / githubweb
Add arm_97 case to the Jenkins e3sm_run_gfortran_test — bmg2 / githubweb
Updated the E3SM SCM runscript for ARM 97 for E3SM v2 code. — bmg2 / githubweb
Updating the ARM 97 E3SM SCM run script so that it runs with — bmg2 / githubweb
Getting rid of this hyper-annoying print statement. — bmg2 / githubweb
I am updating the version of CLUBB and SILHS in the brand new future — bmg2 / githubweb
Bringing the branch up-to-date with the changes that needed to be — bmg2 / githubweb
I updated the version of CLUBB in the future clubb_silhs_devel branch to be — bmg2 / githubweb
Raw-copy updating components/eam/src/physics/clubb — LarsonGroupSysAdmin / githubweb
Raw-copy updating components/eam/src/physics/clubb — LarsonGroupSysAdmin / githubweb
Fixing error where test could not find CXX definition. #46 — pbroels / githubweb

#60 (Feb 22, 2022, 3:57:28 PM)

Pushing column index into zm2zt and zt2zm. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 — Gunther Huebler / githubweb
A variety of small loop pushing. larson-group/clubb#972 — Gunther Huebler / githubweb
Fixed small bug that slipped through because the G_unit tests use nz=1. — Gunther Huebler / githubweb
Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 — Gunther Huebler / githubweb
I added a subroutine that prints that values of all PDF parameters in — bmg2 / githubweb
Small changes and a loop push. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing loop into advance_xm_wpxp. larson-group/clubb#972 — Gunther Huebler / githubweb
Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 — Gunther Huebler / githubweb
Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing column loop into local functions. larson-group/clubb#972 — Gunther Huebler / githubweb
Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing. — Gunther Huebler / githubweb
Added log file output in the post step so it is displayed when the test fails. — pbroels / githubweb
Fixing ne4 jenkins script from small copy-paste error. — Gunther Huebler / githubweb
Script now exits with 1 when run fails. — Gunther Huebler / githubweb
I am fixing the issue with clubb_silhs_devel branch. The arrays — bmg2 / githubweb
Changing post step order to read log files before removing them. — pbroels / githubweb
Fixing script to make the error code correct upon exit — Gunther Huebler / githubweb
Fixing log copy statements to allow test to run. — noreply / githubweb
Adding 2D version of zt2zm and zm2zt to clubb_api — Gunther Huebler / githubweb
Add arm_97 case to the Jenkins e3sm_run_gfortran_test — noreply / githubweb
Pushing loop into solve_xm_wpxp_with_single_lhs (#986) — noreply / githubweb
Refactoring to remove need for global stats scratch variables. (#988) — noreply / githubweb

#59 (Feb 22, 2022, 3:49:55 PM)

Updating the ARM 97 E3SM SCM run script so that it runs with — bmg2 / githubweb
Getting rid of this hyper-annoying print statement. — bmg2 / githubweb

#58 (Feb 17, 2022, 6:25:04 PM)

Add arm_97 case to the Jenkins e3sm_run_gfortran_test — bmg2 / githubweb
Updated the E3SM SCM runscript for ARM 97 for E3SM v2 code. — bmg2 / githubweb

#55 (Feb 17, 2022, 4:55:41 PM)

Change "F_SCAM5" to "F_SCAM" and "-phys cam5" to "-phys default" — noreply / githubweb
Change "F_SCAM5" to "F_SCAM" and "-phys cam5" to "-phys default" — noreply / githubweb
Change "F_SCAM5" to "F_SCAM" and "-phys cam5" to "-phys default" — noreply / githubweb
Updating the nelson's FFLAGS in config_compilers.xml — noreply / githubweb
Revert "Updating the nelson's FFLAGS in config_compilers.xml" — bmg2 / githubweb
I am committing a "manual cherry-pick" of git commit 1b238fe to the clubb_silhs_devel — bmg2 / githubweb
Updating micro_p3_interface.F90 so that it compiles on Nelson with the gfortran compiler. — bmg2 / githubweb
Adding w_up_in_cloud to the pbuf, which will eventually allow it to be ported — bmg2 / githubweb
Adding statistical output for w_up_in_cloud (stat name W_UP_IN_CL_CLUBB). — bmg2 / githubweb
The stat output for w_up_in_cloud should be on thermodynamic levels ('lev') — bmg2 / githubweb
I am fixing some of the statistical output level listings for variable CLUBB — bmg2 / githubweb
I am updating the nightly E3SM SCM scripts (for BOMEX, DYCOMS-II RF01, — bmg2 / githubweb

#54 (Feb 17, 2022, 4:21:01 PM)

Changing flags. — Gunther Huebler / githubweb

#53 (Feb 17, 2022, 3:57:28 PM)

Fixing bug. — Gunther Huebler / githubweb

#51 (Feb 10, 2022, 4:30:15 PM)

quick check for brians fix — Gunther Huebler / githubweb

#50 (Feb 10, 2022, 2:41:09 PM)

Script update — Gunther Huebler / githubweb

#49 (Feb 10, 2022, 2:32:38 PM)

Script update — Gunther Huebler / githubweb

#48 (Feb 10, 2022, 12:57:14 PM)

Script update — Gunther Huebler / githubweb

#47 (Feb 10, 2022, 12:51:25 PM)

Script update — Gunther Huebler / githubweb

#46 (Feb 10, 2022, 12:41:10 PM)

Script update — Gunther Huebler / githubweb

#45 (Feb 10, 2022, 12:36:17 PM)

New jenkinsfile — Gunther Huebler / githubweb

#44 (Feb 9, 2022, 3:24:07 PM)

does this fix? — Gunther Huebler / githubweb

#43 (Feb 3, 2022, 4:46:12 PM)

quick_test aghrhrj — Gunther Huebler / githubweb

#42 (Feb 3, 2022, 3:49:49 PM)

quick_test awrrfg — Gunther Huebler / githubweb

#41 (Feb 3, 2022, 3:04:52 PM)

quick_test agdgh — Gunther Huebler / githubweb

#40 (Feb 3, 2022, 2:53:54 PM)

Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 — Gunther Huebler / githubweb
Making sure that ice_supersat_frac is configured properly for restarts — bmg2 / githubweb
Fixed an array size mismatch — bmg2 / githubweb
Added an initialization for ice_supersat_frac — bmg2 / githubweb
Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing column index into zm2zt and zt2zm. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 — Gunther Huebler / githubweb
A variety of small loop pushing. larson-group/clubb#972 — Gunther Huebler / githubweb
Fixed small bug that slipped through because the G_unit tests use nz=1. — Gunther Huebler / githubweb
Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 — Gunther Huebler / githubweb
quick_test sodgjk — Gunther Huebler / githubweb

#39 (Jan 31, 2022, 4:40:32 PM)

Breaking up column loop in advance_clubb_core. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence — bmg2 / githubweb
Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 — Gunther Huebler / githubweb
Making a commit that officially places the call to the PDF in the "post" — bmg2 / githubweb
Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 — Gunther Huebler / githubweb
Forgot an & symbol. — Gunther Huebler / githubweb
We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 — Gunther Huebler / githubweb
I am updating ice_supersat_frac to be an intent(inout) variable for — bmg2 / githubweb
Making compatible with latest clubb change. — Gunther Huebler / githubweb
Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 — Gunther Huebler / githubweb
Making sure that ice_supersat_frac is configured properly for restarts — bmg2 / githubweb
Fixed an array size mismatch — bmg2 / githubweb
Added an initialization for ice_supersat_frac — bmg2 / githubweb
Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 — Gunther Huebler / githubweb

#38 (Jan 28, 2022, 3:09:50 PM)

Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 — Gunther Huebler / githubweb
Making e3sm use the single column version of advance clubb core directly, since it does not want to use the interface version. larson-group/clubb#972 — Gunther Huebler / githubweb
Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 — Gunther Huebler / githubweb
Breaking up column loop in advance_clubb_core. larson-group/clubb#972 — Gunther Huebler / githubweb
Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence — bmg2 / githubweb
Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 — Gunther Huebler / githubweb
Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 — Gunther Huebler / githubweb
Making a commit that officially places the call to the PDF in the "post" — bmg2 / githubweb
Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 — Gunther Huebler / githubweb
Forgot an & symbol. — Gunther Huebler / githubweb
We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 — Gunther Huebler / githubweb
I am updating ice_supersat_frac to be an intent(inout) variable for — bmg2 / githubweb
Making compatible with latest clubb change. — Gunther Huebler / githubweb
quick_test — Gunther Huebler / githubweb

#37 (Jan 20, 2022, 2:45:17 PM)

I have passed clubb_params down into advance_xm_wpxp_module.F90. — bmg2 / githubweb
See ticket — jan.gruenenwald / githubweb
I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. — bmg2 / githubweb
added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — jan.gruenenwald / githubweb
Updates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example. — 59519056+bstephens82 / githubweb
Changing the name of dummy_1d variables for clarity. — 59519056+bstephens82 / githubweb
I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 — bmg2 / githubweb
Add a blank line to trigger nightly tests. — noreply / githubweb
Passing down more of CLUBB's tunable parameters. — bmg2 / githubweb
I accidentally removed an important comment in the previous commit. — bmg2 / githubweb
Passing down more CLUBB tunable parameters. — bmg2 / githubweb
More passing down CLUBB parameters ... whoop-de-doo — bmg2 / githubweb
Passing down more tunable parameters and removing references to — bmg2 / githubweb
Removing line to trigger the nightly tests for all repos. — noreply / githubweb
See respective messages on the issue 958 on date 10/12/2021 — jan.gruenenwald / githubweb
Handling the abomination that is lmin. — bmg2 / githubweb
Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b. — benjamin.andrew.stephens / githubweb
Passing tunable parameters into the new tau code. — bmg2 / githubweb
Passed down more parameters. Results are bit-for-bit. — bmg2 / githubweb
Passing through more clubb parameters. Bit-for-bit — bmg2 / githubweb
Passing down CLUBB's tunable parameters into the setup_pdf_parameters and — bmg2 / githubweb
These updates incorporate some of Shixuan Zhang's changes, including: — benjamin.andrew.stephens / githubweb
Passing down CLUBB's tunable parameters into the remainder of the — bmg2 / githubweb
I passed down the forgotten thlp2_rad_coef tunable parameter. — bmg2 / githubweb
Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. — benjamin.andrew.stephens / githubweb
I am passing down the forgotten parameter, altitude threshold, in — bmg2 / githubweb
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/968. — benjamin.andrew.stephens / githubweb
Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920. — 59519056+bstephens82 / githubweb
Updates as requested to the l_use_tke_in_K_dfsn code: — 59519056+bstephens82 / githubweb
I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
I am committing the final stage of the "pass-down params" project. — bmg2 / githubweb
Adding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b. — 59519056+bstephens82 / githubweb
Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. — 59519056+bstephens82 / githubweb
Adding comments for clarity. — 59519056+bstephens82 / githubweb
I forgot to add this necessary subroutine call to the clubb API. — bmg2 / githubweb
Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms. — benjamin.andrew.stephens / githubweb
Applying the fix for the new CLUBB code to the developmental — bmg2 / githubweb
I fixed a couple of errors. — bmg2 / githubweb
I have turned the nu_vert_res_dep family of variables into a derived — bmg2 / githubweb
Updating for changes to CLUBB. — bmg2 / githubweb
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — jan.gruenenwald / githubweb
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — jan.gruenenwald / githubweb
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — jan.gruenenwald / githubweb
fixed a typo in pdf_closure_module.f90, line 1284 — jan.gruenenwald / githubweb
See ticket — 68997723+JanGrn / githubweb
added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk — 68997723+JanGrn / githubweb
See respective messages on the issue 958 on date 10/12/2021 — 68997723+JanGrn / githubweb
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 — 68997723+JanGrn / githubweb
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details — 68997723+JanGrn / githubweb
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge — 68997723+JanGrn / githubweb
fixed a typo in pdf_closure_module.f90, line 1284 — 68997723+JanGrn / githubweb
Passing w_up_in_cloud out of advance_clubb_core — bmg2 / githubweb
Updating clubb_intr.F90 for the changes to advance_clubb_core_api — bmg2 / githubweb
fixed compiler warning regarding w_up_in_cloud — jan.gruenenwald / githubweb
Remove clipping from a3_coef. — noreply / githubweb
These changes allow you to call the 4 clubb "advance" subroutines in any — Brian Griffin / githubweb
Placing the order variables in a nice, convenient place for testing use. — Brian Griffin / githubweb
I reordered advance_clubb_core so that the "Advance xp3" (which is a — Brian Griffin / githubweb
I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx — Brian Griffin / githubweb
I am indenting the portion of the code where the advance subroutines — Brian Griffin / githubweb
Temporarily commenting out the idiot proofing in order to run some tests ... — Brian Griffin / githubweb
Now official reinstating the idiot-proofing and turning off the — bmg2 / githubweb
I am committing some idiot proofing in regards to the advance — bmg2 / githubweb
Updating for the latest version of CLUBB. — bmg2 / githubweb
Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. — bmg2 / githubweb
Now that uprcp and vprcp have been passed through advance_clubb_core, — bmg2 / githubweb
I am adding more arguments to the argument list for advance_clubb_core — bmg2 / githubweb
I am updating clubb_intr.F90 to account for recent changes to the call to — bmg2 / githubweb
Adding omitted lines to the call to advance_clubb_core_api. — bmg2 / githubweb
Reverting to using Gfortran 8 temporarily to get things working. — pbroels / githubweb
Insert print about overwriting default flags with namelist values — noreply / githubweb
Insert print about overwriting default parameters with namelist values — noreply / githubweb
Making api version of setup_grid. larson-group/clubb#972 — Gunther Huebler / githubweb
Making some paramters_silhs variables available from the silhs api — Gunther Huebler / githubweb
Comment out setting of fatal error — noreply / githubweb
This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. — Gunther Huebler / githubweb
Changing the value of C_invrs_tau_shear from 0.02 to 0.15. — bmg2 / githubweb
Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. — Gunther Huebler / githubweb
Updated e3sm to fit the new clubb driver api — noreply / githubweb
Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that — bmg2 / githubweb
Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm — noreply / githubweb
Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 — Gunther Huebler / githubweb
Update the config_compilers.xml for carson. — noreply / githubweb
Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 — Gunther Huebler / githubweb
Making e3sm use the single column version of advance clubb core directly, since it does not want to use the interface version. larson-group/clubb#972 — Gunther Huebler / githubweb
Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 — Gunther Huebler / githubweb

#36 (Jan 19, 2022, 4:13:40 PM)

uh — Gunther Huebler / githubweb

#35 (Jan 19, 2022, 4:03:44 PM)

uh — Gunther Huebler / githubweb

#33 (Jan 19, 2022, 3:50:39 PM)

uh — Gunther Huebler / githubweb

#32 (Jan 19, 2022, 3:45:48 PM)

uh — Gunther Huebler / githubweb

#28 (Dec 29, 2021, 4:51:52 PM)

Change user namelist name from "user_nl_cam" to "user_nl_eam". — noreply / githubweb

#24 (Sep 30, 2021, 9:28:09 AM)

Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
Eliminating l_include_ice and sat_ice_ratio. — rhodesk / githubweb
Eliminating l_update_pressure flag. — rhodesk / githubweb
Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
Fixing small pathing error in log reading step. larson-group/sys_admin#735 — pbroels / githubweb
Updating the surface clipping coefficient... — noreply / githubweb
Updating the surface clipping coefficient... — noreply / githubweb
Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb
Adding in l_vary_convect_depth as requested. — 72510114+RhodesKeegan / githubweb
Reflecting changes made to clubb in host models — 72510114+RhodesKeegan / githubweb
Adding clubb directory for testing — 72510114+RhodesKeegan / githubweb
Removing clubb and silhs directory for tonight's merge — 72510114+RhodesKeegan / githubweb
Removing a couple of unused parameters from use statement. — noreply / githubweb
Removing a couple of unused parameters from use statement. — noreply / githubweb
Pushing k loop down through clip_variance_level. — rhodesk / githubweb
Pushing k loop down through clip_variance_level. — rhodesk / githubweb
Udpates to make it possible for us to keep certain parameters equal to each other during tuning. — 59519056+bstephens82 / githubweb
Udpates to make it possible for us to keep certain parameters equal to each other during tuning. — 59519056+bstephens82 / githubweb
Further tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included. — 59519056+bstephens82 / githubweb
Further tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included. — 59519056+bstephens82 / githubweb
Updating some comments related to the tuner updates. — 59519056+bstephens82 / githubweb
Updating some comments related to the tuner updates. — 59519056+bstephens82 / githubweb
Adding space to trigger autoupdate. larson-group/sys_admin#755 — Gunther Huebler / githubweb
Adding space to trigger autoupdate. larson-group/sys_admin#755 — Gunther Huebler / githubweb
Remove space to trigger autoupdate. larson-group/sys_admin#755 — noreply / githubweb
Add space to trigger nightly tests. For larson-group/sys_admin#755. — noreply / githubweb
I am fixing a bug that was introduced in 6b0348e, where the logical — bmg2 / githubweb

#23 (Aug 24, 2021, 12:09:22 PM)

Changing log reading proceedure since run logs for standard run test are not compressed. larson-group/sys_admin#735 — pbroels / githubweb

#21 (Aug 24, 2021, 11:04:18 AM)

For clubb:ticket:770, the Oracle compiler was throwing a floating point exception here. wpxp2 and xp2 were being fed in as Nans. — weberjk / githubweb
The new file calc_roots.F90 contains functions that solve for the roots of a — bmg2 / githubweb
I tweaked the precipitation fraction code so that the weighted ith PDF component — bmg2 / githubweb
For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j. — raut / githubweb
I updated pdf_closure_module.F90 by integrating changes I made in the — bmg2 / githubweb
For cam:ticket:36: — raut / githubweb
For cam:ticket:36#comment:132, I removed `gr` from the use statement in `setup_grid_heights_api`. — raut / githubweb
For clubb:ticket:773, I fixed some unsoundness in our code regarding kinds, specifically in `parameters_model.F90` and `endian.F90`. — raut / githubweb
For cam:ticket:41, the change in clubb:r7921 should be applied to the trunk as well. — raut / githubweb
For clubb:ticket:775: — raut / githubweb
For clubb:ticket:775: — raut / githubweb
Misc. code cleanup — raut / githubweb
I am updating default CLUBB to use the same hydrometeor PDF parameters that are — bmg2 / githubweb
For cam:ticket:50: — raut / githubweb
For cam:ticket:52: — raut / githubweb
For cam:ticket:52, I added some parameter indices to the API. — raut / githubweb
I forgot a parameter! — raut / githubweb
For clubb:ticket:753: — raut / githubweb
For clubb:ticket:782: — raut / githubweb
I forgot a flag. — raut / githubweb
For clubb:ticket:782: — raut / githubweb
For cam:ticket:55, I added some parameters to CLUBB's API. — raut / githubweb
For cam:ticket:55: — raut / githubweb
I cleaned up some warnings from the Mac compiler. (build:14977) — raut / githubweb
For clubb:ticket:785, I renamed `initvars` to `clubb_params_nl`. — raut / githubweb
For clubb:ticket:785: — raut / githubweb
For clubb:ticket:779: — raut / githubweb
For clubb:ticket:786: — raut / githubweb
For clubb:ticket:786: — raut / githubweb
For clubb:ticket:782, I added all CLUBB's parameter indices to the API. — raut / githubweb
helpful note — raut / githubweb
more helpful note — raut / githubweb
most helpful note — raut / githubweb
For cam:ticket:56: — raut / githubweb
While working on cam:ticket:59, I noticed that `tau_N2_zm` is computed twice. I removed one computation. — raut / githubweb
Dat crazy indentation, though... — raut / githubweb
For cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`. — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59, I added a new output for Richardson number. — raut / githubweb
For cam:ticket:59: — raut / githubweb
Per cam:ticket:59#comment:21, using `T_in_K_zm` in "the formula". — raut / githubweb
For cam:ticket:59. — raut / githubweb
For cam:ticket:59 I renamed `Richardson_no` to `Richardson_num`. — raut / githubweb
For cam:ticket:59, I added kludgy statistical output for `brunt_vaisala_freq_sqd`. — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59. — raut / githubweb
For cam:ticket:59: — raut / githubweb
Apparently, I didn't have to jump through the hoop of declaring a separate profile to use in the `max` statement. — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For clubb:ticket:782: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For clubb:ticket:782: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59, I fixed bugs in the `l_use_C7_Richardson=T` vertical averaging code: — raut / githubweb
I adjusted a comment. — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For cam:ticket:59: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:788: — raut / githubweb
Renamed C7 to Cx in appropriate places. — raut / githubweb
For cam:ticket:59: — raut / githubweb
For cam:ticket:59: — raut / githubweb
I made it a default to use 0 instead of cloud_frac_min in the B.V. frequency calculation. — raut / githubweb
For cam:ticket:67: — raut / githubweb
For cam:ticket:67: — raut / githubweb
Code improvements. — raut / githubweb
Vince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more! — raut / githubweb
For cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used. — raut / githubweb
Fixed a comment. — raut / githubweb
For clubb:ticket:788: — raut / githubweb
For clubb:ticket:792: — raut / githubweb
For clubb:ticket:792: — raut / githubweb
For clubb:ticket:792, I added more initializations for uninitialized variables. — raut / githubweb
When l_avg_Lscale is turned on but the plume-centered calculation is disabled, — bmg2 / githubweb
For clubb:ticket:792: — raut / githubweb
For clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output. — raut / githubweb
I renamed RH_postPDF to rel_humidity. — raut / githubweb
For clubb:ticket:792. rsat actually should be recomputed here before output, because it will change if `l_rcm_supersat_adj = T`. — raut / githubweb
For clubb:ticket:792. I am reusing the `rel_humidity` variable for output, for no particular reason. — raut / githubweb
For clubb:ticket:792!!!! I set `l_rcm_supersat_adj = T` by default, in both source code and namelist. — raut / githubweb
As requested, I am adding a warning message (debug level 1) when spurious supersaturation is removed. — raut / githubweb
Comment. — raut / githubweb
For clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010). — raut / githubweb
I removed a spurious print statement. — raut / githubweb
For cam:ticket:73: — raut / githubweb
I am beginning to generalize the sponge damping code so that it can be applied to — bmg2 / githubweb
I have added all the coding infrastructure to perform sponge damping (and record — bmg2 / githubweb
— Vince Larson / githubweb
clubb:ticket:796 — roessle9 / githubweb
I added some parameter value checking in subroutine setup_parameters. — bmg2 / githubweb
I finally have a standalone version of the new subroutine, generate_pdf_params, — bmg2 / githubweb
Some code within advance_clubb_core that is found within CAM_CLUBB preprocessor — bmg2 / githubweb
The perturbation Lscale code requires rtm_frz, thlm_frz, and pdf_params_frz to — bmg2 / githubweb
I added a missing intent(out) statement. — bmg2 / githubweb
I have interfaced the new subroutine containing all of the PDF closure-related — bmg2 / githubweb
I got rid of some variables that were brought into advance_clubb_core by use statements — bmg2 / githubweb
I cleaned up more compiler warnings for unused variables. The warnings came from g95. — bmg2 / githubweb
I have added a second call to subroutine generate_pdf_params. This one occurs — bmg2 / githubweb
I moved the setting of qclvar and thlprcp_out to after the second call to — bmg2 / githubweb
I have declared the l_use_ice_latent option and the l_call_pdf_closure_twice — bmg2 / githubweb
I added a local cslculation of sigma_sqd_w near the top of subroutine — bmg2 / githubweb
I am changing the inputs and outputs of subroutine advance_clubb_core so that — bmg2 / githubweb
I added code so that stats that are internal to subroutine generate_pdf_params — bmg2 / githubweb
I have updated subroutine advance_clubb_core so that pdf_params_zm is now passed — bmg2 / githubweb
Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical — savva / githubweb
Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical — savva / githubweb
— Vince Larson / githubweb
— Vince Larson / githubweb
I added a new subroutine, init_pdf_params, to pdf_parameter_module.F90. — bmg2 / githubweb
I renamed the subroutine pack_pdf_params found in setup_clubb_pdf_params.F90 — bmg2 / githubweb
I am now using the new subroutine init_pdf_params to initialize the — bmg2 / githubweb
I removed the CAM_CLUBB preprocessor directives from pack_pdf_params_api, — bmg2 / githubweb
clubb:ticket:800 -- Changed fatal errors statements to debug level 0. — savva / githubweb
I updated CLUBB stats so that wpthvp, wp2thvp, rtpthvp, and thlpthvp — bmg2 / githubweb
I have added the coding infrastructure to output additional statistics — bmg2 / githubweb
This is a bug fix for the Sun compiler. The variables pdf_params_zm and — bmg2 / githubweb
I am updating the hydrometeor PDF code to set mu_hm_1 and — bmg2 / githubweb
Running the Bitten tests. — bmg2 / githubweb
I added some comments so that CLUBB-SILHS would be consistent with — Vince Larson / githubweb
As a first step, I changed all instances of rrtthl to corr_rt_thl_1. — bmg2 / githubweb
I have added corr_rt_thl_2 to the code to go along with corr_rt_thl_2. — bmg2 / githubweb
I have added some code to add corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2 — bmg2 / githubweb
I added new statistics to the CLUBB _zt output files, specifically corr_w_rt_1, corr_w_rt_2, — bmg2 / githubweb
I am updating the equations for wp2rtp, wp2thlp, wprtp2, and wpthlp2 to include — bmg2 / githubweb
I am adding a special function to calculate the within-component correlation of — bmg2 / githubweb
I added variables corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 — bmg2 / githubweb
I am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to type — bmg2 / githubweb
Now that the PDF component correlations of w and chi, as well as w and eta, — bmg2 / githubweb
I am adding statistical output for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, — bmg2 / githubweb
I am changing the name of the flag l_fix_chi_eta_correlations to — bmg2 / githubweb
The two component normal (double Gaussian) PDF used by CLUBB will now be — bmg2 / githubweb
I moved the checking of the options for the PDF call placement to subroutine — bmg2 / githubweb
I am altering setup PDF parameters to be able to read in the values of — bmg2 / githubweb
I am adding the new file new_pdf.F90 to the CLUBB core directory. So far, it — bmg2 / githubweb
I am adding a large amount of code to the new PDF. I have filled in the driver — bmg2 / githubweb
I am adding code to the new PDF that calculates the minimum and maximum — bmg2 / githubweb
I added a new iiPDF entry for the new PDF, and I neatened some of the current — bmg2 / githubweb
I added an option to call the new PDF from subroutine pdf_closure. — bmg2 / githubweb
I had to add checking for the new PDF so someone does not try to run it — bmg2 / githubweb
I made a couple changes to (1) initialize two variables that aren't used by the — bmg2 / githubweb
I added a conditional to the subroutine that sets the responder parameters. — bmg2 / githubweb
I have added the beginnings of a new unit test for the PDF parameters. — bmg2 / githubweb
I have updated the PDF parameter unit test to make a call to the full PDF (for — bmg2 / githubweb
I have added a feature to the PDF parameter unit tests which allows the user — bmg2 / githubweb
In the setter variable description and subprograms, I made a name change from — bmg2 / githubweb
I have updated the method of calculating the setter variable so that mu_x_1 — bmg2 / githubweb
I added primarily some more documentation and notes. — bmg2 / githubweb
I added some more comments documenting the code. — bmg2 / githubweb
I got rid of some of the expressions that a script might try to flag as — bmg2 / githubweb
I added much more documentation about the responder variable. Specifically, — bmg2 / githubweb
I am adding the new file, original_pdf.F90, as the new home for the ADG1, ADG2, — bmg2 / githubweb
I have now switched the PDF closure code over to calling the code that had been — bmg2 / githubweb
I updated the documentation in the code comments for the setter method and — bmg2 / githubweb
I added a comment. — bmg2 / githubweb
I added a new function, calc_comp_corrs_binormal, to pdf_utilities.F90. This — bmg2 / githubweb
I added some more descriptive comments and a new function that calculates the — bmg2 / githubweb
I updated the code so that coef_sigma_x_1_sqd and coef_sigma_x_2_sqd are passed — bmg2 / githubweb
I fixed a mistake. — bmg2 / githubweb
I have added code to call the new function that calculates wp4 implicitly from — bmg2 / githubweb
I moved the calculations of wp2xp (wp2rtp and wp2thlp), wp4, and wpxp2 (wprtp2 — bmg2 / githubweb
I added another function to the new PDF. This function helps to calculate — bmg2 / githubweb
I added a special case for the wpxp2 implicit code. — bmg2 / githubweb
Back in clubb:r8409, the PDF component correlations of w and rt and w and — bmg2 / githubweb
I added a subroutine that calculates the implicit and explicit portions of the — bmg2 / githubweb
I renamed original_pdf.F90 as adg1_adg2_3d_luhar_pdf.F90. — bmg2 / githubweb
I added statistical output for F_w, F_rt, F_thl, min_F_w, max_F_w, min_F_rt, — bmg2 / githubweb
I split the new PDF into two files. I added a new file that currently houses — bmg2 / githubweb
I clipped temperature within the Goff-Gratch functions for saturation over liquid and ice. — Vince Larson / githubweb
I initialized some output variables in order to prevent a runtime error. — bmg2 / githubweb
I made a sub-driver level subroutine for the calculations necessary for a — bmg2 / githubweb
I added code to allow the variable (of w, rt, or theta-l) with the greatest — bmg2 / githubweb
I added calls to the functions and subroutines that calculate the implicit and — bmg2 / githubweb
I changed coef_wp2xp_explicit (coef_wp2rtp_explicit and coef_wp2thlp_explicit) — bmg2 / githubweb
I am adding a new file for the new trivariate skewness-dependent analaytic — bmg2 / githubweb
I fixed a bug in the new Trivariate skewness-dependent analytic double Gaussian — bmg2 / githubweb
In order for the TSDADG PDF to work correctly, when Skx * sgn( <w'x'> ) >= 0, — bmg2 / githubweb
In order to clarify coding in CLUBB, I am moving a block of code that is — bmg2 / githubweb
I am fixing a bug where rtp2 and thlp2 (and sclrp2) were not preserved when — bmg2 / githubweb
I updated the TSDADG PDF by adding the responding variable description, the — bmg2 / githubweb
When ADG1 or ADG2 are not used, we have to set alpha_rt, alpha_thl, and — bmg2 / githubweb
I am calling the new TSDADG PDF from subroutine pdf_closure. — bmg2 / githubweb
Clarity changes to the new TSDADG PDF. — bmg2 / githubweb
I added some references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
I fixed a bug in the calculation of PDF component variances in the new TSDADG — bmg2 / githubweb
I added more references to the CLUBB-SILHS tech doc. — Vince Larson / githubweb
I have set the tunable parameters F_x and zeta_x to skewness functions for the — bmg2 / githubweb
I needed to increase the limit of nvarmax_zt so that LBA (and other — bmg2 / githubweb
I changed the URL references to the CLUBB-SILHS overview document. — Vince Larson / githubweb
Changed variable and subroutine names, see ticket 810 and 811 — hoc_browser / githubweb
I have added the Lewellen and Yoh (1993) PDF to CLUBB for testing and comparison — bmg2 / githubweb
Fixed line length exceding 100 characters warnings — Gunther Huebler / githubweb
Changed the arrangement of variables in the subroutine compute_mixing_length as well as calls to it clubb:ticket:815 — Gunther Huebler / githubweb
Fixed lines exceeding 100 characters warnings clubb:ticket:815 — Gunther Huebler / githubweb
I added an option to incorporate the buoyancy term into CLUBB's eddy diffusivity for momentum. — Vince Larson / githubweb
I added c_K10 as a tuning parameter in front of the new momentum eddy diffusivity. — Vince Larson / githubweb
Removed unused parameters to clear warnings clubb:ticket:803 — Gunther Huebler / githubweb
I multiplied the eddy diffusivity for momentum by a skewness-dependent factor — Vince Larson / githubweb
I changed the way that F_rt and F_thl are set in the new PDF. They are now set — bmg2 / githubweb
I changed the flag setting on the new PDF so that it always uses w as the setter — bmg2 / githubweb
Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803 — Gunther Huebler / githubweb
Improved binary search algorithm clubb:ticket:818 — Gunther Huebler / githubweb
Added warning messages to function binary_search clubb:ticket:818 — Gunther Huebler / githubweb
Removed unused variables causing warnings clubb:ticket:803 — Gunther Huebler / githubweb
I updated the call to the new PDF so that Skrt and Skthl are intent INOUT — bmg2 / githubweb
Removed many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803 — Gunther Huebler / githubweb
I am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90. This — bmg2 / githubweb
I finished adding the units to the variable descriptions in — bmg2 / githubweb
The calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>, — bmg2 / githubweb
I added the tunable or adjustable parameters for the new PDF to CLUBB's list — bmg2 / githubweb
Fixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803 — Gunther Huebler / githubweb
I am committing a line of code that limits the adjusted correlation of rt and — bmg2 / githubweb
I implemented a new method to handle cumulus momentum fluxes. — Vince Larson / githubweb
Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804 — Gunther Huebler / githubweb
Removed file anl_erf.F90, it is no longer used — Gunther Huebler / githubweb
I am altering the solution to the wp3 predictive equation to calculate the — bmg2 / githubweb
I fixed the problem with the wp3 budgets as a result of r8584. The budgets in — bmg2 / githubweb
I altered the names of the turbulent advection functions that are closed by — bmg2 / githubweb
I added a couple comments about how the discretization of the turbulent — bmg2 / githubweb
I added the function that sets up the implicit calculation of the wp3 turbulent — bmg2 / githubweb
I added a function that calculates the explicit form of the wp3 turbulent — bmg2 / githubweb
I am adding a function to calculate the turbulent advection of wpxp explicitly. — bmg2 / githubweb
I am adding a function to calculate the turbulent advection of xp2 and xpyp — bmg2 / githubweb
I interfaced the wp3 explicit turbulent advection code with CLUBB. It is — bmg2 / githubweb
I am interfacing the wpxp explicit turbulent advection option with the rest of — bmg2 / githubweb
I fixed a small bug with the explicit turbulent advection option for wpxp. — bmg2 / githubweb
I am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code. — bmg2 / githubweb
I added the l_explicit_turbulent_adv_* family of flags to the new PDF, for some — bmg2 / githubweb
I am packing up the implicit coefficients and explicit terms calculated by the — bmg2 / githubweb
Made epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804 — Gunther Huebler / githubweb
I made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90. — bmg2 / githubweb
I have completed interfacing the implicit form of the wp3 turbulent advection — bmg2 / githubweb
When the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advection — bmg2 / githubweb
I cleaned up the Skx_module and added an additional function, — bmg2 / githubweb
I fixed a bug in the calculation of scalar skewness. It was being set to 0, — bmg2 / githubweb
I moved the location of the LG 2005 ansatz to calculate xp3 because it would be — bmg2 / githubweb
I reverted clubb:r8611 because (1) having the code in the other location — bmg2 / githubweb
I have added a new function, term_ta_new_pdf_lhs, to — bmg2 / githubweb
I have linked the implicit turbulent advection code for rtp2 and thlp2 to the — bmg2 / githubweb
I have added a new file that has two options for handling the xp3 term for — bmg2 / githubweb
I have interface the new xp3 code to the rest of CLUBB. It can be turned on — bmg2 / githubweb
I added a driver level subroutine for the new advance xp3 code. This will make — bmg2 / githubweb
I added budget stats for rtp3 and thlp3 to CLUBB. — bmg2 / githubweb
I am adding code that allows the turbulent advection of wpxp to be treated — bmg2 / githubweb
Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code. — Gunther Huebler / githubweb
Various small comment removals and returned some functionality to api interface clubb:ticket:800 — Gunther Huebler / githubweb
A variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800 — Gunther Huebler / githubweb
This is the first part of a two-part change. I am updating plotgen plots so — bmg2 / githubweb
In part 2 of this two part commit, I have added rc_coef to the list of — bmg2 / githubweb
Various debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800 — Gunther Huebler / githubweb
Check negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800 — Gunther Huebler / githubweb
I'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800 — Gunther Huebler / githubweb
Changed calls to parameterization check to work with the new check negative implementation clubb:ticket:800 — Gunther Huebler / githubweb
— Gunther Huebler / githubweb
Removed rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800 — Gunther Huebler / githubweb
Changed error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800 — Gunther Huebler / githubweb
Fixed unused variable warnings related to error code changes — Gunther Huebler / githubweb
I am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to account — bmg2 / githubweb
Added error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to keep track of error messages is multithreaded scenarios clubb:ticket:800 — Gunther Huebler / githubweb
In r8659, I accidentally overwrote some code. This commit restores the prior — bmg2 / githubweb
Sigh — bmg2 / githubweb
Added clubb debug level checks to error checking statements clubb:ticket:800 — Gunther Huebler / githubweb
Changed many stop commands to return commands and added more err_code checks clubb:ticket:800 — Gunther Huebler / githubweb
Reverted api changes that broke SAM and WRF — Gunther Huebler / githubweb
I am adding the semi-implicit formulation of wprtpthlp, which is the turbulent — bmg2 / githubweb
I am adding output statistics for the implicit and semi-implicit coefficients — bmg2 / githubweb
I corrected the units on a couple of implicit coefficients. — bmg2 / githubweb
I fixed a bug. — bmg2 / githubweb
Removed failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
Removed reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800 — Gunther Huebler / githubweb
I am fixing a bug with the CLUBB tuner. Variables that were allocated at the — bmg2 / githubweb
Completed the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800 — Gunther Huebler / githubweb
Made all debug levels produce the same output, see clubb:ticket:823 — Gunther Huebler / githubweb
I am moving type variable implicit_coefs_terms from new_pdf_main.F90 to — bmg2 / githubweb
Modified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802 — Gunther Huebler / githubweb
Added checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802 — Gunther Huebler / githubweb
This should fix the thlm out of bounds error on clubb:ticket:828 — Gunther Huebler / githubweb
I changed the name of type variable new_pdf_implct_coefs_terms to — bmg2 / githubweb
Changed T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828 — Gunther Huebler / githubweb
I added a flag option to clip the (large, negative) effects of microphysics on — bmg2 / githubweb
I added a flag option to calculate the minimum threshold for xp2 (rtp2 and — bmg2 / githubweb
I added a special max magnitude correlation for fluxes wprtp and wpthlp. This — bmg2 / githubweb
Made better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more information — Gunther Huebler / githubweb
This commit sets C8b=0.02, changes the non-linear damping on wp3 — Vince Larson / githubweb
Added a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829 — Gunther Huebler / githubweb
I am adding a general purpose function for the turbulent advection of CLUBB's — bmg2 / githubweb
I added/changed a couple comments for the rhs portion of the generalized — bmg2 / githubweb
The turbulent advection file that handles turbulent advection for predictive — bmg2 / githubweb
I added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, that — bmg2 / githubweb
Whoops, I forgot to make wpxpyp_zm and xpyp intent (in). — bmg2 / githubweb
Added functionality to make the hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830 — Gunther Huebler / githubweb
I am updating the code that advances predictive variances and covariances in — bmg2 / githubweb
Renamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830 — Gunther Huebler / githubweb
I am updating the code that advances predictive scalar fluxes (<w'x'>) in — bmg2 / githubweb
As a first step toward having code that can clip mean values of hydrometeor — bmg2 / githubweb
init_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562 — Gunther Huebler / githubweb
I have now interfaced the subroutine that I made out of the code that clips — bmg2 / githubweb
I added new code that clips the overall correlation of w and rt or the overall — bmg2 / githubweb
I added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which are — bmg2 / githubweb
Made clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800 — Gunther Huebler / githubweb
Reverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800 — Gunther Huebler / githubweb
Fixed nightly tests — Gunther Huebler / githubweb
I have added code to allow C2 to be adjusted by multiplying by the greater of — bmg2 / githubweb
I moved the location of the declaration and setting of new model flags to — bmg2 / githubweb
Improved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834 — Gunther Huebler / githubweb
Fixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834 — Gunther Huebler / githubweb
Actually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
Optimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834 — Gunther Huebler / githubweb
Reverted stats_clubb_utilities, accidental commit — Gunther Huebler / githubweb
This should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837 — Gunther Huebler / githubweb
— Vince Larson / githubweb
Impoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834 — Gunther Huebler / githubweb
This commit implements the effects of splatting on wp3. — Vince Larson / githubweb
I am making the first step toward committing code that allows for the option — bmg2 / githubweb
I added code to allow the option of predicting upwp and vpwp by using the — bmg2 / githubweb
I took the liberty of upgrading CLUBB's PDF closure and related code to a vector — bmg2 / githubweb
I updated the monotonic flux limiter to account for vector variables u and v. — bmg2 / githubweb
I am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output. — bmg2 / githubweb
In r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic flux — bmg2 / githubweb
I am turning on the l_predict_upwp_vpwp code! — bmg2 / githubweb
Improved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834 — Gunther Huebler / githubweb
Improved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834 — Gunther Huebler / githubweb
Changed the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834 — Gunther Huebler / githubweb
Added grid_class to the dependency lists of the pdf files that were changed in commit 8773 — Gunther Huebler / githubweb
Accidental commit, undoing 8783 — Gunther Huebler / githubweb
I am changing the default setting of flags l_min_wp2_from_corr_wx and — Brian Griffin / githubweb
Modified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834 — Gunther Huebler / githubweb
Removed print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases. — Gunther Huebler / githubweb
Changed the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834 — Gunther Huebler / githubweb
I am adding source code for the introduction of budgets for predictive upwp — Brian Griffin / githubweb
Improved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834 — Gunther Huebler / githubweb
Improved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834 — Gunther Huebler / githubweb
Modified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834 — Gunther Huebler / githubweb
Copied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834 — Gunther Huebler / githubweb
Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834 — Gunther Huebler / githubweb
Improved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834 — Gunther Huebler / githubweb
I made the surface splatting terms conservative. That is, I subtracted from wp2_sfc — Vince Larson / githubweb
I added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2. — Vince Larson / githubweb
This commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero). Hence it is BIT_CHANGING. — Vince Larson / githubweb
Added functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834 — Gunther Huebler / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
I clipped sigma_sqd_w to prevent interpolated values of it — Vince Larson / githubweb
I added a new option to diagnose the dissipation time scale, tau, first — Vince Larson / githubweb
I found a new way to diagnose upthvp. Instead of using a bound on correlations, it relies — Vince Larson / githubweb
introducing error into clubb core for testing larson-group/sys_admin#533 — mcfadd34 / githubweb
reverting error that was introduced larson-group/sys_admin#533 — mcfadd34 / githubweb
I am briefly changing some of the flag and parameter settings in CLUBB — bmg2 / githubweb
Revert "I am briefly changing some of the flag and parameter settings in CLUBB" — bmg2 / githubweb
I added a couple of comments reminding users to change the conditions in — bmg2 / githubweb
Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"" — bmg2 / githubweb
Revert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""" — bmg2 / githubweb
I committed a subroutine, diagnose_upxp, that calculates — Vince Larson / githubweb
Improved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834 — Gunther Huebler / githubweb
I am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a large — bmg2 / githubweb
I am updating the code within setup_clubb_pdf_parameters.F90 in order to take — bmg2 / githubweb
To diagnose uprcp using CLUBB's PDF machinery, — Vince Larson / githubweb
Continuing with diagnosis of uprcp using CLUBB's PDF, — Vince Larson / githubweb
More code to diagnose uprcp using CLUBB's PDF. — Vince Larson / githubweb
Correction for the last uprcp-related commit: — Vince Larson / githubweb
I am correcting the code so that the Nightly Uninitialized Variables Test — bmg2 / githubweb
I am continuing to pull parts of setup_pdf_parameters outside of a large "do" — bmg2 / githubweb
I am pulling statistical output subroutine pdf_param_ln_hm_stats outside — bmg2 / githubweb
Changing the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope. — Gunther Huebler / githubweb
commenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566 — mcfadd34 / githubweb
uncommenting threadprivate larson-group/sys_admin#566 — mcfadd34 / githubweb
I have changed the structure of setup_pdf_parameters so that the subroutine that — bmg2 / githubweb
Returned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING. — Gunther Huebler / githubweb
I am turning on the new calculation of uprcp that uses CLUBB's PDF. — Vince Larson / githubweb
I modified the code in setup_clubb_pdf_params.F90 to use only one call to — bmg2 / githubweb
I am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch to — bmg2 / githubweb
I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch — bmg2 / githubweb
I temporarily set l_clip_extreme_chi_sample_pts back to false in the — bmg2 / githubweb
Revert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the" — bmg2 / githubweb
I improved the error messages when LU decomp. fails within — bmg2 / githubweb
Improved error message prints in advance_xm_wpxp. — bmg2 / githubweb
I added improved LHS and RHS print statements when a LU decomp. error occurs — bmg2 / githubweb
I added params_list to the list of variables that are accessible through — bmg2 / githubweb
I am making the first step for updating the code that calculates sigma_sqd_w. — bmg2 / githubweb
I added a log-law height dependence to the code that diagnoses — Vince Larson / githubweb
I added fill_holes_hydromet_api to clubb_api_module.F90. — bmg2 / githubweb
I added a new python script, check_for_missing_threadprivate.py, — Vince Larson / githubweb
Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834 — Gunther Huebler / githubweb
Fixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834 — Gunther Huebler / githubweb
Added temp test file — noreply / githubweb
Remove test file — noreply / githubweb
Adding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical. — Gunther Huebler / githubweb
Optimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases. — Gunther Huebler / githubweb
ticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequency — guozhun / githubweb
Modifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855 — Gunther Huebler / githubweb
Replacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855 — Gunther Huebler / githubweb
Making procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855 — Gunther Huebler / githubweb
Missed one — Gunther Huebler / githubweb
I have added a new file, calc_pressure.F90, which contains code for initializing — bmg2 / githubweb
I updated CLUBB so that pressure is updated after mean fields have been — bmg2 / githubweb
Removing gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855 — Gunther Huebler / githubweb
Forgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855 — Gunther Huebler / githubweb
issue #842 — guozhun / githubweb
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. — guozhun / githubweb
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842) — guozhun / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly) — guozhun / githubweb
Efficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855 — Gunther Huebler / githubweb
This should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855 — Gunther Huebler / githubweb
An additional damping is added to the invrs_tau term in the C8 equation. ticket #842 — guozhun / githubweb
Adding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations. — Gunther Huebler / githubweb
We use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8. — guozhun / githubweb
Changing ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855 — Gunther Huebler / githubweb
Pulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855 — Gunther Huebler / githubweb
Renaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855 — Gunther Huebler / githubweb
Efficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855. — Gunther Huebler / githubweb
Modifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855 — Gunther Huebler / githubweb
Refactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855 — Gunther Huebler / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
I switched on direct diagnosis of tau rather than Lscale. — Vince Larson / githubweb
I updated the pressure initialization for cases that use sounding that is given — bmg2 / githubweb
I changed the function calculate_thvm from a pre-defined vector of size nz to — bmg2 / githubweb
I updated the calculation of thvm in advance_clubb_core to use the — bmg2 / githubweb
Adding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler. — Gunther Huebler / githubweb
Adding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855 — Gunther Huebler / githubweb
Changing where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626 — Gunther Huebler / githubweb
I am committing a test where I changed subroutine ADG1_w_closure — bmg2 / githubweb
Changing determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862 — Gunther Huebler / githubweb
Finally fixing line length error in pdf_closure — Gunther Huebler / githubweb
Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861 — Gunther Huebler / githubweb
Adding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862 — Gunther Huebler / githubweb
This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc. — guozhun / githubweb
Update advance_helper_module.F90 — noreply / githubweb
Update advance_clubb_core_module.F90 — noreply / githubweb
Update advance_helper_module.F90 — noreply / githubweb
Adding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626 — Gunther Huebler / githubweb
I am adding a file for the new hybrid PDF, which combines the w equation set — bmg2 / githubweb
I updated the function to calculate the implicit coefficient for the wp4 term, — bmg2 / githubweb
I made some changes to new_hybrid_pdf.F90 so that it would compile in its — bmg2 / githubweb
I edited that subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
I updated the subroutine that calculates the implicit coefficient and explicit — bmg2 / githubweb
Replaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves. — nselke / githubweb
I am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the new — bmg2 / githubweb
I worked more the functions for the new hybrid PDF. — bmg2 / githubweb
Refactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855 — Gunther Huebler / githubweb
I changed all the PDF utility functions in pdf_utilities.F90 to elemental — bmg2 / githubweb
I forgot a "then" to go with an "elseif". — bmg2 / githubweb
Adding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855 — Gunther Huebler / githubweb
Adding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855 — Gunther Huebler / githubweb
Refactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855 — Gunther Huebler / githubweb
I am continuing to build the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
I am continuing to work on the driver file for the new hybrid PDF. — bmg2 / githubweb
I have completed the main parts of the driver subroutine for the new hybrid PDF. — bmg2 / githubweb
The code for the new hybrid PDF now compiles. — bmg2 / githubweb
I added an entry for the new hybrid PDF. — bmg2 / githubweb
I have added the new hybrid PDF to the G unit tests. — bmg2 / githubweb
Mathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0. — bmg2 / githubweb
I added code to interface the call to the new hybrid PDF with pdf_closure — bmg2 / githubweb
I interfaced the implicit coefficients and explicit terms used in the turbulent — bmg2 / githubweb
I fixed a small error. The code compiles again now. — bmg2 / githubweb
Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group — pbroels / githubweb
I have added code that allows CLUBB to run interactively using the new hybrid — bmg2 / githubweb
I am updating the subroutine that calculates PDF component means and standard — bmg2 / githubweb
I placed proper thresholding on interpolated up2 and interpolated vp2 — bmg2 / githubweb
I added a limiter to keep the maximum magnitude of the correlations of — bmg2 / githubweb
I upgraded Nc_Ncn_eqns.F90 to use elemental functions. — bmg2 / githubweb
The new hybrid PDF also uses this bit of code that sets the correlation — bmg2 / githubweb
I made modifications to the new hybrid PDF so that that calculation of F_w — bmg2 / githubweb
I added the ability to handle scalars interactively to the new hybrid PDF. — bmg2 / githubweb
I found a couple of spots in the new hybrid PDF where I needed to add — bmg2 / githubweb
I added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90. — bmg2 / githubweb
The variable type implicit_coefs_terms needs to be made public — bmg2 / githubweb
I changed the value of the coefficient in the F_w equation to 0.45 — bmg2 / githubweb
I am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_core — bmg2 / githubweb
I have started the process of adding the coding infrastructure — bmg2 / githubweb
I have completed the addition of the ability to use different up2 — bmg2 / githubweb
I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856 — nselke / githubweb
I made the l_calc_w_corr code (turned off by default) run again by — bmg2 / githubweb
I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute. — nselke / githubweb
I have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac', — nselke / githubweb
I continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm', — nselke / githubweb
I continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm', — nselke / githubweb
I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp', — nselke / githubweb
Finished altering argument lists. This commit covers the final seven flags, which are in different namelists. — nselke / githubweb
I introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type. — nselke / githubweb
I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856 — nselke / githubweb
I fed pdf_params_frz into subroutine advance_clubb_core — Vince Larson / githubweb
Adding error code to arguement list of non-api routines where it was included in the api version. — Gunther Huebler / githubweb
Moving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal. — Gunther Huebler / githubweb
Added use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public. — Steffen Domke / githubweb
I have fixed the warnings for lines exceeding 100 characters. — nselke / githubweb
Passing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity. — Gunther Huebler / githubweb
Trivial update to test if cams autoupdate works — noreply / githubweb
Revert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch" — bmg2 / githubweb
I placed E3SM preprocessor commands around E3SM-specific code in — bmg2 / githubweb
Restoring assertion check for the vertical correlation calculation. larson-group/clubb#869 — Gunther Huebler / githubweb
Changing the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869 — Gunther Huebler / githubweb
I added E3SM's clubb_ parameters that can be read in from the — bmg2 / githubweb
I added the remainder the clubb_ terms that were added previously to — bmg2 / githubweb
Changing error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869 — Gunther Huebler / githubweb
Small updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Redoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Adding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
Simple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869 — Gunther Huebler / githubweb
Small performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Removing lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869 — Gunther Huebler / githubweb
Update latin_hypercube_driver_module.F90 — noreply / githubweb
Update parameters_tunable.F90 — noreply / githubweb
GPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
Making some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869 — Gunther Huebler / githubweb
I changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874 — nselke / githubweb
I added the new l_update_pressure configurable flag to clubb_config_flags. — bmg2 / githubweb
I added some code I used in the special input fields branch to make — bmg2 / githubweb
An improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875] — guozhun / githubweb
I revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874. — nselke / githubweb
I got rid of the "allocatable", "allocate", and "deallocate" statements — bmg2 / githubweb
I placed an ifndef CLUBB_CAM preprocessor flag around the code in — bmg2 / githubweb
I reduced the minimum possible value of lmin from 4.0 to 1.0. — noreply / githubweb
I made a print/write statement debug level 3 — noreply / githubweb
I made a second print/write statement debug level 3 — noreply / githubweb
I fix a print/write statement debug level3. For #755 and #800 — guozhun / githubweb
I am replacing the "use" statements that referenced — bmg2 / githubweb
I "brought back the stats" by passing the stats from advance_clubb_core — bmg2 / githubweb
Removing the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref) — bmg2 / githubweb
Results were changed yesterday for some cases because thlprcp was — bmg2 / githubweb
I have resolved all the issues surrounding recent CLUBB commits that — bmg2 / githubweb
I removed code that stops a run if the output time step is less than a minute. — noreply / githubweb
I removed references to variables_prognostic_module and — bmg2 / githubweb
Fixed a boo-boo. — bmg2 / githubweb
I set `l_diag_Lscale_from_tau = .true.` in source code — noreply / githubweb
I removed references to variable_diagnostic_module for various Kessler — bmg2 / githubweb
I removed the reference to use variables_diagnostic_module for Kh_zm — bmg2 / githubweb
Removed a reference to variables_diagnostic_module for Kh_zm in — bmg2 / githubweb
I am able to remove references to variables_prognostic_module and — bmg2 / githubweb
I removed the l_use_ice_latent flag from the code, and along with it — bmg2 / githubweb
I have completed the project of removing variables_prognostic_module — bmg2 / githubweb
I added some missing threadprivate statements — noreply / githubweb
I have taken the code from wp2_term_ta_all and placed it in the subroutine — bmg2 / githubweb
I am updating wp3_term_ta_new_pdf_lhs to use the optimized code from — bmg2 / githubweb
This commit is BIT_CHANGING. It makes the parameter values in parameters_tunable.F90 agree with those in tunable_parameters.in — benjamin.andrew.stephens / githubweb
I am making the change of using tau_wp2_zm to damp up2 and vp2, — bmg2 / githubweb
I have added the integer flags iiPDF_type and ipdf_call_placement — bmg2 / githubweb
I am going to make primary PDF type options and primary PDF call — bmg2 / githubweb
I added E3SM customizations to CLUBB's master branch. This is meant — bmg2 / githubweb
I am updating the clubb_ list of namelist parameters used in E3SM — bmg2 / githubweb
Typo — bmg2 / githubweb
Fixed more typos — bmg2 / githubweb
I am changing the new hybrid PDF's calculation of F_w to use — bmg2 / githubweb
I updated the xp3 calculation for PDF types other than ADG1. — bmg2 / githubweb
This xp3_coef_ parameters produce new hybrid PDF results similar to the old — bmg2 / githubweb
I added the 2 new parameters in the simple xp3 equation (for PDF — bmg2 / githubweb
I have combined the wp3_term_ta_ADG1_lhs and wp3_term_ta_ADG1_lhs_all — bmg2 / githubweb
I added the partially upwinded implementation of the wp3 turbulent advection — bmg2 / githubweb
Removed unused module imports — isenfireldc / githubweb
Removed unused module imports — isenfireldc / githubweb
Removed a comma that I missed while removing unused imports (#878) — isenfireldc / githubweb
I am adding l_partial_upwind_wp3 to the list of clubb_config_flags. — bmg2 / githubweb
Deprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129 — Gunther Huebler / githubweb
I started the process of paring 2 subprograms back down to 1 in — bmg2 / githubweb
I pared two more sets of equivalent subprograms down to 1 (each). — bmg2 / githubweb
Paring down 2 equivalent subprograms to 1 again. — bmg2 / githubweb
I condensed two more sets of doubled subprograms down to 1 (each) — bmg2 / githubweb
Reduced two more sets of "doubled" subprograms down. — bmg2 / githubweb
Updating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129 — Gunther Huebler / githubweb
Adding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129 — Gunther Huebler / githubweb
I updated CLUBB's copyright date range. — noreply / githubweb
Adding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129 — Gunther Huebler / githubweb
Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
Removed unused parameters [-Wunused-parameter] — isenfireldc / githubweb
Taking more duplicated subprograms and paring them down to 1. — bmg2 / githubweb
Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
Replaced real checks with an epsilon approach [-Wcompare-reals] — isenfireldc / githubweb
Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
Removed unused imports [-Wunused-parameter] — isenfireldc / githubweb
Removed styleguide violations from my code — isenfireldc / githubweb
Fixed a backwards epsilon comparison from 8e8e71e — isenfireldc / githubweb
Removed the "doubling" of the remainder of the subprograms from — bmg2 / githubweb
Changing epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878 — Gunther Huebler / githubweb
Small changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129 — Gunther Huebler / githubweb
Changed the length of solve_type_str to 20 [-Wcharacter-trucation] — isenfireldc / githubweb
Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
Removed unused arguments [-Wunused-dummy-argument] — isenfireldc / githubweb
Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
Removed unused variables [-Wunused-variable] — isenfireldc / githubweb
I have tidied up advance_wp2_wp3_module.F90, and I have removed all doubled — bmg2 / githubweb
Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
Removed continue and undid edits to _api fuction signatures — isenfireldc / githubweb
I handled the "doubled" subprograms in turbulent_adv_pdf.F90. — bmg2 / githubweb
Making change explained in larson-group/clubb#878 — Gunther Huebler / githubweb
Removed some unused variables (ifort) — isenfireldc / githubweb
Removed some unused variables (ifort) — isenfireldc / githubweb
Adding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129 — Gunther Huebler / githubweb
Removed unused import [-Wunused-variable] — isenfireldc / githubweb
Removes unused function calc_cloud_frac [-Wunused-function] — isenfireldc / githubweb
Fixes style issue — isenfireldc / githubweb
Removed import without only as it was unused — isenfireldc / githubweb
Adds mpishorthand back with only, it appears to be used somewhere — isenfireldc / githubweb
I have pared two subprograms down to one again, this time for the — bmg2 / githubweb
I pared down subprogram pairs again, this time for mean advection. — bmg2 / githubweb
I added altitude_threshold to the list of CLUBB's tunable parameters. — bmg2 / githubweb
Updating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots. — strike / githubweb
Updating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be). — strike / githubweb
Adds more debug lines — isenfireldc / githubweb
Removes debug lines — isenfireldc / githubweb
Adds debug lines and changes format — isenfireldc / githubweb
Modifies debug line — isenfireldc / githubweb
Modifies debug line — isenfireldc / githubweb
Initialize ncf%ntimes to 0 when opening netcdf for writing — isenfireldc / githubweb
Removes debug lines — isenfireldc / githubweb
Changes length of units variable in stat_file_module from 20 to 25 — isenfireldc / githubweb
This commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true. A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines. — benjamin.andrew.stephens / githubweb
Adding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close. This will aid in implementing the SILHS 2D output subroutines in host models. The new API subroutines necessitated some minor changes in clubb_driver.F90 as well. Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo). — benjamin.andrew.stephens / githubweb
I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
I updated the stats code in setup_clubb_pdf_params.F90 and in — bmg2 / githubweb
This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. — benjamin.andrew.stephens / githubweb
Undoing accidental find and replace. larson-group/cam#129 — Gunther Huebler / githubweb
Updated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832 — nchief / githubweb
Fix super serious 1 character bug that broke all of the things — strike / githubweb
I am committing Zhun's changes to the CLUBB portion of his — bmg2 / githubweb
Update stats_zm_module.F90 — noreply / githubweb
I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max — bmg2 / githubweb
I connected the new tunable parameters to advance_helper_module.F90. — bmg2 / githubweb
I added l_use_shear_Richardson to CLUBB's configurable model flags. — bmg2 / githubweb
Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs. — benjamin.andrew.stephens / githubweb
In order to prevent dycoms2_rf02_so from crashing, — Vince Larson / githubweb
I updated the recording of the budget terms for upwp_pr4 and vpwp_pr4. — Vince Larson / githubweb
Adding the smooth_min and smooth_max functions to the repo. These are not yet implemented in CLUBB but are now available for use and testing. See issue #894. — benjamin.andrew.stephens / githubweb
Adding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions. See issue #894. — benjamin.andrew.stephens / githubweb
Modifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129 — Gunther Huebler / githubweb
This commit replaces division by tau with multiplication by inverse tau in most cases. It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files. Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine. — benjamin.andrew.stephens / githubweb
I am committing a bug fix to the invrs_tau_zm equation that was — bmg2 / githubweb
CLUBB and pyplotgen changes: — benjamin.andrew.stephens / githubweb
I fixed the LMM stepping bug that was affecting E3SM (because — bmg2 / githubweb
Fixed alignment. — bmg2 / githubweb
This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90. — benjamin.andrew.stephens / githubweb
Update parameter_indices.F90 — noreply / githubweb
Update model_flags.F90 — noreply / githubweb
Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884. — benjamin.andrew.stephens / githubweb
Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901. — benjamin.andrew.stephens / githubweb
I am now passing vert_decorr_coef into SILHS instead of involving — bmg2 / githubweb
This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39). Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before. I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up). — benjamin.andrew.stephens / githubweb
Adding a test to make sure new C_uu_buoy parameter is within the valid range. See #901. — benjamin.andrew.stephens / githubweb
This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. — benjamin.andrew.stephens / githubweb
This will allow for a better interface of SILHS parameter — bmg2 / githubweb
Fixed a preprocessor command. — bmg2 / githubweb
I'm adding the api entry for read_silhs_parameters, called — bmg2 / githubweb
Revert "I'm adding the api entry for read_silhs_parameters, called" — bmg2 / githubweb
Revert "Fixed a preprocessor command." — bmg2 / githubweb
Revert "This will allow for a better interface of SILHS parameter" — bmg2 / githubweb
I updated silhs_api_module so that vert_decorr_coef is publically available — bmg2 / githubweb
Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902. — benjamin.andrew.stephens / githubweb
Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. — benjamin.andrew.stephens / githubweb
Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129 — Gunther Huebler / githubweb
Update parameters_tunable.F90 — noreply / githubweb
Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129 — Gunther Huebler / githubweb
Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129 — Gunther Huebler / githubweb
Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
Changes non-success `stop` statements to `error stop` — Vince Larson / githubweb
Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902. — 59519056+bstephens82 / githubweb
Turning on wp3 pr_turb term. — benjamin.andrew.stephens / githubweb
Changed the variable up2_vp2_factor to up2_sfc_coef in all files — rhodesk / githubweb
I added an option to improve dry, convecting boundary layers. — Vince Larson / githubweb
This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2. In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1. This makes the terms in these equations more consistent with the terms in the wp2 equation. I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped). — Vince Larson / githubweb
Changed surface to sfc in all instances where requested — rhodesk / githubweb
Undid sfc change in stats_sfc_module.F90 — noreply / githubweb
Undid sfc change to grid_class.F90 — noreply / githubweb
Undid sfc change in numerical_check.F90 — noreply / githubweb
Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129 — Gunther Huebler / githubweb
Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Fixed typo bug. larson-group/cam#129 — Gunther Huebler / githubweb
Pushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
More pushing loops down. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
More loop pushing. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Adding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129 — Gunther Huebler / githubweb
More loop pushing, all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions. — Gunther Huebler / githubweb
Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled. — Gunther Huebler / githubweb
Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129 — Gunther Huebler / githubweb
Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Performance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Reducing operations. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Adding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Some small cleanup, all just formatting. larson-group/cam#129 — Gunther Huebler / githubweb
Changed ustar from an array to a scalar issue #909 — rhodesk / githubweb
Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909 — rhodesk / githubweb
Created new subroutine and ensured it's BFB. All cases run sucessfully #909 — rhodesk / githubweb
added in missing flag which was causing memory errors #909 — rhodesk / githubweb
confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909 — rhodesk / githubweb
Update stats_zm_module.F90 — noreply / githubweb
Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129 — Gunther Huebler / githubweb
Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129 — Gunther Huebler / githubweb
Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129 — Gunther Huebler / githubweb
Reformatted mixing length to be more compliant with the coding standard #909 — rhodesk / githubweb
added a reference to new subroutine #909 — rhodesk / githubweb
Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 — Gunther Huebler / githubweb
Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
Fixing lines that exceed 100 characters. — Gunther Huebler / githubweb
Pushing loops related to pdf_params down. larson-group/cam#129 — Gunther Huebler / githubweb
clubb warnings introduced from merge have been removed #909 — rhodesk / githubweb
Changed safeguard threshold in sigma_sqd_w. — rhodesk / githubweb
Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. — 59519056+bstephens82 / githubweb
Adding new coefficient to control the wp3 pressure diffusion term. — 59519056+bstephens82 / githubweb
Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. — 59519056+bstephens82 / githubweb
Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. — 59519056+bstephens82 / githubweb
Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). — 59519056+bstephens82 / githubweb
These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. — 59519056+bstephens82 / githubweb
Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. — 59519056+bstephens82 / githubweb
Added intent comments for the following files: — rhodesk / githubweb
Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core. Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs). This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated. — benjamin.andrew.stephens / githubweb
Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90. — benjamin.andrew.stephens / githubweb
Fixed comment regarding wp3 splatting term. — benjamin.andrew.stephens / githubweb
Added intent comments. — rhodesk / githubweb
Added intent comments. — rhodesk / githubweb
Added intent comments for advance_xp2_xpyp_module.F90. — rhodesk / githubweb
Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface. — 59519056+bstephens82 / githubweb
Deleting comments around the old "magic number" for the near-surface clipping. — 59519056+bstephens82 / githubweb
Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928. — Gunther Huebler / githubweb
Changed some elements of clubb to allow for better script execution — rhodesk / githubweb
Fixed clubb not compiling — rhodesk / githubweb
Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
Feeding gr through the arg list where need only in the CLUBB_core dir. — rhodesk / githubweb
Reverted changes to clubb_api. For #886 — rhodesk / githubweb
Replacing use gr statements with feeding gr throught the arg list. — rhodesk / githubweb
Adding proper indentation to needed files. — rhodesk / githubweb
Fixing spacing issue on blank lines. #886 — rhodesk / githubweb
Fixed comment changes. #886 — rhodesk / githubweb
Fixed incorrect spacing on use — rhodesk / githubweb
Revert "Fixed incorrect spacing on use" — rhodesk / githubweb
Fixed spacing — rhodesk / githubweb
Fixed spacing going too far — rhodesk / githubweb
Fixed comments being pushed over — rhodesk / githubweb
Fixed not all variables being indented properly — rhodesk / githubweb
Fixed indentation going beyond variables — rhodesk / githubweb
Fixed file_functions indentation being off — rhodesk / githubweb
Fixed indentation on operations being wrong — rhodesk / githubweb
Reverted incorrect changes to new_pdf and new_hybrid_pdf — rhodesk / githubweb
Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
Fixed spacing issue when adding in gr. BFB identical. For #886. — rhodesk / githubweb
Removing gr as a module variable from grid_class. — rhodesk / githubweb
Removing gr as a module variable from grid_class. — rhodesk / githubweb
Fixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format. — benjamin.andrew.stephens / githubweb
Fixing a typo from an earlier commit. — noreply / githubweb
Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
Feeding gr through arg list for functions outside of CLUBB_core. — rhodesk / githubweb
Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB. — rhodesk / githubweb
The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken. — rhodesk / githubweb
Add error header for CLUBB in CAM — noreply / githubweb
Fixing the ordering of gr in the clubb_api arg list for affected subroutines. — rhodesk / githubweb
Fixing coding standard violations — rhodesk / githubweb
Improving error messages in setup_clubb_core. larson-group/e3sm#38 — Gunther Huebler / githubweb
Feeding stats variables through the argument lists of needed subroutines. — 72510114+RhodesKeegan / githubweb
Fixing spacing issues along with placing the stats varibales on their own lines. — 72510114+RhodesKeegan / githubweb
Changing more subroutines to include stats vars in their arg lists. — 72510114+RhodesKeegan / githubweb
Fixing incorrect subroutine arg list — 72510114+RhodesKeegan / githubweb
Fixing host models not compiling. — 72510114+RhodesKeegan / githubweb
Fixing argument list so that way the coding standard is upheld. — 72510114+RhodesKeegan / githubweb
I changed the name to calc_responder_driver because I thought that — bmg2 / githubweb
Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920. — 59519056+bstephens82 / githubweb
Fixing comment for the wp2_term_pr_dfsn subroutine. Related to #920. — 59519056+bstephens82 / githubweb
Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. — 59519056+bstephens82 / githubweb
Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920. — 59519056+bstephens82 / githubweb
Fixing some comments. — 59519056+bstephens82 / githubweb
Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. — benjamin.andrew.stephens / githubweb
Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. — 59519056+bstephens82 / githubweb
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. — 59519056+bstephens82 / githubweb
Removing l_interp_prescribed_params from setup_clubb_pdf_params. — rhodesk / githubweb
Adding comments labeling subroutine calls with intent. — rhodesk / githubweb
Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
Removing unnecessary constant from use statement — noreply / githubweb
Eliminating l_nu_grid_dependent as requested. — rhodesk / githubweb
Eliminating l_use_buoy_mod_Km_zm. — rhodesk / githubweb
Eliminating l_iter_xp2_xpyp flag. — rhodesk / githubweb
Eliminating l_apply_rule_to_pdf_params flag. — rhodesk / githubweb
Eliminating l_ub_const_deriv flag. — rhodesk / githubweb
Eliminating l_equation_21 flag. — rhodesk / githubweb
Eliminating l_wp3_2nd_buoyancy flag. — rhodesk / githubweb
Eliminating l_refine_grid_in_cloud and l_interactive_refined. — rhodesk / githubweb
Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds — rhodesk / githubweb
Eliminating l_use_wp3_pr3 flag. — rhodesk / githubweb
Eliminating l_clip_semi_implicit flag. — rhodesk / githubweb
Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
Eliminating l_single_C2_Skw flag. — 72510114+RhodesKeegan / githubweb
Eliminating l_include_ice and sat_ice_ratio. — rhodesk / githubweb
Raw-copy updating components/cam/src/physics/clubb — LarsonGroupSysAdmin / githubweb
Raw-copy updating components/cam/src/physics/silhs — LarsonGroupSysAdmin / githubweb
Swapping out old intel varible pathing script for the new intel version. — pbroels / githubweb
Eliminating l_update_pressure flag. — rhodesk / githubweb
Reflecting changes made to clubb in host models — rhodesk / githubweb
Raw-copy updating components/cam/src/physics/clubb — LarsonGroupSysAdmin / githubweb
Eliminating l_upwind_wpxp_ta flag. — rhodesk / githubweb
Reflecting changes made to clubb in host models — rhodesk / githubweb
Adding steps to display the logs. larson-group/sys_admin#735 — pbroels / githubweb

#18 (Aug 16, 2021, 1:28:46 PM)

Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920. — 59519056+bstephens82 / githubweb
Fixing comment for the wp2_term_pr_dfsn subroutine. Related to #920. — 59519056+bstephens82 / githubweb
Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. — 59519056+bstephens82 / githubweb
Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920. — 59519056+bstephens82 / githubweb
Fixing some comments. — 59519056+bstephens82 / githubweb
Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. — benjamin.andrew.stephens / githubweb
Feeding stats variables to needed subroutines — 72510114+RhodesKeegan / githubweb
Fixing compiliation errors — 72510114+RhodesKeegan / githubweb
Fixing compiliation errors — 72510114+RhodesKeegan / githubweb
Reflecting changes to nightly tests clubb_intr — 72510114+RhodesKeegan / githubweb
Removing updated clubb and silhs directories — 72510114+RhodesKeegan / githubweb
Fixing incorrect coding standard — 72510114+RhodesKeegan / githubweb
Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
Moving the stats variables to module variables of clubb_driver. — 72510114+RhodesKeegan / githubweb
Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
Fixing coding standard viloation of lines exceeding 100 characters. — rhodesk / githubweb
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. — 59519056+bstephens82 / githubweb
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. — 59519056+bstephens82 / githubweb
Removing l_interp_prescribed_params from setup_clubb_pdf_params. — rhodesk / githubweb
Adding comments labeling subroutine calls with intent. — rhodesk / githubweb
Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
Removing unnecessary constant from use statement — noreply / githubweb
Update the diagnostic. Put white boxes on global plot for all regions. Issue #36. — guozhun / githubweb
Eliminating l_nu_grid_dependent as requested. — rhodesk / githubweb
Eliminating l_use_buoy_mod_Km_zm. — rhodesk / githubweb
Eliminating l_iter_xp2_xpyp flag. — rhodesk / githubweb
Eliminating l_apply_rule_to_pdf_params flag. — rhodesk / githubweb
Eliminating l_ub_const_deriv flag. — rhodesk / githubweb
Eliminating l_equation_21 flag. — rhodesk / githubweb
Eliminating l_wp3_2nd_buoyancy flag. — rhodesk / githubweb
Eliminating l_refine_grid_in_cloud and l_interactive_refined. — rhodesk / githubweb
Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds — rhodesk / githubweb
Eliminating l_use_wp3_pr3 flag. — rhodesk / githubweb
Eliminating l_clip_semi_implicit flag. — rhodesk / githubweb
Adding intent labels for subroutines throughout clubb. — rhodesk / githubweb
Commiting to test host models — 72510114+RhodesKeegan / githubweb
Reverting changes to clubb and silhs — 72510114+RhodesKeegan / githubweb

#11 (Jul 26, 2021, 12:06:22 PM)

Reflecting changes to nightly tests clubb_intr — rhodesk / githubweb

#10 (Jul 26, 2021, 11:53:08 AM)

Fixing compiliation errors — rhodesk / githubweb

#9 (Jul 26, 2021, 11:49:11 AM)

Fixing compiliation errors — rhodesk / githubweb

#6 (Jul 21, 2021, 3:02:56 PM)

Commiting to test host models — rhodesk / githubweb

#5 (Jul 21, 2021, 2:55:59 PM)

Commiting to test host models — rhodesk / githubweb

#4 (Jul 21, 2021, 2:48:05 PM)

Commiting to test host models — rhodesk / githubweb

#3 (Jul 20, 2021, 1:20:31 PM)

Commiting to test host models — rhodesk / githubweb