Skip to content
Success

Changes

Summary

  1. This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39).  Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before.  I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up). (details)
Commit bea4ae0588cdc6758927c5c55cd7edcfb8c48c12 by benjamin.andrew.stephens
This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39).  Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before.  I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up).

This commit is BIT_CHANGING, similar to the previous commit, because of the order-of-operations change in the pr2 term for up2 and vp2.  This leaves more stable cases like BOMEX bit-for-bit identical, but changes outcomes for more senstive cases like ARM_97.

See issue #901.
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)