Skip to content
Success

Changes

Summary

  1. Err code struct (#1238) (details)
  2. Fix that causes BFB GPU tests to break. We need to copy these variables to the CPU before outputtin to disk. It's very unclear why the BFB GPU test ever passed without this. (details)
Commit dbf71d44dd03cd50b69bcb1d20378cb5679b9bf8 by noreply
Err code struct (#1238)

Added err_info type to CLUBB to extend old err_code integer flag
CLUBB ticket #975

Created a new err_info type replacing the old err_code integer.
It contains MPI rank and (OMP) chunk index so we can identify the specific process that caused an error.
It also contains latitude and longitude so a person trying to debug a host model run can pinpoint the column that caused an error.
It contains error headers that combine all the info into a string that can be printed when an error happens.
And it comes with subroutines that handle initialization, value setting, and cleanup.

Host models will be modified accordingly.

Possible TODO: Implement a subroutine that identifies the index of the column with the error after the fact so we can have more specific info at the higher call levels by applying `where` to the err_code member array.
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/SILHS/silhs_api_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/grid_adaptation.F90 (diff)
The file was modified src/CLUBB_core/setup_clubb_pdf_params.F90 (diff)
The file was modified src/clubb_thread_test.F90 (diff)
The file was modified src/advance_microphys_module.F90 (diff)
The file was modified src/Benchmark_cases/atex.F90 (diff)
The file was modified src/SILHS/output_2D_samples_module.F90 (diff)
The file was modified src/CLUBB_core/advance_windm_edsclrm_module.F90 (diff)
The file was modified src/SILHS/latin_hypercube_driver_module.F90 (diff)
The file was addedutilities/parse_argument_list/replace_err_code_type.py
The file was modified src/CLUBB_core/pdf_closure_module.F90 (diff)
The file was modified src/generalized_grid_test.F90 (diff)
The file was modified src/jacobian.F90 (diff)
The file was addedsrc/CLUBB_core/err_info_type_module.F90
The file was modified src/pdf_hydromet_microphys_wrapper.F90 (diff)
The file was modified src/CLUBB_core/matrix_solver_wrapper.F90 (diff)
The file was modified src/error.F90 (diff)
The file was modified src/CLUBB_core/grid_class.F90 (diff)
The file was modified src/CLUBB_core/corr_varnce_module.F90 (diff)
The file was modified src/CLUBB_core/output_netcdf.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/mono_flux_limiter.F90 (diff)
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified src/simple_rad_module.F90 (diff)
The file was modified src/CLUBB_core/numerical_check.F90 (diff)
The file was modified src/CLUBB_core/lapack_wrap.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/clubb_standalone.F90 (diff)
The file was modified src/CLUBB_core/mixing_length.F90 (diff)
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
The file was modified src/CLUBB_core/precipitation_fraction.F90 (diff)
The file was modified src/G_unit_test_types/rev_direction_grid_test.F90 (diff)
The file was modified src/CLUBB_core/sfc_varnce_module.F90 (diff)
Commit 06dbd2718a302cc7d7c18ca420018b0318342201 by Gunther Huebler
Fix that causes BFB GPU tests to break. We need to copy these variables to the CPU before outputtin to disk. It's very unclear why the BFB GPU test ever passed without this.
The file was modified src/clubb_driver.F90 (diff)