Skip to content
Failed

Changes

Summary

  1. Making the l_random_k_lh_start set the random generator seed before generating a random. This should fix the generalized grid test, which failed for the only flag set that turned on l_random_k_lh_start. Before, the test passed because we used the same random seed for all timesteps, preventing differences in the random call. But now we use a different seed each timestep, causing differences. To ensure reproducibility, we use the seed each timestep to generate rand_pool, which is an effective solution, but we need to do that for the rand_integer_in_range call in the l_random_k_lh_start code for the same reason. Since this does change the random that comes out, this is BIT_CHANGING, but only for runs using both SILHS and l_random_k_lh_start=.true. (details)
Commit 50f5a9aa2d2a1e4894e9d0aa40f653db463beb15 by Gunther Huebler
Making the l_random_k_lh_start set the random generator seed before generating a random. This should fix the generalized grid test, which failed for the only flag set that turned on l_random_k_lh_start. Before, the test passed because we used the same random seed for all timesteps, preventing differences in the random call. But now we use a different seed each timestep, causing differences. To ensure reproducibility, we use the seed each timestep to generate rand_pool, which is an effective solution, but we need to do that for the rand_integer_in_range call in the l_random_k_lh_start code for the same reason. Since this does change the random that comes out, this is BIT_CHANGING, but only for runs using both SILHS and l_random_k_lh_start=.true.
The file was modified latin_hypercube_driver_module.F90 (diff)