Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.
(details / githubweb)
Passing tunable parameters into the new tau code.
(details / githubweb)
Passed down more parameters. Results are bit-for-bit.
(details / githubweb)
Passing through more clubb parameters. Bit-for-bit
(details / githubweb)
Passing down CLUBB's tunable parameters into the setup_pdf_parameters and
(details / githubweb)
These updates incorporate some of Shixuan Zhang's changes, including:
(details / githubweb)
Passing down CLUBB's tunable parameters into the remainder of the
(details / githubweb)
I passed down the forgotten thlp2_rad_coef tunable parameter.
(details / githubweb)
Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.
(details / githubweb)
I am passing down the forgotten parameter, altitude threshold, in
(details / githubweb)
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/968.
(details / githubweb)
Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.
(details / githubweb)
Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.
(details / githubweb)
Updates as requested to the l_use_tke_in_K_dfsn code:
(details / githubweb)
Updates as requested to the l_use_tke_in_K_dfsn code:
(details / githubweb)
I am committing the final stage of the "pass-down params" project.
(details / githubweb)
I am committing the final stage of the "pass-down params" project.
(details / githubweb)
Adding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.
(details / githubweb)
Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.
(details / githubweb)
I forgot to add this necessary subroutine call to the clubb API.
(details / githubweb)
Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.
(details / githubweb)
This commit fixes SAM to work with the new version of CLUBB.
(details / githubweb)
I have turned the nu_vert_res_dep family of variables into a derived
(details / githubweb)
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
(details / githubweb)
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
(details / githubweb)
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
(details / githubweb)
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
(details / githubweb)
fixed a typo in pdf_closure_module.f90, line 1284
(details / githubweb)
added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
(details / githubweb)
See respective messages on the issue 958 on date 10/12/2021
(details / githubweb)
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
(details / githubweb)
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
(details / githubweb)
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
(details / githubweb)
See respective messages on the issue 958 on date 10/12/2021
(details / githubweb)
fixed a typo in pdf_closure_module.f90, line 1284
(details / githubweb)
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
(details / githubweb)
Passing w_up_in_cloud out of advance_clubb_core
(details / githubweb)
Updating SAM-CLUBB for the most recent version of CLUBB.
(details / githubweb)
Adding some additional statistics output relevant to Stephens Larson Mironov 2022 paper.
(details / githubweb)
Updating RUNDATA/lst so that the new stats I added in https://github.com/larson-group/sam_clubb/commit/72a614957aa439ae75dbf8be6b4870a7a4c48c4b will be output.
(details / githubweb)
Updates relevant to reproducing results for Stephens, Larson, and Mironov 2022.
(details / githubweb)
Adding comments to described SAM's pressure variable.
(details / githubweb)
These changes allow you to call the 4 clubb "advance" subroutines in any
(details / githubweb)
Placing the order variables in a nice, convenient place for testing use.
(details / githubweb)
I reordered advance_clubb_core so that the "Advance xp3" (which is a
(details / githubweb)
I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx
(details / githubweb)
I am indenting the portion of the code where the advance subroutines
(details / githubweb)
Temporarily commenting out the idiot proofing in order to run some tests ...
(details / githubweb)
Now official reinstating the idiot-proofing and turning off the
(details / githubweb)
I am committing some idiot proofing in regards to the advance
(details / githubweb)
This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing.
(details / githubweb)
Changing the value of C_invrs_tau_shear from 0.02 to 0.15.
(details / githubweb)
Changing the value of C_invrs_tau_shear from 0.02 to 0.15.
(details / githubweb)
Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true.
(details / githubweb)
Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that
(details / githubweb)
Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that
(details / githubweb)
Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm
(details / githubweb)
Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm
(details / githubweb)
Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972
(details / githubweb)
Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972
(details / githubweb)
Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972
(details / githubweb)
Breaking up column loop in advance_clubb_core. larson-group/clubb#972
(details / githubweb)
Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972
(details / githubweb)
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence
(details / githubweb)
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence
(details / githubweb)
Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972
(details / githubweb)
Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972
(details / githubweb)
Making a commit that officially places the call to the PDF in the "post"
(details / githubweb)
Making a commit that officially places the call to the PDF in the "post"
(details / githubweb)
Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972
(details / githubweb)
We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972
(details / githubweb)
I am updating ice_supersat_frac to be an intent(inout) variable for
(details / githubweb)
Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972
(details / githubweb)
Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972
(details / githubweb)
Pushing column index into zm2zt and zt2zm. larson-group/clubb#972
(details / githubweb)
Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972
(details / githubweb)
A variety of small loop pushing. larson-group/clubb#972
(details / githubweb)
Fixed small bug that slipped through because the G_unit tests use nz=1.
(details / githubweb)
Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972
(details / githubweb)
I added a subroutine that prints that values of all PDF parameters in
(details / githubweb)
Small changes and a loop push. larson-group/clubb#972
(details / githubweb)
Pushing loop into advance_xm_wpxp. larson-group/clubb#972
(details / githubweb)
Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972
(details / githubweb)
Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972
(details / githubweb)
Pushing column loop into local functions. larson-group/clubb#972
(details / githubweb)
Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing.
(details / githubweb)
Adding in Post Step log reporting to ensure we recieve log output even on failed runs.
(details / githubweb)
Fixing small bug that breaks runs with scalars.
(details / githubweb)
Implementations of smooth min, max and heaviside function. Added G-Unit tests
(details / githubweb)
Making setup_pdf_parameters accept ngrdcols size arrays of stats and grid types.
(details / githubweb)
Forgot two small changes. larson-group/cam#129
(details / githubweb)
Removing need for data copies. larson-group/cam#129
(details / githubweb)
Changing column loop index from j to i. larson-group/cam#129
(details / githubweb)
Changing microphysics file to UWM from 1MOM for the carson nightly tests.
(details / githubweb)
Removing data copies that we don't need anymore. This still runs correctly on GPUs.
(details / githubweb)
Making clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible.
(details / githubweb)
No more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols.
(details / githubweb)
Increasing HBUF_MAX_LENGTH to 2000 to account for increase in vaiables.
(details / githubweb)
Adds a blank line to trigger git merge with E3SM
(details / githubweb)
Removes a blank line in order to trigger merge with E3SM
(details / githubweb)
Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972
(details / githubweb)
Replacing the i loop iterator for scalars with sclr.
(details / githubweb)
Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats.
(details / githubweb)
Moving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call.
(details / githubweb)
Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way.
(details / githubweb)
Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn.
(details / githubweb)
Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp.
(details / githubweb)
Changed the UTIL Makefile to use ifort rather than sunf95 to allow nightly tests to run.
(details / githubweb)
Adding files and updates necessary to run new neutral, shear_driven case in SAM. The case
(details / githubweb)
I added l_relax_clipping to CLUBB's config flags.
(details / githubweb)
I added l_relax_clipping to CLUBB's config flags.
(details / githubweb)
I am updating clubb_sgs.F90 for the addition of the l_enable_relaxed_clipping
(details / githubweb)
Forgot to add l_enable_relaxed_clipping to the namelist readible flags.
(details / githubweb)
Added a3_coef_min to the list of CLUBB's tunable parameter and then
(details / githubweb)
Added a3_coef_min to the list of CLUBB's tunable parameter and then
(details / githubweb)
Updated SAM-CLUBB for CLUBB's new tunable parameter a3_coef_min
(details / githubweb)
Adding samClubbCodeCopy.bash to the jenkins directory for testing Clubb changes. larson-group/sys_admin#768
(details / githubweb)
Added idiot-proofing to print a warning message when l_diag_Lscale_from_tau
(details / githubweb)
Updating the call to setup_clubb_core_api based on changes found
(details / githubweb)
I added the code for the l_linearize_pbl_winds flag that was originally
(details / githubweb)
I added the code for the l_linearize_pbl_winds flag that was originally
(details / githubweb)
Interfacing SAM-CLUBB with the latest version of CLUBB.
(details / githubweb)
Updated code so that it actually compiles and runs.
(details / githubweb)
Renaming folder and script as well as adding test Jenkinsfile.
(details / githubweb)
Fixing cutt off lines and spelling mistakes.
(details / githubweb)
Renamed smth_range to heaviside_smth_range
(details / githubweb)
Added tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes.
(details / githubweb)
Implemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0.
(details / githubweb)
Changed priorities of total normalized variation stats, included error handling in total normalized variation stats.
(details / githubweb)
Renamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls.
(details / githubweb)
Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail.
(details / githubweb)
Renaming the new case from SHEAR_DRIVEN to NEUTRAL, and associated mentions in files.
(details / githubweb)
Added ability to apply smooth min max functions in mixing_length.F90
(details / githubweb)
Updated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965
(details / githubweb)
Checked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965
(details / githubweb)
Added test cases to smooth_min_max_tests.F90 and updated documentation.
(details / githubweb)
removed SAM_CLUBB_standards.tex, SAM_CLUBB.tex, SAM_code_notes.tex, and SAM6.10_guide.doc larson-group/sys_admin#622
(details / githubweb)
COrrecting a couple of omissions from when I was renaming the shear_driven case to "neutral".
(details / githubweb)
Constructing rcm within SILHS (as rcm_pdf) (#1011)
(details / githubweb)
Constructing rcm within SILHS (as rcm_pdf) (#1011)
(details / githubweb)
Updating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4.
(details / githubweb)
Making compatible with latest clubb change.
(details / githubweb)
Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014)
(details / githubweb)
The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.
(details / githubweb)
Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.
(details / githubweb)
Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).
(details / githubweb)
Making compatible with latest clubb change.
(details / githubweb)
Making 2D versions of setup_grid and setup_parameters.
(details / githubweb)
Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value.
(details / githubweb)
Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types.
(details / githubweb)
![[Jenkins]](/jenkins/static/57c8a776/images/svgs/logo.svg){kind=logo}
