Skip to content
Success

Changes

Summary

  1. Eliminating l_single_C2_Skw flag. (details)
  2. Eliminating l_single_C2_Skw flag. (details)
  3. Eliminating l_include_ice and sat_ice_ratio. (details)
  4. Eliminating l_update_pressure flag. (details)
  5. Eliminating l_upwind_wpxp_ta flag. (details)
  6. Fixing small pathing error in log reading step. larson-group/sys_admin#735 (details)
  7. Updating the surface clipping coefficient... (details)
  8. Updating the surface clipping coefficient... (details)
  9. Adding in l_vary_convect_depth as requested. (details)
  10. Adding in l_vary_convect_depth as requested. (details)
  11. Reflecting changes made to clubb in host models (details)
  12. Adding clubb directory for testing (details)
  13. Removing clubb and silhs directory for tonight's merge (details)
  14. Removing a couple of unused parameters from use statement. (details)
  15. Removing a couple of unused parameters from use statement. (details)
  16. Pushing k loop down through clip_variance_level. (details)
  17. Pushing k loop down through clip_variance_level. (details)
  18. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. (details)
  19. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. (details)
  20. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. (details)
  21. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. (details)
  22. Updating some comments related to the tuner updates. (details)
  23. Updating some comments related to the tuner updates. (details)
  24. Adding space to trigger autoupdate. larson-group/sys_admin#755 (details)
  25. Adding space to trigger autoupdate. larson-group/sys_admin#755 (details)
  26. Remove space to trigger autoupdate. larson-group/sys_admin#755 (details)
  27. Add space to trigger nightly tests.  For larson-group/sys_admin#755. (details)
  28. I am fixing a bug that was introduced in 6b0348e, where the logical (details)
Commit d6771b9ce7eaf03049fb5a7a002028ea528139e3 by 72510114+RhodesKeegan
Eliminating l_single_C2_Skw flag.
Additionally, this commit also eliminates C2, C2b, and C2c.
Since the flag along with the other variables are output to the .nc files,
this commit will be BIT_CHANGING since these variables no longer exist.
This is for ticket #926.
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified output_netcdf.F90 (diff)
The file was modified parameters_tunable.F90 (diff)
The file was modified parameter_indices.F90 (diff)
The file was modified model_flags.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit fff33198f774b25a969928de6793f4d56edeec23 by 72510114+RhodesKeegan
Eliminating l_single_C2_Skw flag.
Additionally, this commit also eliminates C2, C2b, and C2c.
Since the flag along with the other variables are output to the .nc files,
this commit will be BIT_CHANGING since these variables no longer exist.
This is for ticket #926.
The file was modified output_2D_samples_module.F90 (diff)
The file was modified latin_hypercube_driver_module.F90 (diff)
The file was modified silhs_api_module.F90 (diff)
Commit 6a1e0902cf77eeba533be047f9e84b621f397bce by rhodesk
Eliminating l_include_ice and sat_ice_ratio.
For ticket #926
Results are BFB identical.
The file was modified mixing_length.F90 (diff)
Commit 5a57001670ee7b7d03e59cd02523bb9828e35482 by rhodesk
Eliminating l_update_pressure flag.
For ticket #926.
Results are confirmed to be BFB identical.
The file was modified clubb_api_module.F90 (diff)
The file was modified model_flags.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit d0851f0cae643c24780d106d61a78fb1593c9b5f by rhodesk
Eliminating l_upwind_wpxp_ta flag.
For issue #926.
Results are confirmed BFB identical.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified model_flags.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
Commit e9a34488c0c7252ef8603a1663cd2139cad6c120 by pbroels
Fixing small pathing error in log reading step. larson-group/sys_admin#735
The file was modified jenkins_tests/e3sm_ne4_silhs_run_gfortran_test/Jenkinsfile (diff)
Commit 0578ed505c5ca0ef84141586d6c18195c4e28fdf by noreply
Updating the surface clipping coefficient...

...to avoid MC3E failure with PGI compiler.  I find all cases run successfully with this coefficient, with ifort, gfortran, and PGI.
The file was modified clip_explicit.F90 (diff)
Commit 8a6392b854e8b0d8c8b72f94aa18dce014c77b6b by noreply
Updating the surface clipping coefficient...

...to avoid MC3E failure with PGI compiler.  I find all cases run successfully with this coefficient, with ifort, gfortran, and PGI.
The file was modified clip_explicit.F90 (diff)
Commit 64c2cdc41031f3088268356bf8e8149aa33c5459 by 72510114+RhodesKeegan
Adding in l_vary_convect_depth as requested.
For ticket #905.
Results are confirmed to be BFB identical.
The file was modified sfc_varnce_module.F90 (diff)
The file was modified model_flags.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit cebe3ad6391c3d2ba0720cbe910b43c78b9ef0f6 by 72510114+RhodesKeegan
Adding in l_vary_convect_depth as requested.
For ticket #905.
Results are confirmed to be BFB identical.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified sfc_varnce_module.F90 (diff)
The file was modified model_flags.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
Commit 724446ae50688335e193fde8f8b56947ba78b3c4 by 72510114+RhodesKeegan
Reflecting changes made to clubb in host models
The file was modified components/cam/src/physics/cam/clubb_intr.F90 (diff)
Commit 9879587e179912038c6af5152520626b117dd84c by 72510114+RhodesKeegan
Adding clubb directory for testing
The file was modified components/cam/src/physics/clubb/sfc_varnce_module.F90 (diff)
The file was modified components/cam/src/physics/clubb/advance_clubb_core_module.F90 (diff)
The file was modified components/cam/src/physics/clubb/model_flags.F90 (diff)
The file was modified components/cam/src/physics/clubb/clubb_api_module.F90 (diff)
Commit 93d5d8d4ec44e318fa3194a48cae2e41f9f61a90 by 72510114+RhodesKeegan
Removing clubb and silhs directory for tonight's merge
The file was modified components/cam/src/physics/clubb/advance_clubb_core_module.F90 (diff)
The file was modified components/cam/src/physics/clubb/sfc_varnce_module.F90 (diff)
The file was modified components/cam/src/physics/clubb/model_flags.F90 (diff)
The file was modified components/cam/src/physics/clubb/clubb_api_module.F90 (diff)
Commit 1016f8e33ad0f6476ee40bc5dd690451bc0b869b by noreply
Removing a couple of unused parameters from use statement.

These are not caught by the gfortran compiler for whatever reason but the ifort compiler warned about them.
The file was modified advance_clubb_core_module.F90 (diff)
Commit b24820513db462e4a5b1cae18b4a901d7e9bd8a2 by noreply
Removing a couple of unused parameters from use statement.

These are not caught by the gfortran compiler for whatever reason but the ifort compiler warned about them.
The file was modified advance_clubb_core_module.F90 (diff)
Commit dafbfbd0f0baf9f01fcb08b22f2a17333606a56a by rhodesk
Pushing k loop down through clip_variance_level.
This change is for the files advance_wp2_wp3_module and advance_xp2_xpyp_module.
In order to make this change, I added a new variable in the upper-level subroutine
that is an array version of the variable 'threshold' and passed it along to the lower subroutine.
The loop is still present in order to calculate the values of threshold, however, the calls
to the subroutine is outside of the loop. The only calculations inside the loop is for
and intrensic function, max.
All results are BFB identical for default case along with l_stats_samp being set to true.
For ticket #951.
The file was modified clip_explicit.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
Commit ed78e345853d9af1f71e7300220392469b690b67 by rhodesk
Pushing k loop down through clip_variance_level.
This change is for the files advance_wp2_wp3_module and advance_xp2_xpyp_module.
In order to make this change, I added a new variable in the upper-level subroutine
that is an array version of the variable 'threshold' and passed it along to the lower subroutine.
The loop is still present in order to calculate the values of threshold, however, the calls
to the subroutine is outside of the loop. The only calculations inside the loop is for
and intrensic function, max.
All results are BFB identical for default case along with l_stats_samp being set to true.
For ticket #951.
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified clip_explicit.F90 (diff)
Commit 72b5c72ac5985e9a585e44d615243bcbc6582ae8 by 59519056+bstephens82
Udpates to make it possible for us to keep certain parameters equal to each other during tuning.

Includes:

* a new subroutine in parameters_tunable.F90 that will read a new namelist in the error_*.in files
* updates to src/error.F90 to make sure the intended parameters are held equal throughout the tuning run
* updates to src.error.F90 to print the variables that were held equal at the end of the tuning run, together with their beginning and ending values, and updates to ensure that the new tuned values are copied into the new paramters_tunable_*.in file so they can be used for plotting or restarting the tuner.
* includes several simple error checks

See #939.
The file was modified parameters_tunable.F90 (diff)
Commit 747e30bcbd918a4dde0b1491b3ebfeaebdac9b59 by 59519056+bstephens82
Udpates to make it possible for us to keep certain parameters equal to each other during tuning.

Includes:

* a new subroutine in parameters_tunable.F90 that will read a new namelist in the error_*.in files
* updates to src/error.F90 to make sure the intended parameters are held equal throughout the tuning run
* updates to src.error.F90 to print the variables that were held equal at the end of the tuning run, together with their beginning and ending values, and updates to ensure that the new tuned values are copied into the new paramters_tunable_*.in file so they can be used for plotting or restarting the tuner.
* includes several simple error checks

See #939.
The file was modified parameters_tunable.F90 (diff)
Commit 94146014302b085c13961f6e0eab2dadedca0243 by 59519056+bstephens82
Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included.

See #939.
The file was modified parameters_tunable.F90 (diff)
Commit c787271c923e08a7bfa8db303bfee6588f840abf by 59519056+bstephens82
Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included.

See #939.
The file was modified parameters_tunable.F90 (diff)
Commit 5c73ee72a0175108bcc4b103ebd44c696a92a50a by 59519056+bstephens82
Updating some comments related to the tuner updates.

See #939.
The file was modified parameters_tunable.F90 (diff)
Commit 68848116981910e70725c5fcc14d78e78f3f87ed by 59519056+bstephens82
Updating some comments related to the tuner updates.

See #939.
The file was modified parameters_tunable.F90 (diff)
Commit 3b29c310d2e96d7e9fe9e5078ac6ee6a2f2fb759 by Gunther Huebler
Adding space to trigger autoupdate. larson-group/sys_admin#755
The file was modified advance_clubb_core_module.F90 (diff)
Commit ed5bed1dc8054413f5792e6d3abe64789523d730 by Gunther Huebler
Adding space to trigger autoupdate. larson-group/sys_admin#755
The file was modified advance_clubb_core_module.F90 (diff)
Commit a7a1f100a8a3938b9a1717165b7daa1a6858c514 by noreply
Remove space to trigger autoupdate. larson-group/sys_admin#755
The file was modified advance_clubb_core_module.F90 (diff)
Commit 579ae7bf3eba658a981d771ded27f16906ed7896 by noreply
Add space to trigger nightly tests.  For larson-group/sys_admin#755.
The file was modified advance_clubb_core_module.F90 (diff)
Commit 3f4274296a097f61485983e5106c648014382114 by bmg2
I am fixing a bug that was introduced in 6b0348e, where the logical
flow was distorted within the trapezoidal rule code.

This change does not affect standard CLUBB, where the trapezoidal
rule is not used by default. However, it is important for CAM-CLUBB.
The file was modified advance_clubb_core_module.F90 (diff)