Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. (details)
Feeding stats variables to needed subroutines (details)
Moving the stats variables to module variables of clubb_driver. (details)
Moving the stats variables to module variables of clubb_driver. (details)
Fixing coding standard viloation of lines exceeding 100 characters. (details)
Fixing coding standard viloation of lines exceeding 100 characters. (details)
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. (details)
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. (details)
Removing l_interp_prescribed_params from setup_clubb_pdf_params. (details)
Adding comments labeling subroutine calls with intent. (details)
Adding intent labels for subroutines throughout clubb. (details)
Removing unnecessary constant from use statement (details)
Update the diagnostic. Put white boxes on global plot for all regions. Issue #36. (details)
Eliminating l_nu_grid_dependent as requested. (details)
Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.
This is BIT_CHANGING, but only because it will introduce some new output variables in the netcdf files. It will not affect results currently since the pressure diffusion coefficient is set to zero.
Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.
Moving the stats variables to module variables of clubb_driver. This change means I had to modify clubb_api_module's arg list along with other arg lists throughout clubb. Everything compiles and results remain BFB identical. For ticket #733.
Moving the stats variables to module variables of clubb_driver. This change means I had to modify clubb_api_module's arg list along with other arg lists throughout clubb. Everything compiles and results remain BFB identical. For ticket #733.
Fixing coding standard viloation of lines exceeding 100 characters. Violations were introduced as a result of changes made by ticket #733, this commit resolves the coding standard violations. Results BFB identical.
Fixing coding standard viloation of lines exceeding 100 characters. Violations were introduced as a result of changes made by ticket #733, this commit resolves the coding standard violations. Results BFB identical.
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.
This is not set up to change results currently, since the coefficient of the new term is zero, but it is BIT_CHANGING since it will include new output in the netcdf files.
Also includes updates to pyplotgen to accommodate the new term.
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.
Removing l_interp_prescribed_params from setup_clubb_pdf_params. The flag has been removed and so has any code underneat a logic statement involving this statement unless it has multiple flags. The else statement in the if block involving this flag has been set to execute without an if block. For ticket #916 Results are BFB identical. Additionally, complex logic statements with the use of more flags had those flags adjusted and BFB results were also confirmed with these changes.
Adding intent labels for subroutines throughout clubb. All calls to subroutines now have intent comments next to them all the way up through stats_sfc_module. Results are BFB identical. For ticket #942.
Eliminating l_clip_semi_implicit flag. For ticket #926. This commit is BIT_CHANGING due to how the flag needed to be removed. More details on why this commit is bit changing can be seen on the ticket page.
Adding intent labels for subroutines throughout clubb. Remaining files now have intent comments for subroutines. Additionally, all lines are now less than 100 characters. For ticket #942. Results are BFB identical.