Skip to content
Failed

Changes

Summary

  1. Clubb silhs gg (#1239) (details)
  2. Trying to avoid merge issues (details)
  3. Added descriptor for lat/lon values in header, fixed minor issues (details)
  4. Added automatic adjustment of lat/lon values to err_info setter (details)
Commit 2f9bef63460fadecdb3f3679ef29d18beafba72e by noreply
Clubb silhs gg (#1239)

* I added new subroutine pdf_hydromet_microphys_prep to encompass
the code that calls the hydrometeor PDF and then ultimately
handles the setup of SILHS sample points when SILHS is in use.

* Placeholder subroutine for SILHS grid generalization test.

* I have now connected the new subroutine to run_clubb. The results
for all cases match bit-for-bit to the previous revision.

* Cleaning up from the refactoring of the hydrometeor PDF and SILHS
code into a wrapper subroutine.

* I'm moving pdf_hydromet_microphys_prep to its own file to avoid
circular dependency once it finally needs to be called from the
generalized grid test code soon.

* Added some code to the SILHS generalized grid test.

* Changes to make this a fully functioning grid generalization test
for the part of the microphysics code that encompasses
setup_pdf_parameters and hydrometeor_mixed_moments.

* I have completed the code for the SILHS generalized grid test.

* I generalized precipitation fraction for ascending vs. descending grid.

* Fixing a bug that I noticed in the precipitation fraction calculation
when the component precip frac calculation was set to option 1
(which is currently not the default).

* The code should now be successfully grid-generalized for SILHS.
The ascending vs descending grid test should work now for all cases.

* Updating the core flags .json file to change some of the SILHS flags.

* I moved the call to advance_clubb_core_api (the default run option)
to the top of the "if" block, ahead of the grid generalization test
option that is now in the "else" block.

* Adding a new, hardwired constant flag called l_ascending_grid and
setting it to true in clubb_driver.F90.

* Keeping lines under 100 characters in length.

* Making it so the ascending vs. descending grid tests pass for the
l_lh_random_start flag.
The file was modified run_scripts/run_bindiff_w_flags_config_core_flags.json (diff)
The file was modified src/CLUBB_core/setup_clubb_pdf_params.F90 (diff)
The file was modified src/SILHS/latin_hypercube_driver_module.F90 (diff)
The file was modified src/generalized_grid_test.F90 (diff)
The file was modified src/CLUBB_core/precipitation_fraction.F90 (diff)
The file was modified src/SILHS/silhs_api_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified compile/file_list/clubb_model_files (diff)
The file was addedsrc/pdf_hydromet_microphys_wrapper.F90
Commit f1f587e191eb418b6edd1614837070151c26c947 by Steffen Domke
Trying to avoid merge issues
The file was modified src/clubb_driver.F90 (diff)
Commit b7a6f55e7c285a88969611587ef68930f5410787 by Steffen Domke
Added descriptor for lat/lon values in header, fixed minor issues
The file was modified src/pdf_hydromet_microphys_wrapper.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/err_info_type_module.F90 (diff)
Commit e4d48573aac237ed2ca005f1ee2340ac71cc02c5 by Steffen Domke
Added automatic adjustment of lat/lon values to err_info setter
The file was modified src/CLUBB_core/err_info_type_module.F90 (diff)

Summary

  1. Clubb silhs gg (#1239) (details)
  2. Trying to avoid merge issues (details)
  3. Add a blank line to README in order to note BIT_CHANGING:969bc4aa2a1db2664c0f92b98d2df5544c554c32 (details)
  4. Added descriptor for lat/lon values in header, fixed minor issues (details)
  5. Added automatic adjustment of lat/lon values to err_info setter (details)
  6. I updated adj_low_res_nu for use with a generalized grid. It is (details)
  7. Since the call to adj_low_res_nu is not tested by CLUBB's main (details)
Commit 2f9bef63460fadecdb3f3679ef29d18beafba72e by noreply
Clubb silhs gg (#1239)

* I added new subroutine pdf_hydromet_microphys_prep to encompass
the code that calls the hydrometeor PDF and then ultimately
handles the setup of SILHS sample points when SILHS is in use.

* Placeholder subroutine for SILHS grid generalization test.

* I have now connected the new subroutine to run_clubb. The results
for all cases match bit-for-bit to the previous revision.

* Cleaning up from the refactoring of the hydrometeor PDF and SILHS
code into a wrapper subroutine.

* I'm moving pdf_hydromet_microphys_prep to its own file to avoid
circular dependency once it finally needs to be called from the
generalized grid test code soon.

* Added some code to the SILHS generalized grid test.

* Changes to make this a fully functioning grid generalization test
for the part of the microphysics code that encompasses
setup_pdf_parameters and hydrometeor_mixed_moments.

* I have completed the code for the SILHS generalized grid test.

* I generalized precipitation fraction for ascending vs. descending grid.

* Fixing a bug that I noticed in the precipitation fraction calculation
when the component precip frac calculation was set to option 1
(which is currently not the default).

* The code should now be successfully grid-generalized for SILHS.
The ascending vs descending grid test should work now for all cases.

* Updating the core flags .json file to change some of the SILHS flags.

* I moved the call to advance_clubb_core_api (the default run option)
to the top of the "if" block, ahead of the grid generalization test
option that is now in the "else" block.

* Adding a new, hardwired constant flag called l_ascending_grid and
setting it to true in clubb_driver.F90.

* Keeping lines under 100 characters in length.

* Making it so the ascending vs. descending grid tests pass for the
l_lh_random_start flag.
The file was modified src/CLUBB_core/setup_clubb_pdf_params.F90 (diff)
The file was modified src/SILHS/silhs_api_module.F90 (diff)
The file was modified src/generalized_grid_test.F90 (diff)
The file was modified src/CLUBB_core/precipitation_fraction.F90 (diff)
The file was modified src/SILHS/latin_hypercube_driver_module.F90 (diff)
The file was modified run_scripts/run_bindiff_w_flags_config_core_flags.json (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was addedsrc/pdf_hydromet_microphys_wrapper.F90
The file was modified compile/file_list/clubb_model_files (diff)
Commit f1f587e191eb418b6edd1614837070151c26c947 by Steffen Domke
Trying to avoid merge issues
The file was modified src/clubb_driver.F90 (diff)
Commit e25ec88b5e538d090d1d634e3602cf637a24251c by noreply
Add a blank line to README in order to note BIT_CHANGING:969bc4aa2a1db2664c0f92b98d2df5544c554c32

However, the change is only to stats output, not the answer itself.   See https://github.com/larson-group/clubb/issues/1170#issuecomment-2802019464.
The file was modified README (diff)
Commit b7a6f55e7c285a88969611587ef68930f5410787 by Steffen Domke
Added descriptor for lat/lon values in header, fixed minor issues
The file was modified src/CLUBB_core/err_info_type_module.F90 (diff)
The file was modified src/pdf_hydromet_microphys_wrapper.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
Commit e4d48573aac237ed2ca005f1ee2340ac71cc02c5 by Steffen Domke
Added automatic adjustment of lat/lon values to err_info setter
The file was modified src/CLUBB_core/err_info_type_module.F90 (diff)
Commit cb9c724afbacef68636111b671d273df57166a6d by bmg2
I updated adj_low_res_nu for use with a generalized grid. It is
not called from within advance_clubb_core or from within SILHS.
It is not necessary to be generalized for tests within standalone
CLUBB. However, it is necessary to generalize this code for use
within host models, particularly for CAM and E3SM.
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
Commit fa5edf3c9549a7bf9b076506514aa7445f322c43 by bmg2
Since the call to adj_low_res_nu is not tested by CLUBB's main
ascending vs descending grid test (since it is not called from
within advance_clubb_core or from SILHS), I added it to the
reverse grid direction G Unit test so that the results from
ascending vs. descending grids get checked.
The file was modified src/G_unit_test_types/rev_direction_grid_test.F90 (diff)