Skip to content
Success

Changes

Summary

  1. Insert print about overwriting default flags with namelist values (details)
  2. Insert print about overwriting default parameters with namelist values (details)
  3. Making call to setup_grid use new api version. larson-group/clubb#972 (details)
  4. Making api version of setup_grid. larson-group/clubb#972 (details)
  5. Breaking up column loop some more. larson-group/clubb#972 (details)
  6. Making some paramters_silhs variables available from the silhs api (details)
  7. Comment out setting of fatal error (details)
  8. Big column loop is now gone entirely. Replaced by fast small loops. larson-group/clubb#972 (details)
  9. This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. (details)
  10. Changing the value of C_invrs_tau_shear from 0.02 to 0.15. (details)
  11. Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. (details)
  12. Updated cam to reflect the changes in the clubb driver api (details)
  13. Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that (details)
  14. Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm (details)
  15. Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 (details)
  16. Making cam use the multicolumn interface for advance_clubb_core. Everything bit-for-bit. larson-group/clubb#972 (details)
  17. Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 (details)
  18. Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 (details)
  19. Breaking up column loop in advance_clubb_core. larson-group/clubb#972 (details)
  20. Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972 (details)
  21. I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence (details)
  22. Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 (details)
  23. Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 (details)
  24. Rather than allocating pdf_params with pcols grid columns, we should use ncol. Which is what this commit does. We should do this same thing for all the other arrays too, but this change was required to move forward with our loop pushing. larson-group/clubb#972 (details)
  25. Making a commit that officially places the call to the PDF in the "post" (details)
  26. Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 (details)
  27. Forgot an & symbol. (details)
  28. We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 (details)
  29. I am updating ice_supersat_frac to be an intent(inout) variable for (details)
  30. Making compatible with latest clubb change. (details)
  31. Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 (details)
  32. Setting up ice_supersat_frac to be saved from one timestep to the next (details)
  33. Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 (details)
  34. Improving config flag setup process and adding run script using r8029 flag set. larson-group/clubb#984 (details)
  35. Adding nightly test script for the r8029 flag version of the coarse res run. larson-group/clubb#972 (details)
  36. Updating scripts (details)
  37. Fixing scripts, I updated the wrong one. (details)
  38. Pushing column index into zm2zt and zt2zm. larson-group/clubb#972 (details)
  39. Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 (details)
  40. A variety of small loop pushing. larson-group/clubb#972 (details)
  41. Fixed small bug that slipped through because the G_unit tests use nz=1. (details)
  42. Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 (details)
  43. I added a subroutine that prints that values of all PDF parameters in (details)
  44. Small changes and a loop push. larson-group/clubb#972 (details)
  45. Pushing loop into advance_xm_wpxp. larson-group/clubb#972 (details)
  46. Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 (details)
  47. Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 (details)
  48. Pushing column loop into local functions. larson-group/clubb#972 (details)
  49. Adding in functionality for displaying log output into post step. (details)
  50. Fixing whitespace issues with the jenkinsfile changes. (details)
Commit af2e320388670ca0a57e2f176c1bc5d627b9098d by noreply
Insert print about overwriting default flags with namelist values
The file was modified model_flags.F90 (diff)
Commit 8f225830ad630ade0b0f818521e3420cf71da15d by noreply
Insert print about overwriting default parameters with namelist values
The file was modified parameters_tunable.F90 (diff)
Commit 9b67756c7029fdd2ade3029a55e2766aa857ba4c by Gunther Huebler
Making call to setup_grid use new api version. larson-group/clubb#972
The file was modified src/physics/cam/clubb_intr.F90 (diff)
Commit f3942b808f629c080b43dfaca5c50c6ce080ef9a by Gunther Huebler
Making api version of setup_grid. larson-group/clubb#972
The file was modified clubb_api_module.F90 (diff)
Commit 0fd2fe6adde201caeb15329a43d45fd20752d818 by Gunther Huebler
Breaking up column loop some more. larson-group/clubb#972
The file was modified src/physics/cam/clubb_intr.F90 (diff)
Commit 3db947c8588aef8f34322cfdf19bc0b3e0e7be79 by Gunther Huebler
Making some paramters_silhs variables available from the silhs api
The file was modified silhs_api_module.F90 (diff)
Commit 65acb9b0c8906c6bd4001aa5eb2cb31b11760835 by noreply
Comment out setting of fatal error

when l_min_xp2_from_corr_wx = F and l_enable_relaxed_clipping = F. 
The goal is to allow the clubb_backwards_compatibility_gfortran_test
Jenkins test to pass again.

For #846.
The file was modified advance_clubb_core_module.F90 (diff)
Commit 302c3069435e837e84c86681aade287dbf294c73 by Gunther Huebler
Big column loop is now gone entirely. Replaced by fast small loops. larson-group/clubb#972
The file was modified src/physics/cam/clubb_intr.F90 (diff)
Commit 7ec140fc6d8e5e40e4dd195f225d62cdaa8fbabe by Gunther Huebler
This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing.
The file was modified parameters_tunable.F90 (diff)
Commit 5bf9927ebb2fdd8006f9aee4380dd467515d2c06 by bmg2
Changing the value of C_invrs_tau_shear from 0.02 to 0.15.
This commit is BIT_CHANGING
The file was modified parameters_tunable.F90 (diff)
Commit 04279f676a57a9710d4b60f0dafcd0c331a4f18e by Gunther Huebler
Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true.
The file was modified advance_clubb_core_module.F90 (diff)
Commit e7450ff97e11a4ff45bd9edd21b75ec7cf43d70c by noreply
Updated cam to reflect the changes in the clubb driver api
The file was modified src/physics/cam/clubb_intr.F90 (diff)
Commit 03f14dd627f8df25c1e8c40b407a2c60b943f972 by bmg2
Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that
CLUBB (particularly the MC3E case) completes successfully for all
compiler tests.

You might say that this is BIT_CHANGING.
The file was modified parameters_tunable.F90 (diff)
Commit d8836de198f0c3f3457f195fb08642497dead21b by noreply
Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm

This option calls subroutine smooth_heaviside_peskin, which implements the smooth Peskin Heaviside function.
The option is turned off for now, and so the results should remain bit for bit.

For #965.
The file was modified constants_clubb.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified model_flags.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified mixing_length.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
Commit 4d506fc219eb83b1977f318f6b46c3a1f75f09c5 by Gunther Huebler
Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972
The file was modified clubb_api_module.F90 (diff)
The file was modified pdf_parameter_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 193a0adcd7c4de940097e80d38a8cd909a64034c by Gunther Huebler
Making cam use the multicolumn interface for advance_clubb_core. Everything bit-for-bit. larson-group/clubb#972
The file was modified src/physics/cam/clubb_intr.F90 (diff)
Commit 946ca541e9acab72c5dbd52b2df8651bfc0bfb76 by Gunther Huebler
Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972
The file was modified clubb_api_module.F90 (diff)
Commit 7e6744fa4864a0219f8e4a32d0d72fb2664598d9 by Gunther Huebler
Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972
The file was modified clubb_api_module.F90 (diff)
Commit 0bae8e4aaa7651515c8d5df797909bd9de345c2f by Gunther Huebler
Breaking up column loop in advance_clubb_core. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
Commit d55d2cbc2faec828838317f478b04fa8ea410f7a by Gunther Huebler
Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
Commit fabb386b09890bd8a64d59b5ae24bae937af9f93 by bmg2
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence
from going to the model top, which ultimately caused MC3E to crash
by becoming too cold.  Additionally, I set C_invrs_tau_shear back
to 0.15 from 0.16. This commit is BIT_CHANGING.
The file was modified parameters_tunable.F90 (diff)
Commit 2c6b628542302815ac566410bfa583f64b252464 by Gunther Huebler
Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
Commit af9c183212dde92967cca80d87ef80f1aabd76b1 by Gunther Huebler
Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972
The file was modified pdf_closure_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 1c7f56ead0a5db7256f1d9a1061197884ef09152 by Gunther Huebler
Rather than allocating pdf_params with pcols grid columns, we should use ncol. Which is what this commit does. We should do this same thing for all the other arrays too, but this change was required to move forward with our loop pushing. larson-group/clubb#972
The file was modified src/physics/cam/clubb_intr.F90 (diff)
Commit c0b2297dad094c1121026e8520de001748c1d0a7 by bmg2
Making a commit that officially places the call to the PDF in the "post"
position (meaning after CLUBB's predictive fields have been advanced).
This commit is BIT_CHANGING
The file was modified model_flags.F90 (diff)
Commit f1c545226c133b42ec11c523daee00e938910cf3 by Gunther Huebler
Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
The file was modified adg1_adg2_3d_luhar_pdf.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
Commit 376d0e4907dc788fce6a52b6d0dc5ad4d7481f34 by Gunther Huebler
We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972
The file was modified pdf_closure_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 0201571e2624e4580ec5e4f44582e187d7908ebb by bmg2
I am updating ice_supersat_frac to be an intent(inout) variable for
advance_clubb_core. When the PDF is in the "post" position, there is
a chance that it can be used before it is set unless it is preserved
from timestep to timestep.
The file was modified clubb_api_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 1a024c7a0be62e143aafbbdbdee1839194ad9167 by Gunther Huebler
Making compatible with latest clubb change.
The file was modified src/physics/cam/clubb_intr.F90 (diff)
Commit aa44cb502926842665f158cbfab7c8cf1df5c3c5 by Gunther Huebler
Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
Commit cba1a8b172fbc73f5e75e73ec504a30d8ef2ded3 by bmg2
Setting up ice_supersat_frac to be saved from one timestep to the next
for use in advance_clubb_core_api, including proper saving in
restart files.
The file was modified src/physics/cam/clubb_intr.F90 (diff)
Commit 5088c109e589f0398450ea86996147836b8b75d8 by Gunther Huebler
Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972
The file was modified pdf_parameter_module.F90 (diff)
Commit b61128d4e0326a3eecbb69be5f6436513fcaa9dc by Gunther Huebler
Improving config flag setup process and adding run script using r8029 flag set. larson-group/clubb#984
The file was modified bld/namelist_files/namelist_definition.xml (diff)
The file was modified src/physics/cam/clubb_intr.F90 (diff)
The file was modified src/physics/cam/subcol_SILHS.F90 (diff)
The file was addedrun_scripts/run_cesm_uwm_coarse_res_r8029_flags.sh
Commit c74b49460cf50e9d572f594b23b59d4ba4a6c20c by Gunther Huebler
Adding nightly test script for the r8029 flag version of the coarse res run. larson-group/clubb#972
The file was addedjenkins_tests/cam_coarse_res_r8029_flags_bin_diff_regression_gfortran_test/Jenkinsfile
The file was modified jenkins_tests/cam_coarse_res_bin_diff_regression_gfortran_test/Jenkinsfile (diff)
Commit abdea2ab94da931d73eb5701e5a7e158a82240ff by Gunther Huebler
Fixing scripts, I updated the wrong one.
The file was modified jenkins_tests/cam_coarse_res_bin_diff_regression_gfortran_test/Jenkinsfile (diff)
The file was modified jenkins_tests/cam_coarse_res_r8029_flags_bin_diff_regression_gfortran_test/Jenkinsfile (diff)
Commit f1154aed2f15410ec35a99adb03d2d517f9fad2d by Gunther Huebler
Pushing column index into zm2zt and zt2zm. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified grid_class.F90 (diff)
Commit 932c80e272c18da1ccf51719eed39b370ca45912 by Gunther Huebler
Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972
The file was modified Skx_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit a3665dbc5e18abd7e8281d753abed2bbb03d8f1c by Gunther Huebler
A variety of small loop pushing. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified sigma_sqd_w_module.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified grid_class.F90 (diff)
Commit 7f7db11cab062c725e5fe2787d45f0225e4ba60f by Gunther Huebler
Fixed small bug that slipped through because the G_unit tests use nz=1.
The file was modified sigma_sqd_w_module.F90 (diff)
Commit 3c97bd65f2133f211f2d8502473f2cf32a025be1 by Gunther Huebler
Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972
The file was modified mixing_length.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit df7da80153115bfa7df377decb342e4aee4481cf by bmg2
I added a subroutine that prints that values of all PDF parameters in
type pdf_parameter, which is a useful debugging tool.
The file was modified pdf_parameter_module.F90 (diff)
Commit 445f590cf1d278eee326fe3a3355fdc0deab0d21 by Gunther Huebler
Small changes and a loop push. larson-group/clubb#972
The file was modified Skx_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit c9f575df03cc82bf9e0783bd2608ef27d0b4b637 by Gunther Huebler
Pushing loop into advance_xm_wpxp. larson-group/clubb#972
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit eb106afc75f2daab341edd31b7508557525f6fb2 by Gunther Huebler
Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972
The file was modified sigma_sqd_w_module.F90 (diff)
Commit bcda3f8c752053316304a5ce21d56977f49c53b4 by Gunther Huebler
Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972
The file was modified advance_xm_wpxp_module.F90 (diff)
Commit 0a7b2cda84e35cf4f34a3a582daf8b67a6a62194 by Gunther Huebler
Pushing column loop into local functions. larson-group/clubb#972
The file was modified mono_flux_limiter.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
Commit cfc2f8f83323478ae5b63a48655731e0aea28cf3 by pbroels
Adding in functionality for displaying log output into post step.
The file was modified jenkins_tests/cam_global_regression_gfortran_test/Jenkinsfile (diff)
The file was modified jenkins_tests/cam_scam_gfortran_test/Jenkinsfile (diff)
Commit 54748fad84e1e694350da85f95535cc6c01ad11f by pbroels
Fixing whitespace issues with the jenkinsfile changes.
The file was modified jenkins_tests/cam_global_regression_gfortran_test/Jenkinsfile (diff)
The file was modified jenkins_tests/cam_scam_gfortran_test/Jenkinsfile (diff)