Changes

I have passed clubb_params down into advance_xm_wpxp_module.F90.

The results from this revision are an exact match to the results from
the previous revision for all cases.

See ticket
#958

I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.

The results in NetCDF output files from this revision are an exact match to the
results in NetCDF output files from the previous revision for all cases.

added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk

Updates to separate out C4 and C14 in advance_xp2 module.  This will make it easier to control which invrs_tau_* variable multiplies each term for example.

This commit is BIT_CHANGING owing to order of operations differences, but the pyplotgen output for most cases looks identical to the naked eye.

Changing the name of dummy_1d variables for clarity.

I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90
for most parameters, excluding C4 and C14. Results are unchanged.

Add a blank line to trigger nightly tests.

Passing down more of CLUBB's tunable parameters.

I accidentally removed an important comment in the previous commit.

Passing down more CLUBB tunable parameters.

Everything is bit-for-bit.

Updating run_scam.bash to work with newest merge from cam_development. larson-group/cam#140

More passing down CLUBB parameters ... whoop-de-doo

Passing down more tunable parameters and removing references to
parameters_tunable. Results are bit-for-bit.

Removing line to trigger the nightly tests for all repos.

Changing jenkinsfiles and thier diectory to reflect changes to test name. larson-group/sys_admin#735

See respective messages on the issue 958 on date 10/12/2021

Handling the abomination that is lmin.

Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix.  I included comments to describe why this was done.  Results are b4b.

See https://github.com/larson-group/clubb/issues/920#issuecomment-942735433.

Add a blank line in order to note that

this commit, BIT_CHANGING:dd911dca7243ed284b44685820389cca115266da, changed CAM's result because CLUBB-core changed.
The commits below were changed because the compiler version on nelson changed (larson-group/sys_admin#757)
RESOLVED:807d306af0fef7b246dfcafe46d0119b17b5a160
RESOLVED:dbd8ca423fe6c5bf69df15e3318cb25203007d74.

Passing tunable parameters into the new tau code.

Passed down more parameters. Results are bit-for-bit.

Passing through more clubb parameters. Bit-for-bit

Passing down CLUBB's tunable parameters into the setup_pdf_parameters and
precipitation fraction portions of the code. Everything is bit-for-bit.

These updates incorporate some of Shixuan Zhang's changes, including:

(1) upwind scheme for the eddy diffusion code, which Shixuan says does not make a huge difference; and
(2) l_smooth_heaviside_tau_wpxp flag in the mixing_length.F90 code, which is intended to give
smoother results.

Both of the flags for these changes are turned off, but these updates are BIT_CHANGING because
of some minor changes to the way that factors of rho_ds_* and invrs_rho_ds_* are handled going
into the diffusion.F90 subroutines.  Most cases look identical in pyplotgen, but sensitive cases
like arm_97 and rico look slightly different.

These changes were originally in pull request #962, but because of conflicts with the master
branch code base that developed, they could not be rebased and merged, so I incorporated them
into this new commit.

Passing down CLUBB's tunable parameters into the remainder of the
PDF subroutines. Everything is bit-for-bit.

I passed down the forgotten thlp2_rad_coef tunable parameter.
All bit-for-bit.

Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test.  I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.

I am passing down the forgotten parameter, altitude threshold, in
advance_xm_wpxp_module.F90.

Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/968.

Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3.  Relevant to CLUBB issue #920.

Results are b4b when the flag is turned off, which it currently is.

Updates as requested to the l_use_tke_in_K_dfsn code:

- The name of the flag is changed to l_use_tke_in_wp2_wp3_K_dfsn
- Comments are added to the main pieces of code in advance_wp2_wp3
- The flag is added to the "compatible_r8029" configurable flags file.

See this comment https://github.com/larson-group/clubb/issues/920#issuecomment-931446401 and following for more information.

I am committing the final stage of the "pass-down params" project.
The results are bit-for-bit identical.

I am committing the final stage of the "pass-down params" project.
The results are bit-for-bit identical.

Adding an option to use invrs_tau_N2_iso for C4 terms.  The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233).  The flag is currently set to false so results will be b4b.

See also the discussion here: https://github.com/larson-group/clubb/issues/920#issuecomment-920338746 and following comments.

Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion.  This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.

Adding comments for clarity.

I forgot to add this necessary subroutine call to the clubb API.

I am updating CAM-CLUBB-SILHS (the clubb_silhs_devel) branch so
that it runs with the new version of CLUBB.

Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690.  There was some overcounting of the relevant terms.

Results are b4b since the l_use_tke_in_wp2_wp3_K_dfsn flag is false.

Fixing the SILHS code so that CAM-CLUBB-SILHS compiles and runs again.

Add blank line to run_scam.bash in order to note that

a commit is BIT_CHANGING:44103d2962a0f9690a8b891e7203de6e04c38ebc because clubb_core changed
in this commit larson-group/clubb.git@95d7773f81117daff784b8ab91f4211c2edc8390 on 22 Oct 2021.

I have turned the nu_vert_res_dep family of variables into a derived
type and that variable is now being passed throughout the CLUBB code,
rather than accessing variables through a USE statement.

Everything is 100% bit-for-bit!

I am updating clubb_intr.F90 for the new version of CLUBB that
now passes the nu_vert_res_dep derived type variable.

Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90

Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details

Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge

fixed a typo in pdf_closure_module.f90, line 1284

Remove blank line from run_scam.bash

in order to trigger Jenkins test.

We think that the following "differences" are due to failures of compilation, although we didn't go back and re-run fixed versions to check for answer changes:
RESOLVED:2ee1e660d23872ebe9d786a8881a78b5a0d969f2
RESOLVED:b02a38818dee2d02240dacc737d86df3e256ea3a
RESOLVED:27325febfd0a9af7199815e835e48a429a153107

For larson-group/sys_admin#763

See ticket
#958

added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk

See respective messages on the issue 958 on date 10/12/2021

Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90

Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details

Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge

fixed a typo in pdf_closure_module.f90, line 1284

Passing w_up_in_cloud out of advance_clubb_core

Updating cam for changes in the call to advance_clubb_core_api

fixed compiler warning regarding w_up_in_cloud

Remove clipping from a3_coef.

In principle, removing the clipping should reduce noise.
In practice, it makes rico noiser but mpace_b less noisy.
It also allows twp_ice to run to completion with the gfortran compiler.

This commit is BIT_CHANGING.

For #965.