Skip to content
[Jenkins]Jenkins
log in
Success

Changes

Summary

  1. Moved the ghost-point setting of xm(1) = xm(2) to the last line (details)
  2. Optional arguments are just best sometimes (#1150) (details)
  3. Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. (details)
Commit b2af0adcfce248292c5d48aefd9226666ee633e5 by bmg2
Moved the ghost-point setting of xm(1) = xm(2) to the last line
of the subroutine so this command doesn't get overwritten.

This is technically BIT_CHANGING because it alters rtm (and some
rtm-related calculations) at the ghost point, but it is not
answer changing.

This is being done in preparation for ghost point removal.
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
Commit 556370c6406e6b943b88affbe7728a5036b1ba22 by noreply
Optional arguments are just best sometimes (#1150)

* Adding optional argument to zm2zt/zt2zm to act as threshold. This cuts down on lots of bulk and reduces the chances of breaking the GPU code. All BFB.

* Removing TODO

* Replacing hardcoded 0.0_core_rknd with zero_threshold
The file was modified src/CLUBB_core/grid_class.F90 (diff)
The file was modified src/CLUBB_core/mixing_length.F90 (diff)
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/setup_clubb_pdf_params.F90 (diff)
The file was modified src/CLUBB_core/calc_pressure.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/advance_helper_module.F90 (diff)
The file was modified src/CLUBB_core/advance_windm_edsclrm_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xp3_module.F90 (diff)
Commit e904e3ffbf83888681ba64f9008890329bd18631 by Gunther Huebler
Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)