Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106) (details)
BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102 (details)
BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108) (details)
Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109) (details)
Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110) (details)
BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111) (details)
Tunable Richardson number exponent - CLUBB ticket #1102 (#1114) (details)
Tunable Richardson number exponent - CLUBB ticket #1102 (#1114) (details)
* Chaning acc declare statements to acc enter data statement
* Making acc statements more consistent
* Making lapack useable while using openacc. Lapack is still run on the CPU
* Updating setup_clubb_core to now accept clubb_config_flags as an input, and adding warning in case clubb is running with lapack but was compiled with openacc.
* Making all end parallel directives specify end loop
* Replacing last acc declare in a procedure with acc enter/exit data commands
* Removing pure declarations, turns out they dont really improve performance and openmp isn't allowed within them.
* Adding explicit directives to penta_lu and tridiag_lu, as opposed to the previously used kernels directive. Also splitting up a loop to improve GPU performance.
* Splitting up a couple loops for performance reasons.
* Moving functions called inside loops to their own 2D subroutines. This is for performance, but is also BIT_CHANGING.
* Correct range of values to calculate for term_dp1_lhs
* Comments and cleanup
* Slight change to Skx_func, this is mathematically equivalent but BIT_CHANGING. This is faster on GPUs, and doesn't seem to have a signficiant impact on CPU performance.
* Introducing wp_coef and wp_coef_zt to reduce needed computations. This changes order of operations, so it is BIT_CHANGING.
BIT_CHANGING! Added e-folding code for mixed Brunt Vaisala frequency - CLUBB ticket #1069 - Included usage for bv_efold in src/CLUBB_core/advance_helper_module.F90 - Added intent(out) for correction_stability in subroutine calc_correction_stability - Removed brunt_vaisala_freq_sqd_plus - Idiot proofed interaction between l_diag_Lscale_from_tau and l_use_invrs_tau_N2_iso - Moved stat_update_var(invrs_tau_wp3_zm) out of if ( l_diag_Lscale_from_tau ) - Fixed some typos in src/CLUBB_core/stats_zt_module.F90 - Added comment about to input_misc/tuner/README about t_variables adn input/stats/tuning_stats.in
Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106)
This commit is NOT bit changing - Removed remaining mentions of brunt_vaisala_freq_sqd_plus - Added assignment for invrs_tau_wp3_zm in Lscale mode in advance_clubb_core - Increased length of string variables hoc_v, les_v, and t_variables in src/error.F90 to accomodate tuning for invrs_tau fields
BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102
Changes in src/CLUBB_core/mixing_length.F90: - brunt_vaisala_freq_sqd_mixed is now used to calculate brunt_vaisala_freq_sqd_smth and brunt_vaisala_freq_sqd_clipped instead of brunt_vaisala_freq_sqd - Removed 0.1 factor for bkgnd term in calculation of invrs_tau_xp2_zm - Commented out clipping of invrs_tau_xp2_zm to 0.003 and lower out of cloud
BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108)
- Added new flags to inut/tunable_parameters_Lscale/configurable_model_flags.in - Changed default setting for l_use_tke_in_wp3_pr_turb_term in model_flags.F90 from false to true
Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109)
- Added C6_term and bv_freq fields to all_stats.F90 and standard_stats.F90 - Added new fields to VariableGroupTaus.py in pyplotgen - Added calls to stat_update_var to advance_clubb_core_module.F90 - Modified stats_variables.F90 and stats_zm_module.F90 accordingly
Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110)
BIT_CHANGING! Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 Changes in input/stats/all_stats.in, src/CLUBB_core/advance_clubb_core_module.F90, src/CLUBB_core/mixing_length.F90, src/CLUBB_core/stats_variables.F90, and src/CLUBB_core/stats_zm_module.F90 Ri_zm was added to input/stats/standard_stats.in
BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111)
This commit is BIT_CHANGING because: 1. the output field Richardson_num was removed. 2. Since the flag l_use_shear_turb_freq_sqd was removed, the variable shear_sqd is now always written to disk. That means previously, the outputted field shear_sqd was 0 everywhere whereas now it is not anymore. The calculation of shear_sqd within CLUBB did not change! - Removed mentions in input/stats/all_stats.in and standards_stats.in - Removed mentions in src/CLUBB_core/stats_variables.F90 and stats_zm_module.F90 - In src/CLUBB_core/advance_helper_module.F90 removed mentions to [i]Richardson_num[_clipped], as well as l_use_shear_turb_freq_sqd, l_Richardson_vert_avg, and turb_freq_sqd sinc those are only used for calculation of Richardson_num.
Tunable Richardson number exponent - CLUBB ticket #1102 (#1114)
BIT_CHANGING! Added the exponent to the Richardson number in the calculation of the invrs_tau_wpxp threshold term in src/CLUBB_core/mixing_length.F90 to the list of tunable parameters. This is bit changing due to the difference in Fortran between taking the sqrt and the .5th power.
Tunable Richardson number exponent - CLUBB ticket #1102 (#1114)
BIT_CHANGING! Added the exponent to the Richardson number in the calculation of the invrs_tau_wpxp threshold term in src/CLUBB_core/mixing_length.F90 to the list of tunable parameters. This is bit changing due to the difference in Fortran between taking the sqrt and the .5th power.
- Added new folder input/tunable_parameters_tauMatchLscale/ for latest taus code setup reproducing the master Lscale output. - Changes in src/CLUBB_core_mixing_length.F90: - Renamed ddzt_umvm -> ddzt_umvm_sqd ddzt_umvm_clipped -> ddzt_umvm_sqd_clipped sqrt_ddzt_umvm -> norm_ddzt_umvm smooth_sqrt_ddzt_umvm -> smooth_norm_ddzt_umvm Ri_zm_clipped -> Ri_zm_smooth in some places - Made some variable replacements for consistency's sake - Fixed path of log files in run_scripts/run_bindiff_all.py
BIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120)
- Removed commented lines from tunable_parameters.in file in input/tunable_parameters_tauMatchLscale - Increased z_displace value from 10 to 25. This value was chosen so that the taus code with the parameter and flag settings in input/tunable_parameters_tauMatchLscale match the master Lscale output below clouds - Fixed some issues with the new parameter wpxp_Ri_exp: - Moved new exponentiation to a place so that it emulates the previous version with sqrt(Ri_zm) - Adjusted code for l_smooth_min_max=true to match the default version
![[Jenkins]](/jenkins/static/57c8a776/images/svgs/logo.svg){kind=logo}
