Skip to content
[Jenkins]Jenkins
log in

Changes

#13 (Nov 7, 2023, 6:28:11 PM)

  1. CLUBB ticket #1069: (#1092) — noreply / githubweb
  2. CLUBB ticket #1069: (#1092) — noreply / githubweb
  3. Added bv_efold changes for CLUBB API calls — Vince Larson / githubweb
  4. Changing "Fnc" to "fnc" for consistency and easy search. — benjamin.andrew.stephens / githubweb
  5. Memory usage optimizations (#1091) — noreply / githubweb
  6. Making compatible with latest clubb changes. — Gunther Huebler / githubweb
  7. Openacc tweaks and cleanup (#1097) — noreply / githubweb
  8. Loop to `nz-1` instead of `nz` because upper boundary condition — noreply / githubweb
  9. Openacc tweaks and cleanup 2 (#1099) — noreply / githubweb
  10. Bit changing changes (#1104) — noreply / githubweb
  11. Adding wp_coef and wp_coef_zt to acc data statements. — Gunther Huebler / githubweb
  12. Bv efold bit changing (#1095) — noreply / githubweb
  13. Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106) — noreply / githubweb
  14. BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102 — noreply / githubweb
  15. BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108) — noreply / githubweb
  16. Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109) — noreply / githubweb
  17. Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110) — noreply / githubweb
  18. BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111) — noreply / githubweb
  19. Tunable Richardson number exponent - CLUBB ticket #1102 (#1114) — noreply / githubweb
  20. Tunable Richardson number exponent - CLUBB ticket #1102 (#1114) — noreply / githubweb
  21. Raw-copy updating SRC/CLUBB — root / githubweb
  22. Raw-copy updating CLUBB_PARAMETERS — root / githubweb
  23. Deletes svn id tag, will trigger host-model nightly tests. — noreply / githubweb
  24. Raw-copy updating SRC/CLUBB — LarsonGroupSysAdmin / githubweb
  25. Update clubb_sgs.F90 — 42725900+domkesteffen / githubweb
  26. Add library calls to allow SAM to compile with new icx intel compiler (#154) — noreply / githubweb
  27. Remove svn id tag in order to trigger nightly tests. — noreply / githubweb
  28. Removed 3rd svn id tag in order to trigger nightly tests — noreply / githubweb
  29. Finally removing scratch variables. (#1116) — noreply / githubweb
  30. Latest batch of non-bit changing code changes - CLUBB ticket #1115 (#1119) — noreply / githubweb
  31. BIT_CHANGING! Fixed some issues with wpxp_Ri_exp, changed z_displace value - CLUBB ticket #1115 (#1120) — noreply / githubweb

#2 (Jun 27, 2023, 2:52:37 PM)

  1. Gunthers branch (#996) — noreply / githubweb
  2. Various simple changes to improve performance. All bit-for-bit. — Gunther Huebler / githubweb
  3. Pushing loop into calc_stability_correction. — Gunther Huebler / githubweb
  4. Small bug fix. — Gunther Huebler / githubweb
  5. Another similar small bug fix. — Gunther Huebler / githubweb
  6. Adding in comments to the Jenkinsfiles to clarify advanced syntax usage and commands with unclear purpose. — pbroels / githubweb
  7. Gunthers branch (#999) — noreply / githubweb
  8. Renamed smth_range to heaviside_smth_range — 68997723+JanGrn / githubweb
  9. Added tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes. — 68997723+JanGrn / githubweb
  10. Implemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0. — 68997723+JanGrn / githubweb
  11. Changed priorities of total normalized variation stats, included error handling in total normalized variation stats. — 68997723+JanGrn / githubweb
  12. Renamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls. — 68997723+JanGrn / githubweb
  13. Gunthers branch 2 (#1002) — noreply / githubweb
  14. Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail. — 68997723+JanGrn / githubweb
  15. Renaming the new case from SHEAR_DRIVEN to NEUTRAL, and associated mentions in files. — benjamin.andrew.stephens / githubweb
  16. Added ability to apply smooth min max functions in mixing_length.F90 — 68997723+JanGrn / githubweb
  17. Updated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
  18. Checked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965 — 68997723+JanGrn / githubweb
  19. Added test cases to smooth_min_max_tests.F90 and updated documentation. — 68997723+JanGrn / githubweb
  20. removed SAM_CLUBB_standards.tex, SAM_CLUBB.tex, SAM_code_notes.tex, and SAM6.10_guide.doc larson-group/sys_admin#622 — cernikt / githubweb
  21. COrrecting a couple of omissions from when I was renaming the shear_driven case to "neutral". — benjamin.andrew.stephens / githubweb
  22. Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
  23. Constructing rcm within SILHS (as rcm_pdf) (#1011) — noreply / githubweb
  24. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4. — benjamin.andrew.stephens / githubweb
  25. Almost final loop pushes (#1012) — noreply / githubweb
  26. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  27. Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) — noreply / githubweb
  28. The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. — Gunther Huebler / githubweb
  29. Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version. — Gunther Huebler / githubweb
  30. Removing setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). — Gunther Huebler / githubweb
  31. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  32. Making 2D versions of setup_grid and setup_parameters. — Gunther Huebler / githubweb
  33. Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value. — Gunther Huebler / githubweb
  34. Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types. — Gunther Huebler / githubweb
  35. Lots of small loop pushes — 37674341+huebleruwm / githubweb
  36. Small bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run. — 37674341+huebleruwm / githubweb
  37. Small refactoring to mfl_xm_lhs, just removing need to pass in gr. — 37674341+huebleruwm / githubweb
  38. Final loop pushes needed before the grid change. — 37674341+huebleruwm / githubweb
  39. Replacing use of gr with nz — 37674341+huebleruwm / githubweb
  40. Replacing use of gr with nz — 37674341+huebleruwm / githubweb
  41. added -heap-arrays tag to FFlags on Makefile to fix jenkins testing error — cernikt / githubweb
  42. Makefile came with a few other accidental changes, these have been corrected. — cernikt / githubweb
  43. The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb
  44. The big grid change. Converting gr from being an array of types containing 1D arrays, to a type containing 2D arrays. All cases BFB, cam multicolumn+silhs BFB, and cam multicolumn (no silhs) with backwards compatible settings BFB. — 37674341+huebleruwm / githubweb
  45. Adding column index to gr arrays, hard coding to 1 since sam only uses single column calls. — Gunther Huebler / githubweb
  46. Removing the zt2zm interface from clubb_api and making the api calls just redirect to the grid class interface for it. — 37674341+huebleruwm / githubweb
  47. Pushing column loop into mean advection procedures. — 37674341+huebleruwm / githubweb
  48. Little loop push — 37674341+huebleruwm / githubweb
  49. Moving above/below index of grid weights to last dimension. — 37674341+huebleruwm / githubweb
  50. Hardcoding 1 into uses of gr arrays where single column versions of gr is used. — Gunther Huebler / githubweb
  51. Pushing loop into fill_holes. — 37674341+huebleruwm / githubweb
  52. Forgot small change. — 37674341+huebleruwm / githubweb
  53. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  54. Making linear_interpolated_azt_2D and linear_interpolated_azm_2D subroutines just to avoid a needless data copy. — 37674341+huebleruwm / githubweb
  55. Making update_xp2_mc 2D and creating interface for 1D calls. — 37674341+huebleruwm / githubweb
  56. Fixing units in stats_zt_module.F90 — noreply / githubweb
  57. Fixing a bug in mono_flux_limiter.F90. (#1026) — noreply / githubweb
  58. Fixing a bug. — bmg2 / githubweb
  59. I changed the w_up_in_cloud code in 2 ways: — bmg2 / githubweb
  60. I added stats output for w_down_in_cloud to all_stats.in. — bmg2 / githubweb
  61. Modified for the latest changes to CLUBB. — bmg2 / githubweb
  62. adding line to fix mpi configuration in micro drizzle test — cernikt / githubweb
  63. I altered the w_up_in_cloud and w_down_in_cloud code so that a — bmg2 / githubweb
  64. I have optimized the new w_up_in_cloud and w_down_in_cloud code by — bmg2 / githubweb
  65. Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972. — 37674341+huebleruwm / githubweb
  66. Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  67. Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  68. Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  69. Making compatible with latest clubb change. — Gunther Huebler / githubweb
  70. Removing elementalness from sat_vapor_press_liq and making interal procedures subroutines rather than functions to prevent unneccesary data copies. Doing the same for thlm2T_in_K since it is often used in conjunction with sat_vapor_press_liq. Bit-for-bit confirmed with O0 using all single column cases with or without l_diag_Lscale_from_tau, and with cam_coarse_res. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  71. Adding comments. — 37674341+huebleruwm / githubweb
  72. Adding initial subroutine calc_ice_cloud_frac_component. — 37674341+huebleruwm / githubweb
  73. Cleaning up new subroutine calc_liquid_cloud_frac_component, and making sat_mixrat_ice a subroutine that works the same way as sat_mixrat_liq. larson-group/clubb#972 — 37674341+huebleruwm / githubweb
  74. Comment update — 37674341+huebleruwm / githubweb
  75. Removing these paratheses is BIT_CHANGING since it modifies the order of operations, but allows for the multiplication and subraction to be done in parallel for complex pipelines. — 37674341+huebleruwm / githubweb
  76. Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical. — 37674341+huebleruwm / githubweb
  77. Updating column num input in config flags. larson-group/clubb#1033 — 37674341+huebleruwm / githubweb
  78. Adding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033 — 37674341+huebleruwm / githubweb
  79. Improvements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical. — 37674341+huebleruwm / githubweb
  80. Namelists need to be closed with a '/', and omitting it will break many tests. — Gunther Huebler / githubweb
  81. Making save variables in the multicol code threadprivate, this fixes the openmp test. Also changing the way we name and save the multicol output, this allows the parallel run to run with multiple columns. I've reflected the changes in comments where relevant. larson-group/clubb#1033 — Gunther Huebler / githubweb
  82. Adds commented-out line that prevents the monotonic flux — noreply / githubweb
  83. Updating monotonic flux limiter code to remove spikes. (#1038) — noreply / githubweb
  84. Creating new flags to control monotonic flux limiter (#1039) — noreply / githubweb
  85. Creating new flags to control monotonic flux limiter (#1039) — noreply / githubweb
  86. Updating for changes to CLUBB.  See https://github.com/larson-group/clubb/pull/1039. — 59519056+bstephens82 / githubweb
  87. I am adding cloudy_updraft_frac and cloudy_downdraft_frac as — bmg2 / githubweb
  88. Updating SAM-CLUBB for the latest changes to the call to — bmg2 / githubweb
  89. Minor adjustment to eliminate spikes in thlm tendencies from the monotonic flux limiter. (#1043) — noreply / githubweb
  90. Making interface for matrix solvers. — 37674341+huebleruwm / githubweb
  91. Making tridag tridiag everywhere, making sol soln, and adding intent comments. — 37674341+huebleruwm / githubweb
  92. A different way of dealing with monotonic flux limiter spikes (#1046) — noreply / githubweb
  93. Steffens tuner fixer branch (#1041) — noreply / githubweb
  94. Making compatible with latest clubb changes. — Gunther Huebler / githubweb
  95. Adding capability to change matrix solving method via clubb_config_flags. — 37674341+huebleruwm / githubweb
  96. Fixing small bug, need to pass _copy arrays to prevent lapack mangling the real ones. — 37674341+huebleruwm / githubweb
  97. Adding capability to change matrix solving method via clubb_config_flags. — 37674341+huebleruwm / githubweb
  98. Making GPU and CPU versions of the penta_lu solver the same as discussed in larson-group/clubb#1024. — 37674341+huebleruwm / githubweb
  99. Replacing $ with & in namelist definition to make consistent. — Gunther Huebler / githubweb
  100. I added "smooth" max clipping for invrs_tau_shear, which is a variable — bmg2 / githubweb
  101. ADG1_pdf_driver subroutine port with OpenACC — 37674341+huebleruwm / githubweb
  102. Replacing old elemental ADG1_w_closure with new GPUized one. Making G_unit tests work with new version. Also making mixt_frac_max_mag a scalar since it was only being used as such. larson-group/clubb#1049 — 37674341+huebleruwm / githubweb
  103. I can now safely remove all the "ifdef E3SM" statements from CLUBB's — bmg2 / githubweb
  104. Pushing column loop into lapack wrap. — 37674341+huebleruwm / githubweb
  105. Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052) — noreply / githubweb
  106. Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) — noreply / githubweb
  107. Breaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051) — noreply / githubweb
  108. Adding tridiag_lu solver (#1056) — noreply / githubweb
  109. Adding OpenACC data directives for mixing length and adg routines — Vince Larson / githubweb
  110. Fixing error causing GPU code not to run. Some variables to be copied were labelled as (ngrdcol,nz) when it should be (:ngrdcol,:nz). I've just removed the data length specifiers completely since they are not neccesary in general. — Gunther Huebler / githubweb
  111. GPUizing sat_mixrat_ice_2D. — 37674341+huebleruwm / githubweb
  112. Pushing column loop into calculate_thvm — 37674341+huebleruwm / githubweb
  113. Removing update_pressure since it is no longer called anywhere in clubb or host models. The addition of this subroutine was discussed in larson-group/e3sm#6 and the removal of the call to it was discussed in larson-group/clubb#926. — 37674341+huebleruwm / githubweb
  114. Removing update_pressure from public list. This was causing compilation crashes. RESOLVED:8c7230fecb877d04fb129ef5e143e0993b4b29b1 — Gunther Huebler / githubweb
  115. GPUizing some helping procedures. — 37674341+huebleruwm / githubweb
  116. Removing sigma_sqd_w from the acc data copyout statement. This is a bug which was causing the code to crash when not using managed memory. — 37674341+huebleruwm / githubweb
  117. Porting pdf_closure subroutine with OpenACC (#1059) — noreply / githubweb
  118. Adding wp3_on_wp2_cfl_num to CLUBB's output stats. — bmg2 / githubweb
  119. Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly. — 37674341+huebleruwm / githubweb
  120. Clubb ticket #1025: Implemented way to make esa tuner reproducible, h… (#1068) — noreply / githubweb
  121. Gpu updates (#1070) — noreply / githubweb
  122. Implements Thomas Toniazzo's bug fix for spike removal — noreply / githubweb
  123. Making 'a_const' into a CLUBB tunable parameter. (#1072) — noreply / githubweb
  124. Making 'a_const' into a CLUBB tunable parameter. (#1072) — noreply / githubweb
  125. Updating for changes to CLUBB.  See PR #1072. — benjamin.andrew.stephens / githubweb
  126. Pdf closure driver gpuization (#1071) — noreply / githubweb
  127. Moving compute_cloud_cover outside of if ( l_use_cloud_cover ) then statement, the cloud_cover and rcm_in_layer variables they compute aren't output in clubb_standalone, but are in cam, causing cam bit diff tests to break. — Gunther Huebler / githubweb
  128. Adding Skthl_zm to the update host list, I missed this in the last PR. I noticed this by comparing results with and without managed memory, now I've checked BFBness with arm, mpace_b, mc3e, and gabls2. — Gunther Huebler / githubweb
  129. Small GPU fixes (#1076) — noreply / githubweb
  130. Code changes to implement modificiations on wp3 clippings — bmg2 / githubweb
  131. Code changes to implement modificiations on wp3 clippings — bmg2 / githubweb
  132. This commit contains code changes to implement modifications on limiters in three places: — bmg2 / githubweb
  133. This commit contains code changes to implement modifications on limiters in three places: — bmg2 / githubweb
  134. Updated for recent changes to CLUBB. — bmg2 / githubweb
  135. changing tunable_parameters — cernikt / githubweb
  136. changing tunable_parameters — cernikt / githubweb
  137. changing tunable_parameters — cernikt / githubweb
  138. Advance xm wpxp gpuization (#1077) — noreply / githubweb
  139. Small tweaks to fix some GPU bugs. Some variables were uninitialized on the CPU while we were saving them. This could only have been caught by comparing consecutive runs and checking _zt and _zm files, even then few cases were having problems. — Gunther Huebler / githubweb
  140. Fixing a labelling error in redirect_interpolated_azt_2D and similar procedures, since this interpolates to zt the input should be zm. I think this was my fault, so I cleaned all the zt2zm and zm2zt things up to make it a little nicer. Also ordered the routines _k _1D _2D to make it easier to jump around, it was a bit confusing as they were out of order and the typo really made it hard. — Gunther Huebler / githubweb
  141. Making it so sclr_tol is set to 0 before the specified sclr_tol_in. This is so that it is initialized to 0 in the case that sclr_dim = 0, since now we are setting it to have a minimum allocation size of 1 and would otherwise have a garbage value. This is what broke the clubb_openmp_gfortran_test. — Gunther Huebler / githubweb
  142. Lscale GPUization (#1079) — noreply / githubweb
  143. gfortran does not like intent(out) specifiers for functions. — Gunther Huebler / githubweb
  144. GPUizing Various Small Routines (#1080) — noreply / githubweb
  145. This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
  146. This commit is a commit that changes absolutely nothing. It is meant to trigger a change in the git update scripts, so that I can start the commit message logging in the autocommit updates larson-group/sys_admin#797 — cernikt / githubweb
  147. this is another commit that cahnges nothing that will trigger the gitUpdate scripts — cernikt / githubweb
  148. adding an update that changes nothing and is just a test for the autoupdate script — cernikt / githubweb
  149. Making CLUBB's splatting scheme implicit and smoother (#1075) — noreply / githubweb
  150. Calc sfc varnce GPUization (#1081) — noreply / githubweb
  151. Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code. — benjamin.andrew.stephens / githubweb
  152. Reducing C_wp2_splat to 0.25 (from 2.0) for new implicit splatting code. — benjamin.andrew.stephens / githubweb
  153. Removed Space From clip_explicit — cernikt / githubweb
  154. making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
  155. making changes to trigger autoudpate for test, these commits do nothing — cernikt / githubweb
  156. Here is another commit that changes nothing — cernikt / githubweb
  157. Here is another commit that changes nothing — cernikt / githubweb
  158. change to trigger updates — cernikt / githubweb
  159. change to calc pressure to trigger autoupdate — cernikt / githubweb
  160. GPUizing Lscale_width_vert_avg. Loops have been restructured for simplicity, and algorithm has a different starting value to avoid k dependency. Results are BFB. (#1083) — noreply / githubweb
  161. GPUizing most of advance_clubb_core (#1084) — noreply / githubweb
  162. advance_wp2_wp3 with explicitly managed memory  (#1085) — noreply / githubweb
  163. advance_xp2_xpyp with explicitly managed memory (#1086) — noreply / githubweb
  164. advance_windm_edsclrm with explicitly managed memory (#1087) — noreply / githubweb
  165. Moving data statements to outter most parts of clubb and little fix in advance_wp2_wp3 (#1088) — noreply / githubweb
  166. Data movement improvement (#1089) — noreply / githubweb