Skip to content
Success

Changes

Summary

  1. Commenting out sponge damping code. This is BIT_CHANGING. (details)
  2. This fixes a bug that was exposed when we switched to having pdf closure in the post position. pdf_params_chnk is the structure that keeps track of the pdf_params each timestep, and the single_col version is only a local variable we use to get pdf_params from clubb then save them into the chnk version. But we were not copying from the chnk version into the single_col version before calling clubb, so when pdf_closure is done in post, we had incorrect pdf_params as input. This is BIT_CHANGING. This will also be deleted in the next commit, it is mostly symbolic just to demonstrate what exactly the problem was. (details)
  3. Making clubb_tend_cam use the multi column version of clubb. This is bit-for-bit. (details)
Commit 01b2efa06e1d3a73179c28133ae7b38e53be3851 by Gunther Huebler
Commenting out sponge damping code. This is BIT_CHANGING.
The file was modified components/eam/src/physics/cam/clubb_intr.F90 (diff)
Commit b9defd7e5ca98a8cfa0579f3284b18459e565c47 by Gunther Huebler
This fixes a bug that was exposed when we switched to having pdf closure in the post position. pdf_params_chnk is the structure that keeps track of the pdf_params each timestep, and the single_col version is only a local variable we use to get pdf_params from clubb then save them into the chnk version. But we were not copying from the chnk version into the single_col version before calling clubb, so when pdf_closure is done in post, we had incorrect pdf_params as input. This is BIT_CHANGING. This will also be deleted in the next commit, it is mostly symbolic just to demonstrate what exactly the problem was.
The file was modified components/eam/src/physics/cam/clubb_intr.F90 (diff)
Commit 4c916bb095ba518c52a09fc774a988290a344d1a by Gunther Huebler
Making clubb_tend_cam use the multi column version of clubb. This is bit-for-bit.
The file was modified components/eam/src/physics/cam/clubb_intr.F90 (diff)