Changes

Summary

1. Removes a blank line in order to trigger merge with E3SM (details)
2. Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972 (details)
3. Replacing the i loop iterator for scalars with sclr. (details)
4. Pushing loop into advance_xp2_wpxp. (details)
5. Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats. (details)
6. Moving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call. (details)
7. Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way. (details)
8. Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn. (details)
9. Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp. (details)

Removes a blank line in order to trigger merge with E3SM

Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972

Replacing the i loop iterator for scalars with sclr.

Pushing loop into advance_xp2_wpxp.

Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats.

Moving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call.

Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way.

Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn.

Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp.