Skip to content
Success

Changes

Summary

  1. I have passed clubb_params down into advance_xm_wpxp_module.F90. (details)
  2. I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. (details)
  3. I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 (details)
  4. Passing down more of CLUBB's tunable parameters. (details)
  5. I accidentally removed an important comment in the previous commit. (details)
  6. Passing down more CLUBB tunable parameters. (details)
  7. More passing down CLUBB parameters ... whoop-de-doo (details)
  8. Passing down more tunable parameters and removing references to (details)
  9. Handling the abomination that is lmin. (details)
  10. Passing tunable parameters into the new tau code. (details)
  11. Passed down more parameters. Results are bit-for-bit. (details)
  12. Passing through more clubb parameters. Bit-for-bit (details)
  13. Passing down CLUBB's tunable parameters into the setup_pdf_parameters and (details)
  14. I passed down CLUBB's tunable parameters into the advance_microphys portion of (details)
  15. Passing down CLUBB's tunable parameters into the remainder of the (details)
  16. I passed down the forgotten thlp2_rad_coef tunable parameter. (details)
  17. Passing down CLUBB's tunable parameters into CLUBB's (details)
  18. I am passing down the forgotten parameter, altitude threshold, in (details)
  19. I am committing the final stage of the "pass-down params" project. (details)
  20. Adding an option to use invrs_tau_N2_iso for C4 terms.  The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233).  The flag is currently set to false so results will be b4b. (details)
  21. Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion.  This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. (details)
  22. Adding comments for clarity. (details)
Commit f1d888a37cfeeac7b39fd67a7efe332cd27ed65e by bmg2
I have passed clubb_params down into advance_xm_wpxp_module.F90.

The results from this revision are an exact match to the results from
the previous revision for all cases.
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
Commit a73978a3fa1608e44d1d818dbd6b47edcfb4f5d6 by bmg2
I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.

The results in NetCDF output files from this revision are an exact match to the
results in NetCDF output files from the previous revision for all cases.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
Commit 438fbd1f8d117ae85d249575d41e5007775e305d by bmg2
I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90
for most parameters, excluding C4 and C14. Results are unchanged.
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit fe0fc9f90888412a259fba12fc61e5d14d53faa4 by bmg2
Passing down more of CLUBB's tunable parameters.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/pdf_closure_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
Commit cdcc03bf39a00d082e57115d1b45ea6d3481a740 by bmg2
I accidentally removed an important comment in the previous commit.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit 3c7fecaba43e458a2a0a5f10f98e2c8cd3c6de16 by bmg2
Passing down more CLUBB tunable parameters.

Everything is bit-for-bit.
The file was modified src/CLUBB_core/advance_helper_module.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
Commit 66af005868cf95e986d51d7f656177cf7344741a by bmg2
More passing down CLUBB parameters ... whoop-de-doo
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified src/CLUBB_core/pdf_closure_module.F90 (diff)
The file was modified src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90 (diff)
Commit 55a47e458f6dad402c8c2f5094efe28012949463 by bmg2
Passing down more tunable parameters and removing references to
parameters_tunable. Results are bit-for-bit.
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/diagnose_correlations_module.F90 (diff)
The file was modified src/CLUBB_core/sfc_varnce_module.F90 (diff)
The file was modified src/CLUBB_core/Skx_module.F90 (diff)
Commit 7c8ad62fa35fbe06da2b7dc3ee40ed35234125e8 by bmg2
Handling the abomination that is lmin.
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/mixing_length.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit 8f26dce1c7565c16fff85a0661ec47bff2afd353 by bmg2
Passing tunable parameters into the new tau code.
The file was modified src/CLUBB_core/mixing_length.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit b3b3c90a9bfe58517074d1323a4afc072e86ac4d by bmg2
Passed down more parameters. Results are bit-for-bit.
The file was modified src/CLUBB_core/clip_explicit.F90 (diff)
The file was modified src/CLUBB_core/mixing_length.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
Commit a4ea4767df36095f7acac78c07c2ca41d88a0e27 by bmg2
Passing through more clubb parameters. Bit-for-bit
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/parameters_model.F90 (diff)
Commit 253982d8ae576b347c421c1721742cf9dedeee26 by bmg2
Passing down CLUBB's tunable parameters into the setup_pdf_parameters and
precipitation fraction portions of the code. Everything is bit-for-bit.
The file was modified src/CLUBB_core/setup_clubb_pdf_params.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/CLUBB_core/precipitation_fraction.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
Commit 3a9d5757433916b8b1acd46df13293d5d3cf0d2d by bmg2
I passed down CLUBB's tunable parameters into the advance_microphys portion of
the code. It's all bit-for-bit.
The file was modified src/advance_microphys_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
Commit 83b29b9b67737e9df79afeb31e033f1140fb6d25 by bmg2
Passing down CLUBB's tunable parameters into the remainder of the
PDF subroutines. Everything is bit-for-bit.
The file was modified src/CLUBB_core/new_pdf_main.F90 (diff)
The file was modified src/CLUBB_core/pdf_closure_module.F90 (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/new_hybrid_pdf_main.F90 (diff)
Commit 7a306fed7c43c4868e4996ef2fd6e5f604b26732 by bmg2
I passed down the forgotten thlp2_rad_coef tunable parameter.
All bit-for-bit.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
Commit b4d5fb7b8e293100938833b36f3783405c9774d8 by bmg2
Passing down CLUBB's tunable parameters into CLUBB's
microphysics initialization.
The file was modified src/microphys_init_cleanup.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
Commit ae462c9ecc9dac803b2719ccb5aae1126a840c2d by bmg2
I am passing down the forgotten parameter, altitude threshold, in
advance_xm_wpxp_module.F90.
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
Commit bb06897ec9a8a659c69f05c005cb6b7f3380975e by bmg2
I am committing the final stage of the "pass-down params" project.
The results are bit-for-bit identical.
The file was modified src/CLUBB_core/output_netcdf.F90 (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified src/clubb_thread_test.F90 (diff)
The file was modified src/CLUBB_core/stats_clubb_utilities.F90 (diff)
The file was modified src/SILHS/latin_hypercube_driver_module.F90 (diff)
The file was modified src/SILHS/silhs_api_module.F90 (diff)
The file was modified src/SILHS/output_2D_samples_module.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/error.F90 (diff)
The file was modified src/clubb_standalone.F90 (diff)
The file was modified src/jacobian.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
Commit edb7bc84684712739876ec803541ba3b165f4a5a by 59519056+bstephens82
Adding an option to use invrs_tau_N2_iso for C4 terms.  The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233).  The flag is currently set to false so results will be b4b.

See also the discussion here: https://github.com/larson-group/clubb/issues/920#issuecomment-920338746 and following comments.
The file was modified src/CLUBB_core/mixing_length.F90 (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
Commit 17d242a65d579c70299dfcecb853f2aed5e0feb1 by 59519056+bstephens82
Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion.  This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
Commit a29c355bfc54d7459a6107cf45b593473dcce8d1 by 59519056+bstephens82
Adding comments for clarity.
The file was modified src/CLUBB_core/mixing_length.F90 (diff)