Skip to content
Success

Changes

Summary

  1. Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3.  Relevant to CLUBB issue #920. (details)
  2. Updates as requested to the l_use_tke_in_K_dfsn code: (details)
Commit 987d63de489d2baa09ad6e1538b2c6dbb7551690 by 59519056+bstephens82
Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3.  Relevant to CLUBB issue #920.

Results are b4b when the flag is turned off, which it currently is.
The file was modified src/CLUBB_core/model_flags.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified input/tunable_parameters_Lscale/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/clubb_tuner.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
The file was modified input/tunable_parameters_e3sm/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
Commit 79bc651171add5b6a340be02cf6f775ddc779aaa by 59519056+bstephens82
Updates as requested to the l_use_tke_in_K_dfsn code:

- The name of the flag is changed to l_use_tke_in_wp2_wp3_K_dfsn
- Comments are added to the main pieces of code in advance_wp2_wp3
- The flag is added to the "compatible_r8029" configurable flags file.

See this comment https://github.com/larson-group/clubb/issues/920#issuecomment-931446401 and following for more information.
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified input/tunable_parameters_e3sm/configurable_model_flags.in (diff)
The file was modified input/tunable_parameters_compatible_r8029/configurable_model_flags.in (diff)
The file was modified src/clubb_tuner.F90 (diff)
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/model_flags.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified input/tunable_parameters_Lscale/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)