Skip to content
Success

Changes

Summary

  1. Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 (details)
  2. Making e3sm use the single column version of advance clubb core directly, since it does not want to use the interface version. larson-group/clubb#972 (details)
  3. Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 (details)
  4. Breaking up column loop in advance_clubb_core. larson-group/clubb#972 (details)
  5. Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972 (details)
  6. I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence (details)
  7. Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 (details)
  8. Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 (details)
  9. Making a commit that officially places the call to the PDF in the "post" (details)
  10. Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 (details)
  11. Forgot an & symbol. (details)
  12. We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 (details)
  13. I am updating ice_supersat_frac to be an intent(inout) variable for (details)
  14. Making compatible with latest clubb change. (details)
  15. quick_test (details)
Commit 946ca541e9acab72c5dbd52b2df8651bfc0bfb76 by Gunther Huebler
Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972
The file was modified clubb_api_module.F90 (diff)
Commit db4593f73e3fe65968cdee9579c6d6996f3f83c8 by Gunther Huebler
Making e3sm use the single column version of advance clubb core directly, since it does not want to use the interface version. larson-group/clubb#972
The file was modified components/cam/src/physics/cam/clubb_intr.F90 (diff)
Commit 7e6744fa4864a0219f8e4a32d0d72fb2664598d9 by Gunther Huebler
Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972
The file was modified clubb_api_module.F90 (diff)
Commit 0bae8e4aaa7651515c8d5df797909bd9de345c2f by Gunther Huebler
Breaking up column loop in advance_clubb_core. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
Commit d55d2cbc2faec828838317f478b04fa8ea410f7a by Gunther Huebler
Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
Commit fabb386b09890bd8a64d59b5ae24bae937af9f93 by bmg2
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence
from going to the model top, which ultimately caused MC3E to crash
by becoming too cold.  Additionally, I set C_invrs_tau_shear back
to 0.15 from 0.16. This commit is BIT_CHANGING.
The file was modified parameters_tunable.F90 (diff)
Commit 2c6b628542302815ac566410bfa583f64b252464 by Gunther Huebler
Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
Commit af9c183212dde92967cca80d87ef80f1aabd76b1 by Gunther Huebler
Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972
The file was modified pdf_closure_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit c0b2297dad094c1121026e8520de001748c1d0a7 by bmg2
Making a commit that officially places the call to the PDF in the "post"
position (meaning after CLUBB's predictive fields have been advanced).
This commit is BIT_CHANGING
The file was modified model_flags.F90 (diff)
Commit f1c545226c133b42ec11c523daee00e938910cf3 by Gunther Huebler
Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972
The file was modified pdf_closure_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified adg1_adg2_3d_luhar_pdf.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
Commit 376d0e4907dc788fce6a52b6d0dc5ad4d7481f34 by Gunther Huebler
We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972
The file was modified pdf_closure_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 0201571e2624e4580ec5e4f44582e187d7908ebb by bmg2
I am updating ice_supersat_frac to be an intent(inout) variable for
advance_clubb_core. When the PDF is in the "post" position, there is
a chance that it can be used before it is set unless it is preserved
from timestep to timestep.
The file was modified clubb_api_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 1037d7413da3d46060b17cf8589d8afb9797c98f by Gunther Huebler
Making compatible with latest clubb change.
The file was modified components/cam/src/physics/cam/clubb_intr.F90 (diff)
The file was modified components/cam/src/physics/clubb/model_flags.F90 (diff)