Skip to content
Success

Changes

Summary

  1. Eliminating l_update_pressure flag. (details)
  2. Fixing compilation error caused by flag removal (details)
  3. Eliminating l_upwind_wpxp_ta flag. (details)
  4. Updates to tuner to print the improvement in the individual variables at the end of the tuner run, in addition to the total improvement. (details)
  5. Changing the denominator in the variable-by-variable expression so that the individual terms add up to the total percent improvement. (details)
  6. Updating the surface clipping coefficient... (details)
  7. Adding blank line to note that my previous commit was BIT_CHANGING. (details)
  8. Change normalization of sensitivity matrix. (details)
  9. Adding in l_vary_convect_depth as requested. (details)
  10. Removing blank line... (details)
  11. Removing a couple of unused parameters from use statement. (details)
  12. Pushing k loop down through clip_variance_level. (details)
  13. Udpates to make it possible for us to keep certain parameters equal to each other during tuning. (details)
  14. Updates to improve error checking for the tuner, updates to comments. (details)
  15. Getting rid of a duplication of code. (details)
  16. Updating name of l_vary_params_together flag to l_keep_params_equal, since this is probably more clear and also is more consistent with my comments in the code. (details)
  17. Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included. (details)
  18. Removing an old comment (details)
  19. Updating some comments related to the tuner updates. (details)
  20. Update README (details)
  21. Minor updates requested in pull request: renaming a variable and adding some comments. (details)
  22. Adding space to trigger autoupdate. larson-group/sys_admin#755 (details)
  23. Remove space to trigger autoupdate. larson-group/sys_admin#755 (details)
  24. Add space to trigger nightly tests.  For larson-group/sys_admin#755. (details)
  25. Adding in helper scripts to replace variables as in ticket #886 and ticket #733. (details)
  26. Add a blurb on plotting CAM output to the pyplotgen README. (details)
  27. Updates to pyplotgen to include LASSO cases.  Currently the WRF benchmark file path is not going to be generally valid.  We will probably want to add the WRF-LASSO benchmark files to the benchmark repo, but they will need some additional processing to get rid of large 3D variables that we don't need, or possibly add some additional variables that we want. (details)
  28. Some updates to the paths for the WRF-LASSO benchmark files, and some minor updates so that a few more variables will show up from both the WRF-CLUBB runs and the WRF-LASSO benchmark runs. (details)
  29. Adding wpuiui to VariableGroupWs.py (details)
  30. I am fixing a bug that was introduced in 6b0348e, where the logical (details)
Commit 96163408eb466460b5265a137a826b10242fa390 by rhodesk
Eliminating l_update_pressure flag.
For ticket #926.
Results are confirmed to be BFB identical.
The file was modified src/clubb_tuner.F90 (diff)
The file was modified input/tunable_parameters_compatible_r8029/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/model_flags.F90 (diff)
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
The file was modified input/tunable_parameters_e3sm/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit ab1dfbebc1efbdf262564f50b3a9e5450a7cf9cf by rhodesk
Fixing compilation error caused by flag removal
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
Commit fe04ac942588573394579558242909b97254ccbb by rhodesk
Eliminating l_upwind_wpxp_ta flag.
For issue #926.
Results are confirmed BFB identical.
The file was modified input/tunable_parameters_Lscale/configurable_model_flags.in (diff)
The file was modified src/clubb_tuner.F90 (diff)
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified input/tunable_parameters_e3sm/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/model_flags.F90 (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified input/tunable_parameters_compatible_r8029/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/advance_xm_wpxp_module.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
Commit 02cccd21b6adb0e05e98f5c06d3be2a6ce7f0cf0 by 59519056+bstephens82
Updates to tuner to print the improvement in the individual variables at the end of the tuner run, in addition to the total improvement.

See https://github.com/larson-group/clubb/issues/939#issuecomment-899811865.
The file was modified src/error.F90 (diff)
Commit 8901b7ce5a715ef407f741ef8d42eebd7cb5bdcb by 59519056+bstephens82
Changing the denominator in the variable-by-variable expression so that the individual terms add up to the total percent improvement.

See #939.
The file was modified src/error.F90 (diff)
Commit 1656d87e61d919b78bfa54fc2d30171d4a9b1601 by noreply
Updating the surface clipping coefficient...

...to avoid MC3E failure with PGI compiler.  I find all cases run successfully with this coefficient, with ifort, gfortran, and PGI.
The file was modified src/CLUBB_core/clip_explicit.F90 (diff)
Commit e8cfbf132e77e340988e90938742ec1912a371d1 by noreply
Adding blank line to note that my previous commit was BIT_CHANGING.

Also see #921 and #893 regarding the previous commit about the surface clipping coefficient.
The file was modified README (diff)
Commit 6074d7b38f6bd68b4344ab19c9e3ddf8de415e95 by Vince Larson
Change normalization of sensitivity matrix.
Before it was normalized by (default-observed) values of metrics.
Now it is normalized by 1/obs.  This leaves the sensitivity matrix
free from dependence on the bias and puts the bias entirely
on the right-hand side of the matrix equation.
Also, the parameter values are no longer normalized by max(def,sens)
values.  Instead, they are normalized by the values used
in the default simulation, and a sensitivity simulation value
is used only if the default-simulation value is zero.

Add plots of left-singular vectors and right-singular vectors.
Annotate these plots with singular values.

One of the unit tests, test_3x2_C8transformed, is broken.

For #910.
The file was modified utilities/sens_matrix/analyze_sensitivity_matrix.py (diff)
The file was modified utilities/sens_matrix/test_analyzeSensMatrix.py (diff)
The file was modified utilities/sens_matrix/sens_matrix_dashboard.py (diff)
Commit 728531ab73a7f769b1daea31a00fdb2afe821dd9 by 72510114+RhodesKeegan
Adding in l_vary_convect_depth as requested.
For ticket #905.
Results are confirmed to be BFB identical.
The file was modified src/G_unit_test_types/spurious_source_test.F90 (diff)
The file was modified src/clubb_tuner.F90 (diff)
The file was modified src/CLUBB_core/clubb_api_module.F90 (diff)
The file was modified input/tunable_parameters_e3sm/configurable_model_flags.in (diff)
The file was modified input/tunable_parameters/configurable_model_flags.in (diff)
The file was modified src/clubb_driver.F90 (diff)
The file was modified input/tunable_parameters_Lscale/configurable_model_flags.in (diff)
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
The file was modified src/CLUBB_core/model_flags.F90 (diff)
The file was modified src/CLUBB_core/sfc_varnce_module.F90 (diff)
The file was modified src/G_unit_test_types/pdf_parameter_tests.F90 (diff)
Commit 5e8c1c52ff7a270d8d89db7ed98e0ae35bb6203a by noreply
Removing blank line...

... to note a BIT_CHANGING:1656d87e61d919b78bfa54fc2d30171d4a9b1601 commit.
The file was modified README (diff)
Commit da8e9998a0502bb88a7c3d24bc87129045192038 by noreply
Removing a couple of unused parameters from use statement.

These are not caught by the gfortran compiler for whatever reason but the ifort compiler warned about them.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit 645764ff028a78e5856d60fd0efd81fe958b31b5 by rhodesk
Pushing k loop down through clip_variance_level.
This change is for the files advance_wp2_wp3_module and advance_xp2_xpyp_module.
In order to make this change, I added a new variable in the upper-level subroutine
that is an array version of the variable 'threshold' and passed it along to the lower subroutine.
The loop is still present in order to calculate the values of threshold, however, the calls
to the subroutine is outside of the loop. The only calculations inside the loop is for
and intrensic function, max.
All results are BFB identical for default case along with l_stats_samp being set to true.
For ticket #951.
The file was modified src/CLUBB_core/advance_wp2_wp3_module.F90 (diff)
The file was modified src/CLUBB_core/advance_xp2_xpyp_module.F90 (diff)
The file was modified src/CLUBB_core/clip_explicit.F90 (diff)
Commit 15b0b34248cb2472b5bfa40a709675aacfde434d by 59519056+bstephens82
Udpates to make it possible for us to keep certain parameters equal to each other during tuning.

Includes:

* a new subroutine in parameters_tunable.F90 that will read a new namelist in the error_*.in files
* updates to src/error.F90 to make sure the intended parameters are held equal throughout the tuning run
* updates to src.error.F90 to print the variables that were held equal at the end of the tuning run, together with their beginning and ending values, and updates to ensure that the new tuned values are copied into the new paramters_tunable_*.in file so they can be used for plotting or restarting the tuner.
* includes several simple error checks

See #939.
The file was modified input_misc/tuner/error_wangara.in (diff)
The file was modified input_misc/tuner/error_all.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_do.in (diff)
The file was modified input_misc/tuner/error_ticket_756.in (diff)
The file was modified input_misc/tuner/error_rico.in (diff)
The file was modified src/error.F90 (diff)
The file was modified input_misc/tuner/error_atex.in (diff)
The file was modified input_misc/tuner/error_bomex.in (diff)
The file was modified input_misc/tuner/error_arm_97.in (diff)
The file was modified input_misc/tuner/error_nov11_altocu.in (diff)
The file was modified input_misc/tuner/error_arm.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf01.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_ds.in (diff)
The file was modified input_misc/tuner/error_fire.in (diff)
The file was modified input_misc/tuner/error_gabls2.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_nd.in (diff)
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified input_misc/tuner/error_lba.in (diff)
The file was modified input_misc/tuner/error_gabls3_night.in (diff)
Commit 3fd43e54aeb0fe3ed07b3f2b3809384c26c6308f by 59519056+bstephens82
Updates to improve error checking for the tuner, updates to comments.

See #939.
The file was modified src/error.F90 (diff)
Commit 5d3968225001bcf65b88819bf5d44112dfd55520 by 59519056+bstephens82
Getting rid of a duplication of code.
The file was modified src/error.F90 (diff)
Commit f616391b15b456b19250596e2ba716f2e711ddef by 59519056+bstephens82
Updating name of l_vary_params_together flag to l_keep_params_equal, since this is probably more clear and also is more consistent with my comments in the code.
The file was modified input_misc/tuner/error_gabls3_night.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf01.in (diff)
The file was modified input_misc/tuner/error_atex.in (diff)
The file was modified src/error.F90 (diff)
The file was modified input_misc/tuner/error_all.in (diff)
The file was modified input_misc/tuner/error_arm.in (diff)
The file was modified input_misc/tuner/error_gabls2.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_nd.in (diff)
The file was modified input_misc/tuner/error_wangara.in (diff)
The file was modified input_misc/tuner/error_bomex.in (diff)
The file was modified input_misc/tuner/error_arm_97.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_ds.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_do.in (diff)
The file was modified input_misc/tuner/error_rico.in (diff)
The file was modified input_misc/tuner/error_ticket_756.in (diff)
The file was modified input_misc/tuner/error_lba.in (diff)
The file was modified input_misc/tuner/error_nov11_altocu.in (diff)
The file was modified input_misc/tuner/error_fire.in (diff)
Commit 7b4081bc1e9df47f4f74472a5f5fe8aa148fc752 by 59519056+bstephens82
Further tuner updates.  These updates introduce the option to give a minimum value for tuned parameters.  Error checks are included.

See #939.
The file was modified input_misc/tuner/error_all.in (diff)
The file was modified input_misc/tuner/error_bomex.in (diff)
The file was modified input_misc/tuner/error_arm_97.in (diff)
The file was modified input_misc/tuner/error_gabls3_night.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_ds.in (diff)
The file was modified input_misc/tuner/error_gabls2.in (diff)
The file was modified input_misc/tuner/error_atex.in (diff)
The file was modified input_misc/tuner/error_lba.in (diff)
The file was modified src/error.F90 (diff)
The file was modified input_misc/tuner/error_fire.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_do.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf02_nd.in (diff)
The file was modified input_misc/tuner/error_wangara.in (diff)
The file was modified input_misc/tuner/error_dycoms2_rf01.in (diff)
The file was modified input_misc/tuner/error_rico.in (diff)
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified input_misc/tuner/error_arm.in (diff)
The file was modified input_misc/tuner/error_ticket_756.in (diff)
The file was modified input_misc/tuner/error_nov11_altocu.in (diff)
The file was modified src/clubb_tuner.F90 (diff)
The file was modified src/error.F90 (diff)
Commit b26df4032b67b87fa59e706f469b3f6c72b586e9 by 59519056+bstephens82
Updating some comments related to the tuner updates.

See #939.
The file was modified input_misc/tuner/README (diff)
The file was modified src/CLUBB_core/parameters_tunable.F90 (diff)
The file was modified input_misc/tuner/README (diff)
Commit 6958fdf7eb63f23251745b86ce05fb0e631f6258 by 59519056+bstephens82
Minor updates requested in pull request: renaming a variable and adding some comments.

See #939.
The file was modified src/error.F90 (diff)
Commit b203a412c261873e1cc990dfc5f5317974bdb325 by Gunther Huebler
Adding space to trigger autoupdate. larson-group/sys_admin#755
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit a1a93a83b38823619297e58f525de33b4540fe56 by noreply
Remove space to trigger autoupdate. larson-group/sys_admin#755
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit ca98418450a8dcf207e130b945827370b7f5d23e by noreply
Add space to trigger nightly tests.  For larson-group/sys_admin#755.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)
Commit 0957eb945c7dcab580d70b5c642e53bfc3438c2f by rhodesk
Adding in helper scripts to replace variables as in ticket #886 and ticket #733.
The file was addedutilities/parse_argument_list/stats_script.py
The file was addedutilities/parse_argument_list/indent_enforcer.py
The file was addedutilities/parse_argument_list/gr_replacer.py
The file was addedutilities/parse_argument_list/stats_placer.py
The file was addedutilities/parse_argument_list/README
Commit 25b614d82d157bfd10dd704f2a70755f9ba7d2dc by noreply
Add a blurb on plotting CAM output to the pyplotgen README.
The file was modified postprocessing/pyplotgen/README.md (diff)
Commit 511bcf1812444716ac7f7c48788da4726238f4d5 by 59519056+bstephens82
Updates to pyplotgen to include LASSO cases.  Currently the WRF benchmark file path is not going to be generally valid.  We will probably want to add the WRF-LASSO benchmark files to the benchmark repo, but they will need some additional processing to get rid of large 3D variables that we don't need, or possibly add some additional variables that we want.

See https://github.com/larson-group/wrf/issues/104.
The file was modified postprocessing/pyplotgen/config/VariableGroupLiquidMP.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupBaseBudgets.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupSamProfiles.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupBase.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupSamBudgets.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupWs.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupNondimMoments.py (diff)
The file was modified postprocessing/pyplotgen/config/Style_definitions.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupBaseBudgetsSamStyle.py (diff)
The file was modified postprocessing/pyplotgen/src/VariableGroup.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupKKMP.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupSubcolumns.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupTaus.py (diff)
The file was modified postprocessing/pyplotgen/config/Case_definitions.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupIceMP.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupCorrelations.py (diff)
The file was modified postprocessing/pyplotgen/src/CaseGallerySetup.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupScalars.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupSamMultilineProfiles.py (diff)
Commit 381d439c61bde34082edac74c2a9310534cc5f82 by 59519056+bstephens82
Some updates to the paths for the WRF-LASSO benchmark files, and some minor updates so that a few more variables will show up from both the WRF-CLUBB runs and the WRF-LASSO benchmark runs.
The file was modified postprocessing/pyplotgen/config/Case_definitions.py (diff)
The file was modified postprocessing/pyplotgen/config/VariableGroupBase.py (diff)
Commit f6afdede0290f311294ea0492d07f56a1ca5364a by 59519056+bstephens82
Adding wpuiui to VariableGroupWs.py
The file was modified postprocessing/pyplotgen/config/VariableGroupWs.py (diff)
Commit 74d565b42d5bd3e11962eb26b59aa2bf76e7cb22 by bmg2
I am fixing a bug that was introduced in 6b0348e, where the logical
flow was distorted within the trapezoidal rule code.

This change does not affect standard CLUBB, where the trapezoidal
rule is not used by default. However, it is important for CAM-CLUBB.
The file was modified src/CLUBB_core/advance_clubb_core_module.F90 (diff)