Big column loop is now gone entirely. Replaced by fast small loops. larson-group/clubb#972 (details)
This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. (details)
Changing the value of C_invrs_tau_shear from 0.02 to 0.15. (details)
Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. (details)
Updated cam to reflect the changes in the clubb driver api (details)
Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that (details)
Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm (details)
Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 (details)
Making cam use the multicolumn interface for advance_clubb_core. Everything bit-for-bit. larson-group/clubb#972 (details)
Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 (details)
Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 (details)
Breaking up column loop in advance_clubb_core. larson-group/clubb#972 (details)
Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972 (details)
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence (details)
Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 (details)
Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 (details)
Rather than allocating pdf_params with pcols grid columns, we should use ncol. Which is what this commit does. We should do this same thing for all the other arrays too, but this change was required to move forward with our loop pushing. larson-group/clubb#972 (details)
Making a commit that officially places the call to the PDF in the "post" (details)
Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 (details)
We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 (details)
I am updating ice_supersat_frac to be an intent(inout) variable for (details)
Making compatible with latest clubb change. (details)
Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 (details)
Setting up ice_supersat_frac to be saved from one timestep to the next (details)
Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 (details)
Improving config flag setup process and adding run script using r8029 flag set. larson-group/clubb#984 (details)
Adding nightly test script for the r8029 flag version of the coarse res run. larson-group/clubb#972 (details)
Fixing scripts, I updated the wrong one. (details)
Pushing column index into zm2zt and zt2zm. larson-group/clubb#972 (details)
Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 (details)
A variety of small loop pushing. larson-group/clubb#972 (details)
Fixed small bug that slipped through because the G_unit tests use nz=1. (details)
Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 (details)
I added a subroutine that prints that values of all PDF parameters in (details)
Small changes and a loop push. larson-group/clubb#972 (details)
Pushing loop into advance_xm_wpxp. larson-group/clubb#972 (details)
Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 (details)
Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 (details)
Pushing column loop into local functions. larson-group/clubb#972 (details)
Adding in functionality for displaying log output into post step. (details)
Fixing whitespace issues with the jenkinsfile changes. (details)
when l_min_xp2_from_corr_wx = F and l_enable_relaxed_clipping = F. The goal is to allow the clubb_backwards_compatibility_gfortran_test Jenkins test to pass again.
Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm
This option calls subroutine smooth_heaviside_peskin, which implements the smooth Peskin Heaviside function. The option is turned off for now, and so the results should remain bit for bit.
Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence from going to the model top, which ultimately caused MC3E to crash by becoming too cold. Additionally, I set C_invrs_tau_shear back to 0.15 from 0.16. This commit is BIT_CHANGING.
Rather than allocating pdf_params with pcols grid columns, we should use ncol. Which is what this commit does. We should do this same thing for all the other arrays too, but this change was required to move forward with our loop pushing. larson-group/clubb#972
Making a commit that officially places the call to the PDF in the "post" position (meaning after CLUBB's predictive fields have been advanced). This commit is BIT_CHANGING
We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972
I am updating ice_supersat_frac to be an intent(inout) variable for advance_clubb_core. When the PDF is in the "post" position, there is a chance that it can be used before it is set unless it is preserved from timestep to timestep.
Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972