Skip to content
Failed

Changes

Summary

  1. New/new_hybrid PDF Stats Removal (#1185) (details)
  2. Copyout Nuke (#1182) (details)
  3. Jenkins GPU fix (#181) (details)
  4. Ri zm calc cleanup (#1186) (details)
  5. Adding stack size change to jenkins files, this might fix the bin_diff tests. (details)
  6. Monoflux test (#1188) (details)
  7. Fixing bug. This loop has a vertical dependency prevent the use of collapse(2). See https://github.com/larson-group/cam/issues/175\#issuecomment-2261283301 (details)
  8. refactoring to remove compiler warnings (#1187) (details)
  9. refactoring to remove compiler warnings (#1187) (details)
  10. remove unused dummy arguments (#182) (details)
  11. I am copying the round-off level changes made to grid weights (details)
  12. Mono Flux Optimizations  (#1189) (details)
Commit 2e1a3004aa91fe3acd8c455735afb9d715a7758e by noreply
New/new_hybrid PDF Stats Removal (#1185)

* Removing stats output only used for new and new_hybrid pdfs. See https://github.com/larson-group/clubb/issues/1176

* Removing stats from namelists
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified new_hybrid_pdf_main.F90 (diff)
The file was modified new_pdf_main.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
The file was modified stats_variables.F90 (diff)
The file was modified stats_zt_module.F90 (diff)
Commit 83e87d09f2a5cfa1775ca148dff92034932d2edc by noreply
Copyout Nuke (#1182)

* Resolving merge conflicts

* Renaming tmp variables

* More tmp name removals, slightly better copying logic.

* Removing a couple more unneeded data statements

* Adding needed copyouts around calls to GPU functions.

* More copyout removals

* Reverting possible bit-changing commit

* Fixing bug

* One more removal
The file was modified tridiag_lu_solver.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified grid_class.F90 (diff)
The file was modified T_in_K_module.F90 (diff)
The file was modified turbulent_adv_pdf.F90 (diff)
The file was modified mean_adv.F90 (diff)
The file was modified Skx_module.F90 (diff)
The file was modified diffusion.F90 (diff)
The file was modified penta_lu_solver.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
Commit 047ebbfcf32e597686453e21e51ec18f3dc256ae by noreply
Jenkins GPU fix (#181)

* Testing no batch_option to fix test

* Removing tmp removal for investigation.

* test

* Possible fix

* Returning the log file removal
The file was modified run_scripts/run_cesm_uwm_coarse_res_gpu_no_silhs.sh (diff)
The file was modified jenkins_tests/cam_gpu_test/Jenkinsfile (diff)
Commit 0e78da1cb43ae234acfb9a59b99e90d80cb5767e by noreply
Ri zm calc cleanup (#1186)

CLUBB ticket #1145

- Removed redundant smooth_max call on Ri_zm in diagnose_Lscale_from_tau
- Renamed Ri_zm to Ri_zm_Cx in compute_Cx_fnc_Richardson to distinguish it from the Ri_zm used to caluculate invrs_tau_wpxp_zm
The file was modified advance_helper_module.F90 (diff)
The file was modified mixing_length.F90 (diff)
Commit a9cbe307c5d265f0b893ea01a871c98fe19289a4 by Gunther Huebler
Adding stack size change to jenkins files, this might fix the bin_diff tests.
The file was modified jenkins_tests/cam_coarse_res_bin_diff_regression_gfortran_test/Jenkinsfile (diff)
The file was modified jenkins_tests/cam_coarse_res_r8029_flags_bin_diff_regression_gfortran_test/Jenkinsfile (diff)
Commit b66228d768a7cafb64c4c1af750b62c39208a310 by noreply
Monoflux test (#1188)

* Adding comments in code

* Adding test script

* Updating test script

* Adding jenkins file to run new test

* Adding descriptions, cleanup, and name change to indiciate this is a GPU test.

* Cleaup and adding references
The file was modified mono_flux_limiter.F90 (diff)
Commit 86ad303494c4dc2150a14bc92566f0550669cea5 by Gunther Huebler
Fixing bug. This loop has a vertical dependency prevent the use of collapse(2). See https://github.com/larson-group/cam/issues/175\#issuecomment-2261283301
The file was modified mono_flux_limiter.F90 (diff)
Commit e25a2a10f127157f8f597674d2b1a2478dc96a7c by noreply
refactoring to remove compiler warnings (#1187)

* refactor code to remove warnings for exceeding 100 characters per line

* remove unused variables

* remove unused parameters #1174

* fix for the GPU

* remove new unused parameters

* remove unused dummy arguments

* make small changes to reduce compiler warnings

* put solve_name back in as input variable to band_solve methods

* combine intent in and out parameters from calc_trapezoid_zm and calc_trapezoid_zt to intent inout parameters

* remove unused functions init_parameters_999 and sat_vapor_press_ice_*

* remove unused dummy arguments

* fix merge error

* remove unnecessary loop
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified parameters_tunable.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified saturation.F90 (diff)
The file was modified fill_holes.F90 (diff)
Commit ade7da06f81dbd0fc358fb9ca8e63a50b9538664 by noreply
refactoring to remove compiler warnings (#1187)

* refactor code to remove warnings for exceeding 100 characters per line

* remove unused variables

* remove unused parameters #1174

* fix for the GPU

* remove new unused parameters

* remove unused dummy arguments

* make small changes to reduce compiler warnings

* put solve_name back in as input variable to band_solve methods

* combine intent in and out parameters from calc_trapezoid_zm and calc_trapezoid_zt to intent inout parameters

* remove unused functions init_parameters_999 and sat_vapor_press_ice_*

* remove unused dummy arguments

* fix merge error

* remove unnecessary loop
The file was modified silhs_api_module.F90 (diff)
Commit 07ecf4a3bc8df6091e7820434d4ccc473e5dcb05 by noreply
remove unused dummy arguments (#182)

These CAM changes correspond to CLUBB changes larson-group/clubb#1174 and larson-group/clubb#1187.
The file was modified src/physics/cam/clubb_intr.F90 (diff)
The file was modified src/physics/cam/subcol_SILHS.F90 (diff)
Commit 919336b9bc062541373a38408c9db3bc104f92e0 by bmg2
I am copying the round-off level changes made to grid weights
and grid interpolation functions from the generalized_grid branch
over to the master branch. This is being done ahead of merging
code from the master over to the generalized_grid branch.

This code is necessary to get results in the generalized grid
branch bit-for-bit between ascending and descending grid
directions when optimization is set to -O0.

This change produces changes at the numerical round-off level
in the affected calculations, making this commit BIT_CHANGING.

Plots show lines overlap for almost all cases besides the most
sensitive cases (ARM 97, TWP ICE, etc. -- looking at those
shows you how much of a difference a simple numerical round-off
can make).
The file was modified grid_class.F90 (diff)
Commit 414ffbb09cdcd4ea2b175a5d8569e4a6efbd8007 by noreply
Mono Flux Optimizations  (#1189)

* Performance optimizations. This is BIT_CHANGING but not answer changing.

* Small bug fix

* Fix for uninitialized value in stats call and use of zero over 0.0_core_rknd

* Adding new variables to CPU data statements.

* Slight improvements to monoflux_test script.

* Making monoflux test script test with multiple columns

* Renaming and cleanup.
The file was modified mono_flux_limiter.F90 (diff)