Skip to content
Success

Changes

Summary

  1. Feeding gr through arg list for functions outside of CLUBB_core. (details)
  2. Feeding gr through arg list for functions outside of CLUBB_core. (details)
  3. Reflecting changes made to clubb_api_module's subroutine's argument lists. #886. (details)
  4. Defining gr at the top level main as a local variable and feeding it down as needed. (details)
  5. Adding grid_config file (details)
  6. Fixing certain instances of gr missing from clubb_sgs.F90. (details)
  7. Adding references to gr as needed (details)
  8. Adding references to gr where needed (details)
  9. Adding in preprocessor directives so that way sam compiles without clubb. (details)
  10. Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB. (details)
  11. Fixed make file being broke (details)
  12. The purpose of this commit is to check and see if the changes to sam's version of clubb is going to cause some sort of error when clubb's changes get merged into sam. Please ignore this commit unless something horrible happens tommorow morning in which case this commit is the reason why everything broke. (details)
  13. The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken. (details)
  14. Reverted changes to clubb files (details)
  15. Adding name specific functionality to prevent workspace removal and emails. larson-group/sys_admin#735 (details)
  16. Fixing syntax error preventing jenkins tests from running. larson-group/sys_admin#727 (details)
  17. Add error header for CLUBB in CAM (details)
  18. Adding some preprocessor directives (details)
  19. Fixing the ordering of gr in the arg list and dropping usage of grid_class. (details)
  20. Fixing the ordering of gr in the clubb_api arg list for affected subroutines. (details)
  21. Fixing coding standard violations (details)
  22. Changes that will make the WANGARA case run successfully in SAM-CLUBB and SAM-LES modes. (details)
  23. Adding comments to README and updating prm.les. (details)
  24. A few more updates to Wangara case: increasing top height to ~3200m, and removing a few lines from "lsf" file to be consistent with CLUBB (see commit https://github.com/larson-group/clubb/commit/381f3bdb88f44996263d03501401562e39717b25). (details)
Commit 126c61f5ee20ef2a88c9c01a19b94d0b4e54dc13 by rhodesk
Feeding gr through arg list for functions outside of CLUBB_core.
Gr has been removed as a moduler variable from clubb_api_module
and has been moved to clubb_driver as the top level moduler variable.
There is only one instance where a use clubb_driver gr statement is used
and that is within clubb_tuner.
Results are BFB identical.
For ticket #886.
The file was modified clubb_api_module.F90 (diff)
Commit feebefeb35da1d990f72fe4551982a80d01c86ab by rhodesk
Feeding gr through arg list for functions outside of CLUBB_core.
Gr has been removed as a moduler variable from clubb_api_module
and has been moved to clubb_driver as the top level moduler variable.
There is only one instance where a use clubb_driver gr statement is used
and that is within clubb_tuner.
Results are BFB identical.
For ticket #886.
The file was modified latin_hypercube_driver_module.F90 (diff)
The file was modified silhs_api_module.F90 (diff)
Commit cd913c4e9a5aee64f91e7db20c12bd69f63e1a9a by rhodesk
Reflecting changes made to clubb_api_module's subroutine's argument lists. #886.
The file was modified SRC/MICRO_M2005_UWM/microphysics.F90 (diff)
The file was modified SRC/SGS_CLUBB/stat_clubb.F90 (diff)
The file was modified SRC/micro_field_utils.F90 (diff)
The file was modified SRC/SGS_CLUBB/sgs.F90 (diff)
The file was modified SRC/SILHS/latin_hypercube_driver_module.F90 (diff)
The file was modified SRC/CLUBB/clubb_api_module.F90 (diff)
The file was modified SRC/SGS_CLUBB/clubb_sgs.F90 (diff)
The file was modified SRC/SILHS/silhs_api_module.F90 (diff)
Commit 184a06df2d3975fc22f9445e4085495429922e31 by rhodesk
Defining gr at the top level main as a local variable and feeding it down as needed.
Additionally, the file grid had to be changed to grid_config in order to avoid conflicts between the type grid in grid_class and the module named grid.
Sam compiles.
The file was modified SRC/task_util_MPI.f90 (diff)
The file was modified SRC/tracers.f90 (diff)
The file was modified Makefile (diff)
The file was modified SRC/ADV_UM5/advect_scalar3D.f90 (diff)
The file was modified SRC/SGS_TKE/diffuse_scalar.f90 (diff)
The file was modified SRC/task_assign_bnd.f90 (diff)
The file was modified SRC/MICRO_TEMPLATE/.microphysics.f90.template.swp (diff)
The file was modified SRC/hbuffer.F90 (diff)
The file was modified SRC/compute_chi_module.F90 (diff)
The file was modified SRC/micro_field_utils.F90 (diff)
The file was modified SRC/SIMULATORS/instrument_diagnostics.f90 (diff)
The file was modified SRC/compute_correlation_module.F90 (diff)
The file was modified SRC/SGS_CLUBB/diffuse_scalar3D_xy.f90 (diff)
The file was modified SRC/RAD_RRTM/cldefrint.f90 (diff)
The file was modified SRC/ADV_MPDATA/advect_scalar3D.f90 (diff)
The file was modified SRC/stat_covar_wv.F90 (diff)
The file was modified SRC/RAD_RRTM/rrtmg_sw_read_nc.f90 (diff)
The file was modified SRC/stat_covar_v2.F90 (diff)
The file was modified SRC/rad_simple_uwm.F90 (diff)
The file was modified SRC/SGS_TKE/sgs.F90 (diff)
The file was modified SRC/task_exchange.F90 (diff)
The file was modified SRC/SGS_CLUBB/diffuse_scalar_xy.f90 (diff)
The file was modified SRC/SGS_CLUBB/diffuse_scalar_z.f90 (diff)
The file was modified SRC/readiopdata_module.F90 (diff)
The file was modified SRC/radiation.F90 (diff)
The file was modified SRC/MICRO_DRIZZLE/cloud.F90 (diff)
The file was modified SRC/SGS_CLUBB/sgs.F90 (diff)
The file was modified SRC/ADV_UM5/advect_scalar2D.f90.old (diff)
The file was modified SRC/SGS_CLUBB/fluxes_scalar_z.f90 (diff)
The file was modified SRC/utils.f90 (diff)
The file was modified SRC/rad_simple.f90 (diff)
The file was modified SRC/ADV_MPDATA/advect_scalar.F90 (diff)
The file was modified SRC/setdata.F90 (diff)
The file was modified SRC/SGS_CLUBB/diffuse_scalar.f90 (diff)
The file was modified SRC/SGS_TEMPLATE/sgs.f90 (diff)
The file was modified SRC/ADV_MPDATA/advect_scalar2D.f90 (diff)
The file was modified SRC/ADV_UM5/advect_scalar3D.f90.old (diff)
The file was modified SRC/SGS_CLUBB/diffuse_scalar2D_xy.f90 (diff)
The file was modified SRC/MICRO_M2005/microphysics.f90 (diff)
The file was modified SRC/ADV_UM5/advect_um_lib.f90.old (diff)
The file was modified SRC/RAD_CAM/traceini.f90 (diff)
The file was modified SRC/RAD_DUMMY/rad.f90 (diff)
The file was modified SRC/ADV_UM5/advect_scalar2D.f90 (diff)
The file was modified SRC/simple_ocean.f90 (diff)
The file was modified SRC/MICRO_2MOM/micro_params.f90 (diff)
The file was modified SRC/task_init.f90 (diff)
The file was modified SRC/RAD_RRTM/rad.f90 (diff)
The file was modified SRC/SGS_CLUBB/clubbvars.F90 (diff)
The file was modified SRC/MICRO_SAM1MOM/microphysics.f90.RCEOBS (diff)
The file was modified SRC/MICRO_2MOM/microphysics.F90 (diff)
The file was modified SRC/MICRO_SAM1MOM/micro_params.f90.RCEOBS (diff)
The file was modified SRC/SGS_TKE/diffuse_scalar3D.f90 (diff)
The file was modified SRC/MICRO_M2005/module_mp_graupel.f90 (diff)
The file was modified SRC/abcoefs.f90 (diff)
The file was modified SRC/SGS_CLUBB/diffuse_scalar2D_z.f90 (diff)
The file was modified SRC/SGS_CLUBB/stat_clubb.F90 (diff)
The file was modified SRC/header.F90 (diff)
The file was modified SRC/RAD_CAM/rad_full.f90 (diff)
The file was modified SRC/RAD_CAM/rad.f90 (diff)
The file was modified SRC/SGS_CLUBB/diffuse_scalar3D_z.f90 (diff)
The file was modified SRC/movies.f90 (diff)
The file was modified SRC/SGS_CLUBB/diffuse_scalar3D.f90 (diff)
The file was modified SRC/compress3D.F90 (diff)
The file was modified SRC/RAD_RRTM/rrtmg_lw_read_nc.f90 (diff)
The file was modified SRC/stat_covar_u2.F90 (diff)
The file was modified SRC/SGS_CLUBB/clubb_sgs.F90 (diff)
The file was modified SRC/stepout.F90 (diff)
The file was modified SRC/ADV_UM5/advect_scalar.F90 (diff)
The file was modified SRC/MICRO_SAM1MOM/microphysics.F90 (diff)
The file was modified SRC/MICRO_DRIZZLE/micro_params.F90 (diff)
The file was modified SRC/RAD_CAM/ppgrid.f90 (diff)
The file was modified SRC/stat_covar_w2w3.F90 (diff)
The file was modified SRC/main.F90 (diff)
The file was modified SRC/boundaries.f90 (diff)
The file was modified SRC/params.F90 (diff)
The file was modified SRC/stat_covar_sw.F90 (diff)
The file was modified SRC/ADV_UM5/advect_um_lib.f90 (diff)
The file was modified SRC/SGS_CLUBB/diffuse_scalar2D.f90 (diff)
The file was removedSRC/grid.F90
The file was modified SRC/SGS_CLUBB/clubb_silhs_vars.F90 (diff)
The file was modified SRC/SGS_TKE/diffuse_scalar2D.f90 (diff)
The file was modified SRC/pressure.f90 (diff)
The file was modified SRC/surface.rico (diff)
The file was modified SRC/task_ranks.f90 (diff)
The file was modified SRC/bound_exchange.f90 (diff)
The file was modified SRC/RAD_CAM/cldefrint.f90 (diff)
The file was modified SRC/MICRO_DRIZZLE/microphysics.F90 (diff)
The file was modified SRC/stat_covar_wu.F90 (diff)
The file was modified SRC/vars.F90 (diff)
The file was modified SRC/MICRO_SAM1MOM/micro_params.f90 (diff)
The file was modified SRC/MICRO_M2005_UWM/microphysics.F90 (diff)
The file was modified SRC/MICRO_TEMPLATE/microphysics.f90.template (diff)
The file was modified SRC/stat_varscalar.f90 (diff)
Commit 55da14242748277ceac32924fd96a15eb36c1783 by rhodesk
Adding grid_config file
The file was addedSRC/grid_config.F90
Commit a9460b01e20f9efc56acb4e59479d6e6c0bb2697 by rhodesk
Fixing certain instances of gr missing from clubb_sgs.F90.
The file was modified SRC/SGS_CLUBB/clubb_sgs.F90 (diff)
Commit 2f36fb2662c574940365d42d1b86acffec74871e by rhodesk
Adding references to gr as needed
The file was modified SRC/micro_field_utils.F90 (diff)
The file was modified SRC/main.F90 (diff)
Commit 3697ff299604031d4d41f63be800361f2ca082ef by rhodesk
Adding references to gr where needed
The file was modified SRC/main.F90 (diff)
Commit 1344f8a40d6116af1b567307eb389b4be1009fc4 by rhodesk
Adding in preprocessor directives so that way sam compiles without clubb.
Jenkins tests pass.
Additionally, I renamed setdata and stepout so that way we can use them as modules because they previously only contained subroutines.
The file was modified SRC/domain.F90 (diff)
The file was modified SRC/main.F90 (diff)
The file was addedSRC/setdata_module.F90
The file was removedSRC/setdata.F90
The file was removedSRC/stepout.F90
The file was addedSRC/stepout_module.F90
Commit 0a8871adff75bef8493e1d3203fa55ee544fe2f1 by rhodesk
Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified grid_class.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
Commit fcb64a792d6631be39938f67e613ded134dd5dca by rhodesk
Fixed make file being broke
The file was modified Makefile (diff)
Commit af910f5b561ff781d5da6603b065649e6da63741 by rhodesk
The purpose of this commit is to check and see if the changes to sam's version of clubb is going to cause some sort of error when clubb's changes get merged into sam. Please ignore this commit unless something horrible happens tommorow morning in which case this commit is the reason why everything broke.
The file was modified SRC/CLUBB/clubb_api_module.F90 (diff)
Commit e9efb9d45177992fd2880928cd3a10114d65fabb by rhodesk
The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken.
The file was modified clubb_api_module.F90 (diff)
Commit c5c01fc5da140dc13df06c2919c4f4f5a0318b5f by rhodesk
Reverted changes to clubb files
The file was modified SRC/SILHS/latin_hypercube_driver_module.F90 (diff)
The file was modified SRC/SILHS/silhs_api_module.F90 (diff)
The file was modified SRC/CLUBB/clubb_api_module.F90 (diff)
Commit 74f8b9acaaaecdc05763bb35929a066cc551a044 by pbroels
Adding name specific functionality to prevent workspace removal and emails. larson-group/sys_admin#735
The file was modified jenkins_tests/micro_drizzle_test/Jenkinsfile (diff)
The file was modified jenkins_tests/sam_clubb_silhs_build/Jenkinsfile (diff)
The file was modified jenkins_tests/sam_clubb_build/Jenkinsfile (diff)
Commit 20c75ae6657d50abbd04f3f76ffd2f8c04429e13 by pbroels
Fixing syntax error preventing jenkins tests from running. larson-group/sys_admin#727
The file was modified jenkins_tests/sam_clubb_build/Jenkinsfile (diff)
The file was modified jenkins_tests/micro_drizzle_test/Jenkinsfile (diff)
The file was modified jenkins_tests/sam_clubb_silhs_build/Jenkinsfile (diff)
Commit e4722a17a28eb6a7b0f1025e88ad574c8fa6ef92 by noreply
Add error header for CLUBB in CAM
The file was modified error_code.F90 (diff)
Commit 6d8d76ccdd578ce9b1a51c12d58d3dc98fec23b8 by noreply
Adding some preprocessor directives

to get SAM-LES to compile successfully when using MICRO_M2005_UWM instead of MICRO_DRIZZLE.
The file was modified SRC/MICRO_M2005_UWM/microphysics.F90 (diff)
Commit 96f90d5be4cd58321c9dfb60bc92b2b224d4391d by rhodesk
Fixing the ordering of gr in the arg list and dropping usage of grid_class.
The file was modified SRC/main.F90 (diff)
The file was modified SRC/SGS_CLUBB/sgs.F90 (diff)
The file was modified SRC/stepout_module.F90 (diff)
The file was modified SRC/micro_field_utils.F90 (diff)
The file was modified SRC/SGS_CLUBB/clubb_sgs.F90 (diff)
The file was modified SRC/setdata_module.F90 (diff)
The file was modified SRC/MICRO_M2005_UWM/microphysics.F90 (diff)
The file was modified SRC/SGS_CLUBB/stat_clubb.F90 (diff)
Commit b147496942c7b06cb6d5535baadd0cb8d803b886 by rhodesk
Fixing the ordering of gr in the clubb_api arg list for affected subroutines.
Additionally, this commit removes the clubb code standard violation of exceeding more the 100 characters per line.
Lastly, the grid typing is being added to clubb_api_module as a public variable so that the host models have access to the type without having to bypass the api
For ticket #886.
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified diffusion.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
The file was modified advance_windm_edsclrm_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified mixing_length.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 989d81e9eee0bd81d684f7f243ef76602a7d38bd by rhodesk
Fixing coding standard violations
The file was modified mixing_length.F90 (diff)
The file was modified advance_windm_edsclrm_module.F90 (diff)
Commit 62b3702f91c3772f7133b7bec971d6b875b8e45f by 59519056+bstephens82
Changes that will make the WANGARA case run successfully in SAM-CLUBB and SAM-LES modes.
The file was modified WANGARA/prm (diff)
The file was modified WANGARA/snd (diff)
The file was addedWANGARA/prm.les
The file was modified WANGARA/sfc (diff)
The file was addedWANGARA/domain.f90.les
The file was modified SCRIPTS/LES_setup/setup_LES_KK_micro.bash (diff)
The file was addedWANGARA/README
Commit d39c8b39d2e9296b0facdd22d395f138e72ce64f by 59519056+bstephens82
Adding comments to README and updating prm.les.
The file was modified WANGARA/README (diff)
The file was modified WANGARA/prm.les (diff)
Commit 3655285cd4ce9d65cec1b44cf2e6e578f4d08fe7 by 59519056+bstephens82
A few more updates to Wangara case: increasing top height to ~3200m, and removing a few lines from "lsf" file to be consistent with CLUBB (see commit https://github.com/larson-group/clubb/commit/381f3bdb88f44996263d03501401562e39717b25).

See #138.
The file was modified WANGARA/domain.f90.les (diff)
The file was modified WANGARA/prm.les (diff)
The file was modified WANGARA/lsf (diff)