Skip to content
Success

Changes

Summary

  1. Fixing typo in stats_zm_module.F90.  Background:  Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases.  It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit.  This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced.  However, since the budget balance test still found the variable, it kept passing successfully.  This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format. (details)
  2. Fixing a typo from an earlier commit. (details)
Commit f3acc6329ec1f2ec3085b8429539e9fe4fe2dd8d by benjamin.andrew.stephens
Fixing typo in stats_zm_module.F90.  Background:  Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases.  It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit.  This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced.  However, since the budget balance test still found the variable, it kept passing successfully.  This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format.

This is BIT_CHANGING since it will affect the name of the upwp_tp variable in the X_zm.nc netcdf file, but it will not change results.
The file was modified stats_zm_module.F90 (diff)
Commit 12611fa39ab6962bb81a2b6b85ffa1b2b02515b8 by noreply
Fixing a typo from an earlier commit.

See comments in this other commit where a similar typo was fixed: https://github.com/larson-group/clubb/commit/a4f5f736cb16168f40fdc01e454930ffa05fbb4d.
The file was modified stats_sfc_module.F90 (diff)