Skip to content
Failed

Changes

Summary

  1. I have passed clubb_params down into advance_xm_wpxp_module.F90. (details)
  2. I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. (details)
  3. I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 (details)
  4. Passing down more of CLUBB's tunable parameters. (details)
  5. I accidentally removed an important comment in the previous commit. (details)
  6. Passing down more CLUBB tunable parameters. (details)
  7. More passing down CLUBB parameters ... whoop-de-doo (details)
  8. Passing down more tunable parameters and removing references to (details)
  9. Handling the abomination that is lmin. (details)
  10. Passing tunable parameters into the new tau code. (details)
  11. Passed down more parameters. Results are bit-for-bit. (details)
  12. Passing through more clubb parameters. Bit-for-bit (details)
  13. Passing down CLUBB's tunable parameters into the setup_pdf_parameters and (details)
  14. Passing down CLUBB's tunable parameters into the remainder of the (details)
  15. I passed down the forgotten thlp2_rad_coef tunable parameter. (details)
  16. I am passing down the forgotten parameter, altitude threshold, in (details)
  17. I am committing the final stage of the "pass-down params" project. (details)
  18. I am committing the final stage of the "pass-down params" project. (details)
  19. Adding an option to use invrs_tau_N2_iso for C4 terms.  The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233).  The flag is currently set to false so results will be b4b. (details)
  20. Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion.  This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. (details)
  21. Adding comments for clarity. (details)
Commit ecf50b7dd71b99418e7b378199bec3f540f9ab8f by bmg2
I have passed clubb_params down into advance_xm_wpxp_module.F90.

The results from this revision are an exact match to the results from
the previous revision for all cases.
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
Commit b33af07b27883cd48fed63d9fa1557d3b2d4464d by bmg2
I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.

The results in NetCDF output files from this revision are an exact match to the
results in NetCDF output files from the previous revision for all cases.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified advance_wp2_wp3_module.F90 (diff)
Commit 724a970d8e0b0977d63512e25c4462d260039290 by bmg2
I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90
for most parameters, excluding C4 and C14. Results are unchanged.
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 9ac836f8b76e39e820b5fecaae969f70a7b39c21 by bmg2
Passing down more of CLUBB's tunable parameters.
The file was modified pdf_closure_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
Commit 7b950575ac2c00c63de42c11f33c459e649af028 by bmg2
I accidentally removed an important comment in the previous commit.
The file was modified advance_clubb_core_module.F90 (diff)
Commit 835d3d3155f98b2a9b6ba60cb9fa02a94fb7800b by bmg2
Passing down more CLUBB tunable parameters.

Everything is bit-for-bit.
The file was modified advance_xm_wpxp_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified advance_helper_module.F90 (diff)
Commit b65e4cfa8ab2923db015ef2723e3e69071d2c83c by bmg2
More passing down CLUBB parameters ... whoop-de-doo
The file was modified adg1_adg2_3d_luhar_pdf.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
Commit 351cc9aa27aa212ef6cefb48b6c85ec601a993b0 by bmg2
Passing down more tunable parameters and removing references to
parameters_tunable. Results are bit-for-bit.
The file was modified sfc_varnce_module.F90 (diff)
The file was modified Skx_module.F90 (diff)
The file was modified diagnose_correlations_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 40e87490f501202d6d95e7fd2c9c2ccab164ab73 by bmg2
Handling the abomination that is lmin.
The file was modified parameters_tunable.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified mixing_length.F90 (diff)
Commit c8cadb5e9708e898ac688db79e1da0ec0ff2ad29 by bmg2
Passing tunable parameters into the new tau code.
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified mixing_length.F90 (diff)
Commit e6aa931ab2aa8134704c137db183ec06ee9dfcee by bmg2
Passed down more parameters. Results are bit-for-bit.
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified clip_explicit.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified mixing_length.F90 (diff)
Commit d07f2f6c2df3af24ddc90862bc2a656bdd9015d5 by bmg2
Passing through more clubb parameters. Bit-for-bit
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified parameters_model.F90 (diff)
Commit 704eedf20b71e552fe32df3633005d50af58c27f by bmg2
Passing down CLUBB's tunable parameters into the setup_pdf_parameters and
precipitation fraction portions of the code. Everything is bit-for-bit.
The file was modified clubb_api_module.F90 (diff)
The file was modified precipitation_fraction.F90 (diff)
The file was modified setup_clubb_pdf_params.F90 (diff)
Commit 62d364561a81e2b878f95a327df36a4ca4bc3149 by bmg2
Passing down CLUBB's tunable parameters into the remainder of the
PDF subroutines. Everything is bit-for-bit.
The file was modified new_hybrid_pdf_main.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified pdf_closure_module.F90 (diff)
The file was modified new_pdf_main.F90 (diff)
Commit 40315247ab8dc38382642bf30f1d96b329c1304d by bmg2
I passed down the forgotten thlp2_rad_coef tunable parameter.
All bit-for-bit.
The file was modified clubb_api_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
Commit 24592ec9879d2c704c4d7301c8d18c794f2ff744 by bmg2
I am passing down the forgotten parameter, altitude threshold, in
advance_xm_wpxp_module.F90.
The file was modified advance_xm_wpxp_module.F90 (diff)
Commit 48d34a44dac4e6c069b8edf7484da102a7b3e03c by bmg2
I am committing the final stage of the "pass-down params" project.
The results are bit-for-bit identical.
The file was modified output_netcdf.F90 (diff)
The file was modified clubb_api_module.F90 (diff)
The file was modified parameters_tunable.F90 (diff)
The file was modified stats_clubb_utilities.F90 (diff)
Commit a59d8a9d971fa58d96ca0c7c0e3a899990339401 by bmg2
I am committing the final stage of the "pass-down params" project.
The results are bit-for-bit identical.
The file was modified silhs_api_module.F90 (diff)
The file was modified output_2D_samples_module.F90 (diff)
The file was modified latin_hypercube_driver_module.F90 (diff)
Commit e21f33631a9962fc7af096d0f7c4a7a3f6ff021b by 59519056+bstephens82
Adding an option to use invrs_tau_N2_iso for C4 terms.  The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233).  The flag is currently set to false so results will be b4b.

See also the discussion here: https://github.com/larson-group/clubb/issues/920#issuecomment-920338746 and following comments.
The file was modified advance_wp2_wp3_module.F90 (diff)
The file was modified advance_xp2_xpyp_module.F90 (diff)
The file was modified advance_clubb_core_module.F90 (diff)
The file was modified mixing_length.F90 (diff)
Commit 575d6fe14ed80295cce4f30a51ff3d6aac83b5ee by 59519056+bstephens82
Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion.  This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.
The file was modified advance_wp2_wp3_module.F90 (diff)
Commit b1a5dc605454ba0bd6ce90b50c1b1c4e5238daa2 by 59519056+bstephens82
Adding comments for clarity.
The file was modified mixing_length.F90 (diff)